Changeset 5777 in vbox for trunk/src/VBox

Timestamp:

Nov 16, 2007 5:18:13 PM (17 years ago)

Author:

vboxsync

Message:

Main: Fixed a dedalock (Machine::AttachHardDisk() calledl VirtualBox with locking which violated the lock order (parents->self->children) and caused a deadlock when VirtualBox tried to lock Machine in clientWatcherThread()).

File:

• trunk/src/VBox/Main/MachineImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -1600 +1600 @@
     CheckComRCReturnRC (autoCaller.rc());
 
-    AutoLock alock (this);
+    /* VirtualBox::getHardDisk() need read lock */
+    AutoMultiLock <2> alock (mParent->rlock(), this->wlock());
 
     HRESULT rc = checkStateDependency (MutableStateDep);