Changeset 57801 in vbox for trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm

Timestamp:

Sep 17, 2015 9:50:12 AM (9 years ago)

Author:

vboxsync

Message:

Devices/VGA,Additions/WDDM: Fix hardware accelerated video playback with the WDDM driver when VWHA interface is used (fixes VLC video playback)

File:

• trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPVhwa.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPVhwa.cpp

@@ -538 +538 @@
     memset(pInfo, 0, sizeof(VBOXVHWA_SURFACEDESC));
 
+#if 0
+    /**
+     * The following breaks 2D accelerated video playback because this method is called just after the surface was created
+     * and most its members are still 0.
+     *
+     * @todo: Not 100% sure this is the correct way. It looks like the SegmentId specifies where the  memory
+     *        for the surface is stored (VRAM vs. system memory) but because this method is only used
+     *        to query some parameters (using VBOXVHWACMD_SURF_GETINFO) and this command doesn't access any surface memory
+     *        on the host it should be safe.
+     */
     if (pSurf->AllocData.Addr.SegmentId != 1)
     {
@@ -543 +553 @@
         return VERR_INVALID_PARAMETER;
     }
+#endif
 
     pInfo->height = pSurf->AllocData.SurfDesc.height;