Changeset 57897 in vbox

Timestamp:

Sep 25, 2015 2:24:50 PM (9 years ago)

Author:

vboxsync

Message:

FE/Qt: Mac OS X: Window menu Manager cleanup/rework (step 7): Prepare/cleanup adjustment.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• medium/UIMediumManager.cpp (modified) (5 diffs)
• medium/UIMediumManager.h (modified) (2 diffs)
• platform/darwin/UIWindowMenuManager.cpp (modified) (1 diff)
• platform/darwin/UIWindowMenuManager.h (modified) (2 diffs)
• selector/UISelectorWindow.cpp (modified) (4 diffs)
• selector/UISelectorWindow.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.cpp

@@ -956 +956 @@
     retranslateUi();
 
-#ifdef Q_WS_MAC
-    /* Prepare Mac window-menu.
-     * Should go *after* translation! */
-    prepareMacWindowMenu();
-#endif /* Q_WS_MAC */
-
     /* Center according pseudo-parent widget: */
     VBoxGlobal::centerWidget(this, m_pPseudoParentWidget, false);
@@ -1081 +1075 @@
 void UIMediumManager::prepareMenuBar()
 {
-    /* Create menu-bar-menu: */
+    /* Create 'Actions' menu: */
     m_pMenu = menuBar()->addMenu(QString());
     AssertPtrReturnVoid(m_pMenu);
     {
-        /* Configure menu-bar-menu: */
+        /* Configure 'Actions' menu: */
         m_pMenu->addAction(m_pActionCopy);
         m_pMenu->addAction(m_pActionModify);
@@ -1092 +1086 @@
         m_pMenu->addAction(m_pActionRefresh);
     }
+
+#ifdef Q_WS_MAC
+    /* Prepare 'Window' menu: */
+    AssertPtrReturnVoid(gpWindowMenuManager);
+    menuBar()->addMenu(gpWindowMenuManager->createMenu(this));
+    gpWindowMenuManager->addWindow(this);
+#endif /* Q_WS_MAC */
 }
 
@@ -1329 +1330 @@
 }
 
-#ifdef Q_WS_MAC
-void UIMediumManager::prepareMacWindowMenu()
-{
-    /* Create window-menu for menu-bar: */
-    menuBar()->addMenu(UIWindowMenuManager::instance()->createMenu(this));
-    UIWindowMenuManager::instance()->addWindow(this);
-}
-#endif /* Q_WS_MAC */
-
 void UIMediumManager::repopulateTreeWidgets()
 {
@@ -1709 +1701 @@
 }
 
+void UIMediumManager::cleanupMenuBar()
+{
 #ifdef Q_WS_MAC
-void UIMediumManager::cleanupMacWindowMenu()
-{
-    /* Destroy window-menu of menu-bar: */
-    UIWindowMenuManager::instance()->removeWindow(this);
-    UIWindowMenuManager::instance()->destroyMenu(this);
-}
+    /* Cleanup 'Window' menu: */
+    AssertPtrReturnVoid(gpWindowMenuManager);
+    gpWindowMenuManager->removeWindow(this);
+    gpWindowMenuManager->destroyMenu(this);
 #endif /* Q_WS_MAC */
+}
 
 void UIMediumManager::cleanup()
 {
-#ifdef Q_WS_MAC
-    /* Cleanup Mac window-menu: */
-    cleanupMacWindowMenu();
-#endif /* Q_WS_MAC */
+    /* Cleanup menu-bar: */
+    cleanupMenuBar();
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.h

@@ -134 +134 @@
     /** Prepare progress-bar. */
     void prepareProgressBar();
-#ifdef Q_WS_MAC
-    /** Mac OS X: Prepare <i>Window</i> menu. */
-    void prepareMacWindowMenu();
-#endif /* Q_WS_MAC */
 
     /** Repopulates tree-widgets content. */
@@ -164 +160 @@
     void updateInformationFieldsFD();
 
-#ifdef Q_WS_MAC
-    /** Mac OS X: Cleanup <i>Window</i> menu. */
-    void cleanupMacWindowMenu();
-#endif /* Q_WS_MAC */
+    /** Cleanup menu-bar. */
+    void cleanupMenuBar();
     /** General cleanup wrapper. */
     void cleanup();

trunk/src/VBox/Frontends/VirtualBox/src/platform/darwin/UIWindowMenuManager.cpp

@@ -196 +196 @@
 
 /* static */
-UIWindowMenuManager* UIWindowMenuManager::instance()
-{
-    /* Make sure 'Window' menu Manager is created: */
-    if (!m_spInstance)
-        m_spInstance = new UIWindowMenuManager;
-
-    /* Return 'Window' menu Manager: */
-    return m_spInstance;
+void UIWindowMenuManager::create()
+{
+    /* Make sure 'Window' menu Manager is not created: */
+    AssertReturnVoid(!m_spInstance);
+
+    /* Create 'Window' menu Manager: */
+    new UIWindowMenuManager;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/platform/darwin/UIWindowMenuManager.h

@@ -38 +38 @@
 public:
 
-    /** Static constructor and instance provider. */
-    static UIWindowMenuManager* instance();
+    /** Static constructor. */
+    static void create();
     /** Static destructor. */
     static void destroy();
+    /** Static instance provider. */
+    static UIWindowMenuManager* instance() { return m_spInstance; }
 
     /** Creates 'Window' menu for passed @a pWindow. */
@@ -78 +80 @@
 };
 
+#define gpWindowMenuManager UIWindowMenuManager::instance()
+
 #endif /* !___UIWindowMenuManager_h___ */
 

trunk/src/VBox/Frontends/VirtualBox/src/selector/UISelectorWindow.cpp

@@ -1155 +1155 @@
 # endif /* MAC_LEOPARD_STYLE */
 
-    UIWindowMenuManager::instance()->addWindow(this);
     /* Beta label? */
     if (vboxGlobal().isBeta())
@@ -1212 +1211 @@
 
 #ifdef Q_WS_MAC
-    menuBar()->addMenu(UIWindowMenuManager::instance()->createMenu(this));
+    /* Prepare 'Window' menu: */
+    UIWindowMenuManager::create();
+    menuBar()->addMenu(gpWindowMenuManager->createMenu(this));
+    gpWindowMenuManager->addWindow(this);
 #endif /* Q_WS_MAC */
 
@@ -1707 +1709 @@
 void UISelectorWindow::cleanupMenuBar()
 {
+#ifdef Q_WS_MAC
+    /* Cleanup 'Window' menu: */
+    UIWindowMenuManager::destroy();
+#endif /* Q_WS_MAC */
+
     /* Destroy action-pool: */
     UIActionPool::destroy(m_pActionPool);
@@ -1715 +1722 @@
     /* Destroy event handlers: */
     UIVirtualBoxEventHandler::destroy();
-
-#ifdef Q_WS_MAC
-    UIWindowMenuManager::destroy();
-#endif /* Q_WS_MAC */
 
     /* Save settings: */

trunk/src/VBox/Frontends/VirtualBox/src/selector/UISelectorWindow.h

@@ -52 +52 @@
     /** Static destructor. */
     static void destroy();
-    /** Static instance. */
+    /** Static instance provider. */
     static UISelectorWindow* instance() { return m_spInstance; }
 
@@ -60 +60 @@
 protected:
 
-    /** Constructs selector-window.
-      * @param ppSelf brings the pointer to pointer to this window instance used by the external caller.
-      * @param flags  brings the selector-window flags dialogs should have. */
+    /** Constructs selector-window. */
     UISelectorWindow();
     /** Destructs selector-window. */
@@ -259 +257 @@
     /** @} */
 
-    /** Static instance. */
+    /** Holds the static instance. */
     static UISelectorWindow *m_spInstance;