Changeset 58436 in vbox for trunk/src/VBox/VMM/VMMR3

Timestamp:

Oct 27, 2015 4:16:02 PM (9 years ago)

Author:

vboxsync

Message:

VMM/GIM: Comments.

Location:

trunk/src/VBox/VMM/VMMR3

Files:

• GIM.cpp (modified) (1 diff)
• GIMHv.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR3/GIM.cpp

@@ -116 +116 @@
      * Validate the GIM settings.
      */
-    rc = CFGMR3ValidateConfig(pCfgNode, "/GIM/",
-                              "Provider"   /* pszValidValues */
+    rc = CFGMR3ValidateConfig(pCfgNode, "/GIM/", /* pszNode */
+                              "Provider"         /* pszValidValues */
                               "|Version",
-                              "HyperV"     /* pszValidNodes */,
-                              "GIM"        /* pszWho */,
-                              0            /* uInstance */);
+                              "HyperV",          /* pszValidNodes */
+                              "GIM",             /* pszWho */
+                              0);                /* uInstance */
     if (RT_FAILURE(rc))
         return rc;

trunk/src/VBox/VMM/VMMR3/GIMHv.cpp

@@ -279 +279 @@
 
         /* Expose more if we're posing as Microsoft. We can, if needed, force MSR-based Hv
-           debugging by not exposing these bits while exposing the VS interface.*/
+           debugging by not exposing these bits while exposing the VS interface. The better
+           way is what we do currently, via the GIM_HV_DEBUG_OPTIONS_USE_HYPERCALLS bit. */
         if (pHv->fIsVendorMsHv)
         {