Changeset 58466 for trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library – Oracle VirtualBox

trunk/src/VBox/Devices/EFI/Firmware

Property svn:mergeinfo changed
/vendor/edk2/current merged: 103769-103776

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseCacheMaintenanceLib/ArmCache.c

-              r48674
+              r58466
 /** @file
   Cache Maintenance Functions. These functions vary by ARM architecture so the MdePkg
   versions are null functions used to make sure things will compile.
+  Cache Maintenance Functions. These functions vary by ARM architecture so the MdePkg
+  versions are null functions used to make sure things will compile.
   Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf

r58459	r58466
25	25	MODULE_TYPE = BASE
26	26	VERSION_STRING = 1.0
27		LIBRARY_CLASS = CacheMaintenanceLib
	27	LIBRARY_CLASS = CacheMaintenanceLib
28	28
29	29

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseCacheMaintenanceLib/IpfCache.c

r48674	r58466
195	195	{
196	196	//
197		// Invalidation of the entire data cache without writing back is not supported
	197	// Invalidation of the entire data cache without writing back is not supported
198	198	// on IPF architecture, so a write back and invalidate operation is performed.
199	199	//

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseCacheMaintenanceLib/X86Cache.c

r58459	r58466
141	141	//
142	142	// Calculate the cache line alignment
143		//
	143	//
144	144	End = (Start + Length + (CACHE_LINE_SIZE - 1)) & ~(CACHE_LINE_SIZE - 1);
145	145	Start &= ~((UINTN) CACHE_LINE_SIZE - 1);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseCpuLib/Arm/CpuFlushTlb.S

r48674	r58466
1		#------------------------------------------------------------------------------
	1	#------------------------------------------------------------------------------
2	2	#
3	3	# CpuFlushTlb() for ARM

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseCpuLib/Arm/CpuFlushTlb.asm

-              r48674
+              r58466
 ;------------------------------------------------------------------------------
+;------------------------------------------------------------------------------
+;
 ; CpuFlushTlb() for ARM
 …
 ;  );
+;
 CpuFlushTlb
+CpuFlushTlb
     MOV r0,#0
     MCR p15,0,r0,c8,c5,0        ;Invalidate all the unlocked entried in TLB

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseCpuLib/Arm/CpuSleep.S

r48674	r58466
1		#------------------------------------------------------------------------------
	1	#------------------------------------------------------------------------------
2	2	#
3	3	# CpuSleep() for ARMv7

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseCpuLib/Arm/CpuSleep.asm

r48674	r58466
1		;------------------------------------------------------------------------------
	1	;------------------------------------------------------------------------------
2	2	;
3	3	; CpuSleep() for ARMv7

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseCpuLib/BaseCpuLib.inf

-              r58459
+              r58466
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = CpuLib
+  LIBRARY_CLASS                  = CpuLib
 …
 [Sources.IA32]
   Ia32/CpuSleep.c | MSFT
   Ia32/CpuFlushTlb.c | MSFT
+  Ia32/CpuSleep.c | MSFT
+  Ia32/CpuFlushTlb.c | MSFT
   Ia32/CpuSleep.asm | INTEL
   Ia32/CpuFlushTlb.asm | INTEL
+  Ia32/CpuSleep.asm | INTEL
+  Ia32/CpuFlushTlb.asm | INTEL
   Ia32/CpuSleepGcc.c | GCC
   Ia32/CpuFlushTlbGcc.c | GCC
+  Ia32/CpuSleepGcc.c | GCC
+  Ia32/CpuFlushTlbGcc.c | GCC
 [Sources.X64]
   X64/CpuFlushTlb.asm
+  X64/CpuFlushTlb.asm
   X64/CpuSleep.asm
   X64/CpuSleep.S | GCC
   X64/CpuFlushTlb.S | GCC
+  X64/CpuSleep.S | GCC
+  X64/CpuFlushTlb.S | GCC
 [Sources.IPF]
 …
 [Sources.ARM]
   Arm/CpuFlushTlb.asm | RVCT
   Arm/CpuSleep.asm    | RVCT
+  Arm/CpuSleep.asm    | RVCT
   Arm/CpuFlushTlb.S   | GCC
   Arm/CpuSleep.S      | GCC
+  Arm/CpuSleep.S      | GCC
 [Sources.AARCH64]

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseCpuLib/X64/CpuFlushTlb.S

r48674	r58466
1		#------------------------------------------------------------------------------
	1	#------------------------------------------------------------------------------
2	2	# Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR>
3	3	# This program and the accompanying materials

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf

r58459	r58466
21	21	MODULE_TYPE = BASE
22	22	VERSION_STRING = 1.0
23		LIBRARY_CLASS = DebugLib
	23	LIBRARY_CLASS = DebugLib
24	24
25	25

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseDebugLibNull/DebugLib.c

-              r58459
+              r58466
   Prints a debug message to the debug output device if the specified error level is enabled.
   If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function
   GetDebugPrintErrorLevel (), then print the message specified by Format and the
+  If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function
+  GetDebugPrintErrorLevel (), then print the message specified by Format and the
   associated variable argument list to the debug output device.
 …
   @param  ErrorLevel  The error level of the debug message.
   @param  Format      Format string for the debug message to print.
   @param  ...         Variable argument list whose contents are accessed
+  @param  ...         Variable argument list whose contents are accessed
                       based on the format string specified by Format.
 …
 /**
   Prints an assert message containing a filename, line number, and description.
+  Prints an assert message containing a filename, line number, and description.
   This may be followed by a breakpoint or a dead loop.
   Print a message of the form "ASSERT <FileName>(<LineNumber>): <Description>\n"
   to the debug output device.  If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit of
   PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if
   DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then
   CpuDeadLoop() is called.  If neither of these bits are set, then this function
+  to the debug output device.  If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit of
+  PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if
+  DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then
+  CpuDeadLoop() is called.  If neither of these bits are set, then this function
   returns immediately after the message is printed to the debug output device.
   DebugAssert() must actively prevent recursion.  If DebugAssert() is called while
 …
   Fills a target buffer with PcdDebugClearMemoryValue, and returns the target buffer.
   This function fills Length bytes of Buffer with the value specified by
+  This function fills Length bytes of Buffer with the value specified by
   PcdDebugClearMemoryValue, and returns Buffer.
   If Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param   Buffer  The pointer to the target buffer to be filled with PcdDebugClearMemoryValue.
   @param   Length  The number of bytes in Buffer to fill with zeros PcdDebugClearMemoryValue.
+  @param   Length  The number of bytes in Buffer to fill with zeros PcdDebugClearMemoryValue.
   @return  Buffer  The pointer to the target buffer filled with PcdDebugClearMemoryValue.
 …
   Returns TRUE if ASSERT() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG_CODE() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG_CLEAR_MEMORY() macro is enabled.
   This function returns TRUE if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf

r58459	r58466
22	22	MODULE_TYPE = BASE
23	23	VERSION_STRING = 1.0
24		LIBRARY_CLASS = DebugLib
	24	LIBRARY_CLASS = DebugLib
25	25	CONSTRUCTOR = BaseDebugLibSerialPortConstructor
26	26

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseDebugLibSerialPort/DebugLib.c

-              r58459
+              r58466
   Base Debug library instance base on Serial Port library.
   It uses PrintLib to send debug messages to serial port device.
   NOTE: If the Serial Port library enables hardware flow control, then a call
   to DebugPrint() or DebugAssert() may hang if writes to the serial port are
+  NOTE: If the Serial Port library enables hardware flow control, then a call
+  to DebugPrint() or DebugAssert() may hang if writes to the serial port are
   being blocked.  This may occur if a key(s) are pressed in a terminal emulator
   used to monitor the DEBUG() and ASSERT() messages.
+  used to monitor the DEBUG() and ASSERT() messages.
   Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
 //
 // Define the maximum debug and assert message length that this library supports
+// Define the maximum debug and assert message length that this library supports
 //
 #define MAX_DEBUG_MESSAGE_LENGTH  0x100
 …
   Prints a debug message to the debug output device if the specified error level is enabled.
   If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function
   GetDebugPrintErrorLevel (), then print the message specified by Format and the
+  If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function
+  GetDebugPrintErrorLevel (), then print the message specified by Format and the
   associated variable argument list to the debug output device.
 …
   @param  ErrorLevel  The error level of the debug message.
   @param  Format      Format string for the debug message to print.
   @param  ...         Variable argument list whose contents are accessed
+  @param  ...         Variable argument list whose contents are accessed
                       based on the format string specified by Format.
 …
   //
   // Send the print string to a Serial Port
+  // Send the print string to a Serial Port
   //
   SerialPortWrite ((UINT8 *)Buffer, AsciiStrLen (Buffer));
 …
 /**
   Prints an assert message containing a filename, line number, and description.
+  Prints an assert message containing a filename, line number, and description.
   This may be followed by a breakpoint or a dead loop.
   Print a message of the form "ASSERT <FileName>(<LineNumber>): <Description>\n"
   to the debug output device.  If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit of
   PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if
   DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then
   CpuDeadLoop() is called.  If neither of these bits are set, then this function
+  to the debug output device.  If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit of
+  PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if
+  DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then
+  CpuDeadLoop() is called.  If neither of these bits are set, then this function
   returns immediately after the message is printed to the debug output device.
   DebugAssert() must actively prevent recursion.  If DebugAssert() is called while
 …
   Fills a target buffer with PcdDebugClearMemoryValue, and returns the target buffer.
   This function fills Length bytes of Buffer with the value specified by
+  This function fills Length bytes of Buffer with the value specified by
   PcdDebugClearMemoryValue, and returns Buffer.
   If Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param   Buffer  The pointer to the target buffer to be filled with PcdDebugClearMemoryValue.
   @param   Length  The number of bytes in Buffer to fill with zeros PcdDebugClearMemoryValue.
+  @param   Length  The number of bytes in Buffer to fill with zeros PcdDebugClearMemoryValue.
   @return  Buffer  The pointer to the target buffer filled with PcdDebugClearMemoryValue.
 …
   Returns TRUE if ASSERT() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG_CODE() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG_CLEAR_MEMORY() macro is enabled.
   This function returns TRUE if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.c

-              r48674
+              r58466
 /** @file
   Debug Print Error Level library instance that retrieves the current error
   level from PcdDebugPrintErrorLevel.  This generic library instance does not
+  Debug Print Error Level library instance that retrieves the current error
+  level from PcdDebugPrintErrorLevel.  This generic library instance does not
   support the setting of the global debug print error level mask for the platform.
 …
 /**
   Sets the global debug print error level mask fpr the entire platform.
   @param   ErrorLevel     Global debug print error level.
   @retval  TRUE           The debug print error level mask was sucessfully set.
   @retval  FALSE          The debug print error level mask could not be set.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf

-              r58459
+              r58466
 ## @file
 #  Debug Print Error Level library instance based on PcdDebugPrintErrorLevel.
 #  It retrieves the current error level from PcdDebugPrintErrorLevel.
+#  It retrieves the current error level from PcdDebugPrintErrorLevel.
+#
 #  Copyright (c) 2011 - 2014, Intel Corporation. All rights reserved.<BR>
 …
 [LibraryClasses]
   PcdLib
 [Pcd]
   gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel  ## CONSUMES

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseExtractGuidedSectionLib/BaseExtractGuidedSectionLib.c

-              r48674
+              r58466
 /**
   HandlerInfo table address is set by PcdGuidedExtractHandlerTableAddress, which is used to store
   the registered guid and Handler list. When it is initialized, it will be directly returned.
+  HandlerInfo table address is set by PcdGuidedExtractHandlerTableAddress, which is used to store
+  the registered guid and Handler list. When it is initialized, it will be directly returned.
   Or, HandlerInfo table will be initialized in this function.
 …
+{
   EXTRACT_GUIDED_SECTION_HANDLER_INFO *HandlerInfo;
   //
   // Set the available memory address to handler info.
 …
   HandlerInfo->ExtractHandlerGuidTable    = (GUID *) (HandlerInfo + 1);
   HandlerInfo->ExtractDecodeHandlerTable  = (EXTRACT_GUIDED_SECTION_DECODE_HANDLER *) (
                                               (UINT8 *)HandlerInfo->ExtractHandlerGuidTable +
+                                              (UINT8 *)HandlerInfo->ExtractHandlerGuidTable +
                                               PcdGet32 (PcdMaximumGuidedExtractHandler) * sizeof (GUID)
                                              );
   HandlerInfo->ExtractGetInfoHandlerTable = (EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER *) (
                                               (UINT8 *)HandlerInfo->ExtractDecodeHandlerTable +
                                               PcdGet32 (PcdMaximumGuidedExtractHandler) *
+                                              (UINT8 *)HandlerInfo->ExtractDecodeHandlerTable +
+                                              PcdGet32 (PcdMaximumGuidedExtractHandler) *
                                               sizeof (EXTRACT_GUIDED_SECTION_DECODE_HANDLER)
                                              );
 …
   Sets ExtractHandlerGuidTable so it points at a callee allocated array of registered GUIDs.
   The total number of GUIDs in the array are returned. Since the array of GUIDs is callee allocated
   and caller must treat this array of GUIDs as read-only data.
+  and caller must treat this array of GUIDs as read-only data.
   If ExtractHandlerGuidTable is NULL, then ASSERT().
 …
   If the GUID value specified by SectionGuid has already been registered, then return RETURN_ALREADY_STARTED.
   If there are not enough resources available to register the handlers  then RETURN_OUT_OF_RESOURCES is returned.
   If SectionGuid is NULL, then ASSERT().
   If GetInfoHandler is NULL, then ASSERT().
 …
                              required to actually decode the data in a GUIDed section.
   @param[in]  DecodeHandler  The pointer to a function that decodes a GUIDed section into a caller
                              allocated output buffer.
+                             allocated output buffer.
   @retval  RETURN_SUCCESS           The handlers were registered.
 …
     return RETURN_OUT_OF_RESOURCES;
+  }
   //
   // Register new Handler and guid value.
 …
   optional scratch buffer required to actually decode the data in a GUIDed section.
   Examines a GUIDed section specified by InputSection.
+  Examines a GUIDed section specified by InputSection.
   If GUID for InputSection does not match any of the GUIDs registered through ExtractGuidedSectionRegisterHandlers(),
   then RETURN_UNSUPPORTED is returned.
   If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
+  then RETURN_UNSUPPORTED is returned.
+  If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
   of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER that was registered with ExtractGuidedSectionRegisterHandlers()
   is used to retrieve the OututBufferSize, ScratchSize, and Attributes values. The return status from the handler of
   type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER is returned.
   If InputSection is NULL, then ASSERT().
   If OutputBufferSize is NULL, then ASSERT().
 …
   OUT       UINT32  *OutputBufferSize,
   OUT       UINT32  *ScratchBufferSize,
   OUT       UINT16  *SectionAttribute
+  OUT       UINT16  *SectionAttribute
+  )
+{
 …
   EXTRACT_GUIDED_SECTION_HANDLER_INFO *HandlerInfo;
   EFI_GUID                            *SectionDefinitionGuid;
   //
   // Check input paramter
 …
   //
   // Not found, the input guided section is not supported.
+  // Not found, the input guided section is not supported.
   //
   return RETURN_UNSUPPORTED;
 …
   allocated output buffer.
   Decodes the GUIDed section specified by InputSection.
+  Decodes the GUIDed section specified by InputSection.
   If GUID for InputSection does not match any of the GUIDs registered through ExtractGuidedSectionRegisterHandlers(),
   then RETURN_UNSUPPORTED is returned.
+  then RETURN_UNSUPPORTED is returned.
   If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
   of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER that was registered with ExtractGuidedSectionRegisterHandlers()
 …
   then OutputBuffer is set to point at the data in InputSection.  Otherwise, the decoded data will be placed in a caller
   allocated buffer specified by OutputBuffer.    This function is responsible for computing the  EFI_AUTH_STATUS_PLATFORM_OVERRIDE
   bit of in AuthenticationStatus.  The return status from the handler of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER is returned.
+  bit of in AuthenticationStatus.  The return status from the handler of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER is returned.
   If InputSection is NULL, then ASSERT().
   If OutputBuffer is NULL, then ASSERT().
   If ScratchBuffer is NULL and this decode operation requires a scratch buffer, then ASSERT().
   If AuthenticationStatus is NULL, then ASSERT().
+  If AuthenticationStatus is NULL, then ASSERT().
   @param[in]  InputSection   A pointer to a GUIDed section of an FFS formatted file.
   @param[out] OutputBuffer   A pointer to a buffer that contains the result of a decode operation.
   @param[in]  ScratchBuffer  A caller allocated buffer that may be required by this function as a scratch buffer to perform the decode operation.
   @param[out] AuthenticationStatus
+  @param[out] OutputBuffer   A pointer to a buffer that contains the result of a decode operation.
+  @param[in]  ScratchBuffer  A caller allocated buffer that may be required by this function as a scratch buffer to perform the decode operation.
+  @param[out] AuthenticationStatus
                              A pointer to the authentication status of the decoded output buffer. See the definition
                              of authentication status in the EFI_PEI_GUIDED_SECTION_EXTRACTION_PPI section of the PI
 …
   OUT       VOID    **OutputBuffer,
   IN        VOID    *ScratchBuffer,        OPTIONAL
   OUT       UINT32  *AuthenticationStatus
+  OUT       UINT32  *AuthenticationStatus
+  )
+{
 …
   EXTRACT_GUIDED_SECTION_HANDLER_INFO *HandlerInfo;
   EFI_GUID                            *SectionDefinitionGuid;
   //
   // Check input parameter
 …
   //
   // Get all registered handler information.
   //
+  //
   Status = GetExtractGuidedSectionHandlerInfo (&HandlerInfo);
   if (RETURN_ERROR (Status)) {
 …
   //
   // Not found, the input guided section is not supported.
+  // Not found, the input guided section is not supported.
   //
   return RETURN_UNSUPPORTED;
 …
 /**
   Retrieves handlers of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER and
+  Retrieves handlers of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER and
   EXTRACT_GUIDED_SECTION_DECODE_HANDLER for a specific GUID section type.
   Retrieves the handlers associated with SectionGuid and returns them in
+  Retrieves the handlers associated with SectionGuid and returns them in
   GetInfoHandler and DecodeHandler.
   If the GUID value specified by SectionGuid has not been registered, then
+  If the GUID value specified by SectionGuid has not been registered, then
   return RETURN_NOT_FOUND.
   If SectionGuid is NULL, then ASSERT().
   @param[in]  SectionGuid    A pointer to the GUID associated with the handlersof the GUIDed
+  @param[in]  SectionGuid    A pointer to the GUID associated with the handlersof the GUIDed
                              section type being retrieved.
   @param[out] GetInfoHandler Pointer to a function that examines a GUIDed section and returns
                              the size of the decoded buffer and the size of an optional scratch
                              buffer required to actually decode the data in a GUIDed section.
                              This is an optional parameter that may be NULL. If it is NULL, then
+  @param[out] GetInfoHandler Pointer to a function that examines a GUIDed section and returns
+                             the size of the decoded buffer and the size of an optional scratch
+                             buffer required to actually decode the data in a GUIDed section.
+                             This is an optional parameter that may be NULL. If it is NULL, then
                              the previously registered handler is not returned.
   @param[out] DecodeHandler  Pointer to a function that decodes a GUIDed section into a caller

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseExtractGuidedSectionLib/BaseExtractGuidedSectionLib.inf

-              r58459
+              r58466
 #  Base ExtractGuidedSection Library.
 #  This instance can also be used in SEC phase only when the memory is ready in SEC phase.
 #  PCD PcdGuidedExtractHandlerTableAddress points to the available pysical memory space
+#  PCD PcdGuidedExtractHandlerTableAddress points to the available pysical memory space
 #  that is used to store Guided Extract Handlers.
 #  Note: A driver of type DXE_RUNTIME_DRIVER can use this ExtractGuidedSectionLib
 #  in their initialization without any issues. They only have to be careful in
 #  the implementation of runtime services, because this BASE library instance doesn't
+#  Note: A driver of type DXE_RUNTIME_DRIVER can use this ExtractGuidedSectionLib
+#  in their initialization without any issues. They only have to be careful in
+#  the implementation of runtime services, because this BASE library instance doesn't
 #  convert the address pointed by PcdGuidedExtractHandlerTableAddress to the virtual address.
+#
+#
 #  Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
+#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf

r58459	r58466
26	26	MODULE_TYPE = BASE
27	27	VERSION_STRING = 1.0
28		LIBRARY_CLASS = IoLib
	28	LIBRARY_CLASS = IoLib
29	29
30	30

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseIoLibIntrinsic/IoHighLevel.c

-              r58459
+              r58466
 /**
   Reads an 8-bit I/O port, performs a bitwise AND followed by a bitwise
+  Reads an 8-bit I/O port, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 8-bit I/O port.
 …
   Writes Value to the bit field of the I/O register. The bit field is specified
   by the StartBit and the EndBit. All other bits in the destination I/O
   register are preserved. The value written to the I/O port is returned.
+  register are preserved. The value written to the I/O port is returned.
   If 8-bit I/O port operations are not supported, then ASSERT().
 …
   If 16-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 16-bit boundary, then ASSERT().
   @param  Port    The I/O port to write.
   @param  AndData The value to AND with the read value from the I/O port.
 …
 /**
   Reads a 16-bit I/O port, performs a bitwise AND followed by a bitwise
+  Reads a 16-bit I/O port, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 16-bit I/O port.
 …
   If 16-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 16-bit boundary, then ASSERT().
   @param  Port    The I/O port to write.
   @param  AndData The value to AND with the read value from the I/O port.
 …
 /**
   Reads a 32-bit I/O port, performs a bitwise AND followed by a bitwise
+  Reads a 32-bit I/O port, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 32-bit I/O port.
 …
 /**
   Reads a 64-bit I/O port, performs a bitwise AND followed by a bitwise
+  Reads a 64-bit I/O port, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 64-bit I/O port.
 …
   result back to the 8-bit MMIO register.
   Reads the 8-bit MMIO register specified by Address, performs a bitwise
+  Reads the 8-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 8-bit MMIO register specified by Address. The value
 …
 /**
   Reads an 8-bit MMIO register, performs a bitwise AND followed by a bitwise
+  Reads an 8-bit MMIO register, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 8-bit MMIO register.
 …
   writes the result back to the bit field in the 8-bit MMIO register.
   Reads the 8-bit MMIO register specified by Address, performs a bitwise
+  Reads the 8-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 8-bit MMIO register specified by Address. The value
 …
   result back to the 16-bit MMIO register.
   Reads the 16-bit MMIO register specified by Address, performs a bitwise
+  Reads the 16-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 16-bit MMIO register specified by Address. The value
 …
 /**
   Reads a 16-bit MMIO register, performs a bitwise AND followed by a bitwise
+  Reads a 16-bit MMIO register, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 16-bit MMIO register.
 …
   writes the result back to the bit field in the 16-bit MMIO register.
   Reads the 16-bit MMIO register specified by Address, performs a bitwise
+  Reads the 16-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 16-bit MMIO register specified by Address. The value
 …
   result back to the 32-bit MMIO register.
   Reads the 32-bit MMIO register specified by Address, performs a bitwise
+  Reads the 32-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 32-bit MMIO register specified by Address. The value
 …
 /**
   Reads a 32-bit MMIO register, performs a bitwise AND followed by a bitwise
+  Reads a 32-bit MMIO register, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 32-bit MMIO register.
 …
   writes the result back to the bit field in the 32-bit MMIO register.
   Reads the 32-bit MMIO register specified by Address, performs a bitwise
+  Reads the 32-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 32-bit MMIO register specified by Address. The value
 …
   result back to the 64-bit MMIO register.
   Reads the 64-bit MMIO register specified by Address, performs a bitwise
+  Reads the 64-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 64-bit MMIO register specified by Address. The value
 …
 /**
   Reads a 64-bit MMIO register, performs a bitwise AND followed by a bitwise
+  Reads a 64-bit MMIO register, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 64-bit MMIO register.
 …
   writes the result back to the bit field in the 64-bit MMIO register.
   Reads the 64-bit MMIO register specified by Address, performs a bitwise
+  Reads the 64-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 64-bit MMIO register specified by Address. The value

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseIoLibIntrinsic/IoLib.c

-              r48674
+              r58466
   @param  Address The MMIO register to write.
   @param  Value   The value to write to the MMIO register.
   @return Value.
 …
   @param  Address The MMIO register to write.
   @param  Value   The value to write to the MMIO register.
   @return Value.
 …
   *(volatile UINT16*)Address = Value;
   MemoryFence ();
   return Value;
+}
 …
   ASSERT ((Address & 3) == 0);
   MemoryFence ();
   Value = *(volatile UINT32*)Address;
   MemoryFence ();
   return Value;
+}
 …
   @param  Address The MMIO register to write.
   @param  Value   The value to write to the MMIO register.
   @return Value.
 …
+{
   ASSERT ((Address & 3) == 0);
   MemoryFence ();
   *(volatile UINT32*)Address = Value;
   MemoryFence ();
   return Value;
+}
 …
   ASSERT ((Address & 7) == 0);
   MemoryFence ();
   Value = *(volatile UINT64*)Address;
 …
+{
   ASSERT ((Address & 7) == 0);
   MemoryFence ();
   *(volatile UINT64*)Address = Value;
   MemoryFence ();
   return Value;
+}
+  return Value;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c

r48674	r58466
1	1	/** @file
2		I/O Library for ARM.
	2	I/O Library for ARM.
3	3
4	4	Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseIoLibIntrinsic/IoLibIcc.c

-              r48674
+              r58466
     out dx, al
+  }
   return Value;
+  return Value;
+}
 …
   If 16-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 16-bit boundary, then ASSERT().
   @param  Port  The I/O port to write.
   @param  Value The value to write to the I/O port.
 …
   If 32-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 32-bit boundary, then ASSERT().
   @param  Port  The I/O port to read.
 …
     mov dword ptr [Data], eax
+  }
   return Data;
+}
 …
   If 32-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 32-bit boundary, then ASSERT().
   @param  Port  The I/O port to write.
   @param  Value The value to write to the I/O port.
 …
+{
   ASSERT ((Port & 3) == 0);
   __asm {
     mov eax, dword ptr [Value]

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c

-              r48674
+              r58466
   This function translates I/O port address to memory address by adding the 64MB
   aligned I/O Port space to the I/O address.
   If I/O Port space base is not 64MB aligned, then ASSERT ().
+  If I/O Port space base is not 64MB aligned, then ASSERT ().
   @param  Port  The I/O port to read.
 …
   //
   // Make sure that the I/O Port space base is 64MB aligned.
   //
+  //
   ASSERT ((IoBlockBaseAddress & 0x3ffffff) == 0);
   Address += IoBlockBaseAddress;
 …
   If 32-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 32-bit boundary, then ASSERT().
   @param  Port  The I/O port to read.
 …
   If 16-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 16-bit boundary, then ASSERT().
   @param  Port  The I/O port to write.
   @param  Value The value to write to the I/O port.
 …
   If 32-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 32-bit boundary, then ASSERT().
   @param  Port  The I/O port to write.
   @param  Value The value to write to the I/O port.
 …
   //
   // Make sure that Address is 16-bit aligned.
   //
+  //
   ASSERT ((Address & 1) == 0);
 …
   //
   // Make sure that Address is 32-bit aligned.
   //
+  //
   ASSERT ((Address & 3) == 0);
 …
   //
   // Make sure that Address is 64-bit aligned.
   //
+  //
   ASSERT ((Address & 7) == 0);
 …
   @param  Address The MMIO register to write.
   @param  Value   The value to write to the MMIO register.
   @return Value.
 …
   @param  Address The MMIO register to write.
   @param  Value   The value to write to the MMIO register.
   @return Value.
 …
   //
   // Make sure that Address is 16-bit aligned.
   //
+  //
   ASSERT ((Address & 1) == 0);
 …
   @param  Address The MMIO register to write.
   @param  Value   The value to write to the MMIO register.
   @return Value.
 …
   //
   // Make sure that Address is 32-bit aligned.
   //
+  //
   ASSERT ((Address & 3) == 0);
 …
   //
   // Make sure that Address is 64-bit aligned.
   //
+  //
   ASSERT ((Address & 7) == 0);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseIoLibIntrinsic/IoLibMmioBuffer.c

-              r48674
+              r58466
   Copy data from the MMIO region to system memory by using 8-bit access.
   Copy data from the MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 8-bit access. The total
+  Copy data from the MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 8-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
   ReturnBuffer = Buffer;
   while (Length-- != 0) {
     *(Buffer++) = MmioRead8 (StartAddress++);
 …
   Copy data from the MMIO region to system memory by using 16-bit access.
   Copy data from the MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 16-bit access. The total
+  Copy data from the MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 16-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 16-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT16) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ASSERT ((Length & (sizeof (UINT16) - 1)) == 0);
   ASSERT (((UINTN) Buffer & (sizeof (UINT16) - 1)) == 0);
   ReturnBuffer = Buffer;
   while (Length != 0) {
     *(Buffer++) = MmioRead16 (StartAddress);
 …
   Copy data from the MMIO region to system memory by using 32-bit access.
   Copy data from the MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 32-bit access. The total
+  Copy data from the MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 32-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 32-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT32) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ASSERT ((Length & (sizeof (UINT32) - 1)) == 0);
   ASSERT (((UINTN) Buffer & (sizeof (UINT32) - 1)) == 0);
   ReturnBuffer = Buffer;
   while (Length != 0) {
     *(Buffer++) = MmioRead32 (StartAddress);
 …
   Copy data from the MMIO region to system memory by using 64-bit access.
   Copy data from the MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 64-bit access. The total
+  Copy data from the MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 64-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 64-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT64) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ASSERT ((Length & (sizeof (UINT64) - 1)) == 0);
   ASSERT (((UINTN) Buffer & (sizeof (UINT64) - 1)) == 0);
   ReturnBuffer = Buffer;
   while (Length != 0) {
     *(Buffer++) = MmioRead64 (StartAddress);
 …
   Copy data from system memory to the MMIO region by using 8-bit access.
   Copy data from system memory specified by Buffer to the MMIO region specified
   by starting address StartAddress by using 8-bit access. The total number
+  Copy data from system memory specified by Buffer to the MMIO region specified
+  by starting address StartAddress by using 8-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
   ReturnBuffer = (UINT8 *) Buffer;
   while (Length-- != 0) {
      MmioWrite8 (StartAddress++, *(Buffer++));
 …
   return ReturnBuffer;
+}
 …
   Copy data from system memory to the MMIO region by using 16-bit access.
   Copy data from system memory specified by Buffer to the MMIO region specified
   by starting address StartAddress by using 16-bit access. The total number
+  Copy data from system memory specified by Buffer to the MMIO region specified
+  by starting address StartAddress by using 16-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 16-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT16) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ReturnBuffer = (UINT16 *) Buffer;
   while (Length != 0) {
     MmioWrite16 (StartAddress, *(Buffer++));
     StartAddress += sizeof (UINT16);
     Length -= sizeof (UINT16);
 …
   Copy data from system memory to the MMIO region by using 32-bit access.
   Copy data from system memory specified by Buffer to the MMIO region specified
   by starting address StartAddress by using 32-bit access. The total number
+  Copy data from system memory specified by Buffer to the MMIO region specified
+  by starting address StartAddress by using 32-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 32-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT32) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ReturnBuffer = (UINT32 *) Buffer;
   while (Length != 0) {
     MmioWrite32 (StartAddress, *(Buffer++));
     StartAddress += sizeof (UINT32);
     Length -= sizeof (UINT32);
 …
   Copy data from system memory to the MMIO region by using 64-bit access.
   Copy data from system memory specified by Buffer to the MMIO region specified
   by starting address StartAddress by using 64-bit access. The total number
+  Copy data from system memory specified by Buffer to the MMIO region specified
+  by starting address StartAddress by using 64-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 64-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT64) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ReturnBuffer = (UINT64 *) Buffer;
   while (Length != 0) {
     MmioWrite64 (StartAddress, *(Buffer++));
     StartAddress += sizeof (UINT64);
     Length -= sizeof (UINT64);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseIoLibIntrinsic/IoLibMsc.c

-              r48674
+              r58466
   If 16-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 16-bit boundary, then ASSERT().
   @param  Port  The I/O port to write.
   @param  Value The value to write to the I/O port.
 …
   If 32-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 32-bit boundary, then ASSERT().
   @param  Port  The I/O port to read.
 …
   If 32-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 32-bit boundary, then ASSERT().
   @param  Port  The I/O port to write.
   @param  Value The value to write to the I/O port.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/CpuBreakpoint.S

-              r48674
+              r58466
 #------------------------------------------------------------------------------
+#------------------------------------------------------------------------------
+#
 # CpuBreakpoint() for ARM
 …
+#
 ASM_PFX(CpuBreakpoint):
     swi  0xdbdbdb
+    swi  0xdbdbdb
     bx   lr

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/CpuBreakpoint.asm

-              r48674
+              r58466
 ;------------------------------------------------------------------------------
+;------------------------------------------------------------------------------
+;
 ; CpuBreakpoint() for ARM
 …
     swi   0xdbdbdb
     bx    lr
   END

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/CpuPause.asm

r48674	r58466
1		;------------------------------------------------------------------------------
	1	;------------------------------------------------------------------------------
2	2	;
3	3	; CpuPause() for ARM

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/DisableInterrupts.S

r48674	r58466
1		#------------------------------------------------------------------------------
	1	#------------------------------------------------------------------------------
2	2	#
3	3	# DisableInterrupts() for ARM

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/DisableInterrupts.asm

-              r48674
+              r58466
 ;------------------------------------------------------------------------------
+;------------------------------------------------------------------------------
+;
 ; DisableInterrupts() for ARM
 …
     MSR     CPSR_c,R0
     BX      LR
     END

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/EnableInterrupts.S

r48674	r58466
1		#------------------------------------------------------------------------------
	1	#------------------------------------------------------------------------------
2	2	#
3	3	# EnableInterrupts() for ARM

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/EnableInterrupts.asm

-              r48674
+              r58466
 ;------------------------------------------------------------------------------
+;------------------------------------------------------------------------------
+;
 ; EnableInterrupts() for ARM
 …
     MSR     CPSR_c,R0
     BX      LR
     END

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/GetInterruptsState.S

r48674	r58466
1		#------------------------------------------------------------------------------
	1	#------------------------------------------------------------------------------
2	2	#
3	3	# GetInterruptState() function for ARM

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/GetInterruptsState.asm

-              r48674
+              r58466
 ;------------------------------------------------------------------------------
+;------------------------------------------------------------------------------
+;
 ; GetInterruptState() function for ARM
 …
     MOVNE   R0, #0
     BX      LR
     END

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/InternalSwitchStack.c

r48674	r58466
40	40	);
41	41
42
	42
43	43	/**
44	44	Transfers control to a function starting with a new stack.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/Math64.S

-              r48674
+              r58466
 #------------------------------------------------------------------------------
+#
 # Replacement for Math64.c that is coded to use older GCC intrinsics.
+#------------------------------------------------------------------------------
+#
+# Replacement for Math64.c that is coded to use older GCC intrinsics.
 # Doing this reduces the number of intrinsics that are required when
 # you port to a new version of gcc.
+# you port to a new version of gcc.
+#
 # Need to split this into multple files to size optimize the image.
 …
         bl      ASM_PFX(__udivdi3)
         ldmfd   sp!, {r7, pc}
         .align 2
         GCC_ASM_EXPORT(InternalMathModU64x32)
 …
         bl      ASM_PFX(__umoddi3)
         ldmfd   sp!, {r7, pc}
         .align 2
         GCC_ASM_EXPORT(InternalMathDivRemU64x32)
 …
         ldmfd   sp!, {r10, r11}
         ldmfd   sp!, {r4, r5, r6, r7, pc}
         .align 2
         GCC_ASM_EXPORT(InternalMathDivRemU64x64)
 …
         ldmfd   sp!, {r10, r11}
         ldmfd   sp!, {r4, r5, r6, r7, pc}
         .align 2
         GCC_ASM_EXPORT(InternalMathDivRemS64x64)
 …
         ldmfd   sp!, {r10, r11}
         ldmfd   sp!, {r4, r5, r6, r7, pc}
         .align 2
         GCC_ASM_EXPORT(InternalMathSwapBytes64)

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S

r48674	r58466
1		#------------------------------------------------------------------------------
	1	#------------------------------------------------------------------------------
2	2	#
3	3	# Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm

r48674	r58466
1		;------------------------------------------------------------------------------
	1	;------------------------------------------------------------------------------
2	2	;
3	3	; Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/SwitchStack.S

-              r48674
+              r58466
 //------------------------------------------------------------------------------
+//------------------------------------------------------------------------------
 //
 // Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>
 …
 //
 //------------------------------------------------------------------------------
 .text
 .align 5
 GCC_ASM_EXPORT(InternalSwitchStackAsm)
 GCC_ASM_EXPORT(CpuPause)
+GCC_ASM_EXPORT(CpuPause)
 /**
 //

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/SwitchStack.asm

-              r48674
+              r58466
 ;------------------------------------------------------------------------------
+;------------------------------------------------------------------------------
+;
 ; Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>
 …
+;
 ;------------------------------------------------------------------------------
     EXPORT InternalSwitchStackAsm
     AREA   Switch_Stack, CODE, READONLY
 ;/**
 ;  This allows the caller to switch the stack and goes to the new entry point

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Arm/Unaligned.c

r48674	r58466
1	1	/** @file
2	2	Unaligned access functions of BaseLib for ARM.
3
	3
4	4	volatile was added to work around optimization issues.
5	5

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/BaseLib.inf

-              r58459
+              r58466
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = BaseLib
+  LIBRARY_CLASS                  = BaseLib
+#
 …
 [Sources.Ia32]
   Ia32/Wbinvd.c | MSFT
   Ia32/WriteMm7.c | MSFT
   Ia32/WriteMm6.c | MSFT
   Ia32/WriteMm5.c | MSFT
   Ia32/WriteMm4.c | MSFT
   Ia32/WriteMm3.c | MSFT
   Ia32/WriteMm2.c | MSFT
   Ia32/WriteMm1.c | MSFT
   Ia32/WriteMm0.c | MSFT
   Ia32/WriteLdtr.c | MSFT
   Ia32/WriteIdtr.c | MSFT
   Ia32/WriteGdtr.c | MSFT
   Ia32/WriteDr7.c | MSFT
   Ia32/WriteDr6.c | MSFT
   Ia32/WriteDr5.c | MSFT
   Ia32/WriteDr4.c | MSFT
   Ia32/WriteDr3.c | MSFT
   Ia32/WriteDr2.c | MSFT
   Ia32/WriteDr1.c | MSFT
   Ia32/WriteDr0.c | MSFT
   Ia32/WriteCr4.c | MSFT
   Ia32/WriteCr3.c | MSFT
   Ia32/WriteCr2.c | MSFT
   Ia32/WriteCr0.c | MSFT
   Ia32/WriteMsr64.c | MSFT
   Ia32/SwapBytes64.c | MSFT
   Ia32/SetJump.c | MSFT
   Ia32/RRotU64.c | MSFT
   Ia32/RShiftU64.c | MSFT
   Ia32/ReadPmc.c | MSFT
   Ia32/ReadTsc.c | MSFT
   Ia32/ReadLdtr.c | MSFT
   Ia32/ReadIdtr.c | MSFT
   Ia32/ReadGdtr.c | MSFT
   Ia32/ReadTr.c | MSFT
   Ia32/ReadSs.c | MSFT
   Ia32/ReadGs.c | MSFT
   Ia32/ReadFs.c | MSFT
   Ia32/ReadEs.c | MSFT
   Ia32/ReadDs.c | MSFT
   Ia32/ReadCs.c | MSFT
   Ia32/ReadMsr64.c | MSFT
   Ia32/ReadMm7.c | MSFT
   Ia32/ReadMm6.c | MSFT
   Ia32/ReadMm5.c | MSFT
   Ia32/ReadMm4.c | MSFT
   Ia32/ReadMm3.c | MSFT
   Ia32/ReadMm2.c | MSFT
   Ia32/ReadMm1.c | MSFT
   Ia32/ReadMm0.c | MSFT
   Ia32/ReadEflags.c | MSFT
   Ia32/ReadDr7.c | MSFT
   Ia32/ReadDr6.c | MSFT
   Ia32/ReadDr5.c | MSFT
   Ia32/ReadDr4.c | MSFT
   Ia32/ReadDr3.c | MSFT
   Ia32/ReadDr2.c | MSFT
   Ia32/ReadDr1.c | MSFT
   Ia32/ReadDr0.c | MSFT
   Ia32/ReadCr4.c | MSFT
   Ia32/ReadCr3.c | MSFT
   Ia32/ReadCr2.c | MSFT
   Ia32/ReadCr0.c | MSFT
   Ia32/Mwait.c | MSFT
   Ia32/Monitor.c | MSFT
   Ia32/ModU64x32.c | MSFT
   Ia32/MultU64x64.c | MSFT
   Ia32/MultU64x32.c | MSFT
   Ia32/LShiftU64.c | MSFT
   Ia32/LRotU64.c | MSFT
   Ia32/LongJump.c | MSFT
   Ia32/Invd.c | MSFT
   Ia32/FxRestore.c | MSFT
   Ia32/FxSave.c | MSFT
   Ia32/FlushCacheLine.c | MSFT
   Ia32/EnablePaging32.c | MSFT
   Ia32/EnableInterrupts.c | MSFT
   Ia32/EnableDisableInterrupts.c | MSFT
   Ia32/DivU64x64Remainder.asm | MSFT
   Ia32/DivU64x32Remainder.c | MSFT
   Ia32/DivU64x32.c | MSFT
   Ia32/DisablePaging32.c | MSFT
   Ia32/DisableInterrupts.c | MSFT
   Ia32/CpuPause.c | MSFT
   Ia32/CpuIdEx.c | MSFT
   Ia32/CpuId.c | MSFT
   Ia32/CpuBreakpoint.c | MSFT
   Ia32/ARShiftU64.c | MSFT
+  Ia32/Wbinvd.c | MSFT
+  Ia32/WriteMm7.c | MSFT
+  Ia32/WriteMm6.c | MSFT
+  Ia32/WriteMm5.c | MSFT
+  Ia32/WriteMm4.c | MSFT
+  Ia32/WriteMm3.c | MSFT
+  Ia32/WriteMm2.c | MSFT
+  Ia32/WriteMm1.c | MSFT
+  Ia32/WriteMm0.c | MSFT
+  Ia32/WriteLdtr.c | MSFT
+  Ia32/WriteIdtr.c | MSFT
+  Ia32/WriteGdtr.c | MSFT
+  Ia32/WriteDr7.c | MSFT
+  Ia32/WriteDr6.c | MSFT
+  Ia32/WriteDr5.c | MSFT
+  Ia32/WriteDr4.c | MSFT
+  Ia32/WriteDr3.c | MSFT
+  Ia32/WriteDr2.c | MSFT
+  Ia32/WriteDr1.c | MSFT
+  Ia32/WriteDr0.c | MSFT
+  Ia32/WriteCr4.c | MSFT
+  Ia32/WriteCr3.c | MSFT
+  Ia32/WriteCr2.c | MSFT
+  Ia32/WriteCr0.c | MSFT
+  Ia32/WriteMsr64.c | MSFT
+  Ia32/SwapBytes64.c | MSFT
+  Ia32/SetJump.c | MSFT
+  Ia32/RRotU64.c | MSFT
+  Ia32/RShiftU64.c | MSFT
+  Ia32/ReadPmc.c | MSFT
+  Ia32/ReadTsc.c | MSFT
+  Ia32/ReadLdtr.c | MSFT
+  Ia32/ReadIdtr.c | MSFT
+  Ia32/ReadGdtr.c | MSFT
+  Ia32/ReadTr.c | MSFT
+  Ia32/ReadSs.c | MSFT
+  Ia32/ReadGs.c | MSFT
+  Ia32/ReadFs.c | MSFT
+  Ia32/ReadEs.c | MSFT
+  Ia32/ReadDs.c | MSFT
+  Ia32/ReadCs.c | MSFT
+  Ia32/ReadMsr64.c | MSFT
+  Ia32/ReadMm7.c | MSFT
+  Ia32/ReadMm6.c | MSFT
+  Ia32/ReadMm5.c | MSFT
+  Ia32/ReadMm4.c | MSFT
+  Ia32/ReadMm3.c | MSFT
+  Ia32/ReadMm2.c | MSFT
+  Ia32/ReadMm1.c | MSFT
+  Ia32/ReadMm0.c | MSFT
+  Ia32/ReadEflags.c | MSFT
+  Ia32/ReadDr7.c | MSFT
+  Ia32/ReadDr6.c | MSFT
+  Ia32/ReadDr5.c | MSFT
+  Ia32/ReadDr4.c | MSFT
+  Ia32/ReadDr3.c | MSFT
+  Ia32/ReadDr2.c | MSFT
+  Ia32/ReadDr1.c | MSFT
+  Ia32/ReadDr0.c | MSFT
+  Ia32/ReadCr4.c | MSFT
+  Ia32/ReadCr3.c | MSFT
+  Ia32/ReadCr2.c | MSFT
+  Ia32/ReadCr0.c | MSFT
+  Ia32/Mwait.c | MSFT
+  Ia32/Monitor.c | MSFT
+  Ia32/ModU64x32.c | MSFT
+  Ia32/MultU64x64.c | MSFT
+  Ia32/MultU64x32.c | MSFT
+  Ia32/LShiftU64.c | MSFT
+  Ia32/LRotU64.c | MSFT
+  Ia32/LongJump.c | MSFT
+  Ia32/Invd.c | MSFT
+  Ia32/FxRestore.c | MSFT
+  Ia32/FxSave.c | MSFT
+  Ia32/FlushCacheLine.c | MSFT
+  Ia32/EnablePaging32.c | MSFT
+  Ia32/EnableInterrupts.c | MSFT
+  Ia32/EnableDisableInterrupts.c | MSFT
+  Ia32/DivU64x64Remainder.asm | MSFT
+  Ia32/DivU64x32Remainder.c | MSFT
+  Ia32/DivU64x32.c | MSFT
+  Ia32/DisablePaging32.c | MSFT
+  Ia32/DisableInterrupts.c | MSFT
+  Ia32/CpuPause.c | MSFT
+  Ia32/CpuIdEx.c | MSFT
+  Ia32/CpuId.c | MSFT
+  Ia32/CpuBreakpoint.c | MSFT
+  Ia32/ARShiftU64.c | MSFT
   Ia32/Thunk16.asm | MSFT
   Ia32/EnablePaging64.asm | MSFT
 …
   Ia32/DisableCache.c | MSFT
   Ia32/Wbinvd.asm | INTEL
   Ia32/WriteMm7.asm | INTEL
   Ia32/WriteMm6.asm | INTEL
   Ia32/WriteMm5.asm | INTEL
   Ia32/WriteMm4.asm | INTEL
   Ia32/WriteMm3.asm | INTEL
   Ia32/WriteMm2.asm | INTEL
   Ia32/WriteMm1.asm | INTEL
   Ia32/WriteMm0.asm | INTEL
   Ia32/WriteLdtr.asm | INTEL
   Ia32/WriteIdtr.asm | INTEL
   Ia32/WriteGdtr.asm | INTEL
   Ia32/WriteDr7.asm | INTEL
   Ia32/WriteDr6.asm | INTEL
   Ia32/WriteDr5.asm | INTEL
   Ia32/WriteDr4.asm | INTEL
   Ia32/WriteDr3.asm | INTEL
   Ia32/WriteDr2.asm | INTEL
   Ia32/WriteDr1.asm | INTEL
   Ia32/WriteDr0.asm | INTEL
   Ia32/WriteCr4.asm | INTEL
   Ia32/WriteCr3.asm | INTEL
   Ia32/WriteCr2.asm | INTEL
   Ia32/WriteCr0.asm | INTEL
   Ia32/WriteMsr64.asm | INTEL
   Ia32/SwapBytes64.asm | INTEL
   Ia32/SetJump.asm | INTEL
   Ia32/RRotU64.asm | INTEL
   Ia32/RShiftU64.asm | INTEL
   Ia32/ReadPmc.asm | INTEL
   Ia32/ReadTsc.asm | INTEL
   Ia32/ReadLdtr.asm | INTEL
   Ia32/ReadIdtr.asm | INTEL
   Ia32/ReadGdtr.asm | INTEL
   Ia32/ReadTr.asm | INTEL
   Ia32/ReadSs.asm | INTEL
   Ia32/ReadGs.asm | INTEL
   Ia32/ReadFs.asm | INTEL
   Ia32/ReadEs.asm | INTEL
   Ia32/ReadDs.asm | INTEL
   Ia32/ReadCs.asm | INTEL
   Ia32/ReadMsr64.asm | INTEL
   Ia32/ReadMm7.asm | INTEL
   Ia32/ReadMm6.asm | INTEL
   Ia32/ReadMm5.asm | INTEL
   Ia32/ReadMm4.asm | INTEL
   Ia32/ReadMm3.asm | INTEL
   Ia32/ReadMm2.asm | INTEL
   Ia32/ReadMm1.asm | INTEL
   Ia32/ReadMm0.asm | INTEL
   Ia32/ReadEflags.asm | INTEL
   Ia32/ReadDr7.asm | INTEL
   Ia32/ReadDr6.asm | INTEL
   Ia32/ReadDr5.asm | INTEL
   Ia32/ReadDr4.asm | INTEL
   Ia32/ReadDr3.asm | INTEL
   Ia32/ReadDr2.asm | INTEL
   Ia32/ReadDr1.asm | INTEL
   Ia32/ReadDr0.asm | INTEL
   Ia32/ReadCr4.asm | INTEL
   Ia32/ReadCr3.asm | INTEL
   Ia32/ReadCr2.asm | INTEL
   Ia32/ReadCr0.asm | INTEL
   Ia32/Mwait.asm | INTEL
   Ia32/Monitor.asm | INTEL
   Ia32/ModU64x32.asm | INTEL
   Ia32/MultU64x64.asm | INTEL
   Ia32/MultU64x32.asm | INTEL
   Ia32/LShiftU64.asm | INTEL
   Ia32/LRotU64.asm | INTEL
   Ia32/LongJump.asm | INTEL
   Ia32/Invd.asm | INTEL
   Ia32/FxRestore.asm | INTEL
   Ia32/FxSave.asm | INTEL
   Ia32/FlushCacheLine.asm | INTEL
   Ia32/EnablePaging32.asm | INTEL
   Ia32/EnableInterrupts.asm | INTEL
   Ia32/EnableDisableInterrupts.asm | INTEL
   Ia32/DivU64x64Remainder.asm | INTEL
   Ia32/DivU64x32Remainder.asm | INTEL
   Ia32/DivU64x32.asm | INTEL
   Ia32/DisablePaging32.asm | INTEL
   Ia32/DisableInterrupts.asm | INTEL
   Ia32/CpuPause.asm | INTEL
   Ia32/CpuIdEx.asm | INTEL
   Ia32/CpuId.asm | INTEL
   Ia32/CpuBreakpoint.asm | INTEL
   Ia32/ARShiftU64.asm | INTEL
+  Ia32/Wbinvd.asm | INTEL
+  Ia32/WriteMm7.asm | INTEL
+  Ia32/WriteMm6.asm | INTEL
+  Ia32/WriteMm5.asm | INTEL
+  Ia32/WriteMm4.asm | INTEL
+  Ia32/WriteMm3.asm | INTEL
+  Ia32/WriteMm2.asm | INTEL
+  Ia32/WriteMm1.asm | INTEL
+  Ia32/WriteMm0.asm | INTEL
+  Ia32/WriteLdtr.asm | INTEL
+  Ia32/WriteIdtr.asm | INTEL
+  Ia32/WriteGdtr.asm | INTEL
+  Ia32/WriteDr7.asm | INTEL
+  Ia32/WriteDr6.asm | INTEL
+  Ia32/WriteDr5.asm | INTEL
+  Ia32/WriteDr4.asm | INTEL
+  Ia32/WriteDr3.asm | INTEL
+  Ia32/WriteDr2.asm | INTEL
+  Ia32/WriteDr1.asm | INTEL
+  Ia32/WriteDr0.asm | INTEL
+  Ia32/WriteCr4.asm | INTEL
+  Ia32/WriteCr3.asm | INTEL
+  Ia32/WriteCr2.asm | INTEL
+  Ia32/WriteCr0.asm | INTEL
+  Ia32/WriteMsr64.asm | INTEL
+  Ia32/SwapBytes64.asm | INTEL
+  Ia32/SetJump.asm | INTEL
+  Ia32/RRotU64.asm | INTEL
+  Ia32/RShiftU64.asm | INTEL
+  Ia32/ReadPmc.asm | INTEL
+  Ia32/ReadTsc.asm | INTEL
+  Ia32/ReadLdtr.asm | INTEL
+  Ia32/ReadIdtr.asm | INTEL
+  Ia32/ReadGdtr.asm | INTEL
+  Ia32/ReadTr.asm | INTEL
+  Ia32/ReadSs.asm | INTEL
+  Ia32/ReadGs.asm | INTEL
+  Ia32/ReadFs.asm | INTEL
+  Ia32/ReadEs.asm | INTEL
+  Ia32/ReadDs.asm | INTEL
+  Ia32/ReadCs.asm | INTEL
+  Ia32/ReadMsr64.asm | INTEL
+  Ia32/ReadMm7.asm | INTEL
+  Ia32/ReadMm6.asm | INTEL
+  Ia32/ReadMm5.asm | INTEL
+  Ia32/ReadMm4.asm | INTEL
+  Ia32/ReadMm3.asm | INTEL
+  Ia32/ReadMm2.asm | INTEL
+  Ia32/ReadMm1.asm | INTEL
+  Ia32/ReadMm0.asm | INTEL
+  Ia32/ReadEflags.asm | INTEL
+  Ia32/ReadDr7.asm | INTEL
+  Ia32/ReadDr6.asm | INTEL
+  Ia32/ReadDr5.asm | INTEL
+  Ia32/ReadDr4.asm | INTEL
+  Ia32/ReadDr3.asm | INTEL
+  Ia32/ReadDr2.asm | INTEL
+  Ia32/ReadDr1.asm | INTEL
+  Ia32/ReadDr0.asm | INTEL
+  Ia32/ReadCr4.asm | INTEL
+  Ia32/ReadCr3.asm | INTEL
+  Ia32/ReadCr2.asm | INTEL
+  Ia32/ReadCr0.asm | INTEL
+  Ia32/Mwait.asm | INTEL
+  Ia32/Monitor.asm | INTEL
+  Ia32/ModU64x32.asm | INTEL
+  Ia32/MultU64x64.asm | INTEL
+  Ia32/MultU64x32.asm | INTEL
+  Ia32/LShiftU64.asm | INTEL
+  Ia32/LRotU64.asm | INTEL
+  Ia32/LongJump.asm | INTEL
+  Ia32/Invd.asm | INTEL
+  Ia32/FxRestore.asm | INTEL
+  Ia32/FxSave.asm | INTEL
+  Ia32/FlushCacheLine.asm | INTEL
+  Ia32/EnablePaging32.asm | INTEL
+  Ia32/EnableInterrupts.asm | INTEL
+  Ia32/EnableDisableInterrupts.asm | INTEL
+  Ia32/DivU64x64Remainder.asm | INTEL
+  Ia32/DivU64x32Remainder.asm | INTEL
+  Ia32/DivU64x32.asm | INTEL
+  Ia32/DisablePaging32.asm | INTEL
+  Ia32/DisableInterrupts.asm | INTEL
+  Ia32/CpuPause.asm | INTEL
+  Ia32/CpuIdEx.asm | INTEL
+  Ia32/CpuId.asm | INTEL
+  Ia32/CpuBreakpoint.asm | INTEL
+  Ia32/ARShiftU64.asm | INTEL
   Ia32/Thunk16.asm | INTEL
   Ia32/EnablePaging64.asm | INTEL
 …
   Ia32/GccInline.c | GCC
+<<<<<<< .working
 # VBox begin (yasm doesn't like the nasm variant) - original:
 #  Ia32/Thunk16.nasm | GCC
 …
   Ia32/RShiftU64.S | GCC
   Ia32/LShiftU64.S | GCC
+||||||| .merge-left.r103776
+  Ia32/Thunk16.nasm | GCC
+  Ia32/EnableDisableInterrupts.S | GCC
+  Ia32/EnablePaging64.S | GCC
+  Ia32/DisablePaging32.S | GCC
+  Ia32/EnablePaging32.S | GCC
+  Ia32/Mwait.S | GCC
+  Ia32/Monitor.S | GCC
+  Ia32/CpuIdEx.S | GCC
+  Ia32/CpuId.S | GCC
+  Ia32/LongJump.S | GCC
+  Ia32/SetJump.S | GCC
+  Ia32/SwapBytes64.S | GCC
+  Ia32/DivU64x64Remainder.S | GCC
+  Ia32/DivU64x32Remainder.S | GCC
+  Ia32/ModU64x32.S | GCC
+  Ia32/DivU64x32.S | GCC
+  Ia32/MultU64x64.S | GCC
+  Ia32/MultU64x32.S | GCC
+  Ia32/RRotU64.S | GCC
+  Ia32/LRotU64.S | GCC
+  Ia32/ARShiftU64.S | GCC
+  Ia32/RShiftU64.S | GCC
+  Ia32/LShiftU64.S | GCC
+=======
+  Ia32/Thunk16.nasm | GCC
+  Ia32/EnableDisableInterrupts.S | GCC
+  Ia32/EnablePaging64.S | GCC
+  Ia32/DisablePaging32.S | GCC
+  Ia32/EnablePaging32.S | GCC
+  Ia32/Mwait.S | GCC
+  Ia32/Monitor.S | GCC
+  Ia32/CpuIdEx.S | GCC
+  Ia32/CpuId.S | GCC
+  Ia32/LongJump.S | GCC
+  Ia32/SetJump.S | GCC
+  Ia32/SwapBytes64.S | GCC
+  Ia32/DivU64x64Remainder.S | GCC
+  Ia32/DivU64x32Remainder.S | GCC
+  Ia32/ModU64x32.S | GCC
+  Ia32/DivU64x32.S | GCC
+  Ia32/MultU64x64.S | GCC
+  Ia32/MultU64x32.S | GCC
+  Ia32/RRotU64.S | GCC
+  Ia32/LRotU64.S | GCC
+  Ia32/ARShiftU64.S | GCC
+  Ia32/RShiftU64.S | GCC
+  Ia32/LShiftU64.S | GCC
+>>>>>>> .merge-right.r103776
   Ia32/EnableCache.S | GCC
   Ia32/DisableCache.S | GCC
 …
   X64/DisableCache.asm
   X64/CpuBreakpoint.c | MSFT
   X64/WriteMsr64.c | MSFT
   X64/ReadMsr64.c | MSFT
   X64/CpuBreakpoint.asm | INTEL
   X64/WriteMsr64.asm | INTEL
   X64/ReadMsr64.asm | INTEL
+  X64/CpuBreakpoint.c | MSFT
+  X64/WriteMsr64.c | MSFT
+  X64/ReadMsr64.c | MSFT
+  X64/CpuBreakpoint.asm | INTEL
+  X64/WriteMsr64.asm | INTEL
+  X64/ReadMsr64.asm | INTEL
   X64/Non-existing.c
 …
   X64/GccInline.c | GCC
 # VBox begin (yasm doesn't like the nasm variant) - original:
 #  Ia32/Thunk16.nasm | GCC
+#  Ia32/Thunk16.nasm | GCC
   Ia32/Thunk16.asm | GCC
 # VBox end
   X64/SwitchStack.S | GCC
   X64/SetJump.S | GCC
   X64/LongJump.S | GCC
   X64/EnableDisableInterrupts.S | GCC
   X64/DisablePaging64.S | GCC
   X64/CpuId.S | GCC
   X64/CpuIdEx.S | GCC
+  X64/SwitchStack.S | GCC
+  X64/SetJump.S | GCC
+  X64/LongJump.S | GCC
+  X64/EnableDisableInterrupts.S | GCC
+  X64/DisablePaging64.S | GCC
+  X64/CpuId.S | GCC
+  X64/CpuIdEx.S | GCC
   X64/EnableCache.S | GCC
   X64/DisableCache.S | GCC
   ChkStkGcc.c  | GCC
+  ChkStkGcc.c  | GCC
 [Sources.IPF]
 …
   Arm/InternalSwitchStack.c
   Arm/Unaligned.c
   Math64.c                   | RVCT
+  Math64.c                   | RVCT
   Arm/SwitchStack.asm        | RVCT
   Arm/SetJumpLongJump.asm    | RVCT
 …
   Arm/CpuBreakpoint.asm      | RVCT
   Arm/MemoryFence.asm        | RVCT
   Arm/Math64.S                  | GCC
   Arm/SwitchStack.S             | GCC

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/BitField.c

-              r58459
+              r58466
+{
   //
   // Higher bits in OrData those are not used must be zero.
+  // Higher bits in OrData those are not used must be zero.
   //
   // EndBit - StartBit + 1 might be 32 while the result right shifting 32 on a 32bit integer is undefined,
 …
   //
   ASSERT ((OrData >> (EndBit - StartBit)) == ((OrData >> (EndBit - StartBit)) & 1));
   //
   // ~((UINTN)-2 << EndBit) is a mask in which bit[0] thru bit[EndBit]
 …
+{
   //
   // Higher bits in AndData those are not used must be zero.
+  // Higher bits in AndData those are not used must be zero.
   //
   // EndBit - StartBit + 1 might be 32 while the result right shifting 32 on a 32bit integer is undefined,
 …
   Performs a bitwise AND between the bit field specified by StartBit and EndBit
   in Operand and the value specified by AndData, followed by a bitwise
+  in Operand and the value specified by AndData, followed by a bitwise
   OR with value specified by OrData. All other bits in Operand are
   preserved. The new 8-bit value is returned.
 …
   Performs a bitwise AND between the bit field specified by StartBit and EndBit
   in Operand and the value specified by AndData, followed by a bitwise
+  in Operand and the value specified by AndData, followed by a bitwise
   OR with value specified by OrData. All other bits in Operand are
   preserved. The new 16-bit value is returned.
 …
   Performs a bitwise AND between the bit field specified by StartBit and EndBit
   in Operand and the value specified by AndData, followed by a bitwise
+  in Operand and the value specified by AndData, followed by a bitwise
   OR with value specified by OrData. All other bits in Operand are
   preserved. The new 32-bit value is returned.
 …
   ASSERT (StartBit <= EndBit);
   //
   // Higher bits in OrData those are not used must be zero.
+  // Higher bits in OrData those are not used must be zero.
   //
   // EndBit - StartBit + 1 might be 64 while the result right shifting 64 on RShiftU64() API is invalid,
 …
   UINT64  Value1;
   UINT64  Value2;
   ASSERT (EndBit < 64);
   ASSERT (StartBit <= EndBit);
   //
   // Higher bits in AndData those are not used must be zero.
+  // Higher bits in AndData those are not used must be zero.
   //
   // EndBit - StartBit + 1 might be 64 while the right shifting 64 on RShiftU64() API is invalid,
 …
   Performs a bitwise AND between the bit field specified by StartBit and EndBit
   in Operand and the value specified by AndData, followed by a bitwise
+  in Operand and the value specified by AndData, followed by a bitwise
   OR with value specified by OrData. All other bits in Operand are
   preserved. The new 64-bit value is returned.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/CheckSum.c

r48674	r58466
50	50	Sum = (UINT8) (Sum + *(Buffer + Count));
51	51	}
52
	52
53	53	return Sum;
54	54	}
…	…
129	129	Sum = (UINT16) (Sum + *(Buffer + Count));
130	130	}
131
	131
132	132	return Sum;
133	133	}
…	…
211	211	Sum = Sum + *(Buffer + Count);
212	212	}
213
	213
214	214	return Sum;
215	215	}
…	…
293	293	Sum = Sum + *(Buffer + Count);
294	294	}
295
	295
296	296	return Sum;
297	297	}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/ChkStkGcc.c

r48674	r58466
18	18	Hack function for passing GCC build.
19	19	**/
20		VOID
21		__chkstk()
	20	VOID
	21	__chkstk()
22	22	{
23	23	}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/DivS64x64Remainder.c

r48674	r58466
28	28
29	29	It is the caller's responsibility to not call this function with a Divisor of 0.
30		If Divisor is 0, then the quotient and remainder should be assumed to be
	30	If Divisor is 0, then the quotient and remainder should be assumed to be
31	31	the largest negative integer.
32	32

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ia32/DivU64x64Remainder.S

-              r58459
+              r58466
     jnz     L2
     divl    %ebx
     movl    %eax, %ebx                  # ebx <- quotient
     movl    28(%esp), %ecx              # ecx <- high dword of divisor
+    movl    %eax, %ebx                  # ebx <- quotient
+    movl    28(%esp), %ecx              # ecx <- high dword of divisor
     mull    24(%esp)                    # edx:eax <- quotient * divisor[0..31]
     imull   %ebx, %ecx                  # ecx <- quotient * divisor[32..63]
     addl    %ecx, %edx                  # edx <- (quotient * divisor)[32..63]
     mov     32(%esp), %ecx              # ecx <- addr for Remainder
     jc      TooLarge                    # product > 2^64
     cmpl    %edx, %edi                  # compare high 32 bits
     ja      Correct
     jb      TooLarge                    # product > dividend
     cmpl    %eax, %esi
     jae     Correct                     # product <= dividend
+    imull   %ebx, %ecx                  # ecx <- quotient * divisor[32..63]
+    addl    %ecx, %edx                  # edx <- (quotient * divisor)[32..63]
+    mov     32(%esp), %ecx              # ecx <- addr for Remainder
+    jc      TooLarge                    # product > 2^64
+    cmpl    %edx, %edi                  # compare high 32 bits
+    ja      Correct
+    jb      TooLarge                    # product > dividend
+    cmpl    %eax, %esi
+    jae     Correct                     # product <= dividend
 TooLarge:
     decl    %ebx                        # adjust quotient by -1
     jecxz   Return                      # return if Remainder == NULL
     sub     24(%esp), %eax
+    decl    %ebx                        # adjust quotient by -1
+    jecxz   Return                      # return if Remainder == NULL
+    sub     24(%esp), %eax
     sbb     28(%esp), %edx              # edx:eax <- (quotient - 1) * divisor
 Correct:
 …
     movl    %edi, 4(%ecx)
 Return:
     movl    %ebx, %eax                  # eax <- quotient
+    movl    %ebx, %eax                  # eax <- quotient
     xorl    %edx, %edx                  # quotient is 32 bits long
     pop     %edi

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ia32/EnableCache.S

r48674	r58466
16	16	# Abstract:
17	17	#
18		# Flush all caches with a WBINVD instruction, clear the CD bit of CR0 to 0, and clear
	18	# Flush all caches with a WBINVD instruction, clear the CD bit of CR0 to 0, and clear
19	19	# the NW bit of CR0 to 0
20	20	#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ia32/EnableCache.asm

r48674	r58466
16	16	; Abstract:
17	17	;
18		; Flush all caches with a WBINVD instruction, clear the CD bit of CR0 to 0, and clear
	18	; Flush all caches with a WBINVD instruction, clear the CD bit of CR0 to 0, and clear
19	19	; the NW bit of CR0 to 0
20	20	;

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ia32/GccInline.c

-              r48674
+              r58466
 /** @file
   GCC inline implementation of BaseLib processor specific functions.
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
 …
+{
   // This is a little bit of overkill and it is more about the compiler that it is
   // actually processor synchronization. This is like the _ReadWriteBarrier
+  // actually processor synchronization. This is like the _ReadWriteBarrier
   // Microsoft specific intrinsic
   __asm__ __volatile__ ("":::"memory");
 …
   VOID
+  )
+{
+{
   __asm__ __volatile__ ("cli"::: "memory");
+}
 …
+{
   UINT64 Data;
   __asm__ __volatile__ (
     "rdmsr"
 …
     : "c"  (Index)  // %1
     );
   return Data;
+}
 …
       "A" (Value)
     );
   return Value;
+}
 …
+{
   UINTN Eflags;
   __asm__ __volatile__ (
     "pushfl     \n\t"
 …
     : "=r" (Eflags)
     );
   return Eflags;
+}
 …
+{
   UINTN   Data;
   __asm__ __volatile__ (
     "movl %%cr0,%0"
+  __asm__ __volatile__ (
+    "movl %%cr0,%0"
     : "=a" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%cr2, %0"
+  __asm__ __volatile__ (
+    "movl %%cr2, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%cr3, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%cr4, %0"
     : "=a" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%dr0, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%dr1, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%dr2, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%dr3, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%dr4, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%dr5, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%dr6, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "movl %%dr7, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov   %%cs, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov  %%ds, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov  %%es, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov  %%fs, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov  %%gs, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov  %%ds, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "str  %0"
     : "=a" (Data)
     );
   return Data;
+}
 …
     : "m" (*Gdtr)
     );
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "sldt  %0"
     : "=g" (Data)   // %0
     );
   return Data;
+}
 …
+    :
     : "m" (*Buffer)  // %0
     );
+    );
+}
 …
     : "=A"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=A"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=A"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=A"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=A"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=A"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=A"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=A"  (Data)       // %0
     );
   return Data;
+}
 …
   __asm__ __volatile__ (
     "movq %0, %%mm0"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movq %0, %%mm1"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movq %0, %%mm2"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movq %0, %%mm3"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movq %0, %%mm4"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movq %0, %%mm5"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movq %0, %%mm6"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movq %0, %%mm7"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
+{
   UINT64  Data;
   __asm__ __volatile__ (
     "rdtsc"
     : "=A" (Data)
     );
   return Data;
+  return Data;
+}
 …
+{
   UINT64  Data;
   __asm__ __volatile__ (
     "rdpmc"
 …
     : "c"  (Index)
     );
   return Data;
+  return Data;
+}
 …
+{
   __asm__ __volatile__ ("invd":::"memory");
+}
 …
   __asm__ __volatile__ (
     "clflush (%0)"
     : "+a" (LinearAddress)
+    :
+    : "+a" (LinearAddress)
+    :
     : "memory"
     );
     return LinearAddress;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ia32/InternalSwitchStack.S

r48674	r58466
45	45	movl %eax, (%esp)
46	46	pushl $0 # keeps gdb from unwinding stack
47		jmp *8(%ebp) # call and never return
	47	jmp *8(%ebp) # call and never return
48	48

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ia32/MultU64x64.S

-              r48674
+              r58466
 #------------------------------------------------------------------------------
 ASM_PFX(InternalMathMultU64x64):
     push    %ebx
     movl    8(%esp), %ebx             # ebx <- M1[0..31]
     movl    16(%esp), %edx            # edx <- M2[0..31]
     movl    %ebx, %ecx
     movl    %edx, %eax
     imull   20(%esp), %ebx            # ebx <- M1[0..31] * M2[32..63]
     imull   12(%esp), %edx            # edx <- M1[32..63] * M2[0..31]
     addl    %edx, %ebx                # carries are abandoned
+    push    %ebx
+    movl    8(%esp), %ebx             # ebx <- M1[0..31]
+    movl    16(%esp), %edx            # edx <- M2[0..31]
+    movl    %ebx, %ecx
+    movl    %edx, %eax
+    imull   20(%esp), %ebx            # ebx <- M1[0..31] * M2[32..63]
+    imull   12(%esp), %edx            # edx <- M1[32..63] * M2[0..31]
+    addl    %edx, %ebx                # carries are abandoned
     mull    %ecx                      # edx:eax <- M1[0..31] * M2[0..31]
     addl    %ebx, %edx                # carries are abandoned
+    addl    %ebx, %edx                # carries are abandoned
     pop     %ebx
     ret

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ipf/AccessMsrDb.s

-              r48674
+              r58466
 /// @file
 ///  IPF specific Machine Specific Registers accessing functions.
 ///  This implementation uses raw data to prepresent the assembly instruction of
+///  IPF specific Machine Specific Registers accessing functions.
+///  This implementation uses raw data to prepresent the assembly instruction of
 /// mov msr[]= and mov =msr[].
 ///
 …
 AsmReadMsr::
 //
 // The follow 16 bytes stand for the bundle of
+// The follow 16 bytes stand for the bundle of
 //   mov    r8=msr[in0];;
 // since MSFT tool chain does not support mov =msr[] instruction
 …
 AsmWriteMsr::
 //
 // The follow 16 bytes stand for the bundle of
+// The follow 16 bytes stand for the bundle of
 //  mov             msr[in0] = in1
 //  mov             r8 = in1;;

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ipf/Asm.h

r48674	r58466
1		/** @file
	1	/** @file
2	2
3	3	This module contains generic macros for an assembly writer.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ipf/AsmCpuMisc.s

-              r48674
+              r58466
         // do we need the mf.a also here?
         mf.a    // wait for any IO to complete?
         // not sure if we need serialization here, just put it, in case...
         srlz.d;;
         srlz.i;;
         br.ret.dpnt    b0;;
 .endp MemoryFence

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ipf/FlushCacheRange.c

-              r48674
+              r58466
   CPU.
   Flushes the cache lines specified by Address and Length.  If Address is not aligned
   on a cache line boundary, then entire cache line containing Address is flushed.
   If Address + Length is not aligned on a cache line boundary, then the entire cache
   line containing Address + Length - 1 is flushed.  This function may choose to flush
   the entire cache if that is more efficient than flushing the specified range.  If
   Length is 0, the no cache lines are flushed.  Address is returned.
+  Flushes the cache lines specified by Address and Length.  If Address is not aligned
+  on a cache line boundary, then entire cache line containing Address is flushed.
+  If Address + Length is not aligned on a cache line boundary, then the entire cache
+  line containing Address + Length - 1 is flushed.  This function may choose to flush
+  the entire cache if that is more efficient than flushing the specified range.  If
+  Length is 0, the no cache lines are flushed.  Address is returned.
   This function is only available on IPF.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ipf/Ia64gen.h

-              r48674
+              r58466
 /** @file
+/** @file
     Register Definition for IPF.
 Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 …
 THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 #ifndef _IA64GEN_H_

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ipf/InternalFlushCacheRange.s

-              r48674
+              r58466
 //++
 // Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>
 // This program and the accompanying materials
 // are licensed and made available under the terms and conditions of the BSD License
 // which accompanies this distribution.  The full text of the license may be found at
 // http://opensource.org/licenses/bsd-license.php.
 //
 // THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 // WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 //
+// This program and the accompanying materials
+// are licensed and made available under the terms and conditions of the BSD License
+// which accompanies this distribution.  The full text of the license may be found at
+// http://opensource.org/licenses/bsd-license.php.
+//
+// THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+// WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+//
 //  Module Name:
 //    InternalFlushCacheRange.s
+//    InternalFlushCacheRange.s
 //
 //  Abstract:
 //    Assemble routine to flush cache lines
+//    Assemble routine to flush cache lines
 //
 // Revision History:
 …
 //
 //  @return Address
 //
+//
 //  VOID *
 //  EFIAPI
 …
       NESTED_SETUP (5,8,0,0)
       mov         loc2 = ar.lc
       mov         loc3 = in0                  // Start address.
       mov         loc4 = in1;;                // Length in bytes.
       cmp.eq  p6,p7 = loc4, r0;;               // If Length is zero then don't flush any cache
       (p6)  br.spnt.many DoneFlushingC;;
       add         loc4 = loc4,loc3
+      (p6)  br.spnt.many DoneFlushingC;;
+      add         loc4 = loc4,loc3
       mov         loc5 = 1;;
       sub         loc4 = loc4, loc5 ;; // the End address to flush
       dep         loc3 = r0,loc3,0,5
       dep         loc4 = r0,loc4,0,5;;
       shr         loc3 = loc3,5
+      dep         loc3 = r0,loc3,0,5
+      dep         loc4 = r0,loc4,0,5;;
+      shr         loc3 = loc3,5
       shr         loc4 = loc4,5;;    // 32 byte cache line
       sub         loc4 = loc4,loc3;; // total flush count, It should be add 1 but
                                      // the br.cloop will first execute one time
       mov         loc3 = in0
       mov         loc5 = 32
+      sub         loc4 = loc4,loc3;; // total flush count, It should be add 1 but
+                                     // the br.cloop will first execute one time
+      mov         loc3 = in0
+      mov         loc5 = 32
       mov         ar.lc = loc4;;
 StillFlushingC:
       fc          loc3;;
+      fc          loc3;;
       sync.i;;
       srlz.i;;
 …
       br.cloop.sptk.few StillFlushingC;;
 DoneFlushingC:
       mov         ar.lc = loc2
+DoneFlushingC:
+      mov         ar.lc = loc2
       mov          r8   = in0       // return *Address
       NESTED_RETURN

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ipf/ReadCr.s

r48674	r58466
94	94	(p49) mov ret0=cr.lrr0 // cr80
95	95	(p50) mov ret0=cr.lrr1 // cr81
96
	96
97	97	//
98	98	// Restore predicates and return.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/Ipf/SwitchStack.s

-              r48674
+              r58466
         mov                 r18 = in2
         and                 r2  = r14, r2
         flushrs
         mov                 ar.rsc = r2
         mov                 sp  = in3

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/LinkedList.c

-              r58459
+              r58466
   If List->backLink is NULL, then ASSERT().
   If Node is NULL, then ASSERT().
   If PcdVerifyNodeInList is TRUE and DoMembershipCheck is TRUE and Node
+  If PcdVerifyNodeInList is TRUE and DoMembershipCheck is TRUE and Node
   is in not a member of List, then return FALSE
   If PcdMaximumLinkedListLength is not zero, and List contains more than
 …
   @param  List              A pointer to a node in a linked list.
   @param  Node              A pointer to a node in a linked list.
   @param  VerifyNodeInList  TRUE if a check should be made to see if Node is a
                             member of List.  FALSE if no membership test should
+  @param  VerifyNodeInList  TRUE if a check should be made to see if Node is a
+                            member of List.  FALSE if no membership test should
                             be performed.
   @retval   TRUE if PcdVerifyNodeInList is FALSE
   @retval   TRUE if DoMembershipCheck is FALSE
   @retval   TRUE if PcdVerifyNodeInList is TRUE and DoMembershipCheck is TRUE
+  @retval   TRUE if PcdVerifyNodeInList is TRUE and DoMembershipCheck is TRUE
             and Node is a member of List.
   @retval   FALSE if PcdVerifyNodeInList is TRUE and DoMembershipCheck is TRUE
+  @retval   FALSE if PcdVerifyNodeInList is TRUE and DoMembershipCheck is TRUE
             and Node is in not a member of List.
 …
   if (FeaturePcdGet (PcdVerifyNodeInList) && VerifyNodeInList) {
     //
     // Check to see if Node is a member of List.
+    // Check to see if Node is a member of List.
     // Exit early if the number of nodes in List >= PcdMaximumLinkedListLength
     //
 …
+        }
+      }
     } while ((Ptr != List) && (Ptr != Node));
+    } while ((Ptr != List) && (Ptr != Node));
     if (Ptr != Node) {
 …
   //
   ASSERT (InternalBaseLibIsNodeInList (ListHead, Entry, FALSE));
   Entry->ForwardLink = ListHead->ForwardLink;
   Entry->BackLink = ListHead;
 …
   If ListHead is NULL, then ASSERT().
   If Entry is NULL, then ASSERT().
   If ListHead was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or
+  If ListHead was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or
   InitializeListHead(), then ASSERT().
   If PcdMaximumLinkedListLength is not zero, and prior to insertion the number
 …
   //
   ASSERT (InternalBaseLibIsNodeInList (ListHead, Entry, FALSE));
   Entry->ForwardLink = ListHead;
   Entry->BackLink = ListHead->BackLink;
 …
   Retrieves the first node of a doubly-linked list.
   Returns the first node of a doubly-linked list.  List must have been
+  Returns the first node of a doubly-linked list.  List must have been
   initialized with INTIALIZE_LIST_HEAD_VARIABLE() or InitializeListHead().
   If List is empty, then List is returned.
   If List is NULL, then ASSERT().
   If List was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or
+  If List was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or
   InitializeListHead(), then ASSERT().
   If PcdMaximumLinkedListLength is not zero, and the number of nodes
 …
   Retrieves the next node of a doubly-linked list.
   Returns the node of a doubly-linked list that follows Node.
+  Returns the node of a doubly-linked list that follows Node.
   List must have been initialized with INTIALIZE_LIST_HEAD_VARIABLE()
   or InitializeListHead().  If List is empty, then List is returned.
 …
   If List is NULL, then ASSERT().
   If Node is NULL, then ASSERT().
   If List was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or
+  If List was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or
   InitializeListHead(), then ASSERT().
   If PcdMaximumLinkedListLength is not zero, and List contains more than
 …
 /**
   Retrieves the previous node of a doubly-linked list.
   Returns the node of a doubly-linked list that precedes Node.
+  Returns the node of a doubly-linked list that precedes Node.
   List must have been initialized with INTIALIZE_LIST_HEAD_VARIABLE()
   or InitializeListHead().  If List is empty, then List is returned.
   If List is NULL, then ASSERT().
   If Node is NULL, then ASSERT().
   If List was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or
+  If List was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or
   InitializeListHead(), then ASSERT().
   If PcdMaximumLinkedListLength is not zero, and List contains more than
   PcdMaximumLinkedListLength nodes, then ASSERT().
   If PcdVerifyNodeInList is TRUE and Node is not a node in List, then ASSERT().
   @param  List  A pointer to the head node of a doubly-linked list.
   @param  Node  A pointer to a node in the doubly-linked list.
   @return A pointer to the previous node if one exists. Otherwise List is returned.
 **/
 LIST_ENTRY *
 …
   //
   ASSERT (InternalBaseLibIsNodeInList (List, Node, TRUE));
   return Node->BackLink;
+}
 …
   If ListHead is NULL, then ASSERT().
   If ListHead was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or
+  If ListHead was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or
   InitializeListHead(), then ASSERT().
   If PcdMaximumLinkedListLength is not zero, and the number of nodes
 …
   //
   ASSERT (InternalBaseLibIsNodeInList (ListHead, ListHead, FALSE));
   return (BOOLEAN)(ListHead->ForwardLink == ListHead);
+}
 …
   If List is NULL, then ASSERT().
   If Node is NULL, then ASSERT().
   If List was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or InitializeListHead(),
+  If List was not initialized with INTIALIZE_LIST_HEAD_VARIABLE() or InitializeListHead(),
   then ASSERT().
   If PcdMaximumLinkedListLength is not zero, and the number of nodes
   in List, including the List node, is greater than or equal to
   PcdMaximumLinkedListLength, then ASSERT().
   If PcdVerifyNodeInList is TRUE and Node is not a node in List and Node is not
+  If PcdVerifyNodeInList is TRUE and Node is not a node in List and Node is not
   equal to List, then ASSERT().
 …
   //
   ASSERT (InternalBaseLibIsNodeInList (List, Node, TRUE));
   return (BOOLEAN)(Node == List);
+}
 …
   //
   ASSERT (InternalBaseLibIsNodeInList (List, Node, TRUE));
   return (BOOLEAN)(!IsNull (List, Node) && List->BackLink == Node);
+}
 …
   of the SecondEntry node in a doubly-linked list. SecondEntry must be in the
   same double linked list as FirstEntry and that double linked list must have
   been initialized with INTIALIZE_LIST_HEAD_VARIABLE() or InitializeListHead().
+  been initialized with INTIALIZE_LIST_HEAD_VARIABLE() or InitializeListHead().
   SecondEntry is returned after the nodes are swapped.
   If FirstEntry is NULL, then ASSERT().
   If SecondEntry is NULL, then ASSERT().
   If PcdVerifyNodeInList is TRUE and SecondEntry and FirstEntry are not in the
+  If PcdVerifyNodeInList is TRUE and SecondEntry and FirstEntry are not in the
   same linked list, then ASSERT().
   If PcdMaximumLinkedListLength is not zero, and the number of nodes in the
 …
   @param  FirstEntry  A pointer to a node in a linked list.
   @param  SecondEntry A pointer to another node in the same linked list.
   @return SecondEntry.
 …
   //
   ASSERT (InternalBaseLibIsNodeInList (FirstEntry, SecondEntry, TRUE));
   //
   // Ptr is the node pointed to by FirstEntry->ForwardLink
 …
+{
   ASSERT (!IsListEmpty (Entry));
   Entry->ForwardLink->BackLink = Entry->BackLink;
   Entry->BackLink->ForwardLink = Entry->ForwardLink;

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/SafeString.c

-              r58464
+              r58466
                                    If Source is NULL.
                                    If PcdMaximumUnicodeStringLength is not zero,
                                     and DestMax is greater than
+                                    and DestMax is greater than
                                     PcdMaximumUnicodeStringLength.
                                    If DestMax is 0.
 …
+{
   UINTN            SourceLen;
   ASSERT (((UINTN) Destination & BIT0) == 0);
   ASSERT (((UINTN) Source & BIT0) == 0);
 …
   @retval RETURN_SUCCESS           String is copied.
   @retval RETURN_BUFFER_TOO_SMALL  If DestMax is NOT greater than
+  @retval RETURN_BUFFER_TOO_SMALL  If DestMax is NOT greater than
                                    MIN(StrLen(Source), Length).
   @retval RETURN_INVALID_PARAMETER If Destination is NULL.
                                    If Source is NULL.
                                    If PcdMaximumUnicodeStringLength is not zero,
                                     and DestMax is greater than
+                                    and DestMax is greater than
                                     PcdMaximumUnicodeStringLength.
                                    If DestMax is 0.
 …
   @retval RETURN_SUCCESS           String is appended.
   @retval RETURN_BAD_BUFFER_SIZE   If DestMax is NOT greater than
+  @retval RETURN_BAD_BUFFER_SIZE   If DestMax is NOT greater than
                                    StrLen(Destination).
   @retval RETURN_BUFFER_TOO_SMALL  If (DestMax - StrLen(Destination)) is NOT
 …
                                    If Source is NULL.
                                    If PcdMaximumUnicodeStringLength is not zero,
                                     and DestMax is greater than
+                                    and DestMax is greater than
                                     PcdMaximumUnicodeStringLength.
                                    If DestMax is 0.
 …
   UINTN               CopyLen;
   UINTN               SourceLen;
   ASSERT (((UINTN) Destination & BIT0) == 0);
   ASSERT (((UINTN) Source & BIT0) == 0);
 …
                                    If Source is NULL.
                                    If PcdMaximumUnicodeStringLength is not zero,
                                     and DestMax is greater than
+                                    and DestMax is greater than
                                     PcdMaximumUnicodeStringLength.
                                    If DestMax is 0.
 …
   UINTN               CopyLen;
   UINTN               SourceLen;
   ASSERT (((UINTN) Destination & BIT0) == 0);
   ASSERT (((UINTN) Source & BIT0) == 0);
 …
                                    If Source is NULL.
                                    If PcdMaximumAsciiStringLength is not zero,
                                     and DestMax is greater than
+                                    and DestMax is greater than
                                     PcdMaximumAsciiStringLength.
                                    If DestMax is 0.
 …
+{
   UINTN            SourceLen;
   //
   // 1. Neither Destination nor Source shall be a null pointer.
 …
   @retval RETURN_SUCCESS           String is copied.
   @retval RETURN_BUFFER_TOO_SMALL  If DestMax is NOT greater than
+  @retval RETURN_BUFFER_TOO_SMALL  If DestMax is NOT greater than
                                    MIN(StrLen(Source), Length).
   @retval RETURN_INVALID_PARAMETER If Destination is NULL.
                                    If Source is NULL.
                                    If PcdMaximumAsciiStringLength is not zero,
                                     and DestMax is greater than
+                                    and DestMax is greater than
                                     PcdMaximumAsciiStringLength.
                                    If DestMax is 0.
 …
   @retval RETURN_SUCCESS           String is appended.
   @retval RETURN_BAD_BUFFER_SIZE   If DestMax is NOT greater than
+  @retval RETURN_BAD_BUFFER_SIZE   If DestMax is NOT greater than
                                    StrLen(Destination).
   @retval RETURN_BUFFER_TOO_SMALL  If (DestMax - StrLen(Destination)) is NOT
 …
                                    If Source is NULL.
                                    If PcdMaximumAsciiStringLength is not zero,
                                     and DestMax is greater than
+                                    and DestMax is greater than
                                     PcdMaximumAsciiStringLength.
                                    If DestMax is 0.
 …
   UINTN               CopyLen;
   UINTN               SourceLen;
   //
   // Let CopyLen denote the value DestMax - AsciiStrnLenS(Destination, DestMax) upon entry to AsciiStrCatS.
 …
                                    If Source is NULL.
                                    If PcdMaximumAsciiStringLength is not zero,
                                     and DestMax is greater than
+                                    and DestMax is greater than
                                     PcdMaximumAsciiStringLength.
                                    If DestMax is 0.
 …
   UINTN               CopyLen;
   UINTN               SourceLen;
   //
   // Let CopyLen denote the value DestMax - AsciiStrnLenS(Destination, DestMax) upon entry to AsciiStrnCatS.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/String.c

-              r58459
+              r58466
   [ATTENTION] This function will be deprecated for security reason.
   Copies up to a specified length from one Null-terminated Unicode string  to
+  Copies up to a specified length from one Null-terminated Unicode string  to
   another Null-terminated Unicode string and returns the new Unicode string.
 …
   If Length > 0 and Source is not aligned on a 16-bit boundary, then ASSERT().
   If Source and Destination overlap, then ASSERT().
   If PcdMaximumUnicodeStringLength is not zero, and Length is greater than
+  If PcdMaximumUnicodeStringLength is not zero, and Length is greater than
   PcdMaximumUnicodeStringLength, then ASSERT().
   If PcdMaximumUnicodeStringLength is not zero, and Source contains more than
 …
   Null terminator.
   This function returns the size, in bytes, of the Null-terminated Unicode string
+  This function returns the size, in bytes, of the Null-terminated Unicode string
   specified by String.
 …
   Compares up to a specified length the contents of two Null-terminated Unicode strings,
   and returns the difference between the first mismatched Unicode characters.
   This function compares the Null-terminated Unicode string FirstString to the
   Null-terminated Unicode string SecondString. At most, Length Unicode
 …
   [ATTENTION] This function will be deprecated for security reason.
   Concatenates up to a specified length one Null-terminated Unicode to the end
   of another Null-terminated Unicode string, and returns the concatenated
+  Concatenates up to a specified length one Null-terminated Unicode to the end
+  of another Null-terminated Unicode string, and returns the concatenated
   Unicode string.
 …
   If Length > 0 and Source is not aligned on a 16-bit boundary, then ASSERT().
   If Source and Destination overlap, then ASSERT().
   If PcdMaximumUnicodeStringLength is not zero, and Length is greater than
+  If PcdMaximumUnicodeStringLength is not zero, and Length is greater than
   PcdMaximumUnicodeStringLength, then ASSERT().
   If PcdMaximumUnicodeStringLength is not zero, and Destination contains more
 …
     SearchStringTmp = SearchString;
     FirstMatch = String;
     while ((*String == *SearchStringTmp)
+    while ((*String == *SearchStringTmp)
             && (*String != L'\0')) {
       String++;
       SearchStringTmp++;
+    }
+    }
     if (*SearchStringTmp == L'\0') {
       return (CHAR16 *) FirstMatch;
 …
   Check if a Unicode character is a decimal character.
   This internal function checks if a Unicode character is a
+  This internal function checks if a Unicode character is a
   decimal character. The valid decimal character is from
   L'0' to L'9'.
 …
 /**
   Convert a Unicode character to upper case only if
+  Convert a Unicode character to upper case only if
   it maps to a valid small-case ASCII character.
 …
   This internal function only deal with Unicode character
   which maps to a valid hexadecimal ASII character, i.e.
   L'0' to L'9', L'a' to L'f' or L'A' to L'F'. For other
+  L'0' to L'9', L'a' to L'f' or L'A' to L'F'. For other
   Unicode character, the value returned does not make sense.
 …
   Check if a Unicode character is a hexadecimal character.
   This internal function checks if a Unicode character is a
   decimal character.  The valid hexadecimal character is
+  This internal function checks if a Unicode character is a
+  decimal character.  The valid hexadecimal character is
   L'0' to L'9', L'a' to L'f', or L'A' to L'F'.
 …
+{
   UINTN     Result;
   //
   // ASSERT String is less long than PcdMaximumUnicodeStringLength.
 …
   while (InternalIsDecimalDigitCharacter (*String)) {
     //
     // If the number represented by String overflows according
+    // If the number represented by String overflows according
     // to the range defined by UINTN, then ASSERT().
     //
 …
     String++;
+  }
   return Result;
+}
 …
+{
   UINT64     Result;
   //
   // ASSERT String is less long than PcdMaximumUnicodeStringLength.
 …
   while (InternalIsDecimalDigitCharacter (*String)) {
     //
     // If the number represented by String overflows according
+    // If the number represented by String overflows according
     // to the range defined by UINTN, then ASSERT().
     //
 …
     String++;
+  }
   return Result;
+}
 …
   //
   ASSERT (StrSize (String) != 0);
   //
   // Ignore the pad spaces (space or tab)
+  //
+  // Ignore the pad spaces (space or tab)
   //
   while ((*String == L' ') || (*String == L'\t')) {
 …
   Result = 0;
   while (InternalIsHexaDecimalDigitCharacter (*String)) {
     //
     // If the Hex Number represented by String overflows according
+    // If the Hex Number represented by String overflows according
     // to the range defined by UINTN, then ASSERT().
     //
 …
   //
   ASSERT (StrSize (String) != 0);
   //
   // Ignore the pad spaces (space or tab)
+  //
+  // Ignore the pad spaces (space or tab)
   //
   while ((*String == L' ') || (*String == L'\t')) {
 …
   Result = 0;
   while (InternalIsHexaDecimalDigitCharacter (*String)) {
     //
     // If the Hex Number represented by String overflows according
+    // If the Hex Number represented by String overflows according
     // to the range defined by UINTN, then ASSERT().
     //
 …
   Check if a ASCII character is a decimal character.
   This internal function checks if a Unicode character is a
+  This internal function checks if a Unicode character is a
   decimal character. The valid decimal character is from
   '0' to '9'.
 …
   Check if a ASCII character is a hexadecimal character.
   This internal function checks if a ASCII character is a
   decimal character.  The valid hexadecimal character is
+  This internal function checks if a ASCII character is a
+  decimal character.  The valid hexadecimal character is
   L'0' to L'9', L'a' to L'f', or L'A' to L'F'.
 …
   while (*Source != '\0') {
     //
     // If any Unicode characters in Source contain
+    // If any Unicode characters in Source contain
     // non-zero value in the upper 8 bits, then ASSERT().
     //
 …
   [ATTENTION] This function will be deprecated for security reason.
   Copies up to a specified length one Null-terminated ASCII string to another
+  Copies up to a specified length one Null-terminated ASCII string to another
   Null-terminated ASCII string and returns the new ASCII string.
 …
   If Source is NULL, then ASSERT().
   If Source and Destination overlap, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero, and Length is greater than
+  If PcdMaximumAsciiStringLength is not zero, and Length is greater than
   PcdMaximumAsciiStringLength, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero, and Source contains more than
 …
   @param  Chr   one Ascii character
   @return The uppercase value of Ascii character
+  @return The uppercase value of Ascii character
 **/
 …
   This internal function only deal with Unicode character
   which maps to a valid hexadecimal ASII character, i.e.
   '0' to '9', 'a' to 'f' or 'A' to 'F'. For other
+  '0' to '9', 'a' to 'f' or 'A' to 'F'. For other
   ASCII character, the value returned does not make sense.
 …
   If Length > 0 and FirstString is NULL, then ASSERT().
   If Length > 0 and SecondString is NULL, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero, and Length is greater than
+  If PcdMaximumAsciiStringLength is not zero, and Length is greater than
   PcdMaximumAsciiStringLength, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero, and FirstString contains more than
 …
   @param  SecondString  A pointer to a Null-terminated ASCII string.
   @param  Length        The maximum number of ASCII characters for compare.
   @retval ==0       FirstString is identical to SecondString.
   @retval !=0       FirstString is not identical to SecondString.
 …
   [ATTENTION] This function will be deprecated for security reason.
   Concatenates up to a specified length one Null-terminated ASCII string to
   the end of another Null-terminated ASCII string, and returns the
+  Concatenates up to a specified length one Null-terminated ASCII string to
+  the end of another Null-terminated ASCII string, and returns the
   concatenated ASCII string.
 …
     SearchStringTmp = SearchString;
     FirstMatch = String;
     while ((*String == *SearchStringTmp)
+    while ((*String == *SearchStringTmp)
             && (*String != '\0')) {
       String++;
       SearchStringTmp++;
+    }
+    }
     if (*SearchStringTmp == '\0') {
       return (CHAR8 *) FirstMatch;
 …
+{
   UINTN     Result;
   //
   // ASSERT Strings is less long than PcdMaximumAsciiStringLength
 …
   while (InternalAsciiIsDecimalDigitCharacter (*String)) {
     //
     // If the number represented by String overflows according
+    // If the number represented by String overflows according
     // to the range defined by UINTN, then ASSERT().
     //
 …
     String++;
+  }
   return Result;
+}
 …
+{
   UINT64     Result;
   //
   // ASSERT Strings is less long than PcdMaximumAsciiStringLength
 …
   while (InternalAsciiIsDecimalDigitCharacter (*String)) {
     //
     // If the number represented by String overflows according
+    // If the number represented by String overflows according
     // to the range defined by UINTN, then ASSERT().
     //
 …
     String++;
+  }
   return Result;
+}
 …
   //
   ASSERT (AsciiStrSize (String) != 0);
   //
   // Ignore the pad spaces (space or tab)
+  //
+  // Ignore the pad spaces (space or tab)
   //
   while ((*String == ' ') || (*String == '\t' )) {
 …
   Result = 0;
   while (InternalAsciiIsHexaDecimalDigitCharacter (*String)) {
     //
     // If the Hex Number represented by String overflows according
+    // If the Hex Number represented by String overflows according
     // to the range defined by UINTN, then ASSERT().
     //
 …
   //
   ASSERT (AsciiStrSize (String) != 0);
   //
   // Ignore the pad spaces (space or tab) and leading Zeros
   //
   //
   // Ignore the pad spaces (space or tab)
+  // Ignore the pad spaces (space or tab)
   //
   while ((*String == ' ') || (*String == '\t' )) {
 …
   Result = 0;
   while (InternalAsciiIsHexaDecimalDigitCharacter (*String)) {
     //
     // If the Hex Number represented by String overflows according
+    // If the Hex Number represented by String overflows according
     // to the range defined by UINTN, then ASSERT().
     //

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/SwitchStack.c

-              r48674
+              r58466
   @param  NewStack    A pointer to the new stack to use for the EntryPoint
                       function.
   @param  ...         This variable argument list is ignored for IA32, x64, and EBC.
                       For IPF, this variable argument list is expected to contain
                       a single parameter of type VOID * that specifies the new backing
+  @param  ...         This variable argument list is ignored for IA32, x64, and EBC.
+                      For IPF, this variable argument list is expected to contain
+                      a single parameter of type VOID * that specifies the new backing
                       store pointer.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/CpuIdEx.S

-              r48674
+              r58466
     jz      L1
     mov     %ecx,(%r10)
 L1:
+L1:
     mov     %r8, %rcx
     jrcxz   L2
     movl    %eax,(%rcx)
 L2:
+L2:
     mov     %r9, %rcx
     jrcxz   L3
     mov     %ebx, (%rcx)
 L3:
+L3:
     mov     0x40(%rsp), %rcx
     jrcxz   L4
     mov     %edx, (%rcx)
 L4:
+L4:
     pop     %rax                  # restore Index to rax as return value
     pop     %rbx

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/DisablePaging64.S

-              r48674
+              r58466
 #------------------------------------------------------------------------------
 #------------------------------------------------------------------------------
 …
 ASM_GLOBAL ASM_PFX(InternalX86DisablePaging64)
 ASM_PFX(InternalX86DisablePaging64):
     cli
+    cli
     lea    L1(%rip), %rsi                 # rsi <- The start address of transition code
     mov    0x28(%rsp), %edi               # rdi <- New stack
 …
     add    $4, %rax                       # round rax up to the next 4 byte boundary
     and    $0xfc, %al
     sub    %rax, %rdi                     # rdi <- use stack to hold transition code
+    sub    %rax, %rdi                     # rdi <- use stack to hold transition code
     mov    %edi, %r10d                    # r10 <- The start address of transicition code below 4G
     push   %rcx                           # save rcx to stack
 …
     movsb                                 # copy transition code to (new stack - 64byte) below 4G
     pop    %rcx                           # restore rcx
     mov    %r8d, %esi
     mov    %r9d, %edi
+    mov    %r8d, %esi
+    mov    %r9d, %edi
     mov    %r10d, %eax
     sub    $4, %eax
     push   %rcx                           # push Cs to stack
     push   %r10                           # push address of transition code on stack
+    push   %r10                           # push address of transition code on stack
     .byte  0x48, 0xcb                     # retq: Use far return to load CS register from stack
                                           # (Use raw byte code since some GNU assemblers generates incorrect code for "retq")
+                                          # (Use raw byte code since some GNU assemblers generates incorrect code for "retq")
 L1:
     mov    %eax,%esp                      # set up new stack
 …
     mov    %edx,%ebx                      # save EntryPoint to ebx, for rdmsr will overwrite edx
     mov    $0xc0000080,%ecx
     rdmsr
+    rdmsr
     and    $0xfe,%ah                      # clear LME
     wrmsr
+    wrmsr
     mov    %cr4,%rax
     and    $0xdf,%al                      # clear PAE

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/DisablePaging64.asm

-              r48674
+              r58466
     mov     edi, [rsp + 28h]            ; rdi <- New stack
     lea     rax, mTransitionEnd         ; rax <- end of transition code
     sub     rax, rsi                    ; rax <- The size of transition piece code
+    sub     rax, rsi                    ; rax <- The size of transition piece code
     add     rax, 4                      ; Round RAX up to the next 4 byte boundary
     and     al, 0fch
 …
     rep     movsb                       ; copy transition code to top of new stack which must be below 4GB
     pop     rcx                         ; restore rcx
     mov     esi, r8d
     mov     edi, r9d
 …
     btr     eax, 31                     ; Clear CR0.PG
     mov     cr0, rax                    ; disable paging and caches
     mov     ebx, edx                    ; save EntryPoint to rbx, for rdmsr will overwrite rdx
     mov     ecx, 0c0000080h

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/EnableCache.S

r48674	r58466
16	16	# Abstract:
17	17	#
18		# Flush all caches with a WBINVD instruction, clear the CD bit of CR0 to 0, and clear
	18	# Flush all caches with a WBINVD instruction, clear the CD bit of CR0 to 0, and clear
19	19	# the NW bit of CR0 to 0
20	20	#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/EnableCache.asm

r48674	r58466
16	16	; Abstract:
17	17	;
18		; Flush all caches with a WBINVD instruction, clear the CD bit of CR0 to 0, and clear
	18	; Flush all caches with a WBINVD instruction, clear the CD bit of CR0 to 0, and clear
19	19	; the NW bit of CR0 to 0
20	20	;

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/FlushCacheLine.asm

r48674	r58466
26	26	;------------------------------------------------------------------------------
27	27	; VOID *
28		; EFIAPI
	28	; EFIAPI
29	29	; AsmFlushCacheLine (
30	30	; IN VOID *LinearAddress

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/GccInline.c

-              r48674
+              r58466
 /** @file
   GCC inline implementation of BaseLib processor specific functions.
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
+  Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
 …
+{
   // This is a little bit of overkill and it is more about the compiler that it is
   // actually processor synchronization. This is like the _ReadWriteBarrier
+  // actually processor synchronization. This is like the _ReadWriteBarrier
   // Microsoft specific intrinsic
   __asm__ __volatile__ ("":::"memory");
 …
   VOID
+  )
+{
+{
   __asm__ __volatile__ ("cli"::: "memory");
+}
 …
   UINT32 LowData;
   UINT32 HighData;
   __asm__ __volatile__ (
     "rdmsr"
 …
     : "c"  (Index)      // %2
     );
   return (((UINT64)HighData) << 32) | LowData;
+}
 …
   LowData  = (UINT32)(Value);
   HighData = (UINT32)(Value >> 32);
   __asm__ __volatile__ (
     "wrmsr"
 …
       "d" (HighData)
     );
   return Value;
+}
 …
+{
   UINTN Eflags;
   __asm__ __volatile__ (
     "pushfq         \n\t"
 …
     : "=r" (Eflags)       // %0
     );
   return Eflags;
+}
 …
+{
   UINTN   Data;
   __asm__ __volatile__ (
     "mov  %%cr0,%0"
+  __asm__ __volatile__ (
+    "mov  %%cr0,%0"
     : "=r" (Data)           // %0
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%cr2,  %0"
+  __asm__ __volatile__ (
+    "mov  %%cr2,  %0"
     : "=r" (Data)           // %0
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%cr3,  %0"
+  __asm__ __volatile__ (
+    "mov  %%cr3,  %0"
     : "=r" (Data)           // %0
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%cr4,  %0"
+  __asm__ __volatile__ (
+    "mov  %%cr4,  %0"
     : "=r" (Data)           // %0
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%dr0, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%dr1, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%dr2, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%dr3, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%dr4, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%dr5, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%dr6, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINTN Data;
   __asm__ __volatile__ (
     "mov  %%dr7, %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov   %%cs, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov  %%ds, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov  %%es, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov  %%fs, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov  %%gs, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "mov  %%ds, %0"
     :"=a" (Data)
     );
   return Data;
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "str  %0"
     : "=r" (Data)
     );
   return Data;
+}
 …
     : "m" (*Gdtr)
     );
+}
 …
+{
   UINT16  Data;
   __asm__ __volatile__ (
     "sldt  %0"
     : "=g" (Data)   // %0
     );
   return Data;
+}
 …
+    :
     : "m" (*Buffer)  // %0
     );
+    );
+}
 …
     : "=r"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=r"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=r"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=r"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=r"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=r"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=r"  (Data)       // %0
     );
   return Data;
+}
 …
     : "=r"  (Data)       // %0
     );
   return Data;
+}
 …
   __asm__ __volatile__ (
     "movd  %0, %%mm0"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movd  %0, %%mm1"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movd  %0, %%mm2"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movd  %0, %%mm3"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movd  %0, %%mm4"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movd  %0, %%mm5"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movd  %0, %%mm6"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   __asm__ __volatile__ (
     "movd  %0, %%mm7"  // %0
+    :
+    :
     : "m" (Value)
     );
 …
   UINT32  LowData;
   UINT32  HiData;
   __asm__ __volatile__ (
     "rdtsc"
 …
       "=d" (HiData)
     );
   return (((UINT64)HiData) << 32) | LowData;
+  return (((UINT64)HiData) << 32) | LowData;
+}
 …
   UINT32  LowData;
   UINT32  HiData;
   __asm__ __volatile__ (
     "rdpmc"
 …
     : "c"  (Index)
     );
   return (((UINT64)HiData) << 32) | LowData;
+  return (((UINT64)HiData) << 32) | LowData;
+}
 …
       "d" (Edx)
     );
   return Eax;
+}
 …
   __asm__ __volatile__ (
     "mwait"
+    :
+    :
     : "a"  (Eax),
       "c"  (Ecx)
     );
   return Eax;
+  return Eax;
+}
 …
+{
   __asm__ __volatile__ ("invd":::"memory");
+}
 …
     "clflush (%0)"
+    :
     : "r" (LinearAddress)
+    : "r" (LinearAddress)
     : "memory"
     );
     return LinearAddress;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/LongJump.S

r48674	r58466
50	50	movdqu 0xC8(%rcx), %xmm13
51	51	movdqu 0xD8(%rcx), %xmm14
52		movdqu 0xE8(%rcx), %xmm15
	52	movdqu 0xE8(%rcx), %xmm15
53	53	mov %rdx, %rax # set return value
54	54	jmp *0x48(%rcx)

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/SetJump.S

-              r48674
+              r58466
     # save non-volatile fp registers
     stmxcsr 0x50(%rcx)
     movdqu  %xmm6, 0x58(%rcx)
+    movdqu  %xmm6, 0x58(%rcx)
     movdqu  %xmm7, 0x68(%rcx)
     movdqu  %xmm8, 0x78(%rcx)
 …
     movdqu  %xmm13, 0xC8(%rcx)
     movdqu  %xmm14, 0xD8(%rcx)
     movdqu  %xmm15, 0xE8(%rcx)
+    movdqu  %xmm15, 0xE8(%rcx)
     xor    %rax,%rax
     jmpq   *%rdx

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/SwitchStack.S

-              r48674
+              r58466
 ASM_GLOBAL ASM_PFX(InternalSwitchStack)
 ASM_PFX(InternalSwitchStack):
           pushq   %rbp
+          pushq   %rbp
         movq    %rsp, %rbp
     mov     %rcx, %rax  // Shift registers for new call
     mov     %rdx, %rcx

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/Thunk16.S

-              r58459
+              r58466
     .data
 .set Lm16Size, ASM_PFX(InternalAsmThunk16) - ASM_PFX(m16Start)
 ASM_PFX(m16Size):         .word      Lm16Size
 …
     .byte 0x66
     call    L_Base                       # push eip
 L_Base:
+L_Base:
     .byte 0x66
     pushq   $0                          # reserved high order 32 bits of EFlags
 …
     cli                                 # disable interrupts
     jnc     L_2
 L_1:
+L_1:
     testb   $THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL, %dl
     jz      L_2
 …
     orb     $2,%al
     outb    %al, $0x92                   # deactivate A20M#
 L_2:
+L_2:
     xorw    %ax, %ax                     # xor eax, eax
     movl    %ss, %eax                    # mov ax, ss
 …
     .byte 0x66                          # make the following call 32-bit
     call    L_Base1                       # push eip
 L_Base1:
+L_Base1:
     popw    %bp                         # ebp <- address of L_Base1
     pushq   (IA32_REGS_SIZE + 2)(%esp)
 …
     pushq   %rax
     lret                                # execution begins at next instruction
 L_RealMode:
+L_RealMode:
     .byte 0x66,0x2e                     # CS and operand size override
     lidt    (_16Idtr - L_Base1)(%rsi)
 …
     pushq   %rsi
     pushq   %rdi
     movl    %ds, %ebx
     pushq   %rbx      # Save ds segment register on the stack
 …
     movl    _ESP(%rsi), %edi
     lea     -(IA32_REGS_SIZE + 4)(%edi), %rdi
     imul    $16, %r8d, %eax
+    imul    $16, %r8d, %eax
     movl    %edi,%ebx                   # ebx <- stack for 16-bit code
     pushq   $(IA32_REGS_SIZE / 4)
 …
     andl    $0xf,%edx
     shll    $12,%eax                    # segment address in high order 16 bits
     .set LBackFromUserCodeDelta, ASM_PFX(BackFromUserCode) - ASM_PFX(m16Start)
+    .set LBackFromUserCodeDelta, ASM_PFX(BackFromUserCode) - ASM_PFX(m16Start)
     lea     (LBackFromUserCodeDelta)(%rdx), %ax
     stosl                               # [edi] <- return address of user code
     sgdt    0x60(%rsp)                  # save GDT stack in argument space
     movzwq  0x60(%rsp), %r10            # r10 <- GDT limit
     lea     ((ASM_PFX(InternalAsmThunk16) - L_SavedCr4) + 0xf)(%rcx), %r11
     andq    $0xfffffffffffffff0, %r11   # r11 <- 16-byte aligned shadowed GDT table in real mode buffer
+    movzwq  0x60(%rsp), %r10            # r10 <- GDT limit
+    lea     ((ASM_PFX(InternalAsmThunk16) - L_SavedCr4) + 0xf)(%rcx), %r11
+    andq    $0xfffffffffffffff0, %r11   # r11 <- 16-byte aligned shadowed GDT table in real mode buffer
     movw    %r10w, (SavedGdt - L_SavedCr4)(%rcx)       # save the limit of shadowed GDT table
     movq    %r11, (SavedGdt - L_SavedCr4 + 0x2)(%rcx)  # save the base address of shadowed GDT table
     movq    0x62(%rsp) ,%rsi            # rsi <- the original GDT base address
     xchg   %r10, %rcx                   # save rcx to r10 and initialize rcx to be the limit of GDT table
+    xchg   %r10, %rcx                   # save rcx to r10 and initialize rcx to be the limit of GDT table
     incq   %rcx                         # rcx <- the size of memory to copy
     xchg   %r11, %rdi                   # save rdi to r11 and initialize rdi to the base address of shadowed GDT table
 …
     movq   %r10, %rcx                   # restore the orignal rcx before memory copy
     movq   %r11, %rdi                   # restore the original rdi before memory copy
     sidt    0x50(%rsp)
     movq    %cr0, %rax
 …
     .set    Ltemp1, _EntryPoint - L_SavedCr4
     .byte   Ltemp1
 L_RetFromRealMode:
+L_RetFromRealMode:
     popfq
     lgdt    0x60(%rsp)                  # restore protected mode GDTR
 …
     .byte 0x0f, 0xa9                    # pop gs
     .byte 0x0f, 0xa1                    # pop fs
     popq     %rbx
     movl     %ebx, %ss
 …
     popq     %rbx
     movl     %ebx, %ds
     popq    %rdi
     popq    %rsi

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/Thunk16.asm

-              r58459
+              r58466
 SavedCs     DW      ?
 @64BitCode:
     db      090h
+    db      090h
     db      048h, 0bch                 ; mov rsp, imm64
 SavedSp     DQ   ?                     ; restore stack
 …
     mov     rbx, ss
     push    rbx          ; Save ss segment register on the stack
     push    fs
     push    gs
 …
     lea     ax, [rdx + (_BackFromUserCode - m16Start)]  ; offset address
     stosd                               ; [edi] <- return address of user code
     sgdt    fword ptr [rsp + 60h]       ; save GDT stack in argument space
     movzx   r10, word ptr [rsp + 60h]   ; r10 <- GDT limit
+    movzx   r10, word ptr [rsp + 60h]   ; r10 <- GDT limit
     lea     r11, [rcx + (InternalAsmThunk16 - SavedCr4) + 0xf]
     and     r11, 0xfffffff0             ; r11 <- 16-byte aligned shadowed GDT table in real mode buffer
     mov     word ptr [rcx + (SavedGdt - SavedCr4)], r10w      ; save the limit of shadowed GDT table
     mov     qword ptr [rcx + (SavedGdt - SavedCr4) + 2], r11  ; save the base address of shadowed GDT table
     mov     rsi, qword ptr [rsp + 62h]  ; rsi <- the original GDT base address
     xchg    rcx, r10                    ; save rcx to r10 and initialize rcx to be the limit of GDT table
 …
     mov     rcx, r10                    ; restore the orignal rcx before memory copy
     mov     rdi, r11                    ; restore the original rdi before memory copy
     sidt    fword ptr [rsp + 50h]       ; save IDT stack in argument space
     mov     rax, cr0

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X64/Thunk16.nasm

-              r58464
+              r58466
     push    rsi
     push    rdi
     mov     ebx, ds
     push    rbx          ; Save ds segment register on the stack
 …
     mov     ebx, ss
     push    rbx          ; Save ss segment register on the stack
     push    fs
     push    gs
 …
     lea     ax, [rdx + (_BackFromUserCode - ASM_PFX(m16Start))]  ; offset address
     stosd                               ; [edi] <- return address of user code
     sgdt    [rsp + 60h]       ; save GDT stack in argument space
     movzx   r10, word [rsp + 60h]   ; r10 <- GDT limit
+    movzx   r10, word [rsp + 60h]   ; r10 <- GDT limit
     lea     r11, [rcx + (ASM_PFX(InternalAsmThunk16) - _BackFromUserCode.SavedCr4End) + 0xf]
     and     r11, ~0xf            ; r11 <- 16-byte aligned shadowed GDT table in real mode buffer
     mov     [rcx + (SavedGdt - _BackFromUserCode.SavedCr4End)], r10w      ; save the limit of shadowed GDT table
     mov     [rcx + (SavedGdt - _BackFromUserCode.SavedCr4End) + 2], r11  ; save the base address of shadowed GDT table
     mov     rsi, [rsp + 62h]  ; rsi <- the original GDT base address
     xchg    rcx, r10                    ; save rcx to r10 and initialize rcx to be the limit of GDT table
 …
     mov     rcx, r10                    ; restore the orignal rcx before memory copy
     mov     rdi, r11                    ; restore the original rdi before memory copy
     sidt    [rsp + 50h]       ; save IDT stack in argument space
     mov     rax, cr0

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X86Msr.c

-              r58459
+              r58466
   field is specified by the StartBit and the EndBit. All other bits in the
   destination MSR are preserved. The lower 32-bits of the MSR written is
   returned. The caller must either guarantee that Index and the data written
   is valid, or the caller must set up exception handlers to catch the exceptions.
+  returned. The caller must either guarantee that Index and the data written
+  is valid, or the caller must set up exception handlers to catch the exceptions.
   This function is only available on IA-32 and x64.
 …
 /**
   Reads a 64-bit MSR, performs a bitwise AND followed by a bitwise
+  Reads a 64-bit MSR, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 64-bit MSR.
 …
   Writes Value to a bit field in a 64-bit MSR. The bit field is specified by
   the StartBit and the EndBit. All other bits in the destination MSR are
   preserved. The MSR written is returned. The caller must either guarantee
   that Index and the data written is valid, or the caller must set up exception
+  preserved. The MSR written is returned. The caller must either guarantee
+  that Index and the data written is valid, or the caller must set up exception
   handlers to catch the exceptions. This function is only available on IA-32 and x64.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseLib/X86Thunk.c

-              r58459
+              r58466
   Prepares all structures and code required to use AsmThunk16().
   This interface is limited to be used in either physical mode or virtual modes with paging enabled where the
   virtual to physical mappings for ThunkContext.RealModeBuffer is mapped 1:1.
 …
   This function must be called with interrupts disabled.
   The register state from the RealModeState field of ThunkContext is restored just prior
   to calling the 16-bit real mode entry point.  This includes the EFLAGS field of RealModeState,
+  The register state from the RealModeState field of ThunkContext is restored just prior
+  to calling the 16-bit real mode entry point.  This includes the EFLAGS field of RealModeState,
   which is used to set the interrupt state when a 16-bit real mode entry point is called.
   Control is transferred to the 16-bit real mode entry point specified by the CS and Eip fields of RealModeState.
   The stack is initialized to the SS and ESP fields of RealModeState.  Any parameters passed to
   the 16-bit real mode code must be populated by the caller at SS:ESP prior to calling this function.
+  The stack is initialized to the SS and ESP fields of RealModeState.  Any parameters passed to
+  the 16-bit real mode code must be populated by the caller at SS:ESP prior to calling this function.
   The 16-bit real mode entry point is invoked with a 16-bit CALL FAR instruction,
   so when accessing stack contents, the 16-bit real mode code must account for the 16-bit segment
   and 16-bit offset of the return address that were pushed onto the stack. The 16-bit real mode entry
   point must exit with a RETF instruction. The register state is captured into RealModeState immediately
+  so when accessing stack contents, the 16-bit real mode code must account for the 16-bit segment
+  and 16-bit offset of the return address that were pushed onto the stack. The 16-bit real mode entry
+  point must exit with a RETF instruction. The register state is captured into RealModeState immediately
   after the RETF instruction is executed.
   If EFLAGS specifies interrupts enabled, or any of the 16-bit real mode code enables interrupts,
   or any of the 16-bit real mode code makes a SW interrupt, then the caller is responsible for making sure
   the IDT at address 0 is initialized to handle any HW or SW interrupts that may occur while in 16-bit real mode.
   If EFLAGS specifies interrupts enabled, or any of the 16-bit real mode code enables interrupts,
   then the caller is responsible for making sure the 8259 PIC is in a state compatible with 16-bit real mode.
+  If EFLAGS specifies interrupts enabled, or any of the 16-bit real mode code enables interrupts,
+  or any of the 16-bit real mode code makes a SW interrupt, then the caller is responsible for making sure
+  the IDT at address 0 is initialized to handle any HW or SW interrupts that may occur while in 16-bit real mode.
+  If EFLAGS specifies interrupts enabled, or any of the 16-bit real mode code enables interrupts,
+  then the caller is responsible for making sure the 8259 PIC is in a state compatible with 16-bit real mode.
   This includes the base vectors, the interrupt masks, and the edge/level trigger mode.
   If THUNK_ATTRIBUTE_BIG_REAL_MODE is set in the ThunkAttributes field of ThunkContext, then the user code
+  If THUNK_ATTRIBUTE_BIG_REAL_MODE is set in the ThunkAttributes field of ThunkContext, then the user code
   is invoked in big real mode.  Otherwise, the user code is invoked in 16-bit real mode with 64KB segment limits.
   If neither THUNK_ATTRIBUTE_DISABLE_A20_MASK_INT_15 nor THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL are set in
   ThunkAttributes, then it is assumed that the user code did not enable the A20 mask, and no attempt is made to
+  If neither THUNK_ATTRIBUTE_DISABLE_A20_MASK_INT_15 nor THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL are set in
+  ThunkAttributes, then it is assumed that the user code did not enable the A20 mask, and no attempt is made to
   disable the A20 mask.
   If THUNK_ATTRIBUTE_DISABLE_A20_MASK_INT_15 is set and THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL is clear in
   ThunkAttributes, then attempt to use the INT 15 service to disable the A20 mask.  If this INT 15 call fails,
+  If THUNK_ATTRIBUTE_DISABLE_A20_MASK_INT_15 is set and THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL is clear in
+  ThunkAttributes, then attempt to use the INT 15 service to disable the A20 mask.  If this INT 15 call fails,
   then attempt to disable the A20 mask by directly accessing the 8042 keyboard controller I/O ports.
   If THUNK_ATTRIBUTE_DISABLE_A20_MASK_INT_15 is clear and THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL is set in
+  If THUNK_ATTRIBUTE_DISABLE_A20_MASK_INT_15 is clear and THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL is set in
   ThunkAttributes, then attempt to disable the A20 mask by directly accessing the 8042 keyboard controller I/O ports.
   If ThunkContext is NULL, then ASSERT().
   If AsmPrepareThunk16() was not previously called with ThunkContext, then ASSERT().
   If both THUNK_ATTRIBUTE_DISABLE_A20_MASK_INT_15 and THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL are set in
+  If both THUNK_ATTRIBUTE_DISABLE_A20_MASK_INT_15 and THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL are set in
   ThunkAttributes, then ASSERT().
   This interface is limited to be used in either physical mode or virtual modes with paging enabled where the
   virtual to physical mappings for ThunkContext.RealModeBuffer is mapped 1:1.
   @param  ThunkContext  A pointer to the context structure that describes the
 -bit real mode code to call.
 …
   ASSERT (((ThunkContext->ThunkAttributes & (THUNK_ATTRIBUTE_DISABLE_A20_MASK_INT_15 | THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL)) != \
            (THUNK_ATTRIBUTE_DISABLE_A20_MASK_INT_15 | THUNK_ATTRIBUTE_DISABLE_A20_MASK_KBD_CTRL)));
   UpdatedRegs = InternalAsmThunk16 (
                   ThunkContext->RealModeState,
 …
   This interface is limited to be used in either physical mode or virtual modes with paging enabled where the
   virtual to physical mappings for ThunkContext.RealModeBuffer is mapped 1:1.
   See AsmPrepareThunk16() and AsmThunk16() for the detailed description and ASSERT() conditions.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf

r58459	r58466
23	23	MODULE_TYPE = BASE
24	24	VERSION_STRING = 1.0
25		LIBRARY_CLASS = BaseMemoryLib
	25	LIBRARY_CLASS = BaseMemoryLib
26	26
27	27

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLib/CompareMemWrapper.c

-              r48674
+              r58466
   value returned is the first mismatched byte in SourceBuffer subtracted from the first
   mismatched byte in DestinationBuffer.
   If Length > 0 and DestinationBuffer is NULL, then ASSERT().
   If Length > 0 and SourceBuffer is NULL, then ASSERT().
 …
   @retval Non-zero          The first mismatched byte in SourceBuffer subtracted from the first
                             mismatched byte in DestinationBuffer.
 **/
 INTN

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLib/CopyMemWrapper.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   DestinationBuffer.  The implementation must be reentrant, and it must handle the case
   where SourceBuffer overlaps DestinationBuffer.
   If Length is greater than (MAX_ADDRESS - DestinationBuffer + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - SourceBuffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLib/MemLibGuid.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   This function copies the contents of the 128-bit GUID specified by SourceGuid to
   DestinationGuid, and returns DestinationGuid.
   If DestinationGuid is NULL, then ASSERT().
   If SourceGuid is NULL, then ASSERT().
 …
   This function compares Guid1 to Guid2.  If the GUIDs are identical then TRUE is returned.
   If there are any bit differences in the two GUIDs, then FALSE is returned.
   If Guid1 is NULL, then ASSERT().
   If Guid2 is NULL, then ASSERT().
 …
   GUID in the target buffer is returned.  If no match is found, then NULL is returned.
   If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLib/ScanMem16Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 16-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLib/ScanMem32Wrapper.c

r48674	r58466
33	33	then a pointer to the matching byte in the target buffer is returned. If no match is found,
34	34	then NULL is returned. If Length is 0, then NULL is returned.
35
	35
36	36	If Length > 0 and Buffer is NULL, then ASSERT().
37	37	If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLib/ScanMem64Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 64-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLib/ScanMem8Wrapper.c

-              r48674
+              r58466
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT (Buffer != NULL);
   ASSERT ((Length - 1) <= (MAX_ADDRESS - (UINTN)Buffer));
   return (VOID*)InternalMemScanMem8 (Buffer, Length, Value);
+}
 /**
   Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
+  Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
   UINTN sized value in the target buffer.
 …
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a UINTN boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLib/SetMemWrapper.c

r48674	r58466
30	30
31	31	This function fills Length bytes of Buffer with Value, and returns Buffer.
32
	32
33	33	If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
34	34

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLib/ZeroMemWrapper.c

-              r48674
+              r58466
     PeiMemoryLib
     UefiMemoryLib
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   This function fills Length bytes of Buffer with zeros, and returns Buffer.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/BaseMemoryLibMmx.inf

r58459	r58466
24	24	MODULE_TYPE = BASE
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = BaseMemoryLib
	26	LIBRARY_CLASS = BaseMemoryLib
27	27
28	28

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/CompareMemWrapper.c

-              r48674
+              r58466
   value returned is the first mismatched byte in SourceBuffer subtracted from the first
   mismatched byte in DestinationBuffer.
   If Length > 0 and DestinationBuffer is NULL, then ASSERT().
   If Length > 0 and SourceBuffer is NULL, then ASSERT().
 …
   @retval Non-zero          The first mismatched byte in SourceBuffer subtracted from the first
                             mismatched byte in DestinationBuffer.
 **/
 INTN

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/CopyMemWrapper.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   DestinationBuffer.  The implementation must be reentrant, and it must handle the case
   where SourceBuffer overlaps DestinationBuffer.
   If Length is greater than (MAX_ADDRESS - DestinationBuffer + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - SourceBuffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/MemLibGuid.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   This function copies the contents of the 128-bit GUID specified by SourceGuid to
   DestinationGuid, and returns DestinationGuid.
   If DestinationGuid is NULL, then ASSERT().
   If SourceGuid is NULL, then ASSERT().
 …
   This function compares Guid1 to Guid2.  If the GUIDs are identical then TRUE is returned.
   If there are any bit differences in the two GUIDs, then FALSE is returned.
   If Guid1 is NULL, then ASSERT().
   If Guid2 is NULL, then ASSERT().
 …
   GUID in the target buffer is returned.  If no match is found, then NULL is returned.
   If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/ScanMem16Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 16-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/ScanMem32Wrapper.c

r48674	r58466
33	33	then a pointer to the matching byte in the target buffer is returned. If no match is found,
34	34	then NULL is returned. If Length is 0, then NULL is returned.
35
	35
36	36	If Length > 0 and Buffer is NULL, then ASSERT().
37	37	If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/ScanMem64Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 64-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/ScanMem8Wrapper.c

-              r48674
+              r58466
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT (Buffer != NULL);
   ASSERT ((Length - 1) <= (MAX_ADDRESS - (UINTN)Buffer));
   return (VOID*)InternalMemScanMem8 (Buffer, Length, Value);
+}
 /**
   Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
+  Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
   UINTN sized value in the target buffer.
 …
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a UINTN boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/SetMemWrapper.c

r48674	r58466
30	30
31	31	This function fills Length bytes of Buffer with Value, and returns Buffer.
32
	32
33	33	If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
34	34

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/X64/CompareMem.S

-              r48674
+              r58466
     pushq   %rsi
     pushq   %rdi
     movq    %rcx, %rsi
     movq    %rdx, %rdi
     movq    %r8, %rcx
+    movq    %rcx, %rsi
+    movq    %rdx, %rdi
+    movq    %r8, %rcx
     repe    cmpsb
     movzbq  -1(%rsi), %rax
     movzbq  -1(%rdi), %rdx
     subq    %rdx, %rax
+    subq    %rdx, %rax
     popq    %rdi
     popq    %rsi

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/X64/CopyMem.S

-              r48674
+              r58466
     movq    %rdx, %rsi                  # rsi <- Source
     movq    %rcx, %rdi                  # rdi <- Destination
     leaq    -1(%rsi, %r8,), %r9         # r9 <- End of Source
     cmpq    %rdi, %rsi
+    leaq    -1(%rsi, %r8,), %r9         # r9 <- End of Source
+    cmpq    %rdi, %rsi
     movq    %rdi, %rax                  # rax <- Destination as return value
     jae     L0
 …
     jae     L_CopyBackward              # Copy backward if overlapped
 L0:
     movq    %r8, %rcx
+    movq    %r8, %rcx
     andq    $7, %r8
     shrq    $3, %rcx                    # rcx <- # of Qwords to copy
 …
     movq    (%rsi), %mm0
     movntq  %mm0, (%rdi)
     addq    $8, %rsi
+    addq    $8, %rsi
     addq    $8, %rdi
     loop    L1
 …
     std                                 # set direction flag
 L_CopyBytes:
     movq    %r8, %rcx
+    movq    %r8, %rcx
     rep     movsb                       # Copy bytes backward
     cld

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/X64/ScanMem16.S

-              r48674
+              r58466
 ASM_PFX(InternalMemScanMem16):
     pushq   %rdi
     movq    %rcx, %rdi
     movq    %r8, %rax
     movq    %rdx, %rcx
+    movq    %rcx, %rdi
+    movq    %r8, %rax
+    movq    %rdx, %rcx
     repne   scasw
     leaq    -2(%rdi), %rax
     cmovnz  %rcx, %rax
+    cmovnz  %rcx, %rax
     popq    %rdi
     ret

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/X64/ScanMem32.S

-              r48674
+              r58466
 ASM_PFX(InternalMemScanMem32):
     pushq    %rdi
     movq     %rcx, %rdi
     movq     %r8, %rax
     movq     %rdx, %rcx
+    movq     %rcx, %rdi
+    movq     %r8, %rax
+    movq     %rdx, %rcx
     repne    scasl
     leaq     -4(%rdi), %rax
     cmovnz   %rcx, %rax
+    cmovnz   %rcx, %rax
     popq     %rdi
     ret

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/X64/ScanMem64.S

-              r48674
+              r58466
 ASM_PFX(InternalMemScanMem64):
     pushq    %rdi
     movq     %rcx, %rdi
     movq     %r8, %rax
     movq     %rdx, %rcx
+    movq     %rcx, %rdi
+    movq     %r8, %rax
+    movq     %rdx, %rcx
     repne    scasq
     leaq     -8(%rdi), %rax
     cmovnz   %rcx, %rax
+    cmovnz   %rcx, %rax
     popq     %rdi
     ret

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/X64/ScanMem8.S

-              r48674
+              r58466
 ASM_PFX(InternalMemScanMem8):
     pushq    %rdi
     movq     %rcx, %rdi
     movq     %rdx, %rcx
     movq     %r8,   %rax
+    movq     %rcx, %rdi
+    movq     %rdx, %rcx
+    movq     %r8,   %rax
     repne    scasb
     leaq     -1(%rdi), %rax

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/X64/SetMem.S

-              r48674
+              r58466
     movq    %r8, %rdi                     # rdi <- Buffer
     movq    %rdx, %rcx
     andq    $7, %rdx
+    andq    $7, %rdx
     shrq    $3, %rcx
     jz      L_SetBytes
     .byte   0x0f, 0x70, 0x0C0, 0x00
 L0:
     movntq  %mm0, (%rdi)
+    movntq  %mm0, (%rdi)
     addq    $8, %rdi
     loop    L0

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/X64/SetMem16.S

-              r48674
+              r58466
 ASM_PFX(InternalMemSetMem16):
     pushq    %rdi
     movq     %r8, %rax
     movd     %rax, %mm0
     movq     %rcx, %r8
     movq     %r8, %rdi
     movq     %rdx, %rcx
     andl     $3, %edx
+    movq     %r8, %rax
+    movd     %rax, %mm0
+    movq     %rcx, %r8
+    movq     %r8, %rdi
+    movq     %rdx, %rcx
+    andl     $3, %edx
     shrq     $2, %rcx
     jz       L_SetWords
     .byte    0x0f, 0x70, 0x0C0, 0x00
 L0:
     movntq   %mm0, (%rdi)
     addq     $8, %rdi
+    movntq   %mm0, (%rdi)
+    addq     $8, %rdi
     loop     L0
     mfence
 L_SetWords:
     movl    %edx, %ecx
+    movl    %edx, %ecx
     rep     stosw
     movq    %r8, %rax

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/X64/SetMem32.S

-              r48674
+              r58466
    .byte    0x0f, 0x70, 0x0C0, 0x44
 L0:
     movntq  %mm0, (%rdx)
+    movntq  %mm0, (%rdx)
     leaq    8(%rdx), %rdx               # use "lea" to avoid flag changes
     loop    L0
 …
 L_SetDwords:
     jnc     L1
     movd    %mm0, (%rdx)
+    movd    %mm0, (%rdx)
 L1:
     ret

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/X64/SetMem64.S

r58459	r58466
40	40	xchg %rdx, %rcx #rcx <- Count
41	41	L0:
42		movntq %mm0, (%rdx)
	42	movntq %mm0, (%rdx)
43	43	addq $8, %rdx
44	44	loop L0

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibMmx/ZeroMemWrapper.c

-              r48674
+              r58466
     PeiMemoryLib
     UefiMemoryLib
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   This function fills Length bytes of Buffer with zeros, and returns Buffer.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf

-              r58459
+              r58466
 #  Instance of Base Memory Library optimized for use in DXE phase.
+#
 #  Base Memory Library that is optimized for use in DXE phase.
+#  Base Memory Library that is optimized for use in DXE phase.
 #  Uses REP, MMX, XMM registers as required for best performance.
+#
 …
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = BaseMemoryLib
+  LIBRARY_CLASS                  = BaseMemoryLib

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/CompareMemWrapper.c

-              r48674
+              r58466
   value returned is the first mismatched byte in SourceBuffer subtracted from the first
   mismatched byte in DestinationBuffer.
   If Length > 0 and DestinationBuffer is NULL, then ASSERT().
   If Length > 0 and SourceBuffer is NULL, then ASSERT().
 …
   @retval Non-zero          The first mismatched byte in SourceBuffer subtracted from the first
                             mismatched byte in DestinationBuffer.
 **/
 INTN

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/CopyMemWrapper.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   DestinationBuffer.  The implementation must be reentrant, and it must handle the case
   where SourceBuffer overlaps DestinationBuffer.
   If Length is greater than (MAX_ADDRESS - DestinationBuffer + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - SourceBuffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/MemLibGuid.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   This function copies the contents of the 128-bit GUID specified by SourceGuid to
   DestinationGuid, and returns DestinationGuid.
   If DestinationGuid is NULL, then ASSERT().
   If SourceGuid is NULL, then ASSERT().
 …
   This function compares Guid1 to Guid2.  If the GUIDs are identical then TRUE is returned.
   If there are any bit differences in the two GUIDs, then FALSE is returned.
   If Guid1 is NULL, then ASSERT().
   If Guid2 is NULL, then ASSERT().
 …
   GUID in the target buffer is returned.  If no match is found, then NULL is returned.
   If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/ScanMem16Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 16-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/ScanMem32Wrapper.c

r48674	r58466
33	33	then a pointer to the matching byte in the target buffer is returned. If no match is found,
34	34	then NULL is returned. If Length is 0, then NULL is returned.
35
	35
36	36	If Length > 0 and Buffer is NULL, then ASSERT().
37	37	If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/ScanMem64Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 64-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/ScanMem8Wrapper.c

-              r48674
+              r58466
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT (Buffer != NULL);
   ASSERT ((Length - 1) <= (MAX_ADDRESS - (UINTN)Buffer));
   return (VOID*)InternalMemScanMem8 (Buffer, Length, Value);
+}
 /**
   Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
+  Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
   UINTN sized value in the target buffer.
 …
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a UINTN boundary, then ASSERT().
 …
   @param  Buffer      The pointer to the target buffer to scan.
   @param  Length      The number of bytes in Buffer to scan.
   @param  Value
+  @param  Value
 The value to search for in the target buffer.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/SetMemWrapper.c

r48674	r58466
30	30
31	31	This function fills Length bytes of Buffer with Value, and returns Buffer.
32
	32
33	33	If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
34	34

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/X64/CompareMem.S

r48674	r58466
42	42	# IN UINTN Length
43	43	# );
44		#------------------------------------------------------------------------------
	44	#------------------------------------------------------------------------------
45	45	ASM_GLOBAL ASM_PFX(InternalMemCompareMem)
46	46	ASM_PFX(InternalMemCompareMem):

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/X64/CopyMem.S

r48674	r58466
40	40	movq %rdx, %rsi # rsi <- Source
41	41	movq %rcx, %rdi # rdi <- Destination
42		leaq -1(%rsi,%r8,), %r9 # r9 <- Last byte of Source
	42	leaq -1(%rsi,%r8,), %r9 # r9 <- Last byte of Source
43	43	cmpq %rdi, %rsi
44	44	movq %rdi, %rax # rax <- Destination as return value

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/X64/SetMem.S

-              r48674
+              r58466
     shrq    $3, %rcx    # rcx = rcx / 8
     cld
     rep     stosq
+    rep     stosq
     movq    %rdx, %rcx  # rcx = rdx
     andq    $7, %rcx    # rcx = rcx & 7
     rep     stosb
+    rep     stosb
     popq    %rax        # rax = Buffer
     popq    %rbx

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/X64/SetMem.asm

-              r48674
+              r58466
     shr     rcx, 3    ; rcx = rcx / 8
     cld
     rep     stosq
+    rep     stosq
     mov     rcx, rdx  ; rcx = rdx
     and     rcx, 7    ; rcx = rcx & 7
     rep     stosb
+    rep     stosb
     pop     rax       ; rax = Buffer
     ret

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptDxe/ZeroMemWrapper.c

-              r48674
+              r58466
     PeiMemoryLib
     UefiMemoryLib
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   This function fills Length bytes of Buffer with zeros, and returns Buffer.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptPei/BaseMemoryLibOptPei.inf

-              r58459
+              r58466
 #  Instance of Base Memory Library optimized for use in PEI phase.
+#
 #  Base Memory Library that is optimized for use in PEI phase.
+#  Base Memory Library that is optimized for use in PEI phase.
 #  Uses REP, MMX, XMM registers as required for best performance.
+#
 …
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = BaseMemoryLib
+  LIBRARY_CLASS                  = BaseMemoryLib

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptPei/CompareMemWrapper.c

-              r48674
+              r58466
   value returned is the first mismatched byte in SourceBuffer subtracted from the first
   mismatched byte in DestinationBuffer.
   If Length > 0 and DestinationBuffer is NULL, then ASSERT().
   If Length > 0 and SourceBuffer is NULL, then ASSERT().
 …
   @retval Non-zero          The first mismatched byte in SourceBuffer subtracted from the first
                             mismatched byte in DestinationBuffer.
 **/
 INTN

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptPei/CopyMemWrapper.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   DestinationBuffer.  The implementation must be reentrant, and it must handle the case
   where SourceBuffer overlaps DestinationBuffer.
   If Length is greater than (MAX_ADDRESS - DestinationBuffer + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - SourceBuffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptPei/MemLibGuid.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   This function copies the contents of the 128-bit GUID specified by SourceGuid to
   DestinationGuid, and returns DestinationGuid.
   If DestinationGuid is NULL, then ASSERT().
   If SourceGuid is NULL, then ASSERT().
 …
   This function compares Guid1 to Guid2.  If the GUIDs are identical then TRUE is returned.
   If there are any bit differences in the two GUIDs, then FALSE is returned.
   If Guid1 is NULL, then ASSERT().
   If Guid2 is NULL, then ASSERT().
 …
   GUID in the target buffer is returned.  If no match is found, then NULL is returned.
   If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptPei/ScanMem16Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 16-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptPei/ScanMem32Wrapper.c

r48674	r58466
33	33	then a pointer to the matching byte in the target buffer is returned. If no match is found,
34	34	then NULL is returned. If Length is 0, then NULL is returned.
35
	35
36	36	If Length > 0 and Buffer is NULL, then ASSERT().
37	37	If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptPei/ScanMem64Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 64-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptPei/ScanMem8Wrapper.c

-              r48674
+              r58466
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT (Buffer != NULL);
   ASSERT ((Length - 1) <= (MAX_ADDRESS - (UINTN)Buffer));
   return (VOID*)InternalMemScanMem8 (Buffer, Length, Value);
+}
 /**
   Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
+  Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
   UINTN sized value in the target buffer.
 …
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a UINTN boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptPei/SetMemWrapper.c

r48674	r58466
30	30
31	31	This function fills Length bytes of Buffer with Value, and returns Buffer.
32
	32
33	33	If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
34	34

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibOptPei/ZeroMemWrapper.c

-              r48674
+              r58466
     PeiMemoryLib
     UefiMemoryLib
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   This function fills Length bytes of Buffer with zeros, and returns Buffer.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf

r58459	r58466
24	24	MODULE_TYPE = BASE
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = BaseMemoryLib
	26	LIBRARY_CLASS = BaseMemoryLib
27	27
28	28

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibRepStr/CompareMemWrapper.c

-              r48674
+              r58466
   value returned is the first mismatched byte in SourceBuffer subtracted from the first
   mismatched byte in DestinationBuffer.
   If Length > 0 and DestinationBuffer is NULL, then ASSERT().
   If Length > 0 and SourceBuffer is NULL, then ASSERT().
 …
   @retval Non-zero          The first mismatched byte in SourceBuffer subtracted from the first
                             mismatched byte in DestinationBuffer.
 **/
 INTN

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibRepStr/CopyMemWrapper.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   DestinationBuffer.  The implementation must be reentrant, and it must handle the case
   where SourceBuffer overlaps DestinationBuffer.
   If Length is greater than (MAX_ADDRESS - DestinationBuffer + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - SourceBuffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibRepStr/MemLibGuid.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   This function copies the contents of the 128-bit GUID specified by SourceGuid to
   DestinationGuid, and returns DestinationGuid.
   If DestinationGuid is NULL, then ASSERT().
   If SourceGuid is NULL, then ASSERT().
 …
   This function compares Guid1 to Guid2.  If the GUIDs are identical then TRUE is returned.
   If there are any bit differences in the two GUIDs, then FALSE is returned.
   If Guid1 is NULL, then ASSERT().
   If Guid2 is NULL, then ASSERT().
 …
   GUID in the target buffer is returned.  If no match is found, then NULL is returned.
   If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibRepStr/ScanMem16Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 16-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibRepStr/ScanMem32Wrapper.c

r48674	r58466
33	33	then a pointer to the matching byte in the target buffer is returned. If no match is found,
34	34	then NULL is returned. If Length is 0, then NULL is returned.
35
	35
36	36	If Length > 0 and Buffer is NULL, then ASSERT().
37	37	If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibRepStr/ScanMem64Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 64-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibRepStr/ScanMem8Wrapper.c

-              r48674
+              r58466
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT (Buffer != NULL);
   ASSERT ((Length - 1) <= (MAX_ADDRESS - (UINTN)Buffer));
   return (VOID*)InternalMemScanMem8 (Buffer, Length, Value);
+}
 /**
   Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
+  Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
   UINTN sized value in the target buffer.
 …
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a UINTN boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibRepStr/SetMemWrapper.c

r48674	r58466
30	30
31	31	This function fills Length bytes of Buffer with Value, and returns Buffer.
32
	32
33	33	If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
34	34

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibRepStr/ZeroMemWrapper.c

-              r48674
+              r58466
     PeiMemoryLib
     UefiMemoryLib
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   This function fills Length bytes of Buffer with zeros, and returns Buffer.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/BaseMemoryLibSse2.inf

r58459	r58466
23	23	MODULE_TYPE = BASE
24	24	VERSION_STRING = 1.0
25		LIBRARY_CLASS = BaseMemoryLib
	25	LIBRARY_CLASS = BaseMemoryLib
26	26
27	27

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/CompareMemWrapper.c

-              r48674
+              r58466
   value returned is the first mismatched byte in SourceBuffer subtracted from the first
   mismatched byte in DestinationBuffer.
   If Length > 0 and DestinationBuffer is NULL, then ASSERT().
   If Length > 0 and SourceBuffer is NULL, then ASSERT().
 …
   @retval Non-zero          The first mismatched byte in SourceBuffer subtracted from the first
                             mismatched byte in DestinationBuffer.
 **/
 INTN

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/CopyMemWrapper.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   DestinationBuffer.  The implementation must be reentrant, and it must handle the case
   where SourceBuffer overlaps DestinationBuffer.
   If Length is greater than (MAX_ADDRESS - DestinationBuffer + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - SourceBuffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/MemLibGuid.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   This function copies the contents of the 128-bit GUID specified by SourceGuid to
   DestinationGuid, and returns DestinationGuid.
   If DestinationGuid is NULL, then ASSERT().
   If SourceGuid is NULL, then ASSERT().
 …
   This function compares Guid1 to Guid2.  If the GUIDs are identical then TRUE is returned.
   If there are any bit differences in the two GUIDs, then FALSE is returned.
   If Guid1 is NULL, then ASSERT().
   If Guid2 is NULL, then ASSERT().
 …
   GUID in the target buffer is returned.  If no match is found, then NULL is returned.
   If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/ScanMem16Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 16-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/ScanMem32Wrapper.c

r48674	r58466
33	33	then a pointer to the matching byte in the target buffer is returned. If no match is found,
34	34	then NULL is returned. If Length is 0, then NULL is returned.
35
	35
36	36	If Length > 0 and Buffer is NULL, then ASSERT().
37	37	If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/ScanMem64Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 64-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/ScanMem8Wrapper.c

-              r48674
+              r58466
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT (Buffer != NULL);
   ASSERT ((Length - 1) <= (MAX_ADDRESS - (UINTN)Buffer));
   return (VOID*)InternalMemScanMem8 (Buffer, Length, Value);
+}
 /**
   Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
+  Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
   UINTN sized value in the target buffer.
 …
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a UINTN boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/SetMemWrapper.c

r48674	r58466
30	30
31	31	This function fills Length bytes of Buffer with Value, and returns Buffer.
32
	32
33	33	If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
34	34

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/X64/CopyMem.S

-              r48674
+              r58466
     cmpq    %rdi, %r9                   # Overlapped?
     jae     L_CopyBackward              # Copy backward if overlapped
 L0:
     xorq    %rcx, %rcx
+L0:
+    xorq    %rcx, %rcx
     subq    %rdi, %rcx                  # rcx <- -rdi
     andq    $15, %rcx                   # rcx + rsi should be 16 bytes aligned

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseMemoryLibSse2/ZeroMemWrapper.c

-              r48674
+              r58466
     PeiMemoryLib
     UefiMemoryLib
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   This function fills Length bytes of Buffer with zeros, and returns Buffer.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePalLibNull/BasePalLibNull.inf

r58459	r58466
21	21	MODULE_TYPE = BASE
22	22	VERSION_STRING = 1.0
23		LIBRARY_CLASS = PalLib
	23	LIBRARY_CLASS = PalLib
24	24
25	25

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePalLibNull/PalCall.c

-              r48674
+              r58466
 /** @file
   Template and Sample instance of PalCallLib.
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf

r58459	r58466
24	24	MODULE_TYPE = BASE
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = PcdLib
	26	LIBRARY_CLASS = PcdLib
27	27
28	28

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePcdLibNull/PcdLib.c

-              r58459
+              r58466
   Sets the current SKU in the PCD database to the value specified by SkuId.  SkuId is returned.
   @param[in]  SkuId The SKU value that will be used when the PCD service will retrieve and
+  @param[in]  SkuId The SKU value that will be used when the PCD service will retrieve and
                     set values associated with a PCD token.
   If SkuId >= 0x100, then ASSERT().
+  If SkuId >= 0x100, then ASSERT().
   @return Return the SKU ID that just be set.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 8-bit value for the token specified by TokenNumber.
+  Returns the 8-bit value for the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the 8-bit value for the token specified by TokenNumber.
+  @return Returns the 8-bit value for the token specified by TokenNumber.
 **/
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 16-bit value for the token specified by TokenNumber.
+  Returns the 16-bit value for the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the 16-bit value for the token specified by TokenNumber.
+  @return Returns the 16-bit value for the token specified by TokenNumber.
 **/
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 32-bit value for the token specified by TokenNumber.
+  Returns the 32-bit value for the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 64-bit value for the token specified by TokenNumber.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the pointer to the buffer of the token specified by TokenNumber.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the Boolean value of the token specified by TokenNumber.
+  Returns the Boolean value of the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the Boolean value of the token specified by TokenNumber.
 **/
 BOOLEAN
+  @return Returns the Boolean value of the token specified by TokenNumber.
+**/
+BOOLEAN
 EFIAPI
 LibPcdGetBool (
 …
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the size of the token specified by TokenNumber.
+  @return Returns the size of the token specified by TokenNumber.
 **/
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 8-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid The pointer to a 128-bit unique value that designates
               which namespace to retrieve a value from.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
 …
   Returns the 16-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid The pointer to a 128-bit unique value that designates
               which namespace to retrieve a value from.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
 …
 /**
   Returns the 32-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid The pointer to a 128-bit unique value that designates
               which namespace to retrieve a value from.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 64-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the pointer to the buffer of token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the Boolean value of the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  Returns the Boolean value of the token specified by TokenNumber and Guid.
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve the size of a given PCD token.
   Returns the size of the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  Returns the size of the token specified by TokenNumber and Guid.
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 8-bit value for the token specified by TokenNumber
+  Sets the 8-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 16-bit value for the token specified by TokenNumber
+  Sets the 16-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 32-bit value for the token specified by TokenNumber
+  Sets the 32-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 64-bit value for the token specified by TokenNumber
+  Sets the 64-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets a buffer for the token specified by TokenNumber to the value
   specified by Buffer and SizeOfBuffer.  Buffer is returned.
   If SizeOfBuffer is greater than the maximum size support by TokenNumber,
   then set SizeOfBuffer to the maximum size supported by TokenNumber and
+  Sets a buffer for the token specified by TokenNumber to the value
+  specified by Buffer and SizeOfBuffer.  Buffer is returned.
+  If SizeOfBuffer is greater than the maximum size support by TokenNumber,
+  then set SizeOfBuffer to the maximum size supported by TokenNumber and
   return NULL to indicate that the set operation was not actually performed,
   or ASSERT() if the set operation was not corretly performed.
   If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to the
+  If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to the
   maximum size supported by TokenName and NULL must be returned.
   If SizeOfBuffer is NULL, then ASSERT().
   If SizeOfBuffer > 0 and Buffer is NULL, then ASSERT().
   @param[in]      TokenNumber   The PCD token number to set a current value for.
   @param[in, out] SizeOfBuffer  The size, in bytes, of Buffer.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the Boolean value for the token specified by TokenNumber
+  Sets the Boolean value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 8-bit value for the token specified by TokenNumber and
+  Sets the 8-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 16-bit value for the token specified by TokenNumber and
+  Sets the 16-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 32-bit value for the token specified by TokenNumber and
+  Sets the 32-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 64-bit value for the token specified by TokenNumber and
+  Sets the 64-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets a buffer for the token specified by TokenNumber to the value specified by
   Buffer and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
   the maximum size support by TokenNumber, then set SizeOfBuffer to the maximum size
   supported by TokenNumber and return NULL to indicate that the set operation
+  Sets a buffer for the token specified by TokenNumber to the value specified by
+  Buffer and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
+  the maximum size support by TokenNumber, then set SizeOfBuffer to the maximum size
+  supported by TokenNumber and return NULL to indicate that the set operation
   was not actually performed, or ASSERT() if the set operation was not corretly performed.
   If Guid is NULL, then ASSERT().
   If SizeOfBuffer is NULL, then ASSERT().
   If SizeOfBuffer > 0 and Buffer is NULL, then ASSERT().
   @param[in]  Guid              The pointer to a 128-bit unique value that
+  @param[in]  Guid              The pointer to a 128-bit unique value that
                                 designates which namespace to set a value from.
   @param[in]  TokenNumber       The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the Boolean value for the token specified by TokenNumber and
+  Sets the Boolean value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   Set up a notification function that is called when a specified token is set.
   When the token specified by TokenNumber and Guid is set,
   then notification function specified by NotificationFunction is called.
   If Guid is NULL, then the default token space is used.
+  When the token specified by TokenNumber and Guid is set,
+  then notification function specified by NotificationFunction is called.
+  If Guid is NULL, then the default token space is used.
   If NotificationFunction is NULL, then ASSERT().
   @param[in]  Guid      The pointer to a 128-bit unique value that designates which
                         namespace to set a value from.  If NULL, then the default
+  @param[in]  Guid      The pointer to a 128-bit unique value that designates which
+                        namespace to set a value from.  If NULL, then the default
                         token space is used.
   @param[in]  TokenNumber   The PCD token number to monitor.
   @param[in]  NotificationFunction  The function to call when the token
+  @param[in]  NotificationFunction  The function to call when the token
                                     specified by Guid and TokenNumber is set.
 …
 /**
   Disable a notification function that was established with LibPcdCallbackonSet().
   Disable a notification function that was previously established with LibPcdCallbackOnSet().
+  Disable a notification function that was previously established with LibPcdCallbackOnSet().
   If NotificationFunction is NULL, then ASSERT().
   If LibPcdCallbackOnSet() was not previously called with Guid, TokenNumber,
+  If LibPcdCallbackOnSet() was not previously called with Guid, TokenNumber,
   and NotificationFunction, then ASSERT().
   @param[in]  Guid          Specify the GUID token space.
   @param[in]  TokenNumber   Specify the token number.
 …
 /**
   Retrieves the next token in a token space.
   Retrieves the next PCD token number from the token space specified by Guid.
   If Guid is NULL, then the default token space is used.  If TokenNumber is 0,
   then the first token number is returned.  Otherwise, the token number that
   follows TokenNumber in the token space is returned.  If TokenNumber is the last
   token number in the token space, then 0 is returned.
+  Retrieves the next PCD token number from the token space specified by Guid.
+  If Guid is NULL, then the default token space is used.  If TokenNumber is 0,
+  then the first token number is returned.  Otherwise, the token number that
+  follows TokenNumber in the token space is returned.  If TokenNumber is the last
+  token number in the token space, then 0 is returned.
   If TokenNumber is not 0 and is not in the token space specified by Guid, then ASSERT().
   @param[in]  Guid        The pointer to a 128-bit unique value that designates which namespace
+  @param[in]  Guid        The pointer to a 128-bit unique value that designates which namespace
                           to set a value from.  If NULL, then the default token space is used.
   @param[in]  TokenNumber The previous PCD token number.  If 0, then retrieves the first PCD
+  @param[in]  TokenNumber The previous PCD token number.  If 0, then retrieves the first PCD
                           token number.
 …
 **/
 UINTN
+UINTN
 EFIAPI
 LibPcdGetNextToken (
 …
 /**
   Used to retrieve the list of available PCD token space GUIDs.
   Returns the PCD token space GUID that follows TokenSpaceGuid in the list of token spaces
   in the platform.
   If TokenSpaceGuid is NULL, then a pointer to the first PCD token spaces returned.
   If TokenSpaceGuid is the last PCD token space GUID in the list, then NULL is returned.
   @param  TokenSpaceGuid  The pointer to a PCD token space GUID.
 …
 **/
 GUID *
+GUID *
 EFIAPI
 LibPcdGetNextTokenSpace (
 …
 /**
   Sets a value of a patchable PCD entry that is type pointer.
   Sets the PCD entry specified by PatchVariable to the value specified by Buffer
   and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
   MaximumDatumSize, then set SizeOfBuffer to MaximumDatumSize and return
   NULL to indicate that the set operation was not actually performed.
   If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to
+  Sets the PCD entry specified by PatchVariable to the value specified by Buffer
+  and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
+  MaximumDatumSize, then set SizeOfBuffer to MaximumDatumSize and return
+  NULL to indicate that the set operation was not actually performed.
+  If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to
   MaximumDatumSize and NULL must be returned.
   If PatchVariable is NULL, then ASSERT().
   If SizeOfBuffer is NULL, then ASSERT().
   If SizeOfBuffer > 0 and Buffer is NULL, then ASSERT().
   @param[in] PatchVariable      A pointer to the global variable in a module that is
+  @param[in] PatchVariable      A pointer to the global variable in a module that is
                                 the target of the set operation.
   @param[in] MaximumDatumSize   The maximum size allowed for the PCD entry specified by PatchVariable.
   @param[in, out] SizeOfBuffer  A pointer to the size, in bytes, of Buffer.
   @param[in] Buffer             A pointer to the buffer to used to set the target variable.
   @return Return the pointer to the buffer that was set.
 …
   ASSERT (PatchVariable != NULL);
   ASSERT (SizeOfBuffer  != NULL);
   if (*SizeOfBuffer > 0) {
     ASSERT (Buffer != NULL);
 …
     return NULL;
+  }
   CopyMem (PatchVariable, Buffer, *SizeOfBuffer);
   return (VOID *) Buffer;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf

r58459	r58466
24	24	MODULE_TYPE = BASE
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = PciCf8Lib
	26	LIBRARY_CLASS = PciCf8Lib
27	27
28	28	#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePciCf8Lib/PciCf8Lib.c

-              r58459
+              r58466
 /**
   Registers a PCI device so PCI configuration registers may be accessed after
+  Registers a PCI device so PCI configuration registers may be accessed after
   SetVirtualAddressMap().
   Registers the PCI device specified by Address so all the PCI configuration registers
+  Registers the PCI device specified by Address so all the PCI configuration registers
   associated with that PCI device may be accessed after SetVirtualAddressMap() is called.
   If Address > 0x0FFFFFFF, then ASSERT().
   If the register specified by Address >= 0x100, then ASSERT().
 …
   @param  Address The address that encodes the PCI Bus, Device, Function and
                   Register.
   @retval RETURN_SUCCESS           The PCI device was registered for runtime access.
   @retval RETURN_UNSUPPORTED       An attempt was made to call this function
+  @retval RETURN_UNSUPPORTED       An attempt was made to call this function
                                    after ExitBootServices().
   @retval RETURN_UNSUPPORTED       The resources required to access the PCI device
 …
   UINT32   AddressPort;
   UINT8    Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 0);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT8    Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 0);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT8    Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 0);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT8    Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 0);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT8    Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 0);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT8    Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 0);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT8    Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 0);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT8    Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 0);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT8    Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 0);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT8    Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 0);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT16   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 1);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT16   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 1);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT16   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 1);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT16   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 1);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT16   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 1);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT16   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 1);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT16   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 1);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT16   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 1);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT16   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 1);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT16   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 1);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT32   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 3);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT32   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 3);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT32   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 3);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT32   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 3);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT32   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 3);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT32   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 3);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT32   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 3);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT32   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 3);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT32   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 3);
   InterruptState = SaveAndDisableInterrupts ();
 …
   UINT32   AddressPort;
   UINT32   Result;
   ASSERT_INVALID_PCI_ADDRESS (Address, 3);
   InterruptState = SaveAndDisableInterrupts ();

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf

r58459	r58466
24	24	MODULE_TYPE = BASE
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = PciExpressLib
	26	LIBRARY_CLASS = PciExpressLib
27	27
28	28	#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePciExpressLib/PciExpressLib.c

-              r58459
+              r58466
 /**
   Registers a PCI device so PCI configuration registers may be accessed after
+  Registers a PCI device so PCI configuration registers may be accessed after
   SetVirtualAddressMap().
   Registers the PCI device specified by Address so all the PCI configuration
   registers associated with that PCI device may be accessed after SetVirtualAddressMap()
+  Registers the PCI device specified by Address so all the PCI configuration
+  registers associated with that PCI device may be accessed after SetVirtualAddressMap()
   is called.
   If Address > 0x0FFFFFFF, then ASSERT().
   @param  Address The address that encodes the PCI Bus, Device, Function and
                   Register.
+  If Address > 0x0FFFFFFF, then ASSERT().
+  @param  Address The address that encodes the PCI Bus, Device, Function and
+                  Register.
   @retval RETURN_SUCCESS           The PCI device was registered for runtime access.
   @retval RETURN_UNSUPPORTED       An attempt was made to call this function
+  @retval RETURN_UNSUPPORTED       An attempt was made to call this function
                                    after ExitBootServices().
   @retval RETURN_UNSUPPORTED       The resources required to access the PCI device
 …
 /**
   Gets the base address of PCI Express.
   This internal functions retrieves PCI Express Base Address via a PCD entry
   PcdPciExpressBaseAddress.
   @return The base address of PCI Express.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf

r58459	r58466
24	24	MODULE_TYPE = BASE
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = PciLib
	26	LIBRARY_CLASS = PciLib
27	27
28	28	#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePciLibCf8/PciLib.c

-              r58459
+              r58466
 /**
   Registers a PCI device so PCI configuration registers may be accessed after
+  Registers a PCI device so PCI configuration registers may be accessed after
   SetVirtualAddressMap().
   Registers the PCI device specified by Address so all the PCI configuration registers
+  Registers the PCI device specified by Address so all the PCI configuration registers
   associated with that PCI device may be accessed after SetVirtualAddressMap() is called.
   If Address > 0x0FFFFFFF, then ASSERT().
   @param  Address The address that encodes the PCI Bus, Device, Function and
                   Register.
+  If Address > 0x0FFFFFFF, then ASSERT().
+  @param  Address The address that encodes the PCI Bus, Device, Function and
+                  Register.
   @retval RETURN_SUCCESS           The PCI device was registered for runtime access.
   @retval RETURN_UNSUPPORTED       An attempt was made to call this function
+  @retval RETURN_UNSUPPORTED       An attempt was made to call this function
                                    after ExitBootServices().
   @retval RETURN_UNSUPPORTED       The resources required to access the PCI device

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf

r58459	r58466
24	24	MODULE_TYPE = BASE
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = PciLib
	26	LIBRARY_CLASS = PciLib
27	27
28	28

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePciLibPciExpress/PciLib.c

-              r58459
+              r58466
 /**
   Registers a PCI device so PCI configuration registers may be accessed after
+  Registers a PCI device so PCI configuration registers may be accessed after
   SetVirtualAddressMap().
   Registers the PCI device specified by Address so all the PCI configuration registers
+  Registers the PCI device specified by Address so all the PCI configuration registers
   associated with that PCI device may be accessed after SetVirtualAddressMap() is called.
   If Address > 0x0FFFFFFF, then ASSERT().
   @param  Address The address that encodes the PCI Bus, Device, Function and
                   Register.
+  If Address > 0x0FFFFFFF, then ASSERT().
+  @param  Address The address that encodes the PCI Bus, Device, Function and
+                  Register.
   @retval RETURN_SUCCESS           The PCI device was registered for runtime access.
   @retval RETURN_UNSUPPORTED       An attempt was made to call this function
+  @retval RETURN_UNSUPPORTED       An attempt was made to call this function
                                    after ExitBootServices().
   @retval RETURN_UNSUPPORTED       The resources required to access the PCI device

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf

r58459	r58466
21	21	MODULE_TYPE = BASE
22	22	VERSION_STRING = 1.0
23		LIBRARY_CLASS = PeCoffExtraActionLib
	23	LIBRARY_CLASS = PeCoffExtraActionLib
24	24
25	25

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePeCoffExtraActionLibNull/PeCoffExtraActionLib.c

-              r48674
+              r58466
+{
   ASSERT (ImageContext != NULL);
+}
+}
 /**
   Performs additional actions just before a PE/COFF image is unloaded.  Any resources
   that were allocated by PeCoffLoaderRelocateImageExtraAction() must be freed.
   If ImageContext is NULL, then ASSERT().
   @param  ImageContext  The pointer to the image context structure that describes the
                         PE/COFF image that is being unloaded.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf

r58459	r58466
21	21	MODULE_TYPE = BASE
22	22	VERSION_STRING = 1.0
23		LIBRARY_CLASS = PeCoffGetEntryPointLib
	23	LIBRARY_CLASS = PeCoffGetEntryPointLib
24	24
25	25

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c

-              r48674
+              r58466
 /** @file
   Provides the services to get the entry point to a PE/COFF image that has either been
+  Provides the services to get the entry point to a PE/COFF image that has either been
   loaded into memory or is executing at it's linked address.
 …
 /**
   Returns a pointer to the PDB file name for a PE/COFF image that has been
   loaded into system memory with the PE/COFF Loader Library functions.
+  loaded into system memory with the PE/COFF Loader Library functions.
   Returns the PDB file name for the PE/COFF image specified by Pe32Data.  If
 …
   //
   // Scan the directory to find the debug entry.
   //
+  //
   for (DirCount = 0; DirCount < DirectoryEntry->Size; DirCount += sizeof (EFI_IMAGE_DEBUG_DIRECTORY_ENTRY), DebugEntry++) {
     if (DebugEntry->Type == EFI_IMAGE_DEBUG_TYPE_CODEVIEW) {
 …
   ASSERT (Pe32Data   != NULL);
   DosHdr = (EFI_IMAGE_DOS_HEADER *)Pe32Data;
   if (DosHdr->e_magic == EFI_IMAGE_DOS_SIGNATURE) {

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePeCoffLib/Arm/PeCoffLoaderEx.c

-              r48674
+              r58466
 /**
   Pass in a pointer to an ARM MOVT or MOVW immediate instruciton and
+  Pass in a pointer to an ARM MOVT or MOVW immediate instruciton and
   return the immediate data encoded in the instruction.
 …
   UINT32  Movt;
   UINT16  Address;
   // Thumb2 is two 16-bit instructions working together. Not a single 32-bit instruction
   // Example MOVT R0, #0 is 0x0000f2c0 or 0xf2c0 0x0000
   Movt = (*Instruction << 16) | (*(Instruction + 1));
+  Movt = (*Instruction << 16) | (*(Instruction + 1));
   // imm16 = imm4:i:imm3:imm8
 …
   // First 16-bit chunk of instruciton
   Patch  = ((Address >> 12) & 0x000f);            // imm4
+  Patch  = ((Address >> 12) & 0x000f);            // imm4
   Patch |= (((Address & BIT11) != 0) ? BIT10 : 0); // i
   // Mask out instruction bits and or in address
 …
 /**
   Pass in a pointer to an ARM MOVW/MOVT instruciton pair and
+  Pass in a pointer to an ARM MOVW/MOVT instruciton pair and
   return the immediate data encoded in the two` instruction.
 …
   UINT16  *Word;
   UINT16  *Top;
   Word = Instructions;  // MOVW
   Top  = Word + 2;      // MOVT
   return (ThumbMovtImmediateAddress (Top) << 16) + ThumbMovtImmediateAddress (Word);
+}
 …
   UINT16  *Word;
   UINT16  *Top;
   Word = Instructions;  // MOVW
   Top  = Word + 2;      // MOVT
 …
   ThumbMovtImmediatePatch (Top, (UINT16)(Address >> 16));
+}
 /**
 …
   switch ((*Reloc) >> 12) {
   case EFI_IMAGE_REL_BASED_ARM_MOV32T:
     FixupVal = ThumbMovwMovtImmediateAddress (Fixup16) + (UINT32)Adjust;
 …
     if (*FixupData != NULL) {
       *FixupData = ALIGN_POINTER(*FixupData, sizeof(UINT64));
       // Fixup16 is not aligned so we must copy it. Thumb instructions are streams of 16 bytes.
+      // Fixup16 is not aligned so we must copy it. Thumb instructions are streams of 16 bytes.
       CopyMem (*FixupData, Fixup16, sizeof (UINT64));
       *FixupData = *FixupData + sizeof(UINT64);
+    }
     break;
   case EFI_IMAGE_REL_BASED_ARM_MOV32A:
      ASSERT (FALSE);
 …
   loading and relocating of the image type. It's up to the caller to support
   the entry point.
   @param  Machine   Machine type from the PE Header.
 …
+{
   if ((Machine == IMAGE_FILE_MACHINE_ARMTHUMB_MIXED) || (Machine ==  IMAGE_FILE_MACHINE_EBC)) {
     return TRUE;
+    return TRUE;
+  }
 …
+    }
     break;
   case EFI_IMAGE_REL_BASED_ARM_MOV32A:
     ASSERT (FALSE);
 …
     return RETURN_UNSUPPORTED;
+  }
   return RETURN_SUCCESS;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePeCoffLib/BasePeCoff.c

-              r58459
+              r58466
+{
   //
   // NOTE: Some versions of Linux ELILO for Itanium have an incorrect magic value
   //       in the PE/COFF Header.  If the MachineType is Itanium(IA64) and the
+  // NOTE: Some versions of Linux ELILO for Itanium have an incorrect magic value
+  //       in the PE/COFF Header.  If the MachineType is Itanium(IA64) and the
   //       Magic value in the OptionalHeader is  EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC
   //       then override the returned value to EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC
 …
 /**
   Retrieves the PE or TE Header from a PE/COFF or TE image.
+  Retrieves the PE or TE Header from a PE/COFF or TE image.
   Caution: This function may receive untrusted input.
   PE/COFF image is external input, so this routine will
   also done many checks in PE image to make sure PE image DosHeader, PeOptionHeader,
   SizeOfHeader, Section Data Region and Security Data Region be in PE image range.
+  PE/COFF image is external input, so this routine will
+  also done many checks in PE image to make sure PE image DosHeader, PeOptionHeader,
+  SizeOfHeader, Section Data Region and Security Data Region be in PE image range.
   @param  ImageContext    The context of the image being loaded.
 …
     //
     // TE Image Data Directory Entry size is non-zero, but the Data Directory Virtual Address is zero.
     // This case is not a valid TE image.
+    // This case is not a valid TE image.
     //
     if ((Hdr.Te->DataDirectory[0].Size != 0 && Hdr.Te->DataDirectory[0].VirtualAddress == 0) ||
 …
       //
       // 2. Check the FileHeader.SizeOfOptionalHeader field.
       // OptionalHeader.NumberOfRvaAndSizes is not bigger than 16, so
+      // OptionalHeader.NumberOfRvaAndSizes is not bigger than 16, so
       // OptionalHeader.NumberOfRvaAndSizes * sizeof (EFI_IMAGE_DATA_DIRECTORY) will not overflow.
       //
 …
       //
       // 2. Check the FileHeader.SizeOfOptionalHeader field.
       // OptionalHeader.NumberOfRvaAndSizes is not bigger than 16, so
+      // OptionalHeader.NumberOfRvaAndSizes is not bigger than 16, so
       // OptionalHeader.NumberOfRvaAndSizes * sizeof (EFI_IMAGE_DATA_DIRECTORY) will not overflow.
       //
 …
       // Section data should bigger than the Pe header.
       //
       if (SectionHeader.VirtualAddress < ImageContext->SizeOfHeaders ||
+      if (SectionHeader.VirtualAddress < ImageContext->SizeOfHeaders ||
           SectionHeader.PointerToRawData < ImageContext->SizeOfHeaders) {
         ImageContext->ImageError = IMAGE_ERROR_UNSUPPORTED;
 …
   Retrieves information about a PE/COFF image.
   Computes the PeCoffHeaderOffset, IsTeImage, ImageType, ImageAddress, ImageSize,
   DestinationAddress, RelocationsStripped, SectionAlignment, SizeOfHeaders, and
   DebugDirectoryEntryRva fields of the ImageContext structure.
   If ImageContext is NULL, then return RETURN_INVALID_PARAMETER.
   If the PE/COFF image accessed through the ImageRead service in the ImageContext
   structure is not a supported PE/COFF image type, then return RETURN_UNSUPPORTED.
   If any errors occur while computing the fields of ImageContext,
   then the error status is returned in the ImageError field of ImageContext.
+  Computes the PeCoffHeaderOffset, IsTeImage, ImageType, ImageAddress, ImageSize,
+  DestinationAddress, RelocationsStripped, SectionAlignment, SizeOfHeaders, and
+  DebugDirectoryEntryRva fields of the ImageContext structure.
+  If ImageContext is NULL, then return RETURN_INVALID_PARAMETER.
+  If the PE/COFF image accessed through the ImageRead service in the ImageContext
+  structure is not a supported PE/COFF image type, then return RETURN_UNSUPPORTED.
+  If any errors occur while computing the fields of ImageContext,
+  then the error status is returned in the ImageError field of ImageContext.
   If the image is a TE image, then SectionAlignment is set to 0.
   The ImageRead and Handle fields of ImageContext structure must be valid prior
+  The ImageRead and Handle fields of ImageContext structure must be valid prior
   to invoking this service.
   Caution: This function may receive untrusted input.
   PE/COFF image is external input, so this routine will
   also done many checks in PE image to make sure PE image DosHeader, PeOptionHeader,
   SizeOfHeader, Section Data Region and Security Data Region be in PE image range.
+  PE/COFF image is external input, so this routine will
+  also done many checks in PE image to make sure PE image DosHeader, PeOptionHeader,
+  SizeOfHeader, Section Data Region and Security Data Region be in PE image range.
   @param  ImageContext              The pointer to the image context structure that describes the PE/COFF
 …
       // values for the corresponding sections. So the ImageSize can be determined
       // by the RVA and the VirtualSize of the last section header in the
       // Section Table.
+      // Section Table.
       //
       if ((++Index) == (UINTN)Hdr.Te->NumberOfSections) {
 …
 PeCoffLoaderImageAddress (
   IN OUT PE_COFF_LOADER_IMAGE_CONTEXT          *ImageContext,
   IN     UINTN                                 Address,
+  IN     UINTN                                 Address,
   IN     UINTN                                 TeStrippedOffset
+  )
 …
   of ImageContext as the relocation base address.  The caller must allocate the relocation
   fixup log buffer and fill in the FixupData field of ImageContext prior to calling this function.
   The ImageRead, Handle, PeCoffHeaderOffset,  IsTeImage, Machine, ImageType, ImageAddress,
   ImageSize, DestinationAddress, RelocationsStripped, SectionAlignment, SizeOfHeaders,
   DebugDirectoryEntryRva, EntryPoint, FixupDataSize, CodeView, PdbPointer, and FixupData of
+  The ImageRead, Handle, PeCoffHeaderOffset,  IsTeImage, Machine, ImageType, ImageAddress,
+  ImageSize, DestinationAddress, RelocationsStripped, SectionAlignment, SizeOfHeaders,
+  DebugDirectoryEntryRva, EntryPoint, FixupDataSize, CodeView, PdbPointer, and FixupData of
   the ImageContext structure must be valid prior to invoking this service.
   If ImageContext is NULL, then ASSERT().
 …
   //
   if (ImageContext->RelocationsStripped) {
     // Applies additional environment specific actions to relocate fixups
+    // Applies additional environment specific actions to relocate fixups
     // to a PE/COFF image if needed
     PeCoffLoaderRelocateImageExtraAction (ImageContext);
+    PeCoffLoaderRelocateImageExtraAction (ImageContext);
     return RETURN_SUCCESS;
+  }
 …
     // Set base and end to bypass processing below.
     //
     RelocBase = RelocBaseEnd = NULL;
+    RelocBase = RelocBaseEnd = NULL;
+  }
   RelocBaseOrg = RelocBase;
 …
         ImageContext->ImageError = IMAGE_ERROR_FAILED_RELOCATION;
         return RETURN_LOAD_ERROR;
+      }
+      }
       //
 …
+    }
+  }
   // Applies additional environment specific actions to relocate fixups
+  // Applies additional environment specific actions to relocate fixups
   // to a PE/COFF image if needed
   PeCoffLoaderRelocateImageExtraAction (ImageContext);
   return RETURN_SUCCESS;
+}
 …
   the load buffer and fill in the ImageAddress and ImageSize fields prior to calling this function.
   The EntryPoint, FixupDataSize, CodeView, PdbPointer and HiiResourceData fields of ImageContext are computed.
   The ImageRead, Handle, PeCoffHeaderOffset,  IsTeImage,  Machine, ImageType, ImageAddress, ImageSize,
   DestinationAddress, RelocationsStripped, SectionAlignment, SizeOfHeaders, and DebugDirectoryEntryRva
+  The ImageRead, Handle, PeCoffHeaderOffset,  IsTeImage,  Machine, ImageType, ImageAddress, ImageSize,
+  DestinationAddress, RelocationsStripped, SectionAlignment, SizeOfHeaders, and DebugDirectoryEntryRva
   fields of the ImageContext structure must be valid prior to invoking this service.
   If ImageContext is NULL, then ASSERT().
 …
     if (TempDebugEntryRva != 0) {
       ImageContext->CodeView = PeCoffLoaderImageAddress (ImageContext, TempDebugEntryRva, TeStrippedOffset);
+      ImageContext->CodeView = PeCoffLoaderImageAddress (ImageContext, TempDebugEntryRva, TeStrippedOffset);
       if (ImageContext->CodeView == NULL) {
         ImageContext->ImageError = IMAGE_ERROR_FAILED_RELOCATION;
 …
       if (Base != NULL) {
         ResourceDirectory = (EFI_IMAGE_RESOURCE_DIRECTORY *) Base;
         Offset = sizeof (EFI_IMAGE_RESOURCE_DIRECTORY) + sizeof (EFI_IMAGE_RESOURCE_DIRECTORY_ENTRY) *
+        Offset = sizeof (EFI_IMAGE_RESOURCE_DIRECTORY) + sizeof (EFI_IMAGE_RESOURCE_DIRECTORY_ENTRY) *
                (ResourceDirectory->NumberOfNamedEntries + ResourceDirectory->NumberOfIdEntries);
         if (Offset > DirectoryEntry->Size) {
 …
+                }
                 ResourceDirectory = (EFI_IMAGE_RESOURCE_DIRECTORY *) (Base + ResourceDirectoryEntry->u2.s.OffsetToDirectory);
                 Offset = ResourceDirectoryEntry->u2.s.OffsetToDirectory + sizeof (EFI_IMAGE_RESOURCE_DIRECTORY) +
+                Offset = ResourceDirectoryEntry->u2.s.OffsetToDirectory + sizeof (EFI_IMAGE_RESOURCE_DIRECTORY) +
                          sizeof (EFI_IMAGE_RESOURCE_DIRECTORY_ENTRY) * (ResourceDirectory->NumberOfNamedEntries + ResourceDirectory->NumberOfIdEntries);
                 if (Offset > DirectoryEntry->Size) {
 …
+                  }
                   ResourceDirectory = (EFI_IMAGE_RESOURCE_DIRECTORY *) (Base + ResourceDirectoryEntry->u2.s.OffsetToDirectory);
                   Offset = ResourceDirectoryEntry->u2.s.OffsetToDirectory + sizeof (EFI_IMAGE_RESOURCE_DIRECTORY) +
+                  Offset = ResourceDirectoryEntry->u2.s.OffsetToDirectory + sizeof (EFI_IMAGE_RESOURCE_DIRECTORY) +
                            sizeof (EFI_IMAGE_RESOURCE_DIRECTORY_ENTRY) * (ResourceDirectory->NumberOfNamedEntries + ResourceDirectory->NumberOfIdEntries);
                   if (Offset > DirectoryEntry->Size) {
 …
+    }
+  }
   return Status;
+}
 …
 /**
   Reapply fixups on a fixed up PE32/PE32+ image to allow virutal calling at EFI
   runtime.
   This function reapplies relocation fixups to the PE/COFF image specified by ImageBase
   and ImageSize so the image will execute correctly when the PE/COFF image is mapped
   to the address specified by VirtualImageBase.  RelocationData must be identical
   to the FiuxupData buffer from the PE_COFF_LOADER_IMAGE_CONTEXT structure
+  runtime.
+  This function reapplies relocation fixups to the PE/COFF image specified by ImageBase
+  and ImageSize so the image will execute correctly when the PE/COFF image is mapped
+  to the address specified by VirtualImageBase.  RelocationData must be identical
+  to the FiuxupData buffer from the PE_COFF_LOADER_IMAGE_CONTEXT structure
   after this PE/COFF image was relocated with PeCoffLoaderRelocateImage().
 …
   prior to transferring control to a PE/COFF image that is loaded using this library.
   @param  ImageBase          The base address of a PE/COFF image that has been loaded
+  @param  ImageBase          The base address of a PE/COFF image that has been loaded
                              and relocated into system memory.
   @param  VirtImageBase      The request virtual address that the PE/COFF image is to
                              be fixed up for.
   @param  ImageSize          The size, in bytes, of the PE/COFF image.
   @param  RelocationData     A pointer to the relocation data that was collected when the PE/COFF
+  @param  RelocationData     A pointer to the relocation data that was collected when the PE/COFF
                              image was relocated using PeCoffLoaderRelocateImage().
 **/
 VOID
 …
     return ;
+  }
   //
   // ASSERT for the invalid image when RelocBase and RelocBaseEnd are both NULL.
 …
 /**
   Reads contents of a PE/COFF image from a buffer in system memory.
   This is the default implementation of a PE_COFF_LOADER_READ_FILE function
   that assumes FileHandle pointer to the beginning of a PE/COFF image.
   This function reads contents of the PE/COFF image that starts at the system memory
   address specified by FileHandle.  The read operation copies ReadSize bytes from the
   PE/COFF image starting at byte offset FileOffset into the buffer specified by Buffer.
+  This is the default implementation of a PE_COFF_LOADER_READ_FILE function
+  that assumes FileHandle pointer to the beginning of a PE/COFF image.
+  This function reads contents of the PE/COFF image that starts at the system memory
+  address specified by FileHandle.  The read operation copies ReadSize bytes from the
+  PE/COFF image starting at byte offset FileOffset into the buffer specified by Buffer.
   The size of the buffer actually read is returned in ReadSize.
   The caller must make sure the FileOffset and ReadSize within the file scope.
 …
   @param  FileHandle        The pointer to base of the input stream
   @param  FileOffset        Offset into the PE/COFF image to begin the read operation.
   @param  ReadSize          On input, the size in bytes of the requested read operation.
+  @param  ReadSize          On input, the size in bytes of the requested read operation.
                             On output, the number of bytes actually read.
   @param  Buffer            Output buffer that contains the data read from the PE/COFF image.
   @retval RETURN_SUCCESS    Data is read from FileOffset from the Handle into
+  @retval RETURN_SUCCESS    Data is read from FileOffset from the Handle into
                             the buffer.
 **/
 …
 /**
   Unloads a loaded PE/COFF image from memory and releases its taken resource.
   Releases any environment specific resources that were allocated when the image
   specified by ImageContext was loaded using PeCoffLoaderLoadImage().
+  Releases any environment specific resources that were allocated when the image
+  specified by ImageContext was loaded using PeCoffLoaderLoadImage().
   For NT32 emulator, the PE/COFF image loaded by system needs to release.
   For real platform, the PE/COFF image loaded by Core doesn't needs to be unloaded,
+  For real platform, the PE/COFF image loaded by Core doesn't needs to be unloaded,
   this function can simply return RETURN_SUCCESS.
   If ImageContext is NULL, then ASSERT().
   @param  ImageContext              The pointer to the image context structure that describes the PE/COFF
                                     image to be unloaded.
 …
+{
   //
   // Applies additional environment specific actions to unload a
+  // Applies additional environment specific actions to unload a
   // PE/COFF image if needed
   //

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf

r58459	r58466
30	30	MODULE_TYPE = BASE
31	31	VERSION_STRING = 1.0
32		LIBRARY_CLASS = PeCoffLib
	32	LIBRARY_CLASS = PeCoffLib
33	33
34	34

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePeCoffLib/Ipf/PeCoffLoaderEx.c

-              r48674
+              r58466
   does not mean the image can be executed it means the PE/COFF loader supports
   loading and relocating of the image type. It's up to the caller to support
   the entry point.
+  the entry point.
   The itanium version PE/COFF loader/relocater supports itanium and EBC image.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c

r48674	r58466
44	44	loading and relocating of the image type. It's up to the caller to support
45	45	the entry point.
46
	46
47	47	The IA32/X64 version PE/COFF loader/relocater both support IA32, X64 and EBC images.
48	48
…	…
57	57	)
58	58	{
59		if ((Machine == IMAGE_FILE_MACHINE_I386) \|\| (Machine == IMAGE_FILE_MACHINE_X64) \|\|
	59	if ((Machine == IMAGE_FILE_MACHINE_I386) \|\| (Machine == IMAGE_FILE_MACHINE_X64) \|\|
60	60	(Machine == IMAGE_FILE_MACHINE_EBC)) {
61		return TRUE;
	61	return TRUE;
62	62	}
63	63

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf

r58459	r58466
21	21	MODULE_TYPE = BASE
22	22	VERSION_STRING = 1.0
23		LIBRARY_CLASS = PerformanceLib
	23	LIBRARY_CLASS = PerformanceLib
24	24
25	25

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePerformanceLibNull/PerformanceLib.c

-              r58459
+              r58466
 /**
   Creates a record for the beginning of a performance measurement.
+  Creates a record for the beginning of a performance measurement.
   Creates a record that contains the Handle, Token, and Module.
   If TimeStamp is not zero, then TimeStamp is added to the record as the start time.
 …
 /**
   Fills in the end time of a performance measurement.
+  Fills in the end time of a performance measurement.
   Looks up the record that matches Handle, Token, and Module.
   If the record can not be found then return RETURN_NOT_FOUND.
 …
 /**
   Attempts to retrieve a performance measurement log entry from the performance measurement log.
+  Attempts to retrieve a performance measurement log entry from the performance measurement log.
   It can also retrieve the log created by StartPerformanceMeasurementEx and EndPerformanceMeasurementEx,
   and then eliminate the Identifier.
 …
                                   On exit, the key of the next performance lof entry entry.
   @param  Handle                  The pointer to environment specific context used to identify the component
                                   being measured.
+                                  being measured.
   @param  Token                   The pointer to a Null-terminated ASCII string that identifies the component
                                   being measured.
+                                  being measured.
   @param  Module                  The pointer to a Null-terminated ASCII string that identifies the module
                                   being measured.
 …
 EFIAPI
 GetPerformanceMeasurement (
   IN  UINTN       LogEntryKey,
+  IN  UINTN       LogEntryKey,
   OUT CONST VOID  **Handle,
   OUT CONST CHAR8 **Token,
 …
 EFIAPI
 GetPerformanceMeasurementEx (
   IN  UINTN       LogEntryKey,
+  IN  UINTN       LogEntryKey,
   OUT CONST VOID  **Handle,
   OUT CONST CHAR8 **Token,
 …
 /**
   Returns TRUE if the performance measurement macros are enabled.
+  Returns TRUE if the performance measurement macros are enabled.
   This function returns TRUE if the PERFORMANCE_LIBRARY_PROPERTY_MEASUREMENT_ENABLED bit of
   PcdPerformanceLibraryPropertyMask is set.  Otherwise FALSE is returned.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePostCodeLibDebug/BasePostCodeLibDebug.inf

r58459	r58466
24	24	MODULE_TYPE = BASE
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = PostCodeLib
	26	LIBRARY_CLASS = PostCodeLib
27	27
28	28

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePostCodeLibDebug/PostCode.c

-              r48674
+              r58466
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
   Sends an 32-bit value to a POST card.
   Sends the 32-bit value specified by Value to a POST card, and returns Value.
   Some implementations of this library function may perform I/O operations
   directly to a POST card device.  Other implementations may send Value to
   ReportStatusCode(), and the status code reporting mechanism will eventually
+  Sends the 32-bit value specified by Value to a POST card, and returns Value.
+  Some implementations of this library function may perform I/O operations
+  directly to a POST card device.  Other implementations may send Value to
+  ReportStatusCode(), and the status code reporting mechanism will eventually
   display the 32-bit value on the status reporting device.
   PostCode() must actively prevent recursion.  If PostCode() is called while
   processing another any other Post Code Library function, then
+  PostCode() must actively prevent recursion.  If PostCode() is called while
+  processing another any other Post Code Library function, then
   PostCode() must return Value immediately.
 …
   Sends the 32-bit value specified by Value to a POST card, and returns Value.
   If Description is not NULL, then the ASCII string specified by Description is
   also passed to the handler that displays the POST card value.  Some
   implementations of this library function may perform I/O operations directly
   to a POST card device.  Other implementations may send Value to ReportStatusCode(),
   and the status code reporting mechanism will eventually display the 32-bit
   value on the status reporting device.
+  If Description is not NULL, then the ASCII string specified by Description is
+  also passed to the handler that displays the POST card value.  Some
+  implementations of this library function may perform I/O operations directly
+  to a POST card device.  Other implementations may send Value to ReportStatusCode(),
+  and the status code reporting mechanism will eventually display the 32-bit
+  value on the status reporting device.
   PostCodeWithDescription()must actively prevent recursion.  If
   PostCodeWithDescription() is called while processing another any other Post
   Code Library function, then PostCodeWithDescription() must return Value
+  PostCodeWithDescription()must actively prevent recursion.  If
+  PostCodeWithDescription() is called while processing another any other Post
+  Code Library function, then PostCodeWithDescription() must return Value
   immediately.
   @param  Value        The 32-bit value to write to the POST card.
   @param  Description  The pointer to an ASCII string that is a description of the
                        POST code value.  This is an optional parameter that may
+  @param  Description  The pointer to an ASCII string that is a description of the
+                       POST code value.  This is an optional parameter that may
                        be NULL.
 …
   Returns TRUE if POST Codes are enabled.
   This function returns TRUE if the POST_CODE_PROPERTY_POST_CODE_ENABLED
+  This function returns TRUE if the POST_CODE_PROPERTY_POST_CODE_ENABLED
   bit of PcdPostCodePropertyMask is set.  Otherwise FALSE is returned.
   @retval  TRUE   The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
+  @retval  TRUE   The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
                   PcdPostCodeProperyMask is set.
   @retval  FALSE  The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
+  @retval  FALSE  The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
                   PcdPostCodeProperyMask is clear.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf

r58459	r58466
23	23	MODULE_TYPE = BASE
24	24	VERSION_STRING = 1.0
25		LIBRARY_CLASS = PostCodeLib
	25	LIBRARY_CLASS = PostCodeLib
26	26
27	27

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePostCodeLibPort80/PostCode.c

-              r48674
+              r58466
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
   Sends an 32-bit value to a POST card.
   Sends the 32-bit value specified by Value to a POST card, and returns Value.
   Some implementations of this library function may perform I/O operations
   directly to a POST card device.  Other implementations may send Value to
   ReportStatusCode(), and the status code reporting mechanism will eventually
+  Sends the 32-bit value specified by Value to a POST card, and returns Value.
+  Some implementations of this library function may perform I/O operations
+  directly to a POST card device.  Other implementations may send Value to
+  ReportStatusCode(), and the status code reporting mechanism will eventually
   display the 32-bit value on the status reporting device.
   PostCode() must actively prevent recursion.  If PostCode() is called while
   processing another any other Post Code Library function, then
+  PostCode() must actively prevent recursion.  If PostCode() is called while
+  processing another any other Post Code Library function, then
   PostCode() must return Value immediately.
 …
   Sends the 32-bit value specified by Value to a POST card, and returns Value.
   If Description is not NULL, then the ASCII string specified by Description is
   also passed to the handler that displays the POST card value.  Some
   implementations of this library function may perform I/O operations directly
   to a POST card device.  Other implementations may send Value to ReportStatusCode(),
   and the status code reporting mechanism will eventually display the 32-bit
   value on the status reporting device.
+  If Description is not NULL, then the ASCII string specified by Description is
+  also passed to the handler that displays the POST card value.  Some
+  implementations of this library function may perform I/O operations directly
+  to a POST card device.  Other implementations may send Value to ReportStatusCode(),
+  and the status code reporting mechanism will eventually display the 32-bit
+  value on the status reporting device.
   PostCodeWithDescription()must actively prevent recursion.  If
   PostCodeWithDescription() is called while processing another any other Post
   Code Library function, then PostCodeWithDescription() must return Value
+  PostCodeWithDescription()must actively prevent recursion.  If
+  PostCodeWithDescription() is called while processing another any other Post
+  Code Library function, then PostCodeWithDescription() must return Value
   immediately.
   @param  Value        The 32-bit value to write to the POST card.
   @param  Description  The pointer to an ASCII string that is a description of the
                        POST code value.  This is an optional parameter that may
+  @param  Description  The pointer to an ASCII string that is a description of the
+                       POST code value.  This is an optional parameter that may
                        be NULL.
 …
   Returns TRUE if POST Codes are enabled.
   This function returns TRUE if the POST_CODE_PROPERTY_POST_CODE_ENABLED
+  This function returns TRUE if the POST_CODE_PROPERTY_POST_CODE_ENABLED
   bit of PcdPostCodePropertyMask is set.  Otherwise FALSE is returned.
   @retval  TRUE   The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
+  @retval  TRUE   The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
                   PcdPostCodeProperyMask is set.
   @retval  FALSE  The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
+  @retval  FALSE  The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
                   PcdPostCodeProperyMask is clear.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePrintLib/BasePrintLib.inf

r58459	r58466
21	21	MODULE_TYPE = BASE
22	22	VERSION_STRING = 1.0
23		LIBRARY_CLASS = PrintLib
	23	LIBRARY_CLASS = PrintLib
24	24
25	25

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePrintLib/PrintLib.c

-              r48674
+              r58466
 //
 // Declare a VA_LIST global variable that is used in calls to BasePrintLibSPrintMarker()
 // when the BASE_LIST parameter is valid and the VA_LIST parameter is ignored.
 // A NULL VA_LIST can not be passed into  BasePrintLibSPrintMarker() because some
+// when the BASE_LIST parameter is valid and the VA_LIST parameter is ignored.
+// A NULL VA_LIST can not be passed into  BasePrintLibSPrintMarker() because some
 // compilers define VA_LIST to be a structure.
 //
 …
 /**
   Produces a Null-terminated Unicode string in an output buffer based on
+  Produces a Null-terminated Unicode string in an output buffer based on
   a Null-terminated Unicode format string and a VA_LIST argument list
   Produces a Null-terminated Unicode string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The Unicode string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list specified by Marker based on the
   contents of the format string.
+  and BufferSize.
+  The Unicode string is produced by parsing the format string specified by FormatString.
+  Arguments are pulled from the variable argument list specified by Marker based on the
+  contents of the format string.
   The number of Unicode characters in the produced output buffer is returned not including
   the Null-terminator.
 …
   If BufferSize > 1 and FormatString is NULL, then ASSERT().
   If BufferSize > 1 and FormatString is not aligned on a 16-bit boundary, then ASSERT().
   If PcdMaximumUnicodeStringLength is not zero, and FormatString contains more than
+  If PcdMaximumUnicodeStringLength is not zero, and FormatString contains more than
   PcdMaximumUnicodeStringLength Unicode characters not including the Null-terminator, then
   ASSERT().
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           Unicode string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated Unicode format string.
   @param  Marker          VA_LIST marker for the variable argument list.
   @return The number of Unicode characters in the produced output buffer not including the
           Null-terminator.
 …
 /**
   Produces a Null-terminated Unicode string in an output buffer based on
+  Produces a Null-terminated Unicode string in an output buffer based on
   a Null-terminated Unicode format string and a BASE_LIST argument list
   Produces a Null-terminated Unicode string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The Unicode string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list specified by Marker based on the
   contents of the format string.
+  and BufferSize.
+  The Unicode string is produced by parsing the format string specified by FormatString.
+  Arguments are pulled from the variable argument list specified by Marker based on the
+  contents of the format string.
   The number of Unicode characters in the produced output buffer is returned not including
   the Null-terminator.
 …
   If BufferSize > 1 and FormatString is NULL, then ASSERT().
   If BufferSize > 1 and FormatString is not aligned on a 16-bit boundary, then ASSERT().
   If PcdMaximumUnicodeStringLength is not zero, and FormatString contains more than
+  If PcdMaximumUnicodeStringLength is not zero, and FormatString contains more than
   PcdMaximumUnicodeStringLength Unicode characters not including the Null-terminator, then
   ASSERT().
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           Unicode string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated Unicode format string.
   @param  Marker          BASE_LIST marker for the variable argument list.
   @return The number of Unicode characters in the produced output buffer not including the
           Null-terminator.
 …
 /**
   Produces a Null-terminated Unicode string in an output buffer based on a Null-terminated
+  Produces a Null-terminated Unicode string in an output buffer based on a Null-terminated
   Unicode format string and variable argument list.
   Produces a Null-terminated Unicode string in the output buffer specified by StartOfBuffer
   and BufferSize.
 …
   If BufferSize > 1 and FormatString is NULL, then ASSERT().
   If BufferSize > 1 and FormatString is not aligned on a 16-bit boundary, then ASSERT().
   If PcdMaximumUnicodeStringLength is not zero, and FormatString contains more than
+  If PcdMaximumUnicodeStringLength is not zero, and FormatString contains more than
   PcdMaximumUnicodeStringLength Unicode characters not including the Null-terminator, then
   ASSERT().
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           Unicode string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated Unicode format string.
   @param  ...             Variable argument list whose contents are accessed based on the
+  @param  ...             Variable argument list whose contents are accessed based on the
                           format string specified by FormatString.
   @return The number of Unicode characters in the produced output buffer not including the
           Null-terminator.
 …
   Produces a Null-terminated Unicode string in an output buffer based on a Null-terminated
   ASCII format string and a VA_LIST argument list
   Produces a Null-terminated Unicode string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The Unicode string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list specified by Marker based on the
+  Arguments are pulled from the variable argument list specified by Marker based on the
   contents of the format string.
   The number of Unicode characters in the produced output buffer is returned not including
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           Unicode string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated ASCII format string.
   @param  Marker          VA_LIST marker for the variable argument list.
   @return The number of Unicode characters in the produced output buffer not including the
           Null-terminator.
 …
   Produces a Null-terminated Unicode string in an output buffer based on a Null-terminated
   ASCII format string and a BASE_LIST argument list
   Produces a Null-terminated Unicode string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The Unicode string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list specified by Marker based on the
+  Arguments are pulled from the variable argument list specified by Marker based on the
   contents of the format string.
   The number of Unicode characters in the produced output buffer is returned not including
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           Unicode string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated ASCII format string.
   @param  Marker          BASE_LIST marker for the variable argument list.
   @return The number of Unicode characters in the produced output buffer not including the
           Null-terminator.
 …
 /**
   Produces a Null-terminated Unicode string in an output buffer based on a Null-terminated
+  Produces a Null-terminated Unicode string in an output buffer based on a Null-terminated
   ASCII format string and  variable argument list.
   Produces a Null-terminated Unicode string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The Unicode string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list based on the contents of the
+  Arguments are pulled from the variable argument list based on the contents of the
   format string.
   The number of Unicode characters in the produced output buffer is returned not including
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           Unicode string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated ASCII format string.
   @param  ...             Variable argument list whose contents are accessed based on the
+  @param  ...             Variable argument list whose contents are accessed based on the
                           format string specified by FormatString.
   @return The number of Unicode characters in the produced output buffer not including the
           Null-terminator.
 …
 /**
   Converts a decimal value to a Null-terminated Unicode string.
   Converts the decimal number specified by Value to a Null-terminated Unicode
   string specified by Buffer containing at most Width characters. No padding of spaces
+  Converts the decimal number specified by Value to a Null-terminated Unicode
+  string specified by Buffer containing at most Width characters. No padding of spaces
   is ever performed. If Width is 0 then a width of MAXIMUM_VALUE_CHARACTERS is assumed.
   The number of Unicode characters in Buffer is returned not including the Null-terminator.
   If the conversion contains more than Width characters, then only the first
   Width characters are returned, and the total number of characters
+  Width characters are returned, and the total number of characters
   required to perform the conversion is returned.
   Additional conversion parameters are specified in Flags.
+  Additional conversion parameters are specified in Flags.
   The Flags bit LEFT_JUSTIFY is always ignored.
   All conversions are left justified in Buffer.
 …
   If COMMA_TYPE is set in Flags, then PREFIX_ZERO is ignored in Flags, and commas
   are inserted every 3rd digit starting from the right.
   If RADIX_HEX is set in Flags, then the output buffer will be
+  If RADIX_HEX is set in Flags, then the output buffer will be
   formatted in hexadecimal format.
   If Value is < 0 and RADIX_HEX is not set in Flags, then the fist character in Buffer is a '-'.
   If PREFIX_ZERO is set in Flags and PREFIX_ZERO is not being ignored,
   then Buffer is padded with '0' characters so the combination of the optional '-'
+  If PREFIX_ZERO is set in Flags and PREFIX_ZERO is not being ignored,
+  then Buffer is padded with '0' characters so the combination of the optional '-'
   sign character, '0' characters, digit characters for Value, and the Null-terminator
   add up to Width characters.
 …
   @param  Width   The maximum number of Unicode characters to place in Buffer, not including
                   the Null-terminator.
   @return The number of Unicode characters in Buffer not including the Null-terminator.
 …
   Produces a Null-terminated ASCII string in an output buffer based on a Null-terminated
   ASCII format string and a VA_LIST argument list.
   Produces a Null-terminated ASCII string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The ASCII string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list specified by Marker based on
+  Arguments are pulled from the variable argument list specified by Marker based on
   the contents of the format string.
   The number of ASCII characters in the produced output buffer is returned not including
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           ASCII string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated ASCII format string.
   @param  Marker          VA_LIST marker for the variable argument list.
   @return The number of ASCII characters in the produced output buffer not including the
           Null-terminator.
 …
   Produces a Null-terminated ASCII string in an output buffer based on a Null-terminated
   ASCII format string and a BASE_LIST argument list.
   Produces a Null-terminated ASCII string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The ASCII string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list specified by Marker based on
+  Arguments are pulled from the variable argument list specified by Marker based on
   the contents of the format string.
   The number of ASCII characters in the produced output buffer is returned not including
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           ASCII string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated ASCII format string.
   @param  Marker          BASE_LIST marker for the variable argument list.
   @return The number of ASCII characters in the produced output buffer not including the
           Null-terminator.
 …
   Produces a Null-terminated ASCII string in an output buffer based on a Null-terminated
   ASCII format string and  variable argument list.
   Produces a Null-terminated ASCII string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The ASCII string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list based on the contents of the
+  Arguments are pulled from the variable argument list based on the contents of the
   format string.
   The number of ASCII characters in the produced output buffer is returned not including
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           ASCII string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated ASCII format string.
   @param  ...             Variable argument list whose contents are accessed based on the
+  @param  ...             Variable argument list whose contents are accessed based on the
                           format string specified by FormatString.
   @return The number of ASCII characters in the produced output buffer not including the
           Null-terminator.
 …
   Produces a Null-terminated ASCII string in an output buffer based on a Null-terminated
   Unicode format string and a VA_LIST argument list.
   Produces a Null-terminated ASCII string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The ASCII string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list specified by Marker based on
+  Arguments are pulled from the variable argument list specified by Marker based on
   the contents of the format string.
   The number of ASCII characters in the produced output buffer is returned not including
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           ASCII string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated Unicode format string.
   @param  Marker          VA_LIST marker for the variable argument list.
   @return The number of ASCII characters in the produced output buffer not including the
           Null-terminator.
 …
   Produces a Null-terminated ASCII string in an output buffer based on a Null-terminated
   Unicode format string and a BASE_LIST argument list.
   Produces a Null-terminated ASCII string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The ASCII string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list specified by Marker based on
+  Arguments are pulled from the variable argument list specified by Marker based on
   the contents of the format string.
   The number of ASCII characters in the produced output buffer is returned not including
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           ASCII string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated Unicode format string.
   @param  Marker          BASE_LIST marker for the variable argument list.
   @return The number of ASCII characters in the produced output buffer not including the
           Null-terminator.
 …
   Produces a Null-terminated ASCII string in an output buffer based on a Null-terminated
   Unicode format string and  variable argument list.
   Produces a Null-terminated ASCII string in the output buffer specified by StartOfBuffer
   and BufferSize.
   The ASCII string is produced by parsing the format string specified by FormatString.
   Arguments are pulled from the variable argument list based on the contents of the
+  Arguments are pulled from the variable argument list based on the contents of the
   format string.
   The number of ASCII characters in the produced output buffer is returned not including
 …
   Null-terminator, then ASSERT().
   @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
+  @param  StartOfBuffer   A pointer to the output buffer for the produced Null-terminated
                           ASCII string.
   @param  BufferSize      The size, in bytes, of the output buffer specified by StartOfBuffer.
   @param  FormatString    A Null-terminated Unicode format string.
   @param  ...             Variable argument list whose contents are accessed based on the
+  @param  ...             Variable argument list whose contents are accessed based on the
                           format string specified by FormatString.
   @return The number of ASCII characters in the produced output buffer not including the
           Null-terminator.
 …
 /**
   Converts a decimal value to a Null-terminated ASCII string.
   Converts the decimal number specified by Value to a Null-terminated ASCII string
   specified by Buffer containing at most Width characters. No padding of spaces
+  Converts the decimal number specified by Value to a Null-terminated ASCII string
+  specified by Buffer containing at most Width characters. No padding of spaces
   is ever performed.
   If Width is 0 then a width of  MAXIMUM_VALUE_CHARACTERS is assumed.
 …
   characters are returned, and the total number of characters required to perform
   the conversion is returned.
   Additional conversion parameters are specified in Flags.
+  Additional conversion parameters are specified in Flags.
   The Flags bit LEFT_JUSTIFY is always ignored.
   All conversions are left justified in Buffer.
 …
   If COMMA_TYPE is set in Flags, then PREFIX_ZERO is ignored in Flags, and commas
   are inserted every 3rd digit starting from the right.
   If RADIX_HEX is set in Flags, then the output buffer will be
+  If RADIX_HEX is set in Flags, then the output buffer will be
   formatted in hexadecimal format.
   If Value is < 0 and RADIX_HEX is not set in Flags, then the fist character in Buffer is a '-'.
   If PREFIX_ZERO is set in Flags and PREFIX_ZERO is not being ignored,
   then Buffer is padded with '0' characters so the combination of the optional '-'
+  If PREFIX_ZERO is set in Flags and PREFIX_ZERO is not being ignored,
+  then Buffer is padded with '0' characters so the combination of the optional '-'
   sign character, '0' characters, digit characters for Value, and the Null-terminator
   add up to Width characters.
   If Buffer is NULL, then ASSERT().
   If unsupported bits are set in Flags, then ASSERT().
 …
   @param  Width   The maximum number of ASCII characters to place in Buffer, not including
                   the Null-terminator.
   @return The number of ASCII characters in Buffer not including the Null-terminator.
 …
 /**
   Returns the number of characters that would be produced by if the formatted
+  Returns the number of characters that would be produced by if the formatted
   output were produced not including the Null-terminator.
 …
   @param[in]  Marker          VA_LIST marker for the variable argument list.
   @return The number of characters that would be produced, not including the
+  @return The number of characters that would be produced, not including the
           Null-terminator.
 **/
 …
 /**
   Returns the number of characters that would be produced by if the formatted
+  Returns the number of characters that would be produced by if the formatted
   output were produced not including the Null-terminator.
 …
   @param[in]  Marker          VA_LIST marker for the variable argument list.
   @return The number of characters that would be produced, not including the
+  @return The number of characters that would be produced, not including the
           Null-terminator.
 **/

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePrintLib/PrintLibInternal.c

-              r58459
+              r58466
   @param  Buffer      The buffer to place the Unicode or ASCII string.
   @param  EndBuffer   The end of the input Buffer. No characters will be
                       placed after that.
+                      placed after that.
   @param  Length      The count of character to be placed into Buffer.
                       (Negative value indicates no buffer fill.)
 …
+{
   INTN  Index;
   for (Index = 0; Index < Length && Buffer < EndBuffer; Index++) {
     *Buffer = (CHAR8) Character;
 …
 CHAR8 *
 BasePrintLibValueToString (
   IN OUT CHAR8  *Buffer,
   IN INT64      Value,
+  IN OUT CHAR8  *Buffer,
+  IN INT64      Value,
   IN UINTN      Radix
+  )
 …
 /**
   Internal function that converts a decimal value to a Null-terminated string.
   Converts the decimal number specified by Value to a Null-terminated
+  Converts the decimal number specified by Value to a Null-terminated
   string specified by Buffer containing at most Width characters.
   If Width is 0 then a width of  MAXIMUM_VALUE_CHARACTERS is assumed.
   The total number of characters placed in Buffer is returned.
   If the conversion contains more than Width characters, then only the first
   Width characters are returned, and the total number of characters
+  Width characters are returned, and the total number of characters
   required to perform the conversion is returned.
   Additional conversion parameters are specified in Flags.
+  Additional conversion parameters are specified in Flags.
   The Flags bit LEFT_JUSTIFY is always ignored.
   All conversions are left justified in Buffer.
 …
   are inserted every 3rd digit starting from the right.
   If Value is < 0, then the fist character in Buffer is a '-'.
   If PREFIX_ZERO is set in Flags and PREFIX_ZERO is not being ignored,
   then Buffer is padded with '0' characters so the combination of the optional '-'
+  If PREFIX_ZERO is set in Flags and PREFIX_ZERO is not being ignored,
+  then Buffer is padded with '0' characters so the combination of the optional '-'
   sign character, '0' characters, digit characters for Value, and the Null-terminator
   add up to Width characters.
 …
                     the Null-terminator.
   @param  Increment The character increment in Buffer.
   @return Total number of characters required to perform the conversion.
 …
   OriginalBuffer = Buffer;
   //
   // Width is 0 or COMMA_TYPE is set, PREFIX_ZERO is ignored.
 …
   //
   EndBuffer = Buffer + Width * Increment;
   //
   // Convert decimal negative
 …
     Width--;
+  }
   //
   // Count the length of the value string.
 …
   ValueBufferPtr = BasePrintLibValueToString (ValueBuffer, Value, Radix);
   Count = ValueBufferPtr - ValueBuffer;
   //
   // Append Zero
 …
     Buffer = BasePrintLibFillBuffer (Buffer, EndBuffer, Width - Count, '0', Increment);
+  }
   //
   // Print Comma type for every 3 characters
 …
+    }
+  }
   //
   // Print Null-terminator
 …
 /**
   Worker function that produces a Null-terminated string in an output buffer
+  Worker function that produces a Null-terminated string in an output buffer
   based on a Null-terminated format string and a VA_LIST argument list.
   VSPrint function to process format and place the results in Buffer. Since a
   VA_LIST is used this routine allows the nesting of Vararg routines. Thus
+  VSPrint function to process format and place the results in Buffer. Since a
+  VA_LIST is used this routine allows the nesting of Vararg routines. Thus
   this is the main print working routine.
   If COUNT_ONLY_NO_PRINT is set in Flags, Buffer will not be modified at all.
   @param[out] Buffer          The character buffer to print the results of the
+  @param[out] Buffer          The character buffer to print the results of the
                               parsing of Format into.
   @param[in]  BufferSize      The maximum number of characters to put into
+  @param[in]  BufferSize      The maximum number of characters to put into
                               buffer.
   @param[in]  Flags           Initial flags value.
                               Can only have FORMAT_UNICODE, OUTPUT_UNICODE,
+                              Can only have FORMAT_UNICODE, OUTPUT_UNICODE,
                               and COUNT_ONLY_NO_PRINT set.
   @param[in]  Format          A Null-terminated format string.
 …
   //
   // If you change this code be sure to match the 2 versions of this function.
   // Nearly identical logic is found in the BasePrintLib and
+  // Nearly identical logic is found in the BasePrintLib and
   // DxePrintLibPrint2Protocol (both PrintLib instances).
   //
 …
     //
     // Make sure format string cannot contain more than PcdMaximumUnicodeStringLength
     // Unicode characters if PcdMaximumUnicodeStringLength is not zero.
+    // Unicode characters if PcdMaximumUnicodeStringLength is not zero.
     //
     ASSERT (StrSize ((CHAR16 *) Format) != 0);
 …
     //
     // Make sure format string cannot contain more than PcdMaximumAsciiStringLength
     // Ascii characters if PcdMaximumAsciiStringLength is not zero.
+    // Ascii characters if PcdMaximumAsciiStringLength is not zero.
     //
     ASSERT (AsciiStrSize (Format) != 0);
 …
         FormatCharacter = ((*Format & 0xff) | (*(Format + 1) << 8)) & FormatMask;
         switch (FormatCharacter) {
         case '.':
           Flags |= PRECISION;
+        case '.':
+          Flags |= PRECISION;
           break;
         case '-':
           Flags |= LEFT_JUSTIFY;
+        case '-':
+          Flags |= LEFT_JUSTIFY;
           break;
         case '+':
           Flags |= PREFIX_SIGN;
+        case '+':
+          Flags |= PREFIX_SIGN;
           break;
         case ' ':
           Flags |= PREFIX_BLANK;
+        case ' ':
+          Flags |= PREFIX_BLANK;
           break;
         case ',':
           Flags |= COMMA_TYPE;
+        case ',':
+          Flags |= COMMA_TYPE;
           break;
         case 'L':
         case 'l':
           Flags |= LONG_TYPE;
+        case 'l':
+          Flags |= LONG_TYPE;
           break;
         case '*':
 …
+          }
           break;
         case '\0':
           //
           // Make no output if Format string terminates unexpectedly when
           // looking up for flag, width, precision and type.
+          // looking up for flag, width, precision and type.
           //
           Format   -= BytesPerFormatCharacter;
 …
           break;
+        }
+      }
+      }
       //
 …
           // 'd','x', and 'X' that are not preceded by 'l' or 'L' are assumed to be type "int".
           // This assumption is made so the format string definition is compatible with the ANSI C
           // Specification for formatted strings.  It is recommended that the Base Types be used
           // everywhere, but in this one case, compliance with ANSI C is more important, and
           // provides an implementation that is compatible with that largest possible set of CPU
+          // Specification for formatted strings.  It is recommended that the Base Types be used
+          // everywhere, but in this one case, compliance with ANSI C is more important, and
+          // provides an implementation that is compatible with that largest possible set of CPU
           // architectures.  This is why the type "int" is used in this one case.
           //
 …
             // 'd','x', and 'X' that are not preceded by 'l' or 'L' are assumed to be type "int".
             // This assumption is made so the format string definition is compatible with the ANSI C
             // Specification for formatted strings.  It is recommended that the Base Types be used
             // everywhere, but in this one case, compliance with ANSI C is more important, and
             // provides an implementation that is compatible with that largest possible set of CPU
+            // Specification for formatted strings.  It is recommended that the Base Types be used
+            // everywhere, but in this one case, compliance with ANSI C is more important, and
+            // provides an implementation that is compatible with that largest possible set of CPU
             // architectures.  This is why the type "unsigned int" is used in this one case.
             //
 …
+        }
         ArgumentString = (CHAR8 *)ValueBuffer + Count;
         Digits = Count % 3;
         if (Digits != 0) {
 …
           BasePrintLibSPrint (
             ValueBuffer,
             MAXIMUM_VALUE_CHARACTERS,
+            MAXIMUM_VALUE_CHARACTERS,
 ,
             "%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",
 …
       case 't':
         if (BaseListMarker == NULL) {
           TmpTime = VA_ARG (VaListMarker, TIME *);
+          TmpTime = VA_ARG (VaListMarker, TIME *);
         } else {
           TmpTime = BASE_ARG (BaseListMarker, TIME *);
+          TmpTime = BASE_ARG (BaseListMarker, TIME *);
+        }
         if (TmpTime == NULL) {
 …
+      }
       break;
     case '\r':
       Format += BytesPerFormatCharacter;
 …
   //
   // Make sure output buffer cannot contain more than PcdMaximumUnicodeStringLength
   // Unicode characters if PcdMaximumUnicodeStringLength is not zero.
+  // Unicode characters if PcdMaximumUnicodeStringLength is not zero.
   //
   ASSERT ((((Flags & OUTPUT_UNICODE) == 0)) || (StrSize ((CHAR16 *) OriginalBuffer) != 0));
   //
   // Make sure output buffer cannot contain more than PcdMaximumAsciiStringLength
   // ASCII characters if PcdMaximumAsciiStringLength is not zero.
+  // ASCII characters if PcdMaximumAsciiStringLength is not zero.
   //
   ASSERT ((((Flags & OUTPUT_UNICODE) != 0)) || (AsciiStrSize (OriginalBuffer) != 0));
 …
 /**
   Worker function that produces a Null-terminated string in an output buffer
+  Worker function that produces a Null-terminated string in an output buffer
   based on a Null-terminated format string and variable argument list.
   VSPrint function to process format and place the results in Buffer. Since a
   VA_LIST is used this routine allows the nesting of Vararg routines. Thus
+  VSPrint function to process format and place the results in Buffer. Since a
+  VA_LIST is used this routine allows the nesting of Vararg routines. Thus
   this is the main print working routine

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BasePrintLib/PrintLibInternal.h

-              r48674
+              r58466
 /**
   Worker function that produces a Null-terminated string in an output buffer
+  Worker function that produces a Null-terminated string in an output buffer
   based on a Null-terminated format string and a VA_LIST argument list.
   VSPrint function to process format and place the results in Buffer. Since a
   VA_LIST is used this routine allows the nesting of Vararg routines. Thus
+  VSPrint function to process format and place the results in Buffer. Since a
+  VA_LIST is used this routine allows the nesting of Vararg routines. Thus
   this is the main print working routine.
   If COUNT_ONLY_NO_PRINT is set in Flags, Buffer will not be modified at all.
   @param[out] Buffer          The character buffer to print the results of the
+  @param[out] Buffer          The character buffer to print the results of the
                               parsing of Format into.
   @param[in]  BufferSize      The maximum number of characters to put into
+  @param[in]  BufferSize      The maximum number of characters to put into
                               buffer.
   @param[in]  Flags           Initial flags value.
                               Can only have FORMAT_UNICODE, OUTPUT_UNICODE,
+                              Can only have FORMAT_UNICODE, OUTPUT_UNICODE,
                               and COUNT_ONLY_NO_PRINT set.
   @param[in]  Format          A Null-terminated format string.
 …
 /**
   Worker function that produces a Null-terminated string in an output buffer
+  Worker function that produces a Null-terminated string in an output buffer
   based on a Null-terminated format string and variable argument list.
   VSPrint function to process format and place the results in Buffer. Since a
   VA_LIST is used this routine allows the nesting of Vararg routines. Thus
+  VSPrint function to process format and place the results in Buffer. Since a
+  VA_LIST is used this routine allows the nesting of Vararg routines. Thus
   this is the main print working routine
 …
   @param  Buffer      Buffer to place the Unicode or ASCII string.
   @param  EndBuffer   The end of the input Buffer. No characters will be
                       placed after that.
+                      placed after that.
   @param  Length      The count of character to be placed into Buffer.
                       (Negative value indicates no buffer fill.)
 …
 CHAR8 *
 BasePrintLibValueToString (
   IN OUT CHAR8  *Buffer,
   IN INT64      Value,
+  IN OUT CHAR8  *Buffer,
+  IN INT64      Value,
   IN UINTN      Radix
   );
 …
 /**
   Internal function that converts a decimal value to a Null-terminated string.
   Converts the decimal number specified by Value to a Null-terminated
+  Converts the decimal number specified by Value to a Null-terminated
   string specified by Buffer containing at most Width characters.
   If Width is 0 then a width of  MAXIMUM_VALUE_CHARACTERS is assumed.
   The total number of characters placed in Buffer is returned.
   If the conversion contains more than Width characters, then only the first
   Width characters are returned, and the total number of characters
+  Width characters are returned, and the total number of characters
   required to perform the conversion is returned.
   Additional conversion parameters are specified in Flags.
+  Additional conversion parameters are specified in Flags.
   The Flags bit LEFT_JUSTIFY is always ignored.
   All conversions are left justified in Buffer.
 …
   are inserted every 3rd digit starting from the right.
   If Value is < 0, then the fist character in Buffer is a '-'.
   If PREFIX_ZERO is set in Flags and PREFIX_ZERO is not being ignored,
   then Buffer is padded with '0' characters so the combination of the optional '-'
+  If PREFIX_ZERO is set in Flags and PREFIX_ZERO is not being ignored,
+  then Buffer is padded with '0' characters so the combination of the optional '-'
   sign character, '0' characters, digit characters for Value, and the Null-terminator
   add up to Width characters.
 …
                     the Null-terminator.
   @param  Increment Character increment in Buffer.
   @return Total number of characters required to perform the conversion.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLib.c

r48674	r58466
216	216	{
217	217	ASSERT (DevicePath != NULL);
218
	218
219	219	return EFI_SUCCESS;
220	220	}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseS3BootScriptLibNull/BootScriptLib.c

-              r58459
+              r58466
 /** @file
   Null function implementation for EFI S3 boot script.
+  Null function implementation for EFI S3 boot script.
   Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
 …
 /**
   Save I/O write to boot script
+  Save I/O write to boot script
   @param Width  the width of the I/O operations.Enumerated in S3_BOOT_SCRIPT_LIB_WIDTH.
 …
   IN VOID                           *DataMask
+  )
+{
+{
         return RETURN_SUCCESS;
+}
 …
   @param Length         A pointer to signify the number of bytes that this operation will do.
   @param Buffer         Contains the value of data to execute to the SMBUS slave device.
   @retval RETURN_OUT_OF_RESOURCES  Not enough memory for the table do operation.
   @retval RETURN_SUCCESS           Opcode is added.
 …
 EFIAPI
 S3BootScriptSaveSmbusExecute (
   IN  UINTN                             SmBusAddress,
+  IN  UINTN                             SmBusAddress,
   IN  EFI_SMBUS_OPERATION               Operation,
   IN  UINTN                             *Length,
 …
   @param Duration   Duration in microseconds of the stall
   @retval RETURN_OUT_OF_RESOURCES  Not enough memory for the table do operation.
   @retval RETURN_SUCCESS           Opcode is added.
 …
   @param EntryPoint   Entry point of the code to be dispatched.
   @retval RETURN_OUT_OF_RESOURCES   Not enough memory for the table do operation.
   @retval RETURN_SUCCESS            Opcode is added.
 …
   @param EntryPoint   Entry point of the code to be dispatched.
   @param Context      Argument to be passed into the EntryPoint of the code to be dispatched.
   @retval RETURN_OUT_OF_RESOURCES  Not enough memory for the table do operation.
   @retval RETURN_SUCCESS           Opcode is added.
 …
   Adds a record for memory reads of the memory location and continues when the exit criteria is
   satisfied or after a defined duration.
   Please aware, below interface is different with PI specification, Vol 5:
   EFI_S3_SAVE_STATE_PROTOCOL.Write() for EFI_BOOT_SCRIPT_MEM_POLL_OPCODE.
 …
   Store arbitrary information in the boot script table. This opcode is a no-op on dispatch and is only
   used for debugging script issues.
   @param InformationLength   Length of the data in bytes
   @param Information       Information to be logged in the boot scrpit
   @retval RETURN_UNSUPPORTED   If  entering runtime, this method will not support.
   @retval RETURN_OUT_OF_RESOURCES  Not enough memory for the table do operation.
 …
 EFIAPI
 S3BootScriptSaveInformation (
   IN  UINT32                   InformationLength,
+  IN  UINT32                   InformationLength,
   IN  VOID                    *Information
+  )
 …
   Adds a record for I/O reads the I/O location and continues when the exit criteria is satisfied or after a
   defined duration.
   @param  Width                 The width of the I/O operations.
+  @param  Width                 The width of the I/O operations.
   @param  Address               The base address of the I/O operations.
   @param  Data                  The comparison value used for the polling exit criteria.
 …
   IN UINT64                     Address,
   IN VOID                      *Data,
   IN VOID                      *DataMask,
   IN UINT64                     Delay
+  IN VOID                      *DataMask,
+  IN UINT64                     Delay
+  )
+{
 …
   after a defined duration.
   @param  Width                 The width of the I/O operations.
+  @param  Width                 The width of the I/O operations.
   @param  Address               The address within the PCI configuration space.
   @param  Data                  The comparison value used for the polling exit criteria.
 …
   after a defined duration.
   @param  Width                 The width of the I/O operations.
+  @param  Width                 The width of the I/O operations.
   @param  Segment               The PCI segment number for Address.
   @param  Address               The address within the PCI configuration space.
 …
  @retval RETURN_SUCCESS           Opcode is added.
  @note   A known Limitations in the implementation: When interpreting the opcode  EFI_BOOT_SCRIPT_PCI_CONFIG2_WRITE_OPCODE
          EFI_BOOT_SCRIPT_PCI_CONFIG2_READ_WRITE_OPCODE and EFI_BOOT_SCRIPT_PCI_CONFIG2_POLL_OPCODE, the 'Segment' parameter is assumed as
+         EFI_BOOT_SCRIPT_PCI_CONFIG2_READ_WRITE_OPCODE and EFI_BOOT_SCRIPT_PCI_CONFIG2_POLL_OPCODE, the 'Segment' parameter is assumed as
          Zero, or else, assert.
 …
+}
 /**
   This is an function to close the S3 boot script table. The function could only be called in
   BOOT time phase. To comply with the Framework spec definition on
+  This is an function to close the S3 boot script table. The function could only be called in
+  BOOT time phase. To comply with the Framework spec definition on
   EFI_BOOT_SCRIPT_SAVE_PROTOCOL.CloseTable(), this function will fulfill following things:
 . Closes the specified boot script table
 . It allocates a new memory pool to duplicate all the boot scripts in the specified table.
      Once this function is called, the table maintained by the library will be destroyed
+. It allocates a new memory pool to duplicate all the boot scripts in the specified table.
+     Once this function is called, the table maintained by the library will be destroyed
      after it is copied into the allocated pool.
 . Any attempts to add a script record after calling this function will cause a new table
+. Any attempts to add a script record after calling this function will cause a new table
      to be created by the library.
 . The base address of the allocated pool will be returned in Address. Note that after
+. The base address of the allocated pool will be returned in Address. Note that after
      using the boot script table, the CALLER is responsible for freeing the pool that is allocated
      by this function.
+     by this function.
   In Spec PI1.1, this EFI_BOOT_SCRIPT_SAVE_PROTOCOL.CloseTable() is retired. By then it is not
   necessary to provide this API in BootScriptLib. To provides this API for now is only to meet
   the requirement from Framework Spec.
   If anyone does call CloseTable() on a real platform, then the caller is responsible for figuring out
   how to get the script to run on an S3 resume because the boot script maintained by the lib will be
+  If anyone does call CloseTable() on a real platform, then the caller is responsible for figuring out
+  how to get the script to run on an S3 resume because the boot script maintained by the lib will be
   destroyed.
   @return the base address of the new copy of the boot script table.
+  @return the base address of the new copy of the boot script table.
 **/
 …
   @param RETURN_SUCCESS           The boot script table was executed successfully.
   @param RETURN_UNSUPPORTED       Invalid script table or opcode.
+  @param RETURN_UNSUPPORTED       Invalid script table or opcode.
 **/
 RETURN_STATUS
 …
+}
 /**
   Move the last boot script entry to the position
+  Move the last boot script entry to the position
   @param  BeforeOrAfter         Specifies whether the opcode is stored before (TRUE) or after (FALSE) the position
 …
   @param  BeforeOrAfter         Specifies whether the opcode is stored before (TRUE)
                                 or after (FALSE) the position in the boot script table
+                                or after (FALSE) the position in the boot script table
                                 specified by Position.
   @param  CreateIfNotFound      Specifies whether the label will be created if the label
+  @param  CreateIfNotFound      Specifies whether the label will be created if the label
                                 does not exists (TRUE) or not (FALSE).
   @param  Position              On entry, specifies the position in the boot script table
 …
                                 specified script table.
   @retval EFI_INVALID_PARAMETER The parameter is illegal or the given boot script is not supported.
                                 If the opcode is unknow or not supported because of the PCD
+                                If the opcode is unknow or not supported because of the PCD
                                 Feature Flags.
   @retval EFI_OUT_OF_RESOURCES  There is insufficient memory to store the boot script.
 …
 **/
 RETURN_STATUS
 EFIAPI
+EFIAPI
 S3BootScriptLabel (
   IN       BOOLEAN                      BeforeOrAfter,
 …
                                 specified script table.
   @retval EFI_INVALID_PARAMETER The parameter is illegal or the given boot script is not supported.
                                 If the opcode is unknow or not supported because of the PCD
+                                If the opcode is unknow or not supported because of the PCD
                                 Feature Flags.
   @retval EFI_OUT_OF_RESOURCES  There is insufficient memory to store the boot script.
 …
 **/
 RETURN_STATUS
 EFIAPI
+EFIAPI
 S3BootScriptCompare (
   IN  UINT8                       *Position1,

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseS3IoLib/BaseS3IoLib.inf

-              r58459
+              r58466
 # Instance of S3 I/O Library based on I/O and S3 BootScript Library.
+#
 # S3 I/O and MMIO Library Services that do I/O and also
+# S3 I/O and MMIO Library Services that do I/O and also
 # enable the I/O operatation to be replayed during an S3 resume.
+#
 …
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = S3IoLib
+  LIBRARY_CLASS                  = S3IoLib

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseS3IoLib/S3IoLib.c

-              r58459
+              r58466
   I/O and MMIO Library Services that do I/O and also enable the I/O operatation
   to be replayed during an S3 resume.
   Copyright (c) 2006 -2012, Intel Corporation. All rights reserved.<BR>
 …
   This internal worker function saves an I/O port value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
+{
   RETURN_STATUS                Status;
   Status = S3BootScriptSaveIoWrite (
              Width,
 …
   ASSERT (Status == RETURN_SUCCESS);
+}
 /**
   Saves an 8-bit I/O port value to the boot script.
   This internal worker function saves an 8-bit I/O port value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
 /**
   Reads an 8-bit I/O port, performs a bitwise AND followed by a bitwise
   inclusive OR, and writes the result back to the 8-bit I/O port and saves
+  inclusive OR, and writes the result back to the 8-bit I/O port and saves
   the value in the S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field in an 8-bit port, performs a bitwise OR, and writes the
   result back to the bit field in the 8-bit port and saves the value in the
+  result back to the bit field in the 8-bit port and saves the value in the
   S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field in an 8-bit port, performs a bitwise AND, and writes the
   result back to the bit field in the 8-bit port  and saves the value in the
+  result back to the bit field in the 8-bit port  and saves the value in the
   S3 script to be replayed on S3 resume.
 …
   This internal worker function saves a 16-bit I/O port value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
+{
   InternalSaveIoWriteValueToBootScript (S3BootScriptWidthUint16, Port, &Value);
   return Value;
+}
 …
 /**
   Reads a 16-bit I/O port, performs a bitwise OR, and writes the
   result back to the 16-bit I/O port and saves the value in the S3 script to
+  result back to the 16-bit I/O port and saves the value in the S3 script to
   be replayed on S3 resume.
 …
 /**
   Writes a bit field to an I/O register and saves the value in the S3 script
+  Writes a bit field to an I/O register and saves the value in the S3 script
   to be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 16-bit port, performs a bitwise OR, and writes the
   result back to the bit field in the 16-bit port and saves the value in the
+  result back to the bit field in the 16-bit port and saves the value in the
   S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 16-bit port, performs a bitwise AND, and writes the
   result back to the bit field in the 16-bit port and saves the value in the
+  result back to the bit field in the 16-bit port and saves the value in the
   S3 script to be replayed on S3 resume.
 …
   Reads a bit field in a 16-bit port, performs a bitwise AND followed by a
   bitwise OR, and writes the result back to the bit field in the
 -bit port  and saves the value in the S3 script to be replayed on S3
+-bit port  and saves the value in the S3 script to be replayed on S3
   resume.
 …
   This internal worker function saves a 32-bit I/O port value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
+{
   InternalSaveIoWriteValueToBootScript (S3BootScriptWidthUint32, Port, &Value);
   return Value;
+}
 …
 /**
   Reads a 32-bit I/O port, performs a bitwise OR, and writes the
   result back to the 32-bit I/O port and saves the value in the S3 script to
+  result back to the 32-bit I/O port and saves the value in the S3 script to
   be replayed on S3 resume.
 …
 /**
   Reads a 32-bit I/O port, performs a bitwise AND followed by a bitwise
   inclusive OR, and writes the result back to the 32-bit I/O port and saves
+  inclusive OR, and writes the result back to the 32-bit I/O port and saves
   the value in the S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 32-bit port, performs a bitwise OR, and writes the
   result back to the bit field in the 32-bit port and saves the value in the
+  result back to the bit field in the 32-bit port and saves the value in the
   S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 32-bit port, performs a bitwise AND, and writes the
   result back to the bit field in the 32-bit port and saves the value in the
+  result back to the bit field in the 32-bit port and saves the value in the
   S3 script to be replayed on S3 resume.
 …
   Reads a bit field in a 32-bit port, performs a bitwise AND followed by a
   bitwise OR, and writes the result back to the bit field in the
 -bit port and saves the value in the S3 script to be replayed on S3
+-bit port and saves the value in the S3 script to be replayed on S3
   resume.
 …
   This internal worker function saves a 64-bit I/O port value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
+{
   InternalSaveIoWriteValueToBootScript (S3BootScriptWidthUint64, Port, &Value);
   return Value;
+}
 …
 /**
   Reads a 64-bit I/O port, performs a bitwise OR, and writes the
   result back to the 64-bit I/O port and saves the value in the S3 script to
+  result back to the 64-bit I/O port and saves the value in the S3 script to
   be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 64-bit port, performs a bitwise OR, and writes the
   result back to the bit field in the 64-bit port and saves the value in the
+  result back to the bit field in the 64-bit port and saves the value in the
   S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 64-bit port, performs a bitwise AND, and writes the
   result back to the bit field in the 64-bit port and saves the value in the
+  result back to the bit field in the 64-bit port and saves the value in the
   S3 script to be replayed on S3 resume.
 …
   Reads a bit field in a 64-bit port, performs a bitwise AND followed by a
   bitwise OR, and writes the result back to the bit field in the
 -bit port and saves the value in the S3 script to be replayed on S3
+-bit port and saves the value in the S3 script to be replayed on S3
   resume.
 …
   This internal worker function saves an MMIO register value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
   This internal worker function saves an 8-bit MMIO register value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
 /**
   Reads an 8-bit MMIO register and saves the value in the S3 script to be
+  Reads an 8-bit MMIO register and saves the value in the S3 script to be
   replayed on S3 resume.
 …
 /**
   Writes an 8-bit MMIO register and saves the value in the S3 script to be
+  Writes an 8-bit MMIO register and saves the value in the S3 script to be
   replayed on S3 resume.
 …
 /**
   Reads an 8-bit MMIO register, performs a bitwise OR, and writes the
   result back to the 8-bit MMIO register and saves the value in the S3 script
+  result back to the 8-bit MMIO register and saves the value in the S3 script
   to be replayed on S3 resume.
 …
 /**
   Reads an 8-bit MMIO register, performs a bitwise AND, and writes the result
   back to the 8-bit MMIO register and saves the value in the S3 script to be
+  back to the 8-bit MMIO register and saves the value in the S3 script to be
   replayed on S3 resume.
 …
 /**
   Reads an 8-bit MMIO register, performs a bitwise AND followed by a bitwise
   inclusive OR, and writes the result back to the 8-bit MMIO register and saves
+  inclusive OR, and writes the result back to the 8-bit MMIO register and saves
   the value in the S3 script to be replayed on S3 resume.
 …
   This internal worker function saves a 16-bit MMIO register value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
+{
   InternalSaveMmioWriteValueToBootScript (S3BootScriptWidthUint16, Address, &Value);
   return Value;
+}
 …
 /**
   Reads a 16-bit MMIO register, performs a bitwise OR, and writes the
   result back to the 16-bit MMIO register and saves the value in the S3 script
+  result back to the 16-bit MMIO register and saves the value in the S3 script
   to be replayed on S3 resume.
 …
 /**
   Reads a 16-bit MMIO register, performs a bitwise AND, and writes the result
   back to the 16-bit MMIO register and saves the value in the S3 script to be
+  back to the 16-bit MMIO register and saves the value in the S3 script to be
   replayed on S3 resume.
 …
 /**
   Reads a 16-bit MMIO register, performs a bitwise AND followed by a bitwise
   inclusive OR, and writes the result back to the 16-bit MMIO register and
+  inclusive OR, and writes the result back to the 16-bit MMIO register and
   saves the value in the S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 16-bit MMIO register, performs a bitwise OR, and
   writes the result back to the bit field in the 16-bit MMIO register and
+  writes the result back to the bit field in the 16-bit MMIO register and
   saves the value in the S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 16-bit MMIO register, performs a bitwise AND, and
   writes the result back to the bit field in the 16-bit MMIO register and
+  writes the result back to the bit field in the 16-bit MMIO register and
   saves the value in the S3 script to be replayed on S3 resume.
 …
   This internal worker function saves a 32-bit MMIO register value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
 /**
   Reads a 32-bit MMIO register saves the value in the S3 script to be
+  Reads a 32-bit MMIO register saves the value in the S3 script to be
   replayed on S3 resume.
 …
 /**
   Writes a 32-bit MMIO register and saves the value in the S3 script to be
+  Writes a 32-bit MMIO register and saves the value in the S3 script to be
   replayed on S3 resume.
 …
 /**
   Reads a 32-bit MMIO register, performs a bitwise OR, and writes the
   result back to the 32-bit MMIO register and saves the value in the S3 script
+  result back to the 32-bit MMIO register and saves the value in the S3 script
   to be replayed on S3 resume.
 …
 /**
   Reads a 32-bit MMIO register, performs a bitwise AND, and writes the result
   back to the 32-bit MMIO register and saves the value in the S3 script to be
+  back to the 32-bit MMIO register and saves the value in the S3 script to be
   replayed on S3 resume.
 …
 /**
   Reads a 32-bit MMIO register, performs a bitwise AND followed by a bitwise
   inclusive OR, and writes the result back to the 32-bit MMIO register and
+  inclusive OR, and writes the result back to the 32-bit MMIO register and
   saves the value in the S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field of a MMIO register and saves the value in the S3 script
+  Reads a bit field of a MMIO register and saves the value in the S3 script
   to be replayed on S3 resume.
 …
 /**
   Writes a bit field to a MMIO register and saves the value in the S3 script
+  Writes a bit field to a MMIO register and saves the value in the S3 script
   to be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 32-bit MMIO register, performs a bitwise OR, and
   writes the result back to the bit field in the 32-bit MMIO register and
+  writes the result back to the bit field in the 32-bit MMIO register and
   saves the value in the S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 32-bit MMIO register, performs a bitwise AND, and
   writes the result back to the bit field in the 32-bit MMIO register and
+  writes the result back to the bit field in the 32-bit MMIO register and
   saves the value in the S3 script to be replayed on S3 resume.
 …
   This internal worker function saves a 64-bit MMIO register value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
 /**
   Reads a 64-bit MMIO register and saves the value in the S3 script to be
+  Reads a 64-bit MMIO register and saves the value in the S3 script to be
   replayed on S3 resume.
 …
 /**
   Writes a 64-bit MMIO register and saves the value in the S3 script to be
+  Writes a 64-bit MMIO register and saves the value in the S3 script to be
   replayed on S3 resume.
 …
 /**
   Reads a 64-bit MMIO register, performs a bitwise OR, and writes the
   result back to the 64-bit MMIO register and saves the value in the S3 script
+  result back to the 64-bit MMIO register and saves the value in the S3 script
   to be replayed on S3 resume.
 …
 /**
   Reads a 64-bit MMIO register, performs a bitwise AND, and writes the result
   back to the 64-bit MMIO register and saves the value in the S3 script to be
+  back to the 64-bit MMIO register and saves the value in the S3 script to be
   replayed on S3 resume.
 …
 /**
   Reads a 64-bit MMIO register, performs a bitwise AND followed by a bitwise
   inclusive OR, and writes the result back to the 64-bit MMIO register and
+  inclusive OR, and writes the result back to the 64-bit MMIO register and
   saves the value in the S3 script to be replayed on S3 resume.
 …
 /**
   Reads a bit field in a 64-bit MMIO register, performs a bitwise OR, and
   writes the result back to the bit field in the 64-bit MMIO register and
+  writes the result back to the bit field in the 64-bit MMIO register and
   saves the value in the S3 script to be replayed on S3 resume.
 …
   and saves the value in the S3 script to be replayed on S3 resume.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 8-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 8-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   and saves the value in the S3 script to be replayed on S3 resume.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 16-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 16-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 16-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   and saves the value in the S3 script to be replayed on S3 resume.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 32-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 32-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 32-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   and saves the value in the S3 script to be replayed on S3 resume.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 64-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 64-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 64-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   and saves the value in the S3 script to be replayed on S3 resume.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 8-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 8-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   and saves the value in the S3 script to be replayed on S3 resume.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 16-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 16-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 16-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   and saves the value in the S3 script to be replayed on S3 resume.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 32-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 32-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 32-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   and saves the value in the S3 script to be replayed on S3 resume.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 64-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 64-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 64-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseS3PciLib/BaseS3PciLib.inf

-              r58459
+              r58466
 # Instance of S3 PCI Library based on PCI and S3 BootScript Library.
+#
 # S3 PCI Services that perform PCI Configuration cycles and
+# S3 PCI Services that perform PCI Configuration cycles and
 # also enable the PCI operation to be replayed during an S3 resume.
+#
 …
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = S3PciLib
+  LIBRARY_CLASS                  = S3PciLib

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseS3PciLib/S3PciLib.c

-              r58459
+              r58466
   PCI configuration Library Services that do PCI configuration and also enable
   the PCI operations to be replayed during an S3 resume. This library class
   maps directly on top of the PciLib class.
+  maps directly on top of the PciLib class.
   Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR>
 …
   This internal worker function saves a PCI configuration value in
   the S3 script to be replayed on S3 resume.
+  the S3 script to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
   This internal worker function saves an 8-bit PCI configuration value in
   the S3 script to be replayed on S3 resume.
+  the S3 script to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
   This internal worker function saves a 16-bit PCI configuration value in
   the S3 script to be replayed on S3 resume.
+  the S3 script to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
   This internal worker function saves a 32-bit PCI configuration value in the S3 script
   to be replayed on S3 resume.
+  to be replayed on S3 resume.
   If the saving process fails, then ASSERT().
 …
              );
   ASSERT (Status == RETURN_SUCCESS);
   return Size;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseS3SmbusLib/BaseS3SmbusLib.inf

-              r58459
+              r58466
+#
 # S3 Smbus Library Services that do SMBus transactions and also enable the
 # operatation to be replayed during an S3 resume.
+# operatation to be replayed during an S3 resume.
+#
 # Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
 …
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = S3SmbusLib
+  LIBRARY_CLASS                  = S3SmbusLib

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseS3SmbusLib/S3SmbusLib.c

-              r48674
+              r58466
   Smbus Library Services that do SMBus transactions and also enable the operatation
   to be replayed during an S3 resume. This library class maps directly on top
   of the SmbusLib class.
+  of the SmbusLib class.
   Copyright (c) 2007, Intel Corporation. All rights reserved.<BR>
 …
 /**
   Saves an SMBus operation to S3 script to be replayed on S3 resume.
+  Saves an SMBus operation to S3 script to be replayed on S3 resume.
   This function provides a standard way to save SMBus operation to S3 boot Script.
 …
+{
   SmBusQuickRead (SmBusAddress, Status);
   InternalSaveSmBusExecToBootScript (EfiSmbusQuickRead, SmBusAddress, 0, NULL);
+}
 …
   InternalSaveSmBusExecToBootScript (EfiSmbusQuickWrite, SmBusAddress, 0, NULL);
+}
 /**
   Executes an SMBUS receive byte command and saves the value in the S3 script to be replayed
 …
   If Length in SmBusAddress is not zero, then ASSERT().
   If any reserved bits of SmBusAddress are set, then ASSERT().
   @param  SmBusAddress    Address that encodes the SMBUS Slave Address,
                           SMBUS Command, SMBUS Data Length, and PEC.
 …
+{
   UINT16  Word;
   Word = SmBusReadDataWord (SmBusAddress, Status);
 …
   InternalSaveSmBusExecToBootScript (EfiSmbusProcessCall, SmBusAddress, 2, &Value);
   return Word;
+  return Word;
+}
 …
   Bytes are written to the SMBUS from Buffer.
   The number of bytes written is returned, and will never return a value larger than 32-bytes.
   If Status is not NULL, then the status of the executed command is returned in Status.
+  If Status is not NULL, then the status of the executed command is returned in Status.
   If Length in SmBusAddress is zero or greater than 32, then ASSERT().
   If Buffer is NULL, then ASSERT().
 …
   InternalSaveSmBusExecToBootScript (EfiSmbusWriteBlock, SmBusAddress, SMBUS_LIB_LENGTH (SmBusAddress), Buffer);
   return Length;
+}
 …
+{
   UINTN   Length;
   Length = SmBusBlockProcessCall (SmBusAddress, WriteBuffer, ReadBuffer, Status);
   InternalSaveSmBusExecToBootScript (EfiSmbusBWBRProcessCall, SmBusAddress, SMBUS_LIB_LENGTH (SmBusAddress), ReadBuffer);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseS3StallLib/BaseS3StallLib.inf

-              r58459
+              r58466
+#
 # Stall Services that do stall and also enable the Stall operatation
 # to be replayed during an S3 resume.
+# to be replayed during an S3 resume.
+#
 # Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
 …
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = S3StallLib
+  LIBRARY_CLASS                  = S3StallLib

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseS3StallLib/S3StallLib.c

-              r48674
+              r58466
   Stall Services that do stall and also enable the Stall operatation
   to be replayed during an S3 resume. This library class maps directly on top
   of the Timer class.
+  of the Timer class.
   Copyright (c) 2007, Intel Corporation. All rights reserved.<BR>
 …
+{
   RETURN_STATUS    Status;
   Status = S3BootScriptSaveStall (MicroSecondDelay (MicroSeconds));
   ASSERT (Status == RETURN_SUCCESS);
   return MicroSeconds;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.c

-              r48674
+              r58466
 /**
   Initialize the serial device hardware.
   If no initialization is required, then return RETURN_SUCCESS.
   If the serial device was successfully initialized, then return RETURN_SUCCESS.
   If the serial device could not be initialized, then return RETURN_DEVICE_ERROR.
   @retval RETURN_SUCCESS        The serial device was initialized.
   @retval RETURN_DEVICE_ERROR   The serial device could not be initialized.
 …
 /**
   Write data from buffer to serial device.
   Writes NumberOfBytes data bytes from Buffer to the serial device.
+  Write data from buffer to serial device.
+  Writes NumberOfBytes data bytes from Buffer to the serial device.
   The number of bytes actually written to the serial device is returned.
   If the return value is less than NumberOfBytes, then the write operation failed.
   If Buffer is NULL, then ASSERT().
+  If Buffer is NULL, then ASSERT().
   If NumberOfBytes is zero, then return 0.
 …
   @retval 0                NumberOfBytes is 0.
   @retval >0               The number of bytes written to the serial device.
+  @retval >0               The number of bytes written to the serial device.
                            If this value is less than NumberOfBytes, then the read operation failed.
 …
 /**
   Read data from serial device and save the datas in buffer.
   Reads NumberOfBytes data bytes from a serial device into the buffer
   specified by Buffer. The number of bytes actually read is returned.
+  specified by Buffer. The number of bytes actually read is returned.
   If the return value is less than NumberOfBytes, then the rest operation failed.
   If Buffer is NULL, then ASSERT().
+  If Buffer is NULL, then ASSERT().
   If NumberOfBytes is zero, then return 0.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.c

-              r58464
+              r58466
   If Length in SmBusAddress is not zero, then ASSERT().
   If any reserved bits of SmBusAddress are set, then ASSERT().
   @param  SmBusAddress  Address that encodes the SMBUS Slave Address,
                         SMBUS Command, SMBUS Data Length, and PEC.
 …
   Bytes are written to the SMBUS from Buffer.
   The number of bytes written is returned, and will never return a value larger than 32-bytes.
   If Status is not NULL, then the status of the executed command is returned in Status.
+  If Status is not NULL, then the status of the executed command is returned in Status.
   If Length in SmBusAddress is zero or greater than 32, then ASSERT().
   If Buffer is NULL, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseSynchronizationLib/Arm/Synchronization.c

-              r48674
+              r58466
   Performs an atomic compare exchange operation on a 64-bit unsigned integer.
   Performs an atomic compare exchange operation on the 64-bit unsigned integer specified
   by Value.  If Value is equal to CompareValue, then Value is set to ExchangeValue and
   CompareValue is returned.  If Value is not equal to CompareValue, then Value is returned.
+  Performs an atomic compare exchange operation on the 64-bit unsigned integer specified
+  by Value.  If Value is equal to CompareValue, then Value is set to ExchangeValue and
+  CompareValue is returned.  If Value is not equal to CompareValue, then Value is returned.
   The compare exchange operation must be performed using MP safe mechanisms.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf

-              r58459
+              r58466
 [Sources.IA32]
   Ia32/InterlockedCompareExchange64.c | MSFT
   Ia32/InterlockedCompareExchange32.c | MSFT
   Ia32/InterlockedDecrement.c | MSFT
   Ia32/InterlockedIncrement.c | MSFT
+  Ia32/InterlockedCompareExchange64.c | MSFT
+  Ia32/InterlockedCompareExchange32.c | MSFT
+  Ia32/InterlockedDecrement.c | MSFT
+  Ia32/InterlockedIncrement.c | MSFT
   SynchronizationMsc.c  | MSFT
   Ia32/InterlockedCompareExchange64.asm | INTEL
   Ia32/InterlockedCompareExchange32.asm | INTEL
   Ia32/InterlockedDecrement.asm | INTEL
   Ia32/InterlockedIncrement.asm | INTEL
+  Ia32/InterlockedCompareExchange64.asm | INTEL
+  Ia32/InterlockedCompareExchange32.asm | INTEL
+  Ia32/InterlockedDecrement.asm | INTEL
+  Ia32/InterlockedIncrement.asm | INTEL
   Synchronization.c | INTEL
 …
   X64/InterlockedCompareExchange64.c | MSFT
   X64/InterlockedCompareExchange32.c | MSFT
   X64/InterlockedCompareExchange64.asm | INTEL
   X64/InterlockedCompareExchange32.asm | INTEL
-  X64/InterlockedDecrement.c | MSFT
-  X64/InterlockedIncrement.c | MSFT
-  SynchronizationMsc.c | MSFT
+  X64/InterlockedDecrement.asm | INTEL
+  X64/InterlockedIncrement.asm | INTEL
+  Synchronization.c | INTEL
+  X64/InterlockedDecrement.c | MSFT
+  X64/InterlockedIncrement.c | MSFT
+  SynchronizationMsc.c | MSFT
+  X64/InterlockedDecrement.asm | INTEL
+  X64/InterlockedIncrement.asm | INTEL
+  Synchronization.c | INTEL
   X64/GccInline.c | GCC
   SynchronizationGcc.c  | GCC
+  SynchronizationGcc.c  | GCC
 [Sources.IPF]
 …
   Ipf/InterlockedCompareExchange32.s
   Synchronization.c     | INTEL
   SynchronizationMsc.c  | MSFT
   SynchronizationGcc.c  | GCC
+  Synchronization.c     | INTEL
+  SynchronizationMsc.c  | MSFT
+  SynchronizationGcc.c  | GCC
 [Sources.EBC]

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseSynchronizationLib/Ebc/Synchronization.c

-              r48674
+              r58466
   Performs an atomic compare exchange operation on a 64-bit unsigned integer.
   Performs an atomic compare exchange operation on the 64-bit unsigned integer specified
   by Value.  If Value is equal to CompareValue, then Value is set to ExchangeValue and
   CompareValue is returned.  If Value is not equal to CompareValue, then Value is returned.
+  Performs an atomic compare exchange operation on the 64-bit unsigned integer specified
+  by Value.  If Value is equal to CompareValue, then Value is set to ExchangeValue and
+  CompareValue is returned.  If Value is not equal to CompareValue, then Value is returned.
   The compare exchange operation must be performed using MP safe mechanisms.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseSynchronizationLib/Ia32/GccInline.c

-              r48674
+              r58466
 /** @file
   GCC inline implementation of BaseSynchronizationLib processor specific functions.
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
 …
     : "=a" (Result),          // %0
       "=m" (*Value)           // %1
     : "m"  (*Value)           // %2
+    : "m"  (*Value)           // %2
     : "memory",
       "cc"
     );
   return Result;
+  return Result;
+}
 …
+{
    UINT32  Result;
   __asm__ __volatile__ (
     "lock               \n\t"
 …
     : "=a" (Result),          // %0
       "=m" (*Value)           // %1
     : "m"  (*Value)           // %2
+    : "m"  (*Value)           // %2
     : "memory",
       "cc"
     );
   return Result;
+}
 …
     : "q"  (ExchangeValue),   // %1
       "m"  (*Value),          // %2
       "0"  (CompareValue)     // %4
+      "0"  (CompareValue)     // %4
     : "memory",
       "cc"
 …
   __asm__ __volatile__ (
     "                       \n\t"
     "push        %%ebx      \n\t"
     "movl        %2,%%ebx   \n\t"
+    "push        %%ebx      \n\t"
+    "movl        %2,%%ebx   \n\t"
     "lock                   \n\t"
     "cmpxchg8b   (%1)       \n\t"
 …
       "cc"
     );
   return CompareValue;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseSynchronizationLib/Synchronization.c

r58459	r58466
23	23
24	24	This function retrieves the spin lock alignment requirements for optimal
25		performance on a given CPU architecture. The spin lock alignment is byte alignment.
	25	performance on a given CPU architecture. The spin lock alignment is byte alignment.
26	26	It must be a power of two and is returned by this function. If there are no alignment
27	27	requirements, then 1 must be returned. The spin lock synchronization

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseSynchronizationLib/SynchronizationGcc.c

-              r58459
+              r58466
 //
 // GCC inline assembly for Read Write Barrier
+// GCC inline assembly for Read Write Barrier
 //
 #define _ReadWriteBarrier() do { __asm__ __volatile__ ("": : : "memory"); } while(0)
 …
   This function retrieves the spin lock alignment requirements for optimal
   performance on a given CPU architecture. The spin lock alignment is byte alignment.
+  performance on a given CPU architecture. The spin lock alignment is byte alignment.
   It must be a power of two and is returned by this function. If there are no alignment
   requirements, then 1 must be returned. The spin lock synchronization
 …
   SPIN_LOCK   LockValue;
   VOID        *Result;
   ASSERT (SpinLock != NULL);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseSynchronizationLib/SynchronizationMsc.c

-              r58459
+              r58466
   This function retrieves the spin lock alignment requirements for optimal
   performance on a given CPU architecture. The spin lock alignment is byte alignment.
+  performance on a given CPU architecture. The spin lock alignment is byte alignment.
   It must be a power of two and is returned by this function. If there are no alignment
   requirements, then 1 must be returned. The spin lock synchronization
 …
   SPIN_LOCK   LockValue;
   VOID        *Result;
   ASSERT (SpinLock != NULL);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c

-              r48674
+              r58466
 /** @file
   GCC inline implementation of BaseSynchronizationLib processor specific functions.
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
+  Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
 …
     : "=a" (Result),          // %0
       "=m" (*Value)           // %1
     : "m"  (*Value)           // %2
+    : "m"  (*Value)           // %2
     : "memory",
       "cc"
     );
   return Result;
+  return Result;
+}
 …
+{
    UINT32  Result;
   __asm__ __volatile__ (
     "lock               \n\t"
 …
     : "=a" (Result),          // %0
       "=m" (*Value)           // %1
     : "m"  (*Value)           // %2
+    : "m"  (*Value)           // %2
     : "memory",
       "cc"
     );
   return Result;
+}
 …
       "=m" (*Value)           // %1
     : "a"  (CompareValue),    // %2
       "r"  (ExchangeValue),   // %3
+      "r"  (ExchangeValue),   // %3
       "m"  (*Value)
     : "memory",
       "cc"
     );
   return CompareValue;
+}
 …
       "=m" (*Value)           // %1
     : "a"  (CompareValue),    // %2
       "r"  (ExchangeValue),   // %3
+      "r"  (ExchangeValue),   // %3
       "m"  (*Value)
     : "memory",
       "cc"
     );
   return CompareValue;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf

r58459	r58466
26	26	MODULE_TYPE = BASE
27	27	VERSION_STRING = 1.0
28		LIBRARY_CLASS = TimerLib
	28	LIBRARY_CLASS = TimerLib
29	29
30	30

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c

-              r58459
+              r58466
   //
   Sd->mBitCount = (UINT16) (Sd->mBitCount - NumOfBits);
   //
   // Copy NumOfBits of bits from mSubBitBuf into mBitBuf
 …
   //
   // Pop NumOfBits of Bits from Left
   //
+  //
   OutBits = (UINT32) (Sd->mBitBuf >> (BITBUFSIZ - NumOfBits));
 …
     Count[BitLen[Index]]++;
+  }
   Start[0] = 0;
   Start[1] = 0;
 …
   JuBits = (UINT16) (16 - TableBits);
   Weight[0] = 0;
   for (Index = 1; Index <= TableBits; Index++) {
 …
   while (Index <= 16) {
     Weight[Index] = (UINT16) (1U << (16 - Index));
     Index++;
+    Index++;
+  }
 …
           *Pointer = Avail++;
+        }
         if (*Pointer < (2 * NC - 1)) {
           if ((Index3 & Mask) != 0) {
 …
   ASSERT (nn <= NPT);
   //
   // Read Extra Set Code Length Array size
+  // Read Extra Set Code Length Array size
   //
   Number = (UINT16) GetBits (Sd, nbit);
 …
     //
     // If a code length is less than 7, then it is encoded as a 3-bit
     // value. Or it is encoded as a series of "1"s followed by a
+    // value. Or it is encoded as a series of "1"s followed by a
     // terminating "0". The number of "1"s = Code length - 4.
     //
 …
+      }
+    }
     FillBuf (Sd, (UINT16) ((CharC < 7) ? 3 : CharC - 3));
     Sd->mPTLen[Index++] = (UINT8) CharC;
     //
     // For Code&Len Set,
+    //
+    // For Code&Len Set,
     // After the third length of the code length concatenation,
     // a 2-bit value is used to indicated the number of consecutive
+    // a 2-bit value is used to indicated the number of consecutive
     // zero lengths after the third length.
     //
 …
     Sd->mPTLen[Index++] = 0;
+  }
   return MakeTable (Sd, nn, Sd->mPTLen, 8, Sd->mPTTable);
+}
 …
     // Starting a new block
     // Read BlockSize from block header
     //
+    //
     Sd->mBlockSize    = (UINT16) GetBits (Sd, 16);
 …
     //
     // Read in the Position Set Code Length Arrary,
+    // Read in the Position Set Code Length Arrary,
     // Generate the Huffman code mapping table for the Position Set.
     //
 …
     //
     // Get one code from mBitBuf
     //
+    //
     CharC = DecodeC (Sd);
     if (Sd->mBadTableFlag != 0) {
 …
       //
       CharC       = (UINT16) (CharC - (BIT8 - THRESHOLD));
       //
       // Get string length
 …
 /**
   Given a compressed source buffer, this function retrieves the size of
   the uncompressed buffer and the size of the scratch buffer required
+  Given a compressed source buffer, this function retrieves the size of
+  the uncompressed buffer and the size of the scratch buffer required
   to decompress the compressed source buffer.
   Retrieves the size of the uncompressed buffer and the temporary scratch buffer
+  Retrieves the size of the uncompressed buffer and the temporary scratch buffer
   required to decompress the buffer specified by Source and SourceSize.
   If the size of the uncompressed buffer or the size of the scratch buffer cannot
   be determined from the compressed data specified by Source and SourceData,
+  be determined from the compressed data specified by Source and SourceData,
   then RETURN_INVALID_PARAMETER is returned.  Otherwise, the size of the uncompressed
   buffer is returned in DestinationSize, the size of the scratch buffer is returned
   in ScratchSize, and RETURN_SUCCESS is returned.
   This function does not have scratch buffer available to perform a thorough
+  This function does not have scratch buffer available to perform a thorough
   checking of the validity of the source data.  It just retrieves the "Original Size"
   field from the beginning bytes of the source data and output it as DestinationSize.
 …
                           by Source and SourceSize is decompressed.
   @param  ScratchSize     A pointer to the size, in bytes, of the scratch buffer that
                           is required to decompress the compressed buffer specified
+                          is required to decompress the compressed buffer specified
                           by Source and SourceSize.
   @retval  RETURN_SUCCESS The size of the uncompressed data was returned
                           in DestinationSize, and the size of the scratch
+  @retval  RETURN_SUCCESS The size of the uncompressed data was returned
+                          in DestinationSize, and the size of the scratch
                           buffer was returned in ScratchSize.
   @retval  RETURN_INVALID_PARAMETER
                           The size of the uncompressed data or the size of
                           the scratch buffer cannot be determined from
                           the compressed data specified by Source
+  @retval  RETURN_INVALID_PARAMETER
+                          The size of the uncompressed data or the size of
+                          the scratch buffer cannot be determined from
+                          the compressed data specified by Source
                           and SourceSize.
 **/
 …
   This function is designed so that the decompression algorithm can be implemented
   without using any memory services.  As a result, this function is not allowed to
   call any memory allocation services in its implementation.  It is the caller's
+  call any memory allocation services in its implementation.  It is the caller's
   responsibility to allocate and free the Destination and Scratch buffers.
   If the compressed source data specified by Source is successfully decompressed
   into Destination, then RETURN_SUCCESS is returned.  If the compressed source data
+  If the compressed source data specified by Source is successfully decompressed
+  into Destination, then RETURN_SUCCESS is returned.  If the compressed source data
   specified by Source is not in a valid compressed data format,
   then RETURN_INVALID_PARAMETER is returned.
 …
   @param  Destination The destination buffer to store the decompressed data.
   @param  Scratch     A temporary scratch buffer that is used to perform the decompression.
                       This is an optional parameter that may be NULL if the
+                      This is an optional parameter that may be NULL if the
                       required scratch buffer size is 0.
   @retval  RETURN_SUCCESS Decompression completed successfully, and
+  @retval  RETURN_SUCCESS Decompression completed successfully, and
                           the uncompressed buffer is returned in Destination.
   @retval  RETURN_INVALID_PARAMETER
                           The source buffer specified by Source is corrupted
+  @retval  RETURN_INVALID_PARAMETER
+                          The source buffer specified by Source is corrupted
                           (not in a valid compressed format).
 **/

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf

r58459	r58466
21	21	MODULE_TYPE = BASE
22	22	VERSION_STRING = 1.0
23		LIBRARY_CLASS = UefiDecompressLib
	23	LIBRARY_CLASS = UefiDecompressLib
24	24
25	25

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.c

-              r48674
+              r58466
 //
 // Cache copy of HobList pointer.
 //
+// Cache copy of HobList pointer.
+//
 VOID *gHobList = NULL;
 /**
   The entry point of PE/COFF Image for the DXE Core.
+  The entry point of PE/COFF Image for the DXE Core.
   This function is the entry point for the DXE Core. This function is required to call
 …
   If ProcessModuleEntryPointList() returns, then ASSERT() and halt the system.
   @param  HobStart  The pointer to the beginning of the HOB List passed in from the PEI Phase.
+  @param  HobStart  The pointer to the beginning of the HOB List passed in from the PEI Phase.
 **/
 …
   This function is required to call _ModuleEntryPoint() passing in HobStart.
   @param  HobStart  The pointer to the beginning of the HOB List passed in from the PEI Phase.
+  @param  HobStart  The pointer to the beginning of the HOB List passed in from the PEI Phase.
 **/

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf

r58459	r58466
21	21	MODULE_TYPE = DXE_CORE
22	22	VERSION_STRING = 1.0
23		LIBRARY_CLASS = DxeCoreEntryPoint\|DXE_CORE
	23	LIBRARY_CLASS = DxeCoreEntryPoint\|DXE_CORE
24	24
25	25

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf

r58459	r58466
24	24	MODULE_TYPE = DXE_CORE
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = HobLib\|DXE_CORE
	26	LIBRARY_CLASS = HobLib\|DXE_CORE
27	27
28	28

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeCoreHobLib/HobLib.c

-              r58459
+              r58466
   This function returns the pointer to first HOB in the list.
   For PEI phase, the PEI service GetHobList() can be used to retrieve the pointer
+  For PEI phase, the PEI service GetHobList() can be used to retrieve the pointer
   to the HOB list.  For the DXE phase, the HOB list pointer can be retrieved through
   the EFI System Table by looking up theHOB list GUID in the System Configuration Table.
   Since the System Configuration Table does not exist that the time the DXE Core is
   launched, the DXE Core uses a global variable from the DXE Core Entry Point Library
+  Since the System Configuration Table does not exist that the time the DXE Core is
+  launched, the DXE Core uses a global variable from the DXE Core Entry Point Library
   to manage the pointer to the HOB list.
   If the pointer to the HOB list is NULL, then ASSERT().
   @return The pointer to the HOB list.
 …
   Returns the next instance of a HOB type from the starting HOB.
   This function searches the first instance of a HOB type from the starting HOB pointer.
+  This function searches the first instance of a HOB type from the starting HOB pointer.
   If there does not exist such HOB type from the starting HOB pointer, it will return NULL.
   In contrast with macro GET_NEXT_HOB(), this function does not skip the starting HOB pointer
   unconditionally: it returns HobStart back if HobStart itself meets the requirement;
   caller is required to use GET_NEXT_HOB() if it wishes to skip current HobStart.
   If HobStart is NULL, then ASSERT().
 …
   Returns the first instance of a HOB type among the whole HOB list.
   This function searches the first instance of a HOB type among the whole HOB list.
   If there does not exist such HOB type in the HOB list, it will return NULL.
+  This function searches the first instance of a HOB type among the whole HOB list.
+  If there does not exist such HOB type in the HOB list, it will return NULL.
   If the pointer to the HOB list is NULL, then ASSERT().
 …
 /**
   Returns the next instance of the matched GUID HOB from the starting HOB.
   This function searches the first instance of a HOB from the starting HOB pointer.
   Such HOB should satisfy two conditions:
   its HOB type is EFI_HOB_TYPE_GUID_EXTENSION, and its GUID Name equals to the input Guid.
   If such a HOB from the starting HOB pointer does not exist, it will return NULL.
+  This function searches the first instance of a HOB from the starting HOB pointer.
+  Such HOB should satisfy two conditions:
+  its HOB type is EFI_HOB_TYPE_GUID_EXTENSION, and its GUID Name equals to the input Guid.
+  If such a HOB from the starting HOB pointer does not exist, it will return NULL.
   Caller is required to apply GET_GUID_HOB_DATA () and GET_GUID_HOB_DATA_SIZE ()
   to extract the data section and its size information, respectively.
 …
   unconditionally: it returns HobStart back if HobStart itself meets the requirement;
   caller is required to use GET_NEXT_HOB() if it wishes to skip current HobStart.
   If Guid is NULL, then ASSERT().
   If HobStart is NULL, then ASSERT().
 …
 /**
   Returns the first instance of the matched GUID HOB among the whole HOB list.
   This function searches the first instance of a HOB among the whole HOB list.
+  This function searches the first instance of a HOB among the whole HOB list.
   Such HOB should satisfy two conditions:
   its HOB type is EFI_HOB_TYPE_GUID_EXTENSION and its GUID Name equals to the input Guid.
 …
   Caller is required to apply GET_GUID_HOB_DATA () and GET_GUID_HOB_DATA_SIZE ()
   to extract the data section and its size information, respectively.
   If the pointer to the HOB list is NULL, then ASSERT().
   If Guid is NULL, then ASSERT().
 …
   Get the system boot mode from the HOB list.
   This function returns the system boot mode information from the
+  This function returns the system boot mode information from the
   PHIT HOB in HOB list.
   If the pointer to the HOB list is NULL, then ASSERT().
   @param  VOID
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If ModuleName is NULL, then ASSERT().
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
 /**
   Builds a customized HOB tagged with a GUID for identification and returns
+  Builds a customized HOB tagged with a GUID for identification and returns
   the start address of GUID HOB data.
   This function builds a customized HOB tagged with a GUID for identification
   and returns the start address of GUID HOB data so that caller can fill the customized data.
+  This function builds a customized HOB tagged with a GUID for identification
+  and returns the start address of GUID HOB data so that caller can fill the customized data.
   The HOB Header and Name field is already stripped.
   It can only be invoked during PEI phase.
   For DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If Guid is NULL, then ASSERT().
   If there is no additional space for HOB creation, then ASSERT().
 …
 /**
   Builds a customized HOB tagged with a GUID for identification, copies the input data to the HOB
+  Builds a customized HOB tagged with a GUID for identification, copies the input data to the HOB
   data field, and returns the start address of the GUID HOB data.
   This function builds a customized HOB tagged with a GUID for identification and copies the input
   data to the HOB data field and returns the start address of the GUID HOB data.  It can only be
   invoked during PEI phase; for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
+  data to the HOB data field and returns the start address of the GUID HOB data.  It can only be
+  invoked during PEI phase; for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   The HOB Header and Name field is already stripped.
   It can only be invoked during PEI phase.
   For DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If Guid is NULL, then ASSERT().
   If Data is NULL and DataLength > 0, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   @param  FvName        The name of the Firmware Volume.
   @param  FileName      The name of the file.
 **/
 VOID
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If the platform does not support Capsule Volume HOBs, then ASSERT().
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() because PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeExtendedSalLib/DxeExtendedSalLib.inf

r58459	r58466
20	20	MODULE_TYPE = DXE_DRIVER
21	21	VERSION_STRING = 1.0
22		LIBRARY_CLASS = ExtendedSalLib\|DXE_DRIVER UEFI_DRIVER UEFI_APPLICATION
	22	LIBRARY_CLASS = ExtendedSalLib\|DXE_DRIVER UEFI_DRIVER UEFI_APPLICATION
23	23	CONSTRUCTOR = DxeExtendedSalLibConstruct
24	24

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeExtendedSalLib/ExtendedSalLib.c

-              r48674
+              r58466
   Constructor function to get Extended SAL Boot Service Protocol, and initializes
   physical plabel of ESAL entrypoint.
   This function first locates Extended SAL Boot Service Protocol and caches it in global variable.
   Then it initializes the physical plable of ESAL entrypoint, and stores
 …
 /**
   Registers function of ESAL class and it's associated global.
   This function registers function of ESAL class, together with its associated global.
   It is worker function for RegisterEsalClass().
 …
 /**
   Registers ESAL Class and it's associated global.
   This function registers one or more Extended SAL services in a given
   class along with the associated global context.
 …
   @param  ModuleGlobal         Module global for the class.
   @param  ...                  List of Function/FunctionId pairs, ended by NULL
   @retval EFI_SUCCESS          The Extended SAL services were registered.
   @retval EFI_UNSUPPORTED      This function was called after ExitBootServices().
   @retval EFI_OUT_OF_RESOURCES There are not enough resources available to register one or more of the specified services.
   @retval Other                ClassGuid could not be installed onto a new handle.
+  @retval Other                ClassGuid could not be installed onto a new handle.
 **/
 …
 /**
   Calls an Extended SAL Class service that was previously registered with RegisterEsalClass().
   This function gets the entrypoint of Extended SAL, and calls an Extended SAL Class service
   that was previously registered with RegisterEsalClass() through this entrypoint.
 …
   @param  Arg7            Argument 7 ClassGuid/FunctionId defined
   @param  Arg8            Argument 8 ClassGuid/FunctionId defined
   @retval EFI_SAL_SUCCESS ESAL procedure successfully called.
   @retval EFI_SAL_ERROR   The address of ExtendedSalProc() can not be correctly
                           initialized.
   @retval Other           Status returned from ExtendedSalProc() service of
                           EXTENDED_SAL_BOOT_SERVICE_PROTOCOL.
+                          EXTENDED_SAL_BOOT_SERVICE_PROTOCOL.
 **/
 …
 /**
   Wrapper for the EsalStallFunctionId service of Extended SAL Stall Services Class.
   This function is a wrapper for the EsalStallFunctionId service of Extended SAL
   Stall Services Class. See EsalStallFunctionId of Extended SAL Specification.
 …
+{
   return EsalCall (
            EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_HI,
            StallFunctionId,
            Microseconds,
 ,
 ,
 ,
 ,
 ,
+           EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_LO,
+           EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_HI,
+           StallFunctionId,
+           Microseconds,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalSetNewPalEntryFunctionId service of Extended SAL PAL Services Services Class.
   This function is a wrapper for the EsalSetNewPalEntryFunctionId service of Extended SAL
   PAL Services Services Class. See EsalSetNewPalEntryFunctionId of Extended SAL Specification.
 …
+{
   return EsalCall (
            EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_LO,
+           EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_HI,
            SetNewPalEntryFunctionId,
            PhysicalAddress,
            PalEntryPoint,
 ,
 ,
 ,
 ,
+           SetNewPalEntryFunctionId,
+           PhysicalAddress,
+           PalEntryPoint,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetNewPalEntryFunctionId service of Extended SAL PAL Services Services Class.
   This function is a wrapper for the EsalGetNewPalEntryFunctionId service of Extended SAL
   PAL Services Services Class. See EsalGetNewPalEntryFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_HI,
            GetNewPalEntryFunctionId,
            PhysicalAddress,
 ,
 ,
 ,
 ,
 ,
+           GetNewPalEntryFunctionId,
+           PhysicalAddress,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetStateBufferFunctionId service of Extended SAL MCA Log Services Class.
   This function is a wrapper for the EsalGetStateBufferFunctionId service of Extended SAL
   MCA Log Services Class. See EsalGetStateBufferFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_HI,
            EsalGetStateBufferFunctionId,
            McaType,
 ,
 ,
 ,
 ,
 ,
+           EsalGetStateBufferFunctionId,
+           McaType,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalSaveStateBufferFunctionId service of Extended SAL MCA Log Services Class.
   This function is a wrapper for the EsalSaveStateBufferFunctionId service of Extended SAL
   MCA Log Services Class. See EsalSaveStateBufferFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_HI,
            EsalSaveStateBufferFunctionId,
            McaType,
 ,
 ,
 ,
 ,
 ,
+           EsalSaveStateBufferFunctionId,
+           McaType,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetVectorsFunctionId service of Extended SAL Base Services Class.
   This function is a wrapper for the EsalGetVectorsFunctionId service of Extended SAL
   Base Services Class. See EsalGetVectorsFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
            EsalGetVectorsFunctionId,
            VectorType,
 ,
 ,
 ,
 ,
 ,
+           EsalGetVectorsFunctionId,
+           VectorType,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalMcGetParamsFunctionId service of Extended SAL Base Services Class.
   This function is a wrapper for the EsalMcGetParamsFunctionId service of Extended SAL
   Base Services Class. See EsalMcGetParamsFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
            EsalMcGetParamsFunctionId,
            ParamInfoType,
 ,
 ,
 ,
 ,
 ,
+           EsalMcGetParamsFunctionId,
+           ParamInfoType,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalMcGetParamsFunctionId service of Extended SAL Base Services Class.
   This function is a wrapper for the EsalMcGetParamsFunctionId service of Extended SAL
   Base Services Class. See EsalMcGetParamsFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
            EsalMcGetMcParamsFunctionId,
 ,
 ,
 ,
 ,
 ,
 ,
+           EsalMcGetMcParamsFunctionId,
+,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetMcCheckinFlagsFunctionId service of Extended SAL Base Services Class.
   This function is a wrapper for the EsalGetMcCheckinFlagsFunctionId service of Extended SAL
   Base Services Class. See EsalGetMcCheckinFlagsFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
            EsalGetMcCheckinFlagsFunctionId,
            CpuIndex,
 ,
 ,
 ,
 ,
 ,
+           EsalGetMcCheckinFlagsFunctionId,
+           CpuIndex,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalAddCpuDataFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalAddCpuDataFunctionId service of Extended SAL
   MP Services Class. See EsalAddCpuDataFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            AddCpuDataFunctionId,
            CpuGlobalId,
            Enabled,
            PalCompatibility,
 ,
 ,
 ,
+           AddCpuDataFunctionId,
+           CpuGlobalId,
+           Enabled,
+           PalCompatibility,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalRemoveCpuDataFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalRemoveCpuDataFunctionId service of Extended SAL
   MP Services Class. See EsalRemoveCpuDataFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            RemoveCpuDataFunctionId,
            CpuGlobalId,
 ,
 ,
 ,
 ,
 ,
+           RemoveCpuDataFunctionId,
+           CpuGlobalId,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalModifyCpuDataFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalModifyCpuDataFunctionId service of Extended SAL
   MP Services Class. See EsalModifyCpuDataFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            ModifyCpuDataFunctionId,
            CpuGlobalId,
            Enabled,
            PalCompatibility,
 ,
 ,
 ,
+           ModifyCpuDataFunctionId,
+           CpuGlobalId,
+           Enabled,
+           PalCompatibility,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetCpuDataByIdFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalGetCpuDataByIdFunctionId service of Extended SAL
   MP Services Class. See EsalGetCpuDataByIdFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            GetCpuDataByIDFunctionId,
            CpuGlobalId,
            IndexByEnabledCpu,
 ,
 ,
 ,
 ,
+           GetCpuDataByIDFunctionId,
+           CpuGlobalId,
+           IndexByEnabledCpu,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetCpuDataByIndexFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalGetCpuDataByIndexFunctionId service of Extended SAL
   MP Services Class. See EsalGetCpuDataByIndexFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            GetCpuDataByIndexFunctionId,
            Index,
            IndexByEnabledCpu,
 ,
 ,
 ,
 ,
+           GetCpuDataByIndexFunctionId,
+           Index,
+           IndexByEnabledCpu,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalWhoAmIFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalWhoAmIFunctionId service of Extended SAL
   MP Services Class. See EsalWhoAmIFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            CurrentProcInfoFunctionId,
            IndexByEnabledCpu,
 ,
 ,
 ,
 ,
 ,
+           CurrentProcInfoFunctionId,
+           IndexByEnabledCpu,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalNumProcessors service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalNumProcessors service of Extended SAL
   MP Services Class. See EsalNumProcessors of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            NumProcessorsFunctionId,
 ,
 ,
 ,
 ,
 ,
 ,
+           NumProcessorsFunctionId,
+,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalSetMinStateFnctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalSetMinStateFnctionId service of Extended SAL
   MP Services Class. See EsalSetMinStateFnctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            SetMinStateFunctionId,
            CpuGlobalId,
            MinStatePointer,
 ,
 ,
 ,
 ,
+           SetMinStateFunctionId,
+           CpuGlobalId,
+           MinStatePointer,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetMinStateFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalGetMinStateFunctionId service of Extended SAL
   MP Services Class. See EsalGetMinStateFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            GetMinStateFunctionId,
            CpuGlobalId,
 ,
 ,
 ,
 ,
 ,
+           GetMinStateFunctionId,
+           CpuGlobalId,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalMcsGetStateInfoFunctionId service of Extended SAL MCA Services Class.
   This function is a wrapper for the EsalMcsGetStateInfoFunctionId service of Extended SAL
   MCA Services Class. See EsalMcsGetStateInfoFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MCA_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MCA_SERVICES_PROTOCOL_GUID_HI,
            McaGetStateInfoFunctionId,
            CpuGlobalId,
 ,
 ,
 ,
 ,
 ,
+           McaGetStateInfoFunctionId,
+           CpuGlobalId,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalMcaRegisterCpuFunctionId service of Extended SAL MCA Services Class.
   This function is a wrapper for the EsalMcaRegisterCpuFunctionId service of Extended SAL
   MCA Services Class. See EsalMcaRegisterCpuFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MCA_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MCA_SERVICES_PROTOCOL_GUID_HI,
            McaRegisterCpuFunctionId,
            CpuGlobalId,
            StateBufferPointer,
 ,
 ,
 ,
 ,
            );
+}
+           McaRegisterCpuFunctionId,
+           CpuGlobalId,
+           StateBufferPointer,
+,
+,
+,
+,
+           );
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeExtendedSalLib/Ipf/AsmExtendedSalLib.s

-              r48674
+              r58466
 //        r10 = Virtual Plabel
 //        r11 = psr
 //
 // As per static calling conventions.
 //
+//
+// As per static calling conventions.
+//
 //--
 //---------------------------------------------------------------------------
 …
 //  in1 = Physical GP
 //
 // Return Value:
+// Return Value:
 //   r8 = EFI_SAL_SUCCESS
 //
 // As per static calling conventions.
 //
+//
+// As per static calling conventions.
+//
 //--
 //---------------------------------------------------------------------------
 …
 .align 32
 EsalEntryPoint:
+EsalEntryPoint:
     data8 0   // Physical Entry
     data8 0   //         GP

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.c

-              r58459
+              r58466
 ReallocateExtractHandlerTable (
+  )
+{
+{
   //
   // Reallocate memory for GuidTable
   //
   mExtractHandlerGuidTable = ReallocatePool (
                                mMaxNumberOfExtractHandler * sizeof (GUID),
                                (mMaxNumberOfExtractHandler + EXTRACT_HANDLER_TABLE_SIZE) * sizeof (GUID),
+                               mMaxNumberOfExtractHandler * sizeof (GUID),
+                               (mMaxNumberOfExtractHandler + EXTRACT_HANDLER_TABLE_SIZE) * sizeof (GUID),
                                mExtractHandlerGuidTable
                              );
 …
   //
   mExtractDecodeHandlerTable = ReallocatePool (
                                mMaxNumberOfExtractHandler * sizeof (EXTRACT_GUIDED_SECTION_DECODE_HANDLER),
                                (mMaxNumberOfExtractHandler + EXTRACT_HANDLER_TABLE_SIZE) * sizeof (EXTRACT_GUIDED_SECTION_DECODE_HANDLER),
+                               mMaxNumberOfExtractHandler * sizeof (EXTRACT_GUIDED_SECTION_DECODE_HANDLER),
+                               (mMaxNumberOfExtractHandler + EXTRACT_HANDLER_TABLE_SIZE) * sizeof (EXTRACT_GUIDED_SECTION_DECODE_HANDLER),
                                mExtractDecodeHandlerTable
                              );
 …
   //
   mExtractGetInfoHandlerTable = ReallocatePool (
                                mMaxNumberOfExtractHandler * sizeof (EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER),
                                (mMaxNumberOfExtractHandler + EXTRACT_HANDLER_TABLE_SIZE) * sizeof (EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER),
+                               mMaxNumberOfExtractHandler * sizeof (EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER),
+                               (mMaxNumberOfExtractHandler + EXTRACT_HANDLER_TABLE_SIZE) * sizeof (EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER),
                                mExtractGetInfoHandlerTable
                              );
 …
     goto Done;
+  }
   //
   // Increase max handler number
 …
     FreePool (mExtractGetInfoHandlerTable);
+  }
   return RETURN_OUT_OF_RESOURCES;
+}
 …
   Sets ExtractHandlerGuidTable so it points at a callee allocated array of registered GUIDs.
   The total number of GUIDs in the array are returned. Since the array of GUIDs is callee allocated
   and caller must treat this array of GUIDs as read-only data.
+  and caller must treat this array of GUIDs as read-only data.
   If ExtractHandlerGuidTable is NULL, then ASSERT().
 …
   If the GUID value specified by SectionGuid has already been registered, then return RETURN_ALREADY_STARTED.
   If there are not enough resources available to register the handlers  then RETURN_OUT_OF_RESOURCES is returned.
   If SectionGuid is NULL, then ASSERT().
   If GetInfoHandler is NULL, then ASSERT().
 …
                              required to actually decode the data in a GUIDed section.
   @param[in]  DecodeHandler  The pointer to a function that decodes a GUIDed section into a caller
                              allocated output buffer.
+                             allocated output buffer.
   @retval  RETURN_SUCCESS           The handlers were registered.
 …
+    }
+  }
   //
   // Check the global table is enough to contain new Handler.
 …
+    }
+  }
   //
   // Register new Handler and guid value.
 …
   optional scratch buffer required to actually decode the data in a GUIDed section.
   Examines a GUIDed section specified by InputSection.
+  Examines a GUIDed section specified by InputSection.
   If GUID for InputSection does not match any of the GUIDs registered through ExtractGuidedSectionRegisterHandlers(),
   then RETURN_UNSUPPORTED is returned.
   If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
+  then RETURN_UNSUPPORTED is returned.
+  If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
   of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER that was registered with ExtractGuidedSectionRegisterHandlers()
   is used to retrieve the OututBufferSize, ScratchSize, and Attributes values. The return status from the handler of
   type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER is returned.
   If InputSection is NULL, then ASSERT().
   If OutputBufferSize is NULL, then ASSERT().
 …
   OUT       UINT32  *OutputBufferSize,
   OUT       UINT32  *ScratchBufferSize,
   OUT       UINT16  *SectionAttribute
+  OUT       UINT16  *SectionAttribute
+  )
+{
 …
   EFI_GUID *SectionDefinitionGuid;
   ASSERT (InputSection != NULL);
+  ASSERT (InputSection != NULL);
   ASSERT (OutputBufferSize != NULL);
   ASSERT (ScratchBufferSize != NULL);
 …
     SectionDefinitionGuid = &(((EFI_GUID_DEFINED_SECTION *) InputSection)->SectionDefinitionGuid);
+  }
   //
   // Search the match registered GetInfo handler for the input guided section.
 …
   //
   // Not found, the input guided section is not supported.
+  // Not found, the input guided section is not supported.
   //
   return RETURN_UNSUPPORTED;
 …
   allocated output buffer.
   Decodes the GUIDed section specified by InputSection.
+  Decodes the GUIDed section specified by InputSection.
   If GUID for InputSection does not match any of the GUIDs registered through ExtractGuidedSectionRegisterHandlers(),
   then RETURN_UNSUPPORTED is returned.
+  then RETURN_UNSUPPORTED is returned.
   If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
   of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER that was registered with ExtractGuidedSectionRegisterHandlers()
 …
   then OutputBuffer is set to point at the data in InputSection.  Otherwise, the decoded data will be placed in caller
   allocated buffer specified by OutputBuffer.    This function is responsible for computing the  EFI_AUTH_STATUS_PLATFORM_OVERRIDE
   bit of in AuthenticationStatus.  The return status from the handler of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER is returned.
+  bit of in AuthenticationStatus.  The return status from the handler of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER is returned.
   If InputSection is NULL, then ASSERT().
   If OutputBuffer is NULL, then ASSERT().
   If ScratchBuffer is NULL and this decode operation requires a scratch buffer, then ASSERT().
   If AuthenticationStatus is NULL, then ASSERT().
+  If AuthenticationStatus is NULL, then ASSERT().
   @param[in]  InputSection   A pointer to a GUIDed section of an FFS formatted file.
   @param[out] OutputBuffer   A pointer to a buffer that contains the result of a decode operation.
   @param[in]  ScratchBuffer  A caller allocated buffer that may be required by this function as a scratch buffer to perform the decode operation.
   @param[out] AuthenticationStatus
+  @param[out] OutputBuffer   A pointer to a buffer that contains the result of a decode operation.
+  @param[in]  ScratchBuffer  A caller allocated buffer that may be required by this function as a scratch buffer to perform the decode operation.
+  @param[out] AuthenticationStatus
                              A pointer to the authentication status of the decoded output buffer. See the definition
                              of authentication status in the EFI_PEI_GUIDED_SECTION_EXTRACTION_PPI section of the PI
 …
   OUT       VOID    **OutputBuffer,
   IN        VOID    *ScratchBuffer,        OPTIONAL
   OUT       UINT32  *AuthenticationStatus
+  OUT       UINT32  *AuthenticationStatus
+  )
+{
   UINT32 Index;
   EFI_GUID *SectionDefinitionGuid;
   //
   // Check the input parameters
 …
   //
   // Not found, the input guided section is not supported.
+  // Not found, the input guided section is not supported.
   //
   return RETURN_UNSUPPORTED;
 …
 /**
   Retrieves handlers of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER and
+  Retrieves handlers of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER and
   EXTRACT_GUIDED_SECTION_DECODE_HANDLER for a specific GUID section type.
   Retrieves the handlers associated with SectionGuid and returns them in
+  Retrieves the handlers associated with SectionGuid and returns them in
   GetInfoHandler and DecodeHandler.
   If the GUID value specified by SectionGuid has not been registered, then
+  If the GUID value specified by SectionGuid has not been registered, then
   return RETURN_NOT_FOUND.
   If SectionGuid is NULL, then ASSERT().
   @param[in]  SectionGuid    A pointer to the GUID associated with the handlersof the GUIDed
+  @param[in]  SectionGuid    A pointer to the GUID associated with the handlersof the GUIDed
                              section type being retrieved.
   @param[out] GetInfoHandler Pointer to a function that examines a GUIDed section and returns
                              the size of the decoded buffer and the size of an optional scratch
                              buffer required to actually decode the data in a GUIDed section.
                              This is an optional parameter that may be NULL. If it is NULL, then
+  @param[out] GetInfoHandler Pointer to a function that examines a GUIDed section and returns
+                             the size of the decoded buffer and the size of an optional scratch
+                             buffer required to actually decode the data in a GUIDed section.
+                             This is an optional parameter that may be NULL. If it is NULL, then
                              the previously registered handler is not returned.
   @param[out] DecodeHandler  Pointer to a function that decodes a GUIDed section into a caller
 …
+  )
+{
   UINT32 Index;
+  UINT32 Index;
   //
 …
   for (Index = 0; Index < mNumberOfExtractHandler; Index ++) {
     if (CompareGuid (&mExtractHandlerGuidTable[Index], SectionGuid)) {
       //
       // If the guided handler has been registered before, then return the registered handlers.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf

r58459	r58466
23	23	MODULE_TYPE = DXE_DRIVER
24	24	VERSION_STRING = 1.0
25		LIBRARY_CLASS = ExtractGuidedSectionLib\|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
	25	LIBRARY_CLASS = ExtractGuidedSectionLib\|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
26	26
27	27	CONSTRUCTOR = DxeExtractGuidedSectionLibConstructor

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeHobLib/DxeHobLib.inf

-              r58459
+              r58466
   MODULE_TYPE                    = DXE_DRIVER
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = HobLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER SMM_CORE DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
+  LIBRARY_CLASS                  = HobLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER SMM_CORE DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
   CONSTRUCTOR                    = HobLibConstructor
 …
   DebugLib
   UefiLib
 [Guids]
   gEfiHobListGuid                               ## CONSUMES  ## SystemTable

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeHobLib/HobLib.c

-              r58459
+              r58466
 /**
   The constructor function caches the pointer to HOB list.
   The constructor function gets the start address of HOB list from system configuration table.
   It will ASSERT() if that operation fails and it will always return EFI_SUCCESS.
+  It will ASSERT() if that operation fails and it will always return EFI_SUCCESS.
   @param  ImageHandle   The firmware allocated handle for the EFI image.
   @param  SystemTable   A pointer to the EFI System Table.
   @retval EFI_SUCCESS   The constructor successfully gets HobList.
   @retval Other value   The constructor can't get HobList.
 …
   This function returns the pointer to first HOB in the list.
   For PEI phase, the PEI service GetHobList() can be used to retrieve the pointer
+  For PEI phase, the PEI service GetHobList() can be used to retrieve the pointer
   to the HOB list.  For the DXE phase, the HOB list pointer can be retrieved through
   the EFI System Table by looking up theHOB list GUID in the System Configuration Table.
   Since the System Configuration Table does not exist that the time the DXE Core is
   launched, the DXE Core uses a global variable from the DXE Core Entry Point Library
+  Since the System Configuration Table does not exist that the time the DXE Core is
+  launched, the DXE Core uses a global variable from the DXE Core Entry Point Library
   to manage the pointer to the HOB list.
   If the pointer to the HOB list is NULL, then ASSERT().
   @return The pointer to the HOB list.
 …
   Returns the next instance of a HOB type from the starting HOB.
   This function searches the first instance of a HOB type from the starting HOB pointer.
+  This function searches the first instance of a HOB type from the starting HOB pointer.
   If there does not exist such HOB type from the starting HOB pointer, it will return NULL.
   In contrast with macro GET_NEXT_HOB(), this function does not skip the starting HOB pointer
   unconditionally: it returns HobStart back if HobStart itself meets the requirement;
   caller is required to use GET_NEXT_HOB() if it wishes to skip current HobStart.
   If HobStart is NULL, then ASSERT().
 …
   ASSERT (HobStart != NULL);
   Hob.Raw = (UINT8 *) HobStart;
   //
 …
   Returns the first instance of a HOB type among the whole HOB list.
   This function searches the first instance of a HOB type among the whole HOB list.
   If there does not exist such HOB type in the HOB list, it will return NULL.
+  This function searches the first instance of a HOB type among the whole HOB list.
+  If there does not exist such HOB type in the HOB list, it will return NULL.
   If the pointer to the HOB list is NULL, then ASSERT().
 …
 /**
   Returns the next instance of the matched GUID HOB from the starting HOB.
   This function searches the first instance of a HOB from the starting HOB pointer.
   Such HOB should satisfy two conditions:
   its HOB type is EFI_HOB_TYPE_GUID_EXTENSION and its GUID Name equals to the input Guid.
   If there does not exist such HOB from the starting HOB pointer, it will return NULL.
+  This function searches the first instance of a HOB from the starting HOB pointer.
+  Such HOB should satisfy two conditions:
+  its HOB type is EFI_HOB_TYPE_GUID_EXTENSION and its GUID Name equals to the input Guid.
+  If there does not exist such HOB from the starting HOB pointer, it will return NULL.
   Caller is required to apply GET_GUID_HOB_DATA () and GET_GUID_HOB_DATA_SIZE ()
   to extract the data section and its size information, respectively.
 …
   unconditionally: it returns HobStart back if HobStart itself meets the requirement;
   caller is required to use GET_NEXT_HOB() if it wishes to skip current HobStart.
   If Guid is NULL, then ASSERT().
   If HobStart is NULL, then ASSERT().
 …
 /**
   Returns the first instance of the matched GUID HOB among the whole HOB list.
   This function searches the first instance of a HOB among the whole HOB list.
+  This function searches the first instance of a HOB among the whole HOB list.
   Such HOB should satisfy two conditions:
   its HOB type is EFI_HOB_TYPE_GUID_EXTENSION and its GUID Name equals to the input Guid.
 …
   Caller is required to apply GET_GUID_HOB_DATA () and GET_GUID_HOB_DATA_SIZE ()
   to extract the data section and its size information, respectively.
   If the pointer to the HOB list is NULL, then ASSERT().
   If Guid is NULL, then ASSERT().
 …
   Get the system boot mode from the HOB list.
   This function returns the system boot mode information from the
+  This function returns the system boot mode information from the
   PHIT HOB in HOB list.
   If the pointer to the HOB list is NULL, then ASSERT().
   @param  VOID
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If ModuleName is NULL, then ASSERT().
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
 /**
   Builds a customized HOB tagged with a GUID for identification and returns
+  Builds a customized HOB tagged with a GUID for identification and returns
   the start address of GUID HOB data.
   This function builds a customized HOB tagged with a GUID for identification
   and returns the start address of GUID HOB data so that caller can fill the customized data.
+  This function builds a customized HOB tagged with a GUID for identification
+  and returns the start address of GUID HOB data so that caller can fill the customized data.
   The HOB Header and Name field is already stripped.
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If Guid is NULL, then ASSERT().
   If there is no additional space for HOB creation, then ASSERT().
 …
 /**
   Builds a customized HOB tagged with a GUID for identification, copies the input data to the HOB
+  Builds a customized HOB tagged with a GUID for identification, copies the input data to the HOB
   data field, and returns the start address of the GUID HOB data.
   This function builds a customized HOB tagged with a GUID for identification and copies the input
   data to the HOB data field and returns the start address of the GUID HOB data.  It can only be
   invoked during PEI phase; for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
+  data to the HOB data field and returns the start address of the GUID HOB data.  It can only be
+  invoked during PEI phase; for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   The HOB Header and Name field is already stripped.
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If Guid is NULL, then ASSERT().
   If Data is NULL and DataLength > 0, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   @param  FvName        The name of the Firmware Volume.
   @param  FileName      The name of the file.
 **/
 VOID
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If the platform does not support Capsule Volume HOBs, then ASSERT().
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeHstiLib/HstiAip.c

-              r58464
+              r58466
   This function returns information of type InformationType from the adapter.
   If an adapter does not support the requested informational type, then
   EFI_UNSUPPORTED is returned.
+  EFI_UNSUPPORTED is returned.
   @param[in]  This                   A pointer to the EFI_ADAPTER_INFORMATION_PROTOCOL instance.
 …
   @retval EFI_DEVICE_ERROR           The device reported an error.
   @retval EFI_OUT_OF_RESOURCES       The request could not be completed due to a lack of resources.
   @retval EFI_INVALID_PARAMETER      This is NULL.
   @retval EFI_INVALID_PARAMETER      InformationBlock is NULL.
+  @retval EFI_INVALID_PARAMETER      This is NULL.
+  @retval EFI_INVALID_PARAMETER      InformationBlock is NULL.
   @retval EFI_INVALID_PARAMETER      InformationBlockSize is NULL.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeHstiLib/HstiDxe.c

-              r58464
+              r58466
     Hsti = InformationBlock;
     if ((Hsti->Role == Role) &&
+    if ((Hsti->Role == Role) &&
         ((ImplementationID == NULL) || (StrCmp (ImplementationID, Hsti->ImplementationID) == 0))) {
       break;
 …
   HstiAip->HstiSize = HstiSize;
   HstiAip->HstiMaxSize = HstiSize;
   Handle = NULL;
   Status = gBS->InstallMultipleProtocolInterfaces (

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h

-              r48674
+              r58466
 /** @file
   Internal include file of DXE CPU IO2 Library.
   Copyright (c) 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials are licensed and made available
 …
   @param  Width         The width of the I/O operation.
   @param  Data          The value to write to the I/O port.
   @return Data read from registers in the EFI system memory space.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeIoLibCpuIo2/DxeIoLibCpuIo2.inf

r58459	r58466
6	6	# Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved.<BR>
7	7	# This program and the accompanying materials are licensed and made available
8		# under the terms and conditions of the BSD License which accompanies this
	8	# under the terms and conditions of the BSD License which accompanies this
9	9	# distribution. The full text of the license may be found at
10	10	# http://opensource.org/licenses/bsd-license.php.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeIoLibCpuIo2/IoLib.c

-              r48674
+              r58466
 /** @file
   I/O Library instance based on EFI_CPU_IO2_PROTOCOL.
   Copyright (c) 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials are licensed and made available
 …
   @param  Width         The width of the I/O operation.
   @param  Data          The value to write to the I/O port.
   @return Data read from registers in the EFI system memory space.
 …
   If Port is not aligned on a 16-bit boundary, then ASSERT().
   If 16-bit I/O port operations are not supported, then ASSERT().
 …
   This function must guarantee that all I/O read and write operations are
   serialized.
   If Port is not aligned on a 32-bit boundary, then ASSERT().
 …
   If Port is not aligned on a 64-bit boundary, then ASSERT().
   If 64-bit I/O port operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 16-bit boundary, then ASSERT().
   If 16-bit MMIO register operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 16-bit boundary, then ASSERT().
   If 16-bit MMIO register operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 32-bit boundary, then ASSERT().
   If 32-bit MMIO register operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 32-bit boundary, then ASSERT().
   If 32-bit MMIO register operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 64-bit boundary, then ASSERT().
   If 64-bit MMIO register operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 64-bit boundary, then ASSERT().
   If 64-bit MMIO register operations are not supported, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeIoLibCpuIo2/IoLibMmioBuffer.c

-              r48674
+              r58466
   If Length is not aligned on a 16-bit boundary, then ASSERT().
   If Buffer is not aligned on a 16-bit boundary, then ASSERT().
 …
   If Length is not aligned on a 64-bit boundary, then ASSERT().
   If Buffer is not aligned on a 64-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeIoLibEsal/DxeIoLibEsal.inf

r58459	r58466
7	7	# Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
8	8	# This program and the accompanying materials are licensed and made available
9		# under the terms and conditions of the BSD License which accompanies this
	9	# under the terms and conditions of the BSD License which accompanies this
10	10	# distribution. The full text of the license may be found at
11	11	# http://opensource.org/licenses/bsd-license.php.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeIoLibEsal/DxeIoLibEsalInternal.h

r48674	r58466
1	1	/** @file
2	2	Internal include file for the I/O Library using ESAL services.
3
	3
4	4	Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
5	5	This program and the accompanying materials are licensed and made available

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeIoLibEsal/IoLib.c

-              r48674
+              r58466
                 EFI_EXTENDED_SAL_BASE_IO_SERVICES_PROTOCOL_GUID_LO,
                 EFI_EXTENDED_SAL_BASE_IO_SERVICES_PROTOCOL_GUID_HI,
                 IoReadFunctionId,
                 (UINT64)Width,
                 Port,
 ,
                 (UINT64)&Data,
 ,
 ,
+                IoReadFunctionId,
+                (UINT64)Width,
+                Port,
+,
+                (UINT64)&Data,
+,
+,
                 );
 …
                 EFI_EXTENDED_SAL_BASE_IO_SERVICES_PROTOCOL_GUID_LO,
                 EFI_EXTENDED_SAL_BASE_IO_SERVICES_PROTOCOL_GUID_HI,
                 IoWriteFunctionId,
                 (UINT64)Width,
                 Port,
 ,
                 (UINT64)&Data,
 ,
 ,
+                IoWriteFunctionId,
+                (UINT64)Width,
+                Port,
+,
+                (UINT64)&Data,
+,
+,
                 );
 …
                 EFI_EXTENDED_SAL_BASE_IO_SERVICES_PROTOCOL_GUID_LO,
                 EFI_EXTENDED_SAL_BASE_IO_SERVICES_PROTOCOL_GUID_HI,
                 MemReadFunctionId,
                 (UINT64)Width,
                 Address,
 ,
                 (UINT64)&Data,
 ,
 ,
+                MemReadFunctionId,
+                (UINT64)Width,
+                Address,
+,
+                (UINT64)&Data,
+,
+,
                 );
 …
                 EFI_EXTENDED_SAL_BASE_IO_SERVICES_PROTOCOL_GUID_LO,
                 EFI_EXTENDED_SAL_BASE_IO_SERVICES_PROTOCOL_GUID_HI,
                 MemWriteFunctionId,
                 (UINT64)Width,
                 Address,
 ,
                 (UINT64)&Data,
 ,
 ,
+                MemWriteFunctionId,
+                (UINT64)Width,
+                Address,
+,
+                (UINT64)&Data,
+,
+,
                 );

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeIoLibEsal/IoLibMmioBuffer.c

-              r48674
+              r58466
   Copy data from MMIO region to system memory by using 8-bit access.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 8-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 8-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
   ReturnBuffer = Buffer;
   while (Length-- > 0) {
     *(Buffer++) = MmioRead8 (StartAddress++);
 …
   Copy data from MMIO region to system memory by using 16-bit access.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 16-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 16-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 16-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT16) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ASSERT ((Length & (sizeof (UINT16) - 1)) == 0);
   ASSERT (((UINTN) Buffer & (sizeof (UINT16) - 1)) == 0);
   ReturnBuffer = Buffer;
   while (Length > 0) {
     *(Buffer++) = MmioRead16 (StartAddress);
 …
   Copy data from MMIO region to system memory by using 32-bit access.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 32-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 32-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 32-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT32) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ASSERT ((Length & (sizeof (UINT32) - 1)) == 0);
   ASSERT (((UINTN) Buffer & (sizeof (UINT32) - 1)) == 0);
   ReturnBuffer = Buffer;
   while (Length > 0) {
     *(Buffer++) = MmioRead32 (StartAddress);
 …
   Copy data from MMIO region to system memory by using 64-bit access.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 64-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 64-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 64-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT64) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ASSERT ((Length & (sizeof (UINT64) - 1)) == 0);
   ASSERT (((UINTN) Buffer & (sizeof (UINT64) - 1)) == 0);
   ReturnBuffer = Buffer;
   while (Length > 0) {
     *(Buffer++) = MmioRead64 (StartAddress);
 …
   Copy data from system memory to MMIO region by using 8-bit access.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 8-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 8-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
   ReturnBuffer = (UINT8 *) Buffer;
   while (Length-- > 0) {
      MmioWrite8 (StartAddress++, *(Buffer++));
 …
   return ReturnBuffer;
+}
 …
   Copy data from system memory to MMIO region by using 16-bit access.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 16-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 16-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 16-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT16) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ReturnBuffer = (UINT16 *) Buffer;
   while (Length > 0) {
     MmioWrite16 (StartAddress, *(Buffer++));
     StartAddress += sizeof (UINT16);
     Length -= sizeof (UINT16);
 …
   Copy data from system memory to MMIO region by using 32-bit access.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 32-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 32-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 32-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT32) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ReturnBuffer = (UINT32 *) Buffer;
   while (Length > 0) {
     MmioWrite32 (StartAddress, *(Buffer++));
     StartAddress += sizeof (UINT32);
     Length -= sizeof (UINT32);
 …
   Copy data from system memory to MMIO region by using 64-bit access.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 64-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 64-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 64-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT64) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ReturnBuffer = (UINT64 *) Buffer;
   while (Length > 0) {
     MmioWrite64 (StartAddress, *(Buffer++));
     StartAddress += sizeof (UINT64);
     Length -= sizeof (UINT64);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxePalLibEsal/DxePalLibEsal.c

-              r48674
+              r58466
                 EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_LO,
                 EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_HI,
                 PalProcFunctionId,
                 Index,
                 Arg2,
                 Arg3,
                 Arg4,
 ,
 ,
+                PalProcFunctionId,
+                Index,
+                Arg2,
+                Arg3,
+                Arg4,
+,
+,
                 );

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxePalLibEsal/DxePalLibEsal.inf

r58459	r58466
20	20	MODULE_TYPE = DXE_DRIVER
21	21	VERSION_STRING = 1.0
22		LIBRARY_CLASS = PalLib\|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION
	22	LIBRARY_CLASS = PalLib\|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION
23	23
24	24	#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxePcdLib/DxePcdLib.c

-              r58459
+              r58466
 Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php
 THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+This program and the accompanying materials
+are licensed and made available under the terms and conditions of the BSD License
+which accompanies this distribution.  The full text of the license may be found at
+http://opensource.org/licenses/bsd-license.php
+THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 …
   if (mPiPcd == NULL) {
     //
     // PI Pcd protocol defined in PI 1.2 vol3 should be installed before the module
+    // PI Pcd protocol defined in PI 1.2 vol3 should be installed before the module
     // access DynamicEx type PCD.
     //
 …
     // PCD protocol need to be installed before the module access Dynamic type PCD.
     // But dynamic type PCD is not required in PI 1.2 specification.
     //
+    //
     Status = gBS->LocateProtocol (&gPcdProtocolGuid, NULL, (VOID **)&mPcd);
     ASSERT_EFI_ERROR (Status);
 …
 GetPcdInfoProtocolPointer (
   VOID
+  )
+  )
+{
   EFI_STATUS  Status;
 …
   Sets the current SKU in the PCD database to the value specified by SkuId.  SkuId is returned.
   If SkuId >= PCD_MAX_SKU_ID, then ASSERT().
+  If SkuId >= PCD_MAX_SKU_ID, then ASSERT().
   @param  SkuId   The SKU value that will be used when the PCD service retrieves and sets values
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 8-bit value for the token specified by TokenNumber.
+  Returns the 8-bit value for the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the 8-bit value for the token specified by TokenNumber.
+  @return Returns the 8-bit value for the token specified by TokenNumber.
 **/
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 16-bit value for the token specified by TokenNumber.
+  Returns the 16-bit value for the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the 16-bit value for the token specified by TokenNumber.
+  @return Returns the 16-bit value for the token specified by TokenNumber.
 **/
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 32-bit value for the token specified by TokenNumber.
+  Returns the 32-bit value for the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 64-bit value for the token specified by TokenNumber.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the pointer to the buffer of the token specified by TokenNumber.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the Boolean value of the token specified by TokenNumber.
+  Returns the Boolean value of the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the Boolean value of the token specified by TokenNumber.
 **/
 BOOLEAN
+  @return Returns the Boolean value of the token specified by TokenNumber.
+**/
+BOOLEAN
 EFIAPI
 LibPcdGetBool (
 …
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the size of the token specified by TokenNumber.
+  @return Returns the size of the token specified by TokenNumber.
 **/
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 8-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid         The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid         The pointer to a 128-bit unique value that designates
                            which namespace to retrieve a value from.
   @param[in]  TokenNumber  The PCD token number to retrieve a current value for.
 …
+{
   ASSERT (Guid != NULL);
   return GetPiPcdProtocol()->Get8 (Guid, TokenNumber);
+}
 …
   Returns the 16-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid         The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid         The pointer to a 128-bit unique value that designates
                            which namespace to retrieve a value from.
   @param[in]  TokenNumber  The PCD token number to retrieve a current value for.
 …
 /**
   Returns the 32-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid         The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid         The pointer to a 128-bit unique value that designates
                            which namespace to retrieve a value from.
   @param[in]  TokenNumber  The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 64-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
+{
   ASSERT (Guid != NULL);
   return GetPiPcdProtocol()->Get64 (Guid, TokenNumber);
+}
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the pointer to the buffer of token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the Boolean value of the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  Returns the Boolean value of the token specified by TokenNumber and Guid.
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve the size of a given PCD token.
   Returns the size of the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  Returns the size of the token specified by TokenNumber and Guid.
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 8-bit value for the token specified by TokenNumber
+  Sets the 8-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
   Status = GetPcdProtocol()->Set8 (TokenNumber, Value);
   ASSERT_EFI_ERROR (Status);
   return Value;
+}
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 16-bit value for the token specified by TokenNumber
+  Sets the 16-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
   Status = GetPcdProtocol()->Set16 (TokenNumber, Value);
   ASSERT_EFI_ERROR (Status);
   return Value;
+}
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 32-bit value for the token specified by TokenNumber
+  Sets the 32-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
+{
   EFI_STATUS Status;
   Status = GetPcdProtocol()->Set32 (TokenNumber, Value);
   ASSERT_EFI_ERROR (Status);
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 64-bit value for the token specified by TokenNumber
+  Sets the 64-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  TokenNumber   The PCD token number to set a current value for.
   @param[in]  Value         The 64-bit value to set.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets a buffer for the token specified by TokenNumber to the value
   specified by Buffer and SizeOfBuffer.  Buffer is returned.
   If SizeOfBuffer is greater than the maximum size support by TokenNumber,
   then set SizeOfBuffer to the maximum size supported by TokenNumber and
+  Sets a buffer for the token specified by TokenNumber to the value
+  specified by Buffer and SizeOfBuffer.  Buffer is returned.
+  If SizeOfBuffer is greater than the maximum size support by TokenNumber,
+  then set SizeOfBuffer to the maximum size supported by TokenNumber and
   return NULL to indicate that the set operation was not actually performed,
   or ASSERT() if the set operation was not correctly performed.
   If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to the
+  If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to the
   maximum size supported by TokenName and NULL must be returned.
   If SizeOfBuffer is NULL, then ASSERT().
   If SizeOfBuffer > 0 and Buffer is NULL, then ASSERT().
   @param[in]      TokenNumber   The PCD token number to set a current value for.
   @param[in, out] SizeOfBuffer  The size, in bytes, of Buffer.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the Boolean value for the token specified by TokenNumber
+  Sets the Boolean value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 8-bit value for the token specified by TokenNumber and
+  Sets the 8-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 16-bit value for the token specified by TokenNumber and
+  Sets the 16-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 32-bit value for the token specified by TokenNumber and
+  Sets the 32-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 64-bit value for the token specified by TokenNumber and
+  Sets the 64-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets a buffer for the token specified by TokenNumber to the value specified by
   Buffer and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
   the maximum size support by TokenNumber, then set SizeOfBuffer to the maximum size
   supported by TokenNumber and return NULL to indicate that the set operation
+  Sets a buffer for the token specified by TokenNumber to the value specified by
+  Buffer and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
+  the maximum size support by TokenNumber, then set SizeOfBuffer to the maximum size
+  supported by TokenNumber and return NULL to indicate that the set operation
   was not actually performed, or ASSERT() if the set operation was not corretly performed.
   If Guid is NULL, then ASSERT().
   If SizeOfBuffer is NULL, then ASSERT().
   If SizeOfBuffer > 0 and Buffer is NULL, then ASSERT().
   @param[in]  Guid              The pointer to a 128-bit unique value that
+  @param[in]  Guid              The pointer to a 128-bit unique value that
                                 designates which namespace to set a value from.
   @param[in]  TokenNumber       The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the Boolean value for the token specified by TokenNumber and
+  Sets the Boolean value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   Set up a notification function that is called when a specified token is set.
   When the token specified by TokenNumber and Guid is set,
   then notification function specified by NotificationFunction is called.
+  When the token specified by TokenNumber and Guid is set,
+  then notification function specified by NotificationFunction is called.
   If Guid is NULL, then the default token space is used.
   If NotificationFunction is NULL, then ASSERT().
   @param[in]  Guid                  The pointer to a 128-bit unique value that designates which
                                     namespace to set a value from.  If NULL, then the default
+  @param[in]  Guid                  The pointer to a 128-bit unique value that designates which
+                                    namespace to set a value from.  If NULL, then the default
                                     token space is used.
   @param[in]  TokenNumber           The PCD token number to monitor.
   @param[in]  NotificationFunction  The function to call when the token
+  @param[in]  NotificationFunction  The function to call when the token
                                     specified by Guid and TokenNumber is set.
 …
 /**
   Disable a notification function that was established with LibPcdCallbackonSet().
   Disable a notification function that was previously established with LibPcdCallbackOnSet().
   If NotificationFunction is NULL, then ASSERT().
   If LibPcdCallbackOnSet() was not previously called with Guid, TokenNumber,
+  If LibPcdCallbackOnSet() was not previously called with Guid, TokenNumber,
   and NotificationFunction, then ASSERT().
   @param[in]  Guid                 Specify the GUID token space.
   @param[in]  TokenNumber          Specify the token number.
 …
   ASSERT (NotificationFunction != NULL);
   Status = GetPiPcdProtocol()->CancelCallback (Guid, TokenNumber, (EFI_PCD_PROTOCOL_CALLBACK) NotificationFunction);
   ASSERT_EFI_ERROR (Status);
 …
 /**
   Retrieves the next token in a token space.
   Retrieves the next PCD token number from the token space specified by Guid.
   If Guid is NULL, then the default token space is used.  If TokenNumber is 0,
   then the first token number is returned.  Otherwise, the token number that
   follows TokenNumber in the token space is returned.  If TokenNumber is the last
   token number in the token space, then 0 is returned.
+  Retrieves the next PCD token number from the token space specified by Guid.
+  If Guid is NULL, then the default token space is used.  If TokenNumber is 0,
+  then the first token number is returned.  Otherwise, the token number that
+  follows TokenNumber in the token space is returned.  If TokenNumber is the last
+  token number in the token space, then 0 is returned.
   If TokenNumber is not 0 and is not in the token space specified by Guid, then ASSERT().
   @param[in]  Guid        The pointer to a 128-bit unique value that designates which namespace
+  @param[in]  Guid        The pointer to a 128-bit unique value that designates which namespace
                           to set a value from.  If NULL, then the default token space is used.
   @param[in]  TokenNumber The previous PCD token number.  If 0, then retrieves the first PCD
+  @param[in]  TokenNumber The previous PCD token number.  If 0, then retrieves the first PCD
                           token number.
 …
 **/
 UINTN
+UINTN
 EFIAPI
 LibPcdGetNextToken (
 …
 /**
   Used to retrieve the list of available PCD token space GUIDs.
   Returns the PCD token space GUID that follows TokenSpaceGuid in the list of token spaces
   in the platform.
   If TokenSpaceGuid is NULL, then a pointer to the first PCD token spaces returned.
   If TokenSpaceGuid is the last PCD token space GUID in the list, then NULL is returned.
   @param  TokenSpaceGuid  The pointer to the a PCD token space GUID.
 …
 /**
   Sets a value of a patchable PCD entry that is type pointer.
   Sets the PCD entry specified by PatchVariable to the value specified by Buffer
   and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
   MaximumDatumSize, then set SizeOfBuffer to MaximumDatumSize and return
   NULL to indicate that the set operation was not actually performed.
   If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to
+  Sets the PCD entry specified by PatchVariable to the value specified by Buffer
+  and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
+  MaximumDatumSize, then set SizeOfBuffer to MaximumDatumSize and return
+  NULL to indicate that the set operation was not actually performed.
+  If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to
   MaximumDatumSize and NULL must be returned.
   If PatchVariable is NULL, then ASSERT().
   If SizeOfBuffer is NULL, then ASSERT().
   If SizeOfBuffer > 0 and Buffer is NULL, then ASSERT().
   @param[in] PatchVariable      A pointer to the global variable in a module that is
+  @param[in] PatchVariable      A pointer to the global variable in a module that is
                                 the target of the set operation.
   @param[in] MaximumDatumSize   The maximum size allowed for the PCD entry specified by PatchVariable.
   @param[in, out] SizeOfBuffer  A pointer to the size, in bytes, of Buffer.
   @param[in] Buffer             A pointer to the buffer to used to set the target variable.
   @return Return the pointer to the buffer been set.
 …
   ASSERT (PatchVariable != NULL);
   ASSERT (SizeOfBuffer  != NULL);
   if (*SizeOfBuffer > 0) {
     ASSERT (Buffer != NULL);
 …
     return NULL;
+  }
   CopyMem (PatchVariable, Buffer, *SizeOfBuffer);
   return (VOID *) Buffer;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxePcdLib/DxePcdLib.inf

-              r58459
+              r58466
 #      It is EDKII implementation which support Dynamic/DynamicEx Pcds.
 #   2) EFI_PCD_PROTOCOL
 #      It is defined by PI specification 1.2, Vol 3 which only support dynamicEx
+#      It is defined by PI specification 1.2, Vol 3 which only support dynamicEx
 #      type Pcd.
+#
 …
 # EFI_PCD_PROTOCOL to handle dynamicEx type PCD.
+#
 # Note: A driver of type DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER can only use this DxePcdLib
 #  in their initialization without any issues to access Dynamic and DynamicEx PCD. They can't
+# Note: A driver of type DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER can only use this DxePcdLib
+#  in their initialization without any issues to access Dynamic and DynamicEx PCD. They can't
 #  access Dynamic and DynamicEx PCD in the implementation of runtime services and SMI handlers.
 #  Because EFI_PCD_PROTOCOL is DXE protocol that is not aviable in OS runtime phase.
+#  Because EFI_PCD_PROTOCOL is DXE protocol that is not aviable in OS runtime phase.
+#
 # Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
 …
   MODULE_TYPE                    = DXE_DRIVER
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = PcdLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_APPLICATION UEFI_DRIVER
+  LIBRARY_CLASS                  = PcdLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_APPLICATION UEFI_DRIVER
+#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeRuntimeExtendedSalLib/DxeRuntimeExtendedSalLib.inf

r58459	r58466
20	20	MODULE_TYPE = DXE_RUNTIME_DRIVER
21	21	VERSION_STRING = 1.0
22		LIBRARY_CLASS = ExtendedSalLib\|DXE_RUNTIME_DRIVER DXE_SAL_DRIVER
	22	LIBRARY_CLASS = ExtendedSalLib\|DXE_RUNTIME_DRIVER DXE_SAL_DRIVER
23	23	CONSTRUCTOR = DxeRuntimeExtendedSalLibConstruct
24	24	DESTRUCTOR = DxeRuntimeExtendedSalLibDeconstruct

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeRuntimeExtendedSalLib/ExtendedSalLib.c

-              r48674
+              r58466
   Constructor function to initializes physical plabel of ESAL entrypoint and register an event
   for initialization of virtual plabel of ESAL entrypoint.
   This is the library constructor function to call a function to initialize physical plabel of ESAL entrypoint
   and to register notification function for
+  and to register notification function for
   EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE, which sets virtual plabel of ESAL entrypoint.
 …
 /**
   Destructor function to close the event created by the library constructor
   This is the library destructor function to close the event with type of
+  Destructor function to close the event created by the library constructor
+  This is the library destructor function to close the event with type of
   EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE, which is created by the library constructor.
 …
 /**
   Registers function of ESAL class and it's associated global.
   This function registers function of ESAL class, together with its associated global.
   It is worker function for RegisterEsalClass().
 …
 /**
   Registers ESAL Class and it's associated global.
   This function registers one or more Extended SAL services in a given
   class along with the associated global context.
 …
   @retval EFI_UNSUPPORTED      This function was called after ExitBootServices().
   @retval EFI_OUT_OF_RESOURCES There are not enough resources available to register one or more of the specified services.
   @retval Other                ClassGuid could not be installed onto a new handle.
+  @retval Other                ClassGuid could not be installed onto a new handle.
 **/
 …
 /**
   Calls an Extended SAL Class service that was previously registered with RegisterEsalClass().
   This function gets the entrypoint of Extended SAL, and calls an Extended SAL Class service
   that was previously registered with RegisterEsalClass() through this entrypoint.
 …
   @param  Arg7            Argument 7 ClassGuid/FunctionId defined
   @param  Arg8            Argument 8 ClassGuid/FunctionId defined
   @retval EFI_SAL_SUCCESS ESAL procedure successfully called.
   @retval EFI_SAL_ERROR   The address of ExtendedSalProc() can not be correctly
                           initialized.
   @retval Other           Status returned from ExtendedSalProc() service of
                           EXTENDED_SAL_BOOT_SERVICE_PROTOCOL.
+                          EXTENDED_SAL_BOOT_SERVICE_PROTOCOL.
 **/
 …
 /**
   Wrapper for the EsalStallFunctionId service of Extended SAL Stall Services Class.
   This function is a wrapper for the EsalStallFunctionId service of Extended SAL
   Stall Services Class. See EsalStallFunctionId of Extended SAL Specification.
 …
+{
   return EsalCall (
            EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_HI,
            StallFunctionId,
            Microseconds,
 ,
 ,
 ,
 ,
 ,
+           EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_LO,
+           EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_HI,
+           StallFunctionId,
+           Microseconds,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalSetNewPalEntryFunctionId service of Extended SAL PAL Services Services Class.
   This function is a wrapper for the EsalSetNewPalEntryFunctionId service of Extended SAL
   PAL Services Services Class. See EsalSetNewPalEntryFunctionId of Extended SAL Specification.
 …
+{
   return EsalCall (
            EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_LO,
+           EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_HI,
            SetNewPalEntryFunctionId,
            PhysicalAddress,
            PalEntryPoint,
 ,
 ,
 ,
 ,
+           SetNewPalEntryFunctionId,
+           PhysicalAddress,
+           PalEntryPoint,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetNewPalEntryFunctionId service of Extended SAL PAL Services Services Class.
   This function is a wrapper for the EsalGetNewPalEntryFunctionId service of Extended SAL
   PAL Services Services Class. See EsalGetNewPalEntryFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_HI,
            GetNewPalEntryFunctionId,
            PhysicalAddress,
 ,
 ,
 ,
 ,
 ,
+           GetNewPalEntryFunctionId,
+           PhysicalAddress,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetStateBufferFunctionId service of Extended SAL MCA Log Services Class.
   This function is a wrapper for the EsalGetStateBufferFunctionId service of Extended SAL
   MCA Log Services Class. See EsalGetStateBufferFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_HI,
            EsalGetStateBufferFunctionId,
            McaType,
 ,
 ,
 ,
 ,
 ,
+           EsalGetStateBufferFunctionId,
+           McaType,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalSaveStateBufferFunctionId service of Extended SAL MCA Log Services Class.
   This function is a wrapper for the EsalSaveStateBufferFunctionId service of Extended SAL
   MCA Log Services Class. See EsalSaveStateBufferFunctionId of Extended SAL Specification.
   @param  McaType         See type parameter of SAL Procedure SAL_GET_STATE_INFO.
 …
            EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_HI,
            EsalSaveStateBufferFunctionId,
            McaType,
 ,
 ,
 ,
 ,
 ,
+           EsalSaveStateBufferFunctionId,
+           McaType,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetVectorsFunctionId service of Extended SAL Base Services Class.
   This function is a wrapper for the EsalGetVectorsFunctionId service of Extended SAL
   Base Services Class. See EsalGetVectorsFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
            EsalGetVectorsFunctionId,
            VectorType,
 ,
 ,
 ,
 ,
 ,
+           EsalGetVectorsFunctionId,
+           VectorType,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalMcGetParamsFunctionId service of Extended SAL Base Services Class.
   This function is a wrapper for the EsalMcGetParamsFunctionId service of Extended SAL
   Base Services Class. See EsalMcGetParamsFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
            EsalMcGetParamsFunctionId,
            ParamInfoType,
 ,
 ,
 ,
 ,
 ,
+           EsalMcGetParamsFunctionId,
+           ParamInfoType,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalMcGetParamsFunctionId service of Extended SAL Base Services Class.
   This function is a wrapper for the EsalMcGetParamsFunctionId service of Extended SAL
   Base Services Class. See EsalMcGetParamsFunctionId of Extended SAL Specification.
   @retval EFI_SAL_SUCCESS          Call completed without error.
   @retval EFI_SAL_NO_INFORMATION   The requested vector has not been registered
 …
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
            EsalMcGetMcParamsFunctionId,
 ,
 ,
 ,
 ,
 ,
 ,
+           EsalMcGetMcParamsFunctionId,
+,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetMcCheckinFlagsFunctionId service of Extended SAL Base Services Class.
   This function is a wrapper for the EsalGetMcCheckinFlagsFunctionId service of Extended SAL
   Base Services Class. See EsalGetMcCheckinFlagsFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
            EsalGetMcCheckinFlagsFunctionId,
            CpuIndex,
 ,
 ,
 ,
 ,
 ,
+           EsalGetMcCheckinFlagsFunctionId,
+           CpuIndex,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalAddCpuDataFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalAddCpuDataFunctionId service of Extended SAL
   MP Services Class. See EsalAddCpuDataFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            AddCpuDataFunctionId,
            CpuGlobalId,
            Enabled,
            PalCompatibility,
 ,
 ,
 ,
+           AddCpuDataFunctionId,
+           CpuGlobalId,
+           Enabled,
+           PalCompatibility,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalRemoveCpuDataFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalRemoveCpuDataFunctionId service of Extended SAL
   MP Services Class. See EsalRemoveCpuDataFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            RemoveCpuDataFunctionId,
            CpuGlobalId,
 ,
 ,
 ,
 ,
 ,
+           RemoveCpuDataFunctionId,
+           CpuGlobalId,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalModifyCpuDataFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalModifyCpuDataFunctionId service of Extended SAL
   MP Services Class. See EsalModifyCpuDataFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            ModifyCpuDataFunctionId,
            CpuGlobalId,
            Enabled,
            PalCompatibility,
 ,
 ,
 ,
+           ModifyCpuDataFunctionId,
+           CpuGlobalId,
+           Enabled,
+           PalCompatibility,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetCpuDataByIdFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalGetCpuDataByIdFunctionId service of Extended SAL
   MP Services Class. See EsalGetCpuDataByIdFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            GetCpuDataByIDFunctionId,
            CpuGlobalId,
            IndexByEnabledCpu,
 ,
 ,
 ,
 ,
+           GetCpuDataByIDFunctionId,
+           CpuGlobalId,
+           IndexByEnabledCpu,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetCpuDataByIndexFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalGetCpuDataByIndexFunctionId service of Extended SAL
   MP Services Class. See EsalGetCpuDataByIndexFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            GetCpuDataByIndexFunctionId,
            Index,
            IndexByEnabledCpu,
 ,
 ,
 ,
 ,
+           GetCpuDataByIndexFunctionId,
+           Index,
+           IndexByEnabledCpu,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalWhoAmIFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalWhoAmIFunctionId service of Extended SAL
   MP Services Class. See EsalWhoAmIFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            CurrentProcInfoFunctionId,
            IndexByEnabledCpu,
 ,
 ,
 ,
 ,
 ,
+           CurrentProcInfoFunctionId,
+           IndexByEnabledCpu,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalNumProcessors service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalNumProcessors service of Extended SAL
   MP Services Class. See EsalNumProcessors of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            NumProcessorsFunctionId,
 ,
 ,
 ,
 ,
 ,
 ,
+           NumProcessorsFunctionId,
+,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalSetMinStateFnctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalSetMinStateFnctionId service of Extended SAL
   MP Services Class. See EsalSetMinStateFnctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            SetMinStateFunctionId,
            CpuGlobalId,
            MinStatePointer,
 ,
 ,
 ,
 ,
+           SetMinStateFunctionId,
+           CpuGlobalId,
+           MinStatePointer,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalGetMinStateFunctionId service of Extended SAL MP Services Class.
   This function is a wrapper for the EsalGetMinStateFunctionId service of Extended SAL
   MP Services Class. See EsalGetMinStateFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MP_SERVICES_PROTOCOL_GUID_HI,
            GetMinStateFunctionId,
            CpuGlobalId,
 ,
 ,
 ,
 ,
 ,
+           GetMinStateFunctionId,
+           CpuGlobalId,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalMcsGetStateInfoFunctionId service of Extended SAL MCA Services Class.
   This function is a wrapper for the EsalMcsGetStateInfoFunctionId service of Extended SAL
   MCA Services Class. See EsalMcsGetStateInfoFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MCA_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MCA_SERVICES_PROTOCOL_GUID_HI,
            McaGetStateInfoFunctionId,
            CpuGlobalId,
 ,
 ,
 ,
 ,
 ,
+           McaGetStateInfoFunctionId,
+           CpuGlobalId,
+,
+,
+,
+,
+,
            );
 …
 /**
   Wrapper for the EsalMcaRegisterCpuFunctionId service of Extended SAL MCA Services Class.
   This function is a wrapper for the EsalMcaRegisterCpuFunctionId service of Extended SAL
   MCA Services Class. See EsalMcaRegisterCpuFunctionId of Extended SAL Specification.
 …
            EFI_EXTENDED_SAL_MCA_SERVICES_PROTOCOL_GUID_LO,
            EFI_EXTENDED_SAL_MCA_SERVICES_PROTOCOL_GUID_HI,
            McaRegisterCpuFunctionId,
            CpuGlobalId,
            StateBufferPointer,
 ,
 ,
 ,
 ,
            );
+}
+           McaRegisterCpuFunctionId,
+           CpuGlobalId,
+           StateBufferPointer,
+,
+,
+,
+,
+           );
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeRuntimeExtendedSalLib/Ipf/AsmExtendedSalLib.s

-              r48674
+              r58466
 //        r10 = Virtual Plabel
 //        r11 = psr
 //
 // As per static calling conventions.
 //
+//
+// As per static calling conventions.
+//
 //--
 //---------------------------------------------------------------------------
 …
 //  in1 = Physical GP
 //
 // Return Value:
+// Return Value:
 //   r8 = EFI_SAL_SUCCESS
 //
 // As per static calling conventions.
 //
+//
+// As per static calling conventions.
+//
 //--
 //---------------------------------------------------------------------------
 …
 //  in1 = Virtual GP
 //
 // Return Value:
+// Return Value:
 //  r8 = EFI_SAL_ERROR
 //
 // As per static calling conventions.
 //
+//
+// As per static calling conventions.
+//
 //--
 //---------------------------------------------------------------------------
 …
 .align 32
 EsalEntryPoint:
+EsalEntryPoint:
     data8 0   // Physical Entry
     data8 0   //         GP

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeRuntimePciExpressLib/DxeRuntimePciExpressLib.inf

-              r58459
+              r58466
 ## @file
 # Instance of PCI Express Library using the 256 MB PCI Express MMIO window that
+# Instance of PCI Express Library using the 256 MB PCI Express MMIO window that
 # is safe for runtime use.
+#
 # PCI Express Library that uses the 256 MB PCI Express MMIO window to perform
 #  PCI Configuration cycles. Layers on top of an I/O Library instance.  A table of
 #  PCI devices that are registered for for runtime access is maintained so the
+#  PCI Configuration cycles. Layers on top of an I/O Library instance.  A table of
+#  PCI devices that are registered for for runtime access is maintained so the
 #  proper virtual address is used to perform the PCI Express Configuration cycle.
+#
 …
   MODULE_TYPE                    = DXE_RUNTIME_DRIVER
   VERSION_STRING                 = 1.0
   LIBRARY_CLASS                  = PciExpressLib|DXE_RUNTIME_DRIVER
+  LIBRARY_CLASS                  = PciExpressLib|DXE_RUNTIME_DRIVER
   CONSTRUCTOR                    = DxeRuntimePciExpressLibConstructor
   DESTRUCTOR                     = DxeRuntimePciExpressLibDestructor

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeRuntimePciExpressLib/PciExpressLib.c

-              r58459
+              r58466
 /**
   The constructor function caches the PCI Express Base Address and creates a
+  The constructor function caches the PCI Express Base Address and creates a
   Set Virtual Address Map event to convert physical address to virtual addresses.
   @param  ImageHandle   The firmware allocated handle for the EFI image.
   @param  SystemTable   A pointer to the EFI System Table.
   @retval EFI_SUCCESS   The constructor completed successfully.
   @retval Other value   The constructor did not complete successfully.
 …
 /**
   The destructor function frees any allocated buffers and closes the Set Virtual
+  The destructor function frees any allocated buffers and closes the Set Virtual
   Address Map event.
   @param  ImageHandle   The firmware allocated handle for the EFI image.
   @param  SystemTable   A pointer to the EFI System Table.
   @retval EFI_SUCCESS   The destructor completed successfully.
   @retval Other value   The destructor did not complete successfully.
 …
   //
   // If one or more PCI devices have been registered for runtime access, then
+  // If one or more PCI devices have been registered for runtime access, then
   // free the registration table.
   //
 …
 /**
   Gets the base address of PCI Express.
   This internal functions retrieves PCI Express Base Address via a PCD entry
   PcdPciExpressBaseAddress.
   @param  Address  The address that encodes the PCI Bus, Device, Function and Register.
   @return          The base address of PCI Express.
 …
   //
   // Return the physical address
+  // Return the physical address
   //
   return Address;
 …
 /**
   Registers a PCI device so PCI configuration registers may be accessed after
+  Registers a PCI device so PCI configuration registers may be accessed after
   SetVirtualAddressMap().
   Registers the PCI device specified by Address so all the PCI configuration
   registers associated with that PCI device may be accessed after SetVirtualAddressMap()
+  Registers the PCI device specified by Address so all the PCI configuration
+  registers associated with that PCI device may be accessed after SetVirtualAddressMap()
   is called.
   If Address > 0x0FFFFFFF, then ASSERT().
   @param  Address The address that encodes the PCI Bus, Device, Function and
                   Register.
   @retval RETURN_SUCCESS           The PCI device was registered for runtime access.
   @retval RETURN_UNSUPPORTED       An attempt was made to call this function
+  @retval RETURN_UNSUPPORTED       An attempt was made to call this function
                                    after ExitBootServices().
   @retval RETURN_UNSUPPORTED       The resources required to access the PCI device
 …
   //
   NewTable = ReallocateRuntimePool (
                (mDxeRuntimePciExpressLibNumberOfRuntimeRanges + 0) * sizeof (PCI_EXPRESS_RUNTIME_REGISTRATION_TABLE),
                (mDxeRuntimePciExpressLibNumberOfRuntimeRanges + 1) * sizeof (PCI_EXPRESS_RUNTIME_REGISTRATION_TABLE),
+               (mDxeRuntimePciExpressLibNumberOfRuntimeRanges + 0) * sizeof (PCI_EXPRESS_RUNTIME_REGISTRATION_TABLE),
+               (mDxeRuntimePciExpressLibNumberOfRuntimeRanges + 1) * sizeof (PCI_EXPRESS_RUNTIME_REGISTRATION_TABLE),
                mDxeRuntimePciExpressLibRegistrationTable
                );

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeSalLibEsal/DxeSalLibEsal.c

-              r48674
+              r58466
 /**
   Makes a SAL procedure call.
   This is a wrapper function to make a SAL procedure call.
+  This is a wrapper function to make a SAL procedure call.
   No parameter checking is performed on the 8 input parameters,
   but there are some common rules that the caller should follow
 …
+{
   SAL_RETURN_REGS Regs;
   //
   // Initial all members in this structure.
 …
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
              SalSetVectorsFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             SalSetVectorsFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_HI,
              SalGetStateInfoFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             SalGetStateInfoFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_HI,
              SalGetStateInfoSizeFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             SalGetStateInfoSizeFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_MCA_LOG_SERVICES_PROTOCOL_GUID_HI,
              SalClearStateInfoFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             SalClearStateInfoFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
              SalMcRendezFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             SalMcRendezFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
              SalMcSetParamsFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             SalMcSetParamsFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
              EsalRegisterPhysicalAddrFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             EsalRegisterPhysicalAddrFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_CACHE_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_CACHE_SERVICES_PROTOCOL_GUID_HI,
              SalCacheFlushFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             SalCacheFlushFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_CACHE_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_CACHE_SERVICES_PROTOCOL_GUID_HI,
              SalCacheInitFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             SalCacheInitFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_PCI_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_PCI_SERVICES_PROTOCOL_GUID_HI,
              SalPciConfigReadFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             SalPciConfigReadFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_PCI_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_PCI_SERVICES_PROTOCOL_GUID_HI,
              SalPciConfigWriteFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             SalPciConfigWriteFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
              EsalGetPlatformBaseFreqFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             EsalGetPlatformBaseFreqFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_BASE_SERVICES_PROTOCOL_GUID_HI,
              EsalPhysicalIdInfoFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             EsalPhysicalIdInfoFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );
 …
              EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_LO,
              EFI_EXTENDED_SAL_PAL_SERVICES_PROTOCOL_GUID_HI,
              EsalUpdatePalFunctionId,
              Arg2,
              Arg3,
              Arg4,
              Arg5,
              Arg6,
              Arg7,
+             EsalUpdatePalFunctionId,
+             Arg2,
+             Arg3,
+             Arg4,
+             Arg5,
+             Arg6,
+             Arg7,
              Arg8
              );

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeSalLibEsal/DxeSalLibEsal.inf

r58459	r58466
20	20	MODULE_TYPE = DXE_DRIVER
21	21	VERSION_STRING = 1.0
22		LIBRARY_CLASS = SalLib\|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION
	22	LIBRARY_CLASS = SalLib\|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION
23	23
24	24	#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeServicesLib/DxeServicesLib.c

-              r58459
+              r58466
 /** @file
   MDE DXE Services Library provides functions that simplify the development of DXE Drivers.
+  MDE DXE Services Library provides functions that simplify the development of DXE Drivers.
   These functions help access data from sections of FFS files or from file path.
 …
 /**
   Identify the device handle from which the Image is loaded from. As this device handle is passed to
   GetSectionFromFv as the identifier for a Firmware Volume, an EFI_FIRMWARE_VOLUME2_PROTOCOL
+  GetSectionFromFv as the identifier for a Firmware Volume, an EFI_FIRMWARE_VOLUME2_PROTOCOL
   protocol instance should be located succesfully by calling gBS->HandleProtocol ().
   This function locates the EFI_LOADED_IMAGE_PROTOCOL instance installed
   on ImageHandle. It then returns EFI_LOADED_IMAGE_PROTOCOL.DeviceHandle.
   If ImageHandle is NULL, then ASSERT ();
   If failed to locate a EFI_LOADED_IMAGE_PROTOCOL on ImageHandle, then ASSERT ();
   @param  ImageHandle         The firmware allocated handle for UEFI image.
 …
   EFI_STATUS                    Status;
   EFI_LOADED_IMAGE_PROTOCOL     *LoadedImage;
   ASSERT (ImageHandle != NULL);
 …
 /**
   Allocate and fill a buffer from a Firmware Section identified by a Firmware File GUID name, a Firmware
+  Allocate and fill a buffer from a Firmware Section identified by a Firmware File GUID name, a Firmware
   Section type and instance number from the specified Firmware Volume.
   This functions first locate the EFI_FIRMWARE_VOLUME2_PROTOCOL protocol instance on FvHandle in order to
   carry out the Firmware Volume read operation. The function then reads the Firmware Section found sepcifed
   by NameGuid, SectionType and SectionInstance.
   The details of this search order is defined in description of EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection ()
+  This functions first locate the EFI_FIRMWARE_VOLUME2_PROTOCOL protocol instance on FvHandle in order to
+  carry out the Firmware Volume read operation. The function then reads the Firmware Section found sepcifed
+  by NameGuid, SectionType and SectionInstance.
+  The details of this search order is defined in description of EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection ()
   found in PI Specification.
   If SectionType is EFI_SECTION_TE, EFI_SECTION_TE is used as section type to start the search. If EFI_SECTION_TE section
   is not found, EFI_SECTION_PE32 will be used to try the search again. If no EFI_SECTION_PE32 section is found, EFI_NOT_FOUND
+  If SectionType is EFI_SECTION_TE, EFI_SECTION_TE is used as section type to start the search. If EFI_SECTION_TE section
+  is not found, EFI_SECTION_PE32 will be used to try the search again. If no EFI_SECTION_PE32 section is found, EFI_NOT_FOUND
   is returned.
   The data and size is returned by Buffer and Size. The caller is responsible to free the Buffer allocated
+  The data and size is returned by Buffer and Size. The caller is responsible to free the Buffer allocated
   by this function. This function can be only called at TPL_NOTIFY and below.
   If FvHandle is NULL, then ASSERT ();
   If NameGuid is NULL, then ASSERT();
 …
   If Size is NULL, then ASSERT().
   @param  FvHandle                The device handle that contains a instance of
+  @param  FvHandle                The device handle that contains a instance of
                                   EFI_FIRMWARE_VOLUME2_PROTOCOL instance.
   @param  NameGuid                The GUID name of a Firmware File.
   @param  SectionType             The Firmware Section type.
   @param  SectionInstance         The instance number of Firmware Section to
+  @param  SectionInstance         The instance number of Firmware Section to
                                   read from starting from 0.
   @param  Buffer                  On output, Buffer contains the the data read
+  @param  Buffer                  On output, Buffer contains the the data read
                                   from the section in the Firmware File found.
   @param  Size                    On output, the size of Buffer.
   @retval  EFI_SUCCESS            The image is found and data and size is returned.
   @retval  EFI_NOT_FOUND          The image specified by NameGuid and SectionType
+  @retval  EFI_NOT_FOUND          The image specified by NameGuid and SectionType
                                   can't be found.
   @retval  EFI_OUT_OF_RESOURCES   There were not enough resources to allocate the
+  @retval  EFI_OUT_OF_RESOURCES   There were not enough resources to allocate the
                                   output data buffer or complete the operations.
   @retval  EFI_DEVICE_ERROR       A hardware error occurs during reading from the
+  @retval  EFI_DEVICE_ERROR       A hardware error occurs during reading from the
                                   Firmware Volume.
   @retval  EFI_ACCESS_DENIED      The firmware volume containing the searched
+  @retval  EFI_ACCESS_DENIED      The firmware volume containing the searched
                                   Firmware File is configured to disallow reads.
 **/
 EFI_STATUS
 …
   ASSERT (Buffer != NULL);
   ASSERT (Size != NULL);
   ASSERT (FvHandle != NULL);
 …
   if (EFI_ERROR (Status) && (SectionType == EFI_SECTION_TE)) {
     //
     // Try reading PE32 section, if the required section is TE type
+    // Try reading PE32 section, if the required section is TE type
     //
     *Buffer = NULL;
 …
 /**
   Searches all the available firmware volumes and returns the first matching FFS section.
+  Searches all the available firmware volumes and returns the first matching FFS section.
   This function searches all the firmware volumes for FFS files with FV file type specified by FileType
   The order that the firmware volumes is searched is not deterministic. For each available FV a search
   is made for FFS file of type FileType. If the FV contains more than one FFS file with the same FileType,
   the FileInstance instance will be the matched FFS file. For each FFS file found a search
   is made for FFS sections of type SectionType. If the FFS file contains at least SectionInstance instances
   of the FFS section specified by SectionType, then the SectionInstance instance is returned in Buffer.
   Buffer is allocated using AllocatePool(), and the size of the allocated buffer is returned in Size.
   It is the caller's responsibility to use FreePool() to free the allocated buffer.
   See EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection() for details on how sections
+  The order that the firmware volumes is searched is not deterministic. For each available FV a search
+  is made for FFS file of type FileType. If the FV contains more than one FFS file with the same FileType,
+  the FileInstance instance will be the matched FFS file. For each FFS file found a search
+  is made for FFS sections of type SectionType. If the FFS file contains at least SectionInstance instances
+  of the FFS section specified by SectionType, then the SectionInstance instance is returned in Buffer.
+  Buffer is allocated using AllocatePool(), and the size of the allocated buffer is returned in Size.
+  It is the caller's responsibility to use FreePool() to free the allocated buffer.
+  See EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection() for details on how sections
   are retrieved from an FFS file based on SectionType and SectionInstance.
   If SectionType is EFI_SECTION_TE, and the search with an FFS file fails,
+  If SectionType is EFI_SECTION_TE, and the search with an FFS file fails,
   the search will be retried with a section type of EFI_SECTION_PE32.
   This function must be called with a TPL <= TPL_NOTIFY.
 …
   If Size is NULL, then ASSERT().
   @param  FileType             Indicates the FV file type to search for within all
+  @param  FileType             Indicates the FV file type to search for within all
                                available FVs.
   @param  FileInstance         Indicates which file instance within all available
+  @param  FileInstance         Indicates which file instance within all available
                                FVs specified by FileType.
                                FileInstance starts from zero.
   @param  SectionType          Indicates the FFS section type to search for
                                within the FFS file
+  @param  SectionType          Indicates the FFS section type to search for
+                               within the FFS file
                                specified by FileType with FileInstance.
   @param  SectionInstance      Indicates which section instance within the FFS file
                                specified by FileType with FileInstance to retrieve.
+  @param  SectionInstance      Indicates which section instance within the FFS file
+                               specified by FileType with FileInstance to retrieve.
                                SectionInstance starts from zero.
   @param  Buffer               On output, a pointer to a callee allocated buffer
+  @param  Buffer               On output, a pointer to a callee allocated buffer
                                containing the FFS file section that was found.
                                Is it the caller's responsibility to free this
+                               Is it the caller's responsibility to free this
                                buffer using FreePool().
   @param  Size                 On output, a pointer to the size, in bytes, of Buffer.
 …
   @retval  EFI_SUCCESS          The specified FFS section was returned.
   @retval  EFI_NOT_FOUND        The specified FFS section could not be found.
   @retval  EFI_OUT_OF_RESOURCES There are not enough resources available to retrieve
+  @retval  EFI_OUT_OF_RESOURCES There are not enough resources available to retrieve
                                 the matching FFS section.
   @retval  EFI_DEVICE_ERROR     The FFS section could not be retrieves due to a
+  @retval  EFI_DEVICE_ERROR     The FFS section could not be retrieves due to a
                                 device error.
   @retval  EFI_ACCESS_DENIED    The FFS section could not be retrieves because
                                 the firmware volume that
+  @retval  EFI_ACCESS_DENIED    The FFS section could not be retrieves because
+                                the firmware volume that
                                 contains the matching FFS section does not allow reads.
 **/
 …
     if (IndexFile == 0) {
       Status = InternalGetSectionFromFv (
                  HandleBuffer[IndexFv],
+                 HandleBuffer[IndexFv],
                  &NameGuid,
                  SectionType,
 …
   //
   // The required FFS section file is not found.
+  // The required FFS section file is not found.
   //
   if (IndexFv == HandleCount) {
 …
 Done:
   if (HandleBuffer != NULL) {
+  if (HandleBuffer != NULL) {
     FreePool(HandleBuffer);
+  }
 …
 /**
   Searches all the availables firmware volumes and returns the first matching FFS section.
   This function searches all the firmware volumes for FFS files with an FFS filename specified by NameGuid.
   The order that the firmware volumes is searched is not deterministic. For each FFS file found a search
   is made for FFS sections of type SectionType. If the FFS file contains at least SectionInstance instances
   of the FFS section specified by SectionType, then the SectionInstance instance is returned in Buffer.
   Buffer is allocated using AllocatePool(), and the size of the allocated buffer is returned in Size.
   It is the caller's responsibility to use FreePool() to free the allocated buffer.
   See EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection() for details on how sections
+  Searches all the availables firmware volumes and returns the first matching FFS section.
+  This function searches all the firmware volumes for FFS files with an FFS filename specified by NameGuid.
+  The order that the firmware volumes is searched is not deterministic. For each FFS file found a search
+  is made for FFS sections of type SectionType. If the FFS file contains at least SectionInstance instances
+  of the FFS section specified by SectionType, then the SectionInstance instance is returned in Buffer.
+  Buffer is allocated using AllocatePool(), and the size of the allocated buffer is returned in Size.
+  It is the caller's responsibility to use FreePool() to free the allocated buffer.
+  See EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection() for details on how sections
   are retrieved from an FFS file based on SectionType and SectionInstance.
   If SectionType is EFI_SECTION_TE, and the search with an FFS file fails,
+  If SectionType is EFI_SECTION_TE, and the search with an FFS file fails,
   the search will be retried with a section type of EFI_SECTION_PE32.
   This function must be called with a TPL <= TPL_NOTIFY.
 …
   @param  NameGuid             A pointer to to the FFS filename GUID to search for
                                within any of the firmware volumes in the platform.
   @param  SectionType          Indicates the FFS section type to search for within
+  @param  NameGuid             A pointer to to the FFS filename GUID to search for
+                               within any of the firmware volumes in the platform.
+  @param  SectionType          Indicates the FFS section type to search for within
                                the FFS file specified by NameGuid.
   @param  SectionInstance      Indicates which section instance within the FFS file
+  @param  SectionInstance      Indicates which section instance within the FFS file
                                specified by NameGuid to retrieve.
   @param  Buffer               On output, a pointer to a callee allocated buffer
                                containing the FFS file section that was found.
                                Is it the caller's responsibility to free this buffer
+  @param  Buffer               On output, a pointer to a callee allocated buffer
+                               containing the FFS file section that was found.
+                               Is it the caller's responsibility to free this buffer
                                using FreePool().
   @param  Size                 On output, a pointer to the size, in bytes, of Buffer.
 …
   @retval  EFI_SUCCESS          The specified FFS section was returned.
   @retval  EFI_NOT_FOUND        The specified FFS section could not be found.
   @retval  EFI_OUT_OF_RESOURCES There are not enough resources available to
+  @retval  EFI_OUT_OF_RESOURCES There are not enough resources available to
                                 retrieve the matching FFS section.
   @retval  EFI_DEVICE_ERROR     The FFS section could not be retrieves due to a
+  @retval  EFI_DEVICE_ERROR     The FFS section could not be retrieves due to a
                                 device error.
   @retval  EFI_ACCESS_DENIED    The FFS section could not be retrieves because the
                                 firmware volume that
+  @retval  EFI_ACCESS_DENIED    The FFS section could not be retrieves because the
+                                firmware volume that
                                 contains the matching FFS section does not allow reads.
 **/
 …
     if (HandleBuffer[Index] != FvHandle) {
       Status = InternalGetSectionFromFv (
                  HandleBuffer[Index],
                  NameGuid,
                  SectionType,
+                 HandleBuffer[Index],
+                 NameGuid,
+                 SectionType,
                  SectionInstance,
                  Buffer,
+                 Buffer,
                  Size
                  );
 …
 Done:
   if (HandleBuffer != NULL) {
+  if (HandleBuffer != NULL) {
     FreePool(HandleBuffer);
+  }
   return Status;
+}
 /**
   Searches the firmware volume that the currently executing module was loaded from and returns the first matching FFS section.
   This function searches the firmware volume that the currently executing module was loaded
   from for an FFS file with an FFS filename specified by NameGuid. If the FFS file is found a search
   is made for FFS sections of type SectionType. If the FFS file contains at least SectionInstance
+  Searches the firmware volume that the currently executing module was loaded from and returns the first matching FFS section.
+  This function searches the firmware volume that the currently executing module was loaded
+  from for an FFS file with an FFS filename specified by NameGuid. If the FFS file is found a search
+  is made for FFS sections of type SectionType. If the FFS file contains at least SectionInstance
   instances of the FFS section specified by SectionType, then the SectionInstance instance is returned in Buffer.
   Buffer is allocated using AllocatePool(), and the size of the allocated buffer is returned in Size.
   It is the caller's responsibility to use FreePool() to free the allocated buffer.
   See EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection() for details on how sections are retrieved from
+  Buffer is allocated using AllocatePool(), and the size of the allocated buffer is returned in Size.
+  It is the caller's responsibility to use FreePool() to free the allocated buffer.
+  See EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection() for details on how sections are retrieved from
   an FFS file based on SectionType and SectionInstance.
   If the currently executing module was not loaded from a firmware volume, then EFI_NOT_FOUND is returned.
   If SectionType is EFI_SECTION_TE, and the search with an FFS file fails,
+  If SectionType is EFI_SECTION_TE, and the search with an FFS file fails,
   the search will be retried with a section type of EFI_SECTION_PE32.
   This function must be called with a TPL <= TPL_NOTIFY.
   If NameGuid is NULL, then ASSERT().
 …
   If Size is NULL, then ASSERT().
   @param  NameGuid             A pointer to to the FFS filename GUID to search for
                                within the firmware volumes that the currently
+  @param  NameGuid             A pointer to to the FFS filename GUID to search for
+                               within the firmware volumes that the currently
                                executing module was loaded from.
   @param  SectionType          Indicates the FFS section type to search for within
+  @param  SectionType          Indicates the FFS section type to search for within
                                the FFS file specified by NameGuid.
   @param  SectionInstance      Indicates which section instance within the FFS file
+  @param  SectionInstance      Indicates which section instance within the FFS file
                                specified by NameGuid to retrieve.
   @param  Buffer               On output, a pointer to a callee allocated buffer
                                containing the FFS file section that was found.
                                Is it the caller's responsibility to free this buffer
+  @param  Buffer               On output, a pointer to a callee allocated buffer
+                               containing the FFS file section that was found.
+                               Is it the caller's responsibility to free this buffer
                                using FreePool().
   @param  Size                 On output, a pointer to the size, in bytes, of Buffer.
 …
   @retval  EFI_SUCCESS          The specified FFS section was returned.
   @retval  EFI_NOT_FOUND        The specified FFS section could not be found.
   @retval  EFI_OUT_OF_RESOURCES There are not enough resources available to retrieve
+  @retval  EFI_OUT_OF_RESOURCES There are not enough resources available to retrieve
                                 the matching FFS section.
   @retval  EFI_DEVICE_ERROR     The FFS section could not be retrieves due to a
+  @retval  EFI_DEVICE_ERROR     The FFS section could not be retrieves due to a
                                 device error.
   @retval  EFI_ACCESS_DENIED    The FFS section could not be retrieves because the
                                 firmware volume that contains the matching FFS
                                 section does not allow reads.
+  @retval  EFI_ACCESS_DENIED    The FFS section could not be retrieves because the
+                                firmware volume that contains the matching FFS
+                                section does not allow reads.
 **/
 EFI_STATUS
 …
   This function searches the FFS file that the currently executing module was loaded from for a FFS sections of type SectionType.
   If the FFS file contains at least SectionInstance instances of the FFS section specified by SectionType,
   then the SectionInstance instance is returned in Buffer. Buffer is allocated using AllocatePool(),
   and the size of the allocated buffer is returned in Size. It is the caller's responsibility
   to use FreePool() to free the allocated buffer. See EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection() for
+  If the FFS file contains at least SectionInstance instances of the FFS section specified by SectionType,
+  then the SectionInstance instance is returned in Buffer. Buffer is allocated using AllocatePool(),
+  and the size of the allocated buffer is returned in Size. It is the caller's responsibility
+  to use FreePool() to free the allocated buffer. See EFI_FIRMWARE_VOLUME2_PROTOCOL.ReadSection() for
   details on how sections are retrieved from an FFS file based on SectionType and SectionInstance.
   If the currently executing module was not loaded from an FFS file, then EFI_NOT_FOUND is returned.
   If SectionType is EFI_SECTION_TE, and the search with an FFS file fails,
+  If SectionType is EFI_SECTION_TE, and the search with an FFS file fails,
   the search will be retried with a section type of EFI_SECTION_PE32.
   This function must be called with a TPL <= TPL_NOTIFY.
   If Buffer is NULL, then ASSERT().
   If Size is NULL, then ASSERT().
   @param  SectionType          Indicates the FFS section type to search for within
                                the FFS file that the currently executing module
+  @param  SectionType          Indicates the FFS section type to search for within
+                               the FFS file that the currently executing module
                                was loaded from.
   @param  SectionInstance      Indicates which section instance to retrieve within
                                the FFS file that the currently executing module
+  @param  SectionInstance      Indicates which section instance to retrieve within
+                               the FFS file that the currently executing module
                                was loaded from.
   @param  Buffer               On output, a pointer to a callee allocated buffer
                                containing the FFS file section that was found.
                                Is it the caller's responsibility to free this buffer
+  @param  Buffer               On output, a pointer to a callee allocated buffer
+                               containing the FFS file section that was found.
+                               Is it the caller's responsibility to free this buffer
                                using FreePool().
   @param  Size                 On output, a pointer to the size, in bytes, of Buffer.
 …
   @retval  EFI_SUCCESS          The specified FFS section was returned.
   @retval  EFI_NOT_FOUND        The specified FFS section could not be found.
   @retval  EFI_OUT_OF_RESOURCES There are not enough resources available to retrieve
+  @retval  EFI_OUT_OF_RESOURCES There are not enough resources available to retrieve
                                 the matching FFS section.
   @retval  EFI_DEVICE_ERROR     The FFS section could not be retrieves due to a
+  @retval  EFI_DEVICE_ERROR     The FFS section could not be retrieves due to a
                                 device error.
   @retval  EFI_ACCESS_DENIED    The FFS section could not be retrieves because the
                                 firmware volume that contains the matching FFS
                                 section does not allow reads.
+  @retval  EFI_ACCESS_DENIED    The FFS section could not be retrieves because the
+                                firmware volume that contains the matching FFS
+                                section does not allow reads.
 **/
 EFI_STATUS
 …
 /**
   Get the image file buffer data and buffer size by its device path.
   Access the file either from a firmware volume, from a file system interface,
+  Get the image file buffer data and buffer size by its device path.
+  Access the file either from a firmware volume, from a file system interface,
   or from the load file interface.
   Allocate memory to store the found image. The caller is responsible to free memory.
 …
   If AuthenticationStatus is NULL, then NULL is returned.
   @param[in]       BootPolicy           Policy for Open Image File.If TRUE, indicates
                                         that the request originates from the boot
+  @param[in]       BootPolicy           Policy for Open Image File.If TRUE, indicates
+                                        that the request originates from the boot
                                         manager, and that the boot manager is
                                         attempting to load FilePath as a boot
                                         selection. If FALSE, then FilePath must
+                                        selection. If FALSE, then FilePath must
                                         match an exact file to be loaded.
   @param[in]       FilePath             The pointer to the device path of the file
                                         that is absracted to the file buffer.
   @param[out]      FileSize             The pointer to the size of the abstracted
+  @param[out]      FileSize             The pointer to the size of the abstracted
                                         file buffer.
   @param[out]      AuthenticationStatus Pointer to the authentication status.
 …
   ImageBufferSize     = 0;
   *AuthenticationStatus = 0;
   //
   // Copy File Device Path
 …
             break;
+          }
           LastHandle = FileHandle;
           FileHandle = NULL;
           Status = LastHandle->Open (
                                 LastHandle,
 …
                                 );
           //
           // Close the previous node
           //
           LastHandle->Close (LastHandle);
           DevicePathNode = NextDevicePathNode (DevicePathNode);
+        }
         if (!EFI_ERROR (Status)) {
           //
 …
                                 FileInfo
                                 );
           if (Status == EFI_BUFFER_TOO_SMALL) {
             FileInfo = AllocatePool (FileInfoSize);
 …
+            }
+          }
           if (!EFI_ERROR (Status) && (FileInfo != NULL)) {
             //
 …
         //
         // Close the file and Free FileInfo and TempDevicePathNode since we are done
         //
+        //
         if (FileInfo != NULL) {
           FreePool (FileInfo);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeServicesLib/DxeServicesLib.inf

-              r58459
+              r58466
+#
 # DXE Services Library provides access data from sections of FFS files based on FV protocol.
 # It also provides access file based on file path from a firmware volume,
+# It also provides access file based on file path from a firmware volume,
 # from a file system interface, or from the load file interface.
+#
 …
   gEfiLoadedImageProtocolGuid                   ## SOMETIMES_CONSUMES
   gEfiLoadFileProtocolGuid                      ## SOMETIMES_CONSUMES
   gEfiLoadFile2ProtocolGuid                     ## SOMETIMES_CONSUMES
   gEfiSimpleFileSystemProtocolGuid              ## SOMETIMES_CONSUMES
+  gEfiLoadFile2ProtocolGuid                     ## SOMETIMES_CONSUMES
+  gEfiSimpleFileSystemProtocolGuid              ## SOMETIMES_CONSUMES

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.c

-              r48674
+              r58466
   This library implement library class DxeServiceTableLib.
   It produce EFI_DXE_SERVICE pointer in global variable gDS in library's constructure.
   A DXE driver can use gDS pointer to access services in EFI_DXE_SERVICE, if this
   DXE driver declare that use DxeServicesTableLib library class and link to this
+  DXE driver declare that use DxeServicesTableLib library class and link to this
   library instance.
   Please attention this library instance can not be used util EFI_SYSTEM_TABLE was
+  Please attention this library instance can not be used util EFI_SYSTEM_TABLE was
   initialized.
   This library contains contruct function to retrieve EFI_DXE_SERIVCE, this construct
   function will be invoked in DXE driver's autogen file.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c

-              r48674
+              r58466
   the Length byte, word, or a block of data.
   @param  SmbusOperation  Signifies which particular SMBus hardware protocol instance
+  @param  SmbusOperation  Signifies which particular SMBus hardware protocol instance
                           that it will use to execute the SMBus transactions.
   @param  SmBusAddress    The address that encodes the SMBUS Slave Address,
                           SMBUS Command, SMBUS Data Length, and PEC.
   @param  Length          Signifies the number of bytes that this operation will do.
                           The maximum number of bytes can be revision specific
+  @param  Length          Signifies the number of bytes that this operation will do.
+                          The maximum number of bytes can be revision specific
                           and operation specific.
   @param  Buffer          Contains the value of data to execute to the SMBus slave
                           device. Not all operations require this argument. The
+  @param  Buffer          Contains the value of data to execute to the SMBus slave
+                          device. Not all operations require this argument. The
                           length of this buffer is identified by Length.
   @param  Status          Return status for the executed command.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeSmbusLib/InternalSmbusLib.h

-              r48674
+              r58466
   the Length byte, word, or a block of data.
   @param  SmbusOperation  Signifies which particular SMBus hardware protocol instance
+  @param  SmbusOperation  Signifies which particular SMBus hardware protocol instance
                           that it will use toexecute the SMBus transactions.
   @param  SmBusAddress    The address that encodes the SMBUS Slave Address,
                           SMBUS Command, SMBUS Data Length, and PEC.
   @param  Length          Signifies the number of bytes that this operation will
                           do. The maximum number of bytes can be revision specific
+  @param  Length          Signifies the number of bytes that this operation will
+                          do. The maximum number of bytes can be revision specific
                           and operation specific.
   @param  Buffer          Contains the value of data to execute to the SMBus slave
                           device. Not all operations require this argument. The
+                          device. Not all operations require this argument. The
                           length of this buffer is identified by Length.
   @param  Status          Return status for the executed command.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeSmbusLib/SmbusLib.c

-              r48674
+              r58466
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS:  The SMBUS command was executed.
                         RETURN_TIMEOUT:  A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR: The request was not
                         completed because a failure reflected in the Host Status
                         Register bit.  Device errors are a result of a transaction
                         collision, illegal command field, unclaimed cycle (host
                         initiated), or bus errors (collisions).
+                        RETURN_TIMEOUT:  A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR: The request was not
+                        completed because a failure reflected in the Host Status
+                        Register bit.  Device errors are a result of a transaction
+                        collision, illegal command field, unclaimed cycle (host
+                        initiated), or bus errors (collisions).
                         RETURN_UNSUPPORTED: The SMBus operation is not supported.
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
+                        illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
                         RETURN_UNSUPPORTED:  The SMBus operation is not supported.
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.  Device
                         errors are a result of a transaction collision, illegal
                         command field, unclaimed cycle(host initiated), or bus
+                        errors are a result of a transaction collision, illegal
+                        command field, unclaimed cycle(host initiated), or bus
                         errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct. (PEC is incorrect.)
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.  Device
                         errors are a result of a transaction collision, illegal
                         command field, unclaimed cycle(host initiated), or bus
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.  Device
+                        errors are a result of a transaction collision, illegal
+                        command field, unclaimed cycle(host initiated), or bus
                         errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct (PEC is incorrect)
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failurereflected in the Host Status Register bit.  Device
                         errors are a result of a transaction collision, illegal
                         command field, unclaimed cycle (host initiated), or bus
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failurereflected in the Host Status Register bit.  Device
+                        errors are a result of a transaction collision, illegal
+                        command field, unclaimed cycle (host initiated), or bus
                         errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct (PEC is incorrect)
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.  Device
                         errors are a result of a transaction collision, illegal
                         command field, unclaimed cycle host initiated), or bus
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.  Device
+                        errors are a result of a transaction collision, illegal
+                        command field, unclaimed cycle host initiated), or bus
                         errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct. (PEC is incorrect.)
 …
   If Length in SmBusAddress is not zero, then ASSERT().
   If any reserved bits of SmBusAddress are set, then ASSERT().
   @param  SmBusAddress  The address that encodes the SMBUS Slave Address,
                         SMBUS Command, SMBUS Data Length, and PEC.
   @param  Status        Return status for the executed command.
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
+  @param  SmBusAddress  The address that encodes the SMBUS Slave Address,
+                        SMBUS Command, SMBUS Data Length, and PEC.
+  @param  Status        Return status for the executed command.
+                        This is an optional parameter and may be NULL.
+                        RETURN_SUCCESS: The SMBUS command was executed.
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
+                        illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct. (PEC is
+                        RETURN_CRC_ERROR:  The checksum is not correct. (PEC is
                         incorrect.)
                         RETURN_UNSUPPORTED:  The SMBus operation is not supported.
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the SMBUS
+                        RETURN_TIMEOUT: A timeout occurred while executing the SMBUS
                         command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
+                        illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct.
+                        RETURN_CRC_ERROR:  The checksum is not correct.
                         (PEC is incorrect.)
                         RETURN_UNSUPPORTED:  The SMBus operation is not supported.
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
+                        illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct. (PEC is
+                        RETURN_CRC_ERROR:  The checksum is not correct. (PEC is
                         incorrect.)
                         RETURN_UNSUPPORTED:  The SMBus operation is not supported.
 …
   @param  SmBusAddress  The address that encodes the SMBUS Slave Address,
                         SMBUS Command, SMBUS Data Length, and PEC.
   @param  Buffer        The pointer to the buffer to store the bytes read from
+  @param  Buffer        The pointer to the buffer to store the bytes read from
                         the SMBUS.
   @param  Status        Return status for the executed command.
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the SMBUS
+                        RETURN_TIMEOUT: A timeout occurred while executing the SMBUS
                         command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.  Device
                         errors are a result of a transaction collision, illegal
                         command field, unclaimed cycle (host initiated), or bus
                         errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct. (PEC is
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.  Device
+                        errors are a result of a transaction collision, illegal
+                        command field, unclaimed cycle (host initiated), or bus
+                        errors (collisions).
+                        RETURN_CRC_ERROR:  The checksum is not correct. (PEC is
                         incorrect.)
                         RETURN_UNSUPPORTED:  The SMBus operation is not supported.
 …
   Bytes are written to the SMBUS from Buffer.
   The number of bytes written is returned, and will never return a value larger than 32-bytes.
   If Status is not NULL, then the status of the executed command is returned in Status.
+  If Status is not NULL, then the status of the executed command is returned in Status.
   If Length in SmBusAddress is zero or greater than 32, then ASSERT().
   If Buffer is NULL, then ASSERT().
 …
   @param  SmBusAddress  The address that encodes the SMBUS Slave Address,
                         MBUS Command, SMBUS Data Length, and PEC.
   @param  Buffer        The pointer to the buffer to store the bytes read from
+  @param  Buffer        The pointer to the buffer to store the bytes read from
                         the SMBUS.
   @param  Status        Return status for the executed command.
                         This is an optional parameter and may be NULL.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.  Device
                         errors are a result of a transaction collision, illegal
                         command field, unclaimed cycle (host initiated), or bus
                         errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct. (PEC is
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.  Device
+                        errors are a result of a transaction collision, illegal
+                        command field, unclaimed cycle (host initiated), or bus
+                        errors (collisions).
+                        RETURN_CRC_ERROR:  The checksum is not correct. (PEC is
                         incorrect.)
                         RETURN_UNSUPPORTED:  The SMBus operation is not supported.
 …
   @param  Status        Return status for the executed command.
                         This is an optional parameter and may be NULL.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR: The request was not completed because
                         a failure reflected in the Host Status Register bit.  Device
                         errors are a result of a transaction collision, illegal
                         command field, unclaimed cycle (host initiated), or bus
                         errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct. (PEC is
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR: The request was not completed because
+                        a failure reflected in the Host Status Register bit.  Device
+                        errors are a result of a transaction collision, illegal
+                        command field, unclaimed cycle (host initiated), or bus
+                        errors (collisions).
+                        RETURN_CRC_ERROR:  The checksum is not correct. (PEC is
                         incorrect.)
                         RETURN_UNSUPPORTED:  The SMBus operation is not supported.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeTimerLibEsal/DxeTimerLibEsal.c

-              r48674
+              r58466
     EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_LO,
     EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_HI,
     StallFunctionId,
     MicroSeconds,
 ,
 ,
 ,
 ,
 ,
+    StallFunctionId,
+    MicroSeconds,
+,
+,
+,
+,
+,
     );
 …
     EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_LO,
     EFI_EXTENDED_SAL_STALL_SERVICES_PROTOCOL_GUID_HI,
     StallFunctionId,
     MicroSeconds,
 ,
 ,
 ,
 ,
 ,
+    StallFunctionId,
+    MicroSeconds,
+,
+,
+,
+,
+,
     );

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/DxeTimerLibEsal/DxeTimerLibEsal.inf

r58459	r58466
20	20	MODULE_TYPE = DXE_DRIVER
21	21	VERSION_STRING = 1.0
22		LIBRARY_CLASS = TimerLib\|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION
	22	LIBRARY_CLASS = TimerLib\|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION
23	23
24	24	#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.c

-              r48674
+              r58466
   If ProcessModuleEntryPointList() returns, then ASSERT() and halt the system.
   @param SecCoreData  Points to a data structure containing information about the
                       PEI core's operating environment, such as the size and
                       location of temporary RAM, the stack location and the BFV
+  @param SecCoreData  Points to a data structure containing information about the
+                      PEI core's operating environment, such as the size and
+                      location of temporary RAM, the stack location and the BFV
                       location.
   @param PpiList      Points to a list of one or more PPI descriptors to be
                       installed initially by the PEI core. An empty PPI list
                       consists of a single descriptor with the end-tag
+  @param PpiList      Points to a list of one or more PPI descriptors to be
+                      installed initially by the PEI core. An empty PPI list
+                      consists of a single descriptor with the end-tag
                       EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST.
                       As part of its initialization phase, the PEI Foundation will
                       add these SEC-hosted PPIs to its PPI database, such that both
                       the PEI Foundation and any modules can leverage the associated
+                      add these SEC-hosted PPIs to its PPI database, such that both
+                      the PEI Foundation and any modules can leverage the associated
                       service calls and/or code in these early PPIs.
 **/
 VOID
 EFIAPI
+EFIAPI
 _ModuleEntryPoint(
   IN CONST  EFI_SEC_PEI_HAND_OFF    *SecCoreData,
 …
+{
   ProcessModuleEntryPointList (SecCoreData, PpiList, NULL);
   //
   // Should never return
   //
   ASSERT(FALSE);
   CpuDeadLoop ();
+  CpuDeadLoop ();
+}
 …
   @param SecCoreData  Points to a data structure containing information about the PEI core's
                       operating environment, such as the size and location of temporary RAM,
                       the stack location and the BFV location.
+                      the stack location and the BFV location.
   @param PpiList      Points to a list of one or more PPI descriptors to be installed
                       initially by the PEI core.  An empty PPI list consists of
                       a single descriptor with the end-tag
+                      initially by the PEI core.  An empty PPI list consists of
+                      a single descriptor with the end-tag
                       EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST.
                       As part of its initialization phase, the PEI Foundation will
                       add these SEC-hosted PPIs to its PPI database, such that both
                       the PEI Foundationand any modules can leverage the associated
+                      As part of its initialization phase, the PEI Foundation will
+                      add these SEC-hosted PPIs to its PPI database, such that both
+                      the PEI Foundationand any modules can leverage the associated
                       service calls and/or code in these early PPIs.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiDxePostCodeLibReportStatusCode/PostCode.c

-              r48674
+              r58466
   Sends an 32-bit value to a POST card.
   Sends the 32-bit value specified by Value to a POST card, and returns Value.
   Some implementations of this library function may perform I/O operations
   directly to a POST card device.  Other implementations may send Value to
   ReportStatusCode(), and the status code reporting mechanism will eventually
+  Sends the 32-bit value specified by Value to a POST card, and returns Value.
+  Some implementations of this library function may perform I/O operations
+  directly to a POST card device.  Other implementations may send Value to
+  ReportStatusCode(), and the status code reporting mechanism will eventually
   display the 32-bit value on the status reporting device.
   PostCode() must actively prevent recursion.  If PostCode() is called while
   processing another any other Post Code Library function, then
+  PostCode() must actively prevent recursion.  If PostCode() is called while
+  processing another any other Post Code Library function, then
   PostCode() must return Value immediately.
 …
   Sends the 32-bit value specified by Value to a POST card, and returns Value.
   If Description is not NULL, then the ASCII string specified by Description is
   also passed to the handler that displays the POST card value.  Some
   implementations of this library function may perform I/O operations directly
   to a POST card device.  Other implementations may send Value to ReportStatusCode(),
   and the status code reporting mechanism will eventually display the 32-bit
   value on the status reporting device.
+  If Description is not NULL, then the ASCII string specified by Description is
+  also passed to the handler that displays the POST card value.  Some
+  implementations of this library function may perform I/O operations directly
+  to a POST card device.  Other implementations may send Value to ReportStatusCode(),
+  and the status code reporting mechanism will eventually display the 32-bit
+  value on the status reporting device.
   PostCodeWithDescription()must actively prevent recursion.  If
   PostCodeWithDescription() is called while processing another any other Post
   Code Library function, then PostCodeWithDescription() must return Value
+  PostCodeWithDescription()must actively prevent recursion.  If
+  PostCodeWithDescription() is called while processing another any other Post
+  Code Library function, then PostCodeWithDescription() must return Value
   immediately.
   @param  Value        The 32-bit value to write to the POST card.
   @param  Description  The pointer to an ASCII string that is a description of the
                        POST code value.  This is an optional parameter that may
+  @param  Description  The pointer to an ASCII string that is a description of the
+                       POST code value.  This is an optional parameter that may
                        be NULL.
 …
   Returns TRUE if POST Codes are enabled.
   This function returns TRUE if the POST_CODE_PROPERTY_POST_CODE_ENABLED
+  This function returns TRUE if the POST_CODE_PROPERTY_POST_CODE_ENABLED
   bit of PcdPostCodePropertyMask is set.  Otherwise FALSE is returned.
   @retval  TRUE   The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
+  @retval  TRUE   The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
                   PcdPostCodeProperyMask is set.
   @retval  FALSE  The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
+  @retval  FALSE  The POST_CODE_PROPERTY_POST_CODE_ENABLED bit of
                   PcdPostCodeProperyMask is clear.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.c

-              r58459
+              r58466
   PEI_EXTRACT_GUIDED_SECTION_HANDLER_INFO *HandlerInfo;
   EFI_PEI_HOB_POINTERS                    Hob;
   //
   // First try to get handler information from guid hob specified by CallerId.
 …
           HandlerInfo->ExtractHandlerGuidTable    = (GUID *) (HandlerInfo + 1);
           HandlerInfo->ExtractDecodeHandlerTable  = (EXTRACT_GUIDED_SECTION_DECODE_HANDLER *) (
                                                       (UINT8 *)HandlerInfo->ExtractHandlerGuidTable +
+                                                      (UINT8 *)HandlerInfo->ExtractHandlerGuidTable +
                                                       PcdGet32 (PcdMaximumGuidedExtractHandler) * sizeof (GUID)
                                                      );
           HandlerInfo->ExtractGetInfoHandlerTable = (EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER *) (
                                                       (UINT8 *)HandlerInfo->ExtractDecodeHandlerTable +
                                                       PcdGet32 (PcdMaximumGuidedExtractHandler) *
+                                                      (UINT8 *)HandlerInfo->ExtractDecodeHandlerTable +
+                                                      PcdGet32 (PcdMaximumGuidedExtractHandler) *
                                                       sizeof (EXTRACT_GUIDED_SECTION_DECODE_HANDLER)
                                                      );
 …
     Hob.Raw = GetNextHob (EFI_HOB_TYPE_GUID_EXTENSION, Hob.Raw);
+  }
   //
   // If Guid Hob is not found, Build CallerId Guid hob to store Handler Info
   //
   HandlerInfo = BuildGuidHob (
                  &gEfiCallerIdGuid,
+                 &gEfiCallerIdGuid,
                  sizeof (PEI_EXTRACT_GUIDED_SECTION_HANDLER_INFO) +
                  PcdGet32 (PcdMaximumGuidedExtractHandler) *
+                 PcdGet32 (PcdMaximumGuidedExtractHandler) *
                  (sizeof (GUID) + sizeof (EXTRACT_GUIDED_SECTION_DECODE_HANDLER) + sizeof (EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER))
                 );
 …
   HandlerInfo->ExtractHandlerGuidTable    = (GUID *) (HandlerInfo + 1);
   HandlerInfo->ExtractDecodeHandlerTable  = (EXTRACT_GUIDED_SECTION_DECODE_HANDLER *) (
                                               (UINT8 *)HandlerInfo->ExtractHandlerGuidTable +
+                                              (UINT8 *)HandlerInfo->ExtractHandlerGuidTable +
                                               PcdGet32 (PcdMaximumGuidedExtractHandler) * sizeof (GUID)
                                              );
   HandlerInfo->ExtractGetInfoHandlerTable = (EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER *) (
                                               (UINT8 *)HandlerInfo->ExtractDecodeHandlerTable +
                                               PcdGet32 (PcdMaximumGuidedExtractHandler) *
+                                              (UINT8 *)HandlerInfo->ExtractDecodeHandlerTable +
+                                              PcdGet32 (PcdMaximumGuidedExtractHandler) *
                                               sizeof (EXTRACT_GUIDED_SECTION_DECODE_HANDLER)
                                              );
 …
   Sets ExtractHandlerGuidTable so it points at a callee allocated array of registered GUIDs.
   The total number of GUIDs in the array are returned. Since the array of GUIDs is callee allocated
   and caller must treat this array of GUIDs as read-only data.
+  and caller must treat this array of GUIDs as read-only data.
   If ExtractHandlerGuidTable is NULL, then ASSERT().
 …
   If the GUID value specified by SectionGuid has already been registered, then return RETURN_ALREADY_STARTED.
   If there are not enough resources available to register the handlers  then RETURN_OUT_OF_RESOURCES is returned.
   If SectionGuid is NULL, then ASSERT().
   If GetInfoHandler is NULL, then ASSERT().
 …
                              required to actually decode the data in a GUIDed section.
   @param[in]  DecodeHandler  The pointer to a function that decodes a GUIDed section into a caller
                              allocated output buffer.
+                             allocated output buffer.
   @retval  RETURN_SUCCESS           The handlers were registered.
 …
     return RETURN_OUT_OF_RESOURCES;
+  }
   //
   // Register new Handler and guid value.
 …
   optional scratch buffer required to actually decode the data in a GUIDed section.
   Examines a GUIDed section specified by InputSection.
+  Examines a GUIDed section specified by InputSection.
   If GUID for InputSection does not match any of the GUIDs registered through ExtractGuidedSectionRegisterHandlers(),
   then RETURN_UNSUPPORTED is returned.
   If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
+  then RETURN_UNSUPPORTED is returned.
+  If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
   of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER that was registered with ExtractGuidedSectionRegisterHandlers()
   is used to retrieve the OututBufferSize, ScratchSize, and Attributes values. The return status from the handler of
   type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER is returned.
   If InputSection is NULL, then ASSERT().
   If OutputBufferSize is NULL, then ASSERT().
 …
   OUT       UINT32  *OutputBufferSize,
   OUT       UINT32  *ScratchBufferSize,
   OUT       UINT16  *SectionAttribute
+  OUT       UINT16  *SectionAttribute
+  )
+{
 …
   PEI_EXTRACT_GUIDED_SECTION_HANDLER_INFO *HandlerInfo;
   EFI_GUID *SectionDefinitionGuid;
   //
   // Check input paramter
 …
   //
   // Not found, the input guided section is not supported.
+  // Not found, the input guided section is not supported.
   //
   return RETURN_UNSUPPORTED;
 …
   allocated output buffer.
   Decodes the GUIDed section specified by InputSection.
+  Decodes the GUIDed section specified by InputSection.
   If GUID for InputSection does not match any of the GUIDs registered through ExtractGuidedSectionRegisterHandlers(),
   then RETURN_UNSUPPORTED is returned.
+  then RETURN_UNSUPPORTED is returned.
   If the GUID of InputSection does match the GUID that this handler supports, then the the associated handler
   of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER that was registered with ExtractGuidedSectionRegisterHandlers()
 …
   then OutputBuffer is set to point at the data in InputSection.  Otherwise, the decoded data will be placed in caller
   allocated buffer specified by OutputBuffer.    This function is responsible for computing the  EFI_AUTH_STATUS_PLATFORM_OVERRIDE
   bit of in AuthenticationStatus.  The return status from the handler of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER is returned.
+  bit of in AuthenticationStatus.  The return status from the handler of type EXTRACT_GUIDED_SECTION_DECODE_HANDLER is returned.
   If InputSection is NULL, then ASSERT().
   If OutputBuffer is NULL, then ASSERT().
   If ScratchBuffer is NULL and this decode operation requires a scratch buffer, then ASSERT().
   If AuthenticationStatus is NULL, then ASSERT().
+  If AuthenticationStatus is NULL, then ASSERT().
   @param[in]  InputSection   A pointer to a GUIDed section of an FFS formatted file.
   @param[out] OutputBuffer   A pointer to a buffer that contains the result of a decode operation.
   @param[in]  ScratchBuffer  A caller allocated buffer that may be required by this function as a scratch buffer to perform the decode operation.
   @param[out] AuthenticationStatus
+  @param[out] OutputBuffer   A pointer to a buffer that contains the result of a decode operation.
+  @param[in]  ScratchBuffer  A caller allocated buffer that may be required by this function as a scratch buffer to perform the decode operation.
+  @param[out] AuthenticationStatus
                              A pointer to the authentication status of the decoded output buffer. See the definition
                              of authentication status in the EFI_PEI_GUIDED_SECTION_EXTRACTION_PPI section of the PI
 …
   OUT       VOID    **OutputBuffer,
   IN        VOID    *ScratchBuffer,        OPTIONAL
   OUT       UINT32  *AuthenticationStatus
+  OUT       UINT32  *AuthenticationStatus
+  )
+{
 …
   PEI_EXTRACT_GUIDED_SECTION_HANDLER_INFO *HandlerInfo;
   EFI_GUID *SectionDefinitionGuid;
   //
   // Check input parameter
 …
   //
   // Get all registered handler information.
   //
+  //
   Status = PeiGetExtractGuidedSectionHandlerInfo (&HandlerInfo);
   if (EFI_ERROR (Status)) {
 …
   //
   // Not found, the input guided section is not supported.
+  // Not found, the input guided section is not supported.
   //
   return RETURN_UNSUPPORTED;
 …
 /**
   Retrieves handlers of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER and
+  Retrieves handlers of type EXTRACT_GUIDED_SECTION_GET_INFO_HANDLER and
   EXTRACT_GUIDED_SECTION_DECODE_HANDLER for a specific GUID section type.
   Retrieves the handlers associated with SectionGuid and returns them in
+  Retrieves the handlers associated with SectionGuid and returns them in
   GetInfoHandler and DecodeHandler.
   If the GUID value specified by SectionGuid has not been registered, then
+  If the GUID value specified by SectionGuid has not been registered, then
   return RETURN_NOT_FOUND.
   If SectionGuid is NULL, then ASSERT().
   @param[in]  SectionGuid    A pointer to the GUID associated with the handlersof the GUIDed
+  @param[in]  SectionGuid    A pointer to the GUID associated with the handlersof the GUIDed
                              section type being retrieved.
   @param[out] GetInfoHandler Pointer to a function that examines a GUIDed section and returns
                              the size of the decoded buffer and the size of an optional scratch
                              buffer required to actually decode the data in a GUIDed section.
                              This is an optional parameter that may be NULL. If it is NULL, then
+  @param[out] GetInfoHandler Pointer to a function that examines a GUIDed section and returns
+                             the size of the decoded buffer and the size of an optional scratch
+                             buffer required to actually decode the data in a GUIDed section.
+                             This is an optional parameter that may be NULL. If it is NULL, then
                              the previously registered handler is not returned.
   @param[out] DecodeHandler  Pointer to a function that decodes a GUIDed section into a caller

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiHobLib/HobLib.c

-              r58459
+              r58466
   This function returns the pointer to first HOB in the list.
   For PEI phase, the PEI service GetHobList() can be used to retrieve the pointer
+  For PEI phase, the PEI service GetHobList() can be used to retrieve the pointer
   to the HOB list.  For the DXE phase, the HOB list pointer can be retrieved through
   the EFI System Table by looking up theHOB list GUID in the System Configuration Table.
   Since the System Configuration Table does not exist that the time the DXE Core is
   launched, the DXE Core uses a global variable from the DXE Core Entry Point Library
+  Since the System Configuration Table does not exist that the time the DXE Core is
+  launched, the DXE Core uses a global variable from the DXE Core Entry Point Library
   to manage the pointer to the HOB list.
   If the pointer to the HOB list is NULL, then ASSERT().
   @return The pointer to the HOB list.
 …
   Returns the next instance of a HOB type from the starting HOB.
   This function searches the first instance of a HOB type from the starting HOB pointer.
+  This function searches the first instance of a HOB type from the starting HOB pointer.
   If there does not exist such HOB type from the starting HOB pointer, it will return NULL.
   In contrast with macro GET_NEXT_HOB(), this function does not skip the starting HOB pointer
   unconditionally: it returns HobStart back if HobStart itself meets the requirement;
   caller is required to use GET_NEXT_HOB() if it wishes to skip current HobStart.
   If HobStart is NULL, then ASSERT().
 …
   ASSERT (HobStart != NULL);
   Hob.Raw = (UINT8 *) HobStart;
   //
 …
   Returns the first instance of a HOB type among the whole HOB list.
   This function searches the first instance of a HOB type among the whole HOB list.
   If there does not exist such HOB type in the HOB list, it will return NULL.
+  This function searches the first instance of a HOB type among the whole HOB list.
+  If there does not exist such HOB type in the HOB list, it will return NULL.
   If the pointer to the HOB list is NULL, then ASSERT().
 …
 /**
   Returns the next instance of the matched GUID HOB from the starting HOB.
   This function searches the first instance of a HOB from the starting HOB pointer.
   Such HOB should satisfy two conditions:
   its HOB type is EFI_HOB_TYPE_GUID_EXTENSION and its GUID Name equals to the input Guid.
   If there does not exist such HOB from the starting HOB pointer, it will return NULL.
+  This function searches the first instance of a HOB from the starting HOB pointer.
+  Such HOB should satisfy two conditions:
+  its HOB type is EFI_HOB_TYPE_GUID_EXTENSION and its GUID Name equals to the input Guid.
+  If there does not exist such HOB from the starting HOB pointer, it will return NULL.
   Caller is required to apply GET_GUID_HOB_DATA () and GET_GUID_HOB_DATA_SIZE ()
   to extract the data section and its size information, respectively.
 …
   unconditionally: it returns HobStart back if HobStart itself meets the requirement;
   caller is required to use GET_NEXT_HOB() if it wishes to skip current HobStart.
   If Guid is NULL, then ASSERT().
   If HobStart is NULL, then ASSERT().
 …
 /**
   Returns the first instance of the matched GUID HOB among the whole HOB list.
   This function searches the first instance of a HOB among the whole HOB list.
+  This function searches the first instance of a HOB among the whole HOB list.
   Such HOB should satisfy two conditions:
   its HOB type is EFI_HOB_TYPE_GUID_EXTENSION and its GUID Name equals to the input Guid.
 …
   Caller is required to apply GET_GUID_HOB_DATA () and GET_GUID_HOB_DATA_SIZE ()
   to extract the data section and its size information, respectively.
   If the pointer to the HOB list is NULL, then ASSERT().
   If Guid is NULL, then ASSERT().
 …
   Get the system boot mode from the HOB list.
   This function returns the system boot mode information from the
+  This function returns the system boot mode information from the
   PHIT HOB in HOB list.
   If the pointer to the HOB list is NULL, then ASSERT().
   @param  VOID.
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If ModuleName is NULL, then ASSERT().
   If there is no additional space for HOB creation, then ASSERT().
 …
   //
   ZeroMem (Hob->MemoryAllocationHeader.Reserved, sizeof (Hob->MemoryAllocationHeader.Reserved));
   CopyGuid (&Hob->ModuleName, ModuleName);
   Hob->EntryPoint = EntryPoint;
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
 /**
   Builds a customized HOB tagged with a GUID for identification and returns
+  Builds a customized HOB tagged with a GUID for identification and returns
   the start address of GUID HOB data.
   This function builds a customized HOB tagged with a GUID for identification
   and returns the start address of GUID HOB data so that caller can fill the customized data.
+  This function builds a customized HOB tagged with a GUID for identification
+  and returns the start address of GUID HOB data so that caller can fill the customized data.
   The HOB Header and Name field is already stripped.
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If Guid is NULL, then ASSERT().
   If there is no additional space for HOB creation, then ASSERT().
 …
   //
   ASSERT (Guid != NULL);
   //
   // Make sure that data length is not too long.
 …
 /**
   Builds a customized HOB tagged with a GUID for identification, copies the input data to the HOB
+  Builds a customized HOB tagged with a GUID for identification, copies the input data to the HOB
   data field, and returns the start address of the GUID HOB data.
   This function builds a customized HOB tagged with a GUID for identification and copies the input
   data to the HOB data field and returns the start address of the GUID HOB data.  It can only be
   invoked during PEI phase; for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
+  data to the HOB data field and returns the start address of the GUID HOB data.  It can only be
+  invoked during PEI phase; for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   The HOB Header and Name field is already stripped.
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If Guid is NULL, then ASSERT().
   If Data is NULL and DataLength > 0, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   @param  FvName        The name of the Firmware Volume.
   @param  FileName      The name of the file.
 **/
 VOID
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If the platform does not support Capsule Volume HOBs, then ASSERT().
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   // Zero the reserved space to match HOB spec
   //
   ZeroMem (Hob->Reserved, sizeof (Hob->Reserved));
+  ZeroMem (Hob->Reserved, sizeof (Hob->Reserved));
+}
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   It can only be invoked during PEI phase;
   for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
   If there is no additional space for HOB creation, then ASSERT().
 …
   ASSERT (((BaseAddress & (EFI_PAGE_SIZE - 1)) == 0) &&
           ((Length & (EFI_PAGE_SIZE - 1)) == 0));
   Hob = InternalPeiCreateHob (EFI_HOB_TYPE_MEMORY_ALLOCATION, (UINT16) sizeof (EFI_HOB_MEMORY_ALLOCATION));
   if (Hob == NULL) {
     return;
+  }
   ZeroMem (&(Hob->AllocDescriptor.Name), sizeof (EFI_GUID));
   Hob->AllocDescriptor.MemoryBaseAddress = BaseAddress;

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiHobLib/PeiHobLib.inf

r58459	r58466
53	53	# RESOURCE_DESCRIPTOR ## SOMETIMES_PRODUCES
54	54	# FIRMWARE_VOLUME ## SOMETIMES_PRODUCES
55		#
	55	#
56	56

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiIoLibCpuIo/IoHighLevel.c

-              r58459
+              r58466
 /**
   Reads an 8-bit I/O port, performs a bitwise AND followed by a bitwise
+  Reads an 8-bit I/O port, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 8-bit I/O port.
 …
   Writes Value to the bit field of the I/O register. The bit field is specified
   by the StartBit and the EndBit. All other bits in the destination I/O
   register are preserved. The value written to the I/O port is returned.
+  register are preserved. The value written to the I/O port is returned.
   If 8-bit I/O port operations are not supported, then ASSERT().
 …
   If 16-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 16-bit boundary, then ASSERT().
   @param  Port    The I/O port to write.
   @param  AndData The value to AND with the read value from the I/O port.
 …
 /**
   Reads a 16-bit I/O port, performs a bitwise AND followed by a bitwise
+  Reads a 16-bit I/O port, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 16-bit I/O port.
 …
   If 16-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 16-bit boundary, then ASSERT().
   @param  Port    The I/O port to write.
   @param  AndData The value to AND with the read value from the I/O port.
 …
 /**
   Reads a 32-bit I/O port, performs a bitwise AND followed by a bitwise
+  Reads a 32-bit I/O port, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 32-bit I/O port.
 …
 /**
   Reads a 64-bit I/O port, performs a bitwise AND followed by a bitwise
+  Reads a 64-bit I/O port, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 64-bit I/O port.
 …
   result back to the 8-bit MMIO register.
   Reads the 8-bit MMIO register specified by Address, performs a bitwise
+  Reads the 8-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 8-bit MMIO register specified by Address. The value
 …
 /**
   Reads an 8-bit MMIO register, performs a bitwise AND followed by a bitwise
+  Reads an 8-bit MMIO register, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 8-bit MMIO register.
 …
   writes the result back to the bit field in the 8-bit MMIO register.
   Reads the 8-bit MMIO register specified by Address, performs a bitwise
+  Reads the 8-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 8-bit MMIO register specified by Address. The value
 …
   result back to the 16-bit MMIO register.
   Reads the 16-bit MMIO register specified by Address, performs a bitwise
+  Reads the 16-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 16-bit MMIO register specified by Address. The value
 …
 /**
   Reads a 16-bit MMIO register, performs a bitwise AND followed by a bitwise
+  Reads a 16-bit MMIO register, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 16-bit MMIO register.
 …
   writes the result back to the bit field in the 16-bit MMIO register.
   Reads the 16-bit MMIO register specified by Address, performs a bitwise
+  Reads the 16-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 16-bit MMIO register specified by Address. The value
 …
   result back to the 32-bit MMIO register.
   Reads the 32-bit MMIO register specified by Address, performs a bitwise
+  Reads the 32-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 32-bit MMIO register specified by Address. The value
 …
 /**
   Reads a 32-bit MMIO register, performs a bitwise AND followed by a bitwise
+  Reads a 32-bit MMIO register, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 32-bit MMIO register.
 …
   writes the result back to the bit field in the 32-bit MMIO register.
   Reads the 32-bit MMIO register specified by Address, performs a bitwise
+  Reads the 32-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 32-bit MMIO register specified by Address. The value
 …
   result back to the 64-bit MMIO register.
   Reads the 64-bit MMIO register specified by Address, performs a bitwise
+  Reads the 64-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 64-bit MMIO register specified by Address. The value
 …
 /**
   Reads a 64-bit MMIO register, performs a bitwise AND followed by a bitwise
+  Reads a 64-bit MMIO register, performs a bitwise AND followed by a bitwise
   OR, and writes the result back to the 64-bit MMIO register.
 …
   writes the result back to the bit field in the 64-bit MMIO register.
   Reads the 64-bit MMIO register specified by Address, performs a bitwise
+  Reads the 64-bit MMIO register specified by Address, performs a bitwise
   OR between the read result and the value specified by OrData, and
   writes the result to the 64-bit MMIO register specified by Address. The value

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiIoLibCpuIo/IoLib.c

-              r48674
+              r58466
   If 16-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 16-bit boundary, then ASSERT().
   @param  Port  The I/O port to write.
   @param  Value The value to write to the I/O port.
 …
   If 32-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 32-bit boundary, then ASSERT().
   @param  Port  The I/O port to read.
 …
   If 32-bit I/O port operations are not supported, then ASSERT().
   If Port is not aligned on a 32-bit boundary, then ASSERT().
   @param  Port  The I/O port to write.
   @param  Value The value to write to the I/O port.
 …
   @param  Address The MMIO register to write.
   @param  Value   The value to write to the MMIO register.
   @return Value.
 …
   @param  Address The MMIO register to write.
   @param  Value   The value to write to the MMIO register.
   @return Value.
 …
   @param  Address The MMIO register to write.
   @param  Value   The value to write to the MMIO register.
   @return Value.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiIoLibCpuIo/IoLibMmioBuffer.c

-              r48674
+              r58466
   Copy data from MMIO region to system memory by using 8-bit access.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 8-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 8-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
   ReturnBuffer = Buffer;
   while (Length-- != 0) {
     *(Buffer++) = MmioRead8 (StartAddress++);
 …
   Copy data from MMIO region to system memory by using 16-bit access.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 16-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 16-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 16-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT16) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ASSERT ((Length & (sizeof (UINT16) - 1)) == 0);
   ASSERT (((UINTN) Buffer & (sizeof (UINT16) - 1)) == 0);
   ReturnBuffer = Buffer;
   while (Length != 0) {
     *(Buffer++) = MmioRead16 (StartAddress);
 …
   Copy data from MMIO region to system memory by using 32-bit access.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 32-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 32-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 32-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT32) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ASSERT ((Length & (sizeof (UINT32) - 1)) == 0);
   ASSERT (((UINTN) Buffer & (sizeof (UINT32) - 1)) == 0);
   ReturnBuffer = Buffer;
   while (Length != 0) {
     *(Buffer++) = MmioRead32 (StartAddress);
 …
   Copy data from MMIO region to system memory by using 64-bit access.
   Copy data from MMIO region specified by starting address StartAddress
   to system memory specified by Buffer by using 64-bit access. The total
+  Copy data from MMIO region specified by starting address StartAddress
+  to system memory specified by Buffer by using 64-bit access. The total
   number of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 64-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT64) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ASSERT ((Length & (sizeof (UINT64) - 1)) == 0);
   ASSERT (((UINTN) Buffer & (sizeof (UINT64) - 1)) == 0);
   ReturnBuffer = Buffer;
   while (Length != 0) {
     *(Buffer++) = MmioRead64 (StartAddress);
 …
   Copy data from system memory to MMIO region by using 8-bit access.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 8-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 8-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
   ReturnBuffer = (UINT8 *) Buffer;
   while (Length-- != 0) {
      MmioWrite8 (StartAddress++, *(Buffer++));
 …
   return ReturnBuffer;
+}
 …
   Copy data from system memory to MMIO region by using 16-bit access.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 16-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 16-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 16-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT16) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ReturnBuffer = (UINT16 *) Buffer;
   while (Length != 0) {
     MmioWrite16 (StartAddress, *(Buffer++));
     StartAddress += sizeof (UINT16);
     Length -= sizeof (UINT16);
 …
   Copy data from system memory to MMIO region by using 32-bit access.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 32-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 32-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 32-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT32) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ReturnBuffer = (UINT32 *) Buffer;
   while (Length != 0) {
     MmioWrite32 (StartAddress, *(Buffer++));
     StartAddress += sizeof (UINT32);
     Length -= sizeof (UINT32);
 …
   Copy data from system memory to MMIO region by using 64-bit access.
   Copy data from system memory specified by Buffer to MMIO region specified
   by starting address StartAddress by using 64-bit access. The total number
+  Copy data from system memory specified by Buffer to MMIO region specified
+  by starting address StartAddress by using 64-bit access. The total number
   of byte to be copied is specified by Length. Buffer is returned.
   If StartAddress is not aligned on a 64-bit boundary, then ASSERT().
   If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - StartAddress + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS -Buffer + 1), then ASSERT().
 …
   ASSERT ((StartAddress & (sizeof (UINT64) - 1)) == 0);
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - StartAddress));
   ASSERT ((Length - 1) <=  (MAX_ADDRESS - (UINTN) Buffer));
 …
   ReturnBuffer = (UINT64 *) Buffer;
   while (Length != 0) {
     MmioWrite64 (StartAddress, *(Buffer++));
     StartAddress += sizeof (UINT64);
     Length -= sizeof (UINT64);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiIoLibCpuIo/PeiIoLibCpuIo.inf

r58459	r58466
35	35	IoLib.c
36	36	IoLibMmioBuffer.c
37
	37
38	38	[Packages]
39	39	MdePkg/MdePkg.dec

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryAllocationLib/MemoryAllocationLib.c

-              r58459
+              r58466
 /** @file
   Support routines for memory allocation routines
+  Support routines for memory allocation routines
   based on PeiService for PEI phase drivers.
   Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
 VOID *
 InternalAllocatePages (
   IN EFI_MEMORY_TYPE  MemoryType,
+  IN EFI_MEMORY_TYPE  MemoryType,
   IN UINTN            Pages
+  )
+{
   EFI_STATUS            Status;
   EFI_PHYSICAL_ADDRESS  Memory;
+  EFI_PHYSICAL_ADDRESS  Memory;
   EFI_MEMORY_TYPE       RequestType;
   EFI_PEI_HOB_POINTERS  Hob;
 …
   if (MemoryType == EfiReservedMemoryType) {
     //
     // PEI AllocatePages() doesn't support EfiReservedMemoryType.
+    // PEI AllocatePages() doesn't support EfiReservedMemoryType.
     // Change RequestType to EfiBootServicesData for memory allocation.
     //
 …
     return NULL;
+  }
   if (MemoryType == EfiReservedMemoryType) {
     //
     // Memory type needs to be updated to EfiReservedMemoryType. Per PI spec Volume 1,
     // PEI AllocatePages() will automate the creation of the Memory Allocation HOB types.
+    // Memory type needs to be updated to EfiReservedMemoryType. Per PI spec Volume 1,
+    // PEI AllocatePages() will automate the creation of the Memory Allocation HOB types.
     // Search Memory Allocation HOB and find the matched memory region,
     // then change its memory type to EfiReservedMemoryType.
 …
   Allocation Library.  If it is not possible to free allocated pages, then this function will
   perform no actions.
   If Buffer was not allocated with a page allocation function in the Memory Allocation Library,
   then ASSERT().
   If Pages is zero, then ASSERT().
   @param  Buffer                The pointer to the buffer of pages to free.
   @param  Pages                 The number of 4 KB pages to free.
 …
   @param  MemoryType            The type of memory to allocate.
   @param  Pages                 The number of 4 KB pages to allocate.
   @param  Alignment             The requested alignment of the allocation.
+  @param  Alignment             The requested alignment of the allocation.
                                 Must be a power of two.
                                 If Alignment is zero, then byte alignment is used.
 …
 VOID *
 InternalAllocateAlignedPages (
   IN EFI_MEMORY_TYPE  MemoryType,
+  IN EFI_MEMORY_TYPE  MemoryType,
   IN UINTN            Pages,
   IN UINTN            Alignment
 …
   // Make sure that Pages plus EFI_SIZE_TO_PAGES (Alignment) does not overflow.
   //
   ASSERT (Pages <= (MAX_ADDRESS - EFI_SIZE_TO_PAGES (Alignment)));
+  ASSERT (Pages <= (MAX_ADDRESS - EFI_SIZE_TO_PAGES (Alignment)));
   //
 …
   // we simply reserve an overhead memory equal to Alignmemt(page-aligned), no matter what.
   // The overhead mem size could be reduced later with more involved malloc mechanisms
   // (e.g., somthing that can detect the alignment boundary before allocating memory or
+  // (e.g., somthing that can detect the alignment boundary before allocating memory or
   //  can request that memory be allocated at a certain address that is aleady aligned).
   //
 …
+  }
   //
   // Search for the mem HOB referring to the original(unaligned) allocation
+  //
+  // Search for the mem HOB referring to the original(unaligned) allocation
   // and update the size and type if needed.
   //
 …
   } else {
     //
     // Use this HOB as before mem HOB and create a new HOB for the aligned portion
+    // Use this HOB as before mem HOB and create a new HOB for the aligned portion
     //
     HobLength = (AlignedMemory - Memory);
+    HobLength = (AlignedMemory - Memory);
     Hob.MemoryAllocation->AllocDescriptor.MemoryLength = HobLength;
     Hob.MemoryAllocation->AllocDescriptor.MemoryType = EfiConventionalMemory;
 …
   returned.  If there is not enough memory at the specified alignment remaining to satisfy the
   request, then NULL is returned.
   If Alignment is not a power of two and Alignment is not zero, then ASSERT().
   If Pages plus EFI_SIZE_TO_PAGES (Alignment) overflows, then ASSERT().
   @param  Pages                 The number of 4 KB pages to allocate.
   @param  Alignment             The requested alignment of the allocation.
+  @param  Alignment             The requested alignment of the allocation.
                                 Must be a power of two.
                                 If Alignment is zero, then byte alignment is used.
 …
   returned.  If there is not enough memory at the specified alignment remaining to satisfy the
   request, then NULL is returned.
   If Alignment is not a power of two and Alignment is not zero, then ASSERT().
   If Pages plus EFI_SIZE_TO_PAGES (Alignment) overflows, then ASSERT().
   @param  Pages                 The number of 4 KB pages to allocate.
   @param  Alignment             The requested alignment of the allocation.
+  @param  Alignment             The requested alignment of the allocation.
                                 Must be a power of two.
                                 If Alignment is zero, then byte alignment is used.
 …
   returned.  If there is not enough memory at the specified alignment remaining to satisfy the
   request, then NULL is returned.
   If Alignment is not a power of two and Alignment is not zero, then ASSERT().
   If Pages plus EFI_SIZE_TO_PAGES (Alignment) overflows, then ASSERT().
   @param  Pages                 The number of 4 KB pages to allocate.
   @param  Alignment             The requested alignment of the allocation.
+  @param  Alignment             The requested alignment of the allocation.
                                 Must be a power of two.
                                 If Alignment is zero, then byte alignment is used.
 …
   Frees the number of 4KB pages specified by Pages from the buffer specified by Buffer.  Buffer
   must have been allocated on a previous call to the aligned page allocation services of the Memory
   Allocation Library.  If it is not possible to free allocated pages, then this function will
+  Allocation Library.  If it is not possible to free allocated pages, then this function will
   perform no actions.
   If Buffer was not allocated with an aligned page allocation function in the Memory Allocation
   Library, then ASSERT().
   If Pages is zero, then ASSERT().
   @param  Buffer                The pointer to the buffer of pages to free.
   @param  Pages                 The number of 4 KB pages to free.
 …
 VOID *
 InternalAllocatePool (
   IN EFI_MEMORY_TYPE  MemoryType,
+  IN EFI_MEMORY_TYPE  MemoryType,
   IN UINTN            AllocationSize
+  )
+{
   //
   // If we need lots of small runtime/reserved memory type from PEI in the future,
   // we can consider providing a more complex algorithm that allocates runtime pages and
   // provide pool allocations from those pages.
+  // If we need lots of small runtime/reserved memory type from PEI in the future,
+  // we can consider providing a more complex algorithm that allocates runtime pages and
+  // provide pool allocations from those pages.
   //
   return InternalAllocatePages (MemoryType, EFI_SIZE_TO_PAGES (AllocationSize));
 …
   EFI_STATUS        Status;
   VOID              *Buffer;
   Status = PeiServicesAllocatePool (AllocationSize, &Buffer);
   if (EFI_ERROR (Status)) {
 …
 VOID *
 InternalAllocateZeroPool (
   IN EFI_MEMORY_TYPE  PoolType,
+  IN EFI_MEMORY_TYPE  PoolType,
   IN UINTN            AllocationSize
+  )
+  )
+{
   VOID  *Memory;
 …
   is not enough memory remaining to satisfy the request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  PoolType              The type of pool to allocate.
 …
 VOID *
 InternalAllocateCopyPool (
   IN EFI_MEMORY_TYPE  PoolType,
+  IN EFI_MEMORY_TYPE  PoolType,
   IN UINTN            AllocationSize,
   IN CONST VOID       *Buffer
+  )
+  )
+{
   VOID  *Memory;
 …
+  }
   return Memory;
+}
+}
 /**
 …
   allocated buffer.  If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there
   is not enough memory remaining to satisfy the request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  AllocationSize        The number of bytes to allocate and zero.
 …
   allocated buffer.  If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there
   is not enough memory remaining to satisfy the request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  AllocationSize        The number of bytes to allocate and zero.
 …
   allocated buffer.  If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there
   is not enough memory remaining to satisfy the request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  AllocationSize        The number of bytes to allocate and zero.
 …
   Allocates and zeros the number bytes specified by NewSize from memory of the type
   specified by PoolType.  If OldBuffer is not NULL, then the smaller of OldSize and
   NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  specified by PoolType.  If OldBuffer is not NULL, then the smaller of OldSize and
+  NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
   If the allocation of the new buffer is successful and the smaller of NewSize and OldSize
   is greater than (MAX_ADDRESS - OldBuffer + 1), then ASSERT().
 …
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
                          optional parameter that may be NULL.
 …
 VOID *
 InternalReallocatePool (
   IN EFI_MEMORY_TYPE  PoolType,
+  IN EFI_MEMORY_TYPE  PoolType,
   IN UINTN            OldSize,
   IN UINTN            NewSize,
 …
   Allocates and zeros the number bytes specified by NewSize from memory of type
   EfiBootServicesData.  If OldBuffer is not NULL, then the smaller of OldSize and
   NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  EfiBootServicesData.  If OldBuffer is not NULL, then the smaller of OldSize and
+  NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
   If the allocation of the new buffer is successful and the smaller of NewSize and OldSize
   is greater than (MAX_ADDRESS - OldBuffer + 1), then ASSERT().
 …
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
                          parameter that may be NULL.
 …
   Allocates and zeros the number bytes specified by NewSize from memory of type
   EfiRuntimeServicesData.  If OldBuffer is not NULL, then the smaller of OldSize and
   NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  EfiRuntimeServicesData.  If OldBuffer is not NULL, then the smaller of OldSize and
+  NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
 …
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
                          parameter that may be NULL.
 …
   Allocates and zeros the number bytes specified by NewSize from memory of type
   EfiReservedMemoryType.  If OldBuffer is not NULL, then the smaller of OldSize and
   NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  EfiReservedMemoryType.  If OldBuffer is not NULL, then the smaller of OldSize and
+  NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
 …
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
                          optional parameter that may be NULL.
 …
   pool allocation services of the Memory Allocation Library.  If it is not possible to free pool
   resources, then this function will perform no actions.
   If Buffer was not allocated with a pool allocation function in the Memory Allocation Library,
   then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/CompareMemWrapper.c

-              r48674
+              r58466
   value returned is the first mismatched byte in SourceBuffer subtracted from the first
   mismatched byte in DestinationBuffer.
   If Length > 0 and DestinationBuffer is NULL, then ASSERT().
   If Length > 0 and SourceBuffer is NULL, then ASSERT().
 …
   @retval Non-zero          The first mismatched byte in SourceBuffer subtracted from the first
                             mismatched byte in DestinationBuffer.
 **/
 INTN

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/CopyMemWrapper.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   DestinationBuffer.  The implementation must be reentrant, and it must handle the case
   where SourceBuffer overlaps DestinationBuffer.
   If Length is greater than (MAX_ADDRESS - DestinationBuffer + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - SourceBuffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/MemLib.c

-              r48674
+              r58466
   This function wraps the gPS->CopyMem ().
   @param  DestinationBuffer   The pointer to the destination buffer of the memory copy.
   @param  SourceBuffer        The pointer to the source buffer of the memory copy.
 …
   This function wraps the gPS->SetMem ().
   @param  Buffer    Memory to set.
   @param  Size      The number of bytes to set.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/MemLibGuid.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   This function copies the contents of the 128-bit GUID specified by SourceGuid to
   DestinationGuid, and returns DestinationGuid.
   If DestinationGuid is NULL, then ASSERT().
   If SourceGuid is NULL, then ASSERT().
 …
   This function compares Guid1 to Guid2.  If the GUIDs are identical then TRUE is returned.
   If there are any bit differences in the two GUIDs, then FALSE is returned.
   If Guid1 is NULL, then ASSERT().
   If Guid2 is NULL, then ASSERT().
 …
   GUID in the target buffer is returned.  If no match is found, then NULL is returned.
   If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/MemLibInternals.h

-              r48674
+              r58466
   This function wraps the (*PeiServices)->CopyMem ().
   @param  DestinationBuffer   The pointer to the destination buffer of the memory copy.
   @param  SourceBuffer        The pointer to the source buffer of the memory copy.
 …
   This function wraps the (*PeiServices)->SetMem ().
   @param  Buffer    The memory to set.
   @param  Size      The number of bytes to set.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/ScanMem16Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 16-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/ScanMem32Wrapper.c

r48674	r58466
33	33	then a pointer to the matching byte in the target buffer is returned. If no match is found,
34	34	then NULL is returned. If Length is 0, then NULL is returned.
35
	35
36	36	If Length > 0 and Buffer is NULL, then ASSERT().
37	37	If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/ScanMem64Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 64-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/ScanMem8Wrapper.c

-              r48674
+              r58466
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT (Buffer != NULL);
   ASSERT ((Length - 1) <= (MAX_ADDRESS - (UINTN)Buffer));
   return (VOID*)InternalMemScanMem8 (Buffer, Length, Value);
+}
 /**
   Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
+  Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
   UINTN sized value in the target buffer.
 …
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a UINTN boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/SetMemWrapper.c

r48674	r58466
30	30
31	31	This function fills Length bytes of Buffer with Value, and returns Buffer.
32
	32
33	33	If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
34	34

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiMemoryLib/ZeroMemWrapper.c

-              r48674
+              r58466
     PeiMemoryLib
     UefiMemoryLib
   Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   This function fills Length bytes of Buffer with zeros, and returns Buffer.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiPalLib/PeiPalLib.c

-              r48674
+              r58466
   Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiPcdLib/PeiPcdLib.c

-              r58459
+              r58466
 Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php
 THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+This program and the accompanying materials
+are licensed and made available under the terms and conditions of the BSD License
+which accompanies this distribution.  The full text of the license may be found at
+http://opensource.org/licenses/bsd-license.php
+THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 …
   Retrieve the PCD_PPI pointer.
   This function is to locate PCD_PPI PPI via PeiService.
+  This function is to locate PCD_PPI PPI via PeiService.
   If fail to locate PCD_PPI, then ASSERT_EFI_ERROR().
   @retval PCD_PPI * The pointer to the PCD_PPI.
 …
 GetPcdPpiPointer (
   VOID
+  )
+  )
+{
   EFI_STATUS        Status;
   PCD_PPI           *PcdPpi;
   Status = PeiServicesLocatePpi (&gPcdPpiGuid, 0, NULL, (VOID **)&PcdPpi);
   ASSERT_EFI_ERROR (Status);
 …
   Retrieve the pointer of EFI_PEI_PCD_PPI defined in PI 1.2 Vol 3.
   This function is to locate EFI_PEI_PCD_PPI PPI via PeiService.
+  This function is to locate EFI_PEI_PCD_PPI PPI via PeiService.
   If fail to locate EFI_PEI_PCD_PPI, then ASSERT_EFI_ERROR().
   @retval EFI_PEI_PCD_PPI * The pointer to the EFI_PEI_PCD_PPI.
 …
   EFI_STATUS        Status;
   EFI_PEI_PCD_PPI   *PiPcdPpi;
   Status = PeiServicesLocatePpi (&gEfiPeiPcdPpiGuid, 0, NULL, (VOID **)&PiPcdPpi);
   ASSERT_EFI_ERROR (Status);
   return PiPcdPpi;
+}
+}
 /**
   Retrieve the GET_PCD_INFO_PPI pointer.
   This function is to locate GET_PCD_INFO_PPI PPI via PeiService.
+  This function is to locate GET_PCD_INFO_PPI PPI via PeiService.
   If fail to locate GET_PCD_INFO_PPI, then ASSERT_EFI_ERROR().
 …
 GetPcdInfoPpiPointer (
   VOID
+  )
+  )
+{
   EFI_STATUS            Status;
   GET_PCD_INFO_PPI      *PcdInfoPpi;
   Status = PeiServicesLocatePpi (&gGetPcdInfoPpiGuid, 0, NULL, (VOID **)&PcdInfoPpi);
   ASSERT_EFI_ERROR (Status);
 …
   Retrieve the pointer of EFI_GET_PCD_INFO_PPI defined in PI 1.2.1 Vol 3.
   This function is to locate EFI_GET_PCD_INFO_PPI PPI via PeiService.
+  This function is to locate EFI_GET_PCD_INFO_PPI PPI via PeiService.
   If fail to locate EFI_GET_PCD_INFO_PPI, then ASSERT_EFI_ERROR().
 …
   EFI_STATUS            Status;
   EFI_GET_PCD_INFO_PPI  *PiPcdInfoPpi;
   Status = PeiServicesLocatePpi (&gEfiGetPcdInfoPpiGuid, 0, NULL, (VOID **)&PiPcdInfoPpi);
   ASSERT_EFI_ERROR (Status);
   return PiPcdInfoPpi;
+}
+}
 /**
 …
   Sets the current SKU in the PCD database to the value specified by SkuId.  SkuId is returned.
   If SkuId >= PCD_MAX_SKU_ID, then ASSERT().
   @param  SkuId   The SKU value that will be used when the PCD service retrieves
+  If SkuId >= PCD_MAX_SKU_ID, then ASSERT().
+  @param  SkuId   The SKU value that will be used when the PCD service retrieves
                   and sets values associated with a PCD token.
 …
   GetPiPcdPpiPointer()->SetSku (SkuId);
   return SkuId;
+}
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 8-bit value for the token specified by TokenNumber.
+  Returns the 8-bit value for the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the 8-bit value for the token specified by TokenNumber.
+  @return Returns the 8-bit value for the token specified by TokenNumber.
 **/
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 16-bit value for the token specified by TokenNumber.
+  Returns the 16-bit value for the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the 16-bit value for the token specified by TokenNumber.
+  @return Returns the 16-bit value for the token specified by TokenNumber.
 **/
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 32-bit value for the token specified by TokenNumber.
+  Returns the 32-bit value for the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 64-bit value for the token specified by TokenNumber.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the pointer to the buffer of the token specified by TokenNumber.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the Boolean value of the token specified by TokenNumber.
+  Returns the Boolean value of the token specified by TokenNumber.
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the Boolean value of the token specified by TokenNumber.
 **/
 BOOLEAN
+  @return Returns the Boolean value of the token specified by TokenNumber.
+**/
+BOOLEAN
 EFIAPI
 LibPcdGetBool (
 …
   @param[in]  TokenNumber The PCD token number to retrieve a current value for.
   @return Returns the size of the token specified by TokenNumber.
+  @return Returns the size of the token specified by TokenNumber.
 **/
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 8-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid         The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid         The pointer to a 128-bit unique value that designates
                            which namespace to retrieve a value from.
   @param[in]  TokenNumber  The PCD token number to retrieve a current value for.
 …
   Returns the 16-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid         The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid         The pointer to a 128-bit unique value that designates
                            which namespace to retrieve a value from.
   @param[in]  TokenNumber  The PCD token number to retrieve a current value for.
 …
 /**
   Returns the 32-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid         The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid         The pointer to a 128-bit unique value that designates
                            which namespace to retrieve a value from.
   @param[in]  TokenNumber  The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the 64-bit value for the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the pointer to the buffer of token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve a value for a given PCD token.
   Returns the Boolean value of the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  Returns the Boolean value of the token specified by TokenNumber and Guid.
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to retrieve the size of a given PCD token.
   Returns the size of the token specified by TokenNumber and Guid.
   If Guid is NULL, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that designates
+  Returns the size of the token specified by TokenNumber and Guid.
+  If Guid is NULL, then ASSERT().
+  @param[in]  Guid          The pointer to a 128-bit unique value that designates
                             which namespace to retrieve a value from.
   @param[in]  TokenNumber   The PCD token number to retrieve a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 8-bit value for the token specified by TokenNumber
+  Sets the 8-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
   ASSERT_EFI_ERROR (Status);
   return Value;
+}
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 16-bit value for the token specified by TokenNumber
+  Sets the 16-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
   ASSERT_EFI_ERROR (Status);
   return Value;
+}
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 32-bit value for the token specified by TokenNumber
+  Sets the 32-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 64-bit value for the token specified by TokenNumber
+  Sets the 64-bit value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets a buffer for the token specified by TokenNumber to the value
   specified by Buffer and SizeOfBuffer.  Buffer is returned.
   If SizeOfBuffer is greater than the maximum size support by TokenNumber,
   then set SizeOfBuffer to the maximum size supported by TokenNumber and
+  Sets a buffer for the token specified by TokenNumber to the value
+  specified by Buffer and SizeOfBuffer.  Buffer is returned.
+  If SizeOfBuffer is greater than the maximum size support by TokenNumber,
+  then set SizeOfBuffer to the maximum size supported by TokenNumber and
   return NULL to indicate that the set operation was not actually performed,
   or ASSERT() if the set operation was not corretly performed.
   If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to the
+  If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to the
   maximum size supported by TokenName and NULL must be returned.
   If SizeOfBuffer is NULL, then ASSERT().
   If SizeOfBuffer > 0 and Buffer is NULL, then ASSERT().
   @param[in]      TokenNumber   The PCD token number to set a current value for.
   @param[in, out] SizeOfBuffer  The size, in bytes, of Buffer.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the Boolean value for the token specified by TokenNumber
+  Sets the Boolean value for the token specified by TokenNumber
   to the value specified by Value.  Value is returned.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 8-bit value for the token specified by TokenNumber and
+  Sets the 8-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 16-bit value for the token specified by TokenNumber and
+  Sets the 16-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 32-bit value for the token specified by TokenNumber and
+  Sets the 32-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the 64-bit value for the token specified by TokenNumber and
+  Sets the 64-bit value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets a buffer for the token specified by TokenNumber to the value specified by
   Buffer and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
   the maximum size support by TokenNumber, then set SizeOfBuffer to the maximum size
   supported by TokenNumber and return NULL to indicate that the set operation
+  Sets a buffer for the token specified by TokenNumber to the value specified by
+  Buffer and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
+  the maximum size support by TokenNumber, then set SizeOfBuffer to the maximum size
+  supported by TokenNumber and return NULL to indicate that the set operation
   was not actually performed, or ASSERT() if the set operation was not corretly performed.
   If Guid is NULL, then ASSERT().
   If SizeOfBuffer is NULL, then ASSERT().
   If SizeOfBuffer > 0 and Buffer is NULL, then ASSERT().
   @param[in]  Guid              The pointer to a 128-bit unique value that
+  @param[in]  Guid              The pointer to a 128-bit unique value that
                                 designates which namespace to set a value from.
   @param[in]  TokenNumber       The PCD token number to set a current value for.
 …
 /**
   This function provides a means by which to set a value for a given PCD token.
   Sets the Boolean value for the token specified by TokenNumber and
+  Sets the Boolean value for the token specified by TokenNumber and
   Guid to the value specified by Value. Value is returned.
 …
   If the set operation was not correctly performed, then ASSERT().
   @param[in]  Guid          The pointer to a 128-bit unique value that
+  @param[in]  Guid          The pointer to a 128-bit unique value that
                             designates which namespace to set a value from.
   @param[in]  TokenNumber   The PCD token number to set a current value for.
 …
 /**
   Set up a notification function that is called when a specified token is set.
   When the token specified by TokenNumber and Guid is set,
   then notification function specified by NotificationFunction is called.
+  When the token specified by TokenNumber and Guid is set,
+  then notification function specified by NotificationFunction is called.
   If Guid is NULL, then the default token space is used.
   If NotificationFunction is NULL, then ASSERT().
   @param[in]  Guid                  The pointer to a 128-bit unique value that
                                     designates which namespace to set a value from.
+  @param[in]  Guid                  The pointer to a 128-bit unique value that
+                                    designates which namespace to set a value from.
                                     If NULL, then the default token space is used.
   @param[in]  TokenNumber           The PCD token number to monitor.
   @param[in]  NotificationFunction  The function to call when the token
+  @param[in]  NotificationFunction  The function to call when the token
                                     specified by Guid and TokenNumber is set.
 …
 /**
   Disable a notification function that was established with LibPcdCallbackonSet().
   Disable a notification function that was previously established with LibPcdCallbackOnSet().
   If NotificationFunction is NULL, then ASSERT().
   If LibPcdCallbackOnSet() was not previously called with Guid, TokenNumber,
+  If LibPcdCallbackOnSet() was not previously called with Guid, TokenNumber,
   and NotificationFunction, then ASSERT().
   @param[in]  Guid                 Specify the GUID token space.
   @param[in]  TokenNumber          Specify the token number.
 …
 /**
   Retrieves the next token in a token space.
   Retrieves the next PCD token number from the token space specified by Guid.
   If Guid is NULL, then the default token space is used.  If TokenNumber is 0,
   then the first token number is returned.  Otherwise, the token number that
   follows TokenNumber in the token space is returned.  If TokenNumber is the last
   token number in the token space, then 0 is returned.
+  Retrieves the next PCD token number from the token space specified by Guid.
+  If Guid is NULL, then the default token space is used.  If TokenNumber is 0,
+  then the first token number is returned.  Otherwise, the token number that
+  follows TokenNumber in the token space is returned.  If TokenNumber is the last
+  token number in the token space, then 0 is returned.
   If TokenNumber is not 0 and is not in the token space specified by Guid, then ASSERT().
   @param[in]  Guid        The pointer to a 128-bit unique value that designates which namespace
+  @param[in]  Guid        The pointer to a 128-bit unique value that designates which namespace
                           to set a value from.  If NULL, then the default token space is used.
   @param[in]  TokenNumber The previous PCD token number.  If 0, then retrieves the first PCD
+  @param[in]  TokenNumber The previous PCD token number.  If 0, then retrieves the first PCD
                           token number.
 …
 **/
 UINTN
+UINTN
 EFIAPI
 LibPcdGetNextToken (
 …
 /**
   Used to retrieve the list of available PCD token space GUIDs.
   Returns the PCD token space GUID that follows TokenSpaceGuid in the list of token spaces
   in the platform.
   If TokenSpaceGuid is NULL, then a pointer to the first PCD token spaces returned.
   If TokenSpaceGuid is the last PCD token space GUID in the list, then NULL is returned.
   @param  TokenSpaceGuid  The pointer to the a PCD token space GUID
 …
 /**
   Sets a value of a patchable PCD entry that is type pointer.
   Sets the PCD entry specified by PatchVariable to the value specified by Buffer
   and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
   MaximumDatumSize, then set SizeOfBuffer to MaximumDatumSize and return
   NULL to indicate that the set operation was not actually performed.
   If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to
+  Sets the PCD entry specified by PatchVariable to the value specified by Buffer
+  and SizeOfBuffer.  Buffer is returned.  If SizeOfBuffer is greater than
+  MaximumDatumSize, then set SizeOfBuffer to MaximumDatumSize and return
+  NULL to indicate that the set operation was not actually performed.
+  If SizeOfBuffer is set to MAX_ADDRESS, then SizeOfBuffer must be set to
   MaximumDatumSize and NULL must be returned.
   If PatchVariable is NULL, then ASSERT().
   If SizeOfBuffer is NULL, then ASSERT().
   If SizeOfBuffer > 0 and Buffer is NULL, then ASSERT().
   @param[in] PatchVariable      A pointer to the global variable in a module that is
+  @param[in] PatchVariable      A pointer to the global variable in a module that is
                                 the target of the set operation.
   @param[in] MaximumDatumSize   The maximum size allowed for the PCD entry specified by PatchVariable.
   @param[in, out] SizeOfBuffer  A pointer to the size, in bytes, of Buffer.
   @param[in] Buffer             A pointer to the buffer to used to set the target variable.
   @return Return the pointer to the buffer been set.
 …
   ASSERT (PatchVariable != NULL);
   ASSERT (SizeOfBuffer  != NULL);
   if (*SizeOfBuffer > 0) {
     ASSERT (Buffer != NULL);
 …
     return NULL;
+  }
   CopyMem (PatchVariable, Buffer, *SizeOfBuffer);
   return (VOID *) Buffer;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiPcdLib/PeiPcdLib.inf

-              r58459
+              r58466
+#
 # There are two PCD PPIs as follows:
 #   1) PCD_PPI
+#   1) PCD_PPI
 #      It is EDKII implementation which support Dynamic/DynamicEx Pcds.
 #   2) EFI_PEI_PCD_PPI
 #      It is defined by PI specification 1.2, Vol 3 which only support dynamicEx
+#      It is defined by PI specification 1.2, Vol 3 which only support dynamicEx
 #      type Pcd.
 # For dynamicEx type PCD, it is compatible between PCD_PPI and EFI_PEI_PCD_PPI.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiPciLibPciCfg2/PciLib.c

-              r58459
+              r58466
   text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 …
 /**
   Registers a PCI device so PCI configuration registers may be accessed after
+  Registers a PCI device so PCI configuration registers may be accessed after
   SetVirtualAddressMap().
   Registers the PCI device specified by Address so all the PCI configuration registers
+  Registers the PCI device specified by Address so all the PCI configuration registers
   associated with that PCI device may be accessed after SetVirtualAddressMap() is called.
   If Address > 0x0FFFFFFF, then ASSERT().
   @param  Address The address that encodes the PCI Bus, Device, Function and
                   Register.
+  If Address > 0x0FFFFFFF, then ASSERT().
+  @param  Address The address that encodes the PCI Bus, Device, Function and
+                  Register.
   @retval RETURN_SUCCESS           The PCI device was registered for runtime access.
   @retval RETURN_UNSUPPORTED       An attempt was made to call this function
+  @retval RETURN_UNSUPPORTED       An attempt was made to call this function
                                    after ExitBootServices().
   @retval RETURN_UNSUPPORTED       The resources required to access the PCI device

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiPciSegmentLibPciCfg2/PciSegmentLib.c

-              r58459
+              r58466
   text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 …
   This internal function retrieves PCI CFG2 PPI from PPI database.
   @param  Address       The address that encodes the PCI Segment, Bus, Device,
+  @param  Address       The address that encodes the PCI Segment, Bus, Device,
                         Function and Register.
 …
 /**
   Register a PCI device so PCI configuration registers may be accessed after
+  Register a PCI device so PCI configuration registers may be accessed after
   SetVirtualAddressMap().
   If any reserved bits in Address are set, then ASSERT().
   @param  Address The address that encodes the PCI Bus, Device, Function and
                   Register.
   @retval RETURN_SUCCESS           The PCI device was registered for runtime access.
   @retval RETURN_UNSUPPORTED       An attempt was made to call this function
+  @retval RETURN_UNSUPPORTED       An attempt was made to call this function
                                    after ExitBootServices().
   @retval RETURN_UNSUPPORTED       The resources required to access the PCI device
 …
   Reads and returns the 8-bit PCI configuration register specified by Address.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   @param  Address   The address that encodes the PCI Segment, Bus, Device, Function,
+  If any reserved bits in Address are set, then ASSERT().
+  @param  Address   The address that encodes the PCI Segment, Bus, Device, Function,
                     and Register.
 …
   Writes the 8-bit PCI configuration register specified by Address with the value specified by Value.
   Value is returned.  This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
 …
   Performs a bitwise AND of an 8-bit PCI configuration register with an 8-bit value,
   followed a  bitwise OR with another 8-bit value.
   Reads the 8-bit PCI configuration register specified by Address,
   performs a bitwise AND between the read result and the value specified by AndData,
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
 …
   Reads and returns the 16-bit PCI configuration register specified by Address.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 16-bit boundary, then ASSERT().
   @param  Address   The address that encodes the PCI Segment, Bus, Device, Function, and Register.
 …
   Writes the 16-bit PCI configuration register specified by Address with the value specified by Value.
   Value is returned.  This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 16-bit boundary, then ASSERT().
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 16-bit boundary, then ASSERT().
   @param  Address   The address that encodes the PCI Segment, Bus, Device, Function, and Register.
   @param  AndData   The value to AND with the PCI configuration register.
 …
   Performs a bitwise AND of a 16-bit PCI configuration register with a 16-bit value,
   followed a  bitwise OR with another 16-bit value.
   Reads the 16-bit PCI configuration register specified by Address,
   performs a bitwise AND between the read result and the value specified by AndData,
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 16-bit boundary, then ASSERT().
 …
   Reads the 16-bit PCI configuration register specified by Address,
   performs a bitwise OR between the read result and the value specified by OrData,
   and writes the result to the 16-bit PCI configuration register specified by Address.
+  and writes the result to the 16-bit PCI configuration register specified by Address.
   If any reserved bits in Address are set, then ASSERT().
 …
   This function must guarantee that all PCI read and write operations are serialized.
   Extra left bits in OrData are stripped.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 16-bit boundary, then ASSERT().
 …
   Reads and returns the 32-bit PCI configuration register specified by Address.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 32-bit boundary, then ASSERT().
   @param  Address   The address that encodes the PCI Segment, Bus, Device, Function,
+  @param  Address   The address that encodes the PCI Segment, Bus, Device, Function,
                     and Register.
 …
   Writes the 32-bit PCI configuration register specified by Address with the value specified by Value.
   Value is returned.  This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 32-bit boundary, then ASSERT().
   @param  Address     The address that encodes the PCI Segment, Bus, Device,
+  @param  Address     The address that encodes the PCI Segment, Bus, Device,
                       Function, and Register.
   @param  Value       The value to write.
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 32-bit boundary, then ASSERT().
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 32-bit boundary, then ASSERT().
   @param  Address   The address that encodes the PCI Segment, Bus, Device, Function,
+  @param  Address   The address that encodes the PCI Segment, Bus, Device, Function,
                     and Register.
   @param  AndData   The value to AND with the PCI configuration register.
 …
   Performs a bitwise AND of a 32-bit PCI configuration register with a 32-bit value,
   followed a  bitwise OR with another 32-bit value.
   Reads the 32-bit PCI configuration register specified by Address,
   performs a bitwise AND between the read result and the value specified by AndData,
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 32-bit boundary, then ASSERT().
 …
   AND, and writes the result back to the bit field in the 32-bit register.
   Reads the 32-bit PCI configuration register specified by Address, performs a bitwise
   AND between the read result and the value specified by AndData, and writes the result
 …
   If Size > 0 and Buffer is NULL, then ASSERT().
   @param  StartAddress  The starting address that encodes the PCI Segment, Bus,
+  @param  StartAddress  The starting address that encodes the PCI Segment, Bus,
                         Device, Function and Register.
   @param  Size          The size in bytes of the transfer.
 …
   If Size > 0 and Buffer is NULL, then ASSERT().
   @param  StartAddress  The starting address that encodes the PCI Segment, Bus,
+  @param  StartAddress  The starting address that encodes the PCI Segment, Bus,
                         Device, Function and Register.
   @param  Size          The size in bytes of the transfer.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.c

-              r48674
+              r58466
   Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
   as permanent memory that may be used for general purpose use by software.
   The amount of memory available to software may be less than MemoryLength
   if published memory has alignment restrictions.
+  if published memory has alignment restrictions.
   If MemoryLength is 0, then ASSERT().
   If MemoryLength is greater than (MAX_ADDRESS - MemoryBegin + 1), then ASSERT().
+  If MemoryLength is greater than (MAX_ADDRESS - MemoryBegin + 1), then ASSERT().
   @param  MemoryBegin               The start address of the memory being declared.
 …
   Status      = PeiServicesInstallPeiMemory (MemoryBegin, MemoryLength);
   return (RETURN_STATUS) Status;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiServicesLib/PeiServicesLib.c

-              r58459
+              r58466
   installed or reinstalled.
   @param  NotifyList            A pointer to the list of notification interfaces
+  @param  NotifyList            A pointer to the list of notification interfaces
                                 that the caller shall install.
 …
   This service enables a PEIM to ascertain the address of the list of HOBs in memory.
   @param  HobList               A pointer to the list of HOBs that the PEI Foundation
+  @param  HobList               A pointer to the list of HOBs that the PEI Foundation
                                 will initialize.
   @retval EFI_SUCCESS           The list was successfully returned.
   @retval EFI_NOT_AVAILABLE_YET The HOB list is not yet published.
 …
   @param  Type                  The type of HOB to be installed.
   @param  Length                The length of the HOB to be added.
   @param  Hob                   The address of a pointer that will contain the
+  @param  Hob                   The address of a pointer that will contain the
                                 HOB header.
 …
   This service enables PEIMs to discover additional firmware volumes.
   @param  Instance              This instance of the firmware volume to find.  The
+  @param  Instance              This instance of the firmware volume to find.  The
                                 value 0 is the Boot Firmware Volume (BFV).
   @param  VolumeHandle          Handle of the firmware volume header of the volume
 …
   @param  SearchType            A filter to find files only of this type.
   @param  VolumeHandle          The pointer to the firmware volume header of the
                                 volume to search. This parameter must point to a
                                 valid FFS volume.
+  @param  VolumeHandle          The pointer to the firmware volume header of the
+                                volume to search. This parameter must point to a
+                                valid FFS volume.
   @param  FileHandle            Handle of the current file from which to begin searching.
 …
   @param  SectionType           The value of the section type to find.
   @param  FileHandle            A pointer to the file header that contains the set
+  @param  FileHandle            A pointer to the file header that contains the set
                                 of sections to be searched.
   @param  SectionData           A pointer to the discovered section, if successful.
 …
   @param  SectionType           The value of the section type to find.
   @param  SectionInstance       Section instance to find.
   @param  FileHandle            A pointer to the file header that contains the set
+  @param  FileHandle            A pointer to the file header that contains the set
                                 of sections to be searched.
   @param  SectionData           A pointer to the discovered section, if successful.
 …
   @param  Size                  The number of bytes to allocate from the pool.
   @param  Buffer                If the call succeeds, a pointer to a pointer to
+  @param  Buffer                If the call succeeds, a pointer to a pointer to
                                 the allocate buffer; otherwise, undefined.
 …
 /**
   This service is a wrapper for the PEI Service RegisterForShadow(), except the
   pointer to the PEI Services Table has been removed.  See the Platform
   Initialization Pre-EFI Initialization Core Interface Specification for details.
+  This service is a wrapper for the PEI Service RegisterForShadow(), except the
+  pointer to the PEI Services Table has been removed.  See the Platform
+  Initialization Pre-EFI Initialization Core Interface Specification for details.
   @param FileHandle             PEIM's file handle. Must be the currently
                                 executing PEIM.
   @retval EFI_SUCCESS           The PEIM was successfully registered for
                                 shadowing.
 …
 /**
   This service is a wrapper for the PEI Service FfsGetFileInfo(), except the pointer to the PEI Services
   Table has been removed.  See the Platform Initialization Pre-EFI Initialization Core Interface
   Specification for details.
+  This service is a wrapper for the PEI Service FfsGetFileInfo(), except the pointer to the PEI Services
+  Table has been removed.  See the Platform Initialization Pre-EFI Initialization Core Interface
+  Specification for details.
   @param FileHandle              The handle of the file.
 …
   @retval EFI_SUCCESS             File information returned.
   @retval EFI_INVALID_PARAMETER   If FileHandle does not
                                   represent a valid file.
   @retval EFI_INVALID_PARAMETER   FileInfo is NULL.
 **/
 EFI_STATUS
 EFIAPI
+**/
+EFI_STATUS
+EFIAPI
 PeiServicesFfsGetFileInfo (
   IN CONST  EFI_PEI_FILE_HANDLE   FileHandle,
 …
 /**
   This service is a wrapper for the PEI Service FfsFindByName(), except the pointer to the PEI Services
   Table has been removed.  See the Platform Initialization Pre-EFI Initialization Core Interface
   Specification for details.
+  This service is a wrapper for the PEI Service FfsFindByName(), except the pointer to the PEI Services
+  Table has been removed.  See the Platform Initialization Pre-EFI Initialization Core Interface
+  Specification for details.
   @param FileName                 A pointer to the name of the file to
 …
                                   Upon exit, points to the found file's
                                   handle or NULL if it could not be found.
   @param FileHandle               The pointer to found file handle
+  @param FileHandle               The pointer to found file handle
   @retval EFI_SUCCESS             File was found.
 …
 /**
   This service is a wrapper for the PEI Service FfsGetVolumeInfo(), except the pointer to the PEI Services
   Table has been removed.  See the Platform Initialization Pre-EFI Initialization Core Interface
   Specification for details.
+  This service is a wrapper for the PEI Service FfsGetVolumeInfo(), except the pointer to the PEI Services
+  Table has been removed.  See the Platform Initialization Pre-EFI Initialization Core Interface
+  Specification for details.
   @param VolumeHandle             Handle of the volume.
 …
   @retval EFI_SUCCESS             File information returned.
   @retval EFI_INVALID_PARAMETER   If FileHandle does not
                                   represent a valid file.
   @retval EFI_INVALID_PARAMETER   If FileInfo is NULL.
 …
+  )
+{
   EFI_STATUS                       Status;
+  EFI_STATUS                       Status;
   EFI_PEI_FIRMWARE_VOLUME_INFO_PPI *FvInfoPpi;
   EFI_PEI_PPI_DESCRIPTOR           *FvInfoPpiDescriptor;

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiServicesLib/PeiServicesLib.inf

r58459	r58466
21	21	MODULE_TYPE = PEIM
22	22	VERSION_STRING = 1.0
23		LIBRARY_CLASS = PeiServicesLib\|SEC PEIM PEI_CORE
	23	LIBRARY_CLASS = PeiServicesLib\|SEC PEIM PEI_CORE
24	24	PI_SPECIFICATION_VERSION = 0x0001000A
25	25

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c

-              r58459
+              r58466
 /** @file
   PEI Services Table Pointer Library.
   This library is used for PEIM which does executed from flash device directly but
   executed in memory.
 …
 /**
   Caches a pointer PEI Services Table.
   Caches the pointer to the PEI Services Table specified by PeiServicesTablePointer
   in a CPU specific manner as specified in the CPU binding section of the Platform Initialization
   Pre-EFI Initialization Core Interface Specification.
+  Caches a pointer PEI Services Table.
+  Caches the pointer to the PEI Services Table specified by PeiServicesTablePointer
+  in a CPU specific manner as specified in the CPU binding section of the Platform Initialization
+  Pre-EFI Initialization Core Interface Specification.
   If PeiServicesTablePointer is NULL, then ASSERT().
   @param    PeiServicesTablePointer   The address of PeiServices pointer.
 **/
 …
   Retrieves the cached value of the PEI Services Table pointer.
   Returns the cached value of the PEI Services Table pointer in a CPU specific manner
   as specified in the CPU binding section of the Platform Initialization Pre-EFI
+  Returns the cached value of the PEI Services Table pointer in a CPU specific manner
+  as specified in the CPU binding section of the Platform Initialization Pre-EFI
   Initialization Core Interface Specification.
   If the cached PEI Services Table pointer is NULL, then ASSERT().
 …
 /**
   The constructor function caches the pointer to PEI services.
   The constructor function caches the pointer to PEI services.
   It will always return EFI_SUCCESS.
 …
 /**
   Perform CPU specific actions required to migrate the PEI Services Table
+  Perform CPU specific actions required to migrate the PEI Services Table
   pointer from temporary RAM to permanent RAM.
   For IA32 CPUs, the PEI Services Table pointer is stored in the 4 bytes
+  For IA32 CPUs, the PEI Services Table pointer is stored in the 4 bytes
   immediately preceding the Interrupt Descriptor Table (IDT) in memory.
   For X64 CPUs, the PEI Services Table pointer is stored in the 8 bytes
+  For X64 CPUs, the PEI Services Table pointer is stored in the 8 bytes
   immediately preceding the Interrupt Descriptor Table (IDT) in memory.
   For Itanium and ARM CPUs, a the PEI Services Table Pointer is stored in
   a dedicated CPU register.  This means that there is no memory storage
   associated with storing the PEI Services Table pointer, so no additional
+  a dedicated CPU register.  This means that there is no memory storage
+  associated with storing the PEI Services Table pointer, so no additional
   migration actions are required for Itanium or ARM CPUs.
 …
+{
   //
   //  PEI Services Table pointer is cached in the global variable. No additional
+  //  PEI Services Table pointer is cached in the global variable. No additional
   //  migration actions are required.
   //

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c

-              r58459
+              r58466
   According to PI specification, the peiservice pointer is stored prior at IDT
   table in IA32 and x64 architecture.
   Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
   Retrieves the cached value of the PEI Services Table pointer.
   Returns the cached value of the PEI Services Table pointer in a CPU specific manner
   as specified in the CPU binding section of the Platform Initialization Pre-EFI
+  Returns the cached value of the PEI Services Table pointer in a CPU specific manner
+  as specified in the CPU binding section of the Platform Initialization Pre-EFI
   Initialization Core Interface Specification.
   If the cached PEI Services Table pointer is NULL, then ASSERT().
 …
   CONST EFI_PEI_SERVICES  **PeiServices;
   IA32_DESCRIPTOR   Idtr;
   AsmReadIdtr (&Idtr);
   PeiServices = (CONST EFI_PEI_SERVICES **) (*(UINTN*)(Idtr.Base - sizeof (UINTN)));
 …
 /**
   Caches a pointer PEI Services Table.
   Caches the pointer to the PEI Services Table specified by PeiServicesTablePointer
   in a CPU specific manner as specified in the CPU binding section of the Platform Initialization
   Pre-EFI Initialization Core Interface Specification.
+  Caches a pointer PEI Services Table.
+  Caches the pointer to the PEI Services Table specified by PeiServicesTablePointer
+  in a CPU specific manner as specified in the CPU binding section of the Platform Initialization
+  Pre-EFI Initialization Core Interface Specification.
   The function set the pointer of PEI services immediately preceding the IDT table
   according to PI specification.
   If PeiServicesTablePointer is NULL, then ASSERT().
   @param    PeiServicesTablePointer   The address of PeiServices pointer.
 **/
 …
+{
   IA32_DESCRIPTOR        Idtr;
   ASSERT (PeiServicesTablePointer != NULL);
   AsmReadIdtr (&Idtr);
 …
 /**
   Perform CPU specific actions required to migrate the PEI Services Table
+  Perform CPU specific actions required to migrate the PEI Services Table
   pointer from temporary RAM to permanent RAM.
   For IA32 CPUs, the PEI Services Table pointer is stored in the 4 bytes
+  For IA32 CPUs, the PEI Services Table pointer is stored in the 4 bytes
   immediately preceding the Interrupt Descriptor Table (IDT) in memory.
   For X64 CPUs, the PEI Services Table pointer is stored in the 8 bytes
+  For X64 CPUs, the PEI Services Table pointer is stored in the 8 bytes
   immediately preceding the Interrupt Descriptor Table (IDT) in memory.
   For Itanium and ARM CPUs, a the PEI Services Table Pointer is stored in
   a dedicated CPU register.  This means that there is no memory storage
   associated with storing the PEI Services Table pointer, so no additional
+  a dedicated CPU register.  This means that there is no memory storage
+  associated with storing the PEI Services Table pointer, so no additional
   migration actions are required for Itanium or ARM CPUs.
 …
   //
   Status = (*PeiServices)->AllocatePages (
                             PeiServices,
+                            PeiServices,
                             EfiBootServicesCode,
                             EFI_SIZE_TO_PAGES(Idtr.Limit + 1 + sizeof (UINTN)),
 …
   Idtr.Base = (UINTN) IdtBase + sizeof (UINTN);
   AsmWriteIdtr (&Idtr);
   return;
+}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiServicesTablePointerLibKr7/PeiServicesTablePointer.c

-              r58459
+              r58466
   Retrieves the cached value of the PEI Services Table pointer.
   Returns the cached value of the PEI Services Table pointer in a CPU specific manner
   as specified in the CPU binding section of the Platform Initialization Pre-EFI
+  Returns the cached value of the PEI Services Table pointer in a CPU specific manner
+  as specified in the CPU binding section of the Platform Initialization Pre-EFI
   Initialization Core Interface Specification.
   If the cached PEI Services Table pointer is NULL, then ASSERT().
 …
 /**
   Caches a pointer PEI Services Table.
   Caches the pointer to the PEI Services Table specified by PeiServicesTablePointer
   in a CPU specific manner as specified in the CPU binding section of the Platform Initialization
   Pre-EFI Initialization Core Interface Specification.
   The function set the pointer of PEI services in KR7 register
+  Caches a pointer PEI Services Table.
+  Caches the pointer to the PEI Services Table specified by PeiServicesTablePointer
+  in a CPU specific manner as specified in the CPU binding section of the Platform Initialization
+  Pre-EFI Initialization Core Interface Specification.
+  The function set the pointer of PEI services in KR7 register
   according to PI specification.
   If PeiServicesTablePointer is NULL, then ASSERT().
   @param    PeiServicesTablePointer   The address of PeiServices pointer.
 **/
 …
   AsmWriteKr7 ((UINT64)(UINTN)PeiServicesTablePointer);
+}
 /**
   Perform CPU specific actions required to migrate the PEI Services Table
+  Perform CPU specific actions required to migrate the PEI Services Table
   pointer from temporary RAM to permanent RAM.
   For IA32 CPUs, the PEI Services Table pointer is stored in the 4 bytes
+  For IA32 CPUs, the PEI Services Table pointer is stored in the 4 bytes
   immediately preceding the Interrupt Descriptor Table (IDT) in memory.
   For X64 CPUs, the PEI Services Table pointer is stored in the 8 bytes
+  For X64 CPUs, the PEI Services Table pointer is stored in the 8 bytes
   immediately preceding the Interrupt Descriptor Table (IDT) in memory.
   For Itanium and ARM CPUs, a the PEI Services Table Pointer is stored in
   a dedicated CPU register.  This means that there is no memory storage
   associated with storing the PEI Services Table pointer, so no additional
+  a dedicated CPU register.  This means that there is no memory storage
+  associated with storing the PEI Services Table pointer, so no additional
   migration actions are required for Itanium or ARM CPUs.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiSmbusLibSmbus2Ppi/InternalSmbusLib.h

-              r48674
+              r58466
   the Length byte, word, or a block of data.
   @param  SmbusOperation  Signifies which particular SMBus hardware protocol
+  @param  SmbusOperation  Signifies which particular SMBus hardware protocol
                           instance that it will use to execute the SMBus transactions.
   @param  SmBusAddress    The address that encodes the SMBUS Slave Address,
                           SMBUS Command, SMBUS Data Length, and PEC.
   @param  Length          Signifies the number of bytes that this operation will
                           do. The maximum number of bytes can be revision specific
+  @param  Length          Signifies the number of bytes that this operation will
+                          do. The maximum number of bytes can be revision specific
                           and operation specific.
   @param  Buffer          Contains the value of data to execute to the SMBus slave
                           device. Not all operations require this argument. The
+  @param  Buffer          Contains the value of data to execute to the SMBus slave
+                          device. Not all operations require this argument. The
                           length of this buffer is identified by Length.
   @param  Status          Return status for the executed command.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiSmbusLibSmbus2Ppi/PeiSmbusLib.c

-              r48674
+              r58466
   the Length byte, word, or a block of data.
   @param  SmbusOperation  Signifies which particular SMBus hardware protocol instance
+  @param  SmbusOperation  Signifies which particular SMBus hardware protocol instance
                           that it will use to execute the SMBus transactions.
   @param  SmBusAddress    The address that encodes the SMBUS Slave Address,
                           SMBUS Command, SMBUS Data Length, and PEC.
   @param  Length          Signifies the number of bytes that this operation will
                           do. The maximum number of bytes can be revision specific
+  @param  Length          Signifies the number of bytes that this operation will
+                          do. The maximum number of bytes can be revision specific
                           and operation specific.
   @param  Buffer          Contains the value of data to execute to the SMBus slave
                           device. Not all operations require this argument. The
+  @param  Buffer          Contains the value of data to execute to the SMBus slave
+                          device. Not all operations require this argument. The
                           length of this buffer is identified by Length.
   @param  Status          Return status for the executed command.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiSmbusLibSmbus2Ppi/PeiSmbusLibSmbus2Ppi.inf

r58459	r58466
47	47
48	48	[Depex.common.PEIM]
49		gEfiPeiSmbus2PpiGuid
	49	gEfiPeiSmbus2PpiGuid
50	50

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeiSmbusLibSmbus2Ppi/SmbusLib.c

-              r48674
+              r58466
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS:  The SMBUS command was executed.
                         RETURN_TIMEOUT:  A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR: The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
+                        RETURN_TIMEOUT:  A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR: The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle
                         (host initiated), or bus errors (collisions).
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.  Device
                         errors are a result of a transaction collision, illegal
                         command field, unclaimed cycle (host initiated), or bus
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.  Device
+                        errors are a result of a transaction collision, illegal
+                        command field, unclaimed cycle (host initiated), or bus
                         errors (collisions).
                         RETURN_UNSUPPORTED::  The SMBus operation is not supported.
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.  Device
                         errors are a result of a transaction collision, illegal
                         command field, unclaimed cycle (host initiated), or bus
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.  Device
+                        errors are a result of a transaction collision, illegal
+                        command field, unclaimed cycle (host initiated), or bus
                         errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct. (PEC is incorrect.)
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
                        or bus errors (collisions).
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
 …
   If Length in SmBusAddress is not zero, then ASSERT().
   If any reserved bits of SmBusAddress are set, then ASSERT().
   @param  SmBusAddress  The address that encodes the SMBUS Slave Address,
                         SMBUS Command, SMBUS Data Length, and PEC.
   @param  Status        Return status for the executed command.
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
+  @param  SmBusAddress  The address that encodes the SMBUS Slave Address,
+                        SMBUS Command, SMBUS Data Length, and PEC.
+  @param  Status        Return status for the executed command.
+                        This is an optional parameter and may be NULL.
+                        RETURN_SUCCESS: The SMBUS command was executed.
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
 …
                         This is an optional parameter and may be NULL.
                         RETURN_SUCCESS: The SMBUS command was executed.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
+                        illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct. (PEC is incorrect.)
 …
   Bytes are written to the SMBUS from Buffer.
   The number of bytes written is returned, and will never return a value larger than 32-bytes.
   If Status is not NULL, then the status of the executed command is returned in Status.
+  If Status is not NULL, then the status of the executed command is returned in Status.
   If Length in SmBusAddress is zero or greater than 32, then ASSERT().
   If Buffer is NULL, then ASSERT().
 …
   @param  Status        Return status for the executed command.
                         This is an optional parameter and may be NULL.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
+                        illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
                         RETURN_CRC_ERROR:  The checksum is not correct (PEC is incorrect)
 …
   @param  Status        Return status for the executed command.
                         This is an optional parameter and may be NULL.
                         RETURN_TIMEOUT: A timeout occurred while executing the
                         SMBUS command.
                         RETURN_DEVICE_ERROR:  The request was not completed because
                         a failure reflected in the Host Status Register bit.
                         Device errors are a result of a transaction collision,
                         illegal command field, unclaimed cycle (host initiated),
+                        RETURN_TIMEOUT: A timeout occurred while executing the
+                        SMBUS command.
+                        RETURN_DEVICE_ERROR:  The request was not completed because
+                        a failure reflected in the Host Status Register bit.
+                        Device errors are a result of a transaction collision,
+                        illegal command field, unclaimed cycle (host initiated),
                         or bus errors (collisions).
                         RETURN_CRC_ERROR  The checksum is not correct. (PEC is incorrect.)

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeimEntryPoint/PeimEntryPoint.c

-              r48674
+              r58466
   The entry point of PE/COFF Image for a PEIM.
   This function is the entry point for a PEIM.  This function must call ProcessLibraryConstructorList()
+  This function is the entry point for a PEIM.  This function must call ProcessLibraryConstructorList()
   and ProcessModuleEntryPointList().  The return value from ProcessModuleEntryPointList() is returned.
   If _gPeimRevision is not zero and PeiServices->Hdr.Revision is less than _gPeimRevison, then ASSERT().
   @param  FileHandle  Handle of the file being invoked.
+  @param  FileHandle  Handle of the file being invoked.
   @param  PeiServices Describes the list of possible PEI Services.
 …
 /**
   Required by the EBC compiler and identical in functionality to _ModuleEntryPoint().
   This function is required to call _ModuleEntryPoint() passing in FileHandle and PeiServices.
   @param  FileHandle  Handle of the file being invoked.
+  @param  FileHandle  Handle of the file being invoked.
   @param  PeiServices Describes the list of possible PEI Services.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf

r58459	r58466
21	21	MODULE_TYPE = PEIM
22	22	VERSION_STRING = 1.0
23		LIBRARY_CLASS = PeimEntryPoint\|PEIM
	23	LIBRARY_CLASS = PeimEntryPoint\|PEIM
24	24
25	25	#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SecPeiDxeTimerLibCpu/SecPeiDxeTimerLibCpu.inf

-              r58459
+              r58466
 # Timer Library that only uses CPU resources to provide calibrated delays
 #  on IA-32, x64, and IPF.
 # Note: A driver of type DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER can use this TimerLib
 #  in their initialization without any issues. They only have to be careful in
 #  the implementation of runtime services and SMI handlers.
+# Note: A driver of type DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER can use this TimerLib
+#  in their initialization without any issues. They only have to be careful in
+#  the implementation of runtime services and SMI handlers.
 #  Because CPU Local APIC and ITC could be programmed by OS, it cannot be
 #  used by SMM drivers and runtime drivers, ACPI timer is recommended for SMM

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c

-              r48674
+              r58466
 /** @file
   I/O Library.
   The implementation of I/O operation for this library instance
+  The implementation of I/O operation for this library instance
   are based on EFI_CPU_IO_PROTOCOL.
   Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   @param  Width         The width of the I/O operation.
   @param  Data          The value to write to the I/O port.
   @return Data read from registers in the EFI system memory space.
 …
   If Port is not aligned on a 16-bit boundary, then ASSERT().
   If 16-bit I/O port operations are not supported, then ASSERT().
 …
   This function must guarantee that all I/O read and write operations are
   serialized.
   If Port is not aligned on a 32-bit boundary, then ASSERT().
 …
   If Port is not aligned on a 64-bit boundary, then ASSERT().
   If 64-bit I/O port operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 16-bit boundary, then ASSERT().
   If 16-bit MMIO register operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 16-bit boundary, then ASSERT().
   If 16-bit MMIO register operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 32-bit boundary, then ASSERT().
   If 32-bit MMIO register operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 32-bit boundary, then ASSERT().
   If 32-bit MMIO register operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 64-bit boundary, then ASSERT().
   If 64-bit MMIO register operations are not supported, then ASSERT().
 …
   If Address is not aligned on a 64-bit boundary, then ASSERT().
   If 64-bit MMIO register operations are not supported, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmIoLibSmmCpuIo2/IoLibMmioBuffer.c

-              r48674
+              r58466
   If Length is not aligned on a 16-bit boundary, then ASSERT().
   If Buffer is not aligned on a 16-bit boundary, then ASSERT().
 …
   If Length is not aligned on a 64-bit boundary, then ASSERT().
   If Buffer is not aligned on a 64-bit boundary, then ASSERT().
 …
   @param  StartAddress    The starting address for the MMIO region to be copied to.
   @param  Length          The size in bytes of the copy.
   @param  Buffer          The pointer to a system memory buffer containing the
+  @param  Buffer          The pointer to a system memory buffer containing the
                           data to write.
 …
   @param  StartAddress    The starting address for the MMIO region to be copied to.
   @param  Length          The size in bytes of the copy.
   @param  Buffer          The pointer to a system memory buffer containing the
+  @param  Buffer          The pointer to a system memory buffer containing the
                           data to write.
 …
   @param  StartAddress    The starting address for the MMIO region to be copied to.
   @param  Length          The size in bytes of the copy.
   @param  Buffer          The pointer to a system memory buffer containing the
+  @param  Buffer          The pointer to a system memory buffer containing the
                           data to write.
 …
   @param  StartAddress    The starting address for the MMIO region to be copied to.
   @param  Length          The size in bytes of the copy.
   @param  Buffer          The pointer to a system memory buffer containing the
+  @param  Buffer          The pointer to a system memory buffer containing the
                           data to write.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmIoLibSmmCpuIo2/SmmCpuIoLibInternal.h

-              r48674
+              r58466
   Internal include file of SMM CPU IO Library.
   It includes all necessary protocol/library class's header file
   for implementation of IoLib library instance. It is included
+  for implementation of IoLib library instance. It is included
   all source code of this library instance.
   Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   @param  Width         The width of the I/O operation.
   @param  Data          The value to write to the I/O port.
   @return Data read from registers in the EFI system memory space.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmLibNull/SmmLibNull.c

-              r48674
+              r58466
   Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
 /**
   Triggers an SMI at boot time.
+  Triggers an SMI at boot time.
   This function triggers a software SMM interrupt at boot time.
 …
 /**
   Triggers an SMI at run time.
+  Triggers an SMI at run time.
   This function triggers a software SMM interrupt at run time.
 …
 /**
   Test if a boot time software SMI happened.
+  Test if a boot time software SMI happened.
   This function tests if a software SMM interrupt happened. If a software SMM
   interrupt happened and it was triggered at boot time, it returns TRUE. Otherwise,
+  This function tests if a software SMM interrupt happened. If a software SMM
+  interrupt happened and it was triggered at boot time, it returns TRUE. Otherwise,
   it returns FALSE.
 …
 /**
   Test if a run time software SMI happened.
+  Test if a run time software SMI happened.
   This function tests if a software SMM interrupt happened. If a software SMM
   interrupt happened and it was triggered at run time, it returns TRUE. Otherwise,
+  This function tests if a software SMM interrupt happened. If a software SMM
+  interrupt happened and it was triggered at run time, it returns TRUE. Otherwise,
   it returns FALSE.
 …
 /**
   Clear APM SMI Status Bit; Set the EOS bit.
+  Clear APM SMI Status Bit; Set the EOS bit.
 **/
 VOID

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmLibNull/SmmLibNull.inf

r58459	r58466
31	31	[Sources]
32	32	SmmLibNull.c
33
	33
34	34
35	35	[Packages]

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmMemLib/SmmMemLib.c

-              r58464
+              r58466
     PhysicalAddressBits = 48;
+  }
   //
   // Save the maximum support address in one global variable
+  //
+  // Save the maximum support address in one global variable
   //
   mSmmMemLibInternalMaximumSupportAddress = (EFI_PHYSICAL_ADDRESS)(UINTN)(LShiftU64 (1, PhysicalAddressBits) - 1);
 …
+{
   UINTN  Index;
   //
   // Check override.
 …
     return FALSE;
+  }
   for (Index = 0; Index < mSmmMemLibInternalSmramCount; Index ++) {
     if (((Buffer >= mSmmMemLibInternalSmramRanges[Index].CpuStart) && (Buffer < mSmmMemLibInternalSmramRanges[Index].CpuStart + mSmmMemLibInternalSmramRanges[Index].PhysicalSize)) ||
 …
   If the check fails, it returns EFI_SECURITY_VIOLATION.
   The implementation must be reentrant.
   @param  DestinationBuffer   The pointer to the destination buffer of the memory copy.
   @param  SourceBuffer        The pointer to the source buffer of the memory copy.
 …
   If the check fails, it returns EFI_SECURITY_VIOLATION.
   The implementation must be reentrant, and it must handle the case where source buffer overlaps destination buffer.
   @param  DestinationBuffer   The pointer to the destination buffer of the memory copy.
   @param  SourceBuffer        The pointer to the source buffer of the memory copy.
 …
   If the check passes, it fills memory and returns EFI_SUCCESS.
   If the check fails, it returns EFI_SECURITY_VIOLATION.
   @param  Buffer    The memory to set.
   @param  Length    The number of bytes to set.
   @param  Value     The value with which to fill Length bytes of Buffer.
   @retval EFI_SECURITY_VIOLATION The Buffer is invalid per processor architecture or overlap with SMRAM.
   @retval EFI_SUCCESS            Memory is set.
 …
   EFI_SMM_ACCESS2_PROTOCOL      *SmmAccess;
   UINTN                         Size;
   //
   // Get SMRAM information

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmMemLib/SmmMemLib.inf

-              r58464
+              r58466
 #  all SMRAM range via SMM_ACCESS2_PROTOCOL, including the range for firmware (like SMM Core
 #  and SMM driver) and/or specific dedicated hardware.
+#
+#
 #  Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
 #  This program and the accompanying materials
 …
 #  which accompanies this distribution.  The full text of the license may be found at
 #  http://opensource.org/licenses/bsd-license.php
+#
+#
 #  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 #  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+#
 ##
 …
 [Sources]
   SmmMemLib.c
 [Packages]
   MdePkg/MdePkg.dec
 [LibraryClasses]
   SmmServicesTableLib

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmMemoryAllocationLib/MemoryAllocationLib.c

-              r58459
+              r58466
 /** @file
   Support routines for memory allocation routines based
+  Support routines for memory allocation routines based
   on SMM Services Table services for SMM phase drivers.
   The PI System Management Mode Core Interface Specification only allows the use
   of EfiRuntimeServicesCode and EfiRuntimeServicesData memory types for memory
   allocations through the SMM Services Table.  The functions in the Memory
+  of EfiRuntimeServicesCode and EfiRuntimeServicesData memory types for memory
+  allocations through the SMM Services Table.  The functions in the Memory
   Allocation Library use EfiBootServicesData as the default memory allocation
   type.  For this SMM specific instance of the Memory Allocation Library,
+  type.  For this SMM specific instance of the Memory Allocation Library,
   EfiRuntimeServicesData is used as the default memory type for all allocations.
   In addition, allocation for the Reserved memory types are not supported and
+  In addition, allocation for the Reserved memory types are not supported and
   will always return NULL.
   Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
 /**
   The constructor function caches SMRAM ranges that are present in the system.
   It will ASSERT() if SMM Access2 Protocol doesn't exist.
   It will ASSERT() if SMRAM ranges can't be got.
   It will ASSERT() if Resource can't be allocated for cache SMRAM range.
+  It will ASSERT() if Resource can't be allocated for cache SMRAM range.
   It will always return EFI_SUCCESS.
 …
   //
   Status = gBS->LocateProtocol (
                   &gEfiSmmAccess2ProtocolGuid,
                   NULL,
+                  &gEfiSmmAccess2ProtocolGuid,
+                  NULL,
                   (VOID **)&SmmAccess
                   );
 …
 /**
   If SMM driver exits with an error, it must call this routine
+  If SMM driver exits with an error, it must call this routine
   to free the allocated resource before the exiting.
 …
   for (Index = 0; Index < mSmramRangeCount; Index ++) {
     if (((EFI_PHYSICAL_ADDRESS) (UINTN) Buffer >= mSmramRanges[Index].CpuStart) &&
+    if (((EFI_PHYSICAL_ADDRESS) (UINTN) Buffer >= mSmramRanges[Index].CpuStart) &&
         ((EFI_PHYSICAL_ADDRESS) (UINTN) Buffer < (mSmramRanges[Index].CpuStart + mSmramRanges[Index].PhysicalSize))) {
       return TRUE;
 …
   Allocates one or more 4KB pages of a certain memory type.
   Allocates the number of 4KB pages of a certain memory type and returns a pointer
   to the allocated buffer.  The buffer returned is aligned on a 4KB boundary.  If
   Pages is 0, then NULL is returned.   If there is not enough memory remaining to
+  Allocates the number of 4KB pages of a certain memory type and returns a pointer
+  to the allocated buffer.  The buffer returned is aligned on a 4KB boundary.  If
+  Pages is 0, then NULL is returned.   If there is not enough memory remaining to
   satisfy the request, then NULL is returned.
 …
 VOID *
 InternalAllocatePages (
   IN EFI_MEMORY_TYPE  MemoryType,
+  IN EFI_MEMORY_TYPE  MemoryType,
   IN UINTN            Pages
+  )
+{
   EFI_STATUS            Status;
   EFI_PHYSICAL_ADDRESS  Memory;
+  EFI_PHYSICAL_ADDRESS  Memory;
   if (Pages == 0) {
 …
   Allocates one or more 4KB pages of type EfiBootServicesData.
   Allocates the number of 4KB pages of type EfiBootServicesData and returns a pointer
   to the allocated buffer.  The buffer returned is aligned on a 4KB boundary.  If
   Pages is 0, then NULL is returned.  If there is not enough memory remaining to
+  Allocates the number of 4KB pages of type EfiBootServicesData and returns a pointer
+  to the allocated buffer.  The buffer returned is aligned on a 4KB boundary.  If
+  Pages is 0, then NULL is returned.  If there is not enough memory remaining to
   satisfy the request, then NULL is returned.
 …
   Allocates one or more 4KB pages of type EfiRuntimeServicesData.
   Allocates the number of 4KB pages of type EfiRuntimeServicesData and returns a
   pointer to the allocated buffer.  The buffer returned is aligned on a 4KB boundary.
   If Pages is 0, then NULL is returned.  If there is not enough memory remaining
+  Allocates the number of 4KB pages of type EfiRuntimeServicesData and returns a
+  pointer to the allocated buffer.  The buffer returned is aligned on a 4KB boundary.
+  If Pages is 0, then NULL is returned.  If there is not enough memory remaining
   to satisfy the request, then NULL is returned.
 …
   Allocates one or more 4KB pages of type EfiReservedMemoryType.
   Allocates the number of 4KB pages of type EfiReservedMemoryType and returns a
   pointer to the allocated buffer.  The buffer returned is aligned on a 4KB boundary.
   If Pages is 0, then NULL is returned.  If there is not enough memory remaining
+  Allocates the number of 4KB pages of type EfiReservedMemoryType and returns a
+  pointer to the allocated buffer.  The buffer returned is aligned on a 4KB boundary.
+  If Pages is 0, then NULL is returned.  If there is not enough memory remaining
   to satisfy the request, then NULL is returned.
 …
   functions in the Memory Allocation Library.
   Frees the number of 4KB pages specified by Pages from the buffer specified by Buffer.
   Buffer must have been allocated on a previous call to the page allocation services
   of the Memory Allocation Library.  If it is not possible to free allocated pages,
+  Frees the number of 4KB pages specified by Pages from the buffer specified by Buffer.
+  Buffer must have been allocated on a previous call to the page allocation services
+  of the Memory Allocation Library.  If it is not possible to free allocated pages,
   then this function will perform no actions.
   If Buffer was not allocated with a page allocation function in the Memory Allocation
+  If Buffer was not allocated with a page allocation function in the Memory Allocation
   Library, then ASSERT().
   If Pages is zero, then ASSERT().
   @param  Buffer                The pointer to the buffer of pages to free.
   @param  Pages                 The number of 4 KB pages to free.
 …
   Allocates one or more 4KB pages of a certain memory type at a specified alignment.
   Allocates the number of 4KB pages specified by Pages of a certain memory type
   with an alignment specified by Alignment.  The allocated buffer is returned.
   If Pages is 0, then NULL is returned. If there is not enough memory at the
+  Allocates the number of 4KB pages specified by Pages of a certain memory type
+  with an alignment specified by Alignment.  The allocated buffer is returned.
+  If Pages is 0, then NULL is returned. If there is not enough memory at the
   specified alignment remaining to satisfy the request, then NULL is returned.
   If Alignment is not a power of two and Alignment is not zero, then ASSERT().
 …
   @param  MemoryType            The type of memory to allocate.
   @param  Pages                 The number of 4 KB pages to allocate.
   @param  Alignment             The requested alignment of the allocation.
+  @param  Alignment             The requested alignment of the allocation.
                                 Must be a power of two.
                                 If Alignment is zero, then byte alignment is used.
 …
 VOID *
 InternalAllocateAlignedPages (
   IN EFI_MEMORY_TYPE  MemoryType,
+  IN EFI_MEMORY_TYPE  MemoryType,
   IN UINTN            Pages,
   IN UINTN            Alignment
 …
   //
   ASSERT ((Alignment & (Alignment - 1)) == 0);
   if (Pages == 0) {
     return NULL;
 …
     //
     ASSERT (RealPages > Pages);
     Status         = gSmst->SmmAllocatePages (AllocateAnyPages, MemoryType, RealPages, &Memory);
     if (EFI_ERROR (Status)) {
 …
   Allocates one or more 4KB pages of type EfiBootServicesData at a specified alignment.
   Allocates the number of 4KB pages specified by Pages of type EfiBootServicesData
   with an alignment specified by Alignment.  The allocated buffer is returned.
   If Pages is 0, then NULL is returned.  If there is not enough memory at the
+  Allocates the number of 4KB pages specified by Pages of type EfiBootServicesData
+  with an alignment specified by Alignment.  The allocated buffer is returned.
+  If Pages is 0, then NULL is returned.  If there is not enough memory at the
   specified alignment remaining to satisfy the request, then NULL is returned.
   If Alignment is not a power of two and Alignment is not zero, then ASSERT().
   If Pages plus EFI_SIZE_TO_PAGES (Alignment) overflows, then ASSERT().
   @param  Pages                 The number of 4 KB pages to allocate.
   @param  Alignment             The requested alignment of the allocation.
+  @param  Alignment             The requested alignment of the allocation.
                                 Must be a power of two.
                                 If Alignment is zero, then byte alignment is used.
 …
   Allocates one or more 4KB pages of type EfiRuntimeServicesData at a specified alignment.
   Allocates the number of 4KB pages specified by Pages of type EfiRuntimeServicesData
   with an alignment specified by Alignment.  The allocated buffer is returned.
   If Pages is 0, then NULL is returned.  If there is not enough memory at the
+  Allocates the number of 4KB pages specified by Pages of type EfiRuntimeServicesData
+  with an alignment specified by Alignment.  The allocated buffer is returned.
+  If Pages is 0, then NULL is returned.  If there is not enough memory at the
   specified alignment remaining to satisfy the request, then NULL is returned.
   If Alignment is not a power of two and Alignment is not zero, then ASSERT().
   If Pages plus EFI_SIZE_TO_PAGES (Alignment) overflows, then ASSERT().
   @param  Pages                 The number of 4 KB pages to allocate.
   @param  Alignment             The requested alignment of the allocation.
+  @param  Alignment             The requested alignment of the allocation.
                                 Must be a power of two.
                                 If Alignment is zero, then byte alignment is used.
 …
   Allocates one or more 4KB pages of type EfiReservedMemoryType at a specified alignment.
   Allocates the number of 4KB pages specified by Pages of type EfiReservedMemoryType
   with an alignment specified by Alignment.  The allocated buffer is returned.
   If Pages is 0, then NULL is returned.  If there is not enough memory at the
+  Allocates the number of 4KB pages specified by Pages of type EfiReservedMemoryType
+  with an alignment specified by Alignment.  The allocated buffer is returned.
+  If Pages is 0, then NULL is returned.  If there is not enough memory at the
   specified alignment remaining to satisfy the request, then NULL is returned.
   If Alignment is not a power of two and Alignment is not zero, then ASSERT().
   If Pages plus EFI_SIZE_TO_PAGES (Alignment) overflows, then ASSERT().
   @param  Pages                 The number of 4 KB pages to allocate.
   @param  Alignment             The requested alignment of the allocation.
+  @param  Alignment             The requested alignment of the allocation.
                                 Must be a power of two.
                                 If Alignment is zero, then byte alignment is used.
 …
   allocation functions in the Memory Allocation Library.
   Frees the number of 4KB pages specified by Pages from the buffer specified by
   Buffer.  Buffer must have been allocated on a previous call to the aligned page
   allocation services of the Memory Allocation Library.  If it is not possible to
+  Frees the number of 4KB pages specified by Pages from the buffer specified by
+  Buffer.  Buffer must have been allocated on a previous call to the aligned page
+  allocation services of the Memory Allocation Library.  If it is not possible to
   free allocated pages, then this function will perform no actions.
   If Buffer was not allocated with an aligned page allocation function in the
+  If Buffer was not allocated with an aligned page allocation function in the
   Memory Allocation Library, then ASSERT().
   If Pages is zero, then ASSERT().
   @param  Buffer                The pointer to the buffer of pages to free.
   @param  Pages                 The number of 4 KB pages to free.
 …
   Allocates a buffer of a certain pool type.
   Allocates the number bytes specified by AllocationSize of a certain pool type
   and returns a pointer to the allocated buffer.  If AllocationSize is 0, then a
   valid buffer of 0 size is returned.  If there is not enough memory remaining to
+  Allocates the number bytes specified by AllocationSize of a certain pool type
+  and returns a pointer to the allocated buffer.  If AllocationSize is 0, then a
+  valid buffer of 0 size is returned.  If there is not enough memory remaining to
   satisfy the request, then NULL is returned.
 …
 VOID *
 InternalAllocatePool (
   IN EFI_MEMORY_TYPE  MemoryType,
+  IN EFI_MEMORY_TYPE  MemoryType,
   IN UINTN            AllocationSize
+  )
 …
   Allocates a buffer of type EfiBootServicesData.
   Allocates the number bytes specified by AllocationSize of type EfiBootServicesData
   and returns a pointer to the allocated buffer.  If AllocationSize is 0, then a
   valid buffer of 0 size is returned.  If there is not enough memory remaining to
+  Allocates the number bytes specified by AllocationSize of type EfiBootServicesData
+  and returns a pointer to the allocated buffer.  If AllocationSize is 0, then a
+  valid buffer of 0 size is returned.  If there is not enough memory remaining to
   satisfy the request, then NULL is returned.
 …
   Allocates a buffer of type EfiRuntimeServicesData.
   Allocates the number bytes specified by AllocationSize of type EfiRuntimeServicesData
   and returns a pointer to the allocated buffer.  If AllocationSize is 0, then a
   valid buffer of 0 size is returned.  If there is not enough memory remaining to
+  Allocates the number bytes specified by AllocationSize of type EfiRuntimeServicesData
+  and returns a pointer to the allocated buffer.  If AllocationSize is 0, then a
+  valid buffer of 0 size is returned.  If there is not enough memory remaining to
   satisfy the request, then NULL is returned.
 …
   Allocates a buffer of type EfiReservedMemoryType.
   Allocates the number bytes specified by AllocationSize of type EfiReservedMemoryType
   and returns a pointer to the allocated buffer.  If AllocationSize is 0, then a
   valid buffer of 0 size is returned.  If there is not enough memory remaining to
+  Allocates the number bytes specified by AllocationSize of type EfiReservedMemoryType
+  and returns a pointer to the allocated buffer.  If AllocationSize is 0, then a
+  valid buffer of 0 size is returned.  If there is not enough memory remaining to
   satisfy the request, then NULL is returned.
 …
   Allocates and zeros a buffer of a certain pool type.
   Allocates the number bytes specified by AllocationSize of a certain pool type,
   clears the buffer with zeros, and returns a pointer to the allocated buffer.
   If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there is
+  Allocates the number bytes specified by AllocationSize of a certain pool type,
+  clears the buffer with zeros, and returns a pointer to the allocated buffer.
+  If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there is
   not enough memory remaining to satisfy the request, then NULL is returned.
 …
 VOID *
 InternalAllocateZeroPool (
   IN EFI_MEMORY_TYPE  PoolType,
+  IN EFI_MEMORY_TYPE  PoolType,
   IN UINTN            AllocationSize
+  )
+  )
+{
   VOID  *Memory;
 …
   Allocates and zeros a buffer of type EfiBootServicesData.
   Allocates the number bytes specified by AllocationSize of type EfiBootServicesData,
   clears the buffer with zeros, and returns a pointer to the allocated buffer.
   If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there is
+  Allocates the number bytes specified by AllocationSize of type EfiBootServicesData,
+  clears the buffer with zeros, and returns a pointer to the allocated buffer.
+  If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there is
   not enough memory remaining to satisfy the request, then NULL is returned.
 …
   Allocates and zeros a buffer of type EfiRuntimeServicesData.
   Allocates the number bytes specified by AllocationSize of type EfiRuntimeServicesData,
   clears the buffer with zeros, and returns a pointer to the allocated buffer.
   If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there is
+  Allocates the number bytes specified by AllocationSize of type EfiRuntimeServicesData,
+  clears the buffer with zeros, and returns a pointer to the allocated buffer.
+  If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there is
   not enough memory remaining to satisfy the request, then NULL is returned.
 …
   Allocates and zeros a buffer of type EfiReservedMemoryType.
   Allocates the number bytes specified by AllocationSize of type EfiReservedMemoryType,
   clears the   buffer with zeros, and returns a pointer to the allocated buffer.
   If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there is
+  Allocates the number bytes specified by AllocationSize of type EfiReservedMemoryType,
+  clears the   buffer with zeros, and returns a pointer to the allocated buffer.
+  If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there is
   not enough memory remaining to satisfy the request, then NULL is returned.
 …
   Copies a buffer to an allocated buffer of a certain pool type.
   Allocates the number bytes specified by AllocationSize of a certain pool type,
   copies AllocationSize bytes from Buffer to the newly allocated buffer, and returns
   a pointer to the allocated buffer.  If AllocationSize is 0, then a valid buffer
   of 0 size is returned.  If there is not enough memory remaining to satisfy the
+  Allocates the number bytes specified by AllocationSize of a certain pool type,
+  copies AllocationSize bytes from Buffer to the newly allocated buffer, and returns
+  a pointer to the allocated buffer.  If AllocationSize is 0, then a valid buffer
+  of 0 size is returned.  If there is not enough memory remaining to satisfy the
   request, then NULL is returned. If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  PoolType              The type of pool to allocate.
 …
 VOID *
 InternalAllocateCopyPool (
   IN EFI_MEMORY_TYPE  PoolType,
+  IN EFI_MEMORY_TYPE  PoolType,
   IN UINTN            AllocationSize,
   IN CONST VOID       *Buffer
+  )
+  )
+{
   VOID  *Memory;
 …
+  }
   return Memory;
+}
+}
 /**
   Copies a buffer to an allocated buffer of type EfiBootServicesData.
   Allocates the number bytes specified by AllocationSize of type EfiBootServicesData,
   copies AllocationSize bytes from Buffer to the newly allocated buffer, and returns
   a pointer to the allocated buffer.  If AllocationSize is 0, then a valid buffer
   of 0 size is returned.  If there is not enough memory remaining to satisfy the
+  Allocates the number bytes specified by AllocationSize of type EfiBootServicesData,
+  copies AllocationSize bytes from Buffer to the newly allocated buffer, and returns
+  a pointer to the allocated buffer.  If AllocationSize is 0, then a valid buffer
+  of 0 size is returned.  If there is not enough memory remaining to satisfy the
   request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  AllocationSize        The number of bytes to allocate and zero.
 …
   Copies a buffer to an allocated buffer of type EfiRuntimeServicesData.
   Allocates the number bytes specified by AllocationSize of type EfiRuntimeServicesData,
   copies AllocationSize bytes from Buffer to the newly allocated buffer, and returns
   a pointer to the allocated buffer.  If AllocationSize is 0, then a valid buffer
   of 0 size is returned.  If there is not enough memory remaining to satisfy the
+  Allocates the number bytes specified by AllocationSize of type EfiRuntimeServicesData,
+  copies AllocationSize bytes from Buffer to the newly allocated buffer, and returns
+  a pointer to the allocated buffer.  If AllocationSize is 0, then a valid buffer
+  of 0 size is returned.  If there is not enough memory remaining to satisfy the
   request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  AllocationSize        The number of bytes to allocate and zero.
 …
   Copies a buffer to an allocated buffer of type EfiReservedMemoryType.
   Allocates the number bytes specified by AllocationSize of type EfiReservedMemoryType,
   copies AllocationSize bytes from Buffer to the newly allocated buffer, and returns
   a pointer to the allocated buffer.  If AllocationSize is 0, then a valid buffer
   of 0 size is returned.  If there is not enough memory remaining to satisfy the
+  Allocates the number bytes specified by AllocationSize of type EfiReservedMemoryType,
+  copies AllocationSize bytes from Buffer to the newly allocated buffer, and returns
+  a pointer to the allocated buffer.  If AllocationSize is 0, then a valid buffer
+  of 0 size is returned.  If there is not enough memory remaining to satisfy the
   request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  AllocationSize        The number of bytes to allocate and zero.
 …
   Allocates and zeros the number bytes specified by NewSize from memory of the type
   specified by PoolType.  If OldBuffer is not NULL, then the smaller of OldSize and
   NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  specified by PoolType.  If OldBuffer is not NULL, then the smaller of OldSize and
+  NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
   If the allocation of the new buffer is successful and the smaller of NewSize
+  If the allocation of the new buffer is successful and the smaller of NewSize
   and OldSize is greater than (MAX_ADDRESS - OldBuffer + 1), then ASSERT().
 …
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
                          optional parameter that may be NULL.
 …
 VOID *
 InternalReallocatePool (
   IN EFI_MEMORY_TYPE  PoolType,
+  IN EFI_MEMORY_TYPE  PoolType,
   IN UINTN            OldSize,
   IN UINTN            NewSize,
 …
   Allocates and zeros the number bytes specified by NewSize from memory of type
   EfiBootServicesData.  If OldBuffer is not NULL, then the smaller of OldSize and
   NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  EfiBootServicesData.  If OldBuffer is not NULL, then the smaller of OldSize and
+  NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
   If the allocation of the new buffer is successful and the smaller of NewSize
+  If the allocation of the new buffer is successful and the smaller of NewSize
   and OldSize is greater than (MAX_ADDRESS - OldBuffer + 1), then ASSERT().
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
                          optional parameter that may be NULL.
 …
   Allocates and zeros the number bytes specified by NewSize from memory of type
   EfiRuntimeServicesData.  If OldBuffer is not NULL, then the smaller of OldSize
   and NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  EfiRuntimeServicesData.  If OldBuffer is not NULL, then the smaller of OldSize
+  and NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
   If the allocation of the new buffer is successful and the smaller of NewSize
+  If the allocation of the new buffer is successful and the smaller of NewSize
   and OldSize is greater than (MAX_ADDRESS - OldBuffer + 1), then ASSERT().
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
                          optional parameter that may be NULL.
 …
   Allocates and zeros the number bytes specified by NewSize from memory of type
   EfiReservedMemoryType.  If OldBuffer is not NULL, then the smaller of OldSize
   and NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  EfiReservedMemoryType.  If OldBuffer is not NULL, then the smaller of OldSize
+  and NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
   If the allocation of the new buffer is successful and the smaller of NewSize
+  If the allocation of the new buffer is successful and the smaller of NewSize
   and OldSize is greater than (MAX_ADDRESS - OldBuffer + 1), then ASSERT().
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an
                          optional parameter that may be NULL.
 …
 /**
   Frees a buffer that was previously allocated with one of the pool allocation
+  Frees a buffer that was previously allocated with one of the pool allocation
   functions in the Memory Allocation Library.
   Frees the buffer specified by Buffer.  Buffer must have been allocated on a
   previous call to the pool allocation services of the Memory Allocation Library.
   If it is not possible to free pool resources, then this function will perform
+  Frees the buffer specified by Buffer.  Buffer must have been allocated on a
+  previous call to the pool allocation services of the Memory Allocation Library.
+  If it is not possible to free pool resources, then this function will perform
   no actions.
   If Buffer was not allocated with a pool allocation function in the Memory
+  If Buffer was not allocated with a pool allocation function in the Memory
   Allocation Library, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf

-              r58459
+              r58466
 # Instance of Memory Allocation Library using SMM Services Table.
+#
 # Memory Allocation Library that uses services from the SMM Services Table to
+# Memory Allocation Library that uses services from the SMM Services Table to
 # allocate and free memory.
+#
 …
   VERSION_STRING                 = 1.0
   PI_SPECIFICATION_VERSION       = 0x0001000A
   LIBRARY_CLASS                  = MemoryAllocationLib|DXE_SMM_DRIVER
+  LIBRARY_CLASS                  = MemoryAllocationLib|DXE_SMM_DRIVER
   CONSTRUCTOR                    = SmmMemoryAllocationLibConstructor
   DESTRUCTOR                     = SmmMemoryAllocationLibDestructor
 …
 [Protocols]
   gEfiSmmAccess2ProtocolGuid    ## CONSUMES
+  gEfiSmmAccess2ProtocolGuid    ## CONSUMES
 [Depex]

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmPciLibPciRootBridgeIo/PciLib.c

-              r58459
+              r58466
   text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 …
 // Global varible to cache pointer to PCI Root Bridge I/O protocol.
 //
 EFI_SMM_PCI_ROOT_BRIDGE_IO_PROTOCOL      *mSmmPciRootBridgeIo = NULL;
+EFI_SMM_PCI_ROOT_BRIDGE_IO_PROTOCOL      *mSmmPciRootBridgeIo = NULL;
 /**
   The constructor function caches the pointer to PCI Root Bridge I/O protocol.
   The constructor function locates PCI Root Bridge I/O protocol from protocol database.
   It will ASSERT() if that operation fails and it will always return EFI_SUCCESS.
+  It will ASSERT() if that operation fails and it will always return EFI_SUCCESS.
   @param  ImageHandle   The firmware allocated handle for the EFI image.
   @param  SystemTable   A pointer to the EFI System Table.
   @retval EFI_SUCCESS   The constructor always returns EFI_SUCCESS.
 …
+{
   EFI_STATUS  Status;
   Status = gSmst->SmmLocateProtocol (&gEfiSmmPciRootBridgeIoProtocolGuid, NULL, (VOID**) &mSmmPciRootBridgeIo);
   ASSERT_EFI_ERROR (Status);
 …
 /**
   Registers a PCI device so PCI configuration registers may be accessed after
+  Registers a PCI device so PCI configuration registers may be accessed after
   SetVirtualAddressMap().
   Registers the PCI device specified by Address so all the PCI configuration registers
+  Registers the PCI device specified by Address so all the PCI configuration registers
   associated with that PCI device may be accessed after SetVirtualAddressMap() is called.
   If Address > 0x0FFFFFFF, then ASSERT().
   @param  Address The address that encodes the PCI Bus, Device, Function and
                   Register.
+  If Address > 0x0FFFFFFF, then ASSERT().
+  @param  Address The address that encodes the PCI Bus, Device, Function and
+                  Register.
   @retval RETURN_SUCCESS           The PCI device was registered for runtime access.
   @retval RETURN_UNSUPPORTED       An attempt was made to call this function
+  @retval RETURN_UNSUPPORTED       An attempt was made to call this function
                                    after ExitBootServices().
   @retval RETURN_UNSUPPORTED       The resources required to access the PCI device

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmPciLibPciRootBridgeIo/SmmPciLibPciRootBridgeIo.inf

r58459	r58466
50	50	[Protocols]
51	51	gEfiSmmPciRootBridgeIoProtocolGuid ## CONSUMES
52
	52
53	53	[Depex.common.DXE_SMM_DRIVER]
54	54	gEfiSmmPciRootBridgeIoProtocolGuid

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.c

-              r48674
+              r58466
   UINT64                                   TickPeriod;
   ///
   /// The Cpu number that is required to execute DispatchFunction.  If Cpu is
   /// set to PERIODIC_SMI_LIBRARY_ANY_CPU, then DispatchFunction may be executed
+  /// The Cpu number that is required to execute DispatchFunction.  If Cpu is
+  /// set to PERIODIC_SMI_LIBRARY_ANY_CPU, then DispatchFunction may be executed
   /// on any CPU.
   ///
   UINTN                                    Cpu;
   ///
   /// The size, in bytes, of the stack allocated for a periodic SMI handler.
+  /// The size, in bytes, of the stack allocated for a periodic SMI handler.
   /// This value must be a multiple of EFI_PAGE_SIZE.
   ///
 …
   SPIN_LOCK                                DispatchLock;
   ///
   /// The rate in Hz of the performance counter that is used to measure the
+  /// The rate in Hz of the performance counter that is used to measure the
   /// amount of time that a periodic SMI handler executes.
   ///
   UINT64                                   PerfomanceCounterRate;
   ///
   /// The start count value of the performance counter that is used to measure
+  /// The start count value of the performance counter that is used to measure
   /// the amount of time that a periodic SMI handler executes.
   ///
   UINT64                                   PerfomanceCounterStartValue;
   ///
   /// The end count value of the performance counter that is used to measure
+  /// The end count value of the performance counter that is used to measure
   /// the amount of time that a periodic SMI handler executes.
   ///
   UINT64                                   PerfomanceCounterEndValue;
   ///
   /// The context record passed into the Register() function of the SMM Periodic
+  /// The context record passed into the Register() function of the SMM Periodic
   /// Timer Dispatch Protocol when a periodic SMI handler is enabled.
   ///
   EFI_SMM_PERIODIC_TIMER_REGISTER_CONTEXT  RegisterContext;
   ///
   /// The handle returned from the Register() function of the SMM Periodic
+  /// The handle returned from the Register() function of the SMM Periodic
   /// Timer Dispatch Protocol when a periodic SMI handler is enabled.
   ///
 …
   UINT64                                   DispatchTotalTime;
   ///
   /// The performance counter value that was captured the last time that the
+  /// The performance counter value that was captured the last time that the
   /// periodic SMI handler called PeriodcSmiExecutionTime().  This allows the
   /// time value returned by PeriodcSmiExecutionTime() to be accurate even when
 …
   ///
   /// Buffer used to save the context when control is transfer from this library
   /// to an enabled periodic SMI handler.  This saved context is used when the
   /// periodic SMI handler exits or yields.
+  /// to an enabled periodic SMI handler.  This saved context is used when the
+  /// periodic SMI handler exits or yields.
   ///
   BASE_LIBRARY_JUMP_BUFFER                 DispatchJumpBuffer;
   ///
   /// Flag that is set to TRUE when a periodic SMI handler requests to yield
   /// using PeriodicSmiYield().  When this flag IS TRUE, YieldJumpBuffer is
+  /// Flag that is set to TRUE when a periodic SMI handler requests to yield
+  /// using PeriodicSmiYield().  When this flag IS TRUE, YieldJumpBuffer is
   /// valid.  When this flag is FALSE, YieldJumpBuffer is not valid.
   ///
   BOOLEAN                                  YieldFlag;
   ///
   /// Buffer used to save the context when a periodic SMI handler requests to
   /// yield using PeriodicSmiYield().  This context is used to resume the
+  /// Buffer used to save the context when a periodic SMI handler requests to
+  /// yield using PeriodicSmiYield().  This context is used to resume the
   /// execution of a periodic SMI handler the next time control is transferd
   /// to the periodic SMI handler that yielded.
 …
 /**
  Macro that returns a pointer to a PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT
+ Macro that returns a pointer to a PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT
  structure based on a pointer to a RegisterContext field.
 …
 /**
  Macro that returns a pointer to a PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT
+ Macro that returns a pointer to a PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT
  structure based on a pointer to a Link field.
 …
 ///
 /// Pointer to a table of supported periodic SMI tick periods in 100 ns units
+/// Pointer to a table of supported periodic SMI tick periods in 100 ns units
 /// sorted from largest to smallest terminated by a tick period value of 0.
 /// This table is allocated using AllocatePool() in the constructor and filled
 /// in based on the values returned from the SMM Periodic Timer Dispatch 2 Protocol
+/// This table is allocated using AllocatePool() in the constructor and filled
+/// in based on the values returned from the SMM Periodic Timer Dispatch 2 Protocol
 /// function GetNextShorterInterval().
 ///
 …
 /**
   Internal worker function that returns a pointer to the
   PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT structure associated with the periodic
   SMI handler that is currently being executed.  If a periodic SMI handler is
+  Internal worker function that returns a pointer to the
+  PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT structure associated with the periodic
+  SMI handler that is currently being executed.  If a periodic SMI handler is
   not currently being executed, the NULL is returned.
   @retval  NULL   A periodic SMI handler is not currently being executed.
   @retval  other  Pointer to the PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT
                   associated with the active periodic SMI handler.
 **/
 PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT *
 …
 /**
   Internal worker function that returns a pointer to the
   PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT structure associated with the
+  Internal worker function that returns a pointer to the
+  PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT structure associated with the
   DispatchHandle that was returned when the periodic SMI handler was enabled
   with PeriodicSmiEnable().  If DispatchHandle is NULL, then the active
+  with PeriodicSmiEnable().  If DispatchHandle is NULL, then the active
   periodic SMI handler is returned.  If DispatchHandle is NULL and there is
   no active periodic SMI handler, then NULL is returned.
   @param[in] DispatchHandle  DispatchHandle that was returned when the periodic
                              SMI handler was enabled with PeriodicSmiEnable().
+  @param[in] DispatchHandle  DispatchHandle that was returned when the periodic
+                             SMI handler was enabled with PeriodicSmiEnable().
                              This is an optional parameter that may be NULL.
                              If this parameter is NULL, then the active periodic
                              SMI handler is returned.
   @retval  NULL   DispatchHandle is NULL and there is no active periodic SMI
+  @retval  NULL   DispatchHandle is NULL and there is no active periodic SMI
                   handler.
   @retval  NULL   DispatchHandle does not match any of the periodic SMI handlers
 …
   @retval  other  Pointer to the PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT
                   associated with the DispatchHandle.
 **/
 PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT *
 …
+    }
+  }
   //
   // No entries match DispatchHandle, so return NULL
 …
 /**
   Internal worker function that sets that active periodic SMI handler based on
   the Context used when the periodic SMI handler was registered with the
   SMM Periodic Timer Dispatch 2 Protocol.  If Context is NULL, then the
+  Internal worker function that sets that active periodic SMI handler based on
+  the Context used when the periodic SMI handler was registered with the
+  SMM Periodic Timer Dispatch 2 Protocol.  If Context is NULL, then the
   state is updated to show that there is not active periodic SMI handler.
   A pointer to the active PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT structure
+  A pointer to the active PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT structure
   is returned.
   @retval  NULL   Context is NULL.
   @retval  other  Pointer to the PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT
                   associated with Context.
 **/
 PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT *
 …
   SMI handler.  If no free entries are available, then additional
   entries are allocated.
   @retval  NULL   There are not enough resources available to to allocate a free entry.
   @retval  other  Pointer to a free PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT structure.
 **/
 PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT *
 …
+{
   PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT  *PeriodicSmiLibraryHandler;
   if (IsListEmpty (&gFreePeriodicSmiLibraryHandlers)) {
     if (!EnlargeFreePeriodicSmiLibraryHandlerList ()) {
 …
 /**
   This function returns a pointer to a table of supported periodic
   SMI tick periods in 100 ns units sorted from largest to smallest.
   The table contains a array of UINT64 values terminated by a tick
+  SMI tick periods in 100 ns units sorted from largest to smallest.
+  The table contains a array of UINT64 values terminated by a tick
   period value of 0.  The returned table must be treated as read-only
   data and must not be freed.
   @return  A pointer to a table of UINT64 tick period values in
 ns units sorted from largest to smallest terminated
+  @return  A pointer to a table of UINT64 tick period values in
+ns units sorted from largest to smallest terminated
            by a tick period of 0.
 **/
 UINT64 *
 …
   //
   // If there is no active periodic SMI handler, then return 0
+  // If there is no active periodic SMI handler, then return 0
   //
   PeriodicSmiLibraryHandler = GetActivePeriodicSmiLibraryHandler ();
 …
     return 0;
+  }
   //
   // Get the current performance counter value
   //
   Current = GetPerformanceCounter ();
   //
   // Count the number of performance counter ticks since the periodic SMI handler
   // was dispatched or the last time this function was called.
+  //
+  // Count the number of performance counter ticks since the periodic SMI handler
+  // was dispatched or the last time this function was called.
   //
   if (PeriodicSmiLibraryHandler->PerfomanceCounterEndValue > PeriodicSmiLibraryHandler->PerfomanceCounterStartValue) {
 …
+    }
+  }
   //
   // Accumulate the total number of performance counter ticks since the periodic
+  //
+  // Accumulate the total number of performance counter ticks since the periodic
   // SMI handler was dispatched or resumed.
   //
   PeriodicSmiLibraryHandler->DispatchTotalTime += Count;
   //
   // Update the checkpoint value to the current performance counter value
   //
   PeriodicSmiLibraryHandler->DispatchCheckPointTime = Current;
   //
   // Convert the total number of performance counter ticks to 100 ns units
   //
   return DivU64x64Remainder (
            MultU64x32 (PeriodicSmiLibraryHandler->DispatchTotalTime, 10000000),
            PeriodicSmiLibraryHandler->PerfomanceCounterRate,
+           MultU64x32 (PeriodicSmiLibraryHandler->DispatchTotalTime, 10000000),
+           PeriodicSmiLibraryHandler->PerfomanceCounterRate,
            NULL
            );
 …
 /**
   This function returns control back to the SMM Foundation.  When the next
+  This function returns control back to the SMM Foundation.  When the next
   periodic SMI for the currently executing handler is triggered, the periodic
   SMI handler will restarted from its registered DispatchFunction entry point.
   If this function is not called from within an enabled periodic SMI handler,
+  If this function is not called from within an enabled periodic SMI handler,
   then control is returned to the calling function.
 **/
 VOID
 EFIAPI
+EFIAPI
 PeriodicSmiExit (
   VOID
 …
+{
   PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT  *PeriodicSmiLibraryHandler;
   //
   // If there is no active periodic SMI handler, then return
+  //
+  // If there is no active periodic SMI handler, then return
   //
   PeriodicSmiLibraryHandler = GetActivePeriodicSmiLibraryHandler ();
 …
     return;
+  }
   //
   // Perform a long jump back to the point when the currently executing dispatch
+  //
+  // Perform a long jump back to the point when the currently executing dispatch
   // function was dispatched.
   //
   LongJump (&PeriodicSmiLibraryHandler->DispatchJumpBuffer, 1);
   //
   // Must never return
 …
 /**
   This function yields control back to the SMM Foundation.  When the next
+  This function yields control back to the SMM Foundation.  When the next
   periodic SMI for the currently executing handler is triggered, the periodic
   SMI handler will be resumed and this function will return.  Use of this
+  SMI handler will be resumed and this function will return.  Use of this
   function requires a seperate stack for the periodic SMI handler.  A non zero
   stack size must be specified in PeriodicSmiEnable() for this function to be
   used.
+  stack size must be specified in PeriodicSmiEnable() for this function to be
+  used.
   If the stack size passed into PeriodicSmiEnable() was zero, the 0 is returned.
   If this function is not called from within an enabled periodic SMI handler,
+  If this function is not called from within an enabled periodic SMI handler,
   then 0 is returned.
 …
 **/
 UINT64
 EFIAPI
+EFIAPI
 PeriodicSmiYield (
   VOID
 …
   //
   // If there is no active periodic SMI handler, then return
+  // If there is no active periodic SMI handler, then return
   //
   PeriodicSmiLibraryHandler = GetActivePeriodicSmiLibraryHandler ();
 …
     return 0;
+  }
   //
   // If PeriodicSmiYield() is called without an allocated stack, then just return
+  //
+  // If PeriodicSmiYield() is called without an allocated stack, then just return
   // immediately with an elapsed time of 0.
   //
 …
     return 0;
+  }
   //
   // Set a flag so the next periodic SMI event will resume at where SetJump()
+  //
+  // Set a flag so the next periodic SMI event will resume at where SetJump()
   // is called below.
   //
 …
   //
   // Save context in YieldJumpBuffer
   //
+  //
   SetJumpFlag = SetJump (&PeriodicSmiLibraryHandler->YieldJumpBuffer);
   if (SetJumpFlag == 0) {
 …
     PeriodicSmiExit ();
+  }
   //
   // We get here when a LongJump is performed from PeriodicSmiDispatchFunctionOnCpu()
   // to resume a periodic SMI handler that called PeriodicSmiYield() on the
+  // to resume a periodic SMI handler that called PeriodicSmiYield() on the
   // previous time this periodic SMI handler was dispatched.
   //
 …
   //
   // Return the amount elapsed time that occured while yielded
   //
+  //
   return PeriodicSmiLibraryHandler->ElapsedTime;
+}
 /**
   Internal worker function that transfers control to an enabled periodic SMI
   handler.  If the enabled periodic SMI handler was allocated its own stack,
   then this function is called on that allocated stack through the BaseLin
+  Internal worker function that transfers control to an enabled periodic SMI
+  handler.  If the enabled periodic SMI handler was allocated its own stack,
+  then this function is called on that allocated stack through the BaseLin
   function SwitchStack().
 …
   //
   // Convert Context1 to PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT *
   //
+  // Convert Context1 to PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT *
+  //
   PeriodicSmiLibraryHandler = (PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT *)Context1;
   //
   // Dispatch the registered handler passing in the context that was registered
   // and the amount of time that has elapsed since the previous time this
+  // and the amount of time that has elapsed since the previous time this
   // periodic SMI handler was dispacthed.
   //
+  //
   PeriodicSmiLibraryHandler->DispatchFunction (
     PeriodicSmiLibraryHandler->Context,
     PeriodicSmiLibraryHandler->ElapsedTime
     );
   //
   // If this DispatchFunction() returns, then unconditially call PeriodicSmiExit()
   // to perform a LongJump() back to PeriodicSmiDispatchFunctionOnCpu(). The
+  // to perform a LongJump() back to PeriodicSmiDispatchFunctionOnCpu(). The
   // LongJump() will resume exection on the original stack.
   //
+  //
   PeriodicSmiExit ();
+}
 /**
   Internal worker function that transfers control to an enabled periodic SMI
   handler on the specified logial CPU.  This function determines if the periodic
   SMI handler yielded and needs to be resumed.  It also and switches to an
+  Internal worker function that transfers control to an enabled periodic SMI
+  handler on the specified logial CPU.  This function determines if the periodic
+  SMI handler yielded and needs to be resumed.  It also and switches to an
   allocated stack if one was allocated in PeriodicSmiEnable().
   @param[in] PeriodicSmiLibraryHandler  A pointer to the context for the periodic
                                         SMI handler to execute.
 **/
 VOID
 …
+{
   //
   // Save context in DispatchJumpBuffer.  The intial call to SetJump() always
   // returns 0.  If this is the initial call, then either resume from a prior
   // call to PeriodicSmiYield() or call the DispatchFunction registerd in
+  // Save context in DispatchJumpBuffer.  The intial call to SetJump() always
+  // returns 0.  If this is the initial call, then either resume from a prior
+  // call to PeriodicSmiYield() or call the DispatchFunction registerd in
   // PeriodicSmiEnable() using an allocated stack if one was specified.
   //
+  //
   if (SetJump (&PeriodicSmiLibraryHandler->DispatchJumpBuffer) != 0) {
     return;
+  }
   //
   // Capture the performance counter value just before the periodic SMI handler
   // is resumed so the amount of time the periodic SMI handler executes can be
+  //
+  // Capture the performance counter value just before the periodic SMI handler
+  // is resumed so the amount of time the periodic SMI handler executes can be
   // calculated.
   //
   PeriodicSmiLibraryHandler->DispatchTotalTime      = 0;
   PeriodicSmiLibraryHandler->DispatchCheckPointTime = GetPerformanceCounter();
   if (PeriodicSmiLibraryHandler->YieldFlag) {
     //
     // Perform a long jump back to the point where the previously dispatched
     // function called PeriodicSmiYield().
+    // Perform a long jump back to the point where the previously dispatched
+    // function called PeriodicSmiYield().
     //
     LongJump (&PeriodicSmiLibraryHandler->YieldJumpBuffer, 1);
   } else if (PeriodicSmiLibraryHandler->Stack == NULL) {
     //
     // If Stack is NULL then call DispatchFunction using current stack passing
     // in the context that was registered and the amount of time that has
+    // If Stack is NULL then call DispatchFunction using current stack passing
+    // in the context that was registered and the amount of time that has
     // elapsed since the previous time this periodic SMI handler was dispacthed.
     //
+    //
     PeriodicSmiLibraryHandler->DispatchFunction (
       PeriodicSmiLibraryHandler->Context,
       PeriodicSmiLibraryHandler->ElapsedTime
       );
     //
     // If this DispatchFunction() returns, then unconditially call PeriodicSmiExit()
     // to perform a LongJump() back to this function.
     //
+    //
     PeriodicSmiExit ();
   } else {
 …
       (UINT8 *)PeriodicSmiLibraryHandler->Stack + PeriodicSmiLibraryHandler->StackSize
       );
+  }
+  }
   //
 …
 /**
   Internal worker function that transfers control to an enabled periodic SMI
   handler on the specified logial CPU.  This worker function is only called
   using the SMM Services Table function SmmStartupThisAp() to execute the
   periodic SMI handler on a logical CPU that is different than the one that is
+  Internal worker function that transfers control to an enabled periodic SMI
+  handler on the specified logial CPU.  This worker function is only called
+  using the SMM Services Table function SmmStartupThisAp() to execute the
+  periodic SMI handler on a logical CPU that is different than the one that is
   running the SMM Foundation.  When the periodic SMI handler returns, a lock is
   released to notify the CPU that is running the SMM Foundation that the periodic
 …
+{
   PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT  *PeriodicSmiLibraryHandler;
   //
   // Get context
   //
+  //
   PeriodicSmiLibraryHandler = (PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT  *)Buffer;
   //
   // Execute dispatch function on the currently excuting logical CPU
   //
+  //
   PeriodicSmiDispatchFunctionOnCpu (PeriodicSmiLibraryHandler);
   //
   // Release the dispatch spin lock
 …
   was enabled using PeriodicSmiEnable().
   @param[in]     DispatchHandle  The unique handle assigned to this handler by
+  @param[in]     DispatchHandle  The unique handle assigned to this handler by
                                  SmiHandlerRegister().
   @param[in]     Context         Points to an optional handler context which was
+  @param[in]     Context         Points to an optional handler context which was
                                  specified when the handler was registered.
   @param[in, out] CommBuffer     A pointer to a collection of data in memory that
                                  will be conveyed from a non-SMM environment into
+                                 will be conveyed from a non-SMM environment into
                                  an SMM environment.
   @param[in, out] CommBufferSize The size of the CommBuffer.
 …
                                               handlers should still be called.
   @retval EFI_INTERRUPT_PENDING               The interrupt could not be quiesced.
 **/
 EFI_STATUS
 …
   EFI_SMM_PERIODIC_TIMER_CONTEXT        *TimerContext;
   EFI_STATUS                            Status;
   //
   // Set the active periodic SMI handler
   //
+  //
   PeriodicSmiLibraryHandler = SetActivePeriodicSmiLibraryHandler (Context);
   if (PeriodicSmiLibraryHandler == NULL) {
     return EFI_NOT_FOUND;
+  }
   //
   // Retrieve the elapsed time since the last time this periodic SMI handler was called
 …
     //
     AcquireSpinLock (&PeriodicSmiLibraryHandler->DispatchLock);
     //
     // Execute the periodic SMI handler on the CPU that was specified in
+    //
+    // Execute the periodic SMI handler on the CPU that was specified in
     // PeriodicSmiEnable().
     //
 …
+      }
+    }
     //
     // Release the spin lock for the periodic SMI handler.
 …
     ReclaimPeriodicSmiLibraryHandler (PeriodicSmiLibraryHandler);
+  }
   //
   // Update state to show that there is no active periodic SMI handler
   //
+  //
   SetActivePeriodicSmiLibraryHandler (NULL);
   return EFI_SUCCESS;
+}
 /**
   This function enables a periodic SMI handler.
   @param[in, out] DispatchHandle   A pointer to the handle associated with the
                                    enabled periodic SMI handler.  This is an
                                    optional parameter that may be NULL.  If it is
                                    NULL, then the handle will not be returned,
                                    which means that the periodic SMI handler can
+  @param[in, out] DispatchHandle   A pointer to the handle associated with the
+                                   enabled periodic SMI handler.  This is an
+                                   optional parameter that may be NULL.  If it is
+                                   NULL, then the handle will not be returned,
+                                   which means that the periodic SMI handler can
                                    never be disabled.
   @param[in]     DispatchFunction  A pointer to a periodic SMI handler function.
   @param[in]     Context           Optional content to pass into DispatchFunction.
   @param[in]     TickPeriod        The requested tick period in 100ns units that
+  @param[in]     TickPeriod        The requested tick period in 100ns units that
                                    control should be givien to the periodic SMI
                                    handler.  Must be one of the supported values
                                    returned by PeriodicSmiSupportedPickPeriod().
   @param[in]     Cpu               Specifies the CPU that is required to execute
                                    the periodic SMI handler.  If Cpu is
                                    PERIODIC_SMI_LIBRARY_ANY_CPU, then the periodic
                                    SMI handler will always be executed on the SMST
                                    CurrentlyExecutingCpu, which may vary across
                                    periodic SMIs.  If Cpu is between 0 and the SMST
+                                   the periodic SMI handler.  If Cpu is
+                                   PERIODIC_SMI_LIBRARY_ANY_CPU, then the periodic
+                                   SMI handler will always be executed on the SMST
+                                   CurrentlyExecutingCpu, which may vary across
+                                   periodic SMIs.  If Cpu is between 0 and the SMST
                                    NumberOfCpus, then the periodic SMI will always
                                    be executed on the requested CPU.
 …
                                    use by the periodic SMI handler.  If 0, then the
                                    default stack will be used.
   @retval EFI_INVALID_PARAMETER  DispatchFunction is NULL.
   @retval EFI_UNSUPPORTED        TickPeriod is not a supported tick period.  The
                                  supported tick periods can be retrieved using
+  @retval EFI_UNSUPPORTED        TickPeriod is not a supported tick period.  The
+                                 supported tick periods can be retrieved using
                                  PeriodicSmiSupportedTickPeriod().
   @retval EFI_INVALID_PARAMETER  Cpu is not PERIODIC_SMI_LIBRARY_ANY_CPU or in
+  @retval EFI_INVALID_PARAMETER  Cpu is not PERIODIC_SMI_LIBRARY_ANY_CPU or in
                                  the range 0 to SMST NumberOfCpus.
   @retval EFI_OUT_OF_RESOURCES   There are not enough resources to enable the
+  @retval EFI_OUT_OF_RESOURCES   There are not enough resources to enable the
                                  periodic SMI handler.
   @retval EFI_OUT_OF_RESOURCES   There are not enough resources to allocate the
+  @retval EFI_OUT_OF_RESOURCES   There are not enough resources to allocate the
                                  stack speficied by StackSize.
   @retval EFI_SUCCESS            The periodic SMI handler was enabled.
 **/
 EFI_STATUS
+**/
+EFI_STATUS
 EFIAPI
 PeriodicSmiEnable (
 …
   //
   // Make sure all the input parameters are valid
   //
+  //
   if (DispatchFunction == NULL) {
     return EFI_INVALID_PARAMETER;
+  }
   for (Index = 0; gSmiTickPeriodTable[Index] != 0; Index++) {
     if (gSmiTickPeriodTable[Index] == TickPeriod) {
       break;
+    }
+  }
+  }
   if (gSmiTickPeriodTable[Index] == 0) {
     return EFI_UNSUPPORTED;
+  }
   if (Cpu != PERIODIC_SMI_LIBRARY_ANY_CPU && Cpu >= gSmst->NumberOfCpus) {
     return EFI_INVALID_PARAMETER;
 …
   //
   // Find a free periodic SMI handler entry
   //
+  //
   PeriodicSmiLibraryHandler = FindFreePeriodicSmiLibraryHandler();
   if (PeriodicSmiLibraryHandler == NULL) {
 …
     return EFI_OUT_OF_RESOURCES;
+  }
   //
   // Return the registered handle if the optional DispatchHandle parameter is not NULL
 …
     *DispatchHandle = PeriodicSmiLibraryHandler->DispatchHandle;
+  }
   return EFI_SUCCESS;
+  return EFI_SUCCESS;
+}
 …
   This function disables a periodic SMI handler that has been previously
   enabled with PeriodicSmiEnable().
   @param[in] DispatchHandle  A handle associated with a previously enabled periodic
+  @param[in] DispatchHandle  A handle associated with a previously enabled periodic
                              SMI handler.  This is an optional parameter that may
                              be NULL.  If it is NULL, then the active periodic SMI
 …
   @retval FALSE  DispatchHandle is NULL and there is no active periodic SMI handler.
   @retval FALSE  The periodic SMI handler specified by DispatchHandle has
+  @retval FALSE  The periodic SMI handler specified by DispatchHandle has
                  not been enabled with PeriodicSmiEnable().
   @retval TRUE   The periodic SMI handler specified by DispatchHandle has
+  @retval TRUE   The periodic SMI handler specified by DispatchHandle has
                  been disabled.  If DispatchHandle is NULL, then the active
                  periodic SMI handler has been disabled.
 **/
 BOOLEAN
+**/
+BOOLEAN
 EFIAPI
 PeriodicSmiDisable (
 …
     return FALSE;
+  }
   //
   // Unregister the periodic SMI handler from the SMM Periodic Timer Dispatch 2 Protocol
 …
 /**
   This constructor function caches the pointer to the SMM Periodic Timer
+  This constructor function caches the pointer to the SMM Periodic Timer
   Dispatch 2 Protocol and collects the list SMI tick rates that the hardware
   supports.
 …
   //
   // Count the number of periodic SMI tick intervals that the SMM Periodic Timer
+  // Count the number of periodic SMI tick intervals that the SMM Periodic Timer
   // Dipatch 2 Protocol supports.
   //
 …
                                            &SmiTickInterval
                                            );
     Count++;
   } while (SmiTickInterval != NULL);
+    Count++;
+  } while (SmiTickInterval != NULL);
   //
   // Allocate a buffer for the table of supported periodic SMI tick periods.
   //
+  //
   gSmiTickPeriodTable = AllocateZeroPool (Count * sizeof (UINT64));
   ASSERT (gSmiTickPeriodTable != NULL);
   //
   // Fill in the table of supported periodic SMI tick periods.
 …
 /**
   The constructor function caches the pointer to the SMM Periodic Timer Dispatch 2
+  The constructor function caches the pointer to the SMM Periodic Timer Dispatch 2
   Protocol and collects the list SMI tick rates that the hardware supports.
 …
   // Free all the periodic SMI handler entries
   //
   for (Link = GetFirstNode (&gFreePeriodicSmiLibraryHandlers); !IsNull (&gFreePeriodicSmiLibraryHandlers, Link);) {
+  for (Link = GetFirstNode (&gFreePeriodicSmiLibraryHandlers); !IsNull (&gFreePeriodicSmiLibraryHandlers, Link);) {
     PeriodicSmiLibraryHandler = PERIODIC_SMI_LIBRARY_HANDLER_CONTEXT_FROM_LINK (Link);
     Link = RemoveEntryList (Link);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmPeriodicSmiLib/SmmPeriodicSmiLib.inf

-              r58459
+              r58466
   CONSTRUCTOR                    = SmmPeriodicSmiLibConstructor
   DESTRUCTOR                     = SmmPeriodicSmiLibDestructor
+#
 #  VALID_ARCHITECTURES           = IA32 X64
 …
   MemoryAllocationLib
   SmmServicesTableLib
 [Protocols]
   gEfiSmmPeriodicTimerDispatch2ProtocolGuid  ## CONSUMES
 [Depex]
   gEfiSmmPeriodicTimerDispatch2ProtocolGuid

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.c

-              r48674
+              r58466
   //
   // Retrieve SMM Base2 Protocol,  Do not use gBS from UefiBootServicesTableLib on purpose
   // to prevent inclusion of gBS, gST, and gImageHandle from SMM Drivers unless the
   // SMM driver explicity declares that dependency.
+  // to prevent inclusion of gBS, gST, and gImageHandle from SMM Drivers unless the
+  // SMM driver explicity declares that dependency.
   //
   Status = SystemTable->BootServices->LocateProtocol (
 …
 /**
   This function allows the caller to determine if the driver is executing in
+  This function allows the caller to determine if the driver is executing in
   System Management Mode(SMM).
   This function returns TRUE if the driver is executing in SMM and FALSE if the
+  This function returns TRUE if the driver is executing in SMM and FALSE if the
   driver is not executing in SMM.
   @retval  TRUE  The driver is executing in System Management Mode (SMM).
   @retval  FALSE The driver is not executing in System Management Mode (SMM).
+  @retval  FALSE The driver is not executing in System Management Mode (SMM).
 **/

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiApplicationEntryPoint/ApplicationEntryPoint.c

-              r48674
+              r58466
 /**
   Invokes the library destructors for all dependent libraries and terminates
   the UEFI Application.
+  the UEFI Application.
   This function calls ProcessLibraryDestructorList() and the EFI Boot Service Exit()
 …
   @param  Status  Status returned by the application that is exiting.
 **/
 VOID
 …
 /**
   Required by the EBC compiler and identical in functionality to _ModuleEntryPoint().
+  Required by the EBC compiler and identical in functionality to _ModuleEntryPoint().
   @param  ImageHandle  The image handle of the UEFI Application.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.c

-              r48674
+              r58466
 /** @file
   This library retrieve the EFI_BOOT_SERVICES pointer from EFI system table in
+  This library retrieve the EFI_BOOT_SERVICES pointer from EFI system table in
   library's constructor.
 …
 /**
   The constructor function caches the pointer of Boot Services Table.
   The constructor function caches the pointer of Boot Services Table through System Table.
   It will ASSERT() if the pointer of System Table is NULL.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf

r58459	r58466
1	1	## @file
2	2	# UEFI Boot Services Table Library implementation.
3		#
	3	#
4	4	# Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
5	5	#

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDebugLibConOut/DebugLib.c

-              r58459
+              r58466
   Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
 //
 // Define the maximum debug and assert message length that this library supports
+// Define the maximum debug and assert message length that this library supports
 //
 #define MAX_DEBUG_MESSAGE_LENGTH  0x100
 …
   Prints a debug message to the debug output device if the specified error level is enabled.
   If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function
   GetDebugPrintErrorLevel (), then print the message specified by Format and the
+  If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function
+  GetDebugPrintErrorLevel (), then print the message specified by Format and the
   associated variable argument list to the debug output device.
 …
   @param  ErrorLevel  The error level of the debug message.
   @param  Format      Format string for the debug message to print.
   @param  ...         A variable argument list whose contents are accessed
+  @param  ...         A variable argument list whose contents are accessed
                       based on the format string specified by Format.
 …
 /**
   Prints an assert message containing a filename, line number, and description.
+  Prints an assert message containing a filename, line number, and description.
   This may be followed by a breakpoint or a dead loop.
   Print a message of the form "ASSERT <FileName>(<LineNumber>): <Description>\n"
   to the debug output device.  If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit of
   PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if
   DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then
   CpuDeadLoop() is called.  If neither of these bits are set, then this function
+  to the debug output device.  If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit of
+  PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if
+  DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then
+  CpuDeadLoop() is called.  If neither of these bits are set, then this function
   returns immediately after the message is printed to the debug output device.
   DebugAssert() must actively prevent recursion.  If DebugAssert() is called while
 …
   If Description is NULL, then a <Description> string of "(NULL) Description" is printed.
   @param  FileName     The pointer to the name of the source file that generated
+  @param  FileName     The pointer to the name of the source file that generated
                        the assert condition.
   @param  LineNumber   The line number in the source file that generated the
+  @param  LineNumber   The line number in the source file that generated the
                        assert condition
   @param  Description  The pointer to the description of the assert condition.
 …
   //
   UnicodeSPrintAsciiFormat (
     Buffer,
     sizeof (Buffer),
     "ASSERT %a(%d): %a\n",
     FileName,
     LineNumber,
+    Buffer,
+    sizeof (Buffer),
+    "ASSERT %a(%d): %a\n",
+    FileName,
+    LineNumber,
     Description
     );
   //
   // Send the print string to the Console Output device
 …
   Fills a target buffer with PcdDebugClearMemoryValue, and returns the target buffer.
   This function fills Length bytes of Buffer with the value specified by
+  This function fills Length bytes of Buffer with the value specified by
   PcdDebugClearMemoryValue, and returns Buffer.
   If Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param   Buffer  The pointer to the target buffer to be filled with PcdDebugClearMemoryValue.
   @param   Length  The number of bytes in Buffer to fill with zeros PcdDebugClearMemoryValue.
+  @param   Length  The number of bytes in Buffer to fill with zeros PcdDebugClearMemoryValue.
   @return  Buffer  The pointer to the target buffer filled with PcdDebugClearMemoryValue.
 …
   Returns TRUE if ASSERT() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG_CODE() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG_CLEAR_MEMORY() macro is enabled.
   This function returns TRUE if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf

r58459	r58466
23	23	MODULE_TYPE = UEFI_DRIVER
24	24	VERSION_STRING = 1.0
25		LIBRARY_CLASS = DebugLib\|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
	25	LIBRARY_CLASS = DebugLib\|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
26	26
27	27

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDebugLibStdErr/DebugLib.c

-              r58459
+              r58466
   Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
 //
 // Define the maximum debug and assert message length that this library supports
+// Define the maximum debug and assert message length that this library supports
 //
 #define MAX_DEBUG_MESSAGE_LENGTH  0x100
 …
   Prints a debug message to the debug output device if the specified error level is enabled.
   If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function
   GetDebugPrintErrorLevel (), then print the message specified by Format and the
+  If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function
+  GetDebugPrintErrorLevel (), then print the message specified by Format and the
   associated variable argument list to the debug output device.
 …
   @param  ErrorLevel  The error level of the debug message.
   @param  Format      The format string for the debug message to print.
   @param  ...         The variable argument list whose contents are accessed
+  @param  ...         The variable argument list whose contents are accessed
                       based on the format string specified by Format.
 …
 /**
   Prints an assert message containing a filename, line number, and description.
+  Prints an assert message containing a filename, line number, and description.
   This may be followed by a breakpoint or a dead loop.
   Print a message of the form "ASSERT <FileName>(<LineNumber>): <Description>\n"
   to the debug output device.  If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit of
   PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if
   DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then
   CpuDeadLoop() is called.  If neither of these bits are set, then this function
+  to the debug output device.  If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit of
+  PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if
+  DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then
+  CpuDeadLoop() is called.  If neither of these bits are set, then this function
   returns immediately after the message is printed to the debug output device.
   DebugAssert() must actively prevent recursion.  If DebugAssert() is called while
 …
   If Description is NULL, then a <Description> string of "(NULL) Description" is printed.
   @param  FileName     The pointer to the name of the source file that generated
+  @param  FileName     The pointer to the name of the source file that generated
                        the assert condition.
   @param  LineNumber   The line number in the source file that generated the
+  @param  LineNumber   The line number in the source file that generated the
                        assert condition
   @param  Description  The pointer to the description of the assert condition.
 …
   //
   UnicodeSPrintAsciiFormat (
     Buffer,
+    Buffer,
     sizeof (Buffer),
     "ASSERT %a(%d): %a\n",
     FileName,
     LineNumber,
+    "ASSERT %a(%d): %a\n",
+    FileName,
+    LineNumber,
     Description
     );
   //
   // Send the print string to the Standard Error device
 …
   Fills a target buffer with PcdDebugClearMemoryValue, and returns the target buffer.
   This function fills Length bytes of Buffer with the value specified by
+  This function fills Length bytes of Buffer with the value specified by
   PcdDebugClearMemoryValue, and returns Buffer.
   If Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param   Buffer  The pointer to the target buffer to be filled with PcdDebugClearMemoryValue.
   @param   Length  The number of bytes in Buffer to fill with zeros PcdDebugClearMemoryValue.
+  @param   Length  The number of bytes in Buffer to fill with zeros PcdDebugClearMemoryValue.
   @return  Buffer  The pointer to the target buffer filled with PcdDebugClearMemoryValue.
 …
   Returns TRUE if ASSERT() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG_CODE() macros are enabled.
   This function returns TRUE if the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.
 …
 /**
+/**
   Returns TRUE if DEBUG_CLEAR_MEMORY() macro is enabled.
   This function returns TRUE if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of
+  This function returns TRUE if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of
   PcdDebugProperyMask is set.  Otherwise FALSE is returned.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf

r58459	r58466
23	23	MODULE_TYPE = UEFI_DRIVER
24	24	VERSION_STRING = 1.0
25		LIBRARY_CLASS = DebugLib\|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
	25	LIBRARY_CLASS = DebugLib\|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
26	26
27	27

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c

r58464	r58466
280	280	Str ++;
281	281	}
282
	282
283	283	return (BOOLEAN) (Str == L'x' \|\| Str == L'X');
284	284	}
…	…
410	410	Str ++;
411	411	}
412
	412
413	413	if (IS_HYPHEN (*Str)) {
414	414	Str++;
…	…
416	416	return EFI_UNSUPPORTED;
417	417	}
418
	418
419	419	//
420	420	// Get the second UINT16 data
…	…
430	430	return EFI_UNSUPPORTED;
431	431	}
432
	432
433	433	//
434	434	// Get the third UINT16 data
…	…
447	447	//
448	448	// Get the following 8 bytes data
449		//
	449	//
450	450	StrToBuf (&Guid->Data4[0], 2, Str);
451	451	//
…	…
1130	1130	SetDevicePathNodeLength (AcpiAdr, Length + sizeof (UINT32));
1131	1131	}
1132
	1132
1133	1133	(&AcpiAdr->ADR)[Index] = (UINT32) Strtoi (DisplayDeviceStr);
1134	1134	}

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c

-              r58464
+              r58466
   UnicodeVSPrint (&Str->Str[Str->Count], Str->Capacity - Str->Count * sizeof (CHAR16), Fmt, Args);
   Str->Count += Count;
   VA_END (Args);
   return Str->Str;
 …
   //
   // Converts EISA identification to string.
   //
+  //
   UnicodeSPrint (
     HIDText,
 …
     return ;
+  }
   UefiDevicePathLibCatPrint (Str, L",");
   CatNetworkProtocol (Str, IPDevPath->Protocol);
 …
+      }
+    }
     AlignedNode = AllocateCopyPool (DevicePathNodeLength (Node), Node);
     //
 …
     ToText (&Str, AlignedNode, DisplayOnly, AllowShortcuts);
     FreePool (AlignedNode);
     //
     // Next device path node

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDevicePathLib/DevicePathUtilities.c

-              r58464
+              r58466
   Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
   Returns the 16-bit Length field of a device path node.
   Returns the 16-bit Length field of the device path node specified by Node.
+  Returns the 16-bit Length field of the device path node specified by Node.
   Node is not required to be aligned on a 16-bit boundary, so it is recommended
   that a function such as ReadUnaligned16() be used to extract the contents of
+  that a function such as ReadUnaligned16() be used to extract the contents of
   the Length field.
 …
   Returns a pointer to the next node in a device path.
   Returns a pointer to the device path node that follows the device path node
+  Returns a pointer to the device path node that follows the device path node
   specified by Node.
 …
   @param  Node      A pointer to a device path node data structure.
   @return a pointer to the device path node that follows the device path node
+  @return a pointer to the device path node that follows the device path node
   specified by Node.
 …
 /**
   Determines if a device path node is an end node of a device path.
   This includes nodes that are the end of a device path instance and nodes that
+  This includes nodes that are the end of a device path instance and nodes that
   are the end of an entire device path.
   Determines if the device path node specified by Node is an end node of a device path.
   This includes nodes that are the end of a device path instance and nodes that are the
   end of an entire device path.  If Node represents an end node of a device path,
+  Determines if the device path node specified by Node is an end node of a device path.
+  This includes nodes that are the end of a device path instance and nodes that are the
+  end of an entire device path.  If Node represents an end node of a device path,
   then TRUE is returned.  Otherwise, FALSE is returned.
 …
   @param  Node      A pointer to a device path node data structure.
   @retval TRUE      The device path node specified by Node is an end node of a
+  @retval TRUE      The device path node specified by Node is an end node of a
                     device path.
   @retval FALSE     The device path node specified by Node is not an end node of
+  @retval FALSE     The device path node specified by Node is not an end node of
                     a device path.
 **/
 BOOLEAN
 …
   Determines if a device path node is an end node of an entire device path.
   Determines if a device path node specified by Node is an end node of an entire
   device path. If Node represents the end of an entire device path, then TRUE is
+  Determines if a device path node specified by Node is an end node of an entire
+  device path. If Node represents the end of an entire device path, then TRUE is
   returned.  Otherwise, FALSE is returned.
 …
   @param  Node      A pointer to a device path node data structure.
   @retval TRUE      The device path node specified by Node is the end of an entire
+  @retval TRUE      The device path node specified by Node is the end of an entire
                     device path.
   @retval FALSE     The device path node specified by Node is not the end of an
+  @retval FALSE     The device path node specified by Node is not the end of an
                     entire device path.
 …
   Determines if a device path node is an end node of a device path instance.
   Determines if a device path node specified by Node is an end node of a device
   path instance. If Node represents the end of a device path instance, then TRUE
+  Determines if a device path node specified by Node is an end node of a device
+  path instance. If Node represents the end of a device path instance, then TRUE
   is returned.  Otherwise, FALSE is returned.
 …
   @param  Node      A pointer to a device path node data structure.
   @retval TRUE      The device path node specified by Node is the end of a device
+  @retval TRUE      The device path node specified by Node is the end of a device
                     path instance.
   @retval FALSE     The device path node specified by Node is not the end of a
+  @retval FALSE     The device path node specified by Node is not the end of a
                     device path instance.
 …
   Sets the length, in bytes, of a device path node.
   Sets the length of the device path node specified by Node to the value specified
   by NodeLength.  NodeLength is returned.  Node is not required to be aligned on
+  Sets the length of the device path node specified by Node to the value specified
+  by NodeLength.  NodeLength is returned.  Node is not required to be aligned on
   a 16-bit boundary, so it is recommended that a function such as WriteUnaligned16()
   be used to set the contents of the Length field.
 …
   Fills in all the fields of a device path node that is the end of an entire device path.
   Fills in all the fields of a device path node specified by Node so Node represents
   the end of an entire device path.  The Type field of Node is set to
   END_DEVICE_PATH_TYPE, the SubType field of Node is set to
   END_ENTIRE_DEVICE_PATH_SUBTYPE, and the Length field of Node is set to
   END_DEVICE_PATH_LENGTH.  Node is not required to be aligned on a 16-bit boundary,
   so it is recommended that a function such as WriteUnaligned16() be used to set
   the contents of the Length field.
   If Node is NULL, then ASSERT().
+  Fills in all the fields of a device path node specified by Node so Node represents
+  the end of an entire device path.  The Type field of Node is set to
+  END_DEVICE_PATH_TYPE, the SubType field of Node is set to
+  END_ENTIRE_DEVICE_PATH_SUBTYPE, and the Length field of Node is set to
+  END_DEVICE_PATH_LENGTH.  Node is not required to be aligned on a 16-bit boundary,
+  so it is recommended that a function such as WriteUnaligned16() be used to set
+  the contents of the Length field.
+  If Node is NULL, then ASSERT().
   @param  Node      A pointer to a device path node data structure.
 …
   Returns the size of a device path in bytes.
   This function returns the size, in bytes, of the device path data structure
+  This function returns the size, in bytes, of the device path data structure
   specified by DevicePath including the end of device path node.
   If DevicePath is NULL or invalid, then 0 is returned.
 …
   Creates a new copy of an existing device path.
   This function allocates space for a new copy of the device path specified by DevicePath.
   If DevicePath is NULL, then NULL is returned.  If the memory is successfully
   allocated, then the contents of DevicePath are copied to the newly allocated
   buffer, and a pointer to that buffer is returned.  Otherwise, NULL is returned.
   The memory for the new device path is allocated from EFI boot services memory.
   It is the responsibility of the caller to free the memory allocated.
+  This function allocates space for a new copy of the device path specified by DevicePath.
+  If DevicePath is NULL, then NULL is returned.  If the memory is successfully
+  allocated, then the contents of DevicePath are copied to the newly allocated
+  buffer, and a pointer to that buffer is returned.  Otherwise, NULL is returned.
+  The memory for the new device path is allocated from EFI boot services memory.
+  It is the responsibility of the caller to free the memory allocated.
   @param  DevicePath    A pointer to a device path data structure.
   @retval NULL          DevicePath is NULL or invalid.
   @retval Others        A pointer to the duplicated device path.
 **/
 EFI_DEVICE_PATH_PROTOCOL *
 …
   Creates a new device path by appending a second device path to a first device path.
   This function creates a new device path by appending a copy of SecondDevicePath
   to a copy of FirstDevicePath in a newly allocated buffer.  Only the end-of-device-path
   device node from SecondDevicePath is retained. The newly created device path is
   returned. If FirstDevicePath is NULL, then it is ignored, and a duplicate of
   SecondDevicePath is returned.  If SecondDevicePath is NULL, then it is ignored,
   and a duplicate of FirstDevicePath is returned. If both FirstDevicePath and
   SecondDevicePath are NULL, then a copy of an end-of-device-path is returned.
+  This function creates a new device path by appending a copy of SecondDevicePath
+  to a copy of FirstDevicePath in a newly allocated buffer.  Only the end-of-device-path
+  device node from SecondDevicePath is retained. The newly created device path is
+  returned. If FirstDevicePath is NULL, then it is ignored, and a duplicate of
+  SecondDevicePath is returned.  If SecondDevicePath is NULL, then it is ignored,
+  and a duplicate of FirstDevicePath is returned. If both FirstDevicePath and
+  SecondDevicePath are NULL, then a copy of an end-of-device-path is returned.
   If there is not enough memory for the newly allocated buffer, then NULL is returned.
   The memory for the new device path is allocated from EFI boot services memory.
+  The memory for the new device path is allocated from EFI boot services memory.
   It is the responsibility of the caller to free the memory allocated.
   @param  FirstDevicePath            A pointer to a device path data structure.
   @param  SecondDevicePath           A pointer to a device path data structure.
   @retval NULL      If there is not enough memory for the newly allocated buffer.
   @retval NULL      If FirstDevicePath or SecondDevicePath is invalid.
 …
   Creates a new path by appending the device node to the device path.
   This function creates a new device path by appending a copy of the device node
   specified by DevicePathNode to a copy of the device path specified by DevicePath
   in an allocated buffer. The end-of-device-path device node is moved after the
+  This function creates a new device path by appending a copy of the device node
+  specified by DevicePathNode to a copy of the device path specified by DevicePath
+  in an allocated buffer. The end-of-device-path device node is moved after the
   end of the appended device node.
   If DevicePathNode is NULL then a copy of DevicePath is returned.
   If DevicePath is NULL then a copy of DevicePathNode, followed by an end-of-device
+  If DevicePath is NULL then a copy of DevicePathNode, followed by an end-of-device
   path device node is returned.
   If both DevicePathNode and DevicePath are NULL then a copy of an end-of-device-path
+  If both DevicePathNode and DevicePath are NULL then a copy of an end-of-device-path
   device node is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
 …
   @retval NULL      If there is not enough memory for the new device path.
   @retval Others    A pointer to the new device path if success.
                     A copy of DevicePathNode followed by an end-of-device-path node
+                    A copy of DevicePathNode followed by an end-of-device-path node
                     if both FirstDevicePath and SecondDevicePath are NULL.
                     A copy of an end-of-device-path node if both FirstDevicePath
+                    A copy of an end-of-device-path node if both FirstDevicePath
                     and SecondDevicePath are NULL.
 …
   Creates a new device path by appending the specified device path instance to the specified device
   path.
   This function creates a new device path by appending a copy of the device path
   instance specified by DevicePathInstance to a copy of the device path specified
+  This function creates a new device path by appending a copy of the device path
+  instance specified by DevicePathInstance to a copy of the device path specified
   by DevicePath in a allocated buffer.
   The end-of-device-path device node is moved after the end of the appended device
   path instance and a new end-of-device-path-instance node is inserted between.
+  The end-of-device-path device node is moved after the end of the appended device
+  path instance and a new end-of-device-path-instance node is inserted between.
   If DevicePath is NULL, then a copy if DevicePathInstance is returned.
   If DevicePathInstance is NULL, then NULL is returned.
   If DevicePath or DevicePathInstance is invalid, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   @param  DevicePath                 A pointer to a device path data structure.
   @param  DevicePathInstance         A pointer to a device path instance.
 …
   NewDevicePath = AllocatePool (SrcSize + InstanceSize);
   if (NewDevicePath != NULL) {
     TempDevicePath = CopyMem (NewDevicePath, DevicePath, SrcSize);;
     while (!IsDevicePathEnd (TempDevicePath)) {
       TempDevicePath = NextDevicePathNode (TempDevicePath);
+    }
     TempDevicePath->SubType  = END_INSTANCE_DEVICE_PATH_SUBTYPE;
     TempDevicePath           = NextDevicePathNode (TempDevicePath);
 …
   instance.
   This function creates a copy of the current device path instance. It also updates
   DevicePath to point to the next device path instance in the device path (or NULL
+  This function creates a copy of the current device path instance. It also updates
+  DevicePath to point to the next device path instance in the device path (or NULL
   if no more) and updates Size to hold the size of the device path instance copy.
   If DevicePath is NULL, then NULL is returned.
   If DevicePath points to a invalid device path, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   If Size is NULL, then ASSERT().
   @param  DevicePath                 On input, this holds the pointer to the current
                                      device path instance. On output, this holds
                                      the pointer to the next device path instance
+  @param  DevicePath                 On input, this holds the pointer to the current
+                                     device path instance. On output, this holds
+                                     the pointer to the next device path instance
                                      or NULL if there are no more device path
                                      instances in the device path pointer to a
+                                     instances in the device path pointer to a
                                      device path data structure.
   @param  Size                       On output, this holds the size of the device
                                      path instance, in bytes or zero, if DevicePath
+  @param  Size                       On output, this holds the size of the device
+                                     path instance, in bytes or zero, if DevicePath
                                      is NULL.
 …
   //
   *Size = ((UINTN) DevPath - (UINTN) (*DevicePath)) + sizeof (EFI_DEVICE_PATH_PROTOCOL);
   //
   // Make a copy and return the device path instance
 …
   Creates a device node.
   This function creates a new device node in a newly allocated buffer of size
   NodeLength and initializes the device path node header with NodeType and NodeSubType.
+  This function creates a new device node in a newly allocated buffer of size
+  NodeLength and initializes the device path node header with NodeType and NodeSubType.
   The new device path node is returned.
   If NodeLength is smaller than a device path header, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If NodeLength is smaller than a device path header, then NULL is returned.
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
 …
     return NULL;
+  }
   DevicePath = AllocateZeroPool (NodeLength);
   if (DevicePath != NULL) {
 …
   @retval  TRUE                      DevicePath is multi-instance.
   @retval  FALSE                     DevicePath is not multi-instance, or DevicePath
+  @retval  FALSE                     DevicePath is not multi-instance, or DevicePath
                                      is NULL or invalid.
 …
   Retrieves the device path protocol from a handle.
   This function returns the device path protocol from the handle specified by Handle.
   If Handle is NULL or Handle does not contain a device path protocol, then NULL
+  This function returns the device path protocol from the handle specified by Handle.
+  If Handle is NULL or Handle does not contain a device path protocol, then NULL
   is returned.
   @param  Handle                     The handle from which to retrieve the device
+  @param  Handle                     The handle from which to retrieve the device
                                      path protocol.
 …
   The memory for the new device path is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   If FileName is NULL, then ASSERT().
   If FileName is not aligned on a 16-bit boundary, then ASSERT().
   @param  Device                     A pointer to a device handle.  This parameter
+  @param  Device                     A pointer to a device handle.  This parameter
                                      is optional and may be NULL.
   @param  FileName                   A pointer to a Null-terminated Unicode string.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.c

-              r58459
+              r58466
   Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
   Returns the size of a device path in bytes.
   This function returns the size, in bytes, of the device path data structure
+  This function returns the size, in bytes, of the device path data structure
   specified by DevicePath including the end of device path node.
   If DevicePath is NULL or invalid, then 0 is returned.
 …
   Creates a new copy of an existing device path.
   This function allocates space for a new copy of the device path specified by DevicePath.
   If DevicePath is NULL, then NULL is returned.  If the memory is successfully
   allocated, then the contents of DevicePath are copied to the newly allocated
   buffer, and a pointer to that buffer is returned.  Otherwise, NULL is returned.
   The memory for the new device path is allocated from EFI boot services memory.
   It is the responsibility of the caller to free the memory allocated.
+  This function allocates space for a new copy of the device path specified by DevicePath.
+  If DevicePath is NULL, then NULL is returned.  If the memory is successfully
+  allocated, then the contents of DevicePath are copied to the newly allocated
+  buffer, and a pointer to that buffer is returned.  Otherwise, NULL is returned.
+  The memory for the new device path is allocated from EFI boot services memory.
+  It is the responsibility of the caller to free the memory allocated.
   @param  DevicePath    A pointer to a device path data structure.
   @retval NULL          DevicePath is NULL or invalid.
   @retval Others        A pointer to the duplicated device path.
 **/
 EFI_DEVICE_PATH_PROTOCOL *
 …
   Creates a new device path by appending a second device path to a first device path.
   This function creates a new device path by appending a copy of SecondDevicePath
   to a copy of FirstDevicePath in a newly allocated buffer.  Only the end-of-device-path
   device node from SecondDevicePath is retained. The newly created device path is
   returned. If FirstDevicePath is NULL, then it is ignored, and a duplicate of
   SecondDevicePath is returned.  If SecondDevicePath is NULL, then it is ignored,
   and a duplicate of FirstDevicePath is returned. If both FirstDevicePath and
   SecondDevicePath are NULL, then a copy of an end-of-device-path is returned.
+  This function creates a new device path by appending a copy of SecondDevicePath
+  to a copy of FirstDevicePath in a newly allocated buffer.  Only the end-of-device-path
+  device node from SecondDevicePath is retained. The newly created device path is
+  returned. If FirstDevicePath is NULL, then it is ignored, and a duplicate of
+  SecondDevicePath is returned.  If SecondDevicePath is NULL, then it is ignored,
+  and a duplicate of FirstDevicePath is returned. If both FirstDevicePath and
+  SecondDevicePath are NULL, then a copy of an end-of-device-path is returned.
   If there is not enough memory for the newly allocated buffer, then NULL is returned.
   The memory for the new device path is allocated from EFI boot services memory.
+  The memory for the new device path is allocated from EFI boot services memory.
   It is the responsibility of the caller to free the memory allocated.
   @param  FirstDevicePath            A pointer to a device path data structure.
   @param  SecondDevicePath           A pointer to a device path data structure.
   @retval NULL      If there is not enough memory for the newly allocated buffer.
   @retval NULL      If FirstDevicePath or SecondDevicePath is invalid.
 …
   Creates a new path by appending the device node to the device path.
   This function creates a new device path by appending a copy of the device node
   specified by DevicePathNode to a copy of the device path specified by DevicePath
   in an allocated buffer. The end-of-device-path device node is moved after the
+  This function creates a new device path by appending a copy of the device node
+  specified by DevicePathNode to a copy of the device path specified by DevicePath
+  in an allocated buffer. The end-of-device-path device node is moved after the
   end of the appended device node.
   If DevicePathNode is NULL then a copy of DevicePath is returned.
   If DevicePath is NULL then a copy of DevicePathNode, followed by an end-of-device
+  If DevicePath is NULL then a copy of DevicePathNode, followed by an end-of-device
   path device node is returned.
   If both DevicePathNode and DevicePath are NULL then a copy of an end-of-device-path
+  If both DevicePathNode and DevicePath are NULL then a copy of an end-of-device-path
   device node is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
 …
   @retval NULL      If there is not enough memory for the new device path.
   @retval Others    A pointer to the new device path if success.
                     A copy of DevicePathNode followed by an end-of-device-path node
+                    A copy of DevicePathNode followed by an end-of-device-path node
                     if both FirstDevicePath and SecondDevicePath are NULL.
                     A copy of an end-of-device-path node if both FirstDevicePath
+                    A copy of an end-of-device-path node if both FirstDevicePath
                     and SecondDevicePath are NULL.
 …
   Creates a new device path by appending the specified device path instance to the specified device
   path.
   This function creates a new device path by appending a copy of the device path
   instance specified by DevicePathInstance to a copy of the device path specified
+  This function creates a new device path by appending a copy of the device path
+  instance specified by DevicePathInstance to a copy of the device path specified
   by DevicePath in a allocated buffer.
   The end-of-device-path device node is moved after the end of the appended device
   path instance and a new end-of-device-path-instance node is inserted between.
+  The end-of-device-path device node is moved after the end of the appended device
+  path instance and a new end-of-device-path-instance node is inserted between.
   If DevicePath is NULL, then a copy if DevicePathInstance is returned.
   If DevicePathInstance is NULL, then NULL is returned.
   If DevicePath or DevicePathInstance is invalid, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   @param  DevicePath                 A pointer to a device path data structure.
   @param  DevicePathInstance         A pointer to a device path instance.
 …
   instance.
   This function creates a copy of the current device path instance. It also updates
   DevicePath to point to the next device path instance in the device path (or NULL
+  This function creates a copy of the current device path instance. It also updates
+  DevicePath to point to the next device path instance in the device path (or NULL
   if no more) and updates Size to hold the size of the device path instance copy.
   If DevicePath is NULL, then NULL is returned.
   If DevicePath points to a invalid device path, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   If Size is NULL, then ASSERT().
   @param  DevicePath                 On input, this holds the pointer to the current
                                      device path instance. On output, this holds
                                      the pointer to the next device path instance
+  @param  DevicePath                 On input, this holds the pointer to the current
+                                     device path instance. On output, this holds
+                                     the pointer to the next device path instance
                                      or NULL if there are no more device path
                                      instances in the device path pointer to a
+                                     instances in the device path pointer to a
                                      device path data structure.
   @param  Size                       On output, this holds the size of the device
                                      path instance, in bytes or zero, if DevicePath
+  @param  Size                       On output, this holds the size of the device
+                                     path instance, in bytes or zero, if DevicePath
                                      is NULL.
 …
   Creates a device node.
   This function creates a new device node in a newly allocated buffer of size
   NodeLength and initializes the device path node header with NodeType and NodeSubType.
+  This function creates a new device node in a newly allocated buffer of size
+  NodeLength and initializes the device path node header with NodeType and NodeSubType.
   The new device path node is returned.
   If NodeLength is smaller than a device path header, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If NodeLength is smaller than a device path header, then NULL is returned.
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
 …
   @retval  TRUE                      DevicePath is multi-instance.
   @retval  FALSE                     DevicePath is not multi-instance, or DevicePath
+  @retval  FALSE                     DevicePath is not multi-instance, or DevicePath
                                      is NULL or invalid.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.h

-              r58464
+              r58466
   Returns the size of a device path in bytes.
   This function returns the size, in bytes, of the device path data structure
+  This function returns the size, in bytes, of the device path data structure
   specified by DevicePath including the end of device path node.
   If DevicePath is NULL or invalid, then 0 is returned.
 …
   Creates a new copy of an existing device path.
   This function allocates space for a new copy of the device path specified by DevicePath.
   If DevicePath is NULL, then NULL is returned.  If the memory is successfully
   allocated, then the contents of DevicePath are copied to the newly allocated
   buffer, and a pointer to that buffer is returned.  Otherwise, NULL is returned.
   The memory for the new device path is allocated from EFI boot services memory.
   It is the responsibility of the caller to free the memory allocated.
+  This function allocates space for a new copy of the device path specified by DevicePath.
+  If DevicePath is NULL, then NULL is returned.  If the memory is successfully
+  allocated, then the contents of DevicePath are copied to the newly allocated
+  buffer, and a pointer to that buffer is returned.  Otherwise, NULL is returned.
+  The memory for the new device path is allocated from EFI boot services memory.
+  It is the responsibility of the caller to free the memory allocated.
   @param  DevicePath    A pointer to a device path data structure.
   @retval NULL          DevicePath is NULL or invalid.
   @retval Others        A pointer to the duplicated device path.
 **/
 EFI_DEVICE_PATH_PROTOCOL *
 …
   Creates a new device path by appending a second device path to a first device path.
   This function creates a new device path by appending a copy of SecondDevicePath
   to a copy of FirstDevicePath in a newly allocated buffer.  Only the end-of-device-path
   device node from SecondDevicePath is retained. The newly created device path is
   returned. If FirstDevicePath is NULL, then it is ignored, and a duplicate of
   SecondDevicePath is returned.  If SecondDevicePath is NULL, then it is ignored,
   and a duplicate of FirstDevicePath is returned. If both FirstDevicePath and
   SecondDevicePath are NULL, then a copy of an end-of-device-path is returned.
+  This function creates a new device path by appending a copy of SecondDevicePath
+  to a copy of FirstDevicePath in a newly allocated buffer.  Only the end-of-device-path
+  device node from SecondDevicePath is retained. The newly created device path is
+  returned. If FirstDevicePath is NULL, then it is ignored, and a duplicate of
+  SecondDevicePath is returned.  If SecondDevicePath is NULL, then it is ignored,
+  and a duplicate of FirstDevicePath is returned. If both FirstDevicePath and
+  SecondDevicePath are NULL, then a copy of an end-of-device-path is returned.
   If there is not enough memory for the newly allocated buffer, then NULL is returned.
   The memory for the new device path is allocated from EFI boot services memory.
+  The memory for the new device path is allocated from EFI boot services memory.
   It is the responsibility of the caller to free the memory allocated.
   @param  FirstDevicePath            A pointer to a device path data structure.
   @param  SecondDevicePath           A pointer to a device path data structure.
   @retval NULL      If there is not enough memory for the newly allocated buffer.
   @retval NULL      If FirstDevicePath or SecondDevicePath is invalid.
 …
   Creates a new path by appending the device node to the device path.
   This function creates a new device path by appending a copy of the device node
   specified by DevicePathNode to a copy of the device path specified by DevicePath
   in an allocated buffer. The end-of-device-path device node is moved after the
+  This function creates a new device path by appending a copy of the device node
+  specified by DevicePathNode to a copy of the device path specified by DevicePath
+  in an allocated buffer. The end-of-device-path device node is moved after the
   end of the appended device node.
   If DevicePathNode is NULL then a copy of DevicePath is returned.
   If DevicePath is NULL then a copy of DevicePathNode, followed by an end-of-device
+  If DevicePath is NULL then a copy of DevicePathNode, followed by an end-of-device
   path device node is returned.
   If both DevicePathNode and DevicePath are NULL then a copy of an end-of-device-path
+  If both DevicePathNode and DevicePath are NULL then a copy of an end-of-device-path
   device node is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
 …
   @retval NULL      If there is not enough memory for the new device path.
   @retval Others    A pointer to the new device path if success.
                     A copy of DevicePathNode followed by an end-of-device-path node
+                    A copy of DevicePathNode followed by an end-of-device-path node
                     if both FirstDevicePath and SecondDevicePath are NULL.
                     A copy of an end-of-device-path node if both FirstDevicePath
+                    A copy of an end-of-device-path node if both FirstDevicePath
                     and SecondDevicePath are NULL.
 …
   Creates a new device path by appending the specified device path instance to the specified device
   path.
   This function creates a new device path by appending a copy of the device path
   instance specified by DevicePathInstance to a copy of the device path specified
+  This function creates a new device path by appending a copy of the device path
+  instance specified by DevicePathInstance to a copy of the device path specified
   by DevicePath in a allocated buffer.
   The end-of-device-path device node is moved after the end of the appended device
   path instance and a new end-of-device-path-instance node is inserted between.
+  The end-of-device-path device node is moved after the end of the appended device
+  path instance and a new end-of-device-path-instance node is inserted between.
   If DevicePath is NULL, then a copy if DevicePathInstance is returned.
   If DevicePathInstance is NULL, then NULL is returned.
   If DevicePath or DevicePathInstance is invalid, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   @param  DevicePath                 A pointer to a device path data structure.
   @param  DevicePathInstance         A pointer to a device path instance.
 …
   instance.
   This function creates a copy of the current device path instance. It also updates
   DevicePath to point to the next device path instance in the device path (or NULL
+  This function creates a copy of the current device path instance. It also updates
+  DevicePath to point to the next device path instance in the device path (or NULL
   if no more) and updates Size to hold the size of the device path instance copy.
   If DevicePath is NULL, then NULL is returned.
   If DevicePath points to a invalid device path, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   If Size is NULL, then ASSERT().
   @param  DevicePath                 On input, this holds the pointer to the current
                                      device path instance. On output, this holds
                                      the pointer to the next device path instance
+  @param  DevicePath                 On input, this holds the pointer to the current
+                                     device path instance. On output, this holds
+                                     the pointer to the next device path instance
                                      or NULL if there are no more device path
                                      instances in the device path pointer to a
+                                     instances in the device path pointer to a
                                      device path data structure.
   @param  Size                       On output, this holds the size of the device
                                      path instance, in bytes or zero, if DevicePath
+  @param  Size                       On output, this holds the size of the device
+                                     path instance, in bytes or zero, if DevicePath
                                      is NULL.
 …
   Creates a device node.
   This function creates a new device node in a newly allocated buffer of size
   NodeLength and initializes the device path node header with NodeType and NodeSubType.
+  This function creates a new device node in a newly allocated buffer of size
+  NodeLength and initializes the device path node header with NodeType and NodeSubType.
   The new device path node is returned.
   If NodeLength is smaller than a device path header, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If NodeLength is smaller than a device path header, then NULL is returned.
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
 …
   @retval  TRUE                      DevicePath is multi-instance.
   @retval  FALSE                     DevicePath is not multi-instance, or DevicePath
+  @retval  FALSE                     DevicePath is not multi-instance, or DevicePath
                                      is NULL or invalid.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathProtocol.c

-              r58464
+              r58466
   Copyright (c) 2013, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
   The constructor function caches the pointer to DevicePathUtilites protocol,
   DevicePathToText protocol and DevicePathFromText protocol.
   The constructor function locates these three protocols from protocol database.
   It will caches the pointer to local protocol instance if that operation fails
   and it will always return EFI_SUCCESS.
+  and it will always return EFI_SUCCESS.
   @param  ImageHandle   The firmware allocated handle for the EFI image.
   @param  SystemTable   A pointer to the EFI System Table.
   @retval EFI_SUCCESS   The constructor always returns EFI_SUCCESS.
 …
   Returns the size of a device path in bytes.
   This function returns the size, in bytes, of the device path data structure
+  This function returns the size, in bytes, of the device path data structure
   specified by DevicePath including the end of device path node.
   If DevicePath is NULL or invalid, then 0 is returned.
 …
   Creates a new copy of an existing device path.
   This function allocates space for a new copy of the device path specified by DevicePath.
   If DevicePath is NULL, then NULL is returned.  If the memory is successfully
   allocated, then the contents of DevicePath are copied to the newly allocated
   buffer, and a pointer to that buffer is returned.  Otherwise, NULL is returned.
   The memory for the new device path is allocated from EFI boot services memory.
   It is the responsibility of the caller to free the memory allocated.
+  This function allocates space for a new copy of the device path specified by DevicePath.
+  If DevicePath is NULL, then NULL is returned.  If the memory is successfully
+  allocated, then the contents of DevicePath are copied to the newly allocated
+  buffer, and a pointer to that buffer is returned.  Otherwise, NULL is returned.
+  The memory for the new device path is allocated from EFI boot services memory.
+  It is the responsibility of the caller to free the memory allocated.
   @param  DevicePath    A pointer to a device path data structure.
   @retval NULL          DevicePath is NULL or invalid.
   @retval Others        A pointer to the duplicated device path.
 **/
 EFI_DEVICE_PATH_PROTOCOL *
 …
   Creates a new device path by appending a second device path to a first device path.
   This function creates a new device path by appending a copy of SecondDevicePath
   to a copy of FirstDevicePath in a newly allocated buffer.  Only the end-of-device-path
   device node from SecondDevicePath is retained. The newly created device path is
   returned. If FirstDevicePath is NULL, then it is ignored, and a duplicate of
   SecondDevicePath is returned.  If SecondDevicePath is NULL, then it is ignored,
   and a duplicate of FirstDevicePath is returned. If both FirstDevicePath and
   SecondDevicePath are NULL, then a copy of an end-of-device-path is returned.
+  This function creates a new device path by appending a copy of SecondDevicePath
+  to a copy of FirstDevicePath in a newly allocated buffer.  Only the end-of-device-path
+  device node from SecondDevicePath is retained. The newly created device path is
+  returned. If FirstDevicePath is NULL, then it is ignored, and a duplicate of
+  SecondDevicePath is returned.  If SecondDevicePath is NULL, then it is ignored,
+  and a duplicate of FirstDevicePath is returned. If both FirstDevicePath and
+  SecondDevicePath are NULL, then a copy of an end-of-device-path is returned.
   If there is not enough memory for the newly allocated buffer, then NULL is returned.
   The memory for the new device path is allocated from EFI boot services memory.
+  The memory for the new device path is allocated from EFI boot services memory.
   It is the responsibility of the caller to free the memory allocated.
   @param  FirstDevicePath            A pointer to a device path data structure.
   @param  SecondDevicePath           A pointer to a device path data structure.
   @retval NULL      If there is not enough memory for the newly allocated buffer.
   @retval NULL      If FirstDevicePath or SecondDevicePath is invalid.
 …
   Creates a new path by appending the device node to the device path.
   This function creates a new device path by appending a copy of the device node
   specified by DevicePathNode to a copy of the device path specified by DevicePath
   in an allocated buffer. The end-of-device-path device node is moved after the
+  This function creates a new device path by appending a copy of the device node
+  specified by DevicePathNode to a copy of the device path specified by DevicePath
+  in an allocated buffer. The end-of-device-path device node is moved after the
   end of the appended device node.
   If DevicePathNode is NULL then a copy of DevicePath is returned.
   If DevicePath is NULL then a copy of DevicePathNode, followed by an end-of-device
+  If DevicePath is NULL then a copy of DevicePathNode, followed by an end-of-device
   path device node is returned.
   If both DevicePathNode and DevicePath are NULL then a copy of an end-of-device-path
+  If both DevicePathNode and DevicePath are NULL then a copy of an end-of-device-path
   device node is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
 …
   @retval NULL      If there is not enough memory for the new device path.
   @retval Others    A pointer to the new device path if success.
                     A copy of DevicePathNode followed by an end-of-device-path node
+                    A copy of DevicePathNode followed by an end-of-device-path node
                     if both FirstDevicePath and SecondDevicePath are NULL.
                     A copy of an end-of-device-path node if both FirstDevicePath
+                    A copy of an end-of-device-path node if both FirstDevicePath
                     and SecondDevicePath are NULL.
 …
   Creates a new device path by appending the specified device path instance to the specified device
   path.
   This function creates a new device path by appending a copy of the device path
   instance specified by DevicePathInstance to a copy of the device path specified
+  This function creates a new device path by appending a copy of the device path
+  instance specified by DevicePathInstance to a copy of the device path specified
   by DevicePath in a allocated buffer.
   The end-of-device-path device node is moved after the end of the appended device
   path instance and a new end-of-device-path-instance node is inserted between.
+  The end-of-device-path device node is moved after the end of the appended device
+  path instance and a new end-of-device-path-instance node is inserted between.
   If DevicePath is NULL, then a copy if DevicePathInstance is returned.
   If DevicePathInstance is NULL, then NULL is returned.
   If DevicePath or DevicePathInstance is invalid, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   @param  DevicePath                 A pointer to a device path data structure.
   @param  DevicePathInstance         A pointer to a device path instance.
 …
   instance.
   This function creates a copy of the current device path instance. It also updates
   DevicePath to point to the next device path instance in the device path (or NULL
+  This function creates a copy of the current device path instance. It also updates
+  DevicePath to point to the next device path instance in the device path (or NULL
   if no more) and updates Size to hold the size of the device path instance copy.
   If DevicePath is NULL, then NULL is returned.
   If DevicePath points to a invalid device path, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   If Size is NULL, then ASSERT().
   @param  DevicePath                 On input, this holds the pointer to the current
                                      device path instance. On output, this holds
                                      the pointer to the next device path instance
+  @param  DevicePath                 On input, this holds the pointer to the current
+                                     device path instance. On output, this holds
+                                     the pointer to the next device path instance
                                      or NULL if there are no more device path
                                      instances in the device path pointer to a
+                                     instances in the device path pointer to a
                                      device path data structure.
   @param  Size                       On output, this holds the size of the device
                                      path instance, in bytes or zero, if DevicePath
+  @param  Size                       On output, this holds the size of the device
+                                     path instance, in bytes or zero, if DevicePath
                                      is NULL.
 …
   Creates a device node.
   This function creates a new device node in a newly allocated buffer of size
   NodeLength and initializes the device path node header with NodeType and NodeSubType.
+  This function creates a new device node in a newly allocated buffer of size
+  NodeLength and initializes the device path node header with NodeType and NodeSubType.
   The new device path node is returned.
   If NodeLength is smaller than a device path header, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If NodeLength is smaller than a device path header, then NULL is returned.
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
 …
   @retval  TRUE                      DevicePath is multi-instance.
   @retval  FALSE                     DevicePath is not multi-instance, or DevicePath
+  @retval  FALSE                     DevicePath is not multi-instance, or DevicePath
                                      is NULL or invalid.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLib.c

-              r58459
+              r58466
 /**
   The constructor function caches the pointer to DevicePathUtilites protocol.
   The constructor function locates DevicePathUtilities protocol from protocol database.
   It will ASSERT() if that operation fails and it will always return EFI_SUCCESS.
+  It will ASSERT() if that operation fails and it will always return EFI_SUCCESS.
   @param  ImageHandle   The firmware allocated handle for the EFI image.
   @param  SystemTable   A pointer to the EFI System Table.
   @retval EFI_SUCCESS   The constructor always returns EFI_SUCCESS.
 …
   Returns the 16-bit Length field of a device path node.
   Returns the 16-bit Length field of the device path node specified by Node.
+  Returns the 16-bit Length field of the device path node specified by Node.
   Node is not required to be aligned on a 16-bit boundary, so it is recommended
   that a function such as ReadUnaligned16() be used to extract the contents of
+  that a function such as ReadUnaligned16() be used to extract the contents of
   the Length field.
 …
   Returns a pointer to the next node in a device path.
   Returns a pointer to the device path node that follows the device path node
+  Returns a pointer to the device path node that follows the device path node
   specified by Node.
 …
   @param  Node      A pointer to a device path node data structure.
   @return a pointer to the device path node that follows the device path node
+  @return a pointer to the device path node that follows the device path node
   specified by Node.
 …
 /**
   Determines if a device path node is an end node of a device path.
   This includes nodes that are the end of a device path instance and nodes that
+  This includes nodes that are the end of a device path instance and nodes that
   are the end of an entire device path.
   Determines if the device path node specified by Node is an end node of a device path.
   This includes nodes that are the end of a device path instance and nodes that are the
   end of an entire device path.  If Node represents an end node of a device path,
+  Determines if the device path node specified by Node is an end node of a device path.
+  This includes nodes that are the end of a device path instance and nodes that are the
+  end of an entire device path.  If Node represents an end node of a device path,
   then TRUE is returned.  Otherwise, FALSE is returned.
 …
   @retval TRUE      The device path node specified by Node is an end node of a device path.
   @retval FALSE     The device path node specified by Node is not an end node of
+  @retval FALSE     The device path node specified by Node is not an end node of
                     a device path.
 **/
 BOOLEAN
 …
   Determines if a device path node is an end node of an entire device path.
   Determines if a device path node specified by Node is an end node of an entire
+  Determines if a device path node specified by Node is an end node of an entire
   device path.
   If Node represents the end of an entire device path, then TRUE is returned.
+  If Node represents the end of an entire device path, then TRUE is returned.
   Otherwise, FALSE is returned.
 …
   Determines if a device path node is an end node of a device path instance.
   Determines if a device path node specified by Node is an end node of a device
+  Determines if a device path node specified by Node is an end node of a device
   path instance.
   If Node represents the end of a device path instance, then TRUE is returned.
+  If Node represents the end of a device path instance, then TRUE is returned.
   Otherwise, FALSE is returned.
 …
   @param  Node      A pointer to a device path node data structure.
   @retval TRUE      The device path node specified by Node is the end of a device
+  @retval TRUE      The device path node specified by Node is the end of a device
   path instance.
   @retval FALSE     The device path node specified by Node is not the end of a
+  @retval FALSE     The device path node specified by Node is not the end of a
   device path instance.
 …
   Sets the length, in bytes, of a device path node.
   Sets the length of the device path node specified by Node to the value specified
   by NodeLength.  NodeLength is returned.  Node is not required to be aligned on
+  Sets the length of the device path node specified by Node to the value specified
+  by NodeLength.  NodeLength is returned.  Node is not required to be aligned on
   a 16-bit boundary, so it is recommended that a function such as WriteUnaligned16()
   be used to set the contents of the Length field.
 …
   Fills in all the fields of a device path node that is the end of an entire device path.
   Fills in all the fields of a device path node specified by Node so Node represents
   the end of an entire device path.  The Type field of Node is set to
   END_DEVICE_PATH_TYPE, the SubType field of Node is set to
   END_ENTIRE_DEVICE_PATH_SUBTYPE, and the Length field of Node is set to
   END_DEVICE_PATH_LENGTH.  Node is not required to be aligned on a 16-bit boundary,
   so it is recommended that a function such as WriteUnaligned16() be used to set
   the contents of the Length field.
   If Node is NULL, then ASSERT().
+  Fills in all the fields of a device path node specified by Node so Node represents
+  the end of an entire device path.  The Type field of Node is set to
+  END_DEVICE_PATH_TYPE, the SubType field of Node is set to
+  END_ENTIRE_DEVICE_PATH_SUBTYPE, and the Length field of Node is set to
+  END_DEVICE_PATH_LENGTH.  Node is not required to be aligned on a 16-bit boundary,
+  so it is recommended that a function such as WriteUnaligned16() be used to set
+  the contents of the Length field.
+  If Node is NULL, then ASSERT().
   @param  Node      A pointer to a device path node data structure.
 …
   Returns the size of a device path in bytes.
   This function returns the size, in bytes, of the device path data structure
+  This function returns the size, in bytes, of the device path data structure
   specified by DevicePath including the end of device path node.
   If DevicePath is NULL or invalid, then 0 is returned.
 …
   Creates a new copy of an existing device path.
   This function allocates space for a new copy of the device path specified by
   DevicePath.  If DevicePath is NULL, then NULL is returned.
+  This function allocates space for a new copy of the device path specified by
+  DevicePath.  If DevicePath is NULL, then NULL is returned.
   If the memory is successfully allocated, then the
   contents of DevicePath are copied to the newly allocated buffer, and a pointer to that buffer
   is returned.  Otherwise, NULL is returned.
   The memory for the new device path is allocated from EFI boot services memory.
   It is the responsibility of the caller to free the memory allocated.
+  is returned.  Otherwise, NULL is returned.
+  The memory for the new device path is allocated from EFI boot services memory.
+  It is the responsibility of the caller to free the memory allocated.
   @param  DevicePath                 A pointer to a device path data structure.
   @retval NULL    If DevicePath is NULL or invalid.
   @retval Others  A pointer to the duplicated device path.
 **/
 EFI_DEVICE_PATH_PROTOCOL *
 …
   This function creates a new device path by appending a copy of SecondDevicePath to a copy of
   FirstDevicePath in a newly allocated buffer.  Only the end-of-device-path device node from
   SecondDevicePath is retained. The newly created device path is returned.
   If FirstDevicePath is NULL, then it is ignored, and a duplicate of SecondDevicePath is returned.
   If SecondDevicePath is NULL, then it is ignored, and a duplicate of FirstDevicePath is returned.
+  SecondDevicePath is retained. The newly created device path is returned.
+  If FirstDevicePath is NULL, then it is ignored, and a duplicate of SecondDevicePath is returned.
+  If SecondDevicePath is NULL, then it is ignored, and a duplicate of FirstDevicePath is returned.
   If both FirstDevicePath and SecondDevicePath are NULL, then a copy of an end-of-device-path is
   returned.
+  returned.
   If there is not enough memory for the newly allocated buffer, then NULL is returned.
   The memory for the new device path is allocated from EFI boot services memory. It is the
 …
   @param  FirstDevicePath            A pointer to a device path data structure.
   @param  SecondDevicePath           A pointer to a device path data structure.
   @retval NULL      If there is not enough memory for the newly allocated buffer.
   @retval NULL      If FirstDevicePath or SecondDevicePath is invalid.
   @retval Others    A pointer to the new device path if success.
                     Or a copy an end-of-device-path if both FirstDevicePath and
+                    Or a copy an end-of-device-path if both FirstDevicePath and
                     SecondDevicePath are NULL.
 …
   Creates a new path by appending the device node to the device path.
   This function creates a new device path by appending a copy of the device node
   specified by DevicePathNode to a copy of the device path specified by DevicePath
+  This function creates a new device path by appending a copy of the device node
+  specified by DevicePathNode to a copy of the device path specified by DevicePath
   in an allocated buffer.
   The end-of-device-path device node is moved after the end of the appended device node.
   If DevicePathNode is NULL then a copy of DevicePath is returned.
   If DevicePath is NULL then a copy of DevicePathNode, followed by an end-of-device
+  If DevicePath is NULL then a copy of DevicePathNode, followed by an end-of-device
   path device node is returned.
   If both DevicePathNode and DevicePath are NULL then a copy of an end-of-device-path
+  If both DevicePathNode and DevicePath are NULL then a copy of an end-of-device-path
   device node is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
 …
   @retval NULL      If there is not enough memory for the new device path.
   @retval Others    A pointer to the new device path if success.
                     A copy of DevicePathNode followed by an end-of-device-path node
+                    A copy of DevicePathNode followed by an end-of-device-path node
                     if both FirstDevicePath and SecondDevicePath are NULL.
                     A copy of an end-of-device-path node if both FirstDevicePath
+                    A copy of an end-of-device-path node if both FirstDevicePath
                     and SecondDevicePath are NULL.
 …
 /**
   Creates a new device path by appending the specified device path instance to
+  Creates a new device path by appending the specified device path instance to
   the specified device path.
   This function creates a new device path by appending a copy of the device path
   instance specified by DevicePathInstance to a copy of the device path specified
+  This function creates a new device path by appending a copy of the device path
+  instance specified by DevicePathInstance to a copy of the device path specified
   by DevicePath in a allocated buffer.
   The end-of-device-path device node is moved after the end of the appended device
   path instance and a new end-of-device-path-instance node is inserted between.
+  The end-of-device-path device node is moved after the end of the appended device
+  path instance and a new end-of-device-path-instance node is inserted between.
   If DevicePath is NULL, then a copy if DevicePathInstance is returned.
   If DevicePathInstance is NULL, then NULL is returned.
   If DevicePath or DevicePathInstance is invalid, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   @param  DevicePath                 A pointer to a device path data structure.
   @param  DevicePathInstance         A pointer to a device path instance.
 …
 /**
   Creates a copy of the current device path instance and returns a pointer to the
+  Creates a copy of the current device path instance and returns a pointer to the
   next device path instance.
   This function creates a copy of the current device path instance. It also updates
   DevicePath to point to the next device path instance in the device path (or NULL
+  This function creates a copy of the current device path instance. It also updates
+  DevicePath to point to the next device path instance in the device path (or NULL
   if no more) and updates Size to hold the size of the device path instance copy.
   If DevicePath is NULL, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
   If Size is NULL, then ASSERT().
   @param  DevicePath                 On input, this holds the pointer to the current
                                      device path instance. On output, this holds
                                      the pointer to the next device path instance
+  @param  DevicePath                 On input, this holds the pointer to the current
+                                     device path instance. On output, this holds
+                                     the pointer to the next device path instance
                                      or NULL if there are no more device path
                                      instances in the device path pointer to a
+                                     instances in the device path pointer to a
                                      device path data structure.
   @param  Size                       On output, this holds the size of the device
                                      path instance, in bytes or zero, if DevicePath
+  @param  Size                       On output, this holds the size of the device
+                                     path instance, in bytes or zero, if DevicePath
                                      is NULL.
 …
   Creates a device node.
   This function creates a new device node in a newly allocated buffer of size
   NodeLength and initializes the device path node header with NodeType and NodeSubType.
+  This function creates a new device node in a newly allocated buffer of size
+  NodeLength and initializes the device path node header with NodeType and NodeSubType.
   The new device path node is returned.
   If NodeLength is smaller than a device path header, then NULL is returned.
   If there is not enough memory to allocate space for the new device path, then
   NULL is returned.
   The memory is allocated from EFI boot services memory. It is the responsibility
+  If NodeLength is smaller than a device path header, then NULL is returned.
+  If there is not enough memory to allocate space for the new device path, then
+  NULL is returned.
+  The memory is allocated from EFI boot services memory. It is the responsibility
   of the caller to free the memory allocated.
 …
   @retval  TRUE                      DevicePath is multi-instance.
   @retval  FALSE                     DevicePath is not multi-instance, or DevicePath
+  @retval  FALSE                     DevicePath is not multi-instance, or DevicePath
                                      is NULL or invalid.
 …
   Retrieves the device path protocol from a handle.
   This function returns the device path protocol from the handle specified by Handle.
   If Handle is NULL or Handle does not contain a device path protocol, then NULL
+  This function returns the device path protocol from the handle specified by Handle.
+  If Handle is NULL or Handle does not contain a device path protocol, then NULL
   is returned.
   @param  Handle                     The handle from which to retrieve the device
+  @param  Handle                     The handle from which to retrieve the device
                                      path protocol.
 …
   Allocates a device path for a file and appends it to an existing device path.
   If Device is a valid device handle that contains a device path protocol, then
   a device path for the file specified by FileName  is allocated and appended to
   the device path associated with the handle Device.  The allocated device path
   is returned.  If Device is NULL or Device is a handle that does not support the
   device path protocol, then a device path containing a single device path node
+  If Device is a valid device handle that contains a device path protocol, then
+  a device path for the file specified by FileName  is allocated and appended to
+  the device path associated with the handle Device.  The allocated device path
+  is returned.  If Device is NULL or Device is a handle that does not support the
+  device path protocol, then a device path containing a single device path node
   for the file specified by FileName is allocated and returned.
   The memory for the new device path is allocated from EFI boot services memory.
+  The memory for the new device path is allocated from EFI boot services memory.
   It is the responsibility of the caller to free the memory allocated.
   If FileName is NULL, then ASSERT().
   If FileName is not aligned on a 16-bit boundary, then ASSERT().
   @param  Device                     A pointer to a device handle.  This parameter
+  @param  Device                     A pointer to a device handle.  This parameter
                                      is optional and may be NULL.
   @param  FileName                   A pointer to a Null-terminated Unicode string.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiDriverEntryPoint/DriverEntryPoint.c

-              r48674
+              r58466
   Unloads an image from memory.
   This function is a callback that a driver registers to do cleanup
+  This function is a callback that a driver registers to do cleanup
   when the UnloadImage boot service function is called.
 …
 /**
   The entry point of PE/COFF Image for a DXE Driver, DXE Runtime Driver, DXE SMM
   Driver, or UEFI Driver.
+  The entry point of PE/COFF Image for a DXE Driver, DXE Runtime Driver, DXE SMM
+  Driver, or UEFI Driver.
   This function is the entry point for a DXE Driver, DXE Runtime Driver, DXE SMM Driver,
   or UEFI Driver.  This function must call ProcessLibraryConstructorList() and
   ProcessModuleEntryPointList(). If the return status from ProcessModuleEntryPointList()
   is an error status, then ProcessLibraryDestructorList() must be called. The return
   value from ProcessModuleEntryPointList() is returned. If _gDriverUnloadImageCount
   is greater than zero, then an unload handler must be registered for this image
+  is an error status, then ProcessLibraryDestructorList() must be called. The return
+  value from ProcessModuleEntryPointList() is returned. If _gDriverUnloadImageCount
+  is greater than zero, then an unload handler must be registered for this image
   and the unload handler must invoke ProcessModuleUnloadList().
   If _gUefiDriverRevision is not zero and SystemTable->Hdr.Revision is less than
+  If _gUefiDriverRevision is not zero and SystemTable->Hdr.Revision is less than
   _gUefiDriverRevison, then return EFI_INCOMPATIBLE_VERSION.
   @param  ImageHandle  The image handle of the DXE Driver, DXE Runtime Driver,
+  @param  ImageHandle  The image handle of the DXE Driver, DXE Runtime Driver,
                        DXE SMM Driver, or UEFI Driver.
   @param  SystemTable  A pointer to the EFI System Table.
   @retval  EFI_SUCCESS               The DXE Driver, DXE Runtime Driver, DXE SMM
+  @retval  EFI_SUCCESS               The DXE Driver, DXE Runtime Driver, DXE SMM
                                      Driver, or UEFI Driver exited normally.
   @retval  EFI_INCOMPATIBLE_VERSION  _gUefiDriverRevision is greater than
+  @retval  EFI_INCOMPATIBLE_VERSION  _gUefiDriverRevision is greater than
                                     SystemTable->Hdr.Revision.
   @retval  Other                     Return value from ProcessModuleEntryPointList().
 …
 /**
   Required by the EBC compiler and identical in functionality to _ModuleEntryPoint().
+  Required by the EBC compiler and identical in functionality to _ModuleEntryPoint().
   This function is required to call _ModuleEntryPoint() passing in ImageHandle,
   and SystemTable.
   @param  ImageHandle  The image handle of the DXE Driver, DXE Runtime Driver, DXE
+  @param  ImageHandle  The image handle of the DXE Driver, DXE Runtime Driver, DXE
                        SMM Driver, or UEFI Driver.
   @param  SystemTable  A pointer to the EFI System Table.
   @retval  EFI_SUCCESS               The DXE Driver, DXE Runtime Driver, DXE SMM
+  @retval  EFI_SUCCESS               The DXE Driver, DXE Runtime Driver, DXE SMM
                                      Driver, or UEFI Driver exited normally.
   @retval  EFI_INCOMPATIBLE_VERSION  _gUefiDriverRevision is greater than
+  @retval  EFI_INCOMPATIBLE_VERSION  _gUefiDriverRevision is greater than
                                      SystemTable->Hdr.Revision.
   @retval  Other                     Return value from ProcessModuleEntryPointList().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiLib/Console.c

-              r58459
+              r58466
   Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
   {(CHAR16)0x1FFF,  1},
   /*
    * Merge the blocks and replace them with the above entry as they fall to
+   * Merge the blocks and replace them with the above entry as they fall to
    * the same category and they are all narrow glyph. This will reduce search
    * time and table size. The merge will omit the reserved code.
 …
   {(CHAR16)0x2FFF,  1},
   /*
    * Merge the blocks and replace them with the above entry as they fall to
+   * Merge the blocks and replace them with the above entry as they fall to
    * the same category and they are all narrow glyph. This will reduce search
    * time and table size. The merge will omit the reserved code.
 …
   {(CHAR16)0x33FF,  2},
   /*
    * Merge the blocks and replace them with the above entry as they fall to
+   * Merge the blocks and replace them with the above entry as they fall to
    * the same category and they are all wide glyph. This will reduce search
    * time and table size. The merge will omit the reserved code.
 …
   {(CHAR16)0x9FFF,  2},
   /*
    * Merge the blocks and replace them with the above entry as they fall to
+   * Merge the blocks and replace them with the above entry as they fall to
    * the same category and they are all wide glyph. This will reduce search
    * time and table size. The merge will omit the reserved code.
 …
    * Remove the above item if below is un-commented.
+   *
   {(CHAR16)0x4DFF,  0},       // Reserved. 0x3400-0x4DBF as CJK unified ideographs
+  {(CHAR16)0x4DFF,  0},       // Reserved. 0x3400-0x4DBF as CJK unified ideographs
                       // extension A in ver3.0. 0x3400-0x4DFF
   {(CHAR16)0x9FFF,  2},       // CJK unified ideographs. 0x4E00-0x9FFF
 …
   {(CHAR16)0xD7FF,  2},
   /*
    * Merge the blocks and replace them with the above entry as they fall to
+   * Merge the blocks and replace them with the above entry as they fall to
    * the same category and they are all wide glyph. This will reduce search
    * time and table size. The merge will omit the reserved code.
 …
   Computes the display length of a Null-terminated Unicode String.
   This function computes and returns the display length of the Null-terminated
   Unicode string specified by String.  If String is NULL then 0 is returned. If
   any of the widths of the Unicode characters in String can not be determined,
   then 0 is returned. The display width of String can be computed by summing the
   display widths of each Unicode character in String.  Unicode characters that
   are narrow glyphs have a width of 1, and Unicode characters that are width glyphs
+  This function computes and returns the display length of the Null-terminated
+  Unicode string specified by String.  If String is NULL then 0 is returned. If
+  any of the widths of the Unicode characters in String can not be determined,
+  then 0 is returned. The display width of String can be computed by summing the
+  display widths of each Unicode character in String.  Unicode characters that
+  are narrow glyphs have a width of 1, and Unicode characters that are width glyphs
   have a width of 2.  If String is not aligned on a 16-bit boundary, then ASSERT().
 …
   @return The display length of the Null-terminated Unicode string specified by String.
 **/
 UINTN
 …
 /**
   Count the storage space of a Unicode string.
+  Count the storage space of a Unicode string.
   This function handles the Unicode string with NARROW_CHAR
 …
   @param LimitLen        Whether need to limit the string length.
   @param MaxWidth        The max length this function supported.
   @param Offset          The max index of the string can be show out.
+  @param Offset          The max index of the string can be show out.
   @return Storage space for the input string.
 …
 /**
   Draws a dialog box to the console output device specified by
+  Draws a dialog box to the console output device specified by
   ConOut defined in the EFI_SYSTEM_TABLE and waits for a keystroke
   from the console input device specified by ConIn defined in the
+  from the console input device specified by ConIn defined in the
   EFI_SYSTEM_TABLE.
 …
   @param[in]   Attribute  Specifies the foreground and background color of the popup.
   @param[out]  Key        A pointer to the EFI_KEY value of the key that was
+  @param[out]  Key        A pointer to the EFI_KEY value of the key that was
                           pressed.  This is an optional parameter that may be NULL.
                           If it is NULL then no wait for a keypress will be performed.
   @param[in]  ...         The variable argument list that contains pointers to Null-
                           terminated Unicode strings to display in the dialog box.
+                          terminated Unicode strings to display in the dialog box.
                           The variable argument list is terminated by a NULL.
 …
 EFIAPI
 CreatePopUp (
   IN  UINTN          Attribute,
+  IN  UINTN          Attribute,
   OUT EFI_INPUT_KEY  *Key,      OPTIONAL
   ...
 …
   //
   // Determine the length of the longest line in the popup and the the total
+  // Determine the length of the longest line in the popup and the the total
   // number of lines in the popup
   //
 …
   //
   ConOut = gST->ConOut;
   //
   // Save the current console cursor position and attributes
 …
   //
   // Draw top of popup box
+  // Draw top of popup box
   //
   SetMem16 (Line, (MaxLength + 2) * 2, BOXDRAW_HORIZONTAL);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiLib/UefiDriverModel.c

-              r58459
+              r58466
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
+**/
 …
 /**
   Installs and completes the initialization of a Driver Binding Protocol instance.
   Installs the Driver Binding Protocol specified by DriverBinding onto the handle
   specified by DriverBindingHandle. If DriverBindingHandle is NULL, then DriverBinding
   is installed onto a newly created handle. DriverBindingHandle is typically the same
   as the driver's ImageHandle, but it can be different if the driver produces multiple
   Driver Binding Protocols.
   If DriverBinding is NULL, then ASSERT().
+  Driver Binding Protocols.
+  If DriverBinding is NULL, then ASSERT().
   If DriverBinding can not be installed onto a handle, then ASSERT().
 …
   then the protocols are  installed onto a newly created handle. DriverBindingHandle
   is typically the same as the driver's ImageHandle, but it can be different if the
   driver produces multiple Driver Binding Protocols.
   If DriverBinding is NULL, then ASSERT().
+  driver produces multiple Driver Binding Protocols.
+  If DriverBinding is NULL, then ASSERT().
   If the installation fails, then ASSERT().
   @param  ImageHandle          The image handle of the driver.
   @param  SystemTable          The EFI System Table that was passed to the driver's entry point.
 …
   DriverBinding->ImageHandle         = ImageHandle;
   DriverBinding->DriverBindingHandle = DriverBindingHandle;
   if (DriverDiagnostics == NULL || FeaturePcdGet(PcdDriverDiagnosticsDisable)) {
     if (DriverConfiguration == NULL) {
 …
   DriverBindingHandle.  If DriverBindingHandle is NULL, then the protocols are installed
   onto a newly created handle.  DriverBindingHandle is typically the same as the driver's
   ImageHandle, but it can be different if the driver produces multiple Driver Binding Protocols.
   If DriverBinding is NULL, then ASSERT().
+  ImageHandle, but it can be different if the driver produces multiple Driver Binding Protocols.
+  If DriverBinding is NULL, then ASSERT().
   If the installation fails, then ASSERT().
 …
   optional Driver Diagnostic, and optional Driver Diagnostic 2 Protocols onto the driver's DriverBindingHandle.
   DriverBindingHandle is typically the same as the driver's ImageHandle, but it can be different if the driver
   produces multiple Driver Binding Protocols.
   If DriverBinding is NULL, then ASSERT().
+  produces multiple Driver Binding Protocols.
+  If DriverBinding is NULL, then ASSERT().
   If the installation fails, then ASSERT().
 …
   EFI_STATUS  Status;
   ASSERT (DriverBinding != NULL);
+  ASSERT (DriverBinding != NULL);
   //
 …
   DriverBinding->ImageHandle         = ImageHandle;
   DriverBinding->DriverBindingHandle = DriverBindingHandle;
   if (DriverConfiguration2 == NULL) {
     if (DriverConfiguration == NULL) {

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiLib/UefiLib.c

-              r58459
+              r58466
 /** @file
   The UEFI Library provides functions and macros that simplify the development of
   UEFI Drivers and UEFI Applications.  These functions and macros help manage EFI
   events, build simple locks utilizing EFI Task Priority Levels (TPLs), install
   EFI Driver Model related protocols, manage Unicode string tables for UEFI Drivers,
+  The UEFI Library provides functions and macros that simplify the development of
+  UEFI Drivers and UEFI Applications.  These functions and macros help manage EFI
+  events, build simple locks utilizing EFI Task Priority Levels (TPLs), install
+  EFI Driver Model related protocols, manage Unicode string tables for UEFI Drivers,
   and print messages on the console output and standard error devices.
 …
 /**
   Empty constructor function that is required to resolve dependencies between
+  Empty constructor function that is required to resolve dependencies between
   libraries.
     ** DO NOT REMOVE **
   @param  ImageHandle   The firmware allocated handle for the EFI image.
   @param  SystemTable   A pointer to the EFI System Table.
   @retval EFI_SUCCESS   The constructor executed correctly.
 …
   Retrieves a pointer to the system configuration table from the EFI System Table
   based on a specified GUID.
   This function searches the list of configuration tables stored in the EFI System Table
   for a table with a GUID that matches TableGuid.  If a match is found, then a pointer to
 …
   then the notification function is still executed one time. In addition, every time a protocol
   of type ProtocolGuid instance is installed or reinstalled, the notification function is also
   executed. This function returns the notification event that was created.
+  executed. This function returns the notification event that was created.
   If ProtocolGuid is NULL, then ASSERT().
   If NotifyTpl is not a legal TPL value, then ASSERT().
 …
   @param  Registration    A pointer to a memory location to receive the registration value.
                           This value is passed to LocateHandle() to obtain new handles that
                           have been added that support the ProtocolGuid-specified protocol.
+                          have been added that support the ProtocolGuid-specified protocol.
   @return The notification event that was created.
 …
   This function creates an event using NotifyTpl, NoifyFunction, and NotifyContext.
   This event is signaled with EfiNamedEventSignal(). This provides the ability for one or more
   listeners on the same event named by the GUID specified by Name.
+  listeners on the same event named by the GUID specified by Name.
   If Name is NULL, then ASSERT().
   If NotifyTpl is not a legal TPL value, then ASSERT().
 …
   @param  NotifyTpl             Supplies the task priority level of the event notifications.
   @param  NotifyFunction        Supplies the function to notify when the event is signaled.
   @param  NotifyContext         The context parameter to pass to NotifyFunction.
+  @param  NotifyContext         The context parameter to pass to NotifyFunction.
   @param  Registration          A pointer to a memory location to receive the registration value.
 …
   ASSERT (NotifyFunction != NULL);
   ASSERT (NotifyTpl <= TPL_HIGH_LEVEL);
   //
   // Create event
 …
+}
 /**
+/**
   Returns the current TPL.
   This function returns the current TPL.  There is no EFI service to directly
   retrieve the current TPL. Instead, the RaiseTPL() function is used to raise
   the TPL to TPL_HIGH_LEVEL.  This will return the current TPL.  The TPL level
   can then immediately be restored back to the current TPL level with a call
+  This function returns the current TPL.  There is no EFI service to directly
+  retrieve the current TPL. Instead, the RaiseTPL() function is used to raise
+  the TPL to TPL_HIGH_LEVEL.  This will return the current TPL.  The TPL level
+  can then immediately be restored back to the current TPL level with a call
   to RestoreTPL().
 …
   Initializes a basic mutual exclusion lock.
   This function initializes a basic mutual exclusion lock to the released state
   and returns the lock.  Each lock provides mutual exclusion access at its task
+  This function initializes a basic mutual exclusion lock to the released state
+  and returns the lock.  Each lock provides mutual exclusion access at its task
   priority level.  Since there is no preemption or multiprocessor support in EFI,
   acquiring the lock only consists of raising to the locks TPL.
 …
   Acquires ownership of a lock.
   This function raises the system's current task priority level to the task
   priority level of the mutual exclusion lock.  Then, it places the lock in the
+  This function raises the system's current task priority level to the task
+  priority level of the mutual exclusion lock.  Then, it places the lock in the
   acquired state.
   If Lock is NULL, then ASSERT().
 …
   Releases ownership of a lock.
   This function transitions a mutual exclusion lock from the acquired state to
   the released state, and restores the system's task priority level to its
+  This function transitions a mutual exclusion lock from the acquired state to
+  the released state, and restores the system's task priority level to its
   previous level.
   If Lock is NULL, then ASSERT().
 …
   is performed by evaluating if the the protocol specified by ProtocolGuid is
   present on ControllerHandle and is was opened by DriverBindingHandle with an
   attribute of EFI_OPEN_PROTOCOL_BY_DRIVER.
+  attribute of EFI_OPEN_PROTOCOL_BY_DRIVER.
   If ProtocolGuid is NULL, then ASSERT().
 …
   If ProtocolGuid is NULL, then ASSERT().
   @param  ControllerHandle     A handle for a (parent) controller to test.
+  @param  ControllerHandle     A handle for a (parent) controller to test.
   @param  ChildHandle          A child handle to test.
   @param  ProtocolGuid         Supplies the protocol that the child controller
                                opens on its parent controller.
+                               opens on its parent controller.
   @retval EFI_SUCCESS          ChildHandle is a child of the ControllerHandle.
 …
   is returned in UnicodeString.
   @param  Language                A pointer to the ISO 639-2 language code for the
+  @param  Language                A pointer to the ISO 639-2 language code for the
                                   Unicode string to look up and return.
   @param  SupportedLanguages      A pointer to the set of ISO 639-2 language codes
                                   that the Unicode string table supports.  Language
+  @param  SupportedLanguages      A pointer to the set of ISO 639-2 language codes
+                                  that the Unicode string table supports.  Language
                                   must be a member of this set.
   @param  UnicodeStringTable      A pointer to the table of Unicode strings.
 …
                                   that matches the language specified by Language.
   @retval EFI_SUCCESS             The Unicode string that matches the language
+  @retval EFI_SUCCESS             The Unicode string that matches the language
                                   specified by Language was found
                                   in the table of Unicode strings UnicodeStringTable,
+                                  in the table of Unicode strings UnicodeStringTable,
                                   and it was returned in UnicodeString.
   @retval EFI_INVALID_PARAMETER   Language is NULL.
 …
   @retval EFI_UNSUPPORTED         SupportedLanguages is NULL.
   @retval EFI_UNSUPPORTED         UnicodeStringTable is NULL.
   @retval EFI_UNSUPPORTED         The language specified by Language is not a
+  @retval EFI_UNSUPPORTED         The language specified by Language is not a
                                   member of SupportedLanguages.
   @retval EFI_UNSUPPORTED         The language specified by Language is not
+  @retval EFI_UNSUPPORTED         The language specified by Language is not
                                   supported by UnicodeStringTable.
 …
                                not assumed to be Null-terminated, and only the first three
                                characters are used. If Iso639Language is FALSE, then this ASCII
                                string must be Null-terminated.
+                               string must be Null-terminated.
   @param  SupportedLanguages   A pointer to a Null-terminated ASCII string that contains a
                                set of ISO 639-2 or RFC 4646 language codes that the Unicode
 …
                                   was found in the table of Unicode strings UnicodeStringTable, and
                                   it was returned in UnicodeString.
   @retval  EFI_INVALID_PARAMETER  Language is NULL.
   @retval  EFI_INVALID_PARAMETER  UnicodeString is NULL.
   @retval  EFI_UNSUPPORTED        SupportedLanguages is NULL.
   @retval  EFI_UNSUPPORTED        UnicodeStringTable is NULL.
   @retval  EFI_UNSUPPORTED        The language specified by Language is not a member of SupportedLanguages.
+  @retval  EFI_INVALID_PARAMETER  Language is NULL.
+  @retval  EFI_INVALID_PARAMETER  UnicodeString is NULL.
+  @retval  EFI_UNSUPPORTED        SupportedLanguages is NULL.
+  @retval  EFI_UNSUPPORTED        UnicodeStringTable is NULL.
+  @retval  EFI_UNSUPPORTED        The language specified by Language is not a member of SupportedLanguages.
   @retval  EFI_UNSUPPORTED        The language specified by Language is not supported by UnicodeStringTable.
 …
   This function adds a Unicode string to UnicodeStringTable.
   If Language is a member of SupportedLanguages then UnicodeString is added to
   UnicodeStringTable.  New buffers are allocated for both Language and
   UnicodeString.  The contents of Language and UnicodeString are copied into
   these new buffers.  These buffers are automatically freed when
+  If Language is a member of SupportedLanguages then UnicodeString is added to
+  UnicodeStringTable.  New buffers are allocated for both Language and
+  UnicodeString.  The contents of Language and UnicodeString are copied into
+  these new buffers.  These buffers are automatically freed when
   FreeUnicodeStringTable() is called.
   @param  Language                A pointer to the ISO 639-2 language code for the Unicode
+  @param  Language                A pointer to the ISO 639-2 language code for the Unicode
                                   string to add.
   @param  SupportedLanguages      A pointer to the set of ISO 639-2 language codes
 …
   @param  UnicodeString           A pointer to the Unicode string to add.
   @retval EFI_SUCCESS             The Unicode string that matches the language
                                   specified by Language was found in the table of
                                   Unicode strings UnicodeStringTable, and it was
+  @retval EFI_SUCCESS             The Unicode string that matches the language
+                                  specified by Language was found in the table of
+                                  Unicode strings UnicodeStringTable, and it was
                                   returned in UnicodeString.
   @retval EFI_INVALID_PARAMETER   Language is NULL.
 …
   @retval EFI_INVALID_PARAMETER   UnicodeString is an empty string.
   @retval EFI_UNSUPPORTED         SupportedLanguages is NULL.
   @retval EFI_ALREADY_STARTED     A Unicode string with language Language is
+  @retval EFI_ALREADY_STARTED     A Unicode string with language Language is
                                   already present in UnicodeStringTable.
   @retval EFI_OUT_OF_RESOURCES    There is not enough memory to add another
+  @retval EFI_OUT_OF_RESOURCES    There is not enough memory to add another
                                   Unicode string to UnicodeStringTable.
   @retval EFI_UNSUPPORTED         The language specified by Language is not a
+  @retval EFI_UNSUPPORTED         The language specified by Language is not a
                                   member of SupportedLanguages.
 …
   @param  UnicodeStringTable  A pointer to the table of Unicode strings. Type EFI_UNICODE_STRING_TABLE
                               is defined in "Related Definitions".
   @param  UnicodeString       A pointer to the Unicode string to add.
+  @param  UnicodeString       A pointer to the Unicode string to add.
   @param  Iso639Language      Specifies the supported language code format. If it is TRUE,
                               then Language and SupportedLanguages follow ISO 639-2 language code format.
 …
   @retval EFI_SUCCESS            The Unicode string that matches the language specified by
                                  Language was found in the table of Unicode strings UnicodeStringTable,
                                  and it was returned in UnicodeString.
   @retval EFI_INVALID_PARAMETER  Language is NULL.
   @retval EFI_INVALID_PARAMETER  UnicodeString is NULL.
   @retval EFI_INVALID_PARAMETER  UnicodeString is an empty string.
   @retval EFI_UNSUPPORTED        SupportedLanguages is NULL.
+                                 and it was returned in UnicodeString.
+  @retval EFI_INVALID_PARAMETER  Language is NULL.
+  @retval EFI_INVALID_PARAMETER  UnicodeString is NULL.
+  @retval EFI_INVALID_PARAMETER  UnicodeString is an empty string.
+  @retval EFI_UNSUPPORTED        SupportedLanguages is NULL.
   @retval EFI_ALREADY_STARTED    A Unicode string with language Language is already present in
                                  UnicodeStringTable.
   @retval EFI_OUT_OF_RESOURCES   There is not enough memory to add another Unicode string UnicodeStringTable.
+                                 UnicodeStringTable.
+  @retval EFI_OUT_OF_RESOURCES   There is not enough memory to add another Unicode string UnicodeStringTable.
   @retval EFI_UNSUPPORTED        The language specified by Language is not a member of SupportedLanguages.
 …
         for (Index = 0; LanguageString[Index] != 0 && LanguageString[Index] != ';'; Index++);
         if (AsciiStrnCmp (Language, LanguageString, Index) == 0) {
+        if (AsciiStrnCmp (Language, LanguageString, Index) == 0) {
           return EFI_ALREADY_STARTED;
+        }
 …
   If UnicodeStringTable is NULL, then EFI_SUCCESS is returned.
   Otherwise, each language code, and each Unicode string in the Unicode string
+  Otherwise, each language code, and each Unicode string in the Unicode string
   table are freed, and EFI_SUCCESS is returned.
 …
   [ATTENTION] This function will be deprecated for security reason.
   Returns a pointer to an allocated buffer that contains the contents of a
   variable retrieved through the UEFI Runtime Service GetVariable().  The
+  Returns a pointer to an allocated buffer that contains the contents of a
+  variable retrieved through the UEFI Runtime Service GetVariable().  The
   returned buffer is allocated using AllocatePool().  The caller is responsible
   for freeing this buffer with FreePool().
 …
   [ATTENTION] This function will be deprecated for security reason.
   Returns a pointer to an allocated buffer that contains the contents of a
   variable retrieved through the UEFI Runtime Service GetVariable().  This
+  Returns a pointer to an allocated buffer that contains the contents of a
+  variable retrieved through the UEFI Runtime Service GetVariable().  This
   function always uses the EFI_GLOBAL_VARIABLE GUID to retrieve variables.
   The returned buffer is allocated using AllocatePool().  The caller is
+  The returned buffer is allocated using AllocatePool().  The caller is
   responsible for freeing this buffer with FreePool().
 …
 /**
   Returns the status whether get the variable success. The function retrieves
   variable  through the UEFI Runtime Service GetVariable().  The
+  Returns the status whether get the variable success. The function retrieves
+  variable  through the UEFI Runtime Service GetVariable().  The
   returned buffer is allocated using AllocatePool().  The caller is responsible
   for freeing this buffer with FreePool().
 …
     *Size  = 0;
+  }
   Status = gRT->GetVariable ((CHAR16 *) Name, (EFI_GUID *) Guid, NULL, &BufferSize, *Value);
   if (Status != EFI_BUFFER_TOO_SMALL) {
 …
 /**
   Returns a pointer to an allocated buffer that contains the contents of a
   variable retrieved through the UEFI Runtime Service GetVariable().  This
+  Returns a pointer to an allocated buffer that contains the contents of a
+  variable retrieved through the UEFI Runtime Service GetVariable().  This
   function always uses the EFI_GLOBAL_VARIABLE GUID to retrieve variables.
   The returned buffer is allocated using AllocatePool().  The caller is
+  The returned buffer is allocated using AllocatePool().  The caller is
   responsible for freeing this buffer with FreePool().
 …
 /**
   Returns a pointer to an allocated buffer that contains the best matching language
   from a set of supported languages.
   This function supports both ISO 639-2 and RFC 4646 language codes, but language
   code types may not be mixed in a single call to this function.  The language
   code returned is allocated using AllocatePool().  The caller is responsible for
+  Returns a pointer to an allocated buffer that contains the best matching language
+  from a set of supported languages.
+  This function supports both ISO 639-2 and RFC 4646 language codes, but language
+  code types may not be mixed in a single call to this function.  The language
+  code returned is allocated using AllocatePool().  The caller is responsible for
   freeing the allocated buffer using FreePool().  This function supports a variable
   argument list that allows the caller to pass in a prioritized list of language
   codes to test against all the language codes in SupportedLanguages.
+  argument list that allows the caller to pass in a prioritized list of language
+  codes to test against all the language codes in SupportedLanguages.
   If SupportedLanguages is NULL, then ASSERT().
   @param[in]  SupportedLanguages  A pointer to a Null-terminated ASCII string that
                                   contains a set of language codes in the format
+                                  contains a set of language codes in the format
                                   specified by Iso639Language.
   @param[in]  Iso639Language      If TRUE, then all language codes are assumed to be
                                   in ISO 639-2 format.  If FALSE, then all language
                                   codes are assumed to be in RFC 4646 language format
   @param[in]  ...                 A variable argument list that contains pointers to
+  @param[in]  ...                 A variable argument list that contains pointers to
                                   Null-terminated ASCII strings that contain one or more
                                   language codes in the format specified by Iso639Language.
                                   The first language code from each of these language
                                   code lists is used to determine if it is an exact or
                                   close match to any of the language codes in
+                                  close match to any of the language codes in
                                   SupportedLanguages.  Close matches only apply to RFC 4646
                                   language codes, and the matching algorithm from RFC 4647
                                   is used to determine if a close match is present.  If
+                                  is used to determine if a close match is present.  If
                                   an exact or close match is found, then the matching
                                   language code from SupportedLanguages is returned.  If
                                   no matches are found, then the next variable argument
                                   parameter is evaluated.  The variable argument list
+                                  parameter is evaluated.  The variable argument list
                                   is terminated by a NULL.
   @retval NULL   The best matching language could not be found in SupportedLanguages.
   @retval NULL   There are not enough resources available to return the best matching
+  @retval NULL   There are not enough resources available to return the best matching
                  language.
   @retval Other  A pointer to a Null-terminated ASCII string that is the best matching
+  @retval Other  A pointer to a Null-terminated ASCII string that is the best matching
                  language in SupportedLanguages.
 …
 EFIAPI
 GetBestLanguage (
   IN CONST CHAR8  *SupportedLanguages,
+  IN CONST CHAR8  *SupportedLanguages,
   IN BOOLEAN      Iso639Language,
   ...
 …
       } else {
         //
         // If RFC 4646 mode, then trim Language from the right to the next '-' character
+        // If RFC 4646 mode, then trim Language from the right to the next '-' character
         //
         for (LanguageLength--; LanguageLength > 0 && Language[LanguageLength] != '-'; LanguageLength--);
 …
   //
   // No matches were found
+  // No matches were found
   //
   return NULL;

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiLib/UefiLib.inf

-              r58459
+              r58466
 # Instance of UEFI Library.
+#
 # The UEFI Library provides functions and macros that simplify the development of
 #  UEFI Drivers and UEFI Applications.  These functions and macros help manage EFI
 #  events, build simple locks utilizing EFI Task Priority Levels (TPLs), install
 #  EFI Driver Model related protocols, manage Unicode string tables for UEFI Drivers,
+# The UEFI Library provides functions and macros that simplify the development of
+#  UEFI Drivers and UEFI Applications.  These functions and macros help manage EFI
+#  events, build simple locks utilizing EFI Task Priority Levels (TPLs), install
+#  EFI Driver Model related protocols, manage Unicode string tables for UEFI Drivers,
 #  and print messages on the console output and standard error devices.
+#
 …
   DevicePathLib
   UefiRuntimeServicesTableLib
 [Guids]
   gEfiEventReadyToBootGuid                      ## SOMETIMES_CONSUMES  ## Event

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiLib/UefiLibPrint.c

-              r48674
+              r58466
+}
 /**
   Prints a formatted Unicode string to the console output device specified by
+/**
+  Prints a formatted Unicode string to the console output device specified by
   ConOut defined in the EFI_SYSTEM_TABLE.
   This function prints a formatted Unicode string to the console output device
   specified by ConOut in EFI_SYSTEM_TABLE and returns the number of Unicode
   characters that printed to ConOut.  If the length of the formatted Unicode
   string is greater than PcdUefiLibMaxPrintBufferSize, then only the first
+  This function prints a formatted Unicode string to the console output device
+  specified by ConOut in EFI_SYSTEM_TABLE and returns the number of Unicode
+  characters that printed to ConOut.  If the length of the formatted Unicode
+  string is greater than PcdUefiLibMaxPrintBufferSize, then only the first
   PcdUefiLibMaxPrintBufferSize characters are sent to ConOut.
   If Format is NULL, then ASSERT().
 …
   @param Format   A Null-terminated Unicode format string.
   @param ...      A Variable argument list whose contents are accessed based
+  @param ...      A Variable argument list whose contents are accessed based
                   on the format string specified by Format.
   @return The number of Unicode characters printed to ConOut.
 …
+}
 /**
   Prints a formatted Unicode string to the console output device specified by
+/**
+  Prints a formatted Unicode string to the console output device specified by
   StdErr defined in the EFI_SYSTEM_TABLE.
   This function prints a formatted Unicode string to the console output device
   specified by StdErr in EFI_SYSTEM_TABLE and returns the number of Unicode
   characters that printed to StdErr.  If the length of the formatted Unicode
   string is greater than PcdUefiLibMaxPrintBufferSize, then only the first
+  This function prints a formatted Unicode string to the console output device
+  specified by StdErr in EFI_SYSTEM_TABLE and returns the number of Unicode
+  characters that printed to StdErr.  If the length of the formatted Unicode
+  string is greater than PcdUefiLibMaxPrintBufferSize, then only the first
   PcdUefiLibMaxPrintBufferSize characters are sent to StdErr.
   If Format is NULL, then ASSERT().
 …
   @param Format   A Null-terminated Unicode format string.
   @param ...      Variable argument list whose contents are accessed based
+  @param ...      Variable argument list whose contents are accessed based
                   on the format string specified by Format.
   @return The number of Unicode characters printed to StdErr.
 …
+}
 /**
   Prints a formatted ASCII string to the console output device specified by
+/**
+  Prints a formatted ASCII string to the console output device specified by
   ConOut defined in the EFI_SYSTEM_TABLE.
   This function prints a formatted ASCII string to the console output device
   specified by ConOut in EFI_SYSTEM_TABLE and returns the number of ASCII
   characters that printed to ConOut.  If the length of the formatted ASCII
   string is greater than PcdUefiLibMaxPrintBufferSize, then only the first
+  This function prints a formatted ASCII string to the console output device
+  specified by ConOut in EFI_SYSTEM_TABLE and returns the number of ASCII
+  characters that printed to ConOut.  If the length of the formatted ASCII
+  string is greater than PcdUefiLibMaxPrintBufferSize, then only the first
   PcdUefiLibMaxPrintBufferSize characters are sent to ConOut.
   If Format is NULL, then ASSERT().
 …
   @param Format   A Null-terminated ASCII format string.
   @param ...      Variable argument list whose contents are accessed based
+  @param ...      Variable argument list whose contents are accessed based
                   on the format string specified by Format.
   @return The number of ASCII characters printed to ConOut.
 …
+}
 /**
   Prints a formatted ASCII string to the console output device specified by
+/**
+  Prints a formatted ASCII string to the console output device specified by
   StdErr defined in the EFI_SYSTEM_TABLE.
   This function prints a formatted ASCII string to the console output device
   specified by StdErr in EFI_SYSTEM_TABLE and returns the number of ASCII
   characters that printed to StdErr.  If the length of the formatted ASCII
   string is greater than PcdUefiLibMaxPrintBufferSize, then only the first
+  This function prints a formatted ASCII string to the console output device
+  specified by StdErr in EFI_SYSTEM_TABLE and returns the number of ASCII
+  characters that printed to StdErr.  If the length of the formatted ASCII
+  string is greater than PcdUefiLibMaxPrintBufferSize, then only the first
   PcdUefiLibMaxPrintBufferSize characters are sent to StdErr.
   If Format is NULL, then ASSERT().
 …
   @param Format   A Null-terminated ASCII format string.
   @param ...      Variable argument list whose contents are accessed based
+  @param ...      Variable argument list whose contents are accessed based
                   on the format string specified by Format.
   @return The number of ASCII characters printed to ConErr.
 …
   ConsoleHandle = gST->ConsoleOutHandle;
   ASSERT( ConsoleHandle != NULL);
 …
 /**
   Prints a formatted Unicode string to a graphics console device specified by
+  Prints a formatted Unicode string to a graphics console device specified by
   ConsoleOutputHandle defined in the EFI_SYSTEM_TABLE at the given (X,Y) coordinates.
   This function prints a formatted Unicode string to the graphics console device
   specified by ConsoleOutputHandle in EFI_SYSTEM_TABLE and returns the number of
   Unicode characters displayed, not including partial characters that may be clipped
+  This function prints a formatted Unicode string to the graphics console device
+  specified by ConsoleOutputHandle in EFI_SYSTEM_TABLE and returns the number of
+  Unicode characters displayed, not including partial characters that may be clipped
   by the right edge of the display.  If the length of the formatted Unicode string is
   greater than PcdUefiLibMaxPrintBufferSize, then at most the first
+  greater than PcdUefiLibMaxPrintBufferSize, then at most the first
   PcdUefiLibMaxPrintBufferSize characters are printed.The EFI_HII_FONT_PROTOCOL
   StringToImage() service is used to convert the string to a bitmap using the glyphs
   registered with the HII database. No wrapping is performed, so any portions of the
   string the fall outside the active display region will not be displayed. Please see
+  StringToImage() service is used to convert the string to a bitmap using the glyphs
+  registered with the HII database. No wrapping is performed, so any portions of the
+  string the fall outside the active display region will not be displayed. Please see
   Section 27.2.6 of the UEFI Specification for a description of the supported string
   format including the set of control codes supported by the StringToImage() service.
   If a graphics console device is not associated with the ConsoleOutputHandle
+  If a graphics console device is not associated with the ConsoleOutputHandle
   defined in the EFI_SYSTEM_TABLE then no string is printed, and 0 is returned.
   If the EFI_HII_FONT_PROTOCOL is not present in the handle database, then no
+  If the EFI_HII_FONT_PROTOCOL is not present in the handle database, then no
   string is printed, and 0 is returned.
   If Format is NULL, then ASSERT().
 …
                        in the EFI_SYSTEM_TABLE is used.
   @param  BackGround   The background color of the string being printed.  This is
                        an optional parameter that may be NULL.  If it is NULL,
+                       an optional parameter that may be NULL.  If it is NULL,
                        then the background color of the current ConOut device
                        in the EFI_SYSTEM_TABLE is used.
   @param  Format       A Null-terminated Unicode format string.  See Print Library
+  @param  Format       A Null-terminated Unicode format string.  See Print Library
                        for the supported format string syntax.
   @param  ...          A Variable argument list whose contents are accessed based on
                        the format string specified by Format.
+  @param  ...          A Variable argument list whose contents are accessed based on
+                       the format string specified by Format.
   @return  The number of Unicode characters printed.
 …
 /**
   Prints a formatted ASCII string to a graphics console device specified by
+  Prints a formatted ASCII string to a graphics console device specified by
   ConsoleOutputHandle defined in the EFI_SYSTEM_TABLE at the given (X,Y) coordinates.
   This function prints a formatted ASCII string to the graphics console device
   specified by ConsoleOutputHandle in EFI_SYSTEM_TABLE and returns the number of
   ASCII characters displayed, not including partial characters that may be clipped
+  This function prints a formatted ASCII string to the graphics console device
+  specified by ConsoleOutputHandle in EFI_SYSTEM_TABLE and returns the number of
+  ASCII characters displayed, not including partial characters that may be clipped
   by the right edge of the display.  If the length of the formatted ASCII string is
   greater than PcdUefiLibMaxPrintBufferSize, then at most the first
+  greater than PcdUefiLibMaxPrintBufferSize, then at most the first
   PcdUefiLibMaxPrintBufferSize characters are printed.The EFI_HII_FONT_PROTOCOL
   StringToImage() service is used to convert the string to a bitmap using the glyphs
   registered with the HII database. No wrapping is performed, so any portions of the
   string the fall outside the active display region will not be displayed. Please see
+  StringToImage() service is used to convert the string to a bitmap using the glyphs
+  registered with the HII database. No wrapping is performed, so any portions of the
+  string the fall outside the active display region will not be displayed. Please see
   Section 27.2.6 of the UEFI Specification for a description of the supported string
   format including the set of control codes supported by the StringToImage() service.
   If a graphics console device is not associated with the ConsoleOutputHandle
+  If a graphics console device is not associated with the ConsoleOutputHandle
   defined in the EFI_SYSTEM_TABLE then no string is printed, and 0 is returned.
   If the EFI_HII_FONT_PROTOCOL is not present in the handle database, then no
+  If the EFI_HII_FONT_PROTOCOL is not present in the handle database, then no
   string is printed, and 0 is returned.
   If Format is NULL, then ASSERT().
 …
                        in the EFI_SYSTEM_TABLE is used.
   @param  BackGround   The background color of the string being printed.  This is
                        an optional parameter that may be NULL.  If it is NULL,
+                       an optional parameter that may be NULL.  If it is NULL,
                        then the background color of the current ConOut device
                        in the EFI_SYSTEM_TABLE is used.
   @param  Format       A Null-terminated ASCII format string.  See Print Library
+  @param  Format       A Null-terminated ASCII format string.  See Print Library
                        for the supported format string syntax.
   @param  ...          Variable argument list whose contents are accessed based on
                        the format string specified by Format.
+  @param  ...          Variable argument list whose contents are accessed based on
+                       the format string specified by Format.
   @return  The number of ASCII characters printed.
 …
+}
 /**
+/**
   Appends a formatted Unicode string to a Null-terminated Unicode string
   This function appends a formatted Unicode string to the Null-terminated
+  This function appends a formatted Unicode string to the Null-terminated
   Unicode string specified by String.   String is optional and may be NULL.
   Storage for the formatted Unicode string returned is allocated using
+  Storage for the formatted Unicode string returned is allocated using
   AllocatePool().  The pointer to the appended string is returned.  The caller
   is responsible for freeing the returned string.
   If String is not NULL and not aligned on a 16-bit boundary, then ASSERT().
   If FormatString is NULL, then ASSERT().
   If FormatString is not aligned on a 16-bit boundary, then ASSERT().
   @param[in] String         A Null-terminated Unicode string.
   @param[in] FormatString   A Null-terminated Unicode format string.
 …
   @retval NULL    There was not enough available memory.
   @return         Null-terminated Unicode string is that is the formatted
+  @return         Null-terminated Unicode string is that is the formatted
                   string appended to String.
 **/
 …
+}
 /**
+/**
   Appends a formatted Unicode string to a Null-terminated Unicode string
   This function appends a formatted Unicode string to the Null-terminated
+  This function appends a formatted Unicode string to the Null-terminated
   Unicode string specified by String.   String is optional and may be NULL.
   Storage for the formatted Unicode string returned is allocated using
+  Storage for the formatted Unicode string returned is allocated using
   AllocatePool().  The pointer to the appended string is returned.  The caller
   is responsible for freeing the returned string.
   If String is not NULL and not aligned on a 16-bit boundary, then ASSERT().
   If FormatString is NULL, then ASSERT().
   If FormatString is not aligned on a 16-bit boundary, then ASSERT().
   @param[in] String         A Null-terminated Unicode string.
   @param[in] FormatString   A Null-terminated Unicode format string.
   @param[in] ...            The variable argument list whose contents are
                             accessed based on the format string specified by
+  @param[in] ...            The variable argument list whose contents are
+                            accessed based on the format string specified by
                             FormatString.
   @retval NULL    There was not enough available memory.
   @return         Null-terminated Unicode string is that is the formatted
+  @return         Null-terminated Unicode string is that is the formatted
                   string appended to String.
 **/

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiLib/UefiNotTiano.c

-              r58459
+              r58466
   This empty function ensures that EVT_NOTIFY_SIGNAL_ALL is error
   checked correctly since it is now mapped into CreateEventEx() in UEFI 2.0.
   @param  Event                 Event whose notification function is being invoked.
   @param  Context               The pointer to the notification function's context,
 …
 /**
   Create an EFI event in the Legacy Boot Event Group and allows
   the caller to specify a notification function.
+  the caller to specify a notification function.
   This function abstracts the creation of the Legacy Boot Event.
   The Framework moved from a proprietary to UEFI 2.0 based mechanism.
 …
   Prior to UEFI 2.0 this was done via a non-standard UEFI extension, and this library
   abstracts the implementation mechanism of this event from the caller.
   This function abstracts the creation of the Ready to Boot Event.  The Framework
   moved from a proprietary to UEFI 2.0-based mechanism.  This library abstracts
   the caller from how this event is created to prevent the code form having to
+  abstracts the implementation mechanism of this event from the caller.
+  This function abstracts the creation of the Ready to Boot Event.  The Framework
+  moved from a proprietary to UEFI 2.0-based mechanism.  This library abstracts
+  the caller from how this event is created to prevent the code form having to
   change with the version of the specification supported.
   If ReadyToBootEvent is NULL, then ASSERT().
 …
 /**
   Create an EFI event in the Ready To Boot Event Group and allows
   the caller to specify a notification function.
+  the caller to specify a notification function.
   This function abstracts the creation of the Ready to Boot Event.
   The Framework moved from a proprietary to UEFI 2.0 based mechanism.
 …
 /**
   Create, Signal, and Close the Ready to Boot event using EfiSignalEventReadyToBoot().
   This function abstracts the signaling of the Ready to Boot Event. The Framework moved
   from a proprietary to UEFI 2.0 based mechanism. This library abstracts the caller
 …
 /**
   Check to see if the Firmware Volume (FV) Media Device Path is valid
   The Framework FwVol Device Path changed to conform to the UEFI 2.0 specification.
+  Check to see if the Firmware Volume (FV) Media Device Path is valid
+  The Framework FwVol Device Path changed to conform to the UEFI 2.0 specification.
   This library function abstracts validating a device path node.
   Check the MEDIA_FW_VOL_FILEPATH_DEVICE_PATH data structure to see if it's valid.
   If it is valid, then return the GUID file name from the device path node.  Otherwise,
   return NULL.  This device path changed in the DXE CIS version 0.92 in a non back ward
   compatible way to not conflict with the UEFI 2.0 specification.  This function abstracts
+  Check the MEDIA_FW_VOL_FILEPATH_DEVICE_PATH data structure to see if it's valid.
+  If it is valid, then return the GUID file name from the device path node.  Otherwise,
+  return NULL.  This device path changed in the DXE CIS version 0.92 in a non back ward
+  compatible way to not conflict with the UEFI 2.0 specification.  This function abstracts
   the differences from the caller.
   If FvDevicePathNode is NULL, then ASSERT().
 …
 /**
   Initialize a Firmware Volume (FV) Media Device Path node.
   The Framework FwVol Device Path changed to conform to the UEFI 2.0 specification.
   This library function abstracts initializing a device path node.
   Initialize the MEDIA_FW_VOL_FILEPATH_DEVICE_PATH data structure.  This device
   path changed in the DXE CIS version 0.92 in a non back ward compatible way to
   not conflict with the UEFI 2.0 specification.  This function abstracts the
+  The Framework FwVol Device Path changed to conform to the UEFI 2.0 specification.
+  This library function abstracts initializing a device path node.
+  Initialize the MEDIA_FW_VOL_FILEPATH_DEVICE_PATH data structure.  This device
+  path changed in the DXE CIS version 0.92 in a non back ward compatible way to
+  not conflict with the UEFI 2.0 specification.  This function abstracts the
   differences from the caller.
   If FvDevicePathNode is NULL, then ASSERT().
   If NameGuid is NULL, then ASSERT().
   @param  FvDevicePathNode  The pointer to a FV device path node to initialize
   @param  NameGuid          FV file name to use in FvDevicePathNode

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c

-              r58459
+              r58466
 /** @file
   Support routines for memory allocation routines based
+  Support routines for memory allocation routines based
   on boot services for Dxe phase drivers.
   Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
 VOID *
 InternalAllocatePages (
   IN EFI_MEMORY_TYPE  MemoryType,
+  IN EFI_MEMORY_TYPE  MemoryType,
   IN UINTN            Pages
+  )
+{
   EFI_STATUS            Status;
   EFI_PHYSICAL_ADDRESS  Memory;
+  EFI_PHYSICAL_ADDRESS  Memory;
   if (Pages == 0) {
 …
   Allocation Library.  If it is not possible to free allocated pages, then this function will
   perform no actions.
   If Buffer was not allocated with a page allocation function in the Memory Allocation Library,
   then ASSERT().
   If Pages is zero, then ASSERT().
   @param  Buffer                The pointer to the buffer of pages to free.
   @param  Pages                 The number of 4 KB pages to free.
 …
 VOID *
 InternalAllocateAlignedPages (
   IN EFI_MEMORY_TYPE  MemoryType,
+  IN EFI_MEMORY_TYPE  MemoryType,
   IN UINTN            Pages,
   IN UINTN            Alignment
 …
   //
   ASSERT ((Alignment & (Alignment - 1)) == 0);
   if (Pages == 0) {
     return NULL;
 …
     //
     ASSERT (RealPages > Pages);
     Status         = gBS->AllocatePages (AllocateAnyPages, MemoryType, RealPages, &Memory);
     if (EFI_ERROR (Status)) {
 …
   returned.  If there is not enough memory at the specified alignment remaining to satisfy the
   request, then NULL is returned.
   If Alignment is not a power of two and Alignment is not zero, then ASSERT().
   If Pages plus EFI_SIZE_TO_PAGES (Alignment) overflows, then ASSERT().
 …
   returned.  If there is not enough memory at the specified alignment remaining to satisfy the
   request, then NULL is returned.
   If Alignment is not a power of two and Alignment is not zero, then ASSERT().
   If Pages plus EFI_SIZE_TO_PAGES (Alignment) overflows, then ASSERT().
 …
   returned.  If there is not enough memory at the specified alignment remaining to satisfy the
   request, then NULL is returned.
   If Alignment is not a power of two and Alignment is not zero, then ASSERT().
   If Pages plus EFI_SIZE_TO_PAGES (Alignment) overflows, then ASSERT().
 …
   Frees the number of 4KB pages specified by Pages from the buffer specified by Buffer.  Buffer
   must have been allocated on a previous call to the aligned page allocation services of the Memory
   Allocation Library.  If it is not possible to free allocated pages, then this function will
+  Allocation Library.  If it is not possible to free allocated pages, then this function will
   perform no actions.
   If Buffer was not allocated with an aligned page allocation function in the Memory Allocation
   Library, then ASSERT().
   If Pages is zero, then ASSERT().
   @param  Buffer                The pointer to the buffer of pages to free.
   @param  Pages                 The number of 4 KB pages to free.
 …
 VOID *
 InternalAllocatePool (
   IN EFI_MEMORY_TYPE  MemoryType,
+  IN EFI_MEMORY_TYPE  MemoryType,
   IN UINTN            AllocationSize
+  )
 …
 VOID *
 InternalAllocateZeroPool (
   IN EFI_MEMORY_TYPE  PoolType,
+  IN EFI_MEMORY_TYPE  PoolType,
   IN UINTN            AllocationSize
+  )
+  )
+{
   VOID  *Memory;
 …
   is not enough memory remaining to satisfy the request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  PoolType              The type of pool to allocate.
 …
 VOID *
 InternalAllocateCopyPool (
   IN EFI_MEMORY_TYPE  PoolType,
+  IN EFI_MEMORY_TYPE  PoolType,
   IN UINTN            AllocationSize,
   IN CONST VOID       *Buffer
+  )
+  )
+{
   VOID  *Memory;
 …
+  }
   return Memory;
+}
+}
 /**
 …
   allocated buffer.  If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there
   is not enough memory remaining to satisfy the request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  AllocationSize        The number of bytes to allocate and zero.
 …
   allocated buffer.  If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there
   is not enough memory remaining to satisfy the request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  AllocationSize        The number of bytes to allocate and zero.
 …
   allocated buffer.  If AllocationSize is 0, then a valid buffer of 0 size is returned.  If there
   is not enough memory remaining to satisfy the request, then NULL is returned.
   If Buffer is NULL, then ASSERT().
   If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
+  If AllocationSize is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
   @param  AllocationSize        The number of bytes to allocate and zero.
 …
   Allocates and zeros the number bytes specified by NewSize from memory of the type
   specified by PoolType.  If OldBuffer is not NULL, then the smaller of OldSize and
   NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  specified by PoolType.  If OldBuffer is not NULL, then the smaller of OldSize and
+  NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
   If the allocation of the new buffer is successful and the smaller of NewSize and OldSize
   is greater than (MAX_ADDRESS - OldBuffer + 1), then ASSERT().
 …
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
                          parameter that may be NULL.
 …
 VOID *
 InternalReallocatePool (
   IN EFI_MEMORY_TYPE  PoolType,
+  IN EFI_MEMORY_TYPE  PoolType,
   IN UINTN            OldSize,
   IN UINTN            NewSize,
 …
   Allocates and zeros the number bytes specified by NewSize from memory of type
   EfiBootServicesData.  If OldBuffer is not NULL, then the smaller of OldSize and
   NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  EfiBootServicesData.  If OldBuffer is not NULL, then the smaller of OldSize and
+  NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
   If the allocation of the new buffer is successful and the smaller of NewSize and OldSize
   is greater than (MAX_ADDRESS - OldBuffer + 1), then ASSERT().
 …
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
                          parameter that may be NULL.
 …
   Allocates and zeros the number bytes specified by NewSize from memory of type
   EfiRuntimeServicesData.  If OldBuffer is not NULL, then the smaller of OldSize and
   NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  EfiRuntimeServicesData.  If OldBuffer is not NULL, then the smaller of OldSize and
+  NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
 …
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
                          parameter that may be NULL.
 …
   Allocates and zeros the number bytes specified by NewSize from memory of type
   EfiReservedMemoryType.  If OldBuffer is not NULL, then the smaller of OldSize and
   NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
   OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
   If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
+  EfiReservedMemoryType.  If OldBuffer is not NULL, then the smaller of OldSize and
+  NewSize bytes are copied from OldBuffer to the newly allocated buffer, and
+  OldBuffer is freed.  A pointer to the newly allocated buffer is returned.
+  If NewSize is 0, then a valid buffer of 0 size is  returned.  If there is not
   enough memory remaining to satisfy the request, then NULL is returned.
 …
   @param  OldSize        The size, in bytes, of OldBuffer.
   @param  NewSize        The size, in bytes, of the buffer to reallocate.
   @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
+  @param  OldBuffer      The buffer to copy to the allocated buffer.  This is an optional
                          parameter that may be NULL.
 …
   pool allocation services of the Memory Allocation Library.  If it is not possible to free pool
   resources, then this function will perform no actions.
   If Buffer was not allocated with a pool allocation function in the Memory Allocation Library,
   then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryLib/CompareMemWrapper.c

-              r48674
+              r58466
   value returned is the first mismatched byte in SourceBuffer subtracted from the first
   mismatched byte in DestinationBuffer.
   If Length > 0 and DestinationBuffer is NULL, then ASSERT().
   If Length > 0 and SourceBuffer is NULL, then ASSERT().
 …
   @retval Non-zero          The first mismatched byte in SourceBuffer subtracted from the first
                             mismatched byte in DestinationBuffer.
 **/
 INTN

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryLib/CopyMemWrapper.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   DestinationBuffer.  The implementation must be reentrant, and it must handle the case
   where SourceBuffer overlaps DestinationBuffer.
   If Length is greater than (MAX_ADDRESS - DestinationBuffer + 1), then ASSERT().
   If Length is greater than (MAX_ADDRESS - SourceBuffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryLib/MemLibGuid.c

-              r48674
+              r58466
   The following BaseMemoryLib instances contain the same copy of this file:
     BaseMemoryLib
     BaseMemoryLibMmx
 …
   This function copies the contents of the 128-bit GUID specified by SourceGuid to
   DestinationGuid, and returns DestinationGuid.
   If DestinationGuid is NULL, then ASSERT().
   If SourceGuid is NULL, then ASSERT().
 …
   This function compares Guid1 to Guid2.  If the GUIDs are identical then TRUE is returned.
   If there are any bit differences in the two GUIDs, then FALSE is returned.
   If Guid1 is NULL, then ASSERT().
   If Guid2 is NULL, then ASSERT().
 …
   GUID in the target buffer is returned.  If no match is found, then NULL is returned.
   If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryLib/ScanMem16Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 16-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryLib/ScanMem32Wrapper.c

r48674	r58466
33	33	then a pointer to the matching byte in the target buffer is returned. If no match is found,
34	34	then NULL is returned. If Length is 0, then NULL is returned.
35
	35
36	36	If Length > 0 and Buffer is NULL, then ASSERT().
37	37	If Buffer is not aligned on a 32-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryLib/ScanMem64Wrapper.c

r48674	r58466
34	34	then a pointer to the matching byte in the target buffer is returned. If no match is found,
35	35	then NULL is returned. If Length is 0, then NULL is returned.
36
	36
37	37	If Length > 0 and Buffer is NULL, then ASSERT().
38	38	If Buffer is not aligned on a 64-bit boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryLib/ScanMem8Wrapper.c

-              r48674
+              r58466
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
 …
   ASSERT (Buffer != NULL);
   ASSERT ((Length - 1) <= (MAX_ADDRESS - (UINTN)Buffer));
   return (VOID*)InternalMemScanMem8 (Buffer, Length, Value);
+}
 /**
   Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
+  Scans a target buffer for a UINTN sized value, and returns a pointer to the matching
   UINTN sized value in the target buffer.
 …
   then a pointer to the matching byte in the target buffer is returned.  If no match is found,
   then NULL is returned.  If Length is 0, then NULL is returned.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Buffer is not aligned on a UINTN boundary, then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryLib/SetMemWrapper.c

r48674	r58466
30	30
31	31	This function fills Length bytes of Buffer with Value, and returns Buffer.
32
	32
33	33	If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().
34	34

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryLib/UefiMemoryLib.inf

r58459	r58466
24	24	MODULE_TYPE = UEFI_DRIVER
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = BaseMemoryLib\|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
	26	LIBRARY_CLASS = BaseMemoryLib\|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
27	27
28	28

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiMemoryLib/ZeroMemWrapper.c

-              r48674
+              r58466
     PeiMemoryLib
     UefiMemoryLib
   Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   This function fills Length bytes of Buffer with zeros, and returns Buffer.
   If Length > 0 and Buffer is NULL, then ASSERT().
   If Length is greater than (MAX_ADDRESS - Buffer + 1), then ASSERT().

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiPalLib/UefiPalLib.c

r48674	r58466
9	9	text of the license may be found at
10	10	http://opensource.org/licenses/bsd-license.php.
11
	11
12	12	THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
13	13	WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiPciLibPciRootBridgeIo/PciLib.c

-              r58459
+              r58466
   text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 …
 // Global varible to cache pointer to PCI Root Bridge I/O protocol.
 //
 EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL      *mPciRootBridgeIo = NULL;
+EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL      *mPciRootBridgeIo = NULL;
 /**
   The constructor function caches the pointer to PCI Root Bridge I/O protocol.
   The constructor function locates PCI Root Bridge I/O protocol from protocol database.
   It will ASSERT() if that operation fails and it will always return EFI_SUCCESS.
+  It will ASSERT() if that operation fails and it will always return EFI_SUCCESS.
   @param  ImageHandle   The firmware allocated handle for the EFI image.
   @param  SystemTable   A pointer to the EFI System Table.
   @retval EFI_SUCCESS   The constructor always returns EFI_SUCCESS.
 …
+{
   EFI_STATUS  Status;
   Status = gBS->LocateProtocol (&gEfiPciRootBridgeIoProtocolGuid, NULL, (VOID**) &mPciRootBridgeIo);
   ASSERT_EFI_ERROR (Status);
 …
 /**
   Registers a PCI device so PCI configuration registers may be accessed after
+  Registers a PCI device so PCI configuration registers may be accessed after
   SetVirtualAddressMap().
   Registers the PCI device specified by Address so all the PCI configuration registers
+  Registers the PCI device specified by Address so all the PCI configuration registers
   associated with that PCI device may be accessed after SetVirtualAddressMap() is called.
   If Address > 0x0FFFFFFF, then ASSERT().
   @param  Address The address that encodes the PCI Bus, Device, Function and
                   Register.
+  If Address > 0x0FFFFFFF, then ASSERT().
+  @param  Address The address that encodes the PCI Bus, Device, Function and
+                  Register.
   @retval RETURN_SUCCESS           The PCI device was registered for runtime access.
   @retval RETURN_UNSUPPORTED       An attempt was made to call this function
+  @retval RETURN_UNSUPPORTED       An attempt was made to call this function
                                    after ExitBootServices().
   @retval RETURN_UNSUPPORTED       The resources required to access the PCI device

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiPciSegmentLibPciRootBridgeIo/PciSegmentLib.c

-              r58459
+              r58466
   text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 …
 /**
   The constructor function caches data of PCI Root Bridge I/O Protocol instances.
   The constructor function locates PCI Root Bridge I/O protocol instances,
   and caches the protocol instances, together with their segment numbers and bus ranges.
   It will ASSERT() if that related operation fails and it will always return EFI_SUCCESS.
+  It will ASSERT() if that related operation fails and it will always return EFI_SUCCESS.
   @param  ImageHandle   The firmware allocated handle for the EFI image.
   @param  SystemTable   A pointer to the EFI System Table.
   @retval EFI_SUCCESS   The constructor always returns EFI_SUCCESS.
 …
   UINTN                                HandleCount;
   EFI_HANDLE                           *HandleBuffer;
   EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL      *PciRootBridgeIo;
+  EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL      *PciRootBridgeIo;
   EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR    *Descriptors;
 …
 /**
   The destructor function frees memory allocated by constructor.
   The destructor function frees memory for data of protocol instances allocated by constructor.
   It will ASSERT() if that related operation fails and it will always return EFI_SUCCESS.
+  It will ASSERT() if that related operation fails and it will always return EFI_SUCCESS.
   @param  ImageHandle   The firmware allocated handle for the EFI image.
   @param  SystemTable   A pointer to the EFI System Table.
   @retval EFI_SUCCESS   The constructor always returns EFI_SUCCESS.
 …
         return mPciRootBridgeData[Index].PciRootBridgeIo;
+      }
+    }
+    }
+  }
   return NULL;
 …
+{
   UINT32                               Data;
   EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL      *PciRootBridgeIo;
+  EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL      *PciRootBridgeIo;
   PciRootBridgeIo = PciSegmentLibSearchForRootBridge (Address);
 …
+  )
+{
   EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL      *PciRootBridgeIo;
+  EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL      *PciRootBridgeIo;
   PciRootBridgeIo = PciSegmentLibSearchForRootBridge (Address);
 …
 /**
   Register a PCI device so PCI configuration registers may be accessed after
+  Register a PCI device so PCI configuration registers may be accessed after
   SetVirtualAddressMap().
   If any reserved bits in Address are set, then ASSERT().
   @param  Address The address that encodes the PCI Bus, Device, Function and
                   Register.
   @retval RETURN_SUCCESS           The PCI device was registered for runtime access.
   @retval RETURN_UNSUPPORTED       An attempt was made to call this function
+  @retval RETURN_UNSUPPORTED       An attempt was made to call this function
                                    after ExitBootServices().
   @retval RETURN_UNSUPPORTED       The resources required to access the PCI device
 …
   Reads and returns the 8-bit PCI configuration register specified by Address.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
+  If any reserved bits in Address are set, then ASSERT().
   @param  Address   The address that encodes the PCI Segment, Bus, Device, Function, and Register.
 …
   Writes the 8-bit PCI configuration register specified by Address with the value specified by Value.
   Value is returned.  This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
 …
   Performs a bitwise AND of an 8-bit PCI configuration register with an 8-bit value,
   followed a  bitwise OR with another 8-bit value.
   Reads the 8-bit PCI configuration register specified by Address,
   performs a bitwise AND between the read result and the value specified by AndData,
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
 …
   Reads and returns the 16-bit PCI configuration register specified by Address.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 16-bit boundary, then ASSERT().
   @param  Address   The address that encodes the PCI Segment, Bus, Device, Function, and Register.
 …
   Writes the 16-bit PCI configuration register specified by Address with the value specified by Value.
   Value is returned.  This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 16-bit boundary, then ASSERT().
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 16-bit boundary, then ASSERT().
   @param  Address   The address that encodes the PCI Segment, Bus, Device, Function, and Register.
   @param  AndData   The value to AND with the PCI configuration register.
 …
   Performs a bitwise AND of a 16-bit PCI configuration register with a 16-bit value,
   followed a  bitwise OR with another 16-bit value.
   Reads the 16-bit PCI configuration register specified by Address,
   performs a bitwise AND between the read result and the value specified by AndData,
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 16-bit boundary, then ASSERT().
 …
   Reads the 16-bit PCI configuration register specified by Address,
   performs a bitwise OR between the read result and the value specified by OrData,
   and writes the result to the 16-bit PCI configuration register specified by Address.
+  and writes the result to the 16-bit PCI configuration register specified by Address.
   If any reserved bits in Address are set, then ASSERT().
 …
   This function must guarantee that all PCI read and write operations are serialized.
   Extra left bits in OrData are stripped.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 16-bit boundary, then ASSERT().
 …
   Reads and returns the 32-bit PCI configuration register specified by Address.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 32-bit boundary, then ASSERT().
 …
   Writes the 32-bit PCI configuration register specified by Address with the value specified by Value.
   Value is returned.  This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 32-bit boundary, then ASSERT().
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 32-bit boundary, then ASSERT().
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 32-bit boundary, then ASSERT().
 …
   Performs a bitwise AND of a 32-bit PCI configuration register with a 32-bit value,
   followed a  bitwise OR with another 32-bit value.
   Reads the 32-bit PCI configuration register specified by Address,
   performs a bitwise AND between the read result and the value specified by AndData,
 …
   The value written to the PCI configuration register is returned.
   This function must guarantee that all PCI read and write operations are serialized.
   If any reserved bits in Address are set, then ASSERT().
   If Address is not aligned on a 32-bit boundary, then ASSERT().
 …
   AND, and writes the result back to the bit field in the 32-bit register.
   Reads the 32-bit PCI configuration register specified by Address, performs a bitwise
   AND between the read result and the value specified by AndData, and writes the result

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiPciSegmentLibPciRootBridgeIo/PciSegmentLib.h

r48674	r58466
8	8	text of the license may be found at
9	9	http://opensource.org/licenses/bsd-license.php.
10
	10
11	11	THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
12	12	WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiRuntimeLib/RuntimeLib.c

-              r48674
+              r58466
   This library hides the global variable for the EFI Runtime Services so the
   caller does not need to deal with the possibility of being called from an
   OS virtual address space. All pointer values are different for a virtual
+  OS virtual address space. All pointer values are different for a virtual
   mapping than from the normal physical mapping at boot services time.
 …
 /**
   If a runtime driver exits with an error, it must call this routine
+  If a runtime driver exits with an error, it must call this routine
   to free the allocated resource before the exiting.
   It will ASSERT() if gBS is NULL.
 …
 /**
   This function allows the caller to determine if UEFI SetVirtualAddressMap() has been called.
+  This function allows the caller to determine if UEFI SetVirtualAddressMap() has been called.
   This function returns TRUE after all the EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE functions have
 …
   may create and manage its own variables without the risk of name conflicts by using a unique VendorGuid.
   @param  VariableName The name of the vendor's variable; it's a Null-Terminated
+  @param  VariableName The name of the vendor's variable; it's a Null-Terminated
                        Unicode String
   @param  VendorGuid   Unify identifier for vendor.
 …
 /**
   This service is a wrapper for the UEFI Runtime Service ConvertPointer().
+  This service is a wrapper for the UEFI Runtime Service ConvertPointer().
   The ConvertPointer() function is used by an EFI component during the SetVirtualAddressMap() operation.
 …
   For IA32, x64, and EBC, this service is a wrapper for the UEFI Runtime Service
   ConvertPointer().  See the UEFI Specification for details.
+  ConvertPointer().  See the UEFI Specification for details.
   For IPF, this function interprets Address as a pointer to an EFI_PLABEL structure
   and both the EntryPoint and GP fields of an EFI_PLABEL are converted from physical
 …
   LIST_ENTRY  *Link;
   LIST_ENTRY  *NextLink;
   //
   // For NULL List, return EFI_SUCCESS

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf

r58459	r58466
45	45	UefiRuntimeServicesTableLib
46	46	DebugLib
47
	47
48	48	[Guids]
49	49	gEfiEventExitBootServicesGuid ## CONSUMES ## Event

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiSalLib/UefiSalLib.c

-              r48674
+              r58466
   text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 …
 /**
   Makes a SAL procedure call.
   This is a wrapper function to make a SAL procedure call.
+  This is a wrapper function to make a SAL procedure call.
   No parameter checking is performed on the 8 input parameters,
   but there are some common rules that the caller should follow

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiScsiLib/UefiScsiLib.c

-              r58459
+              r58466
   Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD License
+  which accompanies this distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 **/
 …
 #include <Library/UefiScsiLib.h>
 #include <Library/BaseMemoryLib.h>
 #include <IndustryStandard/Scsi.h>
   //
   // Max bytes needed to represent ID of a SCSI device
   //
 #define EFI_SCSI_TARGET_MAX_BYTES (0x10)
   //
   // bit5..7 are for Logical unit number
 …
   //
 #define EFI_SCSI_LOGICAL_UNIT_NUMBER_MASK 0xe0
   //
   // Scsi Command Length
 …
   @param[in, out] SenseDataLength   On input, a pointer to the length in bytes of
                                     the SenseData buffer. On output, a pointer to
                                     the number of bytes written to the SenseData buffer.
+                                    the number of bytes written to the SenseData buffer.
   @param[out]     HostAdapterStatus The status of the SCSI Host Controller that produces
                                     the SCSI bus containing the SCSI target specified by
 …
                                     on the SCSI Host Controller. See the EFI SCSI I/O
                                     Protocol in the UEFI Specification for details on
                                     the possible return values.
+                                    the possible return values.
   @retval EFI_SUCCESS          The command was executed successfully.
 …
                                          is optional and may be NULL.
   @param[in, out] SenseDataLength        On input, the length in bytes of the SenseData buffer.
                                          On output, the number of bytes written to the SenseData buffer.
+                                         On output, the number of bytes written to the SenseData buffer.
   @param[out]     HostAdapterStatus      The status of the SCSI Host Controller that
                                          produces the SCSI bus containing the SCSI
 …
                                          See the EFI SCSI I/O Protocol in the UEFI
                                          Specification for details on the possible
                                          return values.
+                                         return values.
   @param[in, out] InquiryDataBuffer      A pointer to inquiry data that was generated
                                          by the execution of the SCSI Request Packet.
                                          This buffer must be allocated by the caller.
                                          If InquiryDataLength is 0, then this parameter
                                          is optional and may be NULL.
+                                         is optional and may be NULL.
   @param[in, out] InquiryDataLength      On input, a pointer to the length in bytes
                                          of the InquiryDataBuffer buffer.
 …
                                          is optional and may be NULL.
   @param[in, out] SenseDataLength        On input, the length in bytes of the SenseData buffer.
                                          On output, the number of bytes written to the SenseData buffer.
+                                         On output, the number of bytes written to the SenseData buffer.
   @param[out]     HostAdapterStatus      The status of the SCSI Host Controller that
                                          produces the SCSI bus containing the SCSI
 …
                                          See the EFI SCSI I/O Protocol in the UEFI
                                          Specification for details on the possible
                                          return values.
+                                         return values.
   @param[in, out] InquiryDataBuffer      A pointer to inquiry data that was generated
                                          by the execution of the SCSI Request Packet.
                                          This buffer must be allocated by the caller.
                                          If InquiryDataLength is 0, then this parameter
                                          is optional and may be NULL.
+                                         is optional and may be NULL.
   @param[in, out] InquiryDataLength      On input, a pointer to the length in bytes
                                          of the InquiryDataBuffer buffer.
 …
                                          data is returned in InquiryDataBuffer.
                                          If FALSE, then the standard inquiry data is
                                          returned in InquiryDataBuffer.
+                                         returned in InquiryDataBuffer.
   @retval EFI_SUCCESS          The command executed successfully. See HostAdapterStatus,
 …
                                      is optional and may be NULL.
   @param[in, out]  SenseDataLength   On input, the length in bytes of the SenseData buffer.
                                      On output, the number of bytes written to the SenseData buffer.
+                                     On output, the number of bytes written to the SenseData buffer.
   @param[out]     HostAdapterStatus  The status of the SCSI Host Controller that
                                      produces the SCSI bus containing the SCSI target
 …
                                      buffer must be allocated by the caller. If
                                      DataLength is 0, then this parameter is optional
                                      and may be NULL.
+                                     and may be NULL.
   @param[in, out]  DataLength        On input, a pointer to the length in bytes of
                                      the DataBuffer buffer.  On output, a pointer
                                      to the number of bytes written to the DataBuffer
                                      buffer.
+                                     buffer.
   @param[in]      DBDField           Specifies the DBD field of the CDB for this SCSI Command.
   @param[in]      PageControl        Specifies the PC field of the CDB for this SCSI Command.
   @param[in]      PageCode           Specifies the Page Control field of the CDB for this SCSI Command.
+  @param[in]      PageControl        Specifies the PC field of the CDB for this SCSI Command.
+  @param[in]      PageCode           Specifies the Page Control field of the CDB for this SCSI Command.
   @retval EFI_SUCCESS               The command executed successfully.
 …
   @retval  EFI_BAD_BUFFER_SIZE  The SCSI Request Packet was executed, but the entire DataBuffer could
                                 not be transferred. The actual number of bytes transferred is returned in DataLength.
   @retval  EFI_NOT_READY        The SCSI Request Packet could not be sent because there are too many
+  @retval  EFI_NOT_READY        The SCSI Request Packet could not be sent because there are too many
                                 SCSI Command Packets already queued.
   @retval  EFI_DEVICE_ERROR     A device error occurred while attempting to send SCSI Request Packet.
   @retval  EFI_UNSUPPORTED      The command described by the SCSI Request Packet is not supported by
+  @retval  EFI_UNSUPPORTED      The command described by the SCSI Request Packet is not supported by
                                 the SCSI initiator(i.e., SCSI  Host Controller)
   @retval  EFI_TIMEOUT          A timeout occurred while waiting for the SCSI Request Packet to execute.
 …
   @retval  EFI_BAD_BUFFER_SIZE  The SCSI Request Packet was executed, but the entire DataBuffer could
                                 not be transferred. The actual number of bytes transferred is returned in DataLength.
   @retval  EFI_NOT_READY        The SCSI Request Packet could not be sent because there are too many
+  @retval  EFI_NOT_READY        The SCSI Request Packet could not be sent because there are too many
                                 SCSI Command Packets already queued.
   @retval  EFI_DEVICE_ERROR     A device error occurred while attempting to send SCSI Request Packet.
   @retval  EFI_UNSUPPORTED      The command described by the SCSI Request Packet is not supported by
+  @retval  EFI_UNSUPPORTED      The command described by the SCSI Request Packet is not supported by
                                 the SCSI initiator(i.e., SCSI  Host Controller)
   @retval  EFI_TIMEOUT          A timeout occurred while waiting for the SCSI Request Packet to execute.
 …
   @retval  EFI_BAD_BUFFER_SIZE  The SCSI Request Packet was executed, but the entire DataBuffer could
                                 not be transferred. The actual number of bytes transferred is returned in DataLength.
   @retval  EFI_NOT_READY        The SCSI Request Packet could not be sent because there are too many
+  @retval  EFI_NOT_READY        The SCSI Request Packet could not be sent because there are too many
                                 SCSI Command Packets already queued.
   @retval  EFI_DEVICE_ERROR     A device error occurred while attempting to send SCSI Request Packet.
   @retval  EFI_UNSUPPORTED      The command described by the SCSI Request Packet is not supported by
+  @retval  EFI_UNSUPPORTED      The command described by the SCSI Request Packet is not supported by
                                 the SCSI initiator(i.e., SCSI  Host Controller)
   @retval  EFI_TIMEOUT          A timeout occurred while waiting for the SCSI Request Packet to execute.
 …
   @retval  EFI_BAD_BUFFER_SIZE  The SCSI Request Packet was executed, but the entire DataBuffer could
                                 not be transferred. The actual number of bytes transferred is returned in DataLength.
   @retval  EFI_NOT_READY        The SCSI Request Packet could not be sent because there are too many
+  @retval  EFI_NOT_READY        The SCSI Request Packet could not be sent because there are too many
                                 SCSI Command Packets already queued.
   @retval  EFI_DEVICE_ERROR     A device error occurred while attempting to send SCSI Request Packet.
   @retval  EFI_UNSUPPORTED      The command described by the SCSI Request Packet is not supported by
+  @retval  EFI_UNSUPPORTED      The command described by the SCSI Request Packet is not supported by
                                 the SCSI initiator(i.e., SCSI  Host Controller)
   @retval  EFI_TIMEOUT          A timeout occurred while waiting for the SCSI Request Packet to execute.

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiScsiLib/UefiScsiLib.inf

r58459	r58466
24	24	MODULE_TYPE = UEFI_DRIVER
25	25	VERSION_STRING = 1.0
26		LIBRARY_CLASS = UefiScsiLib\|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
	26	LIBRARY_CLASS = UefiScsiLib\|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
27	27
28	28

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiUsbLib/Hid.c

-              r48674
+              r58466
   The library provides USB HID Class standard and specific requests defined
   in USB HID Firmware Specification 7 section : Requests.
   Copyright (c) 2004 - 2010, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
 …
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 …
 #include "UefiUsbLibInternal.h"
 //
+//
 //  Hid RequestType Bits specifying characteristics of request.
 //  Valid values are 10100001b (0xa1) or 00100001b (0x21).
 …
   ASSERT (UsbIo != NULL);
   //
   // Fill Device request packet
 …
   EFI_STATUS              Result;
   EFI_USB_DEVICE_REQUEST  Request;
   ASSERT (UsbIo != NULL);
   ASSERT (Duration != NULL);

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiUsbLib/UefiUsbLibInternal.h

r48674	r58466
1	1	/** @file
2
	2
3	3	Common header file shared by all source files.
4	4

trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library/UefiUsbLib/UsbDxeLib.c

-              r48674
+              r58466
 /** @file
   The library provides the USB Standard Device Requests defined
+  The library provides the USB Standard Device Requests defined
   in Usb specification 9.4 section.
   Copyright (c) 2004 - 2008, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials are
 …
   text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

Changeset 58466 in vbox for trunk/src/VBox/Devices/EFI/Firmware/MdePkg/Library

Legend: