Changeset 58487 in vbox for trunk/src/VBox/VMM

Timestamp:

Oct 29, 2015 1:53:56 PM (9 years ago)

Author:

vboxsync

Message:

VMM: todo regarding RIP update and hypercall ordering.

Location:

trunk/src/VBox/VMM/VMMR0

Files:

• HMSVMR0.cpp (modified) (1 diff)
• HMVMXR0.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp

@@ -5162 +5162 @@
         {
             hmR0SvmUpdateRip(pVCpu, pCtx, 3);
+
+            /** @todo pre-increment RIP before hypercall will break when we have to implement
+             *  continuing hypercalls (e.g. Hyper-V). */
             rc = GIMHypercall(pVCpu, pCtx);
             /* If the hypercall changes anything other than guest general-purpose registers,

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -10150 +10150 @@
         AssertRCReturn(rc, rc);
 
+        /** @todo pre-increment RIP before hypercall will break when we have to implement
+         *  continuing hypercalls (e.g. Hyper-V). */
         rc = GIMHypercall(pVCpu, pMixedCtx);
         /* If the hypercall changes anything other than guest general-purpose registers,