Changeset 58535 in vbox for trunk/src/recompiler

Timestamp:

Oct 30, 2015 1:51:27 PM (9 years ago)

Author:

vboxsync

Message:

REMR3EmulateInstruction: Corrected assertion.

File:

• trunk/src/recompiler/VBoxRecompiler.c (modified) (2 diffs)

trunk/src/recompiler/VBoxRecompiler.c

@@ -796 +796 @@
      */
     interrupt_request = pVM->rem.s.Env.interrupt_request;
-    Assert(!(interrupt_request & ~(CPU_INTERRUPT_HARD | CPU_INTERRUPT_EXITTB | CPU_INTERRUPT_TIMER  | CPU_INTERRUPT_EXTERNAL_HARD | CPU_INTERRUPT_EXTERNAL_EXIT | CPU_INTERRUPT_EXTERNAL_FLUSH_TLB | CPU_INTERRUPT_EXTERNAL_TIMER)));
+    Assert(!(interrupt_request & ~(CPU_INTERRUPT_HARD | CPU_INTERRUPT_EXITTB | CPU_INTERRUPT_TIMER | CPU_INTERRUPT_EXTERNAL_HARD | CPU_INTERRUPT_EXTERNAL_EXIT | CPU_INTERRUPT_EXTERNAL_FLUSH_TLB | CPU_INTERRUPT_EXTERNAL_TIMER)));
     pVM->rem.s.Env.interrupt_request = 0;
     cpu_single_step(&pVM->rem.s.Env, 1);
@@ -936 +936 @@
     {
         int interrupt_request = pVM->rem.s.Env.interrupt_request;
-        Assert(!(interrupt_request & ~(CPU_INTERRUPT_HARD | CPU_INTERRUPT_EXITTB | CPU_INTERRUPT_TIMER | CPU_INTERRUPT_EXTERNAL_HARD | CPU_INTERRUPT_EXTERNAL_EXIT | CPU_INTERRUPT_EXTERNAL_FLUSH_TLB | CPU_INTERRUPT_EXTERNAL_TIMER)));
+        /* Ignore CPU_INTERRUPT_HARD as it only reflects FF. */
+        /* Ignore CPU_INTERRUPT_TIMER as it doesn't seem to be set anywhere anymore and would reflect a FF. */
+        /* Ignore CPU_INTERRUPT_EXTERNAL_HARD as it is subject to races and reflects a FF. */
+        /* Ignore CPU_INTERRUPT_EXTERNAL_TIMER as it is subject to races and reflects a FF. */
+        /* Ignore CPU_INTERRUPT_EXTERNAL_EXIT as it is subject to races and reflects one or more FFs. */
+        Assert(!(interrupt_request & ~(/*CPU_INTERRUPT_HARD |*/ CPU_INTERRUPT_EXITTB /*| CPU_INTERRUPT_TIMER | CPU_INTERRUPT_EXTERNAL_HARD | CPU_INTERRUPT_EXTERNAL_EXIT*/ | CPU_INTERRUPT_EXTERNAL_FLUSH_TLB /*| CPU_INTERRUPT_EXTERNAL_TIMER*/)));
 #ifdef REM_USE_QEMU_SINGLE_STEP_FOR_LOGGING
         cpu_single_step(&pVM->rem.s.Env, 0);