Changeset 58589 in vbox for trunk/src/VBox/Devices

Timestamp:

Nov 5, 2015 4:00:52 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

103947

Message:

lwip: tcp_restore_pbuf - factor out code to restore syn pbuf passed to
the proxy accept callback into a new function.

File:

• trunk/src/VBox/Devices/Network/lwip-new/src/core/tcp_in.c (modified) (4 diffs)

trunk/src/VBox/Devices/Network/lwip-new/src/core/tcp_in.c

@@ -95 +95 @@
 #if LWIP_CONNECTION_PROXY
 static err_t tcp_proxy_listen_input(struct pbuf *p);
+static void tcp_restore_pbuf(struct pbuf *p);
 
 void
@@ -255 +256 @@
        * create ICMP datagram.
        */
-      pbuf_header(p, ip_current_header_tot_len() + hdrlen * 4);
       tcp_proxy_listen_input(p);
       pbuf_free(p);
@@ -613 +613 @@
 
 #if LWIP_CONNECTION_PROXY
+/*
+ * Proxy accept callback will be passed the pbuf with the SYN segment
+ * so that it can use it for ICMP errors if necessary.  Undo changes
+ * we've done to the pbuf so that it's suitable to be passed to
+ * icmp_send_response().
+ */
+static void
+tcp_restore_pbuf(struct pbuf *p)
+{
+    u8_t hdrlen = TCPH_HDRLEN(tcphdr);
+
+    /* Reveal IP and TCP headers. */
+    pbuf_header(p, ip_current_header_tot_len() + hdrlen * 4);
+
+    /* Convert fields in the TCP header back to network byte order. */
+    tcphdr->src = htons(tcphdr->src);
+    tcphdr->dest = htons(tcphdr->dest);
+    tcphdr->seqno = htonl(tcphdr->seqno);
+    tcphdr->ackno = htonl(tcphdr->ackno);
+    tcphdr->wnd = htons(tcphdr->wnd);
+}
+
+
 /**
  * We run proxied packets through tcp_input() since it mostly does
@@ -707 +730 @@
      * For the proxy to be able to create ICMP unreachable datagram we
      * need to keep the beginning of the pbuf around.  We pass is as
-     * callback arg here and let callback decide.  Payload is already
-     * moved back to the IP header by the caller.
+     * callback arg here and let callback decide.
      */
 
-    /*
-     * Convert fields in the TCP header back to network byte order
-     * (for ICMP).  I think it's safe to do now, as tcphdr will not be
-     * accessed after this.
-     */
-    tcphdr->src = htons(tcphdr->src);
-    tcphdr->dest = htons(tcphdr->dest);
-    tcphdr->seqno = htonl(tcphdr->seqno);
-    tcphdr->ackno = htonl(tcphdr->ackno);
-    tcphdr->wnd = htons(tcphdr->wnd);
-
+    tcp_restore_pbuf(p);
     npcb->callback_arg = (void *)p;