Changeset 58697 in vbox for trunk/src/VBox/HostDrivers/Support/solaris

Timestamp:

Nov 16, 2015 2:42:34 PM (9 years ago)

Author:

vboxsync

Message:

Solaris/r0drv,SUPDrv: Don't drop log messages on bad-preemption context as we miss errors.
Added a warning instead and during normal VBox operation we should eliminate messages with the warning prefix.

File:

• trunk/src/VBox/HostDrivers/Support/solaris/SUPDrv-solaris.c (modified) (2 diffs)

trunk/src/VBox/HostDrivers/Support/solaris/SUPDrv-solaris.c

@@ -1273 +1273 @@
     char        szMsg[512];
 
-    /* cmn_err() acquires adaptive mutexes. Not preemption safe, see @bugref{6657}. */
-    if (!RTThreadPreemptIsEnabled(NIL_RTTHREAD))
-        return 0;
-
     va_start(args, pszFormat);
     RTStrPrintfV(szMsg, sizeof(szMsg) - 1, pszFormat, args);
@@ -1282 +1278 @@
 
     szMsg[sizeof(szMsg) - 1] = '\0';
-    cmn_err(CE_CONT, "%s", szMsg);
+    /* cmn_err() acquires adaptive mutexes. Not preemption safe, see @bugref{6657}. */
+    if (RTThreadPreemptIsEnabled(NIL_RTTHREAD))
+        cmn_err(CE_CONT, "%s", szMsg);
+    else
+        cmn_err(CE_CONT, "[!BadPreemptCtx!] %s", szMsg);
     return 0;
 }