Changeset 59184 in vbox

Timestamp:

Dec 18, 2015 1:38:29 PM (9 years ago)

Author:

vboxsync

Message:

iprt/list.h,DevIchHda.cpp: Introduced RTLISTNODER3 and RTLISTANCHORR3 to avoid ugly padding unions in cross context code.

Location:

trunk

Files:

• include/iprt/list.h (modified) (1 diff)
• src/VBox/Devices/Audio/DevIchHda.cpp (modified) (2 diffs)

trunk/include/iprt/list.h

@@ -69 +69 @@
 /** Pointer to a const doubly linked list anchor. */
 typedef RTLISTANCHOR const *PCRTLISTANCHOR;
+
+/** Version of RTLISTNODE for holding a ring-3 only list in data which gets
+ * shared between multiple contexts */
+#if defined(IN_RING3)
+typedef RTLISTNODE RTLISTNODER3;
+#else
+typedef struct { RTR3PTR aOffLimits[2]; } RTLISTNODER3;
+#endif
+/** Version of RTLISTANCHOR for holding a ring-3 only list in data which gets
+ * shared between multiple contexts */
+typedef RTLISTNODER3 RTLISTANCHORR3;
 
 

trunk/src/VBox/Devices/Audio/DevIchHda.cpp

@@ -651 +651 @@
 typedef struct HDADRIVER
 {
-    union
-    {
-        /** Node for storing this driver in our device driver
-         *  list of HDASTATE. */
-        RTLISTNODE                     Node;
-        struct
-        {
-            R3PTRTYPE(void *)          dummy1;
-            R3PTRTYPE(void *)          dummy2;
-        } dummy;
-    };
+    /** Node for storing this driver in our device driver list of HDASTATE. */
+    RTLISTNODER3                       Node;
 
     /** Pointer to HDA controller (state). */
@@ -754 +745 @@
     /** Pointer to HDA codec to use. */
     R3PTRTYPE(PHDACODEC)               pCodec;
-    union
-    {
-        /** List of associated LUN drivers (HDADRIVER). */
-        RTLISTANCHOR                   lstDrv;
-        /** Padding for alignment. */
-        struct
-        {
-            R3PTRTYPE(void *)          dummy1;
-            R3PTRTYPE(void *)          dummy2;
-        } dummy;
-    };
+    /** List of associated LUN drivers (HDADRIVER). */
+    RTLISTANCHORR3                     lstDrv;
     /** The device' software mixer. */
     R3PTRTYPE(PAUDIOMIXER)             pMixer;