Changeset 59395 in vbox

Timestamp:

Jan 19, 2016 2:33:43 AM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

105092

Message:

VirtualBox_TypeLibWithInterfaces.xsl: Die complaining during packing if an interface has more than 256 methods in total.

File:

• trunk/src/VBox/Installer/win/VirtualBox_TypeLibWithInterfaces.xsl (modified) (2 diffs)

trunk/src/VBox/Installer/win/VirtualBox_TypeLibWithInterfaces.xsl

@@ -230 +230 @@
 
   <!-- Compute the result. -->
-  <xsl:value-of select="$cMethods + $cReservedMethods + $cReadOnlyAttributes + ($cReadWriteAttributes * 2) + $cReservedAttributes + $cParent"/>
+  <xsl:variable name="cMethodsTotal"
+    select="$cMethods + $cReservedMethods + $cReadOnlyAttributes
+          + ($cReadWriteAttributes * 2) + $cReservedAttributes + $cParent"/>
+  <xsl:value-of select="$cMethodsTotal"/>
 
   <!-- For debugging! -->
-  <xsl:if test="0">
+  <xsl:if test="0 or $cMethodsTotal > 256">
     <xsl:message terminate="no">
       <xsl:text>Debug: cMethods=</xsl:text><xsl:value-of select="$cMethods"/>
@@ -244 +247 @@
       <xsl:text> parent=</xsl:text><xsl:value-of select="$sParent"/>
     </xsl:message>
+    <xsl:if test="$cMethodsTotal > 256">
+      <xsl:message terminate="yes">
+        <xsl:text>
+Fatal xidl error: Interface </xsl:text><xsl:value-of select="@name"/>
+        <xsl:text> has </xsl:text><xsl:value-of select="$cMethodsTotal"/>
+        <xsl:text>! The maximum that older windows allows for proxy stubs is 256.
+                  Please try adjust the number of reserved methods or attributes,
+                  though it's clearly time to consider splitting up this monster interface.
+
+</xsl:text>
+      </xsl:message>
+    </xsl:if>
   </xsl:if>
 </xsl:template>