Changeset 59563 in vbox

Timestamp:

Feb 2, 2016 6:26:24 PM (9 years ago)

Author:

vboxsync

Message:

IEM: Updated todo. Unwated blank line.

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• IEMAll.cpp (modified) (1 diff)
• IEMAllCImpl.cpp.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAll.cpp

@@ -7655 +7655 @@
            but it still only writes the lower word... */
         /** @todo Test this on new HW and on AMD and in 64-bit mode.  Also test what
-         *        happens when crossing an electric page boundrary, is the high word
-         *        checked for write accessibility or not? Probably it is.  What about
-         *        segment limits? */
+         * happens when crossing an electric page boundrary, is the high word checked
+         * for write accessibility or not? Probably it is.  What about segment limits?
+         * It appears this behavior is also shared with trap error codes.
+         *
+         * Docs indicate the behavior changed maybe in Pentium or Pentium Pro. Check
+         * ancient hardware when it actually did change. */
         uint16_t *pu16Dst;
         rc = iemMemMap(pIemCpu, (void **)&pu16Dst, sizeof(uint32_t), X86_SREG_SS, GCPtrTop, IEM_ACCESS_STACK_RW);

trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h

@@ -3618 +3618 @@
     if (IEM_IS_LONG_MODE(pIemCpu))
         return IEM_CIMPL_CALL_1(iemCImpl_iret_long, enmEffOpSize);
-
     return     IEM_CIMPL_CALL_1(iemCImpl_iret_prot, enmEffOpSize);
 }