Changeset 59675 in vbox for trunk/src/VBox/Runtime/testcase

Timestamp:

Feb 15, 2016 10:39:32 AM (9 years ago)

Author:

vboxsync

Message:

RTAsn1BitString_EncodeWrite: Fixed assertion. Added testcase which triggers it.

Location:

trunk/src/VBox/Runtime/testcase

Files:

• Makefile.kmk (modified) (1 diff)
• tstRTCrX509-1.cpp (modified) (3 diffs)
• tstRTCrX509-cert1.der (added)
• tstRTCrX509-cert1.pem (added)

trunk/src/VBox/Runtime/testcase/Makefile.kmk

@@ -271 +271 @@
         Pem_sha384=$(PATH_SUB_CURRENT)/tstRTCrX509-sha384.pem \
         Pem_sha512=$(PATH_SUB_CURRENT)/tstRTCrX509-sha512.pem \
+        Pem_cert1=$(PATH_SUB_CURRENT)/tstRTCrX509-cert1.pem \
        \
-        CertDer_md4=$(PATH_SUB_CURRENT)/tstRTCrX509-md4-cert.der \
-        CertDer_md5=$(PATH_SUB_CURRENT)/tstRTCrX509-md5-cert.der \
-        CertDer_sha1=$(PATH_SUB_CURRENT)/tstRTCrX509-sha1-cert.der \
-        CertDer_sha224=$(PATH_SUB_CURRENT)/tstRTCrX509-sha224-cert.der \
-        CertDer_sha256=$(PATH_SUB_CURRENT)/tstRTCrX509-sha256-cert.der \
-        CertDer_sha384=$(PATH_SUB_CURRENT)/tstRTCrX509-sha384-cert.der \
-        CertDer_sha512=$(PATH_SUB_CURRENT)/tstRTCrX509-sha512-cert.der \
+        Der_md4=$(PATH_SUB_CURRENT)/tstRTCrX509-md4-cert.der \
+        Der_md5=$(PATH_SUB_CURRENT)/tstRTCrX509-md5-cert.der \
+        Der_sha1=$(PATH_SUB_CURRENT)/tstRTCrX509-sha1-cert.der \
+        Der_sha224=$(PATH_SUB_CURRENT)/tstRTCrX509-sha224-cert.der \
+        Der_sha256=$(PATH_SUB_CURRENT)/tstRTCrX509-sha256-cert.der \
+        Der_sha384=$(PATH_SUB_CURRENT)/tstRTCrX509-sha384-cert.der \
+        Der_sha512=$(PATH_SUB_CURRENT)/tstRTCrX509-sha512-cert.der \
+        Der_cert1=$(PATH_SUB_CURRENT)/tstRTCrX509-cert1.der \
        $(NO_SUCH_VARIABLE)
 $$(tstRTCrX509-1_0_OUTDIR)/tstRTCrX509-1.h: \

trunk/src/VBox/Runtime/testcase/tstRTCrX509-1.cpp

@@ -48 +48 @@
     const char     *pszFile;
     bool            fMaybeNotInOpenSSL;
+    bool            fSelfSigned;
 
     char const     *pchPem;
@@ -56 +57 @@
 } g_aFiles[] =
 {
-#define MY_CERT_ENTRY(a_fMaybeNotInOpenSSL, a_Name) \
-    { #a_Name, a_fMaybeNotInOpenSSL, \
+#define MY_CERT_ENTRY(a_fMaybeNotInOpenSSL, a_fSelfSigned, a_Name) \
+    { #a_Name, a_fMaybeNotInOpenSSL, a_fSelfSigned, \
       (const char *)RT_CONCAT(g_abPem_, a_Name), RT_CONCAT(g_cbPem_, a_Name), \
-      RT_CONCAT(g_abCertDer_, a_Name), RT_CONCAT(g_cbCertDer_, a_Name) }
-    MY_CERT_ENTRY(true,  md4),
-    MY_CERT_ENTRY(false, md5),
-    MY_CERT_ENTRY(false, sha1),
-/// @todo fix this:    MY_CERT_ENTRY(false, sha224),
-    MY_CERT_ENTRY(false, sha256),
-    MY_CERT_ENTRY(false, sha384),
-    MY_CERT_ENTRY(false, sha512),
+                    RT_CONCAT(g_abDer_, a_Name), RT_CONCAT(g_cbDer_, a_Name) }
+    MY_CERT_ENTRY(true,   true, md4),
+    MY_CERT_ENTRY(false,  true, md5),
+    MY_CERT_ENTRY(false,  true, sha1),
+/// @todo fix this:    MY_CERT_ENTRY(false,  true, sha224),
+    MY_CERT_ENTRY(false,  true, sha256),
+    MY_CERT_ENTRY(false,  true, sha384),
+    MY_CERT_ENTRY(false,  true, sha512),
+    MY_CERT_ENTRY(false, false, cert1),
 };
 
@@ -140 +142 @@
 
                             /*
-                             * Check that our self signed check works, since all of them are self signed.
+                             * Check that our self signed check works.
                              */
-                            RTTESTI_CHECK(RTCrX509Certificate_IsSelfSigned(&Cert0));
-                            RTTESTI_CHECK(RTCrX509Certificate_IsSelfSigned(&Cert1));
-                            RTTESTI_CHECK(RTCrX509Certificate_IsSelfSigned(&Cert2));
+                            RTTESTI_CHECK(RTCrX509Certificate_IsSelfSigned(&Cert0) == g_aFiles[i].fSelfSigned);
+                            RTTESTI_CHECK(RTCrX509Certificate_IsSelfSigned(&Cert1) == g_aFiles[i].fSelfSigned);
+                            RTTESTI_CHECK(RTCrX509Certificate_IsSelfSigned(&Cert2) == g_aFiles[i].fSelfSigned);
 
-                            /*
-                             * Verify the certificate signature (self signed).
-                             */
-                            for (j = 0; j < RT_ELEMENTS(paCerts); j++)
+                            if (g_aFiles[i].fSelfSigned)
                             {
-                                rc = RTCrX509Certificate_VerifySignatureSelfSigned(paCerts[j], NULL /*pErrInfo*/);
-                                if (   RT_FAILURE(rc)
-                                    && (   rc != VERR_CR_PKIX_OSSL_CIPHER_ALGO_NOT_KNOWN_EVP
-                                        || !g_aFiles[i].fMaybeNotInOpenSSL) )
-                                    RTTestIFailed("RTCrX509Certificate_VerifySignatureSelfSigned failed for %s (#%u), variation %u: %Rrc",
-                                                  g_aFiles[i].pszFile, i, j, rc);
+                                /*
+                                 * Verify the certificate signature (self signed).
+                                 */
+                                for (j = 0; j < RT_ELEMENTS(paCerts); j++)
+                                {
+                                    rc = RTCrX509Certificate_VerifySignatureSelfSigned(paCerts[j], NULL /*pErrInfo*/);
+                                    if (   RT_FAILURE(rc)
+                                        && (   rc != VERR_CR_PKIX_OSSL_CIPHER_ALGO_NOT_KNOWN_EVP
+                                            || !g_aFiles[i].fMaybeNotInOpenSSL) )
+                                        RTTestIFailed("RTCrX509Certificate_VerifySignatureSelfSigned failed for %s (#%u), variation %u: %Rrc",
+                                                      g_aFiles[i].pszFile, i, j, rc);
+                                }
                             }
-
                         }