Changeset 59747 in vbox for trunk/src/VBox/Debugger

Timestamp:

Feb 19, 2016 11:18:18 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

105617

Message:

iprt/asm.h: Cleaned up the ASMMemIsAll8/U32 mess and implmeneted the former in assembly. (Found inverted usage due to bad naming in copyUtf8Block, but it is fortunately an unused method.) Replaces the complicated ASMBitFirstSet based scanning in RTSgBufIsZero with a simple call to the new ASMMemIsZero function.

Location:

trunk/src/VBox/Debugger

Files:

• DBGPlugInCommonELFTmpl.cpp.h (modified) (1 diff)
• DBGPlugInSolaris.cpp (modified) (2 diffs)

trunk/src/VBox/Debugger/DBGPlugInCommonELFTmpl.cpp.h

@@ -125 +125 @@
     if (pEhdr->e_shentsize != sizeof(Elf_Shdr))
         return VERR_BAD_EXE_FORMAT;
-    if (ASMMemIsAll8(&pEhdr->e_ident[EI_PAD], EI_NIDENT - EI_PAD, 0) != NULL) //??
+    if (!ASMMemIsZero(&pEhdr->e_ident[EI_PAD], EI_NIDENT - EI_PAD)) //??
         return VERR_BAD_EXE_FORMAT;
 

trunk/src/VBox/Debugger/DBGPlugInSolaris.cpp

@@ -475 +475 @@
         ||  Module.hdr.e_ident[EI_DATA] != ELFDATA2LSB
         ||  Module.hdr.e_ident[EI_VERSION] != EV_CURRENT
-        ||  ASMMemIsAll8(&Module.hdr.e_ident[EI_PAD], EI_NIDENT - EI_PAD, 0) != NULL
+        ||  !ASMMemIsZero(&Module.hdr.e_ident[EI_PAD], EI_NIDENT - EI_PAD)
         )
         return;
@@ -622 +622 @@
         ||  Module.hdr.e_ident[EI_DATA] != ELFDATA2LSB
         ||  Module.hdr.e_ident[EI_VERSION] != EV_CURRENT
-        ||  ASMMemIsAll8(&Module.hdr.e_ident[EI_PAD], EI_NIDENT - EI_PAD, 0) != NULL
+        ||  !ASMMemIsZero(&Module.hdr.e_ident[EI_PAD], EI_NIDENT - EI_PAD)
         )
         return;