Changeset 59882 in vbox

Timestamp:

Mar 1, 2016 10:43:06 AM (9 years ago)

Author:

vboxsync

Message:

VBoxMouse: bugref:8260: Windows mouse filter should use correct device

File:

• trunk/src/VBox/Additions/WINNT/Mouse/NT5/VBoxMFInternal.cpp (modified) (4 diffs)

trunk/src/VBox/Additions/WINNT/Mouse/NT5/VBoxMFInternal.cpp

@@ -216 +216 @@
     KeAcquireSpinLock(&g_ctx.SyncLock, &Irql);
     InsertHeadList(&g_ctx.DevExtList, &pDevExt->ListEntry);
-    if (!g_ctx.pCurrentDevExt)
+    /* g_ctx.pCurrentDevExt must be associated with the i8042prt device. */
+    if (pDevExt->bHostMouse && !g_ctx.pCurrentDevExt)
     {
         ASMAtomicWritePtr(&g_ctx.pCurrentDevExt, pDevExt);
@@ -243 +244 @@
     if (g_ctx.pCurrentDevExt == pDevExt)
     {
+        /* The PS/2 mouse is being removed. Usually never happens. */
         ObDereferenceObject(pDevExt->pdoSelf);
         g_ctx.pCurrentDevExt = NULL;
-        for (PLIST_ENTRY pCur = g_ctx.DevExtList.Flink; pCur != &g_ctx.DevExtList; pCur = pCur->Flink)
-        {
-            PVBOXMOUSE_DEVEXT pNewCurDevExt = PVBOXMOUSE_DEVEXT_FROM_LE(pCur);
-            ASMAtomicWritePtr(&g_ctx.pCurrentDevExt, pNewCurDevExt);
-            /* ensure the object is not deleted while it is being used by a poller thread */
-            ObReferenceObject(pNewCurDevExt->pdoSelf);
-            break;
-        }
     }
 
@@ -347 +341 @@
         }
     }
-
-    vboxNewProtDeviceAdded(pDevExt);
 
     if (!vboxIsHostMouseFound())
@@ -424 +416 @@
         }
     }
+
+    /* Finally call the handler, which needs a correct pDevExt->bHostMouse value. */
+    vboxNewProtDeviceAdded(pDevExt);
+
     LOGF_LEAVE();
 }