Changeset 60388 in vbox for trunk/src/VBox

Timestamp:

Apr 8, 2016 8:39:35 AM (9 years ago)

Author:

vboxsync

Message:

APICR0InitVM: Added @todo hinting that it's not at all needed.

File:

• trunk/src/VBox/VMM/VMMR0/APICR0.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/APICR0.cpp

@@ -52 +52 @@
     size_t const cbApicPib = RT_ALIGN_Z(pVM->cCpus * sizeof(APICPIB), PAGE_SIZE);
     int rc = RTR0MemObjAllocCont(&pApic->hMemObjApicPibR0, cbApicPib, false /* fExecutable */);
+/** @todo r=bird: You can do all this from ring-3 via
+ * SUPR3ContAlloc/SUPR3LowAlloc. I would though, suggest using SUPR3PageAllocEx
+ * on AMD64 systems (RC is in PAE mode on AMD64 systems, so that should work
+ * regardless of HM or RC, I think), since it's generally faster and more
+ * reliable to get memory without physical address restraints.
+ */
     if (RT_SUCCESS(rc))
     {