Changeset 60436 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Apr 11, 2016 5:37:05 PM (9 years ago)

Author:

vboxsync

Message:

FE/Qt: ​bugref:8312: VBoxGlobal: Small cleanup for global UI prepare/cleanup procedures, mostly comments but also some code order, s.a. r106421.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxGlobal.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxGlobal.cpp

@@ -4352 +4352 @@
     mValid = true;
 
+    /* Prepare converter: */
     UIConverter::prepare();
 
-    /* Create medium enumerator but don't do any immediate caching. */
+    /* Create medium-enumerator but don't do any immediate caching: */
     m_pMediumEnumerator = new UIMediumEnumerator;
     {
@@ -4389 +4390 @@
 void VBoxGlobal::cleanup()
 {
-    /* Preventing some unwanted stuff
-     * which could de called from the other threads: */
+    // TODO: Shouldn't that be protected with a mutex or something?
+    /* Remember that the cleanup is in progress preventing any unwanted
+     * stuff which could be called from the other threads: */
     m_sfCleanupInProgress = true;
 
@@ -4406 +4408 @@
 #ifdef VBOX_GUI_WITH_PIDFILE
     deletePidfile();
-#endif
-
-    /* Destroy the GUI root windows _BEFORE_ the media-mess, because there is
-       code in the GUI that's using the media code an will be racing us! */
+#endif /* VBOX_GUI_WITH_PIDFILE */
+
+    /* Destroy the GUI root windows _BEFORE_
+     * the media related code which could race us: */
     if (gpSelectorWindow)
         UISelectorWindow::destroy();
     if (gpMachine)
         UIMachine::destroy();
-    /* As part of recent change UIVirtualBoxEventHandler also used in runtimeUI.
-     * This needs to be destroyed before COM cleanup. As this is supposed to be only part of selectorUI,
-     * and needs to be reworked later doing this here for now: */
-    if (gpMachine)
-        UIVirtualBoxEventHandler::destroy();
-
-    /* Cleanup medium-enumerator: */
+
+    /* Starting medium-enumerator cleanup: */
     m_mediumEnumeratorDtorRwLock.lockForWrite();
-    delete m_pMediumEnumerator;
-    m_pMediumEnumerator = 0;
+    {
+        /* Destroy medium-enumerator: */
+        delete m_pMediumEnumerator;
+        m_pMediumEnumerator = 0;
+    }
+    /* Finishing medium-enumerator cleanup: */
     m_mediumEnumeratorDtorRwLock.unlock();
 
-    /* Destroy extra-data manager: */
+    /* Destroy the global (VirtualBox) Main event handler
+     * which is used in both Selector and Runtime UI. */
+    UIVirtualBoxEventHandler::destroy();
+
+    /* Destroy the extra-data manager finally after everything
+     * above which could use it already destroyed: */
     UIExtraDataManager::destroy();
 
-    /* Destroy whatever this converter stuff is: */
+    /* Cleanup converter: */
     UIConverter::cleanup();
 
@@ -4439 +4445 @@
     m_pIconPool = 0;
 
-    /* ensure CGuestOSType objects are no longer used */
+    /* Ensure CGuestOSType objects are no longer used: */
     m_guestOSFamilyIDs.clear();
     m_guestOSTypes.clear();