Changeset 60532 in vbox for trunk/src

Timestamp:

Apr 18, 2016 9:24:40 AM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

106656

Message:

webservice: Speed up termination (and also trigger proper cleanup for SIGTERM), should be now well below 1 second. Play safe in the service scripts and wait for a second on service termination, to give it time to clean up. Otherwise a service restart can fail for no good reason.

Location:

trunk/src/VBox

Files:

• Installer/linux/vboxweb-service.sh (modified) (1 diff)
• Installer/solaris/smf-vboxwebsrv.sh (modified) (1 diff)
• Main/webservice/vboxweb.cpp (modified) (5 diffs)

trunk/src/VBox/Installer/linux/vboxweb-service.sh

@@ -168 +168 @@
         killproc $binary
         RETVAL=$?
+        # Be careful: wait 1 second, making sure that everything is cleaned up.
+        sleep 1
         if ! pidof $binary > /dev/null 2>&1; then
             rm -f $PIDFILE

trunk/src/VBox/Installer/solaris/smf-vboxwebsrv.sh

@@ -125 +125 @@
         # Kill service contract
         smf_kill_contract $2 TERM 1
+        # Be careful: wait 1 second, making sure that everything is cleaned up.
+        smf_kill_contract $2 TERM 1
     ;;
     *)

trunk/src/VBox/Main/webservice/vboxweb.cpp

@@ -908 +908 @@
         g_pSoapQ = new SoapQ(&soap);
 
-        for (uint64_t i = 1; g_fKeepRunning; i++)
-        {
+        uint64_t cAccepted = 1;
+        while (g_fKeepRunning)
+        {
+            struct timeval timeout;
+            fd_set fds;
+            int rv;
+            for (;;)
+            {
+                timeout.tv_sec = 60;
+                timeout.tv_usec = 0;
+                FD_ZERO(&fds);
+                FD_SET(soap.master, &fds);
+                rv = select((int)soap.master + 1, &fds, &fds, &fds, &timeout);
+                if (rv > 0)
+                    break; // work is waiting
+                else if (rv == 0)
+                    continue; // timeout, not necessary to bother gsoap
+                else // r < 0, errno
+                {
+                    if (soap_socket_errno(soap.master) == SOAP_EINTR)
+                        rv = 0; // re-check if we should terminate
+                    break;
+                }
+            }
+            if (rv == 0)
+                continue;
+
             // call gSOAP to handle incoming SOAP connection
-            soap.accept_timeout = 10;
+            soap.accept_timeout = -1; // 1usec timeout, actual waiting is above
             s = soap_accept(&soap);
             if (!soap_valid_socket(s))
@@ -923 +948 @@
             // pick up the job
             size_t cItemsOnQ = g_pSoapQ->add(s);
-            LogRel(("Request %llu on socket %d queued for processing (%d items on Q)\n", i, s, cItemsOnQ));
+            LogRel(("Request %llu on socket %d queued for processing (%d items on Q)\n", cAccepted, s, cItemsOnQ));
+            cAccepted++;
         }
 
@@ -1321 +1347 @@
 #else
     signal(SIGINT,   websrvSignalHandler);
+    signal(SIGTERM,  websrvSignalHandler);
 # ifdef SIGBREAK
     signal(SIGBREAK, websrvSignalHandler);
@@ -1346 +1373 @@
 #else
     signal(SIGINT,   SIG_DFL);
+    signal(SIGTERM,  SIG_DFL);
 # ifdef SIGBREAK
     signal(SIGBREAK, SIG_DFL);
@@ -1351 +1379 @@
 #endif
 
+    RTThreadPoke(threadQPumper);
     RTThreadWait(threadQPumper, 30000, NULL);
     if (threadWatchdog != NIL_RTTHREAD)
+    {
+        RTThreadPoke(threadWatchdog);
         RTThreadWait(threadWatchdog, g_iWatchdogCheckInterval * 1000 + 10000, NULL);
+    }
 
     /* VirtualBoxClient events unregistration. */