Changeset 60549 in vbox for trunk

Timestamp:

Apr 18, 2016 5:35:25 PM (9 years ago)

Author:

vboxsync

Message:

ValidationKit/usb: Fixes for the USB testcase and enhance addUsbDeviceFilter

Location:

trunk/src/VBox/ValidationKit

Files:

• testdriver/vboxwrappers.py (modified) (2 diffs)
• tests/usb/tdUsb1.py (modified) (1 diff)

trunk/src/VBox/ValidationKit/testdriver/vboxwrappers.py

@@ -2010 +2010 @@
         return fRc;
 
-    def addUsbDeviceFilter(self, sName, sVendorId, sProductId):
+    def addUsbDeviceFilter(self, sName, sVendorId = None, sProductId = None, sRevision = None, \
+                           sManufacturer = None, sProduct = None, sSerialNumber = None, \
+                           sPort = None, sRemote = None):
         """
         Creates a USB device filter and inserts it into the VM.
@@ -2019 +2021 @@
 
         try:
-            usbDevFilter = self.o.machine.USBDeviceFilters.createDeviceFilter(sName);
-            usbDevFilter.active = True;
-            usbDevFilter.vendorId = sVendorId;
-            usbDevFilter.productId = sProductId;
-            try:
-                self.o.machine.USBDeviceFilters.insertDeviceFilter(0, usbDevFilter);
+            oUsbDevFilter = self.o.machine.USBDeviceFilters.createDeviceFilter(sName);
+            oUsbDevFilter.active = True;
+            if sVendorId is not None:
+                oUsbDevFilter.vendorId = sVendorId;
+            if sProductId is not None:
+                oUsbDevFilter.productId = sProductId;
+            if sRevision is not None:
+                oUsbDevFilter.revision = sRevision;
+            if sManufacturer is not None:
+                oUsbDevFilter.manufacturer = sManufacturer;
+            if sProduct is not None:
+                oUsbDevFilter.product = sProduct;
+            if sSerialNumber is not None:
+                oUsbDevFilter.serialnumber = sSerialNumber;
+            if sPort is not None:
+                oUsbDevFilter.port = sPort;
+            if sRemote is not None:
+                oUsbDevFilter.remote = sRemote;
+            try:
+                self.o.machine.USBDeviceFilters.insertDeviceFilter(0, oUsbDevFilter);
             except:
                 reporter.errorXcpt('insertDeviceFilter(%s) failed on "%s"' \

trunk/src/VBox/ValidationKit/tests/usb/tdUsb1.py

@@ -315 +315 @@
             self.oVBox.host.addUSBDeviceSource('USBIP', sGadgetHost, sGadgetHost + (':%s' % oUsbGadget.getUsbIpPort()), [], []);
 
-            # Create device filter
-            fRc = oSession.addUsbDeviceFilter('Compliance device', '0525', 'a4a0');
+            # Create test device gadget and a filter to attach the device automatically.
+            fRc = oUsbGadget.impersonate(usbgadget2.g_ksGadgetImpersonationTest);
             if fRc is True:
-                fRc = oUsbGadget.impersonate(usbgadget2.g_ksGadgetImpersonationTest);
+                iBusId, _ = oUsbGadget.getGadgetBusAndDevId();
+                fRc = oSession.addUsbDeviceFilter('Compliance device', sVendorId = '0525', sProductId = 'a4a0', sPort = str(iBusId));
                 if fRc is True:
 
                     # Wait a moment to let the USB device appear
-                    self.sleep(10);
+                    self.sleep(3);
 
                     tupCmdLine = ('UsbTest', );