Changeset 60761 in vbox

Timestamp:

Apr 29, 2016 11:39:41 AM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

106956

Message:

VMM/APIC: Disallow setting the mode as 'disabled'.

File:

• trunk/src/VBox/VMM/VMMR3/APIC.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR3/APIC.cpp

@@ -1495 +1495 @@
     {
         case APICMODE_DISABLED:
+        {
+            /** @todo permanently disabling the APIC won't really work (needs
+             *        fixing in HM, CPUM, PDM and possibly other places). See
+             *        @bugref{8353}. */
+#if 0
             pApic->enmOriginalMode = enmOriginalMode;
             CPUMClearGuestCpuIdFeature(pVM, CPUMCPUIDFEATURE_APIC);
             CPUMClearGuestCpuIdFeature(pVM, CPUMCPUIDFEATURE_X2APIC);
             break;
+#else
+            return VMR3SetError(pVM->pUVM, VERR_INVALID_PARAMETER, RT_SCR_POS, "APIC mode 'disabled' is not supported yet.");
+#endif
+        }
 
         case APICMODE_X2APIC:
@@ -1511 +1520 @@
 
         default:
-            return VMR3SetError(pVM->pUVM, VERR_INVALID_STATE, RT_SRC_POS, "APIC mode %#x unknown.", uOriginalMode);
+            return VMR3SetError(pVM->pUVM, VERR_INVALID_PARAMETER, RT_SRC_POS, "APIC mode %#x unknown.", uOriginalMode);
     }