Changeset 60772 in vbox for trunk/src/VBox/Additions/WINNT/VBoxTray

Timestamp:

Apr 29, 2016 9:16:24 PM (9 years ago)

Author:

vboxsync

Message:

Additions/SharedClipboard: fix for bugref:6466: fixed OpenClipboard() issue when multiple VM started.

File:

• trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxClipboard.cpp (modified) (8 diffs)

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxClipboard.cpp

@@ -95 +95 @@
 }
 
+
+static int vboxOpenClipboard(HWND hwnd)
+{
+    /* "OpenClipboard fails if another window has the clipboard open."
+    * So try a few times and wait up to 1 second.
+    */
+    int rc;
+
+    uint32_t u32SleepMS = 1;
+    int i;
+    for (i = 0; i <= 9; ++i) /* u32SleepMS = [1..512] */
+    {
+        if (OpenClipboard(hwnd))
+        {
+            rc = 0;
+            break;
+        }
+        rc = RTErrConvertFromWin32(GetLastError());
+        
+        RTThreadSleep(u32SleepMS);
+        u32SleepMS <<= 1;
+    }
+#ifdef LOG_ENABLED
+    if (i > 0)
+        LogFlow(("vboxOpenClipboard: %d times tried to open clipboard. \n", ++i));
+#endif
+    return rc;
+}
+
+
 static int vboxClipboardChanged(PVBOXCLIPBOARDCONTEXT pCtx)
 {
@@ -100 +130 @@
 
     /* Query list of available formats and report to host. */
-    int rc = VINF_SUCCESS;
-    if (FALSE == OpenClipboard(pCtx->hwnd))
-    {
-        rc = RTErrConvertFromWin32(GetLastError());
-    }
-    else
+    int rc = vboxOpenClipboard(pCtx->hwnd);
+    if(RT_SUCCESS(rc))
     {
         uint32_t u32Formats = 0;
@@ -147 +173 @@
         CloseClipboard();
         rc = VbglR3ClipboardReportFormats(pCtx->u32ClientID, u32Formats);
+    }
+    else
+    {
+        LogFlow(("vboxClipboardChanged: error in open clipboard. hwnd: %x. err: %Rrc\n", pCtx->hwnd, rc));
     }
     return rc;
@@ -472 +502 @@
              * windows is to be destroyed and therefore the guest side becomes inactive.
              */
-            if (OpenClipboard(hwnd))
+            int res = vboxOpenClipboard(hwnd);
+            if (RT_SUCCESS(res))
             {
                 EmptyClipboard();
                 CloseClipboard();
             }
+            else
+            {
+                LogFlowFunc(("WM_RENDERALLFORMATS: Failed to open clipboard! rc: %Rrc\n", res));
+            }
         } break;
 
@@ -483 +518 @@
             /* Announce available formats. Do not insert data, they will be inserted in WM_RENDER*. */
             uint32_t u32Formats = (uint32_t)lParam;
-
-            if (FALSE == OpenClipboard(hwnd))
-            {
-                LogFlowFunc(("WM_USER: Failed to open clipboard! Last error = %ld\n", GetLastError()));
-            }
-            else
+            
+            int res = vboxOpenClipboard(hwnd);
+            if(RT_SUCCESS(res))
             {
                 EmptyClipboard();
@@ -519 +551 @@
                 LogFlowFunc(("WM_USER: hClip = %p, err = %ld\n", hClip, GetLastError ()));
             }
+            else
+            {
+                LogFlowFunc(("WM_USER: Failed to open clipboard! error = %Rrc\n", res));
+            }
         } break;
 
@@ -527 +563 @@
             HANDLE hClip = NULL;
 
-            if (FALSE == OpenClipboard(hwnd))
-            {
-                LogFlowFunc(("WM_USER: Failed to open clipboard! Last error = %ld\n", GetLastError()));
-            }
-            else
+            int res = vboxOpenClipboard(hwnd);
+            if (RT_SUCCESS(res))
             {
                 int vboxrc;
@@ -602 +635 @@
                 CloseClipboard();
             }
+            else
+            {
+                LogFlowFunc(("WM_USER: Failed to open clipboard! rc: %Rrc\n", res));
+            }
 
             if (hClip == NULL)