Changeset 60917 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

May 10, 2016 10:23:29 AM (9 years ago)

Author:

vboxsync

Message:

FE/Qt: ​​​​​​​​​​bugref:6769: Rework/cleanup file-path selector widget (part 08): More refactoring.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/widgets

Files:

• UIFilePathSelector.cpp (modified) (4 diffs)
• UIFilePathSelector.h (modified) (4 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIFilePathSelector.cpp

@@ -44 +44 @@
 #endif /* !VBOX_WITH_PRECOMPILED_HEADERS */
 
-enum
-{
-    PathId = 0,
-    SelectId,
-    ResetId
-};
-
 
 /** Returns first position of difference between passed strings. */
@@ -133 +126 @@
 }
 
-bool UIFilePathSelector::isEditable() const
-{
-    return m_fEditable;
-}
-
 void UIFilePathSelector::setResetEnabled(bool fEnabled)
 {
@@ -148 +136 @@
     }
     retranslateUi();
-}
-
-bool UIFilePathSelector::isResetEnabled() const
-{
-    return (count() - 1  == ResetId);
-}
-
-bool UIFilePathSelector::isPathSelected() const
-{
-    return (currentIndex() == PathId);
-}
-
-QString UIFilePathSelector::path() const
-{
-    return m_strPath;
 }
 
@@ -171 +144 @@
     if (fRefreshText)
         refreshText();
-}
-
-void UIFilePathSelector::setHomeDir(const QString &strHomeDir)
-{
-    m_strHomeDir = strHomeDir;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIFilePathSelector.h

@@ -54 +54 @@
     };
 
+    /** Combo-box field IDs file-path selector uses. */
+    enum
+    {
+        PathId = 0,
+        SelectId,
+        ResetId
+    };
+
     /** Constructs file-path selector passing @a pParent to QComboBox base-class. */
     UIFilePathSelector(QWidget *pParent = 0);
@@ -65 +73 @@
     void setEditable(bool fEditable);
     /** Returns whether the path is editable. */
-    bool isEditable() const;
+    bool isEditable() const { return m_fEditable; }
 
     /** Defines whether the reseting to defauilt path is @a fEnabled. */
     void setResetEnabled(bool fEnabled);
     /** Returns whether the reseting to defauilt path is enabled. */
-    bool isResetEnabled() const;
+    bool isResetEnabled() const { return count() - 1  == ResetId; }
 
     /** Defines the file-dialog @a strTitle. */
@@ -92 +100 @@
     bool isModified() const { return m_fModified; }
     /** Returns whether the path is selected. */
-    bool isPathSelected() const;
+    bool isPathSelected() const { return currentIndex() == PathId; }
 
     /** Returns the path. */
-    QString path() const;
+    QString path() const { return m_strPath; }
 
 public slots:
@@ -103 +111 @@
 
     /** Defines the @a strHomeDir. */
-    void setHomeDir(const QString &strHomeDir);
+    void setHomeDir(const QString &strHomeDir) { m_strHomeDir = strHomeDir; }
 
 protected: