Changeset 61009 in vbox for trunk/src/VBox/Main/src-all

Timestamp:

May 17, 2016 5:18:29 PM (9 years ago)

Author:

vboxsync

Message:

Main: big settings cleanup and writing optimization. Moved constructors/equality/default checks into the .cpp file, and write only settings which aren't at the default value. Greatly reduces the effort needed to write everything out, especially when a lot of snapshots have to be dealt with. Move the storage controllers to the hardware settings, where they always belonged. No change to the XML file (yet). Lots of settings related cleanups in the API code.

File:

• trunk/src/VBox/Main/src-all/PCIDeviceAttachmentImpl.cpp (modified) (5 diffs)

trunk/src/VBox/Main/src-all/PCIDeviceAttachmentImpl.cpp

@@ -7 +7 @@
 
 /*
- * Copyright (C) 2010-2012 Oracle Corporation
+ * Copyright (C) 2010-2016 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -23 +23 @@
 #include "Logging.h"
 
+#include <VBox/settings.h>
+
 struct PCIDeviceAttachment::Data
 {
-    Data(const Bstr    &aDevName,
+    Data(const Utf8Str &aDevName,
          LONG          aHostAddress,
          LONG          aGuestAddress,
@@ -35 +37 @@
     }
 
-    Bstr             DevName;
+    Utf8Str          DevName;
     LONG             HostAddress;
     LONG             GuestAddress;
@@ -61 +63 @@
 /////////////////////////////////////////////////////////////////////////////
 HRESULT PCIDeviceAttachment::init(IMachine      *aParent,
-                                  const Bstr   &aDevName,
+                                  const Utf8Str &aDevName,
                                   LONG          aHostAddress,
                                   LONG          aGuestAddress,
@@ -83 +85 @@
                                             const settings::HostPCIDeviceAttachment &hpda)
 {
-    Bstr bname(hpda.strDeviceName);
-    return init(aParent, bname,  hpda.uHostAddress, hpda.uGuestAddress, TRUE);
+    return init(aParent, hpda.strDeviceName, hpda.uHostAddress, hpda.uGuestAddress, TRUE);
 }