Changeset 61044 in vbox

Timestamp:

May 19, 2016 12:40:08 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

107309

Message:

apic.h: See r=bird in code.

File:

• trunk/include/VBox/vmm/apic.h (modified) (1 diff)

trunk/include/VBox/vmm/apic.h

@@ -40 +40 @@
 #define MSR_APICBASE_GET_MODE(a)             (((a) >> 10) & UINT64_C(3))
 /** The APIC global enable bit. */
+/** @todo r=bird: Please do   N O T  use _BIT for what clearly are masks!
+ *  See x86.h and vm.h for examples of how we use _BIT elsewhere!
+ * Besides, you are duplicating existing x86.h defines here
+ * (MSR_IA32_APICBASE_XXX). */
 #define MSR_APICBASE_XAPIC_ENABLE_BIT        RT_BIT_64(11)
 /** The x2APIC global enable bit. */