Changeset 61105 in vbox for trunk/src/VBox

Timestamp:

May 20, 2016 2:56:17 PM (9 years ago)

Author:

vboxsync

Message:

vboxwrappers.py: SessionWrapper.powerOff: Moved the deregistration of the event handler to before we try power off the VM as XPCOM/python/someone seems to deadlock occationally if we do it while the call is running.

File:

• trunk/src/VBox/ValidationKit/testdriver/vboxwrappers.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/testdriver/vboxwrappers.py

@@ -2219 +2219 @@
         Returns None if the progress object returns failure.
         """
+        #
+        # Deregister event handler before we power off the VM, otherwise we're
+        # racing for VM process termination and cause misleading spurious
+        # error messages in the event handling code, because the event objects
+        # disappear.
+        #
+        # Note! Doing this before powerDown to try prevent numerous smoketest
+        #       timeouts on XPCOM hosts.
+        #
+        self.deregisterEventHandlerForTask();
+
+
+        # Try power if off.
         try:
             oProgress = self.o.console.powerDown();
@@ -2228 +2241 @@
             return False;
 
-        # Deregister event handler now, otherwise we're racing for VM process
-        # termination and cause misleading spurious error messages in the
-        # event handling code, because the event objects disappear.
-        self.deregisterEventHandlerForTask();
-
+        # Wait on power off operation to complete.
         rc = self.oTstDrv.waitOnProgress(oProgress);
         if rc < 0: