Changeset 61314 in vbox for trunk/src/VBox/Main/src-server

Timestamp:

May 31, 2016 1:19:41 AM (9 years ago)

Author:

vboxsync

Message:

Main/HostDnsService: Ignore "DhcpDomain" key since it's not stable.
Instead use GetAdaptersAddresses() to get the interfaces in the order
the system deems "correct" to harvest IP_ADAPTER_ADDRESSES::DnsSuffix
and use the first one.

File:

• trunk/src/VBox/Main/src-server/win/HostDnsServiceWin.cpp (modified) (7 diffs)

trunk/src/VBox/Main/src-server/win/HostDnsServiceWin.cpp

@@ -15 +15 @@
  * hope that it will be useful, but WITHOUT ANY WARRANTY of any kind.
  */
+
+/*
+ * XXX: need <winsock2.h> to reveal IP_ADAPTER_ADDRESSES in
+ * <iptypes.h> and it must be included before <windows.h>, which is
+ * pulled in by IPRT headers.
+ */
+#include <winsock2.h>
+
 #include "../HostDnsService.h"
 
@@ -26 +34 @@
 #include <Windows.h>
 #include <windns.h>
+#include <iptypes.h>
+#include <iphlpapi.h>
 
 #include <algorithm>
@@ -240 +250 @@
 HRESULT HostDnsServiceWin::updateInfo()
 {
+    HostDnsInformation info;
+
     LONG lrc;
+    int rc;
 
     std::string strDomain;
-    std::string strDhcpDomain;
     std::string strSearchList;  /* NB: comma separated, no spaces */
 
+
+    /*
+     * We ignore "DhcpDomain" key here since it's not stable.  If
+     * there are two active interfaces that use DHCP (in particular
+     * when host uses OpenVPN) then DHCP ACKs will take turns updating
+     * that key.  Instead we call GetAdaptersAddresses() below (which
+     * is what ipconfig.exe seems to do).
+     */
     for (DWORD regIndex = 0; /**/; ++regIndex) {
         char keyName[256];
@@ -265 +285 @@
         if (lrc != ERROR_SUCCESS)
         {
-            LogRel(("HostDnsServiceWin: RegEnumValue error %d\n", (int)lrc));
+            LogRel2(("HostDnsServiceWin: RegEnumValue error %d\n", (int)lrc));
             return E_FAIL;
         }
@@ -278 +298 @@
         {
             strDomain.assign(keyData, cbKeyData);
-            Log2(("... Domain=\"%s\"\n", strDomain.c_str()));
+            LogRel2(("HostDnsServiceWin: Domain=\"%s\"\n", strDomain.c_str()));
         }
         else if (RTStrICmp("DhcpDomain", keyName) == 0)
         {
-            strDhcpDomain.assign(keyData, cbKeyData);
-            Log2(("... DhcpDomain=\"%s\"\n", strDhcpDomain.c_str()));
+            std::string strDhcpDomain(keyData, cbKeyData);
+            LogRel2(("HostDnsServiceWin: DhcpDomain=\"%s\"\n", strDhcpDomain.c_str()));
         }
         else if (RTStrICmp("SearchList", keyName) == 0)
         {
             strSearchList.assign(keyData, cbKeyData);
-            Log2(("... SearchList=\"%s\"\n", strSearchList.c_str()));
-        }
-    }
-
-    HostDnsInformation info;
+            LogRel2(("HostDnsServiceWin: SearchList=\"%s\"\n", strSearchList.c_str()));
+        }
+    }
+
+    /* statically configured domain name */
+    if (!strDomain.empty())
+    {
+        info.domain = strDomain;
+        info.searchList.push_back(strDomain);
+    }
+
+    /* statically configured search list */
+    if (!strSearchList.empty())
+    {
+        vappend(info.searchList, strSearchList, ',');
+    }
+
 
     /*
@@ -318 +350 @@
             RTStrPrintf(szAddrStr, sizeof(szAddrStr), "%RTnaipv4", pIp4Array->AddrArray[i]);
 
-            Log2(("  server %d: %s\n", i+1,  szAddrStr));
+            LogRel2(("HostDnsServiceWin: server %d: %s\n", i+1,  szAddrStr));
             info.servers.push_back(szAddrStr);
         }
@@ -325 +357 @@
     }
 
-    if (!strDomain.empty())
-    {
-        info.domain = strDomain;
-
-        info.searchList.push_back(strDomain);
-        if (!strDhcpDomain.empty() && strDhcpDomain != strDomain)
-            info.searchList.push_back(strDhcpDomain);
-    }
-    else if (!strDhcpDomain.empty())
-    {
-        info.domain = strDhcpDomain;
-        info.searchList.push_back(strDomain);
-    }
-
-    vappend(info.searchList, strSearchList, ',');
+
+    /**
+     * DnsQueryConfig(DnsConfigSearchList, ...) is not implemented.
+     * Call GetAdaptersAddresses() that orders the returned list
+     * appropriately and collect IP_ADAPTER_ADDRESSES::DnsSuffix.
+     */
+    do {
+        PIP_ADAPTER_ADDRESSES pAddrBuf = NULL;
+        ULONG cbAddrBuf = 8 * 1024;
+        bool fReallocated = false;
+        ULONG err;
+
+        pAddrBuf = (PIP_ADAPTER_ADDRESSES) malloc(cbAddrBuf);
+        if (pAddrBuf == NULL)
+        {
+            LogRel2(("HostDnsServiceWin: failed to allocate %zu bytes"
+                     " of GetAdaptersAddresses buffer\n",
+                     (size_t)cbAddrBuf));
+            break;
+        }
+
+        while (pAddrBuf != NULL)
+        {
+            ULONG cbAddrBufProvided = cbAddrBuf;
+
+            err = GetAdaptersAddresses(AF_UNSPEC,
+                                         GAA_FLAG_SKIP_ANYCAST
+                                       | GAA_FLAG_SKIP_MULTICAST,
+                                       NULL,
+                                       pAddrBuf, &cbAddrBuf);
+            if (err == NO_ERROR)
+            {
+                break;
+            }
+            else if (err == ERROR_BUFFER_OVERFLOW)
+            {
+                LogRel2(("HostDnsServiceWin: provided GetAdaptersAddresses with %zu"
+                         " but asked again for %zu bytes\n",
+                         (size_t)cbAddrBufProvided, (size_t)cbAddrBuf));
+
+                if (RT_UNLIKELY(fReallocated)) /* what? again?! */
+                {
+                    LogRel2(("HostDnsServiceWin: ... not going to realloc again\n"));
+                    free(pAddrBuf);
+                    pAddrBuf = NULL;
+                    break;
+                }
+
+                PIP_ADAPTER_ADDRESSES pNewBuf = (PIP_ADAPTER_ADDRESSES) realloc(pAddrBuf, cbAddrBuf);
+                if (pNewBuf == NULL)
+                {
+                    LogRel2(("HostDnsServiceWin: failed to reallocate %zu bytes\n", (size_t)cbAddrBuf));
+                    free(pAddrBuf);
+                    pAddrBuf = NULL;
+                    break;
+                }
+
+                /* try again */
+                pAddrBuf = pNewBuf; /* cbAddrBuf already updated */
+                fReallocated = true;
+            }
+            else
+            {
+                LogRel2(("HostDnsServiceWin: GetAdaptersAddresses error %d\n", err));
+                free(pAddrBuf);
+                pAddrBuf = NULL;
+                break;
+            }
+        }
+
+        if (pAddrBuf == NULL)
+            break;
+
+        for (PIP_ADAPTER_ADDRESSES pAdp = pAddrBuf; pAdp != NULL; pAdp = pAdp->Next)
+        {
+            LogRel2(("HostDnsServiceWin: %ls (status %u) ...\n",
+                     pAdp->FriendlyName ? pAdp->FriendlyName : L"(null)",
+                     pAdp->OperStatus));
+
+            if (pAdp->OperStatus != IfOperStatusUp)
+                continue;
+
+            if (pAdp->DnsSuffix == NULL || *pAdp->DnsSuffix == L'\0')
+                continue;
+
+            char *pszDnsSuffix = NULL;
+            rc = RTUtf16ToUtf8Ex(pAdp->DnsSuffix, RTSTR_MAX,
+                                 &pszDnsSuffix, 0, /* allocate */
+                                 NULL);
+            if (RT_FAILURE(rc))
+            {
+                LogRel2(("HostDnsServiceWin: failed to convert DNS suffix \"%ls\": %Rrc\n",
+                        pAdp->DnsSuffix, rc));
+                continue;
+            }
+
+            AssertContinue(pszDnsSuffix != NULL);
+            AssertContinue(*pszDnsSuffix != '\0');
+            LogRel2(("HostDnsServiceWin: ... suffix = \"%s\"\n", pszDnsSuffix));
+
+            vappend(info.searchList, pszDnsSuffix);
+            RTStrFree(pszDnsSuffix);
+        }
+
+        free(pAddrBuf);
+    } while (0);
+
+
+    if (info.domain.empty() && !info.searchList.empty())
+        info.domain = info.searchList[0];
+
     if (info.searchList.size() == 1)
         info.searchList.clear();