Changeset 6149 in vbox

Timestamp:

Dec 19, 2007 9:42:02 AM (17 years ago)

Author:

vboxsync

Message:

Solaris VBoxService daemon fix.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxService-solaris.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxService-solaris.cpp

@@ -58 +58 @@
         return -1;
 
-    int pid = fork();
+    pid_t pid = fork();
     if (pid < 0)         /* The fork() failed. Bad. */
         return -1;
@@ -69 +69 @@
      * rid of signals, file descriptors & other stuff we inherited from the parent.
      */
-    setsid();
+    pid_t newpgid = setsid();
+    if (newpgid < 0)     /* Failed to create new sesion */
+        return -1;
 
-    /* Close all or only standard streams */
-    int size = noclose ? getdtablesize() : 2;
-    for (int i = size; i >= 0; i--)
-        close(i);
-
-    /* Open stdin(0), stdout(1) and stderr(2) to /dev/null */
-    int fd = open("/dev/null", O_RDWR);
-    dup(fd);
-    dup(fd);
+    /* BSD daemon style. */
+    if (!noclose)
+    {
+        /* Open stdin(0), stdout(1) and stderr(2) to /dev/null */
+        int fd = open("/dev/null", O_RDWR);
+        dup2(fd, STDIN_FILENO);
+        dup2(fd, STDOUT_FILENO);
+        dup2(fd, STDERR_FILENO);
+        if (fd > 2)
+            close(fd);
+    }
 
     /* Switch our current directory to root */