Changeset 61549 in vbox for trunk/src/VBox

Timestamp:

Jun 7, 2016 5:13:34 PM (9 years ago)

Author:

vboxsync

Message:

bugref:8238 VBoxSVC settings - BIOSSettings ParallelPort SerialPortImpl

Location:

trunk/src/VBox/Main/src-server

Files:

• BIOSSettingsImpl.cpp (modified) (6 diffs)
• ParallelPortImpl.cpp (modified) (1 diff)
• SerialPortImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/BIOSSettingsImpl.cpp

@@ -204 +204 @@
 
     m->bd.backup();
-    m->bd->fLogoFadeIn = !!enable;
+    m->bd->fLogoFadeIn = RT_BOOL(enable);
 
     alock.release();
@@ -233 +233 @@
 
     m->bd.backup();
-    m->bd->fLogoFadeOut = !!enable;
+    m->bd->fLogoFadeOut = RT_BOOL(enable);
 
     alock.release();
@@ -349 +349 @@
 
     m->bd.backup();
-    m->bd->fACPIEnabled = !!enable;
+    m->bd->fACPIEnabled = RT_BOOL(enable);
 
     alock.release();
@@ -379 +379 @@
     m->bd.backup();
 
-    m->bd->fIOAPICEnabled = !!aIOAPICEnabled;
+    m->bd->fIOAPICEnabled = RT_BOOL(aIOAPICEnabled);
     alock.release();
     AutoWriteLock mlock(m->pMachine COMMA_LOCKVAL_SRC_POS);  // mParent is const, needs no locking
@@ -436 +436 @@
 
     m->bd.backup();
-    m->bd->fPXEDebugEnabled = !!enable;
+    m->bd->fPXEDebugEnabled = RT_BOOL(enable);
 
     alock.release();
@@ -506 +506 @@
 
     // simply copy
-    *m->bd.data() = data;
+    m->bd.assignCopy(&data);
 
     return S_OK;

trunk/src/VBox/Main/src-server/ParallelPortImpl.cpp

@@ -213 +213 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    if (m->bd->fEnabled != !!aEnabled)
+    if (m->bd->fEnabled != RT_BOOL(aEnabled))
     {
         m->bd.backup();
-        m->bd->fEnabled = !!aEnabled;
+        m->bd->fEnabled = RT_BOOL(aEnabled);
 
         m->fModified = true;

trunk/src/VBox/Main/src-server/SerialPortImpl.cpp

@@ -217 +217 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    if (m->bd->fEnabled != !!aEnabled)
+    if (m->bd->fEnabled != RT_BOOL(aEnabled))
     {
         m->bd.backup();
-        m->bd->fEnabled = !!aEnabled;
+        m->bd->fEnabled = RT_BOOL(aEnabled);
 
         m->fModified = true;
@@ -467 +467 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    if (m->bd->fServer != !!aServer)
+    if (m->bd->fServer != RT_BOOL(aServer))
     {
         m->bd.backup();
-        m->bd->fServer = !!aServer;
+        m->bd->fServer = RT_BOOL(aServer);
 
         m->fModified = true;