Changeset 61743 in vbox

Timestamp:

Jun 17, 2016 1:32:54 PM (9 years ago)

Author:

vboxsync

Message:

VMM/HMVMXR0: comments, removed old todos.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -11389 +11389 @@
 {
     HMVMX_VALIDATE_EXIT_HANDLER_PARAMS();
-    int rc = hmR0VmxSaveGuestCR4(pVCpu, pMixedCtx);    /** @todo review if CR4 is really required by EM. */
+    int rc = hmR0VmxSaveGuestCR4(pVCpu, pMixedCtx);
     AssertRCReturn(rc, rc);
 
@@ -11415 +11415 @@
 {
     HMVMX_VALIDATE_EXIT_HANDLER_PARAMS();
-    int rc = hmR0VmxSaveGuestCR4(pVCpu, pMixedCtx);                /** @todo review if CR4 is really required by EM. */
+    int rc = hmR0VmxSaveGuestCR4(pVCpu, pMixedCtx);
     rc    |= hmR0VmxSaveGuestAutoLoadStoreMsrs(pVCpu, pMixedCtx);  /* For MSR_K8_TSC_AUX */
     AssertRCReturn(rc, rc);
@@ -11445 +11445 @@
 {
     HMVMX_VALIDATE_EXIT_HANDLER_PARAMS();
-    int rc = hmR0VmxSaveGuestCR4(pVCpu, pMixedCtx);    /** @todo review if CR4 is really required by EM. */
-    rc    |= hmR0VmxSaveGuestCR0(pVCpu, pMixedCtx);    /** @todo review if CR0 is really required by EM. */
+    int rc = hmR0VmxSaveGuestCR4(pVCpu, pMixedCtx);
+    rc    |= hmR0VmxSaveGuestCR0(pVCpu, pMixedCtx);
     AssertRCReturn(rc, rc);
 
@@ -12524 +12524 @@
     }
 
-    /** @todo Emulate task switch someday, currently just going back to ring-3 for
-     *        emulation. */
+    /* Fall back to the interpreter to emulate the task-switch. */
     STAM_COUNTER_INC(&pVCpu->hm.s.StatExitTaskSwitch);
     return VERR_EM_INTERPRETER;
@@ -13486 +13485 @@
                             | HM_CHANGED_VMX_GUEST_APIC_STATE);
 #else
-        /* This is typically a shadow page table sync or a MMIO instruction. But we
-         * may have emulated something like LTR or a far jump. Any part of the CPU
-         * context may have changed.
+        /*
+         * This is typically a shadow page table sync or a MMIO instruction. But we may have
+         * emulated something like LTR or a far jump. Any part of the CPU context may have changed.
          */
         /** @todo take advantage of CPUM changed flags instead of brute forcing. */