VirtualBox

Changeset 61759 in vbox for trunk/src/VBox/VMM


Ignore:
Timestamp:
Jun 20, 2016 8:35:25 AM (9 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
108148
Message:

DBGFR3Type.cpp: mandatory spacing, review comment (see @page).

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/VMM/VMMR3/DBGFR3Type.cpp

    r61680 r61759  
    2121 * The type management system is intended to ease retrieval of values from
    2222 * structures in the guest OS without having to take care of the size of pointers.
     23 *
     24 * @todo r=bird: We need to join this up with modules and address spaces.  It
     25 *       cannot be standalone like this.  Also, it must be comming from IPRT as
     26 *       there is no point in duplicating code (been there, done that with
     27 *       symbols and debug info already).  This unfortunately means we need to
     28 *       find some common way of abstracting DWARF and Codeview type info so we
     29 *       can extend those debug info parsers to make type information available.
    2330 */
    2431
     
    7279    } while (0)
    7380
     81
    7482/*********************************************************************************************************************************
    7583*   Structures and Typedefs                                                                                                      *
    7684*********************************************************************************************************************************/
    77 
    7885/**
    7986 * DBGF registered type.
     
    95102typedef DBGFTYPE *PDBGFTYPE;
    96103
     104
    97105/*********************************************************************************************************************************
    98106*   Internal Functions                                                                                                           *
    99107*********************************************************************************************************************************/
    100 
    101108static int dbgfR3TypeParseBufferByType(PUVM pUVM, PDBGFTYPE pType, uint8_t *pbBuf, size_t cbBuf,
    102109                                       PDBGFTYPEVAL *ppVal, size_t *pcbParsed);
    103110
     111
    104112/**
    105113 * Looks up a type by the identifier.
     
    114122    return (PDBGFTYPE)RTStrSpaceGet(pTypeSpace, pszType);
    115123}
     124
    116125
    117126/**
     
    180189                break;
    181190            }
     191
    182192            case DBGFTYPEVARIANT_UNION:
    183193            {
     
    227237                break;
    228238            }
     239
    229240            case DBGFTYPEVARIANT_ALIAS:
    230241            {
     
    244255                break;
    245256            }
     257
    246258            default:
    247                 AssertMsgFailedBreakStmt(("Invalid type variant: %d", pType->pReg->enmVariant),
    248                                          rc = VERR_INVALID_STATE);
     259                AssertMsgFailedReturn(("Invalid type variant: %d", pType->pReg->enmVariant), VERR_INVALID_STATE);
    249260        }
    250261    }
     
    252263    return rc;
    253264}
     265
    254266
    255267/**
     
    270282    return VINF_SUCCESS;
    271283}
     284
    272285
    273286/**
     
    288301    return VINF_SUCCESS;
    289302}
     303
    290304
    291305/**
     
    427441    return rc;
    428442}
     443
    429444
    430445/**
     
    484499}
    485500
     501
    486502/**
    487503 * Registers a new built-in type
     
    523539}
    524540
     541
    525542/**
    526543 * Registers builtin types.
     
    557574    return rc;
    558575}
     576
    559577
    560578/**
     
    700718}
    701719
     720
    702721/**
    703722 * Parses the given byte buffer and returns the value based no the type information.
     
    749768    return rc;
    750769}
     770
    751771
    752772/**
     
    787807}
    788808
     809
    789810/**
    790811 * Dumps one level of a type.
     
    835856}
    836857
     858
    837859/**
    838860 * Initializes the type database.
     
    861883}
    862884
     885
    863886/**
    864887 * Terminates the type database.
     
    872895    pUVM->dbgf.s.fTypeDbInitialized = false;
    873896}
     897
    874898
    875899/**
     
    919943}
    920944
     945
    921946/**
    922947 * Deregisters a previously registered type.
     
    958983    return rc;
    959984}
     985
    960986
    961987/**
     
    9941020}
    9951021
     1022
    9961023/**
    9971024 * Queries the size a given type would occupy in memory.
     
    10301057}
    10311058
     1059
    10321060/**
    10331061 * Sets the size of the given type in bytes.
     
    10821110    return rc;
    10831111}
     1112
    10841113
    10851114/**
     
    11231152}
    11241153
     1154
    11251155/**
    11261156 * Returns the value of a memory buffer at the given address formatted for the given
     
    11811211}
    11821212
     1213
    11831214/**
    11841215 * Frees all acquired resources of a value previously obtained with
     
    12071238    MMR3HeapFree(pVal);
    12081239}
     1240
    12091241
    12101242/**
Note: See TracChangeset for help on using the changeset viewer.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette