Changeset 61943 in vbox for trunk/src/VBox/Additions/WINNT/VBoxTray

Timestamp:

Jun 30, 2016 2:18:11 AM (8 years ago)

Author:

vboxsync

Message:

fix for ​​​​​​bugref:8441: improved windows procedure in VBoxDispIf

File:

• trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDispIf.cpp (modified) (7 diffs)

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDispIf.cpp

@@ -924 +924 @@
 )
 {
+    /* TODO: AM need to check that the thread retrieves these events */
     switch(uMsg)
     {
@@ -942 +943 @@
             break;
         }
-        case WM_CLOSE:
-            LogFunc(("got WM_CLOSE for hwnd(0x%x)", hwnd));
-            return 0;
-        case WM_DESTROY:
-            LogFunc(("got WM_DESTROY for hwnd(0x%x)", hwnd));
-            return 0;
         case WM_NCHITTEST:
             LogFunc(("got WM_NCHITTEST for hwnd(0x%x)\n", hwnd));
@@ -1051 +1046 @@
     HRESULT hr = S_FALSE;
 
+    /* Create the thread message queue*/
     PeekMessage(&Msg,
             NULL /* HWND hWnd */,
@@ -1056 +1052 @@
             WM_USER /* UINT wMsgFilterMax */,
             PM_NOREMOVE);
+    
+    /* 
+    * Send signal that message queue is ready.
+    * From this moment only the thread is ready to receive messages.
+    */
+    BOOL bRc = SetEvent(pMon->hEvent);
+    if (!bRc)
+    {
+        DWORD winErr = GetLastError();
+        WARN_FUNC(("SetEvent failed, winErr = (%d)", winErr));
+        HRESULT tmpHr = HRESULT_FROM_WIN32(winErr);
+        Assert(tmpHr != S_OK);
+    }
 
     do
@@ -1065 +1074 @@
             );
 
-        if(!bResult) /* WM_QUIT was posted */
-        {
-            hr = S_FALSE;
-            Log(("VBoxTray: GetMessage returned FALSE\n"));
-            VBoxRrRetryStop();
-            break;
-        }
-
-        if(bResult == -1) /* error occurred */
+        if (bResult == -1) /* error occurred */
         {
             DWORD winEr = GetLastError();
@@ -1087 +1088 @@
         }
 
+        if(!bResult) /* WM_QUIT was posted */
+        {
+            hr = S_FALSE;
+            Log(("VBoxTray: GetMessage returned FALSE\n"));
+            VBoxRrRetryStop();
+            break;
+        }
+        
         switch (Msg.message)
         {
@@ -1108 +1117 @@
 static DWORD WINAPI vboxRrRunnerThread(void *pvUser)
 {
-    PVBOXRR pMon = &g_VBoxRr;
-
-    BOOL bRc = SetEvent(pMon->hEvent);
-    if (!bRc)
-    {
-        DWORD winErr = GetLastError();
-        WARN_FUNC(("SetEvent failed, winErr = (%d)", winErr));
-        HRESULT tmpHr = HRESULT_FROM_WIN32(winErr);
-        Assert(tmpHr != S_OK);
-    }
-
     HRESULT hr = vboxRrWndInit();
     Assert(hr == S_OK);