Changeset 61990 in vbox for trunk/src

Timestamp:

Jul 3, 2016 2:54:43 PM (8 years ago)

Author:

vboxsync

Message:

crOpenGL: Fix cppcheck complaints about redundant/missing NULL checks.
We never pass NULL for pfChanged, so this should have been harmless.

File:

• trunk/src/VBox/GuestHost/OpenGL/util/vreg.cpp (modified) (3 diffs)

trunk/src/VBox/GuestHost/OpenGL/util/vreg.cpp

@@ -787 +787 @@
 {
     bool fChanged = false;
-    *pfChanged = false;
+    if (pfChanged)
+        *pfChanged = false;
 
     if (VBoxVrListIsEmpty(pList))
@@ -878 +879 @@
 VBOXVREGDECL(int) VBoxVrListIntersect(PVBOXVR_LIST pList, PCVBOXVR_LIST pList2, bool *pfChanged)
 {
+    bool fChanged = false;
+
+    int rc = vboxVrListIntersectNoJoin(pList, pList2, &fChanged);
     if (pfChanged)
-        *pfChanged = false;
-
-    int rc = vboxVrListIntersectNoJoin(pList, pList2, pfChanged);
+        *pfChanged = fChanged;
+
     if (!RT_SUCCESS(rc))
     {
@@ -888 +891 @@
     }
 
-    if (*pfChanged)
+    if (fChanged)
     {
         vboxVrListJoinRects(pList);