Changeset 62147 in vbox for trunk

Timestamp:

Jul 8, 2016 4:53:24 PM (9 years ago)

Author:

vboxsync

Message:

PDMCritSect: NOP critsects are less likely to appear than real ones (e.g. the PGM one), so drop the compiler a little hint.

Location:

trunk/src/VBox/VMM

Files:

• Makefile.kmk (modified) (1 diff)
• VMMAll/PDMAllCritSect.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/Makefile.kmk

@@ -336 +336 @@
 if "$(USERNAME)" == "bird" && "$(KBUILD_TARGET)" == "win"
  VBoxVMM_VMMAll/IEMAll.cpp_CXXFLAGS = /FAcs /Fa$(subst /,\\,$(outbase).cod)
+ VBoxVMM_VMMAll/PDMAllCritSect.cpp_CXXFLAGS = /FAcs /Fa$(subst /,\\,$(outbase).cod)
 endif
 

trunk/src/VBox/VMM/VMMAll/PDMAllCritSect.cpp

@@ -240 +240 @@
      */
     /* NOP ... */
-    if (pCritSect->s.Core.fFlags & RTCRITSECT_FLAGS_NOP)
+    if (!(pCritSect->s.Core.fFlags & RTCRITSECT_FLAGS_NOP))
+    { /* We're more likely to end up here with real critsects than a NOP one. */ }
+    else
         return VINF_SUCCESS;
 
@@ -434 +436 @@
      */
     /* NOP ... */
-    if (pCritSect->s.Core.fFlags & RTCRITSECT_FLAGS_NOP)
+    if (!(pCritSect->s.Core.fFlags & RTCRITSECT_FLAGS_NOP))
+    { /* We're more likely to end up here with real critsects than a NOP one. */ }
+    else
         return VINF_SUCCESS;
 
@@ -560 +564 @@
 
     /* Check for NOP sections before asserting ownership. */
-    if (pCritSect->s.Core.fFlags & RTCRITSECT_FLAGS_NOP)
+    if (!(pCritSect->s.Core.fFlags & RTCRITSECT_FLAGS_NOP))
+    { /* We're more likely to end up here with real critsects than a NOP one. */ }
+    else
         return VINF_SUCCESS;