Changeset 62157 in vbox for trunk

Timestamp:

Jul 11, 2016 11:59:22 AM (9 years ago)

Author:

vboxsync

Message:

*: Instead of suppressing -Wno-delete-non-virtual-dtor globally we try to make gcc happy and introduce virtual destructors for affected classes. XPCOM is not touched here.

Location:

trunk

Files:

• Config.kmk (modified) (3 diffs)
• src/VBox/Frontends/VBoxManage/VBoxManageUSB.cpp (modified) (1 diff)
• src/VBox/Frontends/VBoxSDL/Framebuffer.h (modified) (1 diff)
• src/VBox/Main/include/Performance.h (modified) (1 diff)
• src/VBox/Main/include/VirtualBoxErrorInfoImpl.h (modified) (1 diff)
• src/VBox/Main/src-client/ConsoleVRDPServer.cpp (modified) (1 diff)
• src/VBox/Main/src-client/GuestFileImpl.cpp (modified) (1 diff)
• src/VBox/Main/src-client/GuestProcessImpl.cpp (modified) (1 diff)
• src/VBox/Main/src-client/GuestSessionImpl.cpp (modified) (2 diffs)

trunk/Config.kmk

@@ -1596 +1596 @@
  VBOX_GCC_WARN_PEDANTIC += -Wunused-variable -Wunused-function -Wunused-label -Wunused-parameter
 endif
-VBOX_GCC_PEDANTIC_CXX ?= -pedantic -Wshadow $(VBOX_GCC_WARN_PEDANTIC) -Wno-long-long $(VBOX_GCC_Wno-delete-non-virtual-dtor) $(VBOX_GCC_Wno-return-type-c-linkage)
+VBOX_GCC_PEDANTIC_CXX ?= -pedantic -Wshadow $(VBOX_GCC_WARN_PEDANTIC) -Wno-long-long $(VBOX_GCC_Wno-return-type-c-linkage)
 VBOX_GCC_PEDANTIC_C   ?= -pedantic -Wshadow $(VBOX_GCC_WARN_PEDANTIC) -Wno-long-long -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Werror-implicit-function-declaration
 ifeq ($(KBUILD_TARGET),win)
@@ -5602 +5602 @@
         -Wno-long-long -fshort-wchar -fno-strict-aliasing \
         $(VBOX_GCC_fvisibility-hidden) $(VBOX_GCC_fvisibility-inlines-hidden) \
-        $(VBOX_GCC_Wno-delete-non-virtual-dtor) $(VBOX_GCC_Wno-return-type-c-linkage) $(VBOX_GCC_std) $(VBOX_GCC_IPRT_FMT_CHECK)
+        $(VBOX_GCC_Wno-return-type-c-linkage) $(VBOX_GCC_std) $(VBOX_GCC_IPRT_FMT_CHECK)
   TEMPLATE_VBOXQTGUIEXE_CXXFLAGS.x86 = -m32
   TEMPLATE_VBOXQTGUIEXE_CXXFLAGS.amd64 = -m64
@@ -6006 +6006 @@
    TEMPLATE_VBOXGUESTR3EXE_TOOL.x86     := VBoxXGccX86RedHatLinux
   endif
-  TEMPLATE_VBOXGUESTR3EXE_CXXFLAGS      := $(filter-out $(VBOX_GCC_pipe) $(VBOX_GCC_Wextra) $(VBOX_GCC_Wno-missing-field-initializers) $(VBOX_GCC_fdiagnostics-show-option) $(VBOX_GCC_Wno-delete-non-virtual-dtor) $(VBOX_GCC_Wno-variadic-macros) $(VBOX_GCC_fvisibility-hidden) $(VBOX_GCC_fvisibility-inlines-hidden) $(VBOX_GCC_mtune-generic) $(VBOX_GCC_Wlogical-op),$(TEMPLATE_VBOXGUESTR3EXE_CXXFLAGS)) -pipe
+  TEMPLATE_VBOXGUESTR3EXE_CXXFLAGS      := $(filter-out $(VBOX_GCC_pipe) $(VBOX_GCC_Wextra) $(VBOX_GCC_Wno-missing-field-initializers) $(VBOX_GCC_fdiagnostics-show-option) $(VBOX_GCC_Wno-variadic-macros) $(VBOX_GCC_fvisibility-hidden) $(VBOX_GCC_fvisibility-inlines-hidden) $(VBOX_GCC_mtune-generic) $(VBOX_GCC_Wlogical-op),$(TEMPLATE_VBOXGUESTR3EXE_CXXFLAGS)) -pipe
   TEMPLATE_VBOXGUESTR3EXE_CFLAGS        := $(TEMPLATE_VBOXGUESTR3EXE_CXXFLAGS)
   TEMPLATE_VBOXGUESTR3EXE_LDFLAGS.linux := $(filter-out $(VBOX_GCC_ORIGIN_OPT) $(VBOX_LD_as_needed),$(TEMPLATE_VBOXGUESTR3EXE_LDFLAGS.linux))

trunk/src/VBox/Frontends/VBoxManage/VBoxManageUSB.cpp

@@ -45 +45 @@
     {
     }
+    virtual ~MyUSBDevice() {};
 
     STDMETHOD_(ULONG, AddRef)(void)

trunk/src/VBox/Frontends/VBoxSDL/Framebuffer.h

@@ -49 +49 @@
 public:
     VBoxSDLFB();
-    ~VBoxSDLFB();
+    virtual ~VBoxSDLFB();
 
     HRESULT init(uint32_t uScreenId,

trunk/src/VBox/Main/include/Performance.h

@@ -814 +814 @@
         virtual ULONG compute(ULONG *data, ULONG length) = 0;
         virtual const char *getName() = 0;
+        virtual ~Aggregate() {}
     };
 

trunk/src/VBox/Main/include/VirtualBoxErrorInfoImpl.h

@@ -109 +109 @@
           m_resultDetail(0)
     {}
+    virtual ~VirtualBoxErrorInfo() {}
 
     // public initializer/uninitializer for internal purposes only

trunk/src/VBox/Main/src-client/ConsoleVRDPServer.cpp

@@ -51 +51 @@
 public:
     VRDPConsoleListener()
+    {
+    }
+
+    virtual ~VRDPConsoleListener()
     {
     }

trunk/src/VBox/Main/src-client/GuestFileImpl.cpp

@@ -55 +55 @@
 
     GuestFileListener(void)
+    {
+    }
+
+    virtual ~GuestFileListener()
     {
     }

trunk/src/VBox/Main/src-client/GuestProcessImpl.cpp

@@ -106 +106 @@
 
     GuestProcessListener(void)
+    {
+    }
+
+    virtual ~GuestProcessListener(void)
     {
     }

trunk/src/VBox/Main/src-client/GuestSessionImpl.cpp

@@ -105 +105 @@
 
     GuestSessionListener(void)
+    {
+    }
+
+    virtual ~GuestSessionListener(void)
     {
     }
@@ -2165 +2169 @@
 
     /* Initialize our worker task. */
+    RT_GCC_NO_DEPRECATED_BEGIN
     std::auto_ptr<GuestSessionTask> task(pTask);
+    RT_GCC_NO_DEPRECATED_END
     int rc = task->RunAsync(strTaskDesc, pProgress);
     if (RT_FAILURE(rc))