Changeset 62168 in vbox for trunk/src/VBox/Devices/EFI

Timestamp:

Jul 11, 2016 5:17:18 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

108675

Message:

EFI/Firmware: EslSocketTransmit - fix pBuffer/pDataLength check to
match EslSocketReceive. While here, fix related debug messages to use
DEBUG_TX instead of copy/pasted DEBUG_RX.

Xref ​https://github.com/tianocore/edk2/issues/52

File:

• trunk/src/VBox/Devices/EFI/Firmware/StdLib/EfiSocketLib/Socket.c (modified) (1 diff)

trunk/src/VBox/Devices/EFI/Firmware/StdLib/EfiSocketLib/Socket.c

@@ -5524 +5524 @@
           //  Validate the buffer length
           //
+          // NB: local fix for https://github.com/tianocore/edk2/issues/52
           if (( NULL == pDataLength )
-            && ( 0 > pDataLength )
-            && ( NULL == pBuffer )) {
+            || ( NULL == pBuffer )) {
             if ( NULL == pDataLength ) {
-              DEBUG (( DEBUG_RX,
+              DEBUG (( DEBUG_TX,
                         "ERROR - pDataLength is NULL!\r\n" ));
             }
-            else if ( NULL == pBuffer ) {
-              DEBUG (( DEBUG_RX,
+            else {
+              DEBUG (( DEBUG_TX,
                         "ERROR - pBuffer is NULL!\r\n" ));
-            }
-            else {
-              DEBUG (( DEBUG_RX,
-                        "ERROR - Data length < 0!\r\n" ));
             }
             Status = EFI_INVALID_PARAMETER;