Changeset 62258 in vbox for trunk/src/VBox

Timestamp:

Jul 14, 2016 3:22:54 PM (9 years ago)

Author:

vboxsync

Message:

Main/VirtualBoxClient: Turn into a proper COM/XPCOM singleton object. Destruction is currently pretty late and might be better handled differently, but it seems to work as intended.

Location:

trunk/src/VBox/Main

Files:

• include/VirtualBoxClientImpl.h (modified) (1 diff)
• src-client/xpcom/module.cpp (modified) (6 diffs)

trunk/src/VBox/Main/include/VirtualBoxClientImpl.h

@@ -34 +34 @@
 {
 public:
-    DECLARE_CLASSFACTORY()
+    DECLARE_CLASSFACTORY_SINGLETON(VirtualBoxClient)
 
     // Do not use any ATL registry support.

trunk/src/VBox/Main/src-client/xpcom/module.cpp

@@ -6 +6 @@
 
 /*
- * Copyright (C) 2006-2015 Oracle Corporation
+ * Copyright (C) 2006-2016 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -62 +62 @@
  *  Suitable for IN-PROC components.
  */
-class SessionClassFactory : public Session
+class VirtualBoxClientClassFactory : public VirtualBoxClient
 {
 public:
-    virtual ~SessionClassFactory() {
+    virtual ~VirtualBoxClientClassFactory()
+    {
         FinalRelease();
         instance = 0;
     }
-    static nsresult getInstance (Session **inst) {
+    static nsresult GetInstance(VirtualBoxClient **inst)
+    {
         int rv = NS_OK;
-        if (instance == 0) {
-            instance = new SessionClassFactory();
+        if (instance == 0)
+        {
+            instance = new VirtualBoxClientClassFactory();
             if (instance) {
                 instance->AddRef(); // protect FinalConstruct()
@@ -89 +92 @@
         return rv;
     }
-    static nsresult releaseInstance () {
+    static nsresult FactoryDestructor()
+    {
         if (instance)
             instance->Release();
@@ -96 +100 @@
 
 private:
-    static Session *instance;
+    static VirtualBoxClient *instance;
 };
 
-/** @note this is for singleton; disabled for now */
-//
-//Session *SessionClassFactory::instance = 0;
-//
-//NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR_WITH_RC (
-//    Session, SessionClassFactory::getInstance
-//)
+VirtualBoxClient *VirtualBoxClientClassFactory::instance = nsnull;
+
 
 NS_GENERIC_FACTORY_CONSTRUCTOR_WITH_RC(Session)
 
-NS_GENERIC_FACTORY_CONSTRUCTOR_WITH_RC(VirtualBoxClient)
+NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR_WITH_RC(VirtualBoxClient, VirtualBoxClientClassFactory::GetInstance)
 
 /**
@@ -123 +122 @@
         NULL, // registration function
         NULL, // deregistration function
-/** @note this is for singleton; disabled for now */
-//        SessionClassFactory::releaseInstance,
         NULL, // destructor function
         NS_CI_INTERFACE_GETTER_NAME(SessionWrap), // interfaces function
@@ -136 +133 @@
         NULL, // registration function
         NULL, // deregistration function
-        NULL, // destructor function
+        VirtualBoxClientClassFactory::FactoryDestructor, // destructor function
         NS_CI_INTERFACE_GETTER_NAME(VirtualBoxClientWrap), // interfaces function
         NULL, // language helper