Changeset 62330 in vbox for trunk/src/libs

Timestamp:

Jul 19, 2016 3:10:44 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

108866

Message:

xpcom: for nsAutoLock and friends don't provide fake implementations
for default and copy constructors, and operators =, new and delete.
Constify reference arguments where applicable.

File:

• trunk/src/libs/xpcom18a4/xpcom/threads/nsAutoLock.h (modified) (3 diffs)

trunk/src/libs/xpcom18a4/xpcom/threads/nsAutoLock.h

@@ -151 +151 @@
     // Not meant to be implemented. This makes it a compiler error to
     // construct or assign an nsAutoLock object incorrectly.
-    nsAutoLock(void) {}
-    nsAutoLock(nsAutoLock& /*aLock*/) {}
-    nsAutoLock& operator =(nsAutoLock& /*aLock*/) {
-        return *this;
-    }
+    nsAutoLock(void);
+    nsAutoLock(const nsAutoLock& /*aLock*/);
+    nsAutoLock& operator =(const nsAutoLock& /*aLock*/);
 
     // Not meant to be implemented. This makes it a compiler error to
     // attempt to create an nsAutoLock object on the heap.
-    static void* operator new(size_t /*size*/) CPP_THROW_NEW {
-        return nsnull;
-    }
-    static void operator delete(void* /*memory*/) {}
+    static void* operator new(size_t /*size*/) CPP_THROW_NEW;
+    static void operator delete(void* /*memory*/);
 
 public:
@@ -311 +307 @@
     // Not meant to be implemented. This makes it a compiler error to
     // construct or assign an nsAutoLock object incorrectly.
-    nsAutoMonitor(void) {}
-    nsAutoMonitor(nsAutoMonitor& /*aMon*/) {}
-    nsAutoMonitor& operator =(nsAutoMonitor& /*aMon*/) {
-        return *this;
-    }
+    nsAutoMonitor(void);
+    nsAutoMonitor(const nsAutoMonitor& /*aMon*/);
+    nsAutoMonitor& operator =(const nsAutoMonitor& /*aMon*/);
 
     // Not meant to be implemented. This makes it a compiler error to
     // attempt to create an nsAutoLock object on the heap.
-    static void* operator new(size_t /*size*/) CPP_THROW_NEW {
-        return nsnull;
-    }
-    static void operator delete(void* /*memory*/) {}
+    static void* operator new(size_t /*size*/) CPP_THROW_NEW;
+    static void operator delete(void* /*memory*/);
 };
 
@@ -378 +370 @@
     // Not meant to be implemented. This makes it a compiler error to
     // construct or assign an nsAutoLock object incorrectly.
-    nsAutoCMonitor(void) {}
-    nsAutoCMonitor(nsAutoCMonitor& /*aMon*/) {}
-    nsAutoCMonitor& operator =(nsAutoCMonitor& /*aMon*/) {
-        return *this;
-    }
+    nsAutoCMonitor(void);
+    nsAutoCMonitor(const nsAutoCMonitor& /*aMon*/);
+    nsAutoCMonitor& operator =(const nsAutoCMonitor& /*aMon*/);
 
     // Not meant to be implemented. This makes it a compiler error to
     // attempt to create an nsAutoLock object on the heap.
-    static void* operator new(size_t /*size*/) CPP_THROW_NEW {
-        return nsnull;
-    }
-    static void operator delete(void* /*memory*/) {}
+    static void* operator new(size_t /*size*/) CPP_THROW_NEW;
+    static void operator delete(void* /*memory*/);
 };