Changeset 62333 in vbox for trunk/src/libs

Timestamp:

Jul 19, 2016 3:54:08 PM (8 years ago)

Author:

vboxsync

Message:

xpcom: Properly init mLock member in CategoryNode and nsCategoryManager
constructors to avoid potential deletion through a garbage pointer on
the error leg of Create().

File:

• trunk/src/libs/xpcom18a4/xpcom/components/nsCategoryManager.h (modified) (2 diffs)

trunk/src/libs/xpcom18a4/xpcom/components/nsCategoryManager.h

@@ -117 +117 @@
 
 private:
-  CategoryNode() { }
+  CategoryNode() : mLock(nsnull) { }
   void* operator new(size_t aSize, PLArenaPool* aArena);
 
@@ -143 +143 @@
   NS_METHOD WriteCategoryManagerToRegistry(PRFileDesc* fd);
 
-  nsCategoryManager() { }
+  nsCategoryManager() : mLock(nsnull) { }
 private:
   friend class nsCategoryManagerFactory;