Changeset 62448 in vbox for trunk/src/VBox

Timestamp:

Jul 22, 2016 2:51:49 PM (8 years ago)

Author:

vboxsync

Message:

IPRT: More MSC level 4 warning fixes.

Location:

trunk/src/VBox/Runtime

Files:

• common/asn1/asn1-ut-objid.cpp (modified) (1 diff)
• common/asn1/asn1-ut-string.cpp (modified) (3 diffs)
• common/crypto/digest-builtin.cpp (modified) (1 diff)
• common/crypto/store-inmem.cpp (modified) (1 diff)
• common/crypto/x509-certpaths.cpp (modified) (1 diff)
• common/dbg/dbgcfg.cpp (modified) (1 diff)
• common/dbg/dbgmodcodeview.cpp (modified) (17 diffs)
• common/dbg/dbgmoddwarf.cpp (modified) (2 diffs)
• common/dvm/dvmmbr.cpp (modified) (1 diff)
• common/err/errmsg.cpp (modified) (1 diff)
• common/ldr/ldrELFRelocatable.cpp.h (modified) (3 diffs)
• common/ldr/ldrPE.cpp (modified) (6 diffs)
• common/log/log.cpp (modified) (2 diffs)
• common/math/bignum.cpp (modified) (2 diffs)
• common/net/netaddrstr2.cpp (modified) (1 diff)
• common/path/RTPathExt.cpp (modified) (1 diff)
• common/path/RTPathParse.cpp.h (modified) (1 diff)
• common/path/RTPathParseSimple.cpp (modified) (1 diff)
• common/vfs/vfsreadahead.cpp (modified) (1 diff)
• common/zip/pkzipvfs.cpp (modified) (2 diffs)
• common/zip/tarcmd.cpp (modified) (3 diffs)
• common/zip/unzipcmd.cpp (modified) (1 diff)
• common/zip/zip.cpp (modified) (1 diff)
• generic/RTPathIsSame-generic.cpp (modified) (1 diff)
• generic/critsectrw-generic.cpp (modified) (4 diffs)
• generic/env-generic.cpp (modified) (1 diff)
• generic/semrw-generic.cpp (modified) (1 diff)
• generic/timerlr-generic.cpp (modified) (1 diff)
• r0drv/nt/ntBldSymDb.cpp (modified) (5 diffs)
• r3/win/errvars-win.cpp (modified) (1 diff)
• r3/win/ldrNative-win.cpp (modified) (1 diff)
• r3/win/localipc-win.cpp (modified) (2 diffs)
• r3/win/pipe-win.cpp (modified) (3 diffs)
• r3/win/process-win.cpp (modified) (2 diffs)
• r3/win/sched-win.cpp (modified) (3 diffs)
• r3/win/timer-win.cpp (modified) (5 diffs)
• tools/RTSignTool.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/asn1/asn1-ut-objid.cpp

@@ -430 +430 @@
         RTAsn1MemInitAllocation(&pThis->Allocation, pAllocator);
         pThis->cComponents = pSrc->cComponents;
+#if 0 /** @todo breaks with arrays of ObjIds or structs containing them. They get resized and repositioned in memory, thus invalidating the pointer. Add recall-pointers callback, or just waste memory? Or maybe make all arrays pointer-arrays? */
         size_t cbLeft = sizeof(pThis->szObjId);
-#if 0 /** @todo breaks with arrays of ObjIds or structs containing them. They get resized and repositioned in memory, thus invalidating the pointer. Add recall-pointers callback, or just waste memory? Or maybe make all arrays pointer-arrays? */
         if (pSrc->cComponents * sizeof(uint32_t) <= cbLeft)
         {

trunk/src/VBox/Runtime/common/asn1/asn1-ut-string.cpp

@@ -518 +518 @@
     while (i-- > 0)
     {
-        uint32_t cchMatch;
+        uint32_t cchMatch = 0; /* (MSC maybe used uninitialized) */
         PCRTISO2022MAP pMap = papMaps[i];
         /** @todo skip non-Teletex codesets if we ever add more than we need for it. */
@@ -530 +530 @@
             return cchMatch + 1;
         }
-        else if (!ppMapRet) /* ppMapRet is NULL if Gn. */
+
+        if (!ppMapRet) /* ppMapRet is NULL if Gn. */
         {
             uint32_t iGn;
@@ -1033 +1034 @@
     if (RT_SUCCESS(rc))
     {
-        size_t cchUtf8 = 0;
         for (;;)
         {

trunk/src/VBox/Runtime/common/crypto/digest-builtin.cpp

@@ -639 +639 @@
 static DECLCALLBACK(RTDIGESTTYPE) rtCrDigestOsslEvp_GetDigestType(void *pvState)
 {
-    EVP_MD_CTX *pThis = (EVP_MD_CTX *)pvState;
+    //EVP_MD_CTX *pThis = (EVP_MD_CTX *)pvState;
     /** @todo figure which digest algorithm it is! */
     return RTDIGESTTYPE_UNKNOWN;

trunk/src/VBox/Runtime/common/crypto/store-inmem.cpp

@@ -236 +236 @@
 static DECLCALLBACK(int) rtCrStoreInMem_CertFindAll(void *pvProvider, PRTCRSTORECERTSEARCH pSearch)
 {
-    PRTCRSTOREINMEM pThis = (PRTCRSTOREINMEM)pvProvider;
     pSearch->auOpaque[0] = ~(uintptr_t)pvProvider;
     pSearch->auOpaque[1] = 0;

trunk/src/VBox/Runtime/common/crypto/x509-certpaths.cpp

@@ -2653 +2653 @@
     int      rcLastFailure = VINF_SUCCESS;
     uint32_t cValidPaths   = 0;
-    uint32_t iPath         = 0;
     PRTCRX509CERTPATHNODE pCurLeaf;
     RTListForEach(&pThis->LeafList, pCurLeaf, RTCRX509CERTPATHNODE, ChildListOrLeafEntry)

trunk/src/VBox/Runtime/common/dbg/dbgcfg.cpp

@@ -1401 +1401 @@
         if (RT_SUCCESS(rc2))
         {
-            size_t cchCurPath = cchPath + strlen(&pszPath[cchPath]);
             for (uint32_t iSuffix = 0; papszSuffixes[iSuffix]; iSuffix++)
             {

trunk/src/VBox/Runtime/common/dbg/dbgmodcodeview.cpp

@@ -278 +278 @@
 
 
+#ifdef LOG_ENABLED
 /**
  * Gets a name string for a subsection type.
@@ -325 +326 @@
     return s_sz;
 }
-
-
+#endif /* LOG_ENABLED */
+
+
+#ifdef LOG_ENABLED
 /**
  * Gets a name string for a symbol type.
@@ -337 +340 @@
     switch (enmSymType)
     {
-#define CASE_RET_STR(Name)  case kCvSymType_##Name: return #Name;
+# define CASE_RET_STR(Name)  case kCvSymType_##Name: return #Name;
         CASE_RET_STR(Compile);
         CASE_RET_STR(Register);
@@ -446 +449 @@
     return "<unknown type>";
 }
+#endif /* LOG_ENABLED */
 
 
@@ -739 +743 @@
                     /*uint32_t uEnd          =*/ *uCursor.pu32++;
                     /*uint32_t uNext         =*/ *uCursor.pu32++;
-                    uint32_t cbProc        = *uCursor.pu32++;
+                    /*uint32_t cbProc        =*/ *uCursor.pu32++;
                     /*uint32_t offDebugStart =*/ *uCursor.pu32++;
                     /*uint32_t offDebugEnd   =*/ *uCursor.pu32++;
@@ -1029 +1033 @@
         {
             PCRTCV8SRCINFO pSrcInfo = (PCRTCV8SRCINFO)&pThis->pbSrcInfo[off];
+#ifdef LOG_ENABLED
             const char    *pszName  = pSrcInfo->offSourceName < pThis->cbSrcStrings
                                     ? &pThis->pchSrcStrings[pSrcInfo->offSourceName] : "out-of-bounds.c!";
@@ -1037 +1042 @@
             else
                 Log3(("    %010zx #%03zu: !%#x! %#x=%s\n", off, iFile, pSrcInfo->uDigestType, pSrcInfo->offSourceName, pszName));
+#endif
             off += pSrcInfo->uDigestType == RTCV8SRCINFO_DIGEST_TYPE_MD5 ? sizeof(*pSrcInfo) : 8;
             iFile++;
@@ -1121 +1127 @@
     uCursor.pv = pvSubSect;
     RTDBGMODCV_CHECK_NOMSG_RET_BF(cbSubSect >= 2 + 2 + 2 + 2 + 0 + 1);
-    uint16_t iOverlay = *uCursor.pu16++;
-    uint16_t iLib     = *uCursor.pu16++;
+    uint16_t iOverlay = *uCursor.pu16++; NOREF(iOverlay);
+    uint16_t iLib     = *uCursor.pu16++; NOREF(iLib);
     uint16_t cSegs    = *uCursor.pu16++;
     pThis->uCurStyle  = *uCursor.pu16++;
@@ -1133 +1139 @@
     RTDBGMODCV_CHECK_NOMSG_RET_BF(cbSubSect >= 2 + 2 + 2 + 2 + cSegs * 12U + 1 + cchName);
 
+#ifdef LOG_ENABLED
     const char *pchName = (const char *)&uCursor.pu8[cSegs * 12 + 1];
     Log2(("RTDbgModCv: Module: iOverlay=%#x iLib=%#x cSegs=%#x Style=%c%c (%#x) %.*s\n", iOverlay, iLib, cSegs,
           RT_BYTE1(pThis->uCurStyle), RT_BYTE2(pThis->uCurStyle), pThis->uCurStyle, cchName, pchName));
+#endif
     RTDBGMODCV_CHECK_NOMSG_RET_BF(pThis->uCurStyle == RT_MAKE_U16('C', 'V'));
 
+#ifdef LOG_ENABLED
     PCRTCVMODSEGINFO32 paSegs = (PCRTCVMODSEGINFO32)uCursor.pv;
     for (uint16_t iSeg = 0; iSeg < cSegs; iSeg++)
         Log2(("    #%02u: %04x:%08x LB %08x\n", iSeg, paSegs[iSeg].iSeg, paSegs[iSeg].off, paSegs[iSeg].cb));
+#endif
 
     return VINF_SUCCESS;
@@ -1181 +1191 @@
     Log2(("RTDbgModCv: SrcModule: cFiles=%u cSegs=%u\n", pHdr->cFiles, pHdr->cFiles));
     RTDBGMODCV_CHECK_RET_BF(cbSubSect >= cbHdr, ("cbSubSect=%#x cbHdr=%zx\n", cbSubSect, cbHdr));
+#ifdef LOG_ENABLED
     if (LogIs2Enabled())
     {
@@ -1190 +1201 @@
             Log2(("RTDbgModCv:   seg #%u: %#010x-%#010x\n", paidxSegs[i], paSegRanges[i].offStart, paSegRanges[i].offEnd));
     }
+#endif
 
     /*
@@ -1333 +1345 @@
         if (i == pHdr->cLogSegs)
             Log2(("Group/Physical descriptors: %u\n", pHdr->cSegs - pHdr->cLogSegs));
-        uint16_t idx = i < pHdr->cLogSegs ? i : i - pHdr->cLogSegs;
         char szFlags[16];
         memset(szFlags, '-', sizeof(szFlags));
@@ -1354 +1365 @@
             szFlags[8]  = '!', szFlags[9] = '\0';
         Log2(("    #%02u: %#010x LB %#010x flags=%#06x ovl=%#06x group=%#06x frame=%#06x iSegName=%#06x iClassName=%#06x %s\n",
-              idx, paDescs[i].off, paDescs[i].cb, paDescs[i].fFlags, paDescs[i].iOverlay, paDescs[i].iGroup,
-              paDescs[i].iFrame, paDescs[i].offSegName, paDescs[i].offClassName, szFlags));
+              i < pHdr->cLogSegs ? i : i - pHdr->cLogSegs, paDescs[i].off, paDescs[i].cb, paDescs[i].fFlags, paDescs[i].iOverlay,
+              paDescs[i].iGroup, paDescs[i].iFrame, paDescs[i].offSegName, paDescs[i].offClassName, szFlags));
 
         RTDBGMODCV_CHECK_NOMSG_RET_BF(paDescs[i].offSegName == UINT16_MAX || paDescs[i].offSegName < pThis->cbSegNames);
@@ -1613 +1624 @@
     for (i = 0; i < pHdr->cSegs; i++)
         if (paDescs[i].fFlags & RTCVSEGMAPDESC_F_ABS)
-            paDescs[i].iGroup = (uint16_t)RTDBGSEGIDX_ABS;
+            paDescs[i].iGroup = (uint16_t)(RTDBGSEGIDX_ABS & UINT16_MAX);
         else if ((paDescs[i].fFlags & RTCVSEGMAPDESC_F_GROUP) || fNoGroups)
             paDescs[i].iGroup = iSeg++;
@@ -2045 +2056 @@
  */
 
+#ifdef LOG_ENABLED
 static const char *rtDbgModCvGetCoffStorageClassName(uint8_t bStorageClass)
 {
@@ -2083 +2095 @@
     return s_szName;
 }
+#endif /* LOG_ENABLED */
 
 
@@ -2104 +2117 @@
         {
             int rc = RTDbgModLineAdd(pThis->hCnt, pszFile, pCur->Linenumber, RTDBGSEGIDX_RVA, pCur->Type.VirtualAddress, NULL);
-            Log4(("    %#010x: %u  [%Rrc]\n", pCur->Type.VirtualAddress, pCur->Linenumber, rc));
+            Log4(("    %#010x: %u  [%Rrc]\n", pCur->Type.VirtualAddress, pCur->Linenumber, rc)); NOREF(rc);
         }
         pCur++;

trunk/src/VBox/Runtime/common/dbg/dbgmoddwarf.cpp

@@ -1031 +1031 @@
 #if defined(LOG_ENABLED) || defined(RT_STRICT)
 
+# if 0 /* unused */
 /**
  * Turns a tag value into a string for logging purposes.
@@ -1050 +1051 @@
     return s_szStatic;
 }
+# endif
 
 

trunk/src/VBox/Runtime/common/dvm/dvmmbr.cpp

@@ -216 +216 @@
                                                   bool *pfUsed)
 {
-    PRTDVMFMTINTERNAL pThis = hVolMgrFmt;
-
+    NOREF(hVolMgrFmt);
     NOREF(cbRange);
 
     /* MBR uses the first sector only. */
-    if (off < 512)
-        *pfUsed = true;
-    else
-        *pfUsed = false;
-
+    *pfUsed = off < 512;
     return VINF_SUCCESS;
 }

trunk/src/VBox/Runtime/common/err/errmsg.cpp

@@ -79 +79 @@
 RTDECL(PCRTSTATUSMSG) RTErrGet(int rc)
 {
-    unsigned iFound = ~0;
+    unsigned iFound = ~0U;
     unsigned i;
     for (i = 0; i < RT_ELEMENTS(g_aStatusMsgs) - 1; i++)

trunk/src/VBox/Runtime/common/ldr/ldrELFRelocatable.cpp.h

@@ -241 +241 @@
             const char *pszName = ELF_STR(pModElf, pSym->st_name);
             RTUINTPTR   ExtValue;
-            int rc = pfnGetImport(&pModElf->Core, "", pszName, ~0, &ExtValue, pvUser);
+            int rc = pfnGetImport(&pModElf->Core, "", pszName, ~0U, &ExtValue, pvUser);
             AssertMsgRCReturn(rc, ("Failed to resolve '%s' rc=%Rrc\n", pszName, rc), rc);
             SymValue = (Elf_Addr)ExtValue;
@@ -445 +445 @@
             /* Try to resolve the symbol. */
             RTUINTPTR Value;
-            int rc = pfnGetImport(&pModElf->Core, "", pszName, ~0, &Value, pvUser);
+            int rc = pfnGetImport(&pModElf->Core, "", pszName, ~0U, &Value, pvUser);
             if (RT_FAILURE(rc))
             {
@@ -747 +747 @@
                  */
                 AssertMsgReturn(Value == (RTUINTPTR)Value, (FMT_ELF_ADDR "\n", Value), VERR_SYMBOL_VALUE_TOO_BIG);
-                rc = pfnCallback(pMod, pszName, ~0, (RTUINTPTR)Value, pvUser);
+                rc = pfnCallback(pMod, pszName, ~0U, (RTUINTPTR)Value, pvUser);
                 if (rc)
                     return rc;

trunk/src/VBox/Runtime/common/ldr/ldrPE.cpp

@@ -673 +673 @@
                      && pThunk->u1.Ordinal < pModPe->cbImage)
             {
-                rc = pfnGetImport(&pModPe->Core, pszModName, PE_RVA2TYPE(pvBitsR, (char*)(uintptr_t)pThunk->u1.AddressOfData + 2, const char *),
-                                  ~0, &Value, pvUser);
+                rc = pfnGetImport(&pModPe->Core, pszModName,
+                                  PE_RVA2TYPE(pvBitsR, (char*)(uintptr_t)pThunk->u1.AddressOfData + 2, const char *),
+                                  ~0U, &Value, pvUser);
                 Log4((RT_SUCCESS(rc) ? "RTLdrPE:  %RTptr %s\n" : "RTLdrPE:  %08RX32 %s rc=%Rrc\n",
                       (uint32_t)Value, PE_RVA2TYPE(pvBitsR, (char*)(uintptr_t)pThunk->u1.AddressOfData + 2, const char *), rc));
@@ -713 +714 @@
 
 /** @copydoc RTLDROPSPE::pfnResolveImports */
-static DECLCALLBACK(int) rtldrPEResolveImports64(PRTLDRMODPE pModPe, const void *pvBitsR, void *pvBitsW, PFNRTLDRIMPORT pfnGetImport, void *pvUser)
+static DECLCALLBACK(int) rtldrPEResolveImports64(PRTLDRMODPE pModPe, const void *pvBitsR, void *pvBitsW,
+                                                 PFNRTLDRIMPORT pfnGetImport, void *pvUser)
 {
     /*
@@ -766 +768 @@
                 /** @todo add validation of the string pointer! */
                 rc = pfnGetImport(&pModPe->Core, pszModName, PE_RVA2TYPE(pvBitsR, (uintptr_t)pThunk->u1.AddressOfData + 2, const char *),
-                                  ~0, &Value, pvUser);
+                                  ~0U, &Value, pvUser);
                 Log4((RT_SUCCESS(rc) ? "RTLdrPE:  %016RX64 %s\n" : "RTLdrPE:  %016RX64 %s rc=%Rrc\n",
                       (uint64_t)Value, PE_RVA2TYPE(pvBitsR, (uintptr_t)pThunk->u1.AddressOfData + 2, const char *), rc));
@@ -788 +790 @@
  * Applies fixups.
  */
-static int rtldrPEApplyFixups(PRTLDRMODPE pModPe, const void *pvBitsR, void *pvBitsW, RTUINTPTR BaseAddress, RTUINTPTR OldBaseAddress)
+static int rtldrPEApplyFixups(PRTLDRMODPE pModPe, const void *pvBitsR, void *pvBitsW, RTUINTPTR BaseAddress,
+                              RTUINTPTR OldBaseAddress)
 {
     if (    !pModPe->RelocDir.VirtualAddress
@@ -2037 +2040 @@
 
 
+#ifndef IPRT_WITHOUT_LDR_VERIFY
 /**
  * Returns the digest size for the given digest type.
@@ -2054 +2058 @@
     }
 }
+#endif
 
 

trunk/src/VBox/Runtime/common/log/log.cpp

@@ -474 +474 @@
 
     va_start(args, pszFormat);
-    rtlogLoggerExVLocked(pLogger, 0, ~0, pszFormat, args);
+    rtlogLoggerExVLocked(pLogger, 0, ~0U, pszFormat, args);
     va_end(args);
 }
@@ -494 +494 @@
 
     va_start(args, pszFormat);
-    RTLogLoggerExV(pLogger, 0, ~0, pszFormat, args);
+    RTLogLoggerExV(pLogger, 0, ~0U, pszFormat, args);
     va_end(args);
 }

trunk/src/VBox/Runtime/common/math/bignum.cpp

@@ -1101 +1101 @@
     {
         RTBIGNUM_ASSERT_VALID(pLeft);
-        if (pLeft->fNegative == (iRight < 0))
+        if (pLeft->fNegative == (unsigned)(iRight < 0)) /* (unsigned cast is for MSC weirdness) */
         {
             AssertCompile(RTBIGNUM_ELEMENT_SIZE <= sizeof(iRight));
@@ -1729 +1729 @@
     {
         int rc = rtBigNumSetUsed(pBigNum, cUsed + 1);
+        AssertRCReturn(rc, rc);
         pBigNum->pauElements[cUsed] = uCarry;
     }

trunk/src/VBox/Runtime/common/net/netaddrstr2.cpp

@@ -224 +224 @@
          * "::" compressed zero run.
          */
+        pszNext = NULL; /* (MSC incorrectly thinks it may be used unitialized) */
         for (iGroup = 0; iGroup < 8; ++iGroup)
         {

trunk/src/VBox/Runtime/common/path/RTPathExt.cpp

@@ -65 +65 @@
     }
 
-    /* will never get here */
-    return NULL;
+    /* not reached */
 }
 

trunk/src/VBox/Runtime/common/path/RTPathParse.cpp.h

@@ -209 +209 @@
 
                     /* look for an ? */
-                    uint16_t cDots  = 0;
                     uint32_t offSuffix = offStart + cchComp;
                     while (offSuffix-- > offStart)

trunk/src/VBox/Runtime/common/path/RTPathParseSimple.cpp

@@ -114 +114 @@
 
     /* will never get here */
-    return 0;
 }
 

trunk/src/VBox/Runtime/common/vfs/vfsreadahead.cpp

@@ -583 +583 @@
             {
 
-                pBufDesc->off      = RTVfsIoStrmTell(pThis->hIos);
-                size_t cbRead      = 0;
-                size_t cbToRead    = pThis->cbBuffer;
+                pBufDesc->off = RTVfsIoStrmTell(pThis->hIos);
+                size_t cbRead = 0;
                 rc = RTVfsIoStrmRead(pThis->hIos, pBufDesc->pbBuffer, pThis->cbBuffer, true /*fBlocking*/, &cbRead);
                 if (RT_SUCCESS(rc))

trunk/src/VBox/Runtime/common/zip/pkzipvfs.cpp

@@ -478 +478 @@
     if (RT_SUCCESS(rc))
     {
-        uint8_t *offStart = pu8Buf;
         pu8Buf += pThis->cdh.cbFilename;
         cb      = pThis->cdh.cbExtra;
@@ -767 +766 @@
 static DECLCALLBACK(int) rtZipPkzipFssBaseObj_Close(void *pvThis)
 {
-    PRTZIPPKZIPBASEOBJ pThis = (PRTZIPPKZIPBASEOBJ)pvThis;
-
+    NOREF(pvThis);
     return VINF_SUCCESS;
 }

trunk/src/VBox/Runtime/common/zip/tarcmd.cpp

@@ -401 +401 @@
 }
 
+#if !defined(RT_OS_WINDOWS) && !defined(RT_OS_OS2)
 
 /**
@@ -463 +464 @@
 }
 
+#endif /* !defined(RT_OS_WINDOWS) && !defined(RT_OS_OS2) */
 
 
@@ -596 +598 @@
                               rc, pszName);
 
-    const char *pszLinkType = NULL;
     char szTarget[RTPATH_MAX];
     szTarget[0] = '\0';

trunk/src/VBox/Runtime/common/zip/unzipcmd.cpp

@@ -477 +477 @@
             return rtZipUnzipDoWithMembers(&Opts, rtZipUnzipCmdExtractCallback, &cFiles, &cBytes);
     }
-
-    return RTEXITCODE_SUCCESS;
-}
+}

trunk/src/VBox/Runtime/common/zip/zip.cpp

@@ -531 +531 @@
             return zipErrConvertFromZlib(rc, true /*fCompressing*/);
     }
-    return VINF_SUCCESS;
 }
 

trunk/src/VBox/Runtime/generic/RTPathIsSame-generic.cpp

@@ -52 +52 @@
      * If the files exist, try use the attributes.
      */
-    RTFSOBJINFO ObjInfo1, ObjInfo2;
+    RTFSOBJINFO ObjInfo1;
     int rc = RTPathQueryInfoEx(pszPath1, &ObjInfo1, RTFSOBJATTRADD_UNIX, RTPATH_F_ON_LINK);
     if (RT_SUCCESS(rc))
+    {
+        RTFSOBJINFO ObjInfo2;
         rc = RTPathQueryInfoEx(pszPath2, &ObjInfo2, RTFSOBJATTRADD_UNIX, RTPATH_F_ON_LINK);
-    if (RT_SUCCESS(rc))
-    {
-        if ((ObjInfo1.Attr.fMode & RTFS_TYPE_MASK) != (ObjInfo2.Attr.fMode & RTFS_TYPE_MASK))
-            return false;
-        if (ObjInfo1.Attr.u.Unix.INodeIdDevice       != ObjInfo2.Attr.u.Unix.INodeIdDevice)
-            return false;
-        if (ObjInfo1.Attr.u.Unix.INodeId             != ObjInfo2.Attr.u.Unix.INodeId)
-            return false;
-        if (ObjInfo1.Attr.u.Unix.GenerationId        != ObjInfo2.Attr.u.Unix.GenerationId)
-            return false;
-        if (   ObjInfo1.Attr.u.Unix.INodeIdDevice != 0
-            && ObjInfo1.Attr.u.Unix.INodeId       != 0)
-            return true;
+        if (RT_SUCCESS(rc))
+        {
+            if ((ObjInfo1.Attr.fMode & RTFS_TYPE_MASK) != (ObjInfo2.Attr.fMode & RTFS_TYPE_MASK))
+                return false;
+            if (ObjInfo1.Attr.u.Unix.INodeIdDevice       != ObjInfo2.Attr.u.Unix.INodeIdDevice)
+                return false;
+            if (ObjInfo1.Attr.u.Unix.INodeId             != ObjInfo2.Attr.u.Unix.INodeId)
+                return false;
+            if (ObjInfo1.Attr.u.Unix.GenerationId        != ObjInfo2.Attr.u.Unix.GenerationId)
+                return false;
+            if (   ObjInfo1.Attr.u.Unix.INodeIdDevice != 0
+                && ObjInfo1.Attr.u.Unix.INodeId       != 0)
+                return true;
+        }
     }
 

trunk/src/VBox/Runtime/generic/critsectrw-generic.cpp

@@ -575 +575 @@
         uint32_t cNestings = ASMAtomicIncU32(&pThis->cWriteRecursions); NOREF(cNestings);
 
+#ifdef IPRT_WITH_DTRACE
         if (IPRT_CRITSECTRW_EXCL_ENTERED_ENABLED())
         {
@@ -582 +583 @@
                                          (uint32_t)((u64State & RTCSRW_CNT_WR_MASK) >> RTCSRW_CNT_WR_SHIFT));
         }
+#endif
         return VINF_SUCCESS;
     }
@@ -879 +881 @@
 #endif
         uint32_t cNestings = ASMAtomicDecU32(&pThis->cWriteRecursions); NOREF(cNestings);
+#ifdef IPRT_WITH_DTRACE
         if (IPRT_CRITSECTRW_EXCL_LEAVING_ENABLED())
         {
@@ -886 +889 @@
                                          (uint32_t)((u64State & RTCSRW_CNT_WR_MASK) >> RTCSRW_CNT_WR_SHIFT));
         }
+#endif
     }
 

trunk/src/VBox/Runtime/generic/env-generic.cpp

@@ -235 +235 @@
     const char * const *papszEnv;
 #ifdef RTENV_HAVE_WENVIRON
-    PCRTUTF16 const * papwszEnv;
+    PCRTUTF16 const * papwszEnv = NULL;
 #endif
     PRTENVINTERNAL pIntEnvToClone;

trunk/src/VBox/Runtime/generic/semrw-generic.cpp

@@ -203 +203 @@
              */
             ASMAtomicWriteU32(&pThis->u32Magic, ~RTSEMRW_MAGIC);
-            pThis->cReads = ~0;
+            pThis->cReads = UINT32_MAX;
 
             /*

trunk/src/VBox/Runtime/generic/timerlr-generic.cpp

@@ -262 +262 @@
         ASMAtomicWriteU64(&pThis->u64NextTS, u64Now);
         ASMAtomicWriteU64(&pThis->u64NanoInterval, u64NanoInterval);
-        int rc = RTSemEventSignal(pThis->hEvent);
+        RTSemEventSignal(pThis->hEvent);
     }
 

trunk/src/VBox/Runtime/r0drv/nt/ntBldSymDb.cpp

@@ -471 +471 @@
 
 
+#if 0
 /**
  * Resets the writable structure members prior to processing a PDB.
@@ -491 +492 @@
     }
 }
+#endif
 
 
@@ -690 +692 @@
 
 
+#if 0 /* unused */
 static bool strIEndsWith(const char *pszString, const char *pszSuffix)
 {
@@ -698 +701 @@
     return RTStrICmp(pszString + cchString - cchSuffix, pszSuffix) == 0;
 }
+#endif
 
 
@@ -754 +758 @@
      *  - en_windows_8_1_symbols_debug_checked_x64_2712568
      */
-    bool fFound = false;
     uint32_t i = u.Split.cComps - 1;
     while (i-- > 0)

trunk/src/VBox/Runtime/r3/win/errvars-win.cpp

@@ -77 +77 @@
 
     return pVars->ai32Vars[0] != RTERRVARS_MAGIC
-        || pVars->ai32Vars[1] != GetLastError()
+        || (uint32_t)pVars->ai32Vars[1] != GetLastError()
         || pVars->ai32Vars[2] != WSAGetLastError()
         || pVars->ai32Vars[3] != errno;

trunk/src/VBox/Runtime/r3/win/ldrNative-win.cpp

@@ -245 +245 @@
                  */
                 unsigned cMatchingComponents = 0;
-                unsigned cSlashes = 0;
                 size_t   off = 0;
                 while (off < pUniStrResult->Length)

trunk/src/VBox/Runtime/r3/win/localipc-win.cpp

@@ -1123 +1123 @@
                     else if (GetLastError() == ERROR_IO_PENDING)
                     {
-                        DWORD rcWait = WaitForSingleObject(pThis->Read.OverlappedIO.hEvent, INFINITE);
+                        WaitForSingleObject(pThis->Read.OverlappedIO.hEvent, INFINITE);
 
                         RTCritSectEnter(&pThis->CritSect);
@@ -1553 +1553 @@
                  * Check for timeout.
                  */
-                DWORD cMsMaxWait;
+                DWORD cMsMaxWait = INFINITE; /* (MSC maybe used uninitialized) */
                 if (cMillies == RT_INDEFINITE_WAIT)
                     cMsMaxWait = INFINITE;

trunk/src/VBox/Runtime/r3/win/pipe-win.cpp

@@ -127 +127 @@
 } FILE_PIPE_LOCAL_INFORMATION, *PFILE_PIPE_LOCAL_INFORMATION;
 
-#define FILE_PIPE_DISCONNECTED_STATE    0x00000001
-#define FILE_PIPE_LISTENING_STATE       0x00000002
-#define FILE_PIPE_CONNECTED_STATE       0x00000003
-#define FILE_PIPE_CLOSING_STATE         0x00000004
-
-#define FILE_PIPE_INBOUND               0x00000000
-#define FILE_PIPE_OUTBOUND              0x00000001
-#define FILE_PIPE_FULL_DUPLEX           0x00000002
-
-#define FILE_PIPE_CLIENT_END            0x00000000
-#define FILE_PIPE_SERVER_END            0x00000001
+#define FILE_PIPE_DISCONNECTED_STATE    0x00000001U
+#define FILE_PIPE_LISTENING_STATE       0x00000002U
+#define FILE_PIPE_CONNECTED_STATE       0x00000003U
+#define FILE_PIPE_CLOSING_STATE         0x00000004U
+
+#define FILE_PIPE_INBOUND               0x00000000U
+#define FILE_PIPE_OUTBOUND              0x00000001U
+#define FILE_PIPE_FULL_DUPLEX           0x00000002U
+
+#define FILE_PIPE_CLIENT_END            0x00000000U
+#define FILE_PIPE_SERVER_END            0x00000001U
 
 extern "C" NTSYSAPI NTSTATUS WINAPI NtQueryInformationFile(HANDLE, PIO_STATUS_BLOCK, PVOID, LONG, FILE_INFORMATION_CLASS);
@@ -858 +858 @@
                     HANDLE hEvent = pThis->Overlapped.hEvent;
                     RTCritSectLeave(&pThis->CritSect);
-                    WaitForSingleObject(pThis->Overlapped.hEvent, INFINITE);
+                    WaitForSingleObject(hEvent, INFINITE);
                     RTCritSectEnter(&pThis->CritSect);
                 }
@@ -928 +928 @@
     return rc;
 
-#if 1
-    return VERR_NOT_IMPLEMENTED;
-#else
+#if 0 /** @todo r=bird: What's this? */
     int rc = rtPipeTryBlocking(pThis);
     if (RT_SUCCESS(rc))

trunk/src/VBox/Runtime/r3/win/process-win.cpp

@@ -500 +500 @@
     int    rc              = VINF_SUCCESS;
     DWORD  cbPidsAllocated = 4096;
-    DWORD  cbPidsReturned;
+    DWORD  cbPidsReturned  = 0; /* (MSC maybe used uninitialized) */
     DWORD *paPids;
     for (;;)
@@ -2079 +2079 @@
      * UTF-16 environment block.
      */
-    RTENV hEnvToUse;
+    RTENV hEnvToUse = NIL_RTENV; /* (MSC maybe used uninitialized) */
     if (   !(fFlags & (RTPROC_FLAGS_PROFILE | RTPROC_FLAGS_ENV_CHANGE_RECORD))
         || (hEnv == RTENV_DEFAULT && !(fFlags & RTPROC_FLAGS_PROFILE))

trunk/src/VBox/Runtime/r3/win/sched-win.cpp

@@ -65 +65 @@
         RTTHREADTYPE    enmType;
         /** The Win32 thread priority. */
-        DWORD           dwThreadPriority;
+        int             iThreadPriority;
     } aTypes[RTTHREADTYPE_END];
 } PROCPRIORITY;
@@ -313 +313 @@
 
 #ifdef WIN32_SCHED_ENABLED
-    if (SetThreadPriority(rtThreadNativeGetHandle(pThread), g_pProcessPriority->aTypes[enmType].dwThreadPriority))
+    if (SetThreadPriority(rtThreadNativeGetHandle(pThread), g_pProcessPriority->aTypes[enmType].iThreadPriority))
         return VINF_SUCCESS;
 
@@ -319 +319 @@
     int rc = RTErrConvertFromWin32(dwLastError);
     AssertMsgFailed(("SetThreadPriority(%p, %d) failed, dwLastError=%d rc=%Rrc\n",
-                     rtThreadNativeGetHandle(pThread), g_pProcessPriority->aTypes[enmType].dwThreadPriority, dwLastError, rc));
+                     rtThreadNativeGetHandle(pThread), g_pProcessPriority->aTypes[enmType].iThreadPriority, dwLastError, rc));
     return rc;
 #else

trunk/src/VBox/Runtime/r3/win/timer-win.cpp

@@ -286 +286 @@
      * we start the timer.
      */
-    ULONG ulMax = ~0;
-    ULONG ulMin = ~0;
-    ULONG ulCur = ~0;
+    ULONG ulMax = UINT32_MAX;
+    ULONG ulMin = UINT32_MAX;
+    ULONG ulCur = UINT32_MAX;
     NtQueryTimerResolution(&ulMax, &ulMin, &ulCur);
     Log(("NtQueryTimerResolution -> ulMax=%lu00ns ulMin=%lu00ns ulCur=%lu00ns\n", ulMax, ulMin, ulCur));
@@ -312 +312 @@
      * Create new timer.
      */
-    int rc;
+    int rc = VERR_IPE_UNINITIALIZED_STATUS;
     PRTTIMER pTimer = (PRTTIMER)RTMemAlloc(sizeof(*pTimer));
     if (pTimer)
@@ -326 +326 @@
         if (pTimer->TimerId)
         {
-            ULONG ulMax = ~0;
-            ULONG ulMin = ~0;
-            ULONG ulCur = ~0;
+            ULONG ulMax = UINT32_MAX;
+            ULONG ulMin = UINT32_MAX;
+            ULONG ulCur = UINT32_MAX;
             NtQueryTimerResolution(&ulMax, &ulMin, &ulCur);
             Log(("NtQueryTimerResolution -> ulMax=%lu00ns ulMin=%lu00ns ulCur=%lu00ns\n", ulMax, ulMin, ulCur));
@@ -342 +342 @@
          * Create Win32 event semaphore.
          */
-        pTimer->iError      = 0;
+        pTimer->iError = 0;
         pTimer->hTimer = CreateWaitableTimer(NULL, TRUE, NULL);
         if (pTimer->hTimer)
@@ -441 +441 @@
         rc = RTThreadWait(pTimer->Thread, 1000, NULL);
         if (RT_FAILURE(rc))
-            TerminateThread((HANDLE)RTThreadGetNative(pTimer->Thread), -1);
+            TerminateThread((HANDLE)RTThreadGetNative(pTimer->Thread), UINT32_MAX);
 
         /*

trunk/src/VBox/Runtime/tools/RTSignTool.cpp

@@ -648 +648 @@
     };
 
-    RTLDRARCH       enmLdrArch = RTLDRARCH_WHATEVER;
     MAKETAINFOSTATE State = { 0, NULL, NULL };