Changeset 62448 in vbox for trunk/src/VBox/Runtime/common/asn1

Timestamp:

Jul 22, 2016 2:51:49 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109001

Message:

IPRT: More MSC level 4 warning fixes.

Location:

trunk/src/VBox/Runtime/common/asn1

Files:

• asn1-ut-objid.cpp (modified) (1 diff)
• asn1-ut-string.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/common/asn1/asn1-ut-objid.cpp

@@ -430 +430 @@
         RTAsn1MemInitAllocation(&pThis->Allocation, pAllocator);
         pThis->cComponents = pSrc->cComponents;
+#if 0 /** @todo breaks with arrays of ObjIds or structs containing them. They get resized and repositioned in memory, thus invalidating the pointer. Add recall-pointers callback, or just waste memory? Or maybe make all arrays pointer-arrays? */
         size_t cbLeft = sizeof(pThis->szObjId);
-#if 0 /** @todo breaks with arrays of ObjIds or structs containing them. They get resized and repositioned in memory, thus invalidating the pointer. Add recall-pointers callback, or just waste memory? Or maybe make all arrays pointer-arrays? */
         if (pSrc->cComponents * sizeof(uint32_t) <= cbLeft)
         {

trunk/src/VBox/Runtime/common/asn1/asn1-ut-string.cpp

@@ -518 +518 @@
     while (i-- > 0)
     {
-        uint32_t cchMatch;
+        uint32_t cchMatch = 0; /* (MSC maybe used uninitialized) */
         PCRTISO2022MAP pMap = papMaps[i];
         /** @todo skip non-Teletex codesets if we ever add more than we need for it. */
@@ -530 +530 @@
             return cchMatch + 1;
         }
-        else if (!ppMapRet) /* ppMapRet is NULL if Gn. */
+
+        if (!ppMapRet) /* ppMapRet is NULL if Gn. */
         {
             uint32_t iGn;
@@ -1033 +1034 @@
     if (RT_SUCCESS(rc))
     {
-        size_t cchUtf8 = 0;
         for (;;)
         {