- Timestamp:
- Jul 26, 2016 2:43:03 PM (8 years ago)
- Location:
- trunk/src/VBox/Runtime
- Files:
-
- 76 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/src/VBox/Runtime/common/alloc/heapoffset.cpp
r62477 r62564 665 665 ASSERT_BLOCK_USED(pHeapInt, pBlock); 666 666 ASSERT_ANCHOR(pHeapInt); 667 Assert(pHeapInt == (PRTHEAPOFFSETINTERNAL)hHeap || !hHeap); 667 Assert(pHeapInt == (PRTHEAPOFFSETINTERNAL)hHeap || !hHeap); RT_NOREF_PV(hHeap); 668 668 669 669 #ifdef RTHEAPOFFSET_FREE_POISON … … 859 859 ASSERT_BLOCK_USED(pHeapInt, pBlock); 860 860 ASSERT_ANCHOR(pHeapInt); 861 Assert(pHeapInt == (PRTHEAPOFFSETINTERNAL)hHeap || !hHeap); 861 Assert(pHeapInt == (PRTHEAPOFFSETINTERNAL)hHeap || !hHeap); RT_NOREF_PV(hHeap); 862 862 863 863 /* -
trunk/src/VBox/Runtime/common/alloc/heapsimple.cpp
r62477 r62564 657 657 ASSERT_BLOCK_USED(pHeapInt, pBlock); 658 658 ASSERT_ANCHOR(pHeapInt); 659 Assert(pHeapInt == (PRTHEAPSIMPLEINTERNAL)hHeap || !hHeap); 659 Assert(pHeapInt == (PRTHEAPSIMPLEINTERNAL)hHeap || !hHeap); RT_NOREF_PV(hHeap); 660 660 661 661 #ifdef RTHEAPSIMPLE_FREE_POISON … … 851 851 ASSERT_BLOCK_USED(pHeapInt, pBlock); 852 852 ASSERT_ANCHOR(pHeapInt); 853 Assert(pHeapInt == (PRTHEAPSIMPLEINTERNAL)hHeap || !hHeap); 853 Assert(pHeapInt == (PRTHEAPSIMPLEINTERNAL)hHeap || !hHeap); RT_NOREF_PV(hHeap); 854 854 855 855 /* -
trunk/src/VBox/Runtime/common/asn1/asn1-basics.cpp
r62477 r62564 588 588 RTDECL(int) RTAsn1ContextTagN_Clone(PRTASN1CONTEXTTAG pThis, PCRTASN1CONTEXTTAG pSrc, uint32_t uTag) 589 589 { 590 Assert(pSrc->Asn1Core.uTag == uTag || !RTASN1CORE_IS_PRESENT(&pSrc->Asn1Core)); 590 Assert(pSrc->Asn1Core.uTag == uTag || !RTASN1CORE_IS_PRESENT(&pSrc->Asn1Core)); RT_NOREF_PV(uTag); 591 591 return RTAsn1Core_CloneNoContent(&pThis->Asn1Core, &pSrc->Asn1Core); 592 592 } -
trunk/src/VBox/Runtime/common/asn1/asn1-default-allocator.cpp
r62477 r62564 58 58 static DECLCALLBACK(void) rtAsn1DefaultAllocator_Free(PCRTASN1ALLOCATORVTABLE pThis, PRTASN1ALLOCATION pAllocation, void *pv) 59 59 { 60 RT_NOREF_PV(pThis); 60 61 RTMemFree(pv); 61 62 pAllocation->cbAllocated = 0; … … 75 76 return VINF_SUCCESS; 76 77 } 78 RT_NOREF_PV(pThis); 77 79 return VERR_NO_MEMORY; 78 80 } … … 93 95 return VINF_SUCCESS; 94 96 } 97 RT_NOREF_PV(pThis); 95 98 return VERR_NO_MEMORY; 96 99 } -
trunk/src/VBox/Runtime/common/asn1/asn1-efence-allocator.cpp
r62477 r62564 40 40 static DECLCALLBACK(void) rtAsn1EFenceAllocator_Free(PCRTASN1ALLOCATORVTABLE pThis, PRTASN1ALLOCATION pAllocation, void *pv) 41 41 { 42 RT_NOREF_PV(pThis); 42 43 RTMemEfFreeNP(pv); 43 44 pAllocation->cbAllocated = 0; … … 56 57 return VINF_SUCCESS; 57 58 } 59 RT_NOREF_PV(pThis); 58 60 return VERR_NO_MEMORY; 59 61 } … … 73 75 return VINF_SUCCESS; 74 76 } 77 RT_NOREF_PV(pThis); 75 78 return VERR_NO_MEMORY; 76 79 } -
trunk/src/VBox/Runtime/common/asn1/asn1-encode.cpp
r62477 r62564 167 167 { 168 168 RTASN1ENCODEPREPARGS *pArgs = (RTASN1ENCODEPREPARGS *)pvUser; 169 RT_NOREF_PV(pszName); 169 170 if (RTASN1CORE_IS_PRESENT(pAsn1Core)) 170 171 { … … 376 377 { 377 378 RTASN1ENCODEWRITEARGS *pArgs = (RTASN1ENCODEWRITEARGS *)pvUser; 379 RT_NOREF_PV(pszName); 378 380 int rc; 379 381 if (RTASN1CORE_IS_PRESENT(pAsn1Core)) … … 460 462 pArgs->cbDst = 0; 461 463 } 464 RT_NOREF_PV(pErrInfo); 462 465 return VERR_BUFFER_OVERFLOW; 463 466 } -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-bitstring.cpp
r62477 r62564 82 82 return VERR_NOT_EQUAL; 83 83 pCtx->offBuf += (uint32_t)cbToWrite; 84 RT_NOREF_PV(pErrInfo); 84 85 return VINF_SUCCESS; 85 86 } -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-boolean.cpp
r62477 r62564 54 54 RTDECL(int) RTAsn1Boolean_InitDefault(PRTASN1BOOLEAN pThis, bool fValue, PCRTASN1ALLOCATORVTABLE pAllocator) 55 55 { 56 RT_NOREF_PV(pAllocator); 56 57 RTAsn1Core_InitEx(&pThis->Asn1Core, ASN1_TAG_BOOLEAN, ASN1_TAGCLASS_UNIVERSAL | ASN1_TAGFLAG_PRIMITIVE, 57 58 &g_RTAsn1Boolean_Vtable, RTASN1CORE_F_DEFAULT | RTASN1CORE_F_PRIMITE_TAG_STRUCT); … … 102 103 RTDECL(int) RTAsn1Boolean_Init(PRTASN1BOOLEAN pThis, PCRTASN1ALLOCATORVTABLE pAllocator) 103 104 { 105 RT_NOREF_PV(pAllocator); 104 106 RTAsn1Core_InitEx(&pThis->Asn1Core, ASN1_TAG_BOOLEAN, ASN1_TAGCLASS_UNIVERSAL | ASN1_TAGFLAG_PRIMITIVE, 105 107 &g_RTAsn1Boolean_Vtable, RTASN1CORE_F_PRESENT | RTASN1CORE_F_PRIMITE_TAG_STRUCT); … … 161 163 { 162 164 Assert(pThis && (!RTAsn1Boolean_IsPresent(pThis) || pThis->Asn1Core.pOps == &g_RTAsn1Boolean_Vtable)); 165 RT_NOREF_PV(pThis); RT_NOREF_PV(pfnCallback); RT_NOREF_PV(uDepth); RT_NOREF_PV(pvUser); 163 166 164 167 /* No children to enumerate. */ … … 190 193 if (RT_UNLIKELY(!RTAsn1Boolean_IsPresent(pThis))) 191 194 return RTErrInfoSetF(pErrInfo, VERR_ASN1_NOT_PRESENT, "%s: Missing (BOOLEAN).", pszErrorTag); 195 RT_NOREF_PV(fFlags); 192 196 return VINF_SUCCESS; 193 197 } -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-core-decode.cpp
r62477 r62564 45 45 return VINF_SUCCESS; 46 46 } 47 RT_NOREF_PV(fFlags); 47 48 RT_ZERO(*pThis); 48 49 return rc; -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-core.cpp
r62477 r62564 206 206 RTDECL(int) RTAsn1Core_Init(PRTASN1CORE pThis, PCRTASN1ALLOCATORVTABLE pAllocator) 207 207 { 208 RT_NOREF_PV(pAllocator); 208 209 return RTAsn1Core_InitEx(pThis, 0, ASN1_TAGCLASS_CONTEXT | ASN1_TAGFLAG_PRIMITIVE, 209 210 &g_RTAsn1Core_Vtable, RTASN1CORE_F_PRESENT); … … 262 263 RTDECL(int) RTAsn1Core_CheckSanity(PCRTASN1CORE pThis, uint32_t fFlags, PRTERRINFO pErrInfo, const char *pszErrorTag) 263 264 { 265 RT_NOREF_PV(fFlags); 266 264 267 /* We can only check that it's present. */ 265 268 if (!RTAsn1Core_IsPresent(pThis)) -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-dyntype-decode.cpp
r62477 r62564 43 43 RT_ZERO(*pDynType); 44 44 45 Assert(!(fFlags & RTASN1CURSOR_GET_F_IMPLICIT)); 45 Assert(!(fFlags & RTASN1CURSOR_GET_F_IMPLICIT)); RT_NOREF_PV(fFlags); 46 46 uint32_t cbSavedLeft = pCursor->cbLeft; 47 47 uint8_t const *pbSavedCur = pCursor->pbCur; -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-dyntype.cpp
r62477 r62564 45 45 RTDECL(int) RTAsn1DynType_Init(PRTASN1DYNTYPE pThis, PCRTASN1ALLOCATORVTABLE pAllocator) 46 46 { 47 RT_NOREF_PV(pAllocator); 47 48 RT_ZERO(*pThis); 48 49 pThis->enmType = RTASN1TYPE_NOT_PRESENT; -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-integer.cpp
r60030 r62564 403 403 RTDECL(int) RTAsn1Integer_Init(PRTASN1INTEGER pThis, PCRTASN1ALLOCATORVTABLE pAllocator) 404 404 { 405 RT_NOREF_PV(pAllocator); 405 406 RTAsn1Core_InitEx(&pThis->Asn1Core, 406 407 ASN1_TAG_INTEGER, … … 462 463 RTDECL(int) RTAsn1Integer_Enum(PRTASN1INTEGER pThis, PFNRTASN1ENUMCALLBACK pfnCallback, uint32_t uDepth, void *pvUser) 463 464 { 465 RT_NOREF_PV(pThis); RT_NOREF_PV(pfnCallback); RT_NOREF_PV(uDepth); RT_NOREF_PV(pvUser); 464 466 Assert(pThis && (!RTAsn1Integer_IsPresent(pThis) || pThis->Asn1Core.pOps == &g_RTAsn1Integer_Vtable)); 465 467 … … 477 479 RTDECL(int) RTAsn1Integer_CheckSanity(PCRTASN1INTEGER pThis, uint32_t fFlags, PRTERRINFO pErrInfo, const char *pszErrorTag) 478 480 { 481 RT_NOREF_PV(fFlags); 479 482 if (RT_UNLIKELY(!RTAsn1Integer_IsPresent(pThis))) 480 483 return RTErrInfoSetF(pErrInfo, VERR_ASN1_NOT_PRESENT, "%s: Missing (INTEGER).", pszErrorTag); -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-null.cpp
r62477 r62564 67 67 RTDECL(int) RTAsn1Null_Init(PRTASN1NULL pThis, PCRTASN1ALLOCATORVTABLE pAllocator) 68 68 { 69 RT_NOREF_PV(pAllocator); 69 70 return RTAsn1Core_InitEx(&pThis->Asn1Core, ASN1_TAG_NULL, ASN1_TAGCLASS_UNIVERSAL | ASN1_TAGFLAG_PRIMITIVE, 70 71 &g_RTAsn1Null_Vtable, RTASN1CORE_F_PRESENT | RTASN1CORE_F_PRIMITE_TAG_STRUCT); … … 74 75 RTDECL(int) RTAsn1Null_Clone(PRTASN1NULL pThis, PCRTASN1NULL pSrc, PCRTASN1ALLOCATORVTABLE pAllocator) 75 76 { 76 AssertPtr(pSrc); AssertPtr(pThis); AssertPtr(pAllocator); 77 AssertPtr(pSrc); AssertPtr(pThis); AssertPtr(pAllocator); RT_NOREF_PV(pAllocator); 77 78 RT_ZERO(*pThis); 78 79 if (RTAsn1Null_IsPresent(pSrc)) … … 102 103 RTDECL(int) RTAsn1Null_Enum(PRTASN1NULL pThis, PFNRTASN1ENUMCALLBACK pfnCallback, uint32_t uDepth, void *pvUser) 103 104 { 105 RT_NOREF_PV(pThis); RT_NOREF_PV(pfnCallback); RT_NOREF_PV(uDepth); RT_NOREF_PV(pvUser); 104 106 Assert(pThis && (!RTAsn1Null_IsPresent(pThis) || pThis->Asn1Core.pOps == &g_RTAsn1Null_Vtable)); 105 107 … … 120 122 RTDECL(int) RTAsn1Null_CheckSanity(PCRTASN1NULL pThis, uint32_t fFlags, PRTERRINFO pErrInfo, const char *pszErrorTag) 121 123 { 124 RT_NOREF_PV(fFlags); 122 125 if (RT_UNLIKELY(!RTAsn1Null_IsPresent(pThis))) 123 126 return RTErrInfoSetF(pErrInfo, VERR_ASN1_NOT_PRESENT, "%s: Missing (NULL).", pszErrorTag); -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-objid-decode.cpp
r62477 r62564 233 233 } 234 234 return RTAsn1CursorSetInfo(pCursor, VERR_ASN1_OBJID_TOO_LONG_STRING_FORM, 235 " Object ID has a too long string form: %#x (max %#x)",236 cchObjId, RT_SIZEOFMEMB(RTASN1OBJID, szObjId));235 "%s: Object ID has a too long string form: %#x (max %#x)", 236 pszErrorTag, cchObjId, RT_SIZEOFMEMB(RTASN1OBJID, szObjId)); 237 237 } 238 238 return RTAsn1CursorSetInfo(pCursor, VERR_ASN1_OBJID_TOO_MANY_COMPONENTS, 239 " Object ID has too many components: %#x (max 127)", cComponents);239 "%s: Object ID has too many components: %#x (max 127)", pszErrorTag, cComponents); 240 240 } 241 241 … … 244 244 } while (rc > 0); 245 245 } 246 rc = RTAsn1CursorSetInfo(pCursor, rc, " Bad object ID component #%u encoding: %.*Rhxs",247 cComponents, cbContent, pbContent);246 rc = RTAsn1CursorSetInfo(pCursor, rc, "%s: Bad object ID component #%u encoding: %.*Rhxs", 247 pszErrorTag, cComponents, cbContent, pbContent); 248 248 } 249 249 else if (cbContent) 250 rc = RTAsn1CursorSetInfo(pCursor, VERR_ASN1_INVALID_OBJID_ENCODING, "Object ID content is loo long: %#x", cbContent); 250 rc = RTAsn1CursorSetInfo(pCursor, VERR_ASN1_INVALID_OBJID_ENCODING, "%s: Object ID content is loo long: %#x", 251 pszErrorTag, cbContent); 251 252 else 252 rc = RTAsn1CursorSetInfo(pCursor, VERR_ASN1_INVALID_OBJID_ENCODING, " Zero length object ID content");253 rc = RTAsn1CursorSetInfo(pCursor, VERR_ASN1_INVALID_OBJID_ENCODING, "%s: Zero length object ID content", pszErrorTag); 253 254 return rc; 254 255 } -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-objid.cpp
r62477 r62564 395 395 RTDECL(int) RTAsn1ObjId_Init(PRTASN1OBJID pThis, PCRTASN1ALLOCATORVTABLE pAllocator) 396 396 { 397 RT_NOREF_PV(pAllocator); 397 398 RTAsn1Core_InitEx(&pThis->Asn1Core, 398 399 ASN1_TAG_OID, … … 497 498 RTDECL(int) RTAsn1ObjId_Enum(PRTASN1OBJID pThis, PFNRTASN1ENUMCALLBACK pfnCallback, uint32_t uDepth, void *pvUser) 498 499 { 500 RT_NOREF_PV(pThis); RT_NOREF_PV(pfnCallback); RT_NOREF_PV(uDepth); RT_NOREF_PV(pvUser); 499 501 Assert(pThis && (!RTAsn1ObjId_IsPresent(pThis) || pThis->Asn1Core.pOps == &g_RTAsn1ObjId_Vtable)); 500 502 … … 527 529 RTDECL(int) RTAsn1ObjId_CheckSanity(PCRTASN1OBJID pThis, uint32_t fFlags, PRTERRINFO pErrInfo, const char *pszErrorTag) 528 530 { 531 RT_NOREF_PV(fFlags); 529 532 if (RT_UNLIKELY(!RTAsn1ObjId_IsPresent(pThis))) 530 533 return RTErrInfoSetF(pErrInfo, VERR_ASN1_NOT_PRESENT, "%s: Missing (OBJID).", pszErrorTag); -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-octetstring.cpp
r62477 r62564 78 78 { 79 79 RTASN1OCTETSTRINGWRITERCTX *pCtx = (RTASN1OCTETSTRINGWRITERCTX *)pvUser; 80 RT_NOREF_PV(pErrInfo); 80 81 AssertReturn(cbToWrite <= pCtx->cbBuf - pCtx->offBuf, VERR_BUFFER_OVERFLOW); 81 82 if (memcmp(&pCtx->pbBuf[pCtx->offBuf], pvBuf, cbToWrite) != 0) -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-string.cpp
r62477 r62564 1736 1736 RTDECL(int) RTAsn1String_Enum(PRTASN1STRING pThis, PFNRTASN1ENUMCALLBACK pfnCallback, uint32_t uDepth, void *pvUser) 1737 1737 { 1738 RT_NOREF_PV(pThis); RT_NOREF_PV(pfnCallback); RT_NOREF_PV(uDepth); RT_NOREF_PV(pvUser); 1738 1739 Assert(pThis && (!RTAsn1String_IsPresent(pThis) || pThis->Asn1Core.pOps == &g_RTAsn1String_Vtable)); 1739 1740 … … 1752 1753 RTDECL(int) RTAsn1String_CheckSanity(PCRTASN1STRING pThis, uint32_t fFlags, PRTERRINFO pErrInfo, const char *pszErrorTag) 1753 1754 { 1755 RT_NOREF_PV(fFlags); 1754 1756 if (RT_UNLIKELY(!RTAsn1String_IsPresent(pThis))) 1755 1757 return RTErrInfoSetF(pErrInfo, VERR_ASN1_NOT_PRESENT, "%s: Missing (STRING).", pszErrorTag); … … 1787 1789 RTDECL(int) RT_CONCAT(a_Api,_Enum)(PRTASN1STRING pThis, PFNRTASN1ENUMCALLBACK pfnCallback, uint32_t uDepth, void *pvUser) \ 1788 1790 { \ 1791 RT_NOREF_PV(pThis); RT_NOREF_PV(pfnCallback); RT_NOREF_PV(uDepth); RT_NOREF_PV(pvUser); \ 1789 1792 Assert( pThis \ 1790 1793 && ( !RTAsn1String_IsPresent(pThis) \ -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-time-decode.cpp
r62477 r62564 305 305 RTDECL(int) RTAsn1Time_DecodeAsn1(PRTASN1CURSOR pCursor, uint32_t fFlags, PRTASN1TIME pThis, const char *pszErrorTag) 306 306 { 307 Assert(!(fFlags & RTASN1CURSOR_GET_F_IMPLICIT)); 307 Assert(!(fFlags & RTASN1CURSOR_GET_F_IMPLICIT)); RT_NOREF_PV(fFlags); 308 308 int rc = RTAsn1CursorReadHdr(pCursor, &pThis->Asn1Core, pszErrorTag); 309 309 if (RT_SUCCESS(rc)) -
trunk/src/VBox/Runtime/common/asn1/asn1-ut-time.cpp
r62477 r62564 55 55 RTDECL(int) RTAsn1Time_InitEx(PRTASN1TIME pThis, uint32_t uTag, PCRTASN1ALLOCATORVTABLE pAllocator) 56 56 { 57 RT_NOREF_PV(pAllocator); 57 58 AssertReturn(uTag == ASN1_TAG_UTC_TIME || uTag == ASN1_TAG_GENERALIZED_TIME, VERR_INVALID_PARAMETER); 58 59 RTAsn1Core_InitEx(&pThis->Asn1Core, … … 154 155 RTDECL(int) RTAsn1Time_Enum(PRTASN1TIME pThis, PFNRTASN1ENUMCALLBACK pfnCallback, uint32_t uDepth, void *pvUser) 155 156 { 157 RT_NOREF_PV(pThis); RT_NOREF_PV(pfnCallback); RT_NOREF_PV(uDepth); RT_NOREF_PV(pvUser); 156 158 Assert(pThis && (!RTAsn1Time_IsPresent(pThis) || pThis->Asn1Core.pOps == &g_RTAsn1Time_Vtable)); 157 159 … … 190 192 RTDECL(int) RTAsn1Time_CheckSanity(PCRTASN1TIME pThis, uint32_t fFlags, PRTERRINFO pErrInfo, const char *pszErrorTag) 191 193 { 194 RT_NOREF_PV(fFlags); 192 195 if (RT_UNLIKELY(!RTAsn1Time_IsPresent(pThis))) 193 196 return RTErrInfoSetF(pErrInfo, VERR_ASN1_NOT_PRESENT, "%s: Missing (TIME).", pszErrorTag); … … 225 228 RTDECL(int) RT_CONCAT(a_Api,_Enum)(PRTASN1TIME pThis, PFNRTASN1ENUMCALLBACK pfnCallback, uint32_t uDepth, void *pvUser) \ 226 229 { \ 230 RT_NOREF_PV(pThis); RT_NOREF_PV(pfnCallback); RT_NOREF_PV(uDepth); RT_NOREF_PV(pvUser); \ 227 231 Assert( pThis \ 228 232 && ( !RTAsn1Time_IsPresent(pThis) \ -
trunk/src/VBox/Runtime/common/checksum/manifest2.cpp
r62477 r62564 301 301 AssertPtr(phManifestDst); 302 302 303 304 /** @todo implement cloning. */ 303 RT_NOREF_PV(phManifestDst); /** @todo implement cloning. */ 305 304 306 305 return VERR_NOT_IMPLEMENTED; -
trunk/src/VBox/Runtime/common/crypto/digest-builtin.cpp
r62477 r62564 64 64 static DECLCALLBACK(int) rtCrDigestMd2_Init(void *pvState, void *pvOpaque, bool fReInit) 65 65 { 66 RT_NOREF_PV(fReInit); RT_NOREF_PV(pvOpaque); 66 67 AssertReturn(pvOpaque == NULL, VERR_INVALID_PARAMETER); 67 68 RTMd2Init((PRTMD2CONTEXT)pvState); … … 118 119 static DECLCALLBACK(int) rtCrDigestMd5_Init(void *pvState, void *pvOpaque, bool fReInit) 119 120 { 121 RT_NOREF_PV(pvOpaque); RT_NOREF_PV(fReInit); 120 122 AssertReturn(pvOpaque == NULL, VERR_INVALID_PARAMETER); 121 123 RTMd5Init((PRTMD5CONTEXT)pvState); … … 172 174 static DECLCALLBACK(int) rtCrDigestSha1_Init(void *pvState, void *pvOpaque, bool fReInit) 173 175 { 176 RT_NOREF_PV(pvOpaque); RT_NOREF_PV(fReInit); 174 177 AssertReturn(pvOpaque == NULL, VERR_INVALID_PARAMETER); 175 178 RTSha1Init((PRTSHA1CONTEXT)pvState); … … 226 229 static DECLCALLBACK(int) rtCrDigestSha256_Init(void *pvState, void *pvOpaque, bool fReInit) 227 230 { 231 RT_NOREF_PV(pvOpaque); RT_NOREF_PV(fReInit); 228 232 AssertReturn(pvOpaque == NULL, VERR_INVALID_PARAMETER); 229 233 RTSha256Init((PRTSHA256CONTEXT)pvState); … … 279 283 static DECLCALLBACK(int) rtCrDigestSha512_Init(void *pvState, void *pvOpaque, bool fReInit) 280 284 { 285 RT_NOREF_PV(pvOpaque); RT_NOREF_PV(fReInit); 281 286 AssertReturn(pvOpaque == NULL, VERR_INVALID_PARAMETER); 282 287 RTSha512Init((PRTSHA512CONTEXT)pvState); … … 332 337 static DECLCALLBACK(int) rtCrDigestSha224_Init(void *pvState, void *pvOpaque, bool fReInit) 333 338 { 339 RT_NOREF_PV(pvOpaque); RT_NOREF_PV(fReInit); 334 340 AssertReturn(pvOpaque == NULL, VERR_INVALID_PARAMETER); 335 341 RTSha224Init((PRTSHA224CONTEXT)pvState); … … 385 391 static DECLCALLBACK(int) rtCrDigestSha384_Init(void *pvState, void *pvOpaque, bool fReInit) 386 392 { 393 RT_NOREF_PV(pvOpaque); RT_NOREF_PV(fReInit); 387 394 AssertReturn(pvOpaque == NULL, VERR_INVALID_PARAMETER); 388 395 RTSha384Init((PRTSHA384CONTEXT)pvState); … … 439 446 static DECLCALLBACK(int) rtCrDigestSha512t224_Init(void *pvState, void *pvOpaque, bool fReInit) 440 447 { 448 RT_NOREF_PV(pvOpaque); RT_NOREF_PV(fReInit); 441 449 AssertReturn(pvOpaque == NULL, VERR_INVALID_PARAMETER); 442 450 RTSha512t224Init((PRTSHA512T224CONTEXT)pvState); … … 493 501 static DECLCALLBACK(int) rtCrDigestSha512t256_Init(void *pvState, void *pvOpaque, bool fReInit) 494 502 { 503 RT_NOREF_PV(pvOpaque); RT_NOREF_PV(fReInit); 495 504 AssertReturn(pvOpaque == NULL, VERR_INVALID_PARAMETER); 496 505 RTSha512t256Init((PRTSHA512T256CONTEXT)pvState); … … 639 648 static DECLCALLBACK(RTDIGESTTYPE) rtCrDigestOsslEvp_GetDigestType(void *pvState) 640 649 { 641 //EVP_MD_CTX *pThis = (EVP_MD_CTX *)pvState;650 RT_NOREF_PV(pvState); //EVP_MD_CTX *pThis = (EVP_MD_CTX *)pvState; 642 651 /** @todo figure which digest algorithm it is! */ 643 652 return RTDIGESTTYPE_UNKNOWN; -
trunk/src/VBox/Runtime/common/crypto/pemfile.cpp
r62477 r62564 334 334 PCRTCRPEMSECTION *ppSectionHead, PRTERRINFO pErrInfo) 335 335 { 336 RT_NOREF_PV(pErrInfo); 337 336 338 /* 337 339 * Input validation. -
trunk/src/VBox/Runtime/common/crypto/pkcs7-asn1-decoder.cpp
r62477 r62564 57 57 const char *pszErrorTag) 58 58 { 59 RT_NOREF_PV(fFlags); RT_NOREF_PV(pszErrorTag); 59 60 pThis->u.pCore = NULL; 60 61 -
trunk/src/VBox/Runtime/common/crypto/pkcs7-sanity.cpp
r62477 r62564 44 44 { 45 45 bool const fAuthenticode = RT_BOOL(fFlags & RTCRPKCS7SIGNEDDATA_SANITY_F_AUTHENTICODE); 46 RT_NOREF_PV(fFlags); 46 47 47 48 //RTAsn1Dump(&pSignedData->SeqCore.Asn1Core, 0, 0, RTAsn1DumpStrmPrintfV, g_pStdOut); … … 61 62 if (pSignedData->DigestAlgorithms.cItems != 1 && fAuthenticode) 62 63 return RTErrInfoSetF(pErrInfo, VERR_CR_SPC_NOT_EXACTLY_ONE_DIGEST_ALGO, 63 " SignedData.DigestAlgorithms has more than one algorithm (%u)",64 p SignedData->DigestAlgorithms.cItems);64 "%s: SignedData.DigestAlgorithms has more than one algorithm (%u)", 65 pszErrorTag, pSignedData->DigestAlgorithms.cItems); 65 66 66 67 if (fFlags & RTCRPKCS7SIGNEDDATA_SANITY_F_ONLY_KNOWN_HASH) … … 69 70 if (RTCrX509AlgorithmIdentifier_QueryDigestType(&pSignedData->DigestAlgorithms.paItems[i]) == RTDIGESTTYPE_INVALID) 70 71 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_UNKNOWN_DIGEST_ALGORITHM, 71 " SignedData.DigestAlgorithms[%i] is not known: %s",72 i, pSignedData->DigestAlgorithms.paItems[i].Algorithm.szObjId);72 "%s: SignedData.DigestAlgorithms[%i] is not known: %s", 73 pszErrorTag, i, pSignedData->DigestAlgorithms.paItems[i].Algorithm.szObjId); 73 74 if (pSignedData->DigestAlgorithms.paItems[i].Parameters.enmType != RTASN1TYPE_NULL) 74 75 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_DIGEST_PARAMS_NOT_IMPL, 75 " SignedData.DigestAlgorithms[%i] has parameters: tag=%u",76 i, pSignedData->DigestAlgorithms.paItems[i].Parameters.u.Core.uTag);76 "%s: SignedData.DigestAlgorithms[%i] has parameters: tag=%u", 77 pszErrorTag, i, pSignedData->DigestAlgorithms.paItems[i].Parameters.u.Core.uTag); 77 78 } 78 79 … … 82 83 if ( (fFlags & RTCRPKCS7SIGNEDDATA_SANITY_F_SIGNING_CERT_PRESENT) 83 84 && pSignedData->Certificates.cItems == 0) 84 return RTErrInfoSet (pErrInfo, VERR_CR_PKCS7_NO_CERTIFICATES,85 "SignedData.Certifcates is empty, expected at least one certificate");85 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_NO_CERTIFICATES, 86 "%s: SignedData.Certifcates is empty, expected at least one certificate", pszErrorTag); 86 87 87 88 /* … … 89 90 */ 90 91 if (fAuthenticode && RTAsn1Core_IsPresent(&pSignedData->Crls)) 91 return RTErrInfoSet (pErrInfo, VERR_CR_PKCS7_EXPECTED_NO_CRLS,92 "SignedData.Crls is not empty as expected for authenticode.");92 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_EXPECTED_NO_CRLS, 93 "%s: SignedData.Crls is not empty as expected for authenticode.", pszErrorTag); 93 94 /** @todo check Crls when they become important. */ 94 95 … … 97 98 */ 98 99 if (pSignedData->SignerInfos.cItems == 0) 99 return RTErrInfoSet (pErrInfo, VERR_CR_PKCS7_NO_SIGNER_INFOS, "SignedData.SignerInfos is empty?");100 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_NO_SIGNER_INFOS, "%s: SignedData.SignerInfos is empty?", pszErrorTag); 100 101 if (fAuthenticode && pSignedData->SignerInfos.cItems != 1) 101 102 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_EXPECTED_ONE_SIGNER_INFO, 102 " SignedData.SignerInfos should have one entry for authenticode: %u",103 p SignedData->SignerInfos.cItems);103 "%s: SignedData.SignerInfos should have one entry for authenticode: %u", 104 pszErrorTag, pSignedData->SignerInfos.cItems); 104 105 105 106 for (uint32_t i = 0; i < pSignedData->SignerInfos.cItems; i++) … … 109 110 if (RTAsn1Integer_UnsignedCompareWithU32(&pSignerInfo->Version, RTCRPKCS7SIGNERINFO_V1) != 0) 110 111 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_SIGNER_INFO_VERSION, 111 " SignedData.SignerInfos[%u] version is %llu, expected %u",112 i, pSignerInfo->Version.uValue.u, RTCRPKCS7SIGNERINFO_V1);112 "%s: SignedData.SignerInfos[%u] version is %llu, expected %u", 113 pszErrorTag, i, pSignerInfo->Version.uValue.u, RTCRPKCS7SIGNERINFO_V1); 113 114 114 115 /* IssuerAndSerialNumber. */ … … 120 121 if (pSignerInfo->IssuerAndSerialNumber.SerialNumber.Asn1Core.cb == 0) 121 122 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_SIGNER_INFO_NO_ISSUER_SERIAL_NO, 122 "SignedData.SignerInfos[%u].IssuerAndSerialNumber.SerialNumber is missing (zero length)", i); 123 "%s: SignedData.SignerInfos[%u].IssuerAndSerialNumber.SerialNumber is missing (zero length)", 124 pszErrorTag, i); 123 125 124 126 PCRTCRX509CERTIFICATE pCert; … … 128 130 if (!pCert && (fFlags & RTCRPKCS7SIGNEDDATA_SANITY_F_SIGNING_CERT_PRESENT)) 129 131 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_SIGNER_CERT_NOT_SHIPPED, 130 "SignedData.SignerInfos[%u].IssuerAndSerialNumber not found in T0.Certificates", i); 132 "%s: SignedData.SignerInfos[%u].IssuerAndSerialNumber not found in T0.Certificates", 133 pszErrorTag, i); 131 134 132 135 /* DigestAlgorithm */ … … 138 141 if (j >= pSignedData->DigestAlgorithms.cItems) 139 142 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_DIGEST_ALGO_NOT_FOUND_IN_LIST, 140 " SignedData.SignerInfos[%u].DigestAlgorithm (%s) not found in SignedData.DigestAlgorithms",141 i, pSignerInfo->DigestAlgorithm.Algorithm.szObjId);143 "%s: SignedData.SignerInfos[%u].DigestAlgorithm (%s) not found in SignedData.DigestAlgorithms", 144 pszErrorTag, i, pSignerInfo->DigestAlgorithm.Algorithm.szObjId); 142 145 143 146 /* Digest encryption algorithm. */ … … 163 166 { 164 167 if (fFoundContentInfo) 165 return RTErrInfoSet (pErrInfo, VERR_CR_PKCS7_MISSING_CONTENT_TYPE_ATTRIB,166 "Multiple authenticated content-type attributes.");168 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_MISSING_CONTENT_TYPE_ATTRIB, 169 "%s: Multiple authenticated content-type attributes.", pszErrorTag); 167 170 fFoundContentInfo = true; 168 171 AssertReturn(pAttrib->enmType == RTCRPKCS7ATTRIBUTETYPE_OBJ_IDS, VERR_INTERNAL_ERROR_3); 169 172 if (pAttrib->uValues.pObjIds->cItems != 1) 170 173 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_BAD_CONTENT_TYPE_ATTRIB, 171 " Expected exactly one value for content-type attrib, found: %u",172 p Attrib->uValues.pObjIds->cItems);174 "%s: Expected exactly one value for content-type attrib, found: %u", 175 pszErrorTag, pAttrib->uValues.pObjIds->cItems); 173 176 } 174 177 else if (RTAsn1ObjId_CompareWithString(&pAttrib->Type, RTCR_PKCS9_ID_MESSAGE_DIGEST_OID) == 0) 175 178 { 176 179 if (fFoundMessageDigest) 177 return RTErrInfoSet (pErrInfo, VERR_CR_PKCS7_MISSING_MESSAGE_DIGEST_ATTRIB,178 "Multiple authenticated message-digest attributes.");180 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_MISSING_MESSAGE_DIGEST_ATTRIB, 181 "%s: Multiple authenticated message-digest attributes.", pszErrorTag); 179 182 fFoundMessageDigest = true; 180 183 AssertReturn(pAttrib->enmType == RTCRPKCS7ATTRIBUTETYPE_OCTET_STRINGS, VERR_INTERNAL_ERROR_3); 181 184 if (pAttrib->uValues.pOctetStrings->cItems != 1) 182 185 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_BAD_CONTENT_TYPE_ATTRIB, 183 " Expected exactly one value for message-digest attrib, found: %u",184 p Attrib->uValues.pOctetStrings->cItems);186 "%s: Expected exactly one value for message-digest attrib, found: %u", 187 pszErrorTag, pAttrib->uValues.pOctetStrings->cItems); 185 188 } 186 189 } 187 190 188 191 if (!fFoundContentInfo) 189 return RTErrInfoSet (pErrInfo, VERR_CR_PKCS7_MISSING_CONTENT_TYPE_ATTRIB,190 "Missing authenticated content-type attribute.");192 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_MISSING_CONTENT_TYPE_ATTRIB, 193 "%s: Missing authenticated content-type attribute.", pszErrorTag); 191 194 if (!fFoundMessageDigest) 192 return RTErrInfoSet (pErrInfo, VERR_CR_PKCS7_MISSING_MESSAGE_DIGEST_ATTRIB,193 "Missing authenticated message-digest attribute.");195 return RTErrInfoSetF(pErrInfo, VERR_CR_PKCS7_MISSING_MESSAGE_DIGEST_ATTRIB, 196 "%s: Missing authenticated message-digest attribute.", pszErrorTag); 194 197 } 195 198 } -
trunk/src/VBox/Runtime/common/crypto/pkcs7-verify.cpp
r62477 r62564 53 53 void const *pvContent, uint32_t cbContent, PRTERRINFO pErrInfo) 54 54 { 55 RT_NOREF_PV(fFlags); 56 55 57 /* 56 58 * Verify using OpenSSL. … … 149 151 void *pvUser, PRTERRINFO pErrInfo) 150 152 { 153 RT_NOREF_PV(hCertPaths); RT_NOREF_PV(pvUser); 151 154 int rc = VINF_SUCCESS; 152 155 … … 169 172 void *pvUser, PRTERRINFO pErrInfo) 170 173 { 174 RT_NOREF_PV(hCertPaths); RT_NOREF_PV(pvUser); 171 175 int rc = VINF_SUCCESS; 172 176 if (fFlags & RTCRPKCS7VCC_F_SIGNED_DATA) -
trunk/src/VBox/Runtime/common/crypto/pkix-signature-rsa.cpp
r62477 r62564 140 140 bool fSigning, PCRTASN1BITSTRING pKey, PCRTASN1DYNTYPE pParams) 141 141 { 142 RT_NOREF_PV(pDesc); RT_NOREF_PV(pvState); RT_NOREF_PV(pvOpaque); 143 142 144 if (pParams) 143 145 return VERR_CR_PKIX_SIGNATURE_TAKES_NO_PARAMETERS; … … 199 201 { 200 202 PRTCRPKIXSIGNATURERSA pThis = (PRTCRPKIXSIGNATURERSA)pvState; 203 RT_NOREF_PV(fSigning); RT_NOREF_PV(pDesc); 201 204 Assert(pThis->fSigning == fSigning); NOREF(pThis); 202 205 return VINF_SUCCESS; … … 208 211 { 209 212 PRTCRPKIXSIGNATURERSA pThis = (PRTCRPKIXSIGNATURERSA)pvState; 210 Assert(pThis->fSigning == fSigning); NOREF(pThis); 213 RT_NOREF_PV(fSigning); RT_NOREF_PV(pDesc); 214 Assert(pThis->fSigning == fSigning); 211 215 212 216 RTBigNumDestroy(&pThis->Modulus); … … 297 301 { 298 302 PRTCRPKIXSIGNATURERSA pThis = (PRTCRPKIXSIGNATURERSA)pvState; 303 RT_NOREF_PV(pDesc); 299 304 Assert(!pThis->fSigning); 300 305 if (cbSignature > sizeof(pThis->Scratch) / 2) … … 386 391 { 387 392 PRTCRPKIXSIGNATURERSA pThis = (PRTCRPKIXSIGNATURERSA)pvState; 393 RT_NOREF_PV(pDesc); RT_NOREF_PV(hDigest); RT_NOREF_PV(pvSignature); RT_NOREF_PV(pcbSignature); 388 394 Assert(pThis->fSigning); NOREF(pThis); 389 395 return VERR_NOT_IMPLEMENTED; -
trunk/src/VBox/Runtime/common/crypto/spc-asn1-decoder.cpp
r62477 r62564 48 48 49 49 { 50 RT_NOREF_PV(fFlags); RT_NOREF_PV(pszErrorTag); 51 50 52 int rc; 51 53 RTASN1CURSOR SubCursor; -
trunk/src/VBox/Runtime/common/crypto/store-inmem.cpp
r62477 r62564 228 228 uint8_t *pbKey, size_t cbKey, size_t *pcbKeyRet) 229 229 { 230 RT_NOREF_PV(pvProvider); RT_NOREF_PV(pCertCtx); RT_NOREF_PV(pbKey); RT_NOREF_PV(cbKey); RT_NOREF_PV(pcbKeyRet); 230 231 //PRTCRSTOREINMEM pThis = (PRTCRSTOREINMEM)pvProvider; 231 232 return VERR_NOT_FOUND; -
trunk/src/VBox/Runtime/common/crypto/store.cpp
r62477 r62564 323 323 AssertPtrReturn(pThis, VERR_INVALID_HANDLE); 324 324 AssertReturn(pThis->u32Magic == RTCRSTOREINT_MAGIC, VERR_INVALID_HANDLE); 325 RT_NOREF_PV(fFlags); 325 326 326 327 /* … … 376 377 AssertPtrReturn(pThis, VERR_INVALID_HANDLE); 377 378 AssertReturn(pThis->u32Magic == RTCRSTOREINT_MAGIC, VERR_INVALID_HANDLE); 379 RT_NOREF_PV(fFlags); 378 380 379 381 /* -
trunk/src/VBox/Runtime/common/crypto/x509-asn1-decoder.cpp
r62477 r62564 44 44 PRTCRX509EXTENSION pThis, const char *pszErrorTag) 45 45 { 46 RT_NOREF_PV(fFlags); RT_NOREF_PV(pszErrorTag); 47 46 48 pThis->enmValue = RTCRX509EXTENSIONVALUE_UNKNOWN; 47 49 -
trunk/src/VBox/Runtime/common/crypto/x509-certpaths.cpp
r62477 r62564 750 750 pNode = pParent; 751 751 } 752 753 RT_NOREF_PV(pThis); 752 754 } 753 755 … … 1137 1139 uint32_t uVerbosity, PFNRTDUMPPRINTFV pfnPrintfV, void *pvUser) 1138 1140 { 1141 RT_NOREF_PV(pThis); 1139 1142 rtDumpPrintf(pfnPrintfV, pvUser, "Path #%u: %s, %u deep, rcVerify=%Rrc\n", 1140 1143 iPath, RTCRX509CERTPATHNODE_SRC_IS_TRUSTED(pCurLeaf->uSrc) ? "trusted" : "untrusted", pCurLeaf->uDepth, -
trunk/src/VBox/Runtime/common/crypto/x509-sanity.cpp
r62477 r62564 41 41 static int rtCrX509Validity_CheckSanityExtra(PCRTCRX509VALIDITY pThis, uint32_t fFlags, PRTERRINFO pErrInfo, const char *pszErrorTag) 42 42 { 43 RT_NOREF_PV(fFlags); 44 43 45 if (RTAsn1Time_Compare(&pThis->NotBefore, &pThis->NotAfter) > 0) 44 46 return RTErrInfoSetF(pErrInfo, VERR_CR_X509_VALIDITY_SWAPPED, "%s: NotBefore is after NotAfter", pszErrorTag); … … 50 52 static int rtCrX509Name_CheckSanityExtra(PCRTCRX509NAME pThis, uint32_t fFlags, PRTERRINFO pErrInfo, const char *pszErrorTag) 51 53 { 54 RT_NOREF_PV(fFlags); 55 52 56 if (pThis->cItems == 0) 53 57 return RTErrInfoSetF(pErrInfo, VERR_CR_X509_NAME_EMPTY_SET, "%s: Has no components.", pszErrorTag); … … 94 98 PRTERRINFO pErrInfo, const char *pszErrorTag) 95 99 { 100 RT_NOREF_PV(fFlags); 96 101 if (pThis->SubjectPublicKey.cBits <= 32) 97 102 return RTErrInfoSetF(pErrInfo, VERR_CR_X509_PUBLIC_KEY_TOO_SMALL, … … 104 109 PRTERRINFO pErrInfo, const char *pszErrorTag) 105 110 { 111 RT_NOREF_PV(fFlags); 112 106 113 if ( RTAsn1Integer_IsPresent(&pThis->T0.Version) 107 114 && RTAsn1Integer_UnsignedCompareWithU32(&pThis->T0.Version, RTCRX509TBSCERTIFICATE_V1) != 0 … … 134 141 PRTERRINFO pErrInfo, const char *pszErrorTag) 135 142 { 143 RT_NOREF_PV(fFlags); 144 136 145 if (RTCrX509AlgorithmIdentifier_Compare(&pThis->SignatureAlgorithm, &pThis->TbsCertificate.Signature) != 0) 137 146 return RTErrInfoSetF(pErrInfo, VERR_CR_X509_CERT_TBS_SIGN_ALGO_MISMATCH, -
trunk/src/VBox/Runtime/common/dbg/dbgcfg.cpp
r62477 r62564 870 870 871 871 #else /* !IPRT_WITH_HTTP */ 872 RT_NOREF_PV(pThis); RT_NOREF_PV(pszServer); RT_NOREF_PV(pszPath); RT_NOREF_PV(pszCacheSubDir); 873 RT_NOREF_PV(pszUuidMappingSubDir); RT_NOREF_PV(pSplitFn); RT_NOREF_PV(pszCacheSuffix); RT_NOREF_PV(fFlags); 874 RT_NOREF_PV(pfnCallback); RT_NOREF_PV(pvUser1); RT_NOREF_PV(pvUser2); 872 875 return VWRN_NOT_FOUND; 873 876 #endif /* !IPRT_WITH_HTTP */ … … 878 881 const char *pszCacheSubDir, const char *pszUuidMappingSubDir, PRTPATHSPLIT pSplitFn) 879 882 { 883 RT_NOREF_PV(pThis); RT_NOREF_PV(pszSrc); RT_NOREF_PV(pchCache); RT_NOREF_PV(cchCache); 884 RT_NOREF_PV(pszUuidMappingSubDir); RT_NOREF_PV(pSplitFn); 885 880 886 if (!pszCacheSubDir || !*pszCacheSubDir) 881 887 return VINF_SUCCESS; … … 1315 1321 PFNRTDBGCFGOPEN pfnCallback, void *pvUser1, void *pvUser2) 1316 1322 { 1323 RT_NOREF_PV(cbImage); 1317 1324 /** @todo test this! */ 1318 1325 char szSubDir[32]; … … 1865 1872 PRTLISTANCHOR pList) 1866 1873 { 1874 RT_NOREF_PV(pThis); RT_NOREF_PV(fPaths); 1875 1867 1876 if (enmOp == RTDBGCFGOP_SET) 1868 1877 rtDbgCfgFreeStrList(pList); … … 1939 1948 PCRTDBGCFGU64MNEMONIC paMnemonics, uint64_t *puValue) 1940 1949 { 1950 RT_NOREF_PV(pThis); 1951 1941 1952 uint64_t uNew = enmOp == RTDBGCFGOP_SET ? 0 : *puValue; 1942 1943 1953 char ch; 1944 1954 while ((ch = *pszValue)) … … 2095 2105 char *pszValue, size_t cbValue) 2096 2106 { 2107 RT_NOREF_PV(hDbgCfg); 2108 2097 2109 /* 2098 2110 * Check the length first. … … 2135 2147 char *pszValue, size_t cbValue) 2136 2148 { 2149 RT_NOREF_PV(hDbgCfg); 2150 2137 2151 /* 2138 2152 * If no mnemonics, just return the hex value. -
trunk/src/VBox/Runtime/common/dbg/dbgmod.cpp
r62477 r62564 369 369 RTUINTPTR uSubtrahend, RTDBGCFG hDbgCfg) 370 370 { 371 RT_NOREF_PV(hDbgCfg); 372 371 373 /* 372 374 * Input validation and lazy initialization. … … 505 507 PRTDBGMODINT pDbgMod = (PRTDBGMODINT)pvUser1; 506 508 PCRTLDRDBGINFO pDbgInfo = (PCRTLDRDBGINFO)pvUser2; 507 NOREF(pDbgInfo); /** @todo consider a more direct search for a interpreter. */ 509 RT_NOREF_PV(pDbgInfo); /** @todo consider a more direct search for a interpreter. */ 510 RT_NOREF_PV(hDbgCfg); 508 511 509 512 Assert(!pDbgMod->pDbgVt); … … 563 566 { 564 567 RTDBGMODOPENDIETI *pArgs = (RTDBGMODOPENDIETI *)pvUser; 568 RT_NOREF_PV(hLdrMod); 565 569 566 570 Assert(pDbgInfo->enmType > RTLDRDBGINFOTYPE_INVALID && pDbgInfo->enmType < RTLDRDBGINFOTYPE_END); … … 675 679 { 676 680 PRTDBGMODINT pDbgMod = (PRTDBGMODINT)pvUser1; 677 NOREF(pvUser2); /** @todo image matching string or smth. */ 681 RT_NOREF_PV(pvUser2); /** @todo image matching string or smth. */ 682 RT_NOREF_PV(hDbgCfg); 678 683 679 684 Assert(!pDbgMod->pDbgVt); … … 945 950 PRTDBGMODDEFERRED pDeferred = (PRTDBGMODDEFERRED)pvUser2; 946 951 LogFlow(("rtDbgModFromPeImageOpenCallback: %s\n", pszFilename)); 952 RT_NOREF_PV(hDbgCfg); 947 953 948 954 Assert(pDbgMod->pImgVt == NULL); … … 1212 1218 PRTDBGMODINT pDbgMod = (PRTDBGMODINT)pvUser1; 1213 1219 PCRTDBGMODMACHOARGS pArgs = (PCRTDBGMODMACHOARGS)pvUser2; 1220 RT_NOREF_PV(hDbgCfg); 1214 1221 1215 1222 Assert(!pDbgMod->pDbgVt); … … 1331 1338 uint32_t cSegs, PCRTDBGSEGMENT paSegs, PCRTUUID pUuid, RTDBGCFG hDbgCfg) 1332 1339 { 1340 RT_NOREF_PV(cbImage); RT_NOREF_PV(cSegs); RT_NOREF_PV(paSegs); 1341 1333 1342 RTDBGMODMACHOARGS Args; 1334 1343 Args.enmArch = enmArch; -
trunk/src/VBox/Runtime/common/dbg/dbgmodcodeview.cpp
r62477 r62564 582 582 uint32_t cchName, uint32_t fFlags, uint32_t cbSym) 583 583 { 584 RT_NOREF_PV(fFlags); 584 585 const char *pszName = rtDbgModCvAddSanitizedStringToCache(pchName, cchName); 585 586 int rc; … … 667 668 RTCPTRUNION uCursor; 668 669 uCursor.pv = pvSymTab; 670 671 RT_NOREF_PV(fFlags); 669 672 670 673 while (cbSymTab > 0 && RT_SUCCESS(rc)) … … 827 830 static int rtDbgModCvSsProcessV8SrcStrings(PRTDBGMODCV pThis, void const *pvSrcStrings, size_t cbSrcStrings, uint32_t fFlags) 828 831 { 832 RT_NOREF_PV(fFlags); 833 829 834 if (pThis->cbSrcStrings) 830 835 Log(("\n!!More than one source file string table for this module!!\n\n")); … … 872 877 static int rtDbgModCvSsProcessV8SrcInfo(PRTDBGMODCV pThis, void const *pvSrcInfo, size_t cbSrcInfo, uint32_t fFlags) 873 878 { 879 RT_NOREF_PV(fFlags); 880 874 881 if (pThis->cbSrcInfo) 875 882 Log(("\n!!More than one source file info table for this module!!\n\n")); … … 903 910 static int rtDbgModCvSsProcessV8SectLines(PRTDBGMODCV pThis, void const *pvSectLines, size_t cbSectLines, uint32_t fFlags) 904 911 { 912 RT_NOREF_PV(fFlags); 913 905 914 /* 906 915 * Starts with header. … … 1098 1107 { 1099 1108 PCRTCVGLOBALSYMTABHDR pHdr = (PCRTCVGLOBALSYMTABHDR)pvSubSect; 1109 RT_NOREF_PV(pDirEnt); 1100 1110 1101 1111 /* … … 1124 1134 rtDbgModCvSs_Module(PRTDBGMODCV pThis, void const *pvSubSect, size_t cbSubSect, PCRTCVDIRENT32 pDirEnt) 1125 1135 { 1136 RT_NOREF_PV(pDirEnt); 1137 1126 1138 RTCPTRUNION uCursor; 1127 1139 uCursor.pv = pvSubSect; … … 1162 1174 rtDbgModCvSs_Symbols_PublicSym_AlignSym(PRTDBGMODCV pThis, void const *pvSubSect, size_t cbSubSect, PCRTCVDIRENT32 pDirEnt) 1163 1175 { 1176 RT_NOREF_PV(pDirEnt); 1164 1177 RTDBGMODCV_CHECK_NOMSG_RET_BF(pThis->uCurStyle == RT_MAKE_U16('C', 'V')); 1165 1178 RTDBGMODCV_CHECK_NOMSG_RET_BF(cbSubSect >= 8); … … 1180 1193 rtDbgModCvSs_SrcModule(PRTDBGMODCV pThis, void const *pvSubSect, size_t cbSubSect, PCRTCVDIRENT32 pDirEnt) 1181 1194 { 1195 RT_NOREF_PV(pDirEnt); 1182 1196 Log(("rtDbgModCvSs_SrcModule: uCurStyle=%#x\n%.*Rhxd\n", pThis->uCurStyle, cbSubSect, pvSubSect)); 1183 1197 … … 1660 1674 if (pEntry1->uSubSectType > pEntry2->uSubSectType) 1661 1675 return 1; 1676 1677 RT_NOREF_PV(pvUser); 1662 1678 return 0; 1663 1679 } … … 2110 2126 PCIMAGE_LINENUMBER paLines, uint32_t cLines) 2111 2127 { 2128 RT_NOREF_PV(iSection); 2112 2129 Log4(("Adding %u line numbers in section #%u for %s\n", cLines, iSection, pszFile)); 2113 2130 PCIMAGE_LINENUMBER pCur = paLines; … … 2439 2456 { 2440 2457 PRTDBGMODCV pThis = (PRTDBGMODCV)pMod->pvDbgPriv; 2441 Assert(!pszSymbol[cchSymbol]); 2458 Assert(!pszSymbol[cchSymbol]); RT_NOREF_PV(cchSymbol); 2442 2459 return RTDbgModSymbolByName(pThis->hCnt, pszSymbol/*, cchSymbol*/, pSymInfo); 2443 2460 } … … 2572 2589 static int rtDbgModCvAddSegmentsFromDbg(PRTDBGMODCV pThis, PCIMAGE_SEPARATE_DEBUG_HEADER pDbgHdr, const char *pszFilename) 2573 2590 { 2591 RT_NOREF_PV(pszFilename); 2592 2574 2593 /* 2575 2594 * Validate the header fields a little. … … 2741 2760 uint32_t off, uint32_t cb, const char *pszFilename) 2742 2761 { 2762 RT_NOREF_PV(pszFilename); 2763 2743 2764 /* 2744 2765 * Check that there is sufficient data for a header, then read it. … … 2834 2855 { 2835 2856 int rc = VERR_DBG_NO_MATCHING_INTERPRETER; 2857 RT_NOREF_PV(enmArch); RT_NOREF_PV(pszFilename); 2836 2858 2837 2859 /* Is a codeview format we (wish to) support? */ … … 2878 2900 PRTDBGMODINT pDbgMod = (PRTDBGMODINT)pvUser; 2879 2901 Assert(!pDbgMod->pvDbgPriv); 2902 RT_NOREF_PV(hLdrMod); 2880 2903 2881 2904 /* Skip external files, RTDbgMod will deal with those -
trunk/src/VBox/Runtime/common/dbg/dbgmoddwarf.cpp
r62477 r62564 3530 3530 static int rtDwarfLoc_Evaluate(PRTDWARFLOCST pLoc, void *pvLater, void *pvUser) 3531 3531 { 3532 RT_NOREF_PV(pvLater); RT_NOREF_PV(pvUser); 3533 3532 3534 while (!rtDwarfCursor_IsAtEndOfUnit(&pLoc->Cursor)) 3533 3535 { … … 4424 4426 { 4425 4427 PRTDBGMODDWARF pThis = (PRTDBGMODDWARF)pvUser; 4426 NOREF(hLdrMod);4428 RT_NOREF_PV(hLdrMod); RT_NOREF_PV(uSymbol); 4427 4429 Assert(pThis->iWatcomPass != 1); 4428 4430 … … 4556 4558 { 4557 4559 PRTDBGMODDWARF pThis = (PRTDBGMODDWARF)pMod->pvDbgPriv; 4558 Assert(!pszSymbol[cchSymbol]); 4560 Assert(!pszSymbol[cchSymbol]); RT_NOREF_PV(cchSymbol); 4559 4561 return RTDbgModSymbolByName(pThis->hCnt, pszSymbol/*, cchSymbol*/, pSymInfo); 4560 4562 } … … 4670 4672 static DECLCALLBACK(int) rtDbgModDwarfEnumCallback(RTLDRMOD hLdrMod, PCRTLDRDBGINFO pDbgInfo, void *pvUser) 4671 4673 { 4674 RT_NOREF_PV(hLdrMod); 4675 4672 4676 /* 4673 4677 * Skip stuff we can't handle. -
trunk/src/VBox/Runtime/common/dbg/dbgmodldr.cpp
r62477 r62564 89 89 { 90 90 PRTDBGMODLDR pThis = (PRTDBGMODLDR)pMod->pvImgPriv; 91 RT_NOREF_PV(iDbgInfoHint); 91 92 return rtLdrReadAt(pThis->hLdrMod, pvBuf, UINT32_MAX /** @todo iDbgInfo*/, off, cb); 92 93 } -
trunk/src/VBox/Runtime/common/ldr/ldrELF.cpp
r62477 r62564 123 123 const char *pszLogName = pReader->pfnLogName(pReader); NOREF(pszLogName); 124 124 125 RT_NOREF_PV(pErrInfo); /** @todo implement */ 126 125 127 /* 126 128 * Read the ident to decide if this is 32-bit or 64-bit -
trunk/src/VBox/Runtime/common/ldr/ldrELFRelocatable.cpp.h
r62477 r62564 1020 1020 { 1021 1021 PRTLDRMODELF pModElf = (PRTLDRMODELF)pMod; 1022 RT_NOREF_PV(pvBits); 1022 1023 1023 1024 /* … … 1290 1291 unsigned uSymbol, PRTLDRADDR pValue, void *pvUser) 1291 1292 { 1293 RT_NOREF_PV(hLdrMod); RT_NOREF_PV(pszModule); RT_NOREF_PV(pszSymbol); 1294 RT_NOREF_PV(uSymbol); RT_NOREF_PV(pValue); RT_NOREF_PV(pvUser); 1292 1295 return VERR_SYMBOL_NOT_FOUND; 1293 1296 } … … 1744 1747 const char *pszLogName = pReader->pfnLogName(pReader); 1745 1748 RTFOFF cbRawImage = pReader->pfnSize(pReader); 1749 RT_NOREF_PV(fFlags); 1746 1750 1747 1751 /* -
trunk/src/VBox/Runtime/common/ldr/ldrPE.cpp
r62477 r62564 2766 2766 return rc; 2767 2767 #else 2768 RT_NOREF_PV(pMod); RT_NOREF_PV(pfnCallback); RT_NOREF_PV(pvUser); RT_NOREF_PV(pErrInfo); 2768 2769 return VERR_NOT_SUPPORTED; 2769 2770 #endif … … 3054 3055 static int rtldrPEValidateFileHeader(PIMAGE_FILE_HEADER pFileHdr, uint32_t fFlags, const char *pszLogName, PRTLDRARCH penmArch) 3055 3056 { 3057 RT_NOREF_PV(pszLogName); 3058 3056 3059 size_t cbOptionalHeader; 3057 3060 switch (pFileHdr->Machine) … … 3115 3118 const IMAGE_FILE_HEADER *pFileHdr, RTFOFF cbRawImage, uint32_t fFlags) 3116 3119 { 3120 RT_NOREF_PV(pszLogName); 3121 3117 3122 const uint16_t CorrectMagic = pFileHdr->SizeOfOptionalHeader == sizeof(IMAGE_OPTIONAL_HEADER32) 3118 3123 ? IMAGE_NT_OPTIONAL_HDR32_MAGIC : IMAGE_NT_OPTIONAL_HDR64_MAGIC; … … 3306 3311 const IMAGE_OPTIONAL_HEADER64 *pOptHdr, RTFOFF cbRawImage, uint32_t fFlags, bool fNoCode) 3307 3312 { 3313 RT_NOREF_PV(pszLogName); 3314 3308 3315 const uint32_t cbImage = pOptHdr->SizeOfImage; 3309 3316 const IMAGE_SECTION_HEADER *pSH = &paSections[0]; -
trunk/src/VBox/Runtime/common/ldr/ldrkStuff.cpp
r62477 r62564 600 600 { 601 601 PRTLDRMODKLDRARGS pArgs = (PRTLDRMODKLDRARGS)pvUser; 602 NOREF(pMod); 602 RT_NOREF_PV(pMod); RT_NOREF_PV(iMajorVer); RT_NOREF_PV(iMinorVer); 603 603 604 604 605 RTLDRDBGINFO DbgInfo; … … 832 833 { 833 834 PRTLDRMODKLDR pThis = (PRTLDRMODKLDR)pMod; 835 RT_NOREF_PV(iDbgInfo); 834 836 /** @todo May have to apply fixups here. */ 835 837 return pThis->Core.pReader->pfnRead(pThis->Core.pReader, pvBuf, cb, off); … … 850 852 return VERR_NOT_FOUND; 851 853 AssertReturn(rc == 0, VERR_INVALID_PARAMETER); 854 cbBuf = RT_MIN(cbBuf, sizeof(RTUUID)); 852 855 break; 853 856 854 857 default: 858 RT_NOREF_PV(pvBits); 855 859 return VERR_NOT_FOUND; 856 860 } 861 if (pcbRet) 862 *pcbRet = cbBuf; 857 863 return VINF_SUCCESS; 858 864 } … … 901 907 int rtldrkLdrOpen(PRTLDRREADER pReader, uint32_t fFlags, RTLDRARCH enmArch, PRTLDRMOD phLdrMod, PRTERRINFO pErrInfo) 902 908 { 909 RT_NOREF_PV(pErrInfo); 910 903 911 /* Convert enmArch to k-speak. */ 904 912 KCPUARCH enmCpuArch; -
trunk/src/VBox/Runtime/common/misc/json.cpp
r62461 r62564 432 432 if ( !rtJsonTokenizerIsEos(pTokenizer) 433 433 && !rtJsonTokenizerIsSkipNewLine(pTokenizer)) 434 {435 434 break; /* Skipped everything, next is some real content. */ 436 }437 435 } 438 436 } … … 723 721 static void rtJsonTokenizerDestroy(PRTJSONTOKENIZER pTokenizer) 724 722 { 725 723 RT_NOREF_PV(pTokenizer); 726 724 } 727 725 … … 1142 1140 size_t *pcbRead) 1143 1141 { 1144 int rc = VINF_SUCCESS;1145 1142 PRTJSONREADERARGS pArgs = (PRTJSONREADERARGS)pvUser; 1143 1144 RT_NOREF_PV(offInput); 1145 1146 1146 size_t cbRead = 0; 1147 1148 rc = RTStrmReadEx(pArgs->u.hStream, pvBuf, cbBuf, &cbRead); 1147 int rc = RTStrmReadEx(pArgs->u.hStream, pvBuf, cbBuf, &cbRead); 1149 1148 if (RT_SUCCESS(rc)) 1150 1149 *pcbRead = cbRead; … … 1160 1159 AssertReturn(cbBuf > 0, VERR_INVALID_PARAMETER); 1161 1160 1162 int rc = VINF_SUCCESS;1161 RTJSONTOKENIZER Tokenizer; 1163 1162 RTJSONREADERARGS Args; 1164 RTJSONTOKENIZER Tokenizer;1165 1166 1163 Args.cbData = cbBuf; 1167 1164 Args.u.pbBuf = pbBuf; 1168 1165 1169 rc = rtJsonTokenizerInit(&Tokenizer, rtJsonTokenizerParseFromBuf, &Args);1166 int rc = rtJsonTokenizerInit(&Tokenizer, rtJsonTokenizerParseFromBuf, &Args); 1170 1167 if (RT_SUCCESS(rc)) 1171 1168 { … … 1182 1179 AssertPtrReturn(pszStr, VERR_INVALID_POINTER); 1183 1180 1184 int rc = VINF_SUCCESS;1185 1181 RTJSONTOKENIZER Tokenizer; 1186 1187 rc = rtJsonTokenizerInit(&Tokenizer, rtJsonTokenizerParseFromString, (void *)pszStr); 1182 int rc = rtJsonTokenizerInit(&Tokenizer, rtJsonTokenizerParseFromString, (void *)pszStr); 1188 1183 if (RT_SUCCESS(rc)) 1189 1184 { -
trunk/src/VBox/Runtime/common/misc/lockvalidator.cpp
r62477 r62564 3061 3061 if (pRecU->Excl.hThread == hThreadSelf) 3062 3062 { 3063 Assert(!fFirstRecursion); 3063 Assert(!fFirstRecursion); RT_NOREF_PV(fFirstRecursion); 3064 3064 pRecU->Excl.cRecursion++; 3065 3065 rtLockValidatorStackPushRecursion(hThreadSelf, pRecU, pSrcPos); … … 3098 3098 { 3099 3099 Assert(c < UINT32_C(0xffff0000)); 3100 Assert(!fFinalRecursion); 3100 Assert(!fFinalRecursion); RT_NOREF_PV(fFinalRecursion); 3101 3101 rtLockValidatorStackPopRecursion(pThread, pRec); 3102 3102 } -
trunk/src/VBox/Runtime/common/path/RTPathGlob.cpp
r62477 r62564 459 459 PRTPATHMATCHCACHE pCache) 460 460 { 461 RT_NOREF_PV(pCache); 462 461 463 /* 462 464 * Query the PATH value. … … 1650 1652 if (!(pGlob->fFlags & (RTPATHGLOB_F_NO_DIRS | RTPATHGLOB_F_ONLY_DIRS))) 1651 1653 return true; 1652 return RT_BOOL(pGlob->fFlags & RTPATHGLOB_F_ONLY_DIRS) == RTFS_IS_DIRECTORY( pGlob->u.ObjInfo.Attr.fMode);1654 return RT_BOOL(pGlob->fFlags & RTPATHGLOB_F_ONLY_DIRS) == RTFS_IS_DIRECTORY(fMode); 1653 1655 } 1654 1656 … … 1670 1672 { 1671 1673 /** @todo implement multi subdir matching. */ 1674 RT_NOREF_PV(pGlob); 1675 RT_NOREF_PV(offPath); 1676 RT_NOREF_PV(iStarStarComp); 1677 RT_NOREF_PV(offStarStarPath); 1672 1678 return VERR_PATH_MATCH_FEATURE_NOT_IMPLEMENTED; 1673 1679 } -
trunk/src/VBox/Runtime/common/string/strcache.cpp
r62477 r62564 349 349 RTMemFree(pThis); 350 350 } 351 352 RT_NOREF_PV(pszName); 351 353 return rc; 352 354 } … … 431 433 } 432 434 # endif 435 RT_NOREF_PV(pThis); 433 436 } 434 437 #else -
trunk/src/VBox/Runtime/common/string/strformatrt.cpp
r62477 r62564 375 375 376 376 AssertMsg(!chArgSize, ("Not argument size '%c' for RT types! '%.10s'\n", chArgSize, pszFormatOrg)); 377 RT_NOREF_PV(chArgSize); 377 378 378 379 /* -
trunk/src/VBox/Runtime/common/vfs/vfsiosmisc.cpp
r62477 r62564 220 220 /* Make sure the caller isn't messing with us. Hardcoded, but works. */ 221 221 Assert(((size_t *)pvBuf)[0] == READ_ALL_HEADER_MAGIC); 222 Assert(((size_t *)pvBuf)[1] == cbBuf); 222 Assert(((size_t *)pvBuf)[1] == cbBuf); RT_NOREF_PV(cbBuf); 223 223 224 224 /* Free it. */ -
trunk/src/VBox/Runtime/common/zip/pkzip.cpp
r62477 r62564 91 91 PMEMIOSTREAM pThis = (PMEMIOSTREAM)pvThis; 92 92 Assert(pSgBuf->cSegs == 1); 93 RT_NOREF_PV(fBlocking); 93 94 94 95 if (off < 0) … … 119 120 static DECLCALLBACK(int) memFssIos_Write(void *pvThis, RTFOFF off, PCRTSGBUF pSgBuf, bool fBlocking, size_t *pcbWritten) 120 121 { 122 RT_NOREF_PV(pvThis); RT_NOREF_PV(off); RT_NOREF_PV(pSgBuf); RT_NOREF_PV(fBlocking); RT_NOREF_PV(pcbWritten); 121 123 return VERR_NOT_IMPLEMENTED; 122 124 } … … 127 129 static DECLCALLBACK(int) memFssIos_Flush(void *pvThis) 128 130 { 131 RT_NOREF_PV(pvThis); 129 132 return VERR_NOT_IMPLEMENTED; 130 133 } … … 135 138 static DECLCALLBACK(int) memFssIos_PollOne(void *pvThis, uint32_t fEvents, RTMSINTERVAL cMillies, bool fIntr, uint32_t *pfRetEvents) 136 139 { 140 RT_NOREF_PV(pvThis); RT_NOREF_PV(fEvents); RT_NOREF_PV(cMillies); RT_NOREF_PV(fIntr); RT_NOREF_PV(pfRetEvents); 137 141 return VERR_NOT_IMPLEMENTED; 138 142 } -
trunk/src/VBox/Runtime/common/zip/pkzipvfs.cpp
r62477 r62564 898 898 PRTZIPPKZIPIOSTREAM pThis = (PRTZIPPKZIPIOSTREAM)pvThis; 899 899 Assert(pSgBuf->cSegs == 1); 900 RT_NOREF_PV(fBlocking); 900 901 901 902 if (off < 0) … … 981 982 } 982 983 983 static DECLCALLBACK(int) rtZipPkzipFssIos_Write(void *pvThis, RTFOFF off, PCRTSGBUF pSgBuf, bool fBlocking, size_t *pcWritten) 984 { 984 static DECLCALLBACK(int) rtZipPkzipFssIos_Write(void *pvThis, RTFOFF off, PCRTSGBUF pSgBuf, bool fBlocking, size_t *pcbWritten) 985 { 986 RT_NOREF_PV(pvThis); RT_NOREF_PV(off); RT_NOREF_PV(pSgBuf); RT_NOREF_PV(fBlocking); RT_NOREF_PV(pcbWritten); 985 987 return VERR_NOT_IMPLEMENTED; 986 988 } … … 988 990 static DECLCALLBACK(int) rtZipPkzipFssIos_Flush(void *pvThis) 989 991 { 992 RT_NOREF_PV(pvThis); 990 993 return VERR_NOT_IMPLEMENTED; 991 994 } -
trunk/src/VBox/Runtime/common/zip/unzipcmd.cpp
r62477 r62564 95 95 const char *pszName, RTEXITCODE rcExit, PRTFOFF pcBytes) 96 96 { 97 RT_NOREF_PV(pOpts); 98 97 99 /* 98 100 * Query all the information. -
trunk/src/VBox/Runtime/common/zip/zip.cpp
r62477 r62564 1720 1720 { 1721 1721 /* input validation - the crash and burn approach as speed is essential here. */ 1722 Assert(enmLevel <= RTZIPLEVEL_MAX && enmLevel >= RTZIPLEVEL_STORE); 1723 Assert(!fFlags); 1722 Assert(enmLevel <= RTZIPLEVEL_MAX && enmLevel >= RTZIPLEVEL_STORE); RT_NOREF_PV(enmLevel); 1723 Assert(!fFlags); RT_NOREF_PV(fFlags); 1724 1724 1725 1725 /* … … 1836 1836 { 1837 1837 /* input validation - the crash and burn approach as speed is essential here. */ 1838 Assert(!fFlags); 1838 Assert(!fFlags); RT_NOREF_PV(fFlags); 1839 1839 1840 1840 /* -
trunk/src/VBox/Runtime/generic/RTFileReadAllFree-generic.cpp
r62477 r62564 45 45 */ 46 46 pvFile = (void *)((uintptr_t)pvFile - 32); 47 Assert(*(size_t *)pvFile == cbFile); 47 Assert(*(size_t *)pvFile == cbFile); RT_NOREF_PV(cbFile); 48 48 *(size_t *)pvFile = ~(size_t)1; 49 49 -
trunk/src/VBox/Runtime/generic/cdrom-generic.cpp
r62477 r62564 38 38 RTDECL(int) RTCdromOpen(const char *psz, uint32_t fFlags, PRTCDROM phCdrom) 39 39 { 40 RT_NOREF_PV(psz); RT_NOREF_PV(fFlags); RT_NOREF_PV(phCdrom); 40 41 return VERR_NOT_IMPLEMENTED; 41 42 } … … 44 45 RTDECL(uint32_t) RTCdromRetain(RTCDROM hCdrom) 45 46 { 47 RT_NOREF_PV(hCdrom); 46 48 AssertFailedReturn(UINT32_MAX); 47 49 } … … 50 52 RTDECL(uint32_t) RTCdromRelease(RTCDROM hCdrom) 51 53 { 54 RT_NOREF_PV(hCdrom); 52 55 AssertFailedReturn(UINT32_MAX); 53 56 } … … 56 59 RTDECL(int) RTCdromQueryMountPoint(RTCDROM hCdrom, char *pszMountPoint, size_t cbMountPoint) 57 60 { 61 RT_NOREF_PV(hCdrom); 62 RT_NOREF_PV(pszMountPoint); 63 RT_NOREF_PV(cbMountPoint); 58 64 AssertFailedReturn(VERR_NOT_IMPLEMENTED); 59 65 } … … 62 68 RTDECL(int) RTCdromUnmount(RTCDROM hCdrom) 63 69 { 70 RT_NOREF_PV(hCdrom); 64 71 AssertFailedReturn(VERR_NOT_IMPLEMENTED); 65 72 } … … 68 75 RTDECL(int) RTCdromEject(RTCDROM hCdrom, bool fForce) 69 76 { 77 RT_NOREF_PV(hCdrom); 78 RT_NOREF_PV(fForce); 70 79 AssertFailedReturn(VERR_NOT_IMPLEMENTED); 71 80 } … … 74 83 RTDECL(int) RTCdromLock(RTCDROM hCdrom) 75 84 { 85 RT_NOREF_PV(hCdrom); 76 86 AssertFailedReturn(VERR_NOT_IMPLEMENTED); 77 87 } … … 80 90 RTDECL(int) RTCdromUnlock(RTCDROM hCdrom) 81 91 { 92 RT_NOREF_PV(hCdrom); 82 93 AssertFailedReturn(VERR_NOT_IMPLEMENTED); 83 94 } … … 91 102 RTDECL(int) RTCdromOrdinalToName(unsigned iCdrom, char *pszName, size_t cbName) 92 103 { 104 RT_NOREF_PV(iCdrom); 93 105 if (cbName) 94 106 *pszName = '\0'; … … 99 111 RTDECL(int) RTCdromOpenByOrdinal(unsigned iCdrom, uint32_t fFlags, PRTCDROM phCdrom) 100 112 { 113 RT_NOREF_PV(iCdrom); 114 RT_NOREF_PV(fFlags); 115 RT_NOREF_PV(phCdrom); 101 116 return VERR_OUT_OF_RANGE; 102 117 } -
trunk/src/VBox/Runtime/generic/critsectrw-generic.cpp
r62556 r62564 927 927 RTDECL(bool) RTCritSectRwIsReadOwner(PRTCRITSECTRW pThis, bool fWannaHear) 928 928 { 929 RT_NOREF_PV(fWannaHear); 930 929 931 /* 930 932 * Validate handle. -
trunk/src/VBox/Runtime/generic/mempool-generic.cpp
r62477 r62564 380 380 Assert( hMemPool == NIL_RTMEMPOOL 381 381 || hMemPool == pEntry->pMemPool 382 || (hMemPool == RTMEMPOOL_DEFAULT && pEntry->pMemPool == &g_rtMemPoolDefault)); 382 || (hMemPool == RTMEMPOOL_DEFAULT && pEntry->pMemPool == &g_rtMemPoolDefault)); RT_NOREF_PV(hMemPool); 383 383 AssertReturn(pEntry->cRefs > 0, UINT32_MAX); 384 384 -
trunk/src/VBox/Runtime/generic/spinlock-generic.cpp
r62477 r62564 78 78 PRTSPINLOCKINTERNAL pThis; 79 79 AssertReturn(fFlags == RTSPINLOCK_FLAGS_INTERRUPT_SAFE || fFlags == RTSPINLOCK_FLAGS_INTERRUPT_UNSAFE, VERR_INVALID_PARAMETER); 80 RT_NOREF_PV(pszName); 80 81 81 82 /* -
trunk/src/VBox/Runtime/r3/allocex.cpp
r62477 r62564 41 41 RTDECL(int) RTMemAllocExTag(size_t cb, size_t cbAlignment, uint32_t fFlags, const char *pszTag, void **ppv) RT_NO_THROW_DEF 42 42 { 43 RT_NOREF_PV(pszTag); 44 43 45 /* 44 46 * Validate and adjust input. … … 114 116 AssertMsg(pHdr->u32Magic == RTMEMHDR_MAGIC, ("pHdr->u32Magic=%RX32 pv=%p cb=%#x\n", pHdr->u32Magic, pv, cb)); 115 117 pHdr->u32Magic = RTMEMHDR_MAGIC_DEAD; 116 Assert(pHdr->cbReq == cb); 118 Assert(pHdr->cbReq == cb); RT_NOREF_PV(cb); 117 119 118 120 if (pHdr->fFlags & (RTMEMALLOCEX_FLAGS_16BIT_REACH | RTMEMALLOCEX_FLAGS_32BIT_REACH)) -
trunk/src/VBox/Runtime/r3/dir.cpp
r62477 r62564 656 656 AssertMsgReturn(VALID_PTR(ppDir), ("%p\n", ppDir), VERR_INVALID_POINTER); 657 657 AssertMsgReturn(VALID_PTR(pszPath), ("%p\n", pszPath), VERR_INVALID_POINTER); 658 AssertReturn(!(fOpen & ~RTDIROPEN_FLAGS_NO_SYMLINKS), VERR_INVALID_FLAGS); 658 659 switch (enmFilter) 659 660 { -
trunk/src/VBox/Runtime/r3/init.cpp
r62477 r62564 146 146 || defined(RT_OS_LINUX) || defined(RT_OS_OS2) || defined(RT_OS_SOLARIS) /** @todo add host init hooks everywhere. */ 147 147 /* Stubs */ 148 DECLHIDDEN(int) rtR3InitNativeFirst(uint32_t fFlags) {return VINF_SUCCESS; }149 DECLHIDDEN(int) rtR3InitNativeFinal(uint32_t fFlags) {return VINF_SUCCESS; }150 DECLHIDDEN(void) rtR3InitNativeObtrusive(uint32_t fFlags) { }148 DECLHIDDEN(int) rtR3InitNativeFirst(uint32_t fFlags) { RT_NOREF_PV(fFlags); return VINF_SUCCESS; } 149 DECLHIDDEN(int) rtR3InitNativeFinal(uint32_t fFlags) { RT_NOREF_PV(fFlags); return VINF_SUCCESS; } 150 DECLHIDDEN(void) rtR3InitNativeObtrusive(uint32_t fFlags) { RT_NOREF_PV(fFlags); } 151 151 #endif 152 152 -
trunk/src/VBox/Runtime/r3/linux/sched-linux.cpp
r62477 r62564 589 589 Assert(enmType > RTTHREADTYPE_INVALID && enmType < RTTHREADTYPE_END); 590 590 Assert(enmType == g_pProcessPriority->paTypes[enmType].enmType); 591 Assert((pthread_t)pThread->Core.Key == pthread_self()); 591 Assert((pthread_t)pThread->Core.Key == pthread_self()); RT_NOREF_PV(pThread); 592 592 593 593 /* -
trunk/src/VBox/Runtime/r3/memsafer-r3.cpp
r62477 r62564 114 114 static DECLCALLBACK(int32_t) rtMemSaferOnceInit(void *pvUserIgnore) 115 115 { 116 RT_NOREF_PV(pvUserIgnore); 117 116 118 g_uMemSaferScramblerXor = (uintptr_t)RTRandU64(); 117 119 g_uMemSaferPtrScramblerXor = (uintptr_t)RTRandU64(); … … 126 128 static DECLCALLBACK(void) rtMemSaferOnceTerm(void *pvUser, bool fLazyCleanUpOk) 127 129 { 130 RT_NOREF_PV(pvUser); 131 128 132 if (!fLazyCleanUpOk) 129 133 { … … 314 318 } 315 319 return rc; 320 316 321 #else /* !IN_SUP_R3 */ 322 RT_NOREF_PV(pThis); 317 323 return VERR_NOT_SUPPORTED; 318 324 #endif /* !IN_SUP_R3 */ … … 362 368 RTDECL(int) RTMemSaferAllocZExTag(void **ppvNew, size_t cb, uint32_t fFlags, const char *pszTag) RT_NO_THROW_DEF 363 369 { 370 RT_NOREF_PV(pszTag); 371 364 372 /* 365 373 * Validate input. -
trunk/src/VBox/Runtime/r3/poll.cpp
r62477 r62564 353 353 354 354 #else /* POSIX */ 355 356 RT_NOREF_PV(MsStart); 355 357 356 358 /* clear the revents. */ -
trunk/src/VBox/Runtime/r3/posix/allocex-r3-posix.cpp
r62477 r62564 105 105 DECLHIDDEN(void) rtMemFreeExYyBitReach(void *pv, size_t cb, uint32_t fFlags) 106 106 { 107 RT_NOREF_PV(fFlags); 107 108 munmap(pv, cb); 108 109 } -
trunk/src/VBox/Runtime/r3/posix/dir-posix.cpp
r62477 r62564 79 79 RTDECL(int) RTDirCreate(const char *pszPath, RTFMODE fMode, uint32_t fCreate) 80 80 { 81 RT_NOREF_PV(fCreate); 82 81 83 int rc; 82 84 fMode = rtFsModeNormalize(fMode, pszPath, 0); -
trunk/src/VBox/Runtime/r3/posix/fs-posix.cpp
r62477 r62564 177 177 RTR3DECL(bool) RTFsIsCaseSensitive(const char *pszFsPath) 178 178 { 179 RT_NOREF_PV(pszFsPath); 179 180 #if defined(RT_OS_OS2) || defined(RT_OS_WINDOWS) 180 181 return false; -
trunk/src/VBox/Runtime/r3/posix/ldrNative-posix.cpp
r62477 r62564 123 123 int rtldrNativeLoadSystem(const char *pszFilename, const char *pszExt, uint32_t fFlags, PRTLDRMOD phLdrMod) 124 124 { 125 RT_NOREF_PV(pszFilename); RT_NOREF_PV(pszExt); RT_NOREF_PV(fFlags); RT_NOREF_PV(phLdrMod); 125 126 /** @todo implement this in some sensible fashion. */ 126 127 return VERR_NOT_SUPPORTED; -
trunk/src/VBox/Runtime/r3/posix/localipc-posix.cpp
r62477 r62564 1049 1049 RTDECL(int) RTLocalIpcSessionQueryProcess(RTLOCALIPCSESSION hSession, PRTPROCESS pProcess) 1050 1050 { 1051 RT_NOREF_PV(hSession); RT_NOREF_PV(pProcess); 1051 1052 return VERR_NOT_SUPPORTED; 1052 1053 } … … 1055 1056 RTDECL(int) RTLocalIpcSessionQueryUserId(RTLOCALIPCSESSION hSession, PRTUID pUid) 1056 1057 { 1058 RT_NOREF_PV(hSession); RT_NOREF_PV(pUid); 1057 1059 return VERR_NOT_SUPPORTED; 1058 1060 } … … 1061 1063 RTDECL(int) RTLocalIpcSessionQueryGroupId(RTLOCALIPCSESSION hSession, PRTGID pGid) 1062 1064 { 1065 RT_NOREF_PV(hSession); RT_NOREF_PV(pGid); 1063 1066 return VERR_NOT_SUPPORTED; 1064 1067 } -
trunk/src/VBox/Runtime/r3/posix/path-posix.cpp
r62477 r62564 302 302 RTR3DECL(int) RTPathUnlink(const char *pszPath, uint32_t fUnlink) 303 303 { 304 RT_NOREF_PV(pszPath); RT_NOREF_PV(fUnlink); 304 305 return VERR_NOT_IMPLEMENTED; 305 306 } -
trunk/src/VBox/Runtime/r3/posix/process-creation-posix.cpp
r62477 r62564 314 314 rc = VERR_BUFFER_OVERFLOW; 315 315 } 316 #else 317 RT_NOREF_PV(hEnvToUse); RT_NOREF_PV(fFlags); RT_NOREF_PV(hEnv); 316 318 #endif 317 319 return rc; -
trunk/src/VBox/Runtime/r3/posix/semevent-posix.cpp
r61751 r62564 151 151 } 152 152 pThis->fEverHadSignallers = false; 153 #else 154 RT_NOREF_PV(hClass); RT_NOREF_PV(pszNameFmt); 153 155 #endif 154 156 … … 500 502 ASMAtomicWriteBool(&pThis->fEverHadSignallers, true); 501 503 RTLockValidatorRecSharedResetOwner(&pThis->Signallers, hThread, NULL); 504 #else 505 RT_NOREF_PV(hEventSem); RT_NOREF_PV(hThread); 502 506 #endif 503 507 } … … 514 518 ASMAtomicWriteBool(&pThis->fEverHadSignallers, true); 515 519 RTLockValidatorRecSharedAddOwner(&pThis->Signallers, hThread, NULL); 520 #else 521 RT_NOREF_PV(hEventSem); RT_NOREF_PV(hThread); 516 522 #endif 517 523 } … … 527 533 528 534 RTLockValidatorRecSharedRemoveOwner(&pThis->Signallers, hThread); 529 #endif 530 } 531 535 #else 536 RT_NOREF_PV(hEventSem); RT_NOREF_PV(hThread); 537 #endif 538 } 539 -
trunk/src/VBox/Runtime/r3/posix/semeventmulti-posix.cpp
r61751 r62564 167 167 } 168 168 pThis->fEverHadSignallers = false; 169 #else 170 RT_NOREF_PV(hClass); RT_NOREF_PV(pszNameFmt); 169 171 #endif 170 172 … … 421 423 #else 422 424 RTTHREAD hThreadSelf = RTThreadSelf(); 425 RT_NOREF_PV(pSrcPos); 423 426 #endif 424 427 RTThreadBlocking(hThreadSelf, RTTHREADSTATE_EVENT_MULTI, true); … … 632 635 ASMAtomicWriteBool(&pThis->fEverHadSignallers, true); 633 636 RTLockValidatorRecSharedResetOwner(&pThis->Signallers, hThread, NULL); 637 #else 638 RT_NOREF_PV(hEventMultiSem); RT_NOREF_PV(hThread); 634 639 #endif 635 640 } … … 646 651 ASMAtomicWriteBool(&pThis->fEverHadSignallers, true); 647 652 RTLockValidatorRecSharedAddOwner(&pThis->Signallers, hThread, NULL); 653 #else 654 RT_NOREF_PV(hEventMultiSem); RT_NOREF_PV(hThread); 648 655 #endif 649 656 } … … 659 666 660 667 RTLockValidatorRecSharedRemoveOwner(&pThis->Signallers, hThread); 661 #endif 662 } 663 668 #else 669 RT_NOREF_PV(hEventMultiSem); RT_NOREF_PV(hThread); 670 #endif 671 } 672 -
trunk/src/VBox/Runtime/r3/posix/semmutex-posix.cpp
r61751 r62564 149 149 va_end(va); 150 150 } 151 #else 152 RT_NOREF_PV(hClass); RT_NOREF_PV(uSubClass); RT_NOREF_PV(pszNameFmt); 151 153 #endif 152 154 … … 211 213 return RTLockValidatorRecExclSetSubClass(&pThis->ValidatorRec, uSubClass); 212 214 #else 215 RT_NOREF_PV(hMutexSem); RT_NOREF_PV(uSubClass); 213 216 return RTLOCKVAL_SUB_CLASS_INVALID; 214 217 #endif … … 256 259 hThreadSelf = RTThreadSelf(); 257 260 RTThreadBlocking(hThreadSelf, RTTHREADSTATE_MUTEX, true); 261 RT_NOREF_PV(pSrcPos); 258 262 #endif 259 263 } -
trunk/src/VBox/Runtime/r3/posix/semrw-posix.cpp
r61751 r62564 145 145 } 146 146 RTLockValidatorRecMakeSiblings(&pThis->ValidatorWrite.Core, &pThis->ValidatorRead.Core); 147 #else 148 RT_NOREF_PV(hClass); RT_NOREF_PV(uSubClass); RT_NOREF_PV(pszNameFmt); 147 149 #endif 148 150 *phRWSem = pThis; … … 215 217 return RTLockValidatorRecExclSetSubClass(&pThis->ValidatorWrite, uSubClass); 216 218 #else 219 RT_NOREF_PV(hRWSem); RT_NOREF_PV(uSubClass); 217 220 return RTLOCKVAL_SUB_CLASS_INVALID; 218 221 #endif … … 264 267 hThreadSelf = RTThreadSelf(); 265 268 RTThreadBlocking(hThreadSelf, RTTHREADSTATE_RW_READ, true); 269 RT_NOREF_PV(pSrcPos); 266 270 #endif 267 271 } … … 459 463 hThreadSelf = RTThreadSelf(); 460 464 RTThreadBlocking(hThreadSelf, RTTHREADSTATE_RW_WRITE, true); 465 RT_NOREF_PV(pSrcPos); 461 466 #endif 462 467 } -
trunk/src/VBox/Runtime/r3/posix/symlink-posix.cpp
r62477 r62564 94 94 RTDECL(int) RTSymlinkCreate(const char *pszSymlink, const char *pszTarget, RTSYMLINKTYPE enmType, uint32_t fCreate) 95 95 { 96 RT_NOREF_PV(fCreate); 97 96 98 /* 97 99 * Validate the input. … … 132 134 RTDECL(int) RTSymlinkDelete(const char *pszSymlink, uint32_t fDelete) 133 135 { 136 RT_NOREF_PV(fDelete); 137 134 138 char const *pszNativeSymlink; 135 139 int rc = rtPathToNative(&pszNativeSymlink, pszSymlink, NULL); … … 161 165 RTDECL(int) RTSymlinkRead(const char *pszSymlink, char *pszTarget, size_t cbTarget, uint32_t fRead) 162 166 { 167 RT_NOREF_PV(fRead); 168 163 169 char *pszMyTarget; 164 170 int rc = RTSymlinkReadA(pszSymlink, &pszMyTarget); -
trunk/src/VBox/Runtime/r3/socket.cpp
r62477 r62564 1981 1981 1982 1982 #else /* !RT_OS_WINDOWS */ 1983 RT_NOREF_PV(fEvents); 1983 1984 *phNative = (RTHCUINTPTR)pThis->hNative; 1984 1985 return VINF_SUCCESS;
Note:
See TracChangeset
for help on using the changeset viewer.