Changeset 62564 in vbox for trunk/src/VBox/Runtime/common/dbg

Timestamp:

Jul 26, 2016 2:43:03 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109133

Message:

IPRT: Mark unused parameters.

Location:

trunk/src/VBox/Runtime/common/dbg

Files:

• dbgcfg.cpp (modified) (7 diffs)
• dbgmod.cpp (modified) (7 diffs)
• dbgmodcodeview.cpp (modified) (16 diffs)
• dbgmoddwarf.cpp (modified) (4 diffs)
• dbgmodldr.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/dbg/dbgcfg.cpp

@@ -870 +870 @@
 
 #else  /* !IPRT_WITH_HTTP */
+    RT_NOREF_PV(pThis); RT_NOREF_PV(pszServer); RT_NOREF_PV(pszPath); RT_NOREF_PV(pszCacheSubDir);
+    RT_NOREF_PV(pszUuidMappingSubDir); RT_NOREF_PV(pSplitFn); RT_NOREF_PV(pszCacheSuffix); RT_NOREF_PV(fFlags);
+    RT_NOREF_PV(pfnCallback); RT_NOREF_PV(pvUser1); RT_NOREF_PV(pvUser2);
     return VWRN_NOT_FOUND;
 #endif /* !IPRT_WITH_HTTP */
@@ -878 +881 @@
                                    const char *pszCacheSubDir, const char *pszUuidMappingSubDir, PRTPATHSPLIT pSplitFn)
 {
+    RT_NOREF_PV(pThis); RT_NOREF_PV(pszSrc); RT_NOREF_PV(pchCache); RT_NOREF_PV(cchCache);
+    RT_NOREF_PV(pszUuidMappingSubDir); RT_NOREF_PV(pSplitFn);
+
     if (!pszCacheSubDir || !*pszCacheSubDir)
         return VINF_SUCCESS;
@@ -1315 +1321 @@
                               PFNRTDBGCFGOPEN pfnCallback, void *pvUser1, void *pvUser2)
 {
+    RT_NOREF_PV(cbImage);
     /** @todo test this! */
     char szSubDir[32];
@@ -1865 +1872 @@
                                     PRTLISTANCHOR pList)
 {
+    RT_NOREF_PV(pThis); RT_NOREF_PV(fPaths);
+
     if (enmOp == RTDBGCFGOP_SET)
         rtDbgCfgFreeStrList(pList);
@@ -1939 +1948 @@
                                    PCRTDBGCFGU64MNEMONIC paMnemonics, uint64_t *puValue)
 {
+    RT_NOREF_PV(pThis);
+
     uint64_t    uNew = enmOp == RTDBGCFGOP_SET ? 0 : *puValue;
-
     char        ch;
     while ((ch = *pszValue))
@@ -2095 +2105 @@
                                    char *pszValue, size_t cbValue)
 {
+    RT_NOREF_PV(hDbgCfg);
+
     /*
      * Check the length first.
@@ -2135 +2147 @@
                                   char *pszValue, size_t cbValue)
 {
+    RT_NOREF_PV(hDbgCfg);
+
     /*
      * If no mnemonics, just return the hex value.

trunk/src/VBox/Runtime/common/dbg/dbgmod.cpp

@@ -369 +369 @@
                                   RTUINTPTR uSubtrahend, RTDBGCFG hDbgCfg)
 {
+    RT_NOREF_PV(hDbgCfg);
+
     /*
      * Input validation and lazy initialization.
@@ -505 +507 @@
     PRTDBGMODINT        pDbgMod   = (PRTDBGMODINT)pvUser1;
     PCRTLDRDBGINFO      pDbgInfo  = (PCRTLDRDBGINFO)pvUser2;
-    NOREF(pDbgInfo); /** @todo consider a more direct search for a interpreter. */
+    RT_NOREF_PV(pDbgInfo); /** @todo consider a more direct search for a interpreter. */
+    RT_NOREF_PV(hDbgCfg);
 
     Assert(!pDbgMod->pDbgVt);
@@ -563 +566 @@
 {
     RTDBGMODOPENDIETI *pArgs = (RTDBGMODOPENDIETI *)pvUser;
+    RT_NOREF_PV(hLdrMod);
 
     Assert(pDbgInfo->enmType > RTLDRDBGINFOTYPE_INVALID && pDbgInfo->enmType < RTLDRDBGINFOTYPE_END);
@@ -675 +679 @@
 {
     PRTDBGMODINT        pDbgMod   = (PRTDBGMODINT)pvUser1;
-    NOREF(pvUser2); /** @todo image matching string or smth. */
+    RT_NOREF_PV(pvUser2); /** @todo image matching string or smth. */
+    RT_NOREF_PV(hDbgCfg);
 
     Assert(!pDbgMod->pDbgVt);
@@ -945 +950 @@
     PRTDBGMODDEFERRED   pDeferred = (PRTDBGMODDEFERRED)pvUser2;
     LogFlow(("rtDbgModFromPeImageOpenCallback: %s\n", pszFilename));
+    RT_NOREF_PV(hDbgCfg);
 
     Assert(pDbgMod->pImgVt == NULL);
@@ -1212 +1218 @@
     PRTDBGMODINT        pDbgMod = (PRTDBGMODINT)pvUser1;
     PCRTDBGMODMACHOARGS pArgs   = (PCRTDBGMODMACHOARGS)pvUser2;
+    RT_NOREF_PV(hDbgCfg);
 
     Assert(!pDbgMod->pDbgVt);
@@ -1331 +1338 @@
                                         uint32_t cSegs, PCRTDBGSEGMENT paSegs, PCRTUUID pUuid, RTDBGCFG hDbgCfg)
 {
+    RT_NOREF_PV(cbImage); RT_NOREF_PV(cSegs); RT_NOREF_PV(paSegs);
+
     RTDBGMODMACHOARGS Args;
     Args.enmArch    = enmArch;

trunk/src/VBox/Runtime/common/dbg/dbgmodcodeview.cpp

@@ -582 +582 @@
                                uint32_t cchName, uint32_t fFlags, uint32_t cbSym)
 {
+    RT_NOREF_PV(fFlags);
     const char *pszName = rtDbgModCvAddSanitizedStringToCache(pchName, cchName);
     int rc;
@@ -667 +668 @@
     RTCPTRUNION uCursor;
     uCursor.pv = pvSymTab;
+
+    RT_NOREF_PV(fFlags);
 
     while (cbSymTab > 0 && RT_SUCCESS(rc))
@@ -827 +830 @@
 static int rtDbgModCvSsProcessV8SrcStrings(PRTDBGMODCV pThis, void const *pvSrcStrings, size_t cbSrcStrings, uint32_t fFlags)
 {
+    RT_NOREF_PV(fFlags);
+
     if (pThis->cbSrcStrings)
         Log(("\n!!More than one source file string table for this module!!\n\n"));
@@ -872 +877 @@
 static int rtDbgModCvSsProcessV8SrcInfo(PRTDBGMODCV pThis, void const *pvSrcInfo, size_t cbSrcInfo, uint32_t fFlags)
 {
+    RT_NOREF_PV(fFlags);
+
     if (pThis->cbSrcInfo)
         Log(("\n!!More than one source file info table for this module!!\n\n"));
@@ -903 +910 @@
 static int rtDbgModCvSsProcessV8SectLines(PRTDBGMODCV pThis, void const *pvSectLines, size_t cbSectLines, uint32_t fFlags)
 {
+    RT_NOREF_PV(fFlags);
+
     /*
      * Starts with header.
@@ -1098 +1107 @@
 {
     PCRTCVGLOBALSYMTABHDR pHdr = (PCRTCVGLOBALSYMTABHDR)pvSubSect;
+    RT_NOREF_PV(pDirEnt);
 
     /*
@@ -1124 +1134 @@
 rtDbgModCvSs_Module(PRTDBGMODCV pThis, void const *pvSubSect, size_t cbSubSect, PCRTCVDIRENT32 pDirEnt)
 {
+    RT_NOREF_PV(pDirEnt);
+
     RTCPTRUNION uCursor;
     uCursor.pv = pvSubSect;
@@ -1162 +1174 @@
 rtDbgModCvSs_Symbols_PublicSym_AlignSym(PRTDBGMODCV pThis, void const *pvSubSect, size_t cbSubSect, PCRTCVDIRENT32 pDirEnt)
 {
+    RT_NOREF_PV(pDirEnt);
     RTDBGMODCV_CHECK_NOMSG_RET_BF(pThis->uCurStyle == RT_MAKE_U16('C', 'V'));
     RTDBGMODCV_CHECK_NOMSG_RET_BF(cbSubSect >= 8);
@@ -1180 +1193 @@
 rtDbgModCvSs_SrcModule(PRTDBGMODCV pThis, void const *pvSubSect, size_t cbSubSect, PCRTCVDIRENT32 pDirEnt)
 {
+    RT_NOREF_PV(pDirEnt);
     Log(("rtDbgModCvSs_SrcModule: uCurStyle=%#x\n%.*Rhxd\n", pThis->uCurStyle, cbSubSect, pvSubSect));
 
@@ -1660 +1674 @@
     if (pEntry1->uSubSectType > pEntry2->uSubSectType)
         return 1;
+
+    RT_NOREF_PV(pvUser);
     return 0;
 }
@@ -2110 +2126 @@
                                          PCIMAGE_LINENUMBER paLines, uint32_t cLines)
 {
+    RT_NOREF_PV(iSection);
     Log4(("Adding %u line numbers in section #%u  for %s\n", cLines, iSection, pszFile));
     PCIMAGE_LINENUMBER pCur = paLines;
@@ -2439 +2456 @@
 {
     PRTDBGMODCV pThis = (PRTDBGMODCV)pMod->pvDbgPriv;
-    Assert(!pszSymbol[cchSymbol]);
+    Assert(!pszSymbol[cchSymbol]); RT_NOREF_PV(cchSymbol);
     return RTDbgModSymbolByName(pThis->hCnt, pszSymbol/*, cchSymbol*/, pSymInfo);
 }
@@ -2572 +2589 @@
 static int rtDbgModCvAddSegmentsFromDbg(PRTDBGMODCV pThis, PCIMAGE_SEPARATE_DEBUG_HEADER pDbgHdr, const char *pszFilename)
 {
+    RT_NOREF_PV(pszFilename);
+
     /*
      * Validate the header fields a little.
@@ -2741 +2760 @@
                                uint32_t off, uint32_t cb, const char *pszFilename)
 {
+    RT_NOREF_PV(pszFilename);
+
     /*
      * Check that there is sufficient data for a header, then read it.
@@ -2834 +2855 @@
 {
     int rc = VERR_DBG_NO_MATCHING_INTERPRETER;
+    RT_NOREF_PV(enmArch); RT_NOREF_PV(pszFilename);
 
     /* Is a codeview format we (wish to) support? */
@@ -2878 +2900 @@
     PRTDBGMODINT pDbgMod = (PRTDBGMODINT)pvUser;
     Assert(!pDbgMod->pvDbgPriv);
+    RT_NOREF_PV(hLdrMod);
 
     /* Skip external files, RTDbgMod will deal with those

trunk/src/VBox/Runtime/common/dbg/dbgmoddwarf.cpp

@@ -3530 +3530 @@
 static int rtDwarfLoc_Evaluate(PRTDWARFLOCST pLoc, void *pvLater, void *pvUser)
 {
+    RT_NOREF_PV(pvLater); RT_NOREF_PV(pvUser);
+
     while (!rtDwarfCursor_IsAtEndOfUnit(&pLoc->Cursor))
     {
@@ -4424 +4426 @@
 {
     PRTDBGMODDWARF pThis = (PRTDBGMODDWARF)pvUser;
-    NOREF(hLdrMod);
+    RT_NOREF_PV(hLdrMod); RT_NOREF_PV(uSymbol);
     Assert(pThis->iWatcomPass != 1);
 
@@ -4556 +4558 @@
 {
     PRTDBGMODDWARF pThis = (PRTDBGMODDWARF)pMod->pvDbgPriv;
-    Assert(!pszSymbol[cchSymbol]);
+    Assert(!pszSymbol[cchSymbol]); RT_NOREF_PV(cchSymbol);
     return RTDbgModSymbolByName(pThis->hCnt, pszSymbol/*, cchSymbol*/, pSymInfo);
 }
@@ -4670 +4672 @@
 static DECLCALLBACK(int) rtDbgModDwarfEnumCallback(RTLDRMOD hLdrMod, PCRTLDRDBGINFO pDbgInfo, void *pvUser)
 {
+    RT_NOREF_PV(hLdrMod);
+
     /*
      * Skip stuff we can't handle.

trunk/src/VBox/Runtime/common/dbg/dbgmodldr.cpp

@@ -89 +89 @@
 {
     PRTDBGMODLDR pThis = (PRTDBGMODLDR)pMod->pvImgPriv;
+    RT_NOREF_PV(iDbgInfoHint);
     return rtLdrReadAt(pThis->hLdrMod, pvBuf, UINT32_MAX /** @todo iDbgInfo*/, off, cb);
 }