Changeset 6260 in vbox for trunk/src/VBox/Devices/VMMDev

Timestamp:

Jan 7, 2008 11:30:01 AM (17 years ago)

Author:

vboxsync

Message:

VMMDev: changed IRQ logging from #ifdef DEBUG_sunlover to Log3, as it is potentially interesting for other people as well :)

File:

• trunk/src/VBox/Devices/VMMDev/VBoxDev.cpp (modified) (8 diffs)

trunk/src/VBox/Devices/VMMDev/VBoxDev.cpp

@@ -19 +19 @@
 /* #define LOG_ENABLED */
 
+/* Enable dev_vmm Log3 statements to get IRQ-related logging. */
+
 #include <stdio.h>
 #include <string.h>
@@ -152 +154 @@
     PPDMDEVINS pDevIns = VMMDEVSTATE_2_DEVINS (pVMMDevState);
 
-#ifdef DEBUG_sunlover
-    Log(("vmmdevMaybeSetIRQ_EMT: u32HostEventFlags = 0x%08X, u32GuestFilterMask = 0x%08X.\n",
+    Log3(("vmmdevMaybeSetIRQ_EMT: u32HostEventFlags = 0x%08X, u32GuestFilterMask = 0x%08X.\n",
           pVMMDevState->u32HostEventFlags, pVMMDevState->u32GuestFilterMask));
-#endif /* DEBUG_sunlover */
 
     if (pVMMDevState->u32HostEventFlags & pVMMDevState->u32GuestFilterMask)
@@ -161 +161 @@
         pVMMDevState->pVMMDevRAMHC->V.V1_04.fHaveEvents = true;
         PDMDevHlpPCISetIrqNoWait (pDevIns, 0, 1);
-#ifdef DEBUG_sunlover
-        Log(("vmmdevMaybeSetIRQ_EMT: IRQ set.\n"));
-#endif /* DEBUG_sunlover */
+        Log3(("vmmdevMaybeSetIRQ_EMT: IRQ set.\n"));
     }
 }
@@ -169 +167 @@
 static void vmmdevNotifyGuest_EMT (VMMDevState *pVMMDevState, uint32_t u32EventMask)
 {
-#ifdef DEBUG_sunlover
-    Log(("VMMDevNotifyGuest_EMT: u32EventMask = 0x%08X.\n", u32EventMask));
-#endif /* DEBUG_sunlover */
+    Log3(("VMMDevNotifyGuest_EMT: u32EventMask = 0x%08X.\n", u32EventMask));
 
     if (VBOX_GUEST_ADDITIONS_VERSION_1_03 (pVMMDevState))
     {
-#ifdef DEBUG_sunlover
-        Log(("VMMDevNotifyGuest_EMT: Old additions detected.\n"));
-#endif /* DEBUG_sunlover */
+        Log3(("VMMDevNotifyGuest_EMT: Old additions detected.\n"));
 
         pVMMDevState->u32HostEventFlags |= u32EventMask;
@@ -184 +178 @@
     else
     {
-#ifdef DEBUG_sunlover
-        Log(("VMMDevNotifyGuest_EMT: New additions detected.\n"));
-#endif /* DEBUG_sunlover */
+        Log3(("VMMDevNotifyGuest_EMT: New additions detected.\n"));
 
         if (!pVMMDevState->fu32AdditionsOk)
@@ -198 +190 @@
             (pVMMDevState->u32HostEventFlags & pVMMDevState->u32GuestFilterMask) != 0;
 
-#ifdef DEBUG_sunlover
-        Log(("VMMDevNotifyGuest_EMT: fHadEvents = %d, u32HostEventFlags = 0x%08X, u32GuestFilterMask = 0x%08X.\n",
+        Log3(("VMMDevNotifyGuest_EMT: fHadEvents = %d, u32HostEventFlags = 0x%08X, u32GuestFilterMask = 0x%08X.\n",
               fHadEvents, pVMMDevState->u32HostEventFlags, pVMMDevState->u32GuestFilterMask));
-#endif /* DEBUG_sunlover */
 
         pVMMDevState->u32HostEventFlags |= u32EventMask;
@@ -268 +258 @@
     PVMREQ pReq;
 
-#ifdef DEBUG_sunlover
-    Log(("VMMDevNotifyGuest: u32EventMask = 0x%08X.\n", u32EventMask));
-#endif /* DEBUG_sunlover */
+    Log3(("VMMDevNotifyGuest: u32EventMask = 0x%08X.\n", u32EventMask));
 
     rc = VMR3ReqCallVoid (pVM, &pReq, RT_INDEFINITE_WAIT,
@@ -1792 +1780 @@
     }
 
-#ifdef DEBUG_sunlover
-    Log(("vmmdevRequestDisplayChange: same=%d. new: xres=%d, yres=%d, bpp=%d, display=%d. old: xres=%d, yres=%d, bpp=%d, display=%d.\n",
+    Log3(("vmmdevRequestDisplayChange: same=%d. new: xres=%d, yres=%d, bpp=%d, display=%d. old: xres=%d, yres=%d, bpp=%d, display=%d.\n",
           fSameResolution, xres, yres, bpp, display, pData->lastReadDisplayChangeRequest.xres, pData->lastReadDisplayChangeRequest.yres, pData->lastReadDisplayChangeRequest.bpp, pData->lastReadDisplayChangeRequest.display));
-#endif /* DEBUG_sunlover */
 
     if (!fSameResolution)