Changeset 62618 in vbox for trunk/src

Timestamp:

Jul 28, 2016 11:23:36 AM (8 years ago)

Author:

vboxsync

Message:

Devices: unused parameter warnings.

Location:

trunk/src/VBox/Devices

Files:

• Graphics/DevVGA-SVGA.cpp (modified) (4 diffs)
• Network/DevE1000Phy.cpp (modified) (5 diffs)
• Network/DevVirtioNet.cpp (modified) (4 diffs)
• Parallel/DrvHostParallel.cpp (modified) (7 diffs)
• Storage/DevBusLogic.cpp (modified) (3 diffs)
• Storage/DevLsiLogicSCSI.cpp (modified) (6 diffs)
• VirtIO/Virtio.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA.cpp

@@ -1486 +1486 @@
 {
     PVGASTATE   pThis = PDMINS_2_DATA(pDevIns, PVGASTATE);
-    int rc = VINF_SUCCESS;
+    RT_NOREF_PV(pvUser);
 
     /* Ignore non-dword accesses. */
@@ -1515 +1515 @@
         break;
     }
-    return rc;
+
+    return VINF_SUCCESS;
 }
 
@@ -1532 +1533 @@
 {
     PVGASTATE   pThis = PDMINS_2_DATA(pDevIns, PVGASTATE);
-    int rc = VINF_SUCCESS;
+    RT_NOREF_PV(pvUser);
 
     /* Ignore non-dword accesses. */
@@ -1565 +1566 @@
         break;
     }
-    return rc;
+    return VINF_SUCCESS;
 }
 

trunk/src/VBox/Devices/Network/DevE1000Phy.cpp

@@ -174 +174 @@
 static void Phy::regWriteForbidden(PPHY pPhy, uint32_t index, uint16_t u16Value)
 {
+    RT_NOREF_PV(pPhy); RT_NOREF_PV(index); RT_NOREF_PV(u16Value);
     PhyLog(("PHY#%d At %02d write attempted to read-only '%s'\n",
             pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].pszName));
@@ -189 +190 @@
 static uint16_t Phy::regReadUnimplemented(PPHY pPhy, uint32_t index)
 {
+    RT_NOREF_PV(pPhy); RT_NOREF_PV(index);
     PhyLog(("PHY#%d At %02d read attempted from unimplemented '%s'\n",
             pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].pszName));
@@ -204 +206 @@
 static void Phy::regWriteUnimplemented(PPHY pPhy, uint32_t index, uint16_t u16Value)
 {
+    RT_NOREF_PV(pPhy); RT_NOREF_PV(index); RT_NOREF_PV(u16Value);
     PhyLog(("PHY#%d At %02d write attempted to unimplemented '%s'\n",
             pPhy->iInstance, s_regMap[index].u32Address, s_regMap[index].pszName));
@@ -441 +444 @@
 static uint16_t Phy::regReadPSTATUS(PPHY pPhy, uint32_t index)
 {
+    RT_NOREF_PV(pPhy); RT_NOREF_PV(index);
+
     /* Read latched value */
     uint16_t u16 = REG(PSTATUS);
@@ -459 +464 @@
 static uint16_t Phy::regReadGSTATUS(PPHY pPhy, uint32_t index)
 {
+    RT_NOREF_PV(pPhy); RT_NOREF_PV(index);
+
     /*
      * - Link partner is capable of 1000BASE-T half duplex

trunk/src/VBox/Devices/Network/DevVirtioNet.cpp

@@ -292 +292 @@
 DECLINLINE(int) vnetCsRxEnter(PVNETSTATE pThis, int rcBusy)
 {
+    RT_NOREF_PV(pThis);
+    RT_NOREF_PV(rcBusy);
     // STAM_PROFILE_START(&pThis->CTXSUFF(StatCsRx), a);
     // int rc = PDMCritSectEnter(&pThis->csRx, rcBusy);
@@ -301 +303 @@
 DECLINLINE(void) vnetCsRxLeave(PVNETSTATE pThis)
 {
+    RT_NOREF_PV(pThis);
     // PDMCritSectLeave(&pThis->csRx);
 }
@@ -367 +370 @@
 static DECLCALLBACK(uint32_t) vnetIoCb_GetHostFeatures(void *pvState)
 {
+    RT_NOREF_PV(pvState);
+
     /* We support:
      * - Host-provided MAC address
@@ -398 +403 @@
 static DECLCALLBACK(uint32_t) vnetIoCb_GetHostMinimalFeatures(void *pvState)
 {
+    RT_NOREF_PV(pvState);
     return VNET_F_MAC;
 }

trunk/src/VBox/Devices/Parallel/DrvHostParallel.cpp

@@ -172 +172 @@
 /**
  * R0 mode function to write byte value to data port.
+ *
  * @returns VBox status code.
  * @param   pDrvIns    Driver instance.
@@ -186 +187 @@
 
 /**
- * R0 mode function to write byte value to parallel port control
- * register.
+ * R0 mode function to write byte value to parallel port control register.
+ *
  * @returns VBox status code.
  * @param   pDrvIns     Driver instance.
@@ -201 +202 @@
 
 /**
- * R0 mode function to ready byte value from the parallel port
- * data register
+ * R0 mode function to ready byte value from the parallel port data register.
+ *
  * @returns VBox status code.
  * @param   pDrvIns    Driver instance.
- * @param   u64Arg     Not used.
- */
-static int drvR0HostParallelReqRead(PPDMDRVINS pDrvIns, uint64_t u64Arg)
-{
-    uint8_t u8Data;
+ */
+static int drvR0HostParallelReqRead(PPDMDRVINS pDrvIns)
+{
     PDRVHOSTPARALLEL pThis = PDMINS_2_DATA(pDrvIns, PDRVHOSTPARALLEL);
-    u8Data = ASMInU8(pThis->u32LptAddr);
+    uint8_t u8Data = ASMInU8(pThis->u32LptAddr);
     LogFlowFunc(("read from data port=%#x val=%#x\n", pThis->u32LptAddr, u8Data));
     pThis->u8ReadIn = u8Data;
@@ -218 +217 @@
 
 /**
- * R0 mode function to ready byte value from the parallel port
- * control register.
+ * R0 mode function to ready byte value from the parallel port control register.
+ *
  * @returns VBox status code.
  * @param   pDrvIns    Driver instance.
- * @param   u64Arg     Not used.
- */
-static int drvR0HostParallelReqReadControl(PPDMDRVINS pDrvIns, uint64_t u64Arg)
-{
-    uint8_t u8Data;
+ */
+static int drvR0HostParallelReqReadControl(PPDMDRVINS pDrvIns)
+{
     PDRVHOSTPARALLEL pThis = PDMINS_2_DATA(pDrvIns, PDRVHOSTPARALLEL);
-    u8Data = ASMInU8(pThis->u32LptAddrControl);
+    uint8_t u8Data = ASMInU8(pThis->u32LptAddrControl);
     LogFlowFunc(("read from ctrl port=%#x val=%#x\n", pThis->u32LptAddr, u8Data));
     pThis->u8ReadInControl = u8Data;
@@ -235 +232 @@
 
 /**
- * R0 mode function to ready byte value from the parallel port
- * status register.
+ * R0 mode function to ready byte value from the parallel port status register.
+ *
  * @returns VBox status code.
  * @param   pDrvIns    Driver instance.
- * @param   u64Arg     Not used.
- */
-static int drvR0HostParallelReqReadStatus(PPDMDRVINS pDrvIns, uint64_t u64Arg)
-{
-    uint8_t u8Data;
+ */
+static int drvR0HostParallelReqReadStatus(PPDMDRVINS pDrvIns)
+{
     PDRVHOSTPARALLEL pThis = PDMINS_2_DATA(pDrvIns, PDRVHOSTPARALLEL);
-    u8Data = ASMInU8(pThis->u32LptAddrStatus);
+    uint8_t u8Data = ASMInU8(pThis->u32LptAddrStatus);
     LogFlowFunc(("read from status port=%#x val=%#x\n", pThis->u32LptAddr, u8Data));
     pThis->u8ReadInStatus = u8Data;
@@ -254 +249 @@
  * R0 mode function to set the direction of parallel port -
  * operate in bidirectional mode or single direction.
+ *
  * @returns VBox status code.
  * @param   pDrvIns    Driver instance.
@@ -291 +287 @@
     {
         case DRVHOSTPARALLELR0OP_READ:
-            rc = drvR0HostParallelReqRead(pDrvIns, u64Arg);
+            rc = drvR0HostParallelReqRead(pDrvIns);
             break;
         case DRVHOSTPARALLELR0OP_READSTATUS:
-            rc = drvR0HostParallelReqReadStatus(pDrvIns, u64Arg);
+            rc = drvR0HostParallelReqReadStatus(pDrvIns);
             break;
         case DRVHOSTPARALLELR0OP_READCONTROL:
-            rc = drvR0HostParallelReqReadControl(pDrvIns, u64Arg);
+            rc = drvR0HostParallelReqReadControl(pDrvIns);
             break;
         case DRVHOSTPARALLELR0OP_WRITE:

trunk/src/VBox/Devices/Storage/DevBusLogic.cpp

@@ -2408 +2408 @@
 PDMBOTHCBDECL(int) buslogicMMIORead(PPDMDEVINS pDevIns, void *pvUser, RTGCPHYS GCPhysAddr, void *pv, unsigned cb)
 {
+    RT_NOREF_PV(pDevIns); RT_NOREF_PV(pvUser); RT_NOREF_PV(GCPhysAddr); RT_NOREF_PV(pv); RT_NOREF_PV(cb);
+
     /* the linux driver does not make use of the MMIO area. */
     AssertMsgFailed(("MMIO Read\n"));
@@ -2426 +2428 @@
 PDMBOTHCBDECL(int) buslogicMMIOWrite(PPDMDEVINS pDevIns, void *pvUser, RTGCPHYS GCPhysAddr, void const *pv, unsigned cb)
 {
+    RT_NOREF_PV(pDevIns); RT_NOREF_PV(pvUser); RT_NOREF_PV(GCPhysAddr); RT_NOREF_PV(pv); RT_NOREF_PV(cb);
+
     /* the linux driver does not make use of the MMIO area. */
     AssertMsgFailed(("MMIO Write\n"));
@@ -2446 +2450 @@
     PBUSLOGIC pBusLogic = PDMINS_2_DATA(pDevIns, PBUSLOGIC);
     unsigned iRegister = Port % 4;
+    RT_NOREF_PV(pvUser); RT_NOREF_PV(cb);
 
     Assert(cb == 1);

trunk/src/VBox/Devices/Storage/DevLsiLogicSCSI.cpp

@@ -1688 +1688 @@
     uint32_t        offReg = Port - pThis->IOPortBase;
     int             rc;
+    RT_NOREF_PV(pvUser);
 
     if (!(offReg & 3))
@@ -1711 +1712 @@
     PLSILOGICSCSI   pThis   = PDMINS_2_DATA(pDevIns, PLSILOGICSCSI);
     uint32_t        offReg  = Port - pThis->IOPortBase;
+    RT_NOREF_PV(pvUser);
+    RT_NOREF_PV(cb);
 
     int rc = lsilogicRegisterRead(pThis, offReg & ~(uint32_t)3, pu32);
@@ -1728 +1731 @@
     uint32_t        u32;
     int             rc;
+    RT_NOREF_PV(pvUser);
 
     /* See comments in lsilogicR3Map regarding size and alignment. */
@@ -1761 +1765 @@
     uint32_t        offReg = GCPhysAddr - pThis->GCPhysMMIOBase;
     Assert(!(offReg & 3)); Assert(cb == 4);
+    RT_NOREF_PV(pvUser);
 
     return lsilogicRegisterRead(pThis, offReg, (uint32_t *)pv);
@@ -1773 +1778 @@
 #endif
 
+    RT_NOREF_PV(pDevIns); RT_NOREF_PV(pvUser); RT_NOREF_PV(GCPhysAddr); RT_NOREF_PV(pv); RT_NOREF_PV(cb);
     return VINF_SUCCESS;
 }
@@ -1784 +1790 @@
 #endif
 
+    RT_NOREF_PV(pDevIns); RT_NOREF_PV(pvUser); RT_NOREF_PV(GCPhysAddr); RT_NOREF_PV(pv); RT_NOREF_PV(cb);
     return VINF_SUCCESS;
 }

trunk/src/VBox/Devices/VirtIO/Virtio.cpp

@@ -272 +272 @@
 int vpciRaiseInterrupt(VPCISTATE *pState, int rcBusy, uint8_t u8IntCause)
 {
+    RT_NOREF_PV(rcBusy);
     // int rc = vpciCsEnter(pState, rcBusy);
     // if (RT_UNLIKELY(rc != VINF_SUCCESS))
@@ -327 +328 @@
     int         rc     = VINF_SUCCESS;
     STAM_PROFILE_ADV_START(&pState->CTXSUFF(StatIORead), a);
+    RT_NOREF_PV(pvUser);
 
     /*
@@ -425 +427 @@
     bool        fHasBecomeReady;
     STAM_PROFILE_ADV_START(&pState->CTXSUFF(StatIOWrite), a);
+    RT_NOREF_PV(pvUser);
 
     Port -= pState->IOPortBase;