VirtualBox

Changeset 62637 in vbox for trunk/src


Ignore:
Timestamp:
Jul 28, 2016 5:12:17 PM (8 years ago)
Author:
vboxsync
Message:

VMMR3: warnings

Location:
trunk/src/VBox/VMM
Files:
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/VBox/VMM/VMMAll/IEMAll.cpp

    r62603 r62637  
    77827782#ifdef IN_RING3
    77837783    Assert(!fPostponeFail);
     7784    RT_NOREF_PV(fPostponeFail);
    77847785#endif
    77857786
    … …  
    1140911410        else \
    1141011411        { \
    11411             DBGFSTOP(pVCpu->CTX_SUFF(pVM)); \
     11412            (void)DBGFSTOP(pVCpu->CTX_SUFF(pVM)); \
    1141211413            return IEMOP_RAISE_INVALID_OPCODE(); \
    1141311414        } \

  • trunk/src/VBox/VMM/VMMR3/CPUM.cpp

    r62478 r62637  
    23342334 *
    23352335 */
    2336 VMMR3DECL(int) CPUMR3DisasmInstrCPU(PVM pVM, PVMCPU pVCpu, PCPUMCTX pCtx, RTGCPTR GCPtrPC, PDISCPUSTATE pCpu, const char *pszPrefix)
     2336VMMR3DECL(int) CPUMR3DisasmInstrCPU(PVM pVM, PVMCPU pVCpu, PCPUMCTX pCtx, RTGCPTR GCPtrPC, PDISCPUSTATE pCpu,
     2337                                    const char *pszPrefix)
    23372338{
    23382339    CPUMDISASSTATE  State;
    … …  
    23872388    uint32_t cbInstr;
    23882389#ifndef LOG_ENABLED
     2390    RT_NOREF_PV(pszPrefix);
    23892391    rc = DISInstrWithReader(GCPtrPC, enmDisCpuMode, cpumR3DisasInstrRead, &State, pCpu, &cbInstr);
    23902392    if (RT_SUCCESS(rc))
    … …  
    24872489    Assert(!pVCpu->cpum.s.fRawEntered);
    24882490    Assert(pVCpu->cpum.s.fRemEntered);
     2491
     2492    RT_NOREF_PV(fNoOutOfSyncSels);
    24892493
    24902494    pVCpu->cpum.s.fRemEntered = false;

  • trunk/src/VBox/VMM/VMMR3/CPUMDbg.cpp

    r62478 r62637  
    310310static DECLCALLBACK(int) cpumR3RegGet_Dummy(void *pvUser, PCDBGFREGDESC pDesc, PDBGFREGVAL pValue)
    311311{
     312    RT_NOREF_PV(pvUser);
    312313    switch (pDesc->enmType)
    313314    {

  • trunk/src/VBox/VMM/VMMR3/CPUMR3CpuId.cpp

    r62591 r62637  
    20192019}
    20202020
    2021 /**
    2022  * Init a set of host CPUID leaves.
    2023  *
    2024  * @returns VBox status code.
    2025  * @param   paLeaves            The leaf array.
    2026  * @param   cLeaves             The number of leaves.
    2027  * @param   uStart              The start leaf number.
    2028  * @param   pCfgNode            The /CPUM/HostCPUID/ node.
    2029  */
    2030 static int cpumR3CpuIdInitHostSet(uint32_t uStart, PCPUMCPUID paLeaves, uint32_t cLeaves, PCFGMNODE pCfgNode)
    2031 {
    2032     /* Using the ECX variant for all of them can't hurt... */
    2033     for (uint32_t i = 0; i < cLeaves; i++)
    2034         ASMCpuIdExSlow(uStart + i, 0, 0, 0, &paLeaves[i].uEax, &paLeaves[i].uEbx, &paLeaves[i].uEcx, &paLeaves[i].uEdx);
    2035 
    2036     /* Load CPUID leaf override; we currently don't care if the user
    2037        specifies features the host CPU doesn't support. */
    2038     return cpumR3CpuIdInitLoadOverrideSet(uStart, paLeaves, cLeaves, pCfgNode);
    2039 }
    2040 
    20412021
    20422022/**
    … …  
    59955975 *
    59965976 * @param   pHlp        The info helper functions.
    5997  * @param   paLeaves    The CPUID leaves array.
    5998  * @param   cLeaves     The number of leaves in the array.
    59995977 * @param   pCurLeaf    The 0x00000001 leaf.
    60005978 * @param   fVerbose    Whether to be very verbose or not.
    60015979 * @param   fIntel      Set if intel CPU.
    60025980 */
    6003 static void cpumR3CpuIdInfoStdLeaf1Details(PCDBGFINFOHLP pHlp, PCCPUMCPUIDLEAF paLeaves, uint32_t cLeaves,
    6004                                            PCCPUMCPUIDLEAF pCurLeaf, bool fVerbose, bool fIntel)
     5981static void cpumR3CpuIdInfoStdLeaf1Details(PCDBGFINFOHLP pHlp, PCCPUMCPUIDLEAF pCurLeaf, bool fVerbose, bool fIntel)
    60055982{
    60065983    Assert(pCurLeaf); Assert(pCurLeaf->uLeaf == 1);
    … …  
    61126089                                            PCCPUMCPUIDLEAF pCurLeaf, bool fVerbose)
    61136090{
     6091    RT_NOREF_PV(fVerbose);
    61146092    Assert(pCurLeaf); Assert(pCurLeaf->uLeaf == 13);
    61156093    pHlp->pfnPrintf(pHlp, "Processor Extended State Enumeration (leaf 0xd):\n");
    … …  
    63206298
    63216299    if (iVerbosity && (pCurLeaf = cpumR3CpuIdGetLeaf(paLeaves, cLeaves, UINT32_C(0x00000001), 0)) != NULL)
    6322         cpumR3CpuIdInfoStdLeaf1Details(pHlp, paLeaves, cLeaves, pCurLeaf, iVerbosity > 1, fIntel);
     6300        cpumR3CpuIdInfoStdLeaf1Details(pHlp, pCurLeaf, iVerbosity > 1, fIntel);
    63236301
    63246302    if (iVerbosity && (pCurLeaf = cpumR3CpuIdGetLeaf(paLeaves, cLeaves, UINT32_C(0x00000007), 0)) != NULL)
    … …  
    67296707VMMR3_INT_DECL(uint32_t) CPUMR3GetGuestCpuIdPatmStdMax(PVM pVM)
    67306708{
     6709    RT_NOREF_PV(pVM);
    67316710    return RT_ELEMENTS(pVM->cpum.s.aGuestCpuIdPatmStd);
    67326711}
    … …  
    67426721VMMR3_INT_DECL(uint32_t) CPUMR3GetGuestCpuIdPatmExtMax(PVM pVM)
    67436722{
     6723    RT_NOREF_PV(pVM);
    67446724    return RT_ELEMENTS(pVM->cpum.s.aGuestCpuIdPatmExt);
    67456725}
    … …  
    67556735VMMR3_INT_DECL(uint32_t) CPUMR3GetGuestCpuIdPatmCentaurMax(PVM pVM)
    67566736{
     6737    RT_NOREF_PV(pVM);
    67576738    return RT_ELEMENTS(pVM->cpum.s.aGuestCpuIdPatmCentaur);
    67586739}

  • trunk/src/VBox/VMM/VMMR3/DBGFAddrSpace.cpp

    r62478 r62637  
    9292} DBGFR3ASLOADOPENDATA;
    9393
     94#if 0 /* unused */
    9495/**
    9596 * Callback for dbgfR3AsSearchPath and dbgfR3AsSearchEnvPath.
    … …  
    102103/** Pointer to a FNDBGFR3ASSEARCHOPEN. */
    103104typedef FNDBGFR3ASSEARCHOPEN *PFNDBGFR3ASSEARCHOPEN;
     105#endif
    104106
    105107
    … …  
    792794}
    793795
     796#if 0 /* unused */
    794797
    795798/**
    … …  
    931934}
    932935
     936#endif /* unused */
     937
    933938
    934939/**
    … …  
    11441149
    11451150
    1146 /** Temporary symbol conversion function. */
    1147 static void dbgfR3AsSymbolConvert(PRTDBGSYMBOL pSymbol, PCDBGFSYMBOL pDbgfSym)
    1148 {
    1149     pSymbol->offSeg = pSymbol->Value = pDbgfSym->Value;
    1150     pSymbol->cb = pDbgfSym->cb;
    1151     pSymbol->iSeg = 0;
    1152     pSymbol->fFlags = 0;
    1153     pSymbol->iOrdinal = UINT32_MAX;
    1154     strcpy(pSymbol->szName, pDbgfSym->szName);
    1155 }
    1156 
    1157 
    11581151/**
    11591152 * Query a symbol by address.

  • trunk/src/VBox/VMM/VMMR3/DBGFBp.cpp

    r62478 r62637  
    343343    AssertMsgReturn(!piBp || VALID_PTR(piBp), ("piBp=%p\n", piBp), VERR_INVALID_POINTER);
    344344    if (piBp)
    345         *piBp = ~0;
     345        *piBp = UINT32_MAX;
    346346
    347347    /*
    … …  
    505505    AssertMsgReturn(!piBp || VALID_PTR(piBp), ("piBp=%p\n", piBp), VERR_INVALID_POINTER);
    506506    if (piBp)
    507         *piBp = ~0;
     507        *piBp = UINT32_MAX;
    508508    switch (fType)
    509509    {
    … …  
    653653static int dbgfR3BpRegArm(PVM pVM, PDBGFBP pBp)
    654654{
     655    RT_NOREF_PV(pBp);
    655656    Assert(pBp->fEnabled);
    656657    return VMMR3EmtRendezvous(pVM, VMMEMTRENDEZVOUS_FLAGS_TYPE_ALL_AT_ONCE, dbgfR3BpRegRecalcOnCpu, NULL);
    … …  
    670671static int dbgfR3BpRegDisarm(PVM pVM, PDBGFBP pBp)
    671672{
     673    RT_NOREF_PV(pBp);
    672674    Assert(!pBp->fEnabled);
    673675    return VMMR3EmtRendezvous(pVM, VMMEMTRENDEZVOUS_FLAGS_TYPE_ALL_AT_ONCE, dbgfR3BpRegRecalcOnCpu, NULL);
    … …  
    703705    AssertMsgReturn(!piBp || VALID_PTR(piBp), ("piBp=%p\n", piBp), VERR_INVALID_POINTER);
    704706    if (piBp)
    705         *piBp = ~0;
    706 
     707        *piBp = UINT32_MAX;
    707708
    708709    /*
    … …  
    834835    PVM pVM = pUVM->pVM;
    835836    VM_ASSERT_VALID_EXT_RETURN(pVM, VERR_INVALID_VM_HANDLE);
    836     *piBp = ~0;
     837    *piBp = UINT32_MAX;
    837838
    838839    /*
    … …  
    907908     * This must be done on EMT.
    908909     */
    909     uint32_t iBp = -1;
     910    uint32_t iBp = UINT32_MAX;
    910911    int rc = VMR3ReqCallWaitU(pUVM, 0 /*idDstCpu*/, (PFNRT)dbgfR3BpSetPortIo, 7,
    911912                              pUVM, uPort, cPorts, fAccess, &iHitTrigger, &iHitDisable, piBp);
    … …  
    942943    PVM pVM = pUVM->pVM;
    943944    VM_ASSERT_VALID_EXT_RETURN(pVM, VERR_INVALID_VM_HANDLE);
    944     *piBp = ~0;
     945    *piBp = UINT32_MAX;
    945946
    946947    /*
    … …  
    10151016     * This must be done on EMT.
    10161017     */
    1017     uint32_t iBp = -1;
     1018    uint32_t iBp = UINT32_MAX;
    10181019    int rc = VMR3ReqCallWaitU(pUVM, 0 /*idDstCpu*/, (PFNRT)dbgfR3BpSetMmio, 7,
    10191020                              pUVM, &GCPhys, cb, fAccess, &iHitTrigger, &iHitDisable, piBp);

  • trunk/src/VBox/VMM/VMMR3/DBGFDisas.cpp

    r62478 r62637  
    494494        SelInfo.SelGate                 = 0;
    495495        SelInfo.GCPtrBase               = 0;
    496         SelInfo.cbLimit                 = ~0;
     496        SelInfo.cbLimit                 = ~(RTGCUINTPTR)0;
    497497        SelInfo.fFlags                  = PGMMODE_IS_LONG_MODE(enmMode)
    498498                                        ? DBGFSELINFO_FLAGS_LONG_MODE
    … …  
    536536        SelInfo.SelGate                 = 0;
    537537        SelInfo.GCPtrBase               = Sel * 16;
    538         SelInfo.cbLimit                 = ~0;
     538        SelInfo.cbLimit                 = ~(RTGCUINTPTR)0;
    539539        SelInfo.fFlags                  = DBGFSELINFO_FLAGS_REAL_MODE;
    540540        SelInfo.u.Raw.au32[0]           = 0;

  • trunk/src/VBox/VMM/VMMR3/DBGFOS.cpp

    r62478 r62637  
    9393int dbgfR3OSInit(PUVM pUVM)
    9494{
     95    RT_NOREF_PV(pVM);
    9596    return VINF_SUCCESS;
    9697}

  • trunk/src/VBox/VMM/VMMR3/DBGFR3PlugIn.cpp

    r62478 r62637  
    602602{
    603603    PDBGFPLUGIN pPlugIn = pVM->pUVM->dbgf.s.pPlugInHead;
     604    RT_NOREF_PV(pszArgs);
    604605    if (pPlugIn)
    605606    {

  • trunk/src/VBox/VMM/VMMR3/DBGFR3Type.cpp

    r62460 r62637  
    11311131    AssertPtrReturn(pszType, VERR_INVALID_POINTER);
    11321132    AssertPtrReturn(pfnDump, VERR_INVALID_POINTER);
     1133    RT_NOREF_PV(fFlags);
    11331134
    11341135    int rc = VINF_SUCCESS;

  • trunk/src/VBox/VMM/VMMR3/DBGFReg.cpp

    r62478 r62637  
    19151915                                                   PCDBGFREGVAL pValue, PCDBGFREGVAL pMask)
    19161916{
     1917    RT_NOREF_PV(pUVM);
    19171918    PCDBGFREGSUBFIELD pSubField = pLookupRec->pSubField;
    19181919    if (pSubField && pSubField->pfnSet)
    … …  
    20912092                }
    20922093
    2093                 DBGFREGVAL Value3 = Value;
    20942094                RTUInt128AssignAndNFirstBits(&Value.u128, pSubField->cBits);
    20952095                if (rc == VINF_SUCCESS && RTUInt128IsNotEqual(&Value.u128, &Value.u128))

  • trunk/src/VBox/VMM/VMMR3/EMHM.cpp

    r62478 r62637  
    241241    return emR3HmExecuteInstructionWorker(pVM, pVCpu, rcGC, pszPrefix);
    242242#else
     243    RT_NOREF_PV(pszPrefix);
    243244    return emR3HmExecuteInstructionWorker(pVM, pVCpu, rcGC);
    244245#endif

  • trunk/src/VBox/VMM/VMMR3/EMR3Dbg.cpp

    r62478 r62637  
    6969int emR3InitDbg(PVM pVM)
    7070{
     71    RT_NOREF_PV(pVM);
    7172    int rc = VINF_SUCCESS;
    7273#ifdef VBOX_WITH_DEBUGGER

  • trunk/src/VBox/VMM/VMMR3/EMRaw.cpp

    r62478 r62637  
    421421    return emR3RawExecuteInstructionWorker(pVM, pVCpu, rcGC, pszPrefix);
    422422#else
     423    RT_NOREF_PV(pszPrefix);
    423424    return emR3RawExecuteInstructionWorker(pVM, pVCpu, rcGC);
    424425#endif
    … …  
    435436{
    436437    STAM_PROFILE_START(&pVCpu->em.s.StatIOEmu, a);
     438    RT_NOREF_PV(pVM);
    437439
    438440    /* Hand it over to the interpreter. */
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette