Changeset 62642 in vbox for trunk/src

Timestamp:

Jul 28, 2016 9:16:04 PM (8 years ago)

Author:

vboxsync

Message:

gimR3HvInit: Check VendorID length or we'll pick up random stack bits from the stack. Marked confusing RTStNCmp use.

File:

• trunk/src/VBox/VMM/VMMR3/GIMHv.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR3/GIMHv.cpp

@@ -223 +223 @@
     rc = CFGMR3QueryStringDef(pCfgHv, "VendorID", szVendor, sizeof(szVendor), "VBoxVBoxVBox");
     AssertLogRelRCReturn(rc, rc);
+    AssertLogRelMsgReturn(strlen(szVendor) == 12,
+                          ("The VendorID config value must be exactly 12 chars, '%s' isn't!\n", szVendor),
+                          VERR_INVALID_PARAMETER);
 
     LogRel(("GIM: HyperV: Reporting vendor as '%s'\n", szVendor));
+    /** @todo r=bird: GIM_HV_VENDOR_MICROSOFT is 12 char and the string is max
+     *        12+terminator, so the NCmp is a little bit misleading. */
     if (!RTStrNCmp(szVendor, GIM_HV_VENDOR_MICROSOFT, sizeof(GIM_HV_VENDOR_MICROSOFT) - 1))
     {