Changeset 62654 in vbox for trunk

Timestamp:

Jul 28, 2016 10:19:37 PM (8 years ago)

Author:

vboxsync

Message:

VMMR3: warnings

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/CSAMAll.cpp (modified) (1 diff)
• VMMAll/PATMAll.cpp (modified) (2 diffs)
• VMMAll/TMAllCpu.cpp (modified) (1 diff)
• VMMR3/PDMAsyncCompletion.cpp (modified) (4 diffs)
• VMMR3/PDMUsb.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/CSAMAll.cpp

@@ -83 +83 @@
     int rc = PATMR3PatchWrite(pVM, GCPtr, (uint32_t)cbBuf);
     AssertRC(rc);
+    RT_NOREF_PV(pVCpu);
     return VINF_PGM_HANDLER_DO_DEFAULT;
 

trunk/src/VBox/VMM/VMMAll/PATMAll.cpp

@@ -52 +52 @@
     Assert(enmAccessType == PGMACCESSTYPE_WRITE); NOREF(enmAccessType);
     NOREF(pvPtr); NOREF(pvBuf); NOREF(cbBuf); NOREF(enmOrigin); NOREF(pvUser);
+    RT_NOREF_PV(pVCpu);
 
     Assert(pvUser);
@@ -63 +64 @@
 #else
     /* RC: Go handle this in ring-3. */
-    RT_NOREF_PV(pVCpu);
     return VINF_PATM_CHECK_PATCH_PAGE;
 #endif

trunk/src/VBox/VMM/VMMAll/TMAllCpu.cpp

@@ -318 +318 @@
     AssertCompile(TMCLOCK_FREQ_VIRTUAL <= _4G);
 #ifdef IN_RING3
+    RT_NOREF_PV(pVCpu);
     uint64_t uCpuHz = SUPGetCpuHzFromGip(g_pSUPGlobalInfoPage);
 #else

trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletion.cpp

@@ -260 +260 @@
                                              const char *pszDesc)
 {
-    LogFlow(("PDMR3AsyncCompletionTemplateCreateDriver: pDrvIns=%p ppTemplate=%p pfnCompleted=%p pszDesc=%s\n", pDrvIns, ppTemplate, pfnCompleted, pszDesc));
+    LogFlow(("PDMR3AsyncCompletionTemplateCreateDriver: pDrvIns=%p ppTemplate=%p pfnCompleted=%p pszDesc=%s\n",
+             pDrvIns, ppTemplate, pfnCompleted, pszDesc));
+    RT_NOREF_PV(pszDesc); /** @todo async template description */
 
     /*
@@ -346 +348 @@
  * @internal
  */
-VMMR3DECL(int) PDMR3AsyncCompletionTemplateCreateInternal(PVM pVM, PPPDMASYNCCOMPLETIONTEMPLATE ppTemplate, PFNPDMASYNCCOMPLETEINT pfnCompleted, void *pvUser2, const char *pszDesc)
-{
-    LogFlow(("%s: ppTemplate=%p pfnCompleted=%p pvUser2=%p pszDesc=%s\n",
-              __FUNCTION__, ppTemplate, pfnCompleted, pvUser2, pszDesc));
+VMMR3DECL(int) PDMR3AsyncCompletionTemplateCreateInternal(PVM pVM, PPPDMASYNCCOMPLETIONTEMPLATE ppTemplate,
+                                                          PFNPDMASYNCCOMPLETEINT pfnCompleted, void *pvUser2, const char *pszDesc)
+{
+    LogFlow(("PDMR3AsyncCompletionTemplateCreateInternal: ppTemplate=%p pfnCompleted=%p pvUser2=%p pszDesc=%s\n",
+              ppTemplate, pfnCompleted, pvUser2, pszDesc));
+    RT_NOREF_PV(pszDesc); /** @todo async template description */
+
 
     /*
@@ -858 +863 @@
                     /* Create all bandwidth groups for resource control. */
                     PCFGMNODE pCfgBwGrp = CFGMR3GetChild(pCfgNodeClass, "BwGroups");
-
                     if (pCfgBwGrp)
                     {
                         for (PCFGMNODE pCur = CFGMR3GetFirstChild(pCfgBwGrp); pCur; pCur = CFGMR3GetNextChild(pCur))
                         {
-                            uint32_t cbMax, cbStart, cbStep;
-                            size_t cchName = CFGMR3GetNameLen(pCur) + 1;
-                            char *pszBwGrpId = (char *)RTMemAllocZ(cchName);
-
-                            if (!pszBwGrpId)
+                            size_t cbName = CFGMR3GetNameLen(pCur) + 1;
+                            char *pszBwGrpId = (char *)RTMemAllocZ(cbName);
+                            if (pszBwGrpId)
                             {
+                                rc = CFGMR3GetName(pCur, pszBwGrpId, cbName);
+                                if (RT_SUCCESS(rc))
+                                {
+                                    uint32_t cbMax;
+                                    rc = CFGMR3QueryU32(pCur, "Max", &cbMax);
+                                    if (RT_SUCCESS(rc))
+                                    {
+                                        uint32_t cbStart;
+                                        rc = CFGMR3QueryU32Def(pCur, "Start", &cbStart, cbMax);
+                                        if (RT_SUCCESS(rc))
+                                        {
+                                            uint32_t cbStep;
+                                            rc = CFGMR3QueryU32Def(pCur, "Step", &cbStep, 0);
+                                            if (RT_SUCCESS(rc))
+                                                rc = pdmacAsyncCompletionBwMgrCreate(pEndpointClass, pszBwGrpId,
+                                                                                     cbMax, cbStart, cbStep);
+                                        }
+                                    }
+                                }
+                                RTMemFree(pszBwGrpId);
+                            }
+                            else
                                 rc = VERR_NO_MEMORY;
-                                break;
-                            }
-
-                            rc = CFGMR3GetName(pCur, pszBwGrpId, cchName);
-                            AssertRC(rc);
-
-                            if (RT_SUCCESS(rc))
-                                rc = CFGMR3QueryU32(pCur, "Max", &cbMax);
-                            if (RT_SUCCESS(rc))
-                                rc = CFGMR3QueryU32Def(pCur, "Start", &cbStart, cbMax);
-                            if (RT_SUCCESS(rc))
-                                rc = CFGMR3QueryU32Def(pCur, "Step", &cbStep, 0);
-                            if (RT_SUCCESS(rc))
-                                rc = pdmacAsyncCompletionBwMgrCreate(pEndpointClass, pszBwGrpId, cbMax, cbStart, cbStep);
-
-                            RTMemFree(pszBwGrpId);
-
                             if (RT_FAILURE(rc))
                                 break;
                         }
                     }
-
                     if (RT_SUCCESS(rc))
                     {
@@ -1507 +1513 @@
 
     PPDMASYNCCOMPLETIONEPCLASS pEndpointClass = pEndpoint->pEpClass;
-    PVM pVM = pEndpointClass->pVM;
-
     pEndpointClass->pEndpointOps->pfnEpClose(pEndpoint);
 

trunk/src/VBox/VMM/VMMR3/PDMUsb.cpp

@@ -529 +529 @@
         /** @todo r=bird: This code is bogus as it ASSUMES that all USB devices are
          *        capable of infinite number of instances. */
+        rc = VINF_SUCCESS; /* Shut up stupid incorrect uninitialized warning from Visual C++ 2010. */
         for (unsigned c = 0; c < _2M; c++)
         {
@@ -1616 +1617 @@
 
 /** @interface_method_impl{PDMUSBHLP,pfnDBGFInfoRegister} */
-static DECLCALLBACK(int) pdmR3UsbHlp_DBGFInfoRegister(PPDMUSBINS pUsbIns, const char *pszName, const char *pszDesc, PFNDBGFHANDLERUSB pfnHandler)
+static DECLCALLBACK(int) pdmR3UsbHlp_DBGFInfoRegister(PPDMUSBINS pUsbIns, const char *pszName, const char *pszDesc,
+                                                      PFNDBGFHANDLERUSB pfnHandler)
 {
     PDMUSB_ASSERT_USBINS(pUsbIns);
@@ -1624 +1626 @@
     PVM pVM = pUsbIns->Internal.s.pVM;
     VM_ASSERT_EMT(pVM);
-    NOREF(pVM); /** @todo int rc = DBGFR3InfoRegisterUsb(pVM, pszName, pszDesc, pfnHandler, pUsbIns); */
+    RT_NOREF4(pVM, pfnHandler, pszDesc, pszName); /** @todo int rc = DBGFR3InfoRegisterUsb(pVM, pszName, pszDesc, pfnHandler, pUsbIns); */
     int rc = VERR_NOT_IMPLEMENTED; AssertFailed();
 
@@ -1675 +1677 @@
     }
 
+    RT_NOREF5(cbItem, cItems, cMilliesInterval, pfnCallback, ppQueue);
     /** @todo int rc = PDMR3QueueCreateUsb(pVM, pUsbIns, cbItem, cItems, cMilliesInterval, pfnCallback, fGCEnabled, pszName, ppQueue); */
     int rc = VERR_NOT_IMPLEMENTED; AssertFailed();