Changeset 62663 in vbox for trunk

Timestamp:

Jul 28, 2016 11:01:05 PM (8 years ago)

Author:

vboxsync

Message:

RuntimeR0Drv: warnings

Location:

trunk/src/VBox/Runtime

Files:

• generic/memsafer-generic.cpp (modified) (1 diff)
• r0drv/alloc-ef-r0drv.cpp (modified) (1 diff)
• r0drv/generic/threadctxhooks-r0drv-generic.cpp (modified) (1 diff)
• r0drv/nt/memobj-r0drv-nt.cpp (modified) (8 diffs)
• r0drv/nt/mp-r0drv-nt.cpp (modified) (6 diffs)
• r0drv/nt/process-r0drv-nt.cpp (modified) (1 diff)
• r0drv/nt/semevent-r0drv-nt.cpp (modified) (2 diffs)
• r0drv/nt/semeventmulti-r0drv-nt.cpp (modified) (2 diffs)
• r0drv/nt/semmutex-r0drv-nt.cpp (modified) (5 diffs)
• r0drv/nt/spinlock-r0drv-nt.cpp (modified) (1 diff)
• r0drv/nt/thread-r0drv-nt.cpp (modified) (3 diffs)
• r0drv/nt/thread2-r0drv-nt.cpp (modified) (2 diffs)
• r0drv/nt/timer-r0drv-nt.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/generic/memsafer-generic.cpp

@@ -108 +108 @@
     *ppvNew = NULL;
     AssertReturn(cb, VERR_INVALID_PARAMETER);
+    RT_NOREF_PV(pszTag);
 
     /*

trunk/src/VBox/Runtime/r0drv/alloc-ef-r0drv.cpp

@@ -206 +206 @@
 static DECLCALLBACK(size_t) rtR0MemEfWrite(void *pvArg, const char *pachChars, size_t cbChars)
 {
+    RT_NOREF1(pvArg);
     if (cbChars)
     {

trunk/src/VBox/Runtime/r0drv/generic/threadctxhooks-r0drv-generic.cpp

@@ -36 +36 @@
 RTDECL(int) RTThreadCtxHookCreate(PRTTHREADCTXHOOK phCtxHook, uint32_t fFlags, PFNRTTHREADCTXHOOK pfnCallback, void *pvUser)
 {
-    NOREF(phCtxHook);
-    NOREF(pfnCallback);
-    NOREF(pvUser);
+    RT_NOREF4(phCtxHook, fFlags, pfnCallback, pvUser);
     return VERR_NOT_SUPPORTED;
 }

trunk/src/VBox/Runtime/r0drv/nt/memobj-r0drv-nt.cpp

@@ -248 +248 @@
 {
     AssertMsgReturn(cb <= _1G, ("%#x\n", cb), VERR_OUT_OF_RANGE); /* for safe size_t -> ULONG */
+    RT_NOREF1(fExecutable);
 
     /*
@@ -346 +347 @@
             __except(EXCEPTION_EXECUTE_HANDLER)
             {
+# ifdef LOG_ENABLED
                 NTSTATUS rcNt = GetExceptionCode();
                 Log(("rtR0MemObjNativeAllocLow: Exception Code %#x\n", rcNt));
+# endif
                 /* nothing */
             }
@@ -380 +383 @@
 {
     AssertMsgReturn(cb <= _1G, ("%#x\n", cb), VERR_OUT_OF_RANGE); /* for safe size_t -> ULONG */
+    RT_NOREF1(fExecutable);
 #ifdef IPRT_TARGET_NT4
     if (uAlignment != PAGE_SIZE)
@@ -690 +694 @@
      * MmCreateSection(SEC_RESERVE) + MmMapViewInSystemSpace perhaps?
      */
+    RT_NOREF4(ppMem, pvFixed, cb, uAlignment);
     return VERR_NOT_SUPPORTED;
 }
@@ -700 +705 @@
      * ZeCreateSection(SEC_RESERVE) + ZwMapViewOfSection perhaps?
      */
+    RT_NOREF5(ppMem, R3PtrFixed, cb, uAlignment, R0Process);
     return VERR_NOT_SUPPORTED;
 }
@@ -788 +794 @@
         __except(EXCEPTION_EXECUTE_HANDLER)
         {
+#ifdef LOG_ENABLED
             NTSTATUS rcNt = GetExceptionCode();
             Log(("rtR0MemObjNtMap: Exception Code %#x\n", rcNt));
+#endif
 
             /* nothing */
@@ -849 +857 @@
 DECLHIDDEN(int) rtR0MemObjNativeProtect(PRTR0MEMOBJINTERNAL pMem, size_t offSub, size_t cbSub, uint32_t fProt)
 {
+#if 0
     PRTR0MEMOBJNT pMemNt = (PRTR0MEMOBJNT)pMem;
+#endif
     if (!g_fResolvedDynamicApis)
         rtR0MemObjNtResolveDynamicApis();
@@ -967 +977 @@
         return RTErrConvertFromNtStatus(rcNt);
     }
+#else
+    RT_NOREF4(pMem, offSub, cbSub, fProt);
 #endif
 

trunk/src/VBox/Runtime/r0drv/nt/mp-r0drv-nt.cpp

@@ -345 +345 @@
 {
     PRTMPARGS pArgs = (PRTMPARGS)DeferredContext;
+    RT_NOREF3(Dpc, SystemArgument1, SystemArgument2);
 
     ASMAtomicIncU32(&pArgs->cHits);
@@ -453 +454 @@
     {
         ASMAtomicIncS32(&pArgs->cRefs);
-        BOOLEAN ret = KeInsertQueueDpc(&paExecCpuDpcs[0], 0, 0);
-        Assert(ret);
+        BOOLEAN fRc = KeInsertQueueDpc(&paExecCpuDpcs[0], 0, 0);
+        Assert(fRc); NOREF(fRc);
     }
     else if (enmCpuid == RT_NT_CPUID_PAIR)
     {
         ASMAtomicIncS32(&pArgs->cRefs);
-        BOOLEAN ret = KeInsertQueueDpc(&paExecCpuDpcs[0], 0, 0);
-        Assert(ret);
+        BOOLEAN fRc = KeInsertQueueDpc(&paExecCpuDpcs[0], 0, 0);
+        Assert(fRc); NOREF(fRc);
 
         ASMAtomicIncS32(&pArgs->cRefs);
-        ret = KeInsertQueueDpc(&paExecCpuDpcs[1], 0, 0);
-        Assert(ret);
+        fRc = KeInsertQueueDpc(&paExecCpuDpcs[1], 0, 0);
+        Assert(fRc); NOREF(fRc);
     }
     else
@@ -476 +477 @@
             {
                 ASMAtomicIncS32(&pArgs->cRefs);
-                BOOLEAN ret = KeInsertQueueDpc(&paExecCpuDpcs[i], 0, 0);
-                Assert(ret);
+                BOOLEAN fRc = KeInsertQueueDpc(&paExecCpuDpcs[i], 0, 0);
+                Assert(fRc); NOREF(fRc);
             }
         }
@@ -605 +606 @@
 {
     PRTMPNTONSPECIFICARGS pArgs = (PRTMPNTONSPECIFICARGS)DeferredContext;
+    RT_NOREF3(Dpc, SystemArgument1, SystemArgument2);
+
     ASMAtomicWriteBool(&pArgs->fExecuting, true);
 
@@ -702 +705 @@
     {
         BOOLEAN fRc = KeInsertQueueDpc(&pArgs->Dpc, 0, 0);
-        Assert(fRc);
+        Assert(fRc); NOREF(fRc);
         KeLowerIrql(bOldIrql);
 
@@ -813 +816 @@
 int rtMpPokeCpuUsingBroadcastIpi(RTCPUID idCpu)
 {
+    NOREF(idCpu);
     g_pfnrtKeIpiGenericCall(rtMpIpiGenericCall, 0);
     return VINF_SUCCESS;

trunk/src/VBox/Runtime/r0drv/nt/process-r0drv-nt.cpp

@@ -35 +35 @@
 RTDECL(RTPROCESS) RTProcSelf(void)
 {
-    return (RTPROCESS)PsGetCurrentProcessId();
+    return (RTPROCESS)(uintptr_t)PsGetCurrentProcessId();
 }
 

trunk/src/VBox/Runtime/r0drv/nt/semevent-r0drv-nt.cpp

@@ -72 +72 @@
     Assert(!(fFlags & RTSEMEVENT_FLAGS_BOOTSTRAP_HACK) || (fFlags & RTSEMEVENT_FLAGS_NO_LOCK_VAL));
     AssertCompile(sizeof(RTSEMEVENTINTERNAL) > sizeof(void *));
+    RT_NOREF2(hClass, pszNameFmt);
 
     PRTSEMEVENTINTERNAL pThis = (PRTSEMEVENTINTERNAL)RTMemAlloc(sizeof(*pThis));
@@ -173 +174 @@
     AssertMsgReturn(pThis->u32Magic == RTSEMEVENT_MAGIC, ("%p u32Magic=%RX32\n", pThis, pThis->u32Magic), VERR_INVALID_PARAMETER);
     AssertReturn(RTSEMWAIT_FLAGS_ARE_VALID(fFlags), VERR_INVALID_PARAMETER);
+    NOREF(pSrcPos);
 
     rtR0SemEventNtRetain(pThis);

trunk/src/VBox/Runtime/r0drv/nt/semeventmulti-r0drv-nt.cpp

@@ -71 +71 @@
 {
     AssertReturn(!(fFlags & ~RTSEMEVENTMULTI_FLAGS_NO_LOCK_VAL), VERR_INVALID_PARAMETER);
+    RT_NOREF2(hClass, pszNameFmt);
 
     AssertCompile(sizeof(RTSEMEVENTMULTIINTERNAL) > sizeof(void *));
@@ -196 +197 @@
     AssertMsgReturn(pThis->u32Magic == RTSEMEVENTMULTI_MAGIC, ("%p u32Magic=%RX32\n", pThis, pThis->u32Magic), VERR_INVALID_PARAMETER);
     AssertReturn(RTSEMWAIT_FLAGS_ARE_VALID(fFlags), VERR_INVALID_PARAMETER);
+    RT_NOREF1(pSrcPos);
 
     rtR0SemEventMultiNtRetain(pThis);

trunk/src/VBox/Runtime/r0drv/nt/semmutex-r0drv-nt.cpp

@@ -72 +72 @@
 {
     AssertReturn(!(fFlags & ~RTSEMMUTEX_FLAGS_NO_LOCK_VAL), VERR_INVALID_PARAMETER);
+    RT_NOREF3(hClass, uSubClass, pszNameFmt);
 
     AssertCompile(sizeof(RTSEMMUTEXINTERNAL) > sizeof(void *));
@@ -135 +136 @@
     AssertMsg(cMillies == RT_INDEFINITE_WAIT, ("timeouts are not supported when using fast mutexes!\n"));
     ExAcquireFastMutex(&pThis->Mutex);
+    return VINF_SUCCESS;
+
 #else  /* !RT_USE_FAST_MUTEX */
     NTSTATUS rcNt;
@@ -166 +169 @@
     }
 #endif /* !RT_USE_FAST_MUTEX */
-    return VINF_SUCCESS;
 }
 
@@ -178 +180 @@
 RTDECL(int) RTSemMutexRequestDebug(RTSEMMUTEX hMutexSem, RTMSINTERVAL cMillies, RTHCUINTPTR uId, RT_SRC_POS_DECL)
 {
+    RT_NOREF1(uId); RT_SRC_POS_NOREF();
     return RTSemMutexRequest(hMutexSem, cMillies);
 }
@@ -190 +193 @@
 RTDECL(int) RTSemMutexRequestNoResumeDebug(RTSEMMUTEX hMutexSem, RTMSINTERVAL cMillies, RTHCUINTPTR uId, RT_SRC_POS_DECL)
 {
+    RT_NOREF1(uId); RT_SRC_POS_NOREF();
     return RTSemMutexRequestNoResume(hMutexSem, cMillies);
 }

trunk/src/VBox/Runtime/r0drv/nt/spinlock-r0drv-nt.cpp

@@ -86 +86 @@
 {
     AssertReturn(fFlags == RTSPINLOCK_FLAGS_INTERRUPT_SAFE || fFlags == RTSPINLOCK_FLAGS_INTERRUPT_UNSAFE, VERR_INVALID_PARAMETER);
+    RT_NOREF1(pszName);
 
     /*

trunk/src/VBox/Runtime/r0drv/nt/thread-r0drv-nt.cpp

@@ -85 +85 @@
 RTDECL(bool) RTThreadPreemptIsEnabled(RTTHREAD hThread)
 {
-    Assert(hThread == NIL_RTTHREAD);
+    Assert(hThread == NIL_RTTHREAD); RT_NOREF1(hThread);
     KIRQL Irql = KeGetCurrentIrql();
     if (Irql > APC_LEVEL)
@@ -97 +97 @@
 RTDECL(bool) RTThreadPreemptIsPending(RTTHREAD hThread)
 {
-    Assert(hThread == NIL_RTTHREAD);
+    Assert(hThread == NIL_RTTHREAD); RT_NOREF1(hThread);
 
     /*
@@ -140 +140 @@
         fPending = *pu32QuantumEnd != 0;
     }
+    else
+        fPending = false;
 
     /* Check DpcQueueDepth. */

trunk/src/VBox/Runtime/r0drv/nt/thread2-r0drv-nt.cpp

@@ -85 +85 @@
 DECLHIDDEN(int) rtThreadNativeAdopt(PRTTHREADINT pThread)
 {
+    RT_NOREF1(pThread);
     return VERR_NOT_IMPLEMENTED;
 }
@@ -93 +94 @@
     PVOID pvThreadObj = pThread->Core.Key;
     NTSTATUS rcNt = KeWaitForSingleObject(pvThreadObj, Executive, KernelMode, FALSE, NULL);
-    AssertMsg(rcNt == STATUS_SUCCESS, ("rcNt=%#x\n", rcNt));
+    AssertMsg(rcNt == STATUS_SUCCESS, ("rcNt=%#x\n", rcNt)); RT_NOREF1(rcNt);
 }
 

trunk/src/VBox/Runtime/r0drv/nt/timer-r0drv-nt.cpp

@@ -151 +151 @@
 #ifdef RTR0TIMER_NT_MANUAL_RE_ARM
     Assert(pTimer->u64NanoInterval);
+    RT_NOREF1(pMasterDpc);
 
     uint64_t uNtNext = (iTick * pTimer->u64NanoInterval) / 100 - 10; /* 1us fudge */
@@ -163 +164 @@
 
     KeSetTimerEx(&pTimer->NtTimer, DueTime, 0, &pTimer->aSubTimers[0].NtDpc);
+#else
+    RT_NOREF3(pTimer, iTick, pMasterDpc);
 #endif
 }
@@ -426 +429 @@
     AssertPtrReturn(pTimer, VERR_INVALID_HANDLE);
     AssertReturn(pTimer->u32Magic == RTTIMER_MAGIC, VERR_INVALID_HANDLE);
+    RT_NOREF1(u64NanoInterval);
 
     return VERR_NOT_SUPPORTED;