Changeset 62673 in vbox for trunk/src/VBox/ValidationKit/utils/cpu

Timestamp:

Jul 29, 2016 11:04:35 AM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109246

Message:

ValidationKit/utils: warnings.

Location:

trunk/src/VBox/ValidationKit/utils/cpu

Files:

• cidet-app.cpp (modified) (5 diffs)
• cidet-core.cpp (modified) (9 diffs)

trunk/src/VBox/ValidationKit/utils/cpu/cidet-app.cpp

@@ -43 +43 @@
 
 #ifdef RT_OS_WINDOWS
-# include <Windows.h>
+# include <iprt/win/windows.h>
 #else
 # define USE_SIGNALS
@@ -566 +566 @@
                                                  uint32_t fFlags)
 {
+    RT_NOREF_PV(pThis);
     static uint8_t const s_afBufProtToDefaultMemProt[] =
     {
@@ -673 +674 @@
 static bool CidetAppArmBuf(PCIDETAPP pThis, PCIDETAPPBUF pAppBuf)
 {
+    RT_NOREF_PV(pThis);
     uint8_t *pbUsingBuf = (pAppBuf->fUsingNormal ? pAppBuf->pbNormal : pAppBuf->pbLow);
     if (pAppBuf->fLastPageProt == pAppBuf->fDefaultProt)
@@ -693 +695 @@
 static bool CidetAppDearmBuf(PCIDETAPP pThis, PCIDETAPPBUF pAppBuf)
 {
+    RT_NOREF_PV(pThis);
     uint8_t *pbUsingBuf = (pAppBuf->fUsingNormal ? pAppBuf->pbNormal : pAppBuf->pbLow);
     int rc = RTMemProtect(pbUsingBuf, pAppBuf->cb, pAppBuf->fDefaultProt | RTMEM_PROT_READ | RTMEM_PROT_WRITE);
@@ -1106 +1109 @@
 static DECLCALLBACK(void) CidetAppCbFailureV(PCIDETCORE pThis, const char *pszMsg, va_list va)
 {
+    RT_NOREF_PV(pThis);
     RTTestIFailedV(pszMsg, va);
 }

trunk/src/VBox/ValidationKit/utils/cpu/cidet-core.cpp

@@ -319 +319 @@
 bool CidetCoreIsEncodingCompatibleWithInstruction(PCIDETCORE pThis)
 {
+    RT_NOREF_PV(pThis);
     return true;
 }
@@ -727 +728 @@
 static void cidetCoreSetupFirstBaseEncoding_MrmRmMod_32bit64bit(PCIDETCORE pThis, uint8_t iReg, bool f64Bit)
 {
+    RT_NOREF_PV(f64Bit);
     if (CidetInstrHasMrmRegOperand(pThis->pCurInstr))
     {
@@ -1072 +1074 @@
 static bool cidetCoreSetupNextBaseEncoding_SibScale(PCIDETCORE pThis, uint8_t iReg)
 {
+    RT_NOREF_PV(iReg);
     switch ((pThis->bSib >> X86_SIB_SCALE_SHIFT) & X86_SIB_SCALE_SMASK)
     {
@@ -1320 +1323 @@
 bool CidetCoreSetupNextMemoryOperandConfig(PCIDETCORE pThis)
 {
+    RT_NOREF_PV(pThis);
     return false;
 }
@@ -1372 +1376 @@
 bool CidetCoreSetupNextCodeBufferConfig(PCIDETCORE pThis)
 {
+    RT_NOREF_PV(pThis);
     return false;
 }
@@ -1911 +1916 @@
      * The opcode.
      */
-    uint8_t const *pbOpcode = pThis->pCurInstr->abOpcode;
+    //uint8_t const *pbOpcode = pThis->pCurInstr->abOpcode;
     switch (pThis->pCurInstr->cbOpcode)
     {
@@ -1932 +1937 @@
         if (pThis->idxMrmRmOp < RT_ELEMENTS(pThis->aOperands))
         {
-            uint64_t uDispValue = pThis->aOperands[pThis->idxMrmRmOp].uImmDispValue;
+            //uint64_t uDispValue = pThis->aOperands[pThis->idxMrmRmOp].uImmDispValue;
             switch (pThis->aOperands[pThis->idxMrmRmOp].cbMemDisp)
             {
@@ -1958 +1963 @@
         if ((pThis->aOperands[iOp].fFlags & CIDET_OF_K_MASK) == CIDET_OF_K_IMM)
         {
-            uint64_t uImmValue = pThis->aOperands[iOp].uImmDispValue;
+            //uint64_t uImmValue = pThis->aOperands[iOp].uImmDispValue;
             switch (pThis->aOperands[iOp].cb)
             {
@@ -2166 +2171 @@
         CIDET_DPRINTF(("%04u: %s", iSubTest, szInstr));
         Assert(cbInstr == pThis->cbInstr);
+#else
+        RT_NOREF_PV(iSubTest);
 #endif
         if (pThis->pfnSetupCodeBuf(pThis, &pThis->CodeBuf, pThis->abInstr))