Changeset 62704 in vbox

Timestamp:

Jul 29, 2016 8:12:40 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109278

Message:

CodingGuidelines: do-while-false-goto-avoidance-loops are now officially frowned upon.

File:

• trunk/doc/VBox-CodingGuidelines.cpp (modified) (1 diff)

trunk/doc/VBox-CodingGuidelines.cpp

@@ -461 +461 @@
  *      - That Dijkstra is dead is no excuse for using gotos.
  *
+ *      - Using do-while-false loops to avoid gotos is considered very bad form.
+ *        They create hard to read code.  They tend to be either too short (i.e.
+ *        pointless) or way to long (split up the function already), making
+ *        tracking the state is difficult and prone to bugs.  Also, they cause
+ *        the compiler to generate suboptimal code, because the break branches
+ *        are by preferred over the main code flow (MSC has no branch hinting!).
+ *        Instead, do make use the 130 columns (i.e. nested ifs) and split
+ *        the code up into more functions!
  *
  *